[INFO] fetching crate elastic-parser 0.1.15... [INFO] linting elastic-parser-0.1.15 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate elastic-parser 0.1.15 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate elastic-parser 0.1.15 [INFO] finished tweaking crates.io crate elastic-parser 0.1.15 [INFO] tweaked toml for crates.io crate elastic-parser 0.1.15 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate elastic-parser 0.1.15 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2331e13471f52960e595b27ec77d574fc8398a3ee5f9f30543852fa4de6e5f1 [INFO] running `Command { std: "docker" "start" "-a" "a2331e13471f52960e595b27ec77d574fc8398a3ee5f9f30543852fa4de6e5f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2331e13471f52960e595b27ec77d574fc8398a3ee5f9f30543852fa4de6e5f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2331e13471f52960e595b27ec77d574fc8398a3ee5f9f30543852fa4de6e5f1", kill_on_drop: false }` [INFO] [stdout] a2331e13471f52960e595b27ec77d574fc8398a3ee5f9f30543852fa4de6e5f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c5c842f44f6440c187f52927d106e5d10b98a6ae5bc7e96753acc6728d47016 [INFO] running `Command { std: "docker" "start" "-a" "2c5c842f44f6440c187f52927d106e5d10b98a6ae5bc7e96753acc6728d47016", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking elastic-parser v0.1.15 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return Some(hits.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Some(hits.unwrap()); [INFO] [stdout] 56 + Some(hits.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `key_as_string` after checking its variant with `is_some` [INFO] [stdout] --> src/aggregation/mod.rs:61:33 [INFO] [stdout] | [INFO] [stdout] 60 | if key_as_string.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = key_as_string` [INFO] [stdout] 61 | let key_as_string = key_as_string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `key` after checking its variant with `is_some` [INFO] [stdout] --> src/aggregation/mod.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 67 | if key.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = key` [INFO] [stdout] 68 | let key = key.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return None; [INFO] [stdout] 76 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/aggregation/mod.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | if !key.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return None; [INFO] [stdout] 97 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return None; [INFO] [stdout] 117 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/aggregation/mod.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / if value.is_none() { [INFO] [stdout] 111 | | return None; [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____^ help: replace it with: `value?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `hit._source` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 44 | if hit._source.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &hit._source` [INFO] [stdout] 45 | data.push(hit._source.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lib.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | / if self.aggregations.is_none() { [INFO] [stdout] 67 | | return None; [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.aggregations.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return Some(hits.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Some(hits.unwrap()); [INFO] [stdout] 56 + Some(hits.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `key_as_string` after checking its variant with `is_some` [INFO] [stdout] --> src/aggregation/mod.rs:61:33 [INFO] [stdout] | [INFO] [stdout] 60 | if key_as_string.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = key_as_string` [INFO] [stdout] 61 | let key_as_string = key_as_string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `key` after checking its variant with `is_some` [INFO] [stdout] --> src/aggregation/mod.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 67 | if key.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = key` [INFO] [stdout] 68 | let key = key.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return None; [INFO] [stdout] 76 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/aggregation/mod.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | if !key.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return None; [INFO] [stdout] 97 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregation/mod.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return None; [INFO] [stdout] 117 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/aggregation/mod.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / if value.is_none() { [INFO] [stdout] 111 | | return None; [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____^ help: replace it with: `value?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `hit._source` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 44 | if hit._source.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &hit._source` [INFO] [stdout] 45 | data.push(hit._source.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lib.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | / if self.aggregations.is_none() { [INFO] [stdout] 67 | | return None; [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.aggregations.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.18s [INFO] running `Command { std: "docker" "inspect" "2c5c842f44f6440c187f52927d106e5d10b98a6ae5bc7e96753acc6728d47016", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c5c842f44f6440c187f52927d106e5d10b98a6ae5bc7e96753acc6728d47016", kill_on_drop: false }` [INFO] [stdout] 2c5c842f44f6440c187f52927d106e5d10b98a6ae5bc7e96753acc6728d47016