[INFO] fetching crate egui_inspect_derive 0.1.3... [INFO] linting egui_inspect_derive-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate egui_inspect_derive 0.1.3 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate egui_inspect_derive 0.1.3 [INFO] finished tweaking crates.io crate egui_inspect_derive 0.1.3 [INFO] tweaked toml for crates.io crate egui_inspect_derive 0.1.3 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate egui_inspect_derive 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding darling v0.13.4 (available: v0.23.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e81105411e029a3cfe408c7f7b2a2fc5b4c87b3c3ac1849d3ccfbafdd521a4c [INFO] running `Command { std: "docker" "start" "-a" "7e81105411e029a3cfe408c7f7b2a2fc5b4c87b3c3ac1849d3ccfbafdd521a4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e81105411e029a3cfe408c7f7b2a2fc5b4c87b3c3ac1849d3ccfbafdd521a4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e81105411e029a3cfe408c7f7b2a2fc5b4c87b3c3ac1849d3ccfbafdd521a4c", kill_on_drop: false }` [INFO] [stdout] 7e81105411e029a3cfe408c7f7b2a2fc5b4c87b3c3ac1849d3ccfbafdd521a4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30a257f88683180652ab8aebe40354708f7d2c0cf4fdbf2bd654f3dd499440e9 [INFO] running `Command { std: "docker" "start" "-a" "30a257f88683180652ab8aebe40354708f7d2c0cf4fdbf2bd654f3dd499440e9", kill_on_drop: false }` [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking darling v0.13.4 [INFO] [stderr] Checking egui_inspect_derive v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/lib.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | for (i,f) in fields.unnamed.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `struct_name_string` [INFO] [stdout] --> src/lib.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | let struct_name_string = struct_name.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_struct_name_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal_paths.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / return path_str == "f32" [INFO] [stdout] 10 | | || path_str == "f64" [INFO] [stdout] 11 | | || path_str == "u8" [INFO] [stdout] 12 | | || path_str == "i8" [INFO] [stdout] ... | [INFO] [stdout] 22 | | || path_str == "String" [INFO] [stdout] 23 | | || path_str == "str"; [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ path_str == "f32" [INFO] [stdout] 10 + || path_str == "f64" [INFO] [stdout] 11 + || path_str == "u8" [INFO] [stdout] 12 + || path_str == "i8" [INFO] [stdout] 13 + || path_str == "u16" [INFO] [stdout] 14 + || path_str == "i16" [INFO] [stdout] 15 + || path_str == "u32" [INFO] [stdout] 16 + || path_str == "i32" [INFO] [stdout] 17 + || path_str == "u64" [INFO] [stdout] 18 + || path_str == "i64" [INFO] [stdout] 19 + || path_str == "usize" [INFO] [stdout] 20 + || path_str == "isize" [INFO] [stdout] 21 + || path_str == "bool" [INFO] [stdout] 22 + || path_str == "String" [INFO] [stdout] 23 ~ || path_str == "str" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/internal_paths.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / if path_str.is_none() { [INFO] [stdout] 34 | | return None; [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ help: replace it with: `path_str.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:44:32 [INFO] [stdout] | [INFO] [stdout] 44 | handle_number_path(&field, mutable, &attrs) [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:44:49 [INFO] [stdout] | [INFO] [stdout] 44 | handle_number_path(&field, mutable, &attrs) [INFO] [stdout] | ^^^^^^ help: change this to: `attrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | "String" => handle_string_path(&field, mutable, &attrs), [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:46:57 [INFO] [stdout] | [INFO] [stdout] 46 | "String" => handle_string_path(&field, mutable, &attrs), [INFO] [stdout] | ^^^^^^ help: change this to: `attrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal_paths.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return None; [INFO] [stdout] 77 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal_paths.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return None; [INFO] [stdout] 104 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return None; [INFO] [stdout] 16 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/utils.rs:18:45 [INFO] [stdout] | [INFO] [stdout] 18 | Reference(type_ref) => get_path_str(&*type_ref.elem), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&type_ref.elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return if mutable { [INFO] [stdout] 28 | | quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect_mut(&mut self.#name, &#name_str, ui);}} [INFO] [stdout] 29 | | } else { [INFO] [stdout] 30 | | quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect(&self.#name, &#name_str, ui);}} [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ if mutable { [INFO] [stdout] 28 + quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect_mut(&mut self.#name, &#name_str, ui);}} [INFO] [stdout] 29 + } else { [INFO] [stdout] 30 + quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect(&self.#name, &#name_str, ui);}} [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | return utils::get_default_function_call(&f, mutable); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return utils::get_default_function_call(&f, mutable); [INFO] [stdout] 136 + utils::get_default_function_call(&f, mutable) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:128:46 [INFO] [stdout] | [INFO] [stdout] 128 | if let Some(ts) = handle_custom_func(&f, mutable, &attr) { [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:132:68 [INFO] [stdout] | [INFO] [stdout] 132 | if let Some(ts) = internal_paths::try_handle_internal_path(&f, mutable, &attr) { [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:136:49 [INFO] [stdout] | [INFO] [stdout] 136 | return utils::get_default_function_call(&f, mutable); [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if !(attrs.custom_func.is_none() || mutable && !attrs.no_edit) { [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if (attrs.no_edit || !mutable) && attrs.custom_func.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if !(mutable && !attrs.no_edit) && attrs.custom_func.is_some() { [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if !mutable || attrs.no_edit && attrs.custom_func.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `attrs.custom_func_mut` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 148 | if mutable && !attrs.no_edit && attrs.custom_func_mut.is_some() { [INFO] [stdout] | ------------------------------- the check is happening here [INFO] [stdout] 149 | let custom_func_mut = attrs.custom_func_mut.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `attrs.custom_func` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:159:27 [INFO] [stdout] | [INFO] [stdout] 158 | if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 159 | let custom_func = attrs.custom_func.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return None; [INFO] [stdout] 168 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:151:14 [INFO] [stdout] | [INFO] [stdout] 151 | .expect(format!("Could not find function: {}", custom_func_mut).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not find function: {}", custom_func_mut))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:161:14 [INFO] [stdout] | [INFO] [stdout] 161 | .expect(format!("Could not find function: {}", custom_func).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not find function: {}", custom_func))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/lib.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | for (i,f) in fields.unnamed.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `struct_name_string` [INFO] [stdout] --> src/lib.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | let struct_name_string = struct_name.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_struct_name_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal_paths.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / return path_str == "f32" [INFO] [stdout] 10 | | || path_str == "f64" [INFO] [stdout] 11 | | || path_str == "u8" [INFO] [stdout] 12 | | || path_str == "i8" [INFO] [stdout] ... | [INFO] [stdout] 22 | | || path_str == "String" [INFO] [stdout] 23 | | || path_str == "str"; [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ path_str == "f32" [INFO] [stdout] 10 + || path_str == "f64" [INFO] [stdout] 11 + || path_str == "u8" [INFO] [stdout] 12 + || path_str == "i8" [INFO] [stdout] 13 + || path_str == "u16" [INFO] [stdout] 14 + || path_str == "i16" [INFO] [stdout] 15 + || path_str == "u32" [INFO] [stdout] 16 + || path_str == "i32" [INFO] [stdout] 17 + || path_str == "u64" [INFO] [stdout] 18 + || path_str == "i64" [INFO] [stdout] 19 + || path_str == "usize" [INFO] [stdout] 20 + || path_str == "isize" [INFO] [stdout] 21 + || path_str == "bool" [INFO] [stdout] 22 + || path_str == "String" [INFO] [stdout] 23 ~ || path_str == "str" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/internal_paths.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / if path_str.is_none() { [INFO] [stdout] 34 | | return None; [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ help: replace it with: `path_str.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:44:32 [INFO] [stdout] | [INFO] [stdout] 44 | handle_number_path(&field, mutable, &attrs) [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:44:49 [INFO] [stdout] | [INFO] [stdout] 44 | handle_number_path(&field, mutable, &attrs) [INFO] [stdout] | ^^^^^^ help: change this to: `attrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | "String" => handle_string_path(&field, mutable, &attrs), [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/internal_paths.rs:46:57 [INFO] [stdout] | [INFO] [stdout] 46 | "String" => handle_string_path(&field, mutable, &attrs), [INFO] [stdout] | ^^^^^^ help: change this to: `attrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal_paths.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return None; [INFO] [stdout] 77 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal_paths.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return None; [INFO] [stdout] 104 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return None; [INFO] [stdout] 16 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/utils.rs:18:45 [INFO] [stdout] | [INFO] [stdout] 18 | Reference(type_ref) => get_path_str(&*type_ref.elem), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&type_ref.elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return if mutable { [INFO] [stdout] 28 | | quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect_mut(&mut self.#name, &#name_str, ui);}} [INFO] [stdout] 29 | | } else { [INFO] [stdout] 30 | | quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect(&self.#name, &#name_str, ui);}} [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ if mutable { [INFO] [stdout] 28 + quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect_mut(&mut self.#name, &#name_str, ui);}} [INFO] [stdout] 29 + } else { [INFO] [stdout] 30 + quote_spanned! {field.span() => {egui_inspect::EguiInspect::inspect(&self.#name, &#name_str, ui);}} [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | return utils::get_default_function_call(&f, mutable); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return utils::get_default_function_call(&f, mutable); [INFO] [stdout] 136 + utils::get_default_function_call(&f, mutable) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:128:46 [INFO] [stdout] | [INFO] [stdout] 128 | if let Some(ts) = handle_custom_func(&f, mutable, &attr) { [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:132:68 [INFO] [stdout] | [INFO] [stdout] 132 | if let Some(ts) = internal_paths::try_handle_internal_path(&f, mutable, &attr) { [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:136:49 [INFO] [stdout] | [INFO] [stdout] 136 | return utils::get_default_function_call(&f, mutable); [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if !(attrs.custom_func.is_none() || mutable && !attrs.no_edit) { [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if (attrs.no_edit || !mutable) && attrs.custom_func.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if !(mutable && !attrs.no_edit) && attrs.custom_func.is_some() { [INFO] [stdout] | [INFO] [stdout] 158 - if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] 158 + if !mutable || attrs.no_edit && attrs.custom_func.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `attrs.custom_func_mut` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 148 | if mutable && !attrs.no_edit && attrs.custom_func_mut.is_some() { [INFO] [stdout] | ------------------------------- the check is happening here [INFO] [stdout] 149 | let custom_func_mut = attrs.custom_func_mut.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `attrs.custom_func` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:159:27 [INFO] [stdout] | [INFO] [stdout] 158 | if (!mutable || (mutable && attrs.no_edit)) && attrs.custom_func.is_some() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 159 | let custom_func = attrs.custom_func.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return None; [INFO] [stdout] 168 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:151:14 [INFO] [stdout] | [INFO] [stdout] 151 | .expect(format!("Could not find function: {}", custom_func_mut).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not find function: {}", custom_func_mut))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:161:14 [INFO] [stdout] | [INFO] [stdout] 161 | .expect(format!("Could not find function: {}", custom_func).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not find function: {}", custom_func))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.95s [INFO] running `Command { std: "docker" "inspect" "30a257f88683180652ab8aebe40354708f7d2c0cf4fdbf2bd654f3dd499440e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30a257f88683180652ab8aebe40354708f7d2c0cf4fdbf2bd654f3dd499440e9", kill_on_drop: false }` [INFO] [stdout] 30a257f88683180652ab8aebe40354708f7d2c0cf4fdbf2bd654f3dd499440e9