[INFO] fetching crate egnite 0.1.6... [INFO] linting egnite-0.1.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate egnite 0.1.6 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate egnite 0.1.6 [INFO] finished tweaking crates.io crate egnite 0.1.6 [INFO] tweaked toml for crates.io crate egnite 0.1.6 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate egnite 0.1.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate egnite 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pbkdf2 v0.10.1 [INFO] [stderr] Downloaded zstd-safe v4.1.6+zstd.1.5.2 [INFO] [stderr] Downloaded time-macros v0.2.4 [INFO] [stderr] Downloaded sha1 v0.10.5 [INFO] [stderr] Downloaded zip v0.6.2 [INFO] [stderr] Downloaded iana-time-zone v0.1.46 [INFO] [stderr] Downloaded console v0.15.1 [INFO] [stderr] Downloaded indicatif v0.17.1 [INFO] [stderr] Downloaded serde_derive v1.0.143 [INFO] [stderr] Downloaded password-hash v0.3.2 [INFO] [stderr] Downloaded miniz_oxide v0.5.4 [INFO] [stderr] Downloaded time v0.3.14 [INFO] [stderr] Downloaded reqwest v0.11.11 [INFO] [stderr] Downloaded serde v1.0.143 [INFO] [stderr] Downloaded serde_json v1.0.83 [INFO] [stderr] Downloaded pickledb v0.5.1 [INFO] [stderr] Downloaded prettytable-rs v0.9.0 [INFO] [stderr] Downloaded thiserror v1.0.32 [INFO] [stderr] Downloaded rpassword v7.0.0 [INFO] [stderr] Downloaded base64ct v1.0.1 [INFO] [stderr] Downloaded chrono v0.4.22 [INFO] [stderr] Downloaded digest v0.10.5 [INFO] [stderr] Downloaded zstd v0.10.2+zstd.1.5.2 [INFO] [stderr] Downloaded pathdiff v0.2.1 [INFO] [stderr] Downloaded open v3.0.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.32 [INFO] [stderr] Downloaded tokio v1.21.1 [INFO] [stderr] Downloaded zstd-sys v1.6.3+zstd.1.5.2 [INFO] [stderr] Downloaded web-sys v0.3.59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bad6c2a5759f931cabf1f11ffe33bfde38c69e6acb245c8a0be52318552f5754 [INFO] running `Command { std: "docker" "start" "-a" "bad6c2a5759f931cabf1f11ffe33bfde38c69e6acb245c8a0be52318552f5754", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bad6c2a5759f931cabf1f11ffe33bfde38c69e6acb245c8a0be52318552f5754", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bad6c2a5759f931cabf1f11ffe33bfde38c69e6acb245c8a0be52318552f5754", kill_on_drop: false }` [INFO] [stdout] bad6c2a5759f931cabf1f11ffe33bfde38c69e6acb245c8a0be52318552f5754 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 40716935b162ed2db1ee12cc421cb18d6a46c9706dd2f02d62447228685971c9 [INFO] running `Command { std: "docker" "start" "-a" "40716935b162ed2db1ee12cc421cb18d6a46c9706dd2f02d62447228685971c9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling serde_derive v1.0.143 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde v1.0.143 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Compiling tokio v1.21.1 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling zstd-safe v4.1.6+zstd.1.5.2 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking digest v0.10.5 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking base64ct v1.0.1 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking sha2 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking password-hash v0.3.2 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Compiling semver v1.0.14 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking pbkdf2 v0.10.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking iana-time-zone v0.1.46 [INFO] [stderr] Checking unicode-segmentation v1.10.0 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling zstd-sys v1.6.3+zstd.1.5.2 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking indicatif v0.17.1 [INFO] [stderr] Checking open v3.0.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking rpassword v7.0.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking time v0.3.14 [INFO] [stderr] Checking bzip2 v0.4.3 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling clap_derive v3.2.15 [INFO] [stderr] Checking clap v3.2.16 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v1.1.2 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking h2 v0.3.14 [INFO] [stderr] Checking pickledb v0.5.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking prettytable-rs v0.9.0 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.11 [INFO] [stderr] Checking zstd v0.10.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.2 [INFO] [stderr] Checking egnite v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `ServerErrorResponse` is never constructed [INFO] [stdout] --> src/extras/response.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct ServerErrorResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/project/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Project { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 9 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/authn/mod.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | if err.error == "authorization_pending".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"authorization_pending"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:129:33 [INFO] [stdout] | [INFO] [stdout] 129 | ... println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/function/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/function/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/function/mod.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 98 | if !(path.file_name() == Path::new("./temp/function.zip").file_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(path.file_name() != Path::new("./temp/function.zip").file_name())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/function/mod.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | && !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(name.components().nth(0) != Some(Component::Normal(OsStr::new("target"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/function/mod.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | if !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(name.components().nth(0) != Some(Component::Normal(OsStr::new("target"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/function/mod.rs:82:33 [INFO] [stdout] | [INFO] [stdout] 82 | let file = File::create(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/function/mod.rs:106:35 [INFO] [stdout] | [INFO] [stdout] 106 | zip.write_all(&*buffer)?; [INFO] [stdout] | ^^^^^^^^ help: try: `&buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/function/mod.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | } else if !name.as_os_str().is_empty() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 110 | | if !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) { [INFO] [stdout] 111 | | #[allow(deprecated)] [INFO] [stdout] 112 | | zip.add_directory_from_path(name, options)?; [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 109 ~ } else if !name.as_os_str().is_empty() [INFO] [stdout] 110 ~ && !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) { [INFO] [stdout] 111 | #[allow(deprecated)] [INFO] [stdout] 112 | zip.add_directory_from_path(name, options)?; [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/function/mod.rs:160:37 [INFO] [stdout] | [INFO] [stdout] 160 | ... format!("Function's version is less than or equal to last deployed version, please bump up the version before pushing it"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Function's version is less than or equal to last deployed version, please bump up the version before pushing it".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/function/mod.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | format!("Please login before pushing the function"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Please login before pushing the function".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | / return Err(CLIError::new( [INFO] [stdout] 114 | | "DATA_ERROR".to_string(), [INFO] [stdout] 115 | | format!( [INFO] [stdout] 116 | | "{}: No description found in Cargo.toml file", [INFO] [stdout] 117 | | "Error:".red().bold(), [INFO] [stdout] 118 | | ), [INFO] [stdout] 119 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 ~ Err(CLIError::new( [INFO] [stdout] 114 + "DATA_ERROR".to_string(), [INFO] [stdout] 115 + format!( [INFO] [stdout] 116 + "{}: No description found in Cargo.toml file", [INFO] [stdout] 117 + "Error:".red().bold(), [INFO] [stdout] 118 + ), [INFO] [stdout] 119 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ServerErrorResponse` is never constructed [INFO] [stdout] --> src/extras/response.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct ServerErrorResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/project/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Project { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 9 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/project/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/project/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/main.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | / println!( [INFO] [stdout] 168 | | "{}", [INFO] [stdout] 169 | | format!("{}: {}", "Error", err) [INFO] [stdout] 170 | | [INFO] [stdout] 171 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/authn/mod.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | if err.error == "authorization_pending".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"authorization_pending"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/authn/mod.rs:129:33 [INFO] [stdout] | [INFO] [stdout] 129 | ... println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/function/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/function/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/function/mod.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 98 | if !(path.file_name() == Path::new("./temp/function.zip").file_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(path.file_name() != Path::new("./temp/function.zip").file_name())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/function/mod.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | && !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(name.components().nth(0) != Some(Component::Normal(OsStr::new("target"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/function/mod.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | if !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(name.components().nth(0) != Some(Component::Normal(OsStr::new("target"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/function/mod.rs:82:33 [INFO] [stdout] | [INFO] [stdout] 82 | let file = File::create(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/function/mod.rs:106:35 [INFO] [stdout] | [INFO] [stdout] 106 | zip.write_all(&*buffer)?; [INFO] [stdout] | ^^^^^^^^ help: try: `&buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/function/mod.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | } else if !name.as_os_str().is_empty() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 110 | | if !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) { [INFO] [stdout] 111 | | #[allow(deprecated)] [INFO] [stdout] 112 | | zip.add_directory_from_path(name, options)?; [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 109 ~ } else if !name.as_os_str().is_empty() [INFO] [stdout] 110 ~ && !(name.components().nth(0) == Some(Component::Normal(OsStr::new("target")))) { [INFO] [stdout] 111 | #[allow(deprecated)] [INFO] [stdout] 112 | zip.add_directory_from_path(name, options)?; [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/function/mod.rs:160:37 [INFO] [stdout] | [INFO] [stdout] 160 | ... format!("Function's version is less than or equal to last deployed version, please bump up the version before pushing it"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Function's version is less than or equal to last deployed version, please bump up the version before pushing it".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/function/mod.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | format!("Please login before pushing the function"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Please login before pushing the function".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | / return Err(CLIError::new( [INFO] [stdout] 114 | | "DATA_ERROR".to_string(), [INFO] [stdout] 115 | | format!( [INFO] [stdout] 116 | | "{}: No description found in Cargo.toml file", [INFO] [stdout] 117 | | "Error:".red().bold(), [INFO] [stdout] 118 | | ), [INFO] [stdout] 119 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 ~ Err(CLIError::new( [INFO] [stdout] 114 + "DATA_ERROR".to_string(), [INFO] [stdout] 115 + format!( [INFO] [stdout] 116 + "{}: No description found in Cargo.toml file", [INFO] [stdout] 117 + "Error:".red().bold(), [INFO] [stdout] 118 + ), [INFO] [stdout] 119 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/project/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/project/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/main.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | / println!( [INFO] [stdout] 168 | | "{}", [INFO] [stdout] 169 | | format!("{}: {}", "Error", err) [INFO] [stdout] 170 | | [INFO] [stdout] 171 | | ); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "40716935b162ed2db1ee12cc421cb18d6a46c9706dd2f02d62447228685971c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40716935b162ed2db1ee12cc421cb18d6a46c9706dd2f02d62447228685971c9", kill_on_drop: false }` [INFO] [stdout] 40716935b162ed2db1ee12cc421cb18d6a46c9706dd2f02d62447228685971c9