[INFO] fetching crate eeyf 0.1.0... [INFO] linting eeyf-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate eeyf 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate eeyf 0.1.0 [INFO] finished tweaking crates.io crate eeyf 0.1.0 [INFO] tweaked toml for crates.io crate eeyf 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate eeyf 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate eeyf 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded potential_utf v0.1.2 [INFO] [stderr] Downloaded env_filter v0.1.3 [INFO] [stderr] Downloaded is-terminal v0.4.16 [INFO] [stderr] Downloaded proc-macro-crate v3.3.0 [INFO] [stderr] Downloaded no-std-compat v0.4.1 [INFO] [stderr] Downloaded envy v0.4.2 [INFO] [stderr] Downloaded kqueue-sys v1.0.4 [INFO] [stderr] Downloaded compression-core v0.4.29 [INFO] [stderr] Downloaded compression-codecs v0.4.31 [INFO] [stderr] Downloaded num-complex v0.3.1 [INFO] [stderr] Downloaded arc-swap v1.7.1 [INFO] [stderr] Downloaded num-bigint v0.3.3 [INFO] [stderr] Downloaded yaml-rust2 v0.8.1 [INFO] [stderr] Downloaded async-compression v0.4.32 [INFO] [stderr] Downloaded proptest v1.8.0 [INFO] [stderr] Downloaded reqwest v0.12.22 [INFO] [stderr] Downloaded quinn-proto v0.11.12 [INFO] [stderr] Downloaded rust_decimal v1.37.2 [INFO] [stderr] Downloaded smol v2.0.2 [INFO] [stderr] Downloaded rustls v0.23.29 [INFO] [stderr] Downloaded h2 v0.3.27 [INFO] [stderr] Downloaded aws-lc-rs v1.14.1 [INFO] [stderr] Downloaded mio v0.8.11 [INFO] [stderr] Downloaded winnow v0.7.12 [INFO] [stderr] Downloaded hyper v0.14.32 [INFO] [stderr] Downloaded parse-zoneinfo v0.3.1 [INFO] [stderr] Downloaded tracing-opentelemetry v0.22.0 [INFO] [stderr] Downloaded opentelemetry_sdk v0.23.0 [INFO] [stderr] Downloaded tokio v1.47.0 [INFO] [stderr] Downloaded rustls-webpki v0.103.4 [INFO] [stderr] Downloaded rkyv v0.7.45 [INFO] [stderr] Downloaded opentelemetry_sdk v0.21.2 [INFO] [stderr] Downloaded indexmap v2.10.0 [INFO] [stderr] Downloaded governor v0.6.3 [INFO] [stderr] Downloaded opentelemetry-semantic-conventions v0.15.0 [INFO] [stderr] Downloaded opentelemetry-jaeger v0.22.0 [INFO] [stderr] Downloaded publicsuffix v2.3.0 [INFO] [stderr] Downloaded tungstenite v0.21.0 [INFO] [stderr] Downloaded idna v1.0.3 [INFO] [stderr] Downloaded jiff-static v0.2.15 [INFO] [stderr] Downloaded flate2 v1.1.2 [INFO] [stderr] Downloaded spinning_top v0.3.0 [INFO] [stderr] Downloaded chrono-tz v0.8.6 [INFO] [stderr] Downloaded jiff v0.2.15 [INFO] [stderr] Downloaded cookie_store v0.21.1 [INFO] [stderr] Downloaded headers v0.3.9 [INFO] [stderr] Downloaded warp v0.3.7 [INFO] [stderr] Downloaded num-rational v0.3.2 [INFO] [stderr] Downloaded time v0.3.41 [INFO] [stderr] Downloaded config v0.14.1 [INFO] [stderr] Downloaded metrics v0.24.2 [INFO] [stderr] Downloaded petgraph v0.6.5 [INFO] [stderr] Downloaded opentelemetry v0.23.0 [INFO] [stderr] Downloaded prost-types v0.12.6 [INFO] [stderr] Downloaded prost-build v0.12.6 [INFO] [stderr] Downloaded quinn v0.11.8 [INFO] [stderr] Downloaded prettyplease v0.2.36 [INFO] [stderr] Downloaded tinyvec v1.9.0 [INFO] [stderr] Downloaded async-signal v0.2.13 [INFO] [stderr] Downloaded opentelemetry v0.21.0 [INFO] [stderr] Downloaded hyper-util v0.1.16 [INFO] [stderr] Downloaded io-uring v0.7.9 [INFO] [stderr] Downloaded chrono-tz-build v0.2.1 [INFO] [stderr] Downloaded dashmap v5.5.3 [INFO] [stderr] Downloaded metrics-exporter-prometheus v0.16.2 [INFO] [stderr] Downloaded kqueue v1.1.1 [INFO] [stderr] Downloaded notify v6.1.1 [INFO] [stderr] Downloaded redox_syscall v0.5.17 [INFO] [stderr] Downloaded cookie v0.18.1 [INFO] [stderr] Downloaded quinn-udp v0.5.13 [INFO] [stderr] Downloaded borsh v1.5.7 [INFO] [stderr] Downloaded async-net v2.0.0 [INFO] [stderr] Downloaded polling v3.11.0 [INFO] [stderr] Downloaded async-io v2.6.0 [INFO] [stderr] Downloaded multer v2.1.0 [INFO] [stderr] Downloaded data-encoding v2.9.0 [INFO] [stderr] Downloaded deadpool v0.10.0 [INFO] [stderr] Downloaded url v2.5.4 [INFO] [stderr] Downloaded num v0.3.1 [INFO] [stderr] Downloaded hashlink v0.8.4 [INFO] [stderr] Downloaded env_logger v0.11.8 [INFO] [stderr] Downloaded nonzero_ext v0.3.0 [INFO] [stderr] Downloaded inotify v0.9.6 [INFO] [stderr] Downloaded integer-encoding v3.0.4 [INFO] [stderr] Downloaded thrift v0.17.0 [INFO] [stderr] Downloaded prost-derive v0.12.6 [INFO] [stderr] Downloaded rustls-native-certs v0.8.1 [INFO] [stderr] Downloaded thiserror-impl v2.0.12 [INFO] [stderr] Downloaded thiserror v2.0.12 [INFO] [stderr] Downloaded libloading v0.8.8 [INFO] [stderr] Downloaded tokio-rustls v0.26.2 [INFO] [stderr] Downloaded rkyv_derive v0.7.45 [INFO] [stderr] Downloaded deranged v0.4.0 [INFO] [stderr] Downloaded zerovec v0.11.2 [INFO] [stderr] Downloaded prost v0.12.6 [INFO] [stderr] Downloaded borsh-derive v1.5.7 [INFO] [stderr] Downloaded async-fs v2.2.0 [INFO] [stderr] Downloaded time-core v0.1.4 [INFO] [stderr] Downloaded tokio-test v0.4.4 [INFO] [stderr] Downloaded deadpool-runtime v0.1.4 [INFO] [stderr] Downloaded lru v0.12.5 [INFO] [stderr] Downloaded inotify-sys v0.1.5 [INFO] [stderr] Downloaded serde_path_to_error v0.1.17 [INFO] [stderr] Downloaded tokio-tungstenite v0.21.0 [INFO] [stderr] Downloaded filetime v0.2.26 [INFO] [stderr] Downloaded fsevent-sys v4.1.0 [INFO] [stderr] Downloaded threadpool v1.8.1 [INFO] [stderr] Downloaded async-executor v1.13.3 [INFO] [stderr] Downloaded async-process v2.5.0 [INFO] [stderr] Downloaded time-macros v0.2.22 [INFO] [stderr] Downloaded serde_json_path_to_error v0.1.5 [INFO] [stderr] Downloaded value-bag v1.11.1 [INFO] [stderr] Downloaded fixedbitset v0.4.2 [INFO] [stderr] Downloaded web-time v0.2.4 [INFO] [stderr] Downloaded headers-core v0.2.0 [INFO] [stderr] Downloaded scoped-tls v1.0.1 [INFO] [stderr] Downloaded assert-json-diff v2.0.2 [INFO] [stderr] Downloaded wiremock v0.6.4 [INFO] [stderr] Downloaded compress v0.2.1 [INFO] [stderr] Downloaded aws-lc-sys v0.32.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28e75ddabda2691c093ff912ba17eaff225a0484a9b4784a9935af694e69401e [INFO] running `Command { std: "docker" "start" "-a" "28e75ddabda2691c093ff912ba17eaff225a0484a9b4784a9935af694e69401e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28e75ddabda2691c093ff912ba17eaff225a0484a9b4784a9935af694e69401e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28e75ddabda2691c093ff912ba17eaff225a0484a9b4784a9935af694e69401e", kill_on_drop: false }` [INFO] [stdout] 28e75ddabda2691c093ff912ba17eaff225a0484a9b4784a9935af694e69401e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8fbae2cdfe07d63089c2f225dc1a6b27c080f9c5d4edbbcf30a47c8705a6d61e [INFO] running `Command { std: "docker" "start" "-a" "8fbae2cdfe07d63089c2f225dc1a6b27c080f9c5d4edbbcf30a47c8705a6d61e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling cc v1.2.30 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.141 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling regex-syntax v0.8.6 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling rustls v0.23.29 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Compiling regex-automata v0.4.11 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking proptest v1.8.0 [INFO] [stderr] Compiling regex v1.11.3 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.8.6 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tokio v1.47.0 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking deadpool v0.10.0 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking publicsuffix v2.3.0 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking cookie_store v0.21.1 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking wiremock v0.6.4 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking eeyf v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/builder.rs:622:5 [INFO] [stdout] | [INFO] [stdout] 622 | / /// ``` [INFO] [stdout] 623 | | [INFO] [stdout] | |_^ [INFO] [stdout] 624 | pub fn build(self) -> Result { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 128 | search_ttl_ms: 3600_000, // 1 hour for search results [INFO] [stdout] | ^^^^^^^^ help: consider: `3_600_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:129:29 [INFO] [stdout] | [INFO] [stdout] 129 | history_ttl_ms: 1800_000, // 30 minutes for historical data [INFO] [stdout] | ^^^^^^^^ help: consider: `1_800_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | search_ttl_ms: 7200_000, // 2 hours [INFO] [stdout] | ^^^^^^^^ help: consider: `7_200_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:147:29 [INFO] [stdout] | [INFO] [stdout] 147 | history_ttl_ms: 3600_000, // 1 hour [INFO] [stdout] | ^^^^^^^^ help: consider: `3_600_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/builder.rs:622:5 [INFO] [stdout] | [INFO] [stdout] 622 | / /// ``` [INFO] [stdout] 623 | | [INFO] [stdout] | |_^ [INFO] [stdout] 624 | pub fn build(self) -> Result { [INFO] [stdout] | ------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 128 | search_ttl_ms: 3600_000, // 1 hour for search results [INFO] [stdout] | ^^^^^^^^ help: consider: `3_600_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:129:29 [INFO] [stdout] | [INFO] [stdout] 129 | history_ttl_ms: 1800_000, // 30 minutes for historical data [INFO] [stdout] | ^^^^^^^^ help: consider: `1_800_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | search_ttl_ms: 7200_000, // 2 hours [INFO] [stdout] | ^^^^^^^^ help: consider: `7_200_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/response_cache.rs:147:29 [INFO] [stdout] | [INFO] [stdout] 147 | history_ttl_ms: 3600_000, // 1 hour [INFO] [stdout] | ^^^^^^^^ help: consider: `3_600_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `completed` is never read [INFO] [stdout] --> src/batch.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 220 | ... completed += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `completed` is never read [INFO] [stdout] --> src/batch.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 220 | ... completed += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/enterprise.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 303 | if let Err(_) = limiter.try_acquire_permit() { [INFO] [stdout] | -------^^^^^^------------------------------- help: try: `if limiter.try_acquire_permit().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/enterprise.rs:354:35 [INFO] [stdout] | [INFO] [stdout] 354 | let rate_limiter_status = if let Some(limiter) = &self.rate_limiter { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 355 | | Some(limiter.status()) [INFO] [stdout] 356 | | } else { [INFO] [stdout] 357 | | None [INFO] [stdout] 358 | | }; [INFO] [stdout] | |_________^ help: try: `self.rate_limiter.as_ref().map(|limiter| limiter.status())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/batch.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | self.concurrency = concurrency.max(1).min(50); // Clamp between 1 and 50 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `concurrency.clamp(1, 50)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/batch.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | self.timeout_secs = timeout.as_secs().max(1).min(300); // 1 to 300 seconds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `timeout.as_secs().clamp(1, 300)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/batch.rs:149:15 [INFO] [stdout] | [INFO] [stdout] 149 | ...n: Box std::pin::Pin> + Send + 'a>> + Send + Sync + 'a>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/batch.rs:219:35 [INFO] [stdout] | [INFO] [stdout] 219 | while let Some(_) = stream.next().await { [INFO] [stdout] | ----------^^^^^^^---------------------- help: try: `while stream.next().await.is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/validation.rs:159:26 [INFO] [stdout] | [INFO] [stdout] 159 | self.min_score = score.max(0.0).min(1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `score.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/screener/mod.rs:367:23 [INFO] [stdout] | [INFO] [stdout] 367 | let finance = body [INFO] [stdout] | _______________________^ [INFO] [stdout] 368 | | .get("finance") [INFO] [stdout] 369 | | .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 369 - .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] 369 + .ok_or(YahooError::DataInconsistency)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/screener/mod.rs:371:22 [INFO] [stdout] | [INFO] [stdout] 371 | let result = finance [INFO] [stdout] | ______________________^ [INFO] [stdout] 372 | | .get("result") [INFO] [stdout] 373 | | .and_then(|r| r.as_array()) [INFO] [stdout] 374 | | .and_then(|arr| arr.first()) [INFO] [stdout] 375 | | .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 375 - .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] 375 + .ok_or(YahooError::DataInconsistency)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/screener/mod.rs:382:22 [INFO] [stdout] | [INFO] [stdout] 382 | let quotes = result [INFO] [stdout] | ______________________^ [INFO] [stdout] 383 | | .get("quotes") [INFO] [stdout] 384 | | .and_then(|q| q.as_array()) [INFO] [stdout] 385 | | .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 385 - .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] 385 + .ok_or(YahooError::DataInconsistency)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | / format!( [INFO] [stdout] 465 | | "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 466 | | YahooConnector and convert to PresetConfig." [INFO] [stdout] 467 | | ) [INFO] [stdout] 468 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 464 ~ format!( [INFO] [stdout] 465 + "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 466 + YahooConnector and convert to PresetConfig." [INFO] [stdout] 467 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | / format!( [INFO] [stdout] 465 | | "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 466 | | YahooConnector and convert to PresetConfig." [INFO] [stdout] 467 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 464 ~ "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 465 + YahooConnector and convert to PresetConfig.".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/async_impl.rs:306:28 [INFO] [stdout] | [INFO] [stdout] 306 | return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 306 - return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] 306 + return self.parse_earnings_response(earnings_response); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/enterprise.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 303 | if let Err(_) = limiter.try_acquire_permit() { [INFO] [stdout] | -------^^^^^^------------------------------- help: try: `if limiter.try_acquire_permit().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/enterprise.rs:354:35 [INFO] [stdout] | [INFO] [stdout] 354 | let rate_limiter_status = if let Some(limiter) = &self.rate_limiter { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 355 | | Some(limiter.status()) [INFO] [stdout] 356 | | } else { [INFO] [stdout] 357 | | None [INFO] [stdout] 358 | | }; [INFO] [stdout] | |_________^ help: try: `self.rate_limiter.as_ref().map(|limiter| limiter.status())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/batch.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | self.concurrency = concurrency.max(1).min(50); // Clamp between 1 and 50 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `concurrency.clamp(1, 50)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/batch.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | self.timeout_secs = timeout.as_secs().max(1).min(300); // 1 to 300 seconds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `timeout.as_secs().clamp(1, 300)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/batch.rs:149:15 [INFO] [stdout] | [INFO] [stdout] 149 | ...n: Box std::pin::Pin> + Send + 'a>> + Send + Sync + 'a>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/batch.rs:219:35 [INFO] [stdout] | [INFO] [stdout] 219 | while let Some(_) = stream.next().await { [INFO] [stdout] | ----------^^^^^^^---------------------- help: try: `while stream.next().await.is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/validation.rs:159:26 [INFO] [stdout] | [INFO] [stdout] 159 | self.min_score = score.max(0.0).min(1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `score.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/screener/mod.rs:367:23 [INFO] [stdout] | [INFO] [stdout] 367 | let finance = body [INFO] [stdout] | _______________________^ [INFO] [stdout] 368 | | .get("finance") [INFO] [stdout] 369 | | .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 369 - .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] 369 + .ok_or(YahooError::DataInconsistency)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/screener/mod.rs:371:22 [INFO] [stdout] | [INFO] [stdout] 371 | let result = finance [INFO] [stdout] | ______________________^ [INFO] [stdout] 372 | | .get("result") [INFO] [stdout] 373 | | .and_then(|r| r.as_array()) [INFO] [stdout] 374 | | .and_then(|arr| arr.first()) [INFO] [stdout] 375 | | .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 375 - .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] 375 + .ok_or(YahooError::DataInconsistency)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/screener/mod.rs:382:22 [INFO] [stdout] | [INFO] [stdout] 382 | let quotes = result [INFO] [stdout] | ______________________^ [INFO] [stdout] 383 | | .get("quotes") [INFO] [stdout] 384 | | .and_then(|q| q.as_array()) [INFO] [stdout] 385 | | .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 385 - .ok_or_else(|| YahooError::DataInconsistency)?; [INFO] [stdout] 385 + .ok_or(YahooError::DataInconsistency)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | / format!( [INFO] [stdout] 465 | | "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 466 | | YahooConnector and convert to PresetConfig." [INFO] [stdout] 467 | | ) [INFO] [stdout] 468 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 464 ~ format!( [INFO] [stdout] 465 + "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 466 + YahooConnector and convert to PresetConfig." [INFO] [stdout] 467 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | / format!( [INFO] [stdout] 465 | | "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 466 | | YahooConnector and convert to PresetConfig." [INFO] [stdout] 467 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 464 ~ "Preset saving not yet implemented. Need to extract current configuration from \ [INFO] [stdout] 465 + YahooConnector and convert to PresetConfig.".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/async_impl.rs:306:28 [INFO] [stdout] | [INFO] [stdout] 306 | return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 306 - return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] 306 + return self.parse_earnings_response(earnings_response); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/async_impl.rs:786:28 [INFO] [stdout] | [INFO] [stdout] 785 | if response.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = response` [INFO] [stdout] 786 | let response = response.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/async_impl.rs:860:56 [INFO] [stdout] | [INFO] [stdout] 860 | provider.get_quote_period_interval("AAPL", &range, &interval, true), [INFO] [stdout] | ^^^^^^ help: change this to: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/async_impl.rs:860:64 [INFO] [stdout] | [INFO] [stdout] 860 | provider.get_quote_period_interval("AAPL", &range, &interval, true), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/async_impl.rs:876:17 [INFO] [stdout] | [INFO] [stdout] 876 | assert!(quotes.len() > 0usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!quotes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/async_impl.rs:905:28 [INFO] [stdout] | [INFO] [stdout] 904 | if response.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = response` [INFO] [stdout] 905 | let response = response.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/async_impl.rs:961:17 [INFO] [stdout] | [INFO] [stdout] 961 | assert!(capital_gains.len() > 0usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!capital_gains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/async_impl.rs:1015:17 [INFO] [stdout] | [INFO] [stdout] 1015 | assert!(!quotes.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `quotes.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 58.26s [INFO] running `Command { std: "docker" "inspect" "8fbae2cdfe07d63089c2f225dc1a6b27c080f9c5d4edbbcf30a47c8705a6d61e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fbae2cdfe07d63089c2f225dc1a6b27c080f9c5d4edbbcf30a47c8705a6d61e", kill_on_drop: false }` [INFO] [stdout] 8fbae2cdfe07d63089c2f225dc1a6b27c080f9c5d4edbbcf30a47c8705a6d61e