[INFO] fetching crate ed_join 1.1.1... [INFO] linting ed_join-1.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ed_join 1.1.1 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate ed_join 1.1.1 [INFO] finished tweaking crates.io crate ed_join 1.1.1 [INFO] tweaked toml for crates.io crate ed_join 1.1.1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ed_join 1.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ed_join 1.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded edit-distance v2.1.0 [INFO] [stderr] Downloaded dialoguer v0.4.0 [INFO] [stderr] Downloaded indicatif v0.12.0 [INFO] [stderr] Downloaded memoffset v0.5.2 [INFO] [stderr] Downloaded console v0.9.0 [INFO] [stderr] Downloaded hermit-abi v0.1.3 [INFO] [stderr] Downloaded error-chain v0.12.1 [INFO] [stderr] Downloaded num_cpus v1.11.0 [INFO] [stderr] Downloaded cc v1.0.46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb6ef0b0642170e1f3fb041b908cf29fbc1db8c271e14e463ea881f8e2ac173e [INFO] running `Command { std: "docker" "start" "-a" "fb6ef0b0642170e1f3fb041b908cf29fbc1db8c271e14e463ea881f8e2ac173e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb6ef0b0642170e1f3fb041b908cf29fbc1db8c271e14e463ea881f8e2ac173e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb6ef0b0642170e1f3fb041b908cf29fbc1db8c271e14e463ea881f8e2ac173e", kill_on_drop: false }` [INFO] [stdout] fb6ef0b0642170e1f3fb041b908cf29fbc1db8c271e14e463ea881f8e2ac173e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 737a578f80deb0767e7f85d669febc2b18c2718e196a6f262ee4ada0b53281c3 [INFO] running `Command { std: "docker" "start" "-a" "737a578f80deb0767e7f85d669febc2b18c2718e196a6f262ee4ada0b53281c3", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling cc v1.0.46 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking edit-distance v2.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling error-chain v0.12.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Compiling memoffset v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking ed_join v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this attribute can only be applied to a `use` item [INFO] [stdout] --> src/lib.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | #[doc(inline)] [INFO] [stdout] | ^^^^^^ only applicable on `use` items [INFO] [stdout] 13 | pub mod matching; [INFO] [stdout] | ---------------- not a `use` item [INFO] [stdout] | [INFO] [stdout] = note: read for more information [INFO] [stdout] = note: `#[warn(invalid_doc_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this attribute can only be applied to a `use` item [INFO] [stdout] --> src/lib.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | #[doc(inline)] [INFO] [stdout] | ^^^^^^ only applicable on `use` items [INFO] [stdout] 15 | pub mod qgram; [INFO] [stdout] | ------------- not a `use` item [INFO] [stdout] | [INFO] [stdout] = note: read for more information [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this attribute can only be applied to a `use` item [INFO] [stdout] --> src/lib.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | #[doc(inline)] [INFO] [stdout] | ^^^^^^ only applicable on `use` items [INFO] [stdout] 17 | pub mod verification; [INFO] [stdout] | -------------------- not a `use` item [INFO] [stdout] | [INFO] [stdout] = note: read for more information [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | foreign_links { [INFO] [stdout] 4 | | Fmt(std::fmt::Error) [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this attribute can only be applied to a `use` item [INFO] [stdout] --> src/lib.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | #[doc(inline)] [INFO] [stdout] | ^^^^^^ only applicable on `use` items [INFO] [stdout] 13 | pub mod matching; [INFO] [stdout] | ---------------- not a `use` item [INFO] [stdout] | [INFO] [stdout] = note: read for more information [INFO] [stdout] = note: `#[warn(invalid_doc_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this attribute can only be applied to a `use` item [INFO] [stdout] --> src/lib.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | #[doc(inline)] [INFO] [stdout] | ^^^^^^ only applicable on `use` items [INFO] [stdout] 15 | pub mod qgram; [INFO] [stdout] | ------------- not a `use` item [INFO] [stdout] | [INFO] [stdout] = note: read for more information [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this attribute can only be applied to a `use` item [INFO] [stdout] --> src/lib.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | #[doc(inline)] [INFO] [stdout] | ^^^^^^ only applicable on `use` items [INFO] [stdout] 17 | pub mod verification; [INFO] [stdout] | -------------------- not a `use` item [INFO] [stdout] | [INFO] [stdout] = note: read for more information [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | foreign_links { [INFO] [stdout] 4 | | Fmt(std::fmt::Error) [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/matching.rs:162:25 [INFO] [stdout] | [INFO] [stdout] 162 | let x_content = String::from(line_x.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line_x.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matching.rs:200:25 [INFO] [stdout] | [INFO] [stdout] 200 | (doc_x == doc_y) && (*y_id > x_id) || (doc_x != doc_y) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 200 - (doc_x == doc_y) && (*y_id > x_id) || (doc_x != doc_y) [INFO] [stdout] 200 + !((doc_x == doc_y) && *y_id <= x_id) [INFO] [stdout] | [INFO] [stdout] 200 - (doc_x == doc_y) && (*y_id > x_id) || (doc_x != doc_y) [INFO] [stdout] 200 + doc_x != doc_y || (*y_id > x_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matching.rs:225:57 [INFO] [stdout] | [INFO] [stdout] 225 | let qgram_array_y = PosQGramArray::from(&y_content, q); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `y_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matching.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | &y_content, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `y_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matching.rs:242:124 [INFO] [stdout] | [INFO] [stdout] 242 | verified.par_iter_mut().for_each(|(_x_id, yvec)| yvec.par_sort_unstable_by(|(a_id, _a_ed), (b_id, _b_ed)| a_id.cmp(&b_id))); [INFO] [stdout] | ^^^^^ help: change this to: `b_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qgram.rs:40:58 [INFO] [stdout] | [INFO] [stdout] 40 | Ordering::Equal => self.token.as_bytes().cmp(&other.token.as_bytes()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `other.token.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PosQGramArray` [INFO] [stdout] --> src/qgram.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / pub fn new() -> Self { [INFO] [stdout] 87 | | Self { [INFO] [stdout] 88 | | inner: Vec::::new(), [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 85 + impl Default for PosQGramArray { [INFO] [stdout] 86 + fn default() -> Self { [INFO] [stdout] 87 + Self::new() [INFO] [stdout] 88 + } [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qgram.rs:131:59 [INFO] [stdout] | [INFO] [stdout] 131 | Ordering::Equal => a.token.as_bytes().cmp(&b.token.as_bytes()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `b.token.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/verification.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 94 | if qgram_array.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `qgram_array.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/verification.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|(a, b)| (*a as isize - *b as isize).abs() as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(*a as isize - *b as isize).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/verification.rs:239:1 [INFO] [stdout] | [INFO] [stdout] 239 | / pub fn verify( [INFO] [stdout] 240 | | x: Vec, [INFO] [stdout] 241 | | line_id: usize, [INFO] [stdout] 242 | | line_content: &str, [INFO] [stdout] ... | [INFO] [stdout] 248 | | tau: usize, [INFO] [stdout] 249 | | ) -> Option<(ID, Vec<(ID, usize)>)> { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verification.rs:262:62 [INFO] [stdout] | [INFO] [stdout] 262 | let (mut loose_mismatch, epsilon_1) = compare_qgrams(&x, &y, &inverted, q); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verification.rs:262:66 [INFO] [stdout] | [INFO] [stdout] 262 | let (mut loose_mismatch, epsilon_1) = compare_qgrams(&x, &y, &inverted, q); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `inverted` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/matching.rs:162:25 [INFO] [stdout] | [INFO] [stdout] 162 | let x_content = String::from(line_x.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line_x.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matching.rs:200:25 [INFO] [stdout] | [INFO] [stdout] 200 | (doc_x == doc_y) && (*y_id > x_id) || (doc_x != doc_y) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 200 - (doc_x == doc_y) && (*y_id > x_id) || (doc_x != doc_y) [INFO] [stdout] 200 + !((doc_x == doc_y) && *y_id <= x_id) [INFO] [stdout] | [INFO] [stdout] 200 - (doc_x == doc_y) && (*y_id > x_id) || (doc_x != doc_y) [INFO] [stdout] 200 + doc_x != doc_y || (*y_id > x_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matching.rs:225:57 [INFO] [stdout] | [INFO] [stdout] 225 | let qgram_array_y = PosQGramArray::from(&y_content, q); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `y_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matching.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | &y_content, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `y_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matching.rs:242:124 [INFO] [stdout] | [INFO] [stdout] 242 | verified.par_iter_mut().for_each(|(_x_id, yvec)| yvec.par_sort_unstable_by(|(a_id, _a_ed), (b_id, _b_ed)| a_id.cmp(&b_id))); [INFO] [stdout] | ^^^^^ help: change this to: `b_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qgram.rs:40:58 [INFO] [stdout] | [INFO] [stdout] 40 | Ordering::Equal => self.token.as_bytes().cmp(&other.token.as_bytes()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `other.token.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PosQGramArray` [INFO] [stdout] --> src/qgram.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / pub fn new() -> Self { [INFO] [stdout] 87 | | Self { [INFO] [stdout] 88 | | inner: Vec::::new(), [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 85 + impl Default for PosQGramArray { [INFO] [stdout] 86 + fn default() -> Self { [INFO] [stdout] 87 + Self::new() [INFO] [stdout] 88 + } [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qgram.rs:131:59 [INFO] [stdout] | [INFO] [stdout] 131 | Ordering::Equal => a.token.as_bytes().cmp(&b.token.as_bytes()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `b.token.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/verification.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 94 | if qgram_array.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `qgram_array.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/verification.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|(a, b)| (*a as isize - *b as isize).abs() as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(*a as isize - *b as isize).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/verification.rs:239:1 [INFO] [stdout] | [INFO] [stdout] 239 | / pub fn verify( [INFO] [stdout] 240 | | x: Vec, [INFO] [stdout] 241 | | line_id: usize, [INFO] [stdout] 242 | | line_content: &str, [INFO] [stdout] ... | [INFO] [stdout] 248 | | tau: usize, [INFO] [stdout] 249 | | ) -> Option<(ID, Vec<(ID, usize)>)> { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verification.rs:262:62 [INFO] [stdout] | [INFO] [stdout] 262 | let (mut loose_mismatch, epsilon_1) = compare_qgrams(&x, &y, &inverted, q); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verification.rs:262:66 [INFO] [stdout] | [INFO] [stdout] 262 | let (mut loose_mismatch, epsilon_1) = compare_qgrams(&x, &y, &inverted, q); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `inverted` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.44s [INFO] running `Command { std: "docker" "inspect" "737a578f80deb0767e7f85d669febc2b18c2718e196a6f262ee4ada0b53281c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "737a578f80deb0767e7f85d669febc2b18c2718e196a6f262ee4ada0b53281c3", kill_on_drop: false }` [INFO] [stdout] 737a578f80deb0767e7f85d669febc2b18c2718e196a6f262ee4ada0b53281c3