[INFO] fetching crate eansearch 1.2.0... [INFO] linting eansearch-1.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate eansearch 1.2.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate eansearch 1.2.0 [INFO] finished tweaking crates.io crate eansearch 1.2.0 [INFO] tweaked toml for crates.io crate eansearch 1.2.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate eansearch 1.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate eansearch 1.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded engine v0.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f32883805f59ce83f0945863834211ccdc102d45eef78bf1706ce83b10368ee [INFO] running `Command { std: "docker" "start" "-a" "0f32883805f59ce83f0945863834211ccdc102d45eef78bf1706ce83b10368ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f32883805f59ce83f0945863834211ccdc102d45eef78bf1706ce83b10368ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f32883805f59ce83f0945863834211ccdc102d45eef78bf1706ce83b10368ee", kill_on_drop: false }` [INFO] [stdout] 0f32883805f59ce83f0945863834211ccdc102d45eef78bf1706ce83b10368ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9472f600813a1aeeb4b8e5b9a61f07a09d2e347c846f2a710cee196ec1ca48c [INFO] running `Command { std: "docker" "start" "-a" "d9472f600813a1aeeb4b8e5b9a61f07a09d2e347c846f2a710cee196ec1ca48c", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling cc v1.2.15 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Compiling serde v1.0.218 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling httparse v1.10.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling openssl v0.10.71 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Compiling serde_json v1.0.139 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.218 [INFO] [stderr] Checking engine v0.0.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking eansearch v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 111 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:111:92 [INFO] [stdout] | [INFO] [stdout] 111 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `api_error` after checking its variant with `is_ok` [INFO] [stdout] --> src/lib.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 172 | if api_error.is_ok() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = api_error` [INFO] [stdout] 173 | return Err(api_error.unwrap()[0].error.clone().into()); // API error [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:168:30 [INFO] [stdout] | [INFO] [stdout] 168 | return self.api_call_list(&url, tries + 1) [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/lib.rs:164:43 [INFO] [stdout] | [INFO] [stdout] 164 | fn api_call_list(&self, url: &String, tries: i32) -> Result, Box> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tries` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/lib.rs:168:36 [INFO] [stdout] | [INFO] [stdout] 168 | return self.api_call_list(&url, tries + 1) [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `name` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:215:36 [INFO] [stdout] | [INFO] [stdout] 214 | if name.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = name` [INFO] [stdout] 215 | url = url + "&name=" + name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 111 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:111:92 [INFO] [stdout] | [INFO] [stdout] 111 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `api_error` after checking its variant with `is_ok` [INFO] [stdout] --> src/lib.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 172 | if api_error.is_ok() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = api_error` [INFO] [stdout] 173 | return Err(api_error.unwrap()[0].error.clone().into()); // API error [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:168:30 [INFO] [stdout] | [INFO] [stdout] 168 | return self.api_call_list(&url, tries + 1) [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/lib.rs:164:43 [INFO] [stdout] | [INFO] [stdout] 164 | fn api_call_list(&self, url: &String, tries: i32) -> Result, Box> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tries` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/lib.rs:168:36 [INFO] [stdout] | [INFO] [stdout] 168 | return self.api_call_list(&url, tries + 1) [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `name` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:215:36 [INFO] [stdout] | [INFO] [stdout] 214 | if name.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = name` [INFO] [stdout] 215 | url = url + "&name=" + name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:334:17 [INFO] [stdout] | [INFO] [stdout] 334 | assert!(!product.unwrap().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product.unwrap().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/lib.rs:463:17 [INFO] [stdout] | [INFO] [stdout] 463 | assert!(checksum_ok.unwrap() == true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `checksum_ok.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | assert!(checksum_ok.unwrap() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!checksum_ok.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `Command { std: "docker" "inspect" "d9472f600813a1aeeb4b8e5b9a61f07a09d2e347c846f2a710cee196ec1ca48c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9472f600813a1aeeb4b8e5b9a61f07a09d2e347c846f2a710cee196ec1ca48c", kill_on_drop: false }` [INFO] [stdout] d9472f600813a1aeeb4b8e5b9a61f07a09d2e347c846f2a710cee196ec1ca48c