[INFO] fetching crate dynorow_derive 0.1.3...
[INFO] linting dynorow_derive-0.1.3 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate dynorow_derive 0.1.3 into /workspace/builds/worker-4-tc1/source
[INFO] started tweaking crates.io crate dynorow_derive 0.1.3
[INFO] finished tweaking crates.io crate dynorow_derive 0.1.3
[INFO] tweaked toml for crates.io crate dynorow_derive 0.1.3 written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate dynorow_derive 0.1.3 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate dynorow_derive 0.1.3 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b2464b49ac787263dce537bc365c193415e700fc0fd606d11602d85317250c05
[INFO] running `Command { std: "docker" "start" "-a" "b2464b49ac787263dce537bc365c193415e700fc0fd606d11602d85317250c05", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b2464b49ac787263dce537bc365c193415e700fc0fd606d11602d85317250c05", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b2464b49ac787263dce537bc365c193415e700fc0fd606d11602d85317250c05", kill_on_drop: false }`
[INFO] [stdout] b2464b49ac787263dce537bc365c193415e700fc0fd606d11602d85317250c05
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8decc8bd9c651e1f2791c3b5ed443ae23cb4c216a0d081c0a61b5db768022b83
[INFO] running `Command { std: "docker" "start" "-a" "8decc8bd9c651e1f2791c3b5ed443ae23cb4c216a0d081c0a61b5db768022b83", kill_on_drop: false }`
[INFO] [stderr]     Checking memchr v2.7.6
[INFO] [stderr]     Checking regex-syntax v0.8.9
[INFO] [stderr]     Checking proc-macro2 v1.0.105
[INFO] [stderr]     Checking aho-corasick v1.1.4
[INFO] [stderr]     Checking quote v1.0.43
[INFO] [stderr]     Checking syn v2.0.114
[INFO] [stderr]     Checking regex-automata v0.4.14
[INFO] [stderr]     Checking regex v1.12.3
[INFO] [stderr]     Checking dynorow_derive v0.1.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream`
[INFO] [stdout]   --> src/generators/as_attribute_values.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 | /     quote! {
[INFO] [stdout] 47 | |         impl dynorow::traits::as_attribute_key_values::AsAttributeKeyValues for #struct_name_expr {
[INFO] [stdout] 48 | |             fn as_attribute_key_values(&self) -> std::collections::HashMap<String, dynorow::aws_sdk_dynamodb::types::AttributeValu...
[INFO] [stdout] 49 | |                 use dynorow::traits::into_attribute_value::*;
[INFO] [stdout] ...  |
[INFO] [stdout] 57 | |     }.into()
[INFO] [stdout]    | |____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] help: consider removing `.into()`
[INFO] [stdout]    |
[INFO] [stdout] 46 ~     quote! {
[INFO] [stdout] 47 +         impl dynorow::traits::as_attribute_key_values::AsAttributeKeyValues for #struct_name_expr {
[INFO] [stdout] 48 +             fn as_attribute_key_values(&self) -> std::collections::HashMap<String, dynorow::aws_sdk_dynamodb::types::AttributeValue> {
[INFO] [stdout] 49 +                 use dynorow::traits::into_attribute_value::*;
[INFO] [stdout] 50 +                 let mut result = std::collections::HashMap::<String, dynorow::aws_sdk_dynamodb::types::AttributeValue>::new();
[INFO] [stdout] 51 + 
[INFO] [stdout] 52 +                 #fields_token
[INFO] [stdout] 53 + 
[INFO] [stdout] 54 +                 return result;
[INFO] [stdout] 55 +             }
[INFO] [stdout] 56 +         }
[INFO] [stdout] 57 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream`
[INFO] [stdout]   --> src/generators/as_attribute_values.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 | /     quote! {
[INFO] [stdout] 47 | |         impl dynorow::traits::as_attribute_key_values::AsAttributeKeyValues for #struct_name_expr {
[INFO] [stdout] 48 | |             fn as_attribute_key_values(&self) -> std::collections::HashMap<String, dynorow::aws_sdk_dynamodb::types::AttributeValu...
[INFO] [stdout] 49 | |                 use dynorow::traits::into_attribute_value::*;
[INFO] [stdout] ...  |
[INFO] [stdout] 57 | |     }.into()
[INFO] [stdout]    | |____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] help: consider removing `.into()`
[INFO] [stdout]    |
[INFO] [stdout] 46 ~     quote! {
[INFO] [stdout] 47 +         impl dynorow::traits::as_attribute_key_values::AsAttributeKeyValues for #struct_name_expr {
[INFO] [stdout] 48 +             fn as_attribute_key_values(&self) -> std::collections::HashMap<String, dynorow::aws_sdk_dynamodb::types::AttributeValue> {
[INFO] [stdout] 49 +                 use dynorow::traits::into_attribute_value::*;
[INFO] [stdout] 50 +                 let mut result = std::collections::HashMap::<String, dynorow::aws_sdk_dynamodb::types::AttributeValue>::new();
[INFO] [stdout] 51 + 
[INFO] [stdout] 52 +                 #fields_token
[INFO] [stdout] 53 + 
[INFO] [stdout] 54 +                 return result;
[INFO] [stdout] 55 +             }
[INFO] [stdout] 56 +         }
[INFO] [stdout] 57 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/generators/conditional_expression_builder.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     if let Some(sk_key) = struct_info.get_sk_key() {
[INFO] [stdout] 27 | |         if struct_info.find_in_handled_fields("sort_key").is_none() {
[INFO] [stdout] 28 | |             generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens);
[INFO] [stdout] 29 | |         }
[INFO] [stdout] 30 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 26 ~     if let Some(sk_key) = struct_info.get_sk_key()
[INFO] [stdout] 27 ~         && struct_info.find_in_handled_fields("sort_key").is_none() {
[INFO] [stdout] 28 |             generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens);
[INFO] [stdout] 29 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/generators/conditional_expression_builder.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     if let Some(sk_key) = struct_info.get_sk_key() {
[INFO] [stdout] 27 | |         if struct_info.find_in_handled_fields("sort_key").is_none() {
[INFO] [stdout] 28 | |             generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens);
[INFO] [stdout] 29 | |         }
[INFO] [stdout] 30 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 26 ~     if let Some(sk_key) = struct_info.get_sk_key()
[INFO] [stdout] 27 ~         && struct_info.find_in_handled_fields("sort_key").is_none() {
[INFO] [stdout] 28 |             generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens);
[INFO] [stdout] 29 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/try_from_attribute_value_hashmap.rs:12:65
[INFO] [stdout]    |
[INFO] [stdout] 12 |     let field_tokens = generate_attribute_value_to_fields_token(&struct_info);
[INFO] [stdout]    |                                                                 ^^^^^^^^^^^^ help: change this to: `struct_info`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/try_from_attribute_value_hashmap.rs:34:68
[INFO] [stdout]    |
[INFO] [stdout] 34 |         let attribute_parse_token = generate_attribute_parse_token(&field);
[INFO] [stdout]    |                                                                    ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream`
[INFO] [stdout]   --> src/generators/try_from_get_item_output.rs:9:5
[INFO] [stdout]    |
[INFO] [stdout]  9 | /     quote::quote! {
[INFO] [stdout] 10 | |         impl TryFrom<dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput> for #struct_name {
[INFO] [stdout] 11 | |             type Error = dynorow::error::Error;
[INFO] [stdout] ...  |
[INFO] [stdout] 21 | |     }.into()
[INFO] [stdout]    | |____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into()`
[INFO] [stdout]    |
[INFO] [stdout]  9 ~     quote::quote! {
[INFO] [stdout] 10 +         impl TryFrom<dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput> for #struct_name {
[INFO] [stdout] 11 +             type Error = dynorow::error::Error;
[INFO] [stdout] 12 + 
[INFO] [stdout] 13 +             fn try_from(value: dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput) -> Result<Self, Self::Error> {
[INFO] [stdout] 14 +                 let Some(items) = value.item else {
[INFO] [stdout] 15 +                     return Err(dynorow::error::Error::value_not_found("GetItemOuput.item".into()));
[INFO] [stdout] 16 +                 };
[INFO] [stdout] 17 +                 
[INFO] [stdout] 18 +                 Self::try_from(items)
[INFO] [stdout] 19 +             }
[INFO] [stdout] 20 +         }
[INFO] [stdout] 21 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/update_expression_builder.rs:19:51
[INFO] [stdout]    |
[INFO] [stdout] 19 |             generate_dynomap_field_function_token(&field).to_tokens(&mut field_tokens);
[INFO] [stdout]    |                                                   ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/update_expression_builder.rs:21:43
[INFO] [stdout]    |
[INFO] [stdout] 21 |             generate_field_function_token(&field).to_tokens(&mut field_tokens);
[INFO] [stdout]    |                                           ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/try_from_attribute_value_hashmap.rs:12:65
[INFO] [stdout]    |
[INFO] [stdout] 12 |     let field_tokens = generate_attribute_value_to_fields_token(&struct_info);
[INFO] [stdout]    |                                                                 ^^^^^^^^^^^^ help: change this to: `struct_info`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/update_expression_builder_for_dynomap.rs:13:39
[INFO] [stdout]    |
[INFO] [stdout] 13 |         generate_field_function_token(&field).to_tokens(&mut field_tokens);
[INFO] [stdout]    |                                       ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/try_from_attribute_value_hashmap.rs:34:68
[INFO] [stdout]    |
[INFO] [stdout] 34 |         let attribute_parse_token = generate_attribute_parse_token(&field);
[INFO] [stdout]    |                                                                    ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]   --> src/struct_info/field_info.rs:79:1
[INFO] [stdout]    |
[INFO] [stdout] 79 | impl Into<FieldInfo> for FieldScan {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout]    = note: `#[warn(clippy::from_over_into)]` on by default
[INFO] [stdout] help: replace the `Into` implementation with `From<struct_info::field_info::FieldScan>`
[INFO] [stdout]    |
[INFO] [stdout] 79 ~ impl From<FieldScan> for FieldInfo {
[INFO] [stdout] 80 ~     fn from(val: FieldScan) -> Self {
[INFO] [stdout] 81 |         FieldInfo::new(
[INFO] [stdout] 82 ~             val.field_name.clone(),
[INFO] [stdout] 83 ~             val.get_key(),
[INFO] [stdout] 84 ~             val.field_type,
[INFO] [stdout] 85 ~             val.field_syn_type,
[INFO] [stdout] 86 ~             val.ignore,
[INFO] [stdout] 87 ~             val.is_option,
[INFO] [stdout] 88 ~             val.is_serde,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/struct_info/field_info.rs:97:17
[INFO] [stdout]    |
[INFO] [stdout] 97 |                 return segment;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -                 return segment;
[INFO] [stdout] 97 +                 segment
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:118:50
[INFO] [stdout]     |
[INFO] [stdout] 118 |                 syn::GenericArgument::Type(t) => return t.clone(),
[INFO] [stdout]     |                                                  ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 118 -                 syn::GenericArgument::Type(t) => return t.clone(),
[INFO] [stdout] 118 +                 syn::GenericArgument::Type(t) => t.clone(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream`
[INFO] [stdout]   --> src/generators/try_from_get_item_output.rs:9:5
[INFO] [stdout]    |
[INFO] [stdout]  9 | /     quote::quote! {
[INFO] [stdout] 10 | |         impl TryFrom<dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput> for #struct_name {
[INFO] [stdout] 11 | |             type Error = dynorow::error::Error;
[INFO] [stdout] ...  |
[INFO] [stdout] 21 | |     }.into()
[INFO] [stdout]    | |____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into()`
[INFO] [stdout]    |
[INFO] [stdout]  9 ~     quote::quote! {
[INFO] [stdout] 10 +         impl TryFrom<dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput> for #struct_name {
[INFO] [stdout] 11 +             type Error = dynorow::error::Error;
[INFO] [stdout] 12 + 
[INFO] [stdout] 13 +             fn try_from(value: dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput) -> Result<Self, Self::Error> {
[INFO] [stdout] 14 +                 let Some(items) = value.item else {
[INFO] [stdout] 15 +                     return Err(dynorow::error::Error::value_not_found("GetItemOuput.item".into()));
[INFO] [stdout] 16 +                 };
[INFO] [stdout] 17 +                 
[INFO] [stdout] 18 +                 Self::try_from(items)
[INFO] [stdout] 19 +             }
[INFO] [stdout] 20 +         }
[INFO] [stdout] 21 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:187:9
[INFO] [stdout]     |
[INFO] [stdout] 187 |         return Key::Key(self.key.clone());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 187 -         return Key::Key(self.key.clone());
[INFO] [stdout] 187 +         Key::Key(self.key.clone())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:221:9
[INFO] [stdout]     |
[INFO] [stdout] 221 |         return field_scan.into();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 221 -         return field_scan.into();
[INFO] [stdout] 221 +         field_scan.into()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/struct_info/field_info.rs:193:45
[INFO] [stdout]     |
[INFO] [stdout] 193 |         let mut field_scan = FieldScan::new(&field);
[INFO] [stdout]     |                                             ^^^^^^ help: change this to: `field`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:217:17
[INFO] [stdout]     |
[INFO] [stdout] 217 |                 return Ok(());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 217 -                 return Ok(());
[INFO] [stdout] 217 +                 Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]  --> src/struct_info/key.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 |     Key(String),
[INFO] [stdout]   |     ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]   = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/struct_info/mod.rs:84:9
[INFO] [stdout]    |
[INFO] [stdout] 84 |         return struct_info;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 84 -         return struct_info;
[INFO] [stdout] 84 +         struct_info
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/struct_info/mod.rs:63:21
[INFO] [stdout]    |
[INFO] [stdout] 63 |                     return Ok(());
[INFO] [stdout]    |                     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -                     return Ok(());
[INFO] [stdout] 63 +                     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/update_expression_builder.rs:19:51
[INFO] [stdout]    |
[INFO] [stdout] 19 |             generate_dynomap_field_function_token(&field).to_tokens(&mut field_tokens);
[INFO] [stdout]    |                                                   ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/update_expression_builder.rs:21:43
[INFO] [stdout]    |
[INFO] [stdout] 21 |             generate_field_function_token(&field).to_tokens(&mut field_tokens);
[INFO] [stdout]    |                                           ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used
[INFO] [stdout]   --> src/struct_info/mod.rs:79:38
[INFO] [stdout]    |
[INFO] [stdout] 79 |             struct_info.insert_field(FieldInfo::try_from(field).unwrap());
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: converting `&Field` to `FieldInfo` cannot fail
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 79 -             struct_info.insert_field(FieldInfo::try_from(field).unwrap());
[INFO] [stdout] 79 +             struct_info.insert_field(FieldInfo::from(field));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/mod.rs:152:9
[INFO] [stdout]     |
[INFO] [stdout] 152 |         return pk.clone();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 152 -         return pk.clone();
[INFO] [stdout] 152 +         pk.clone()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator
[INFO] [stdout]    --> src/struct_info/mod.rs:164:9
[INFO] [stdout]     |
[INFO] [stdout] 164 | /         let Some(sk_field) = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_))) else {
[INFO] [stdout] 165 | |             return None;
[INFO] [stdout] 166 | |         };
[INFO] [stdout]     | |__________^ help: replace it with: `let sk_field = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_)))?;`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]     = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/struct_info/mod.rs:218:12
[INFO] [stdout]     |
[INFO] [stdout] 218 |         if !(struct_has_pk || struct_has_pk_value) && !field_has_pk {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(struct_has_pk || struct_has_pk_value || field_has_pk)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/generators/update_expression_builder_for_dynomap.rs:13:39
[INFO] [stdout]    |
[INFO] [stdout] 13 |         generate_field_function_token(&field).to_tokens(&mut field_tokens);
[INFO] [stdout]    |                                       ^^^^^^ help: change this to: `field`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]   --> src/struct_info/field_info.rs:79:1
[INFO] [stdout]    |
[INFO] [stdout] 79 | impl Into<FieldInfo> for FieldScan {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout]    = note: `#[warn(clippy::from_over_into)]` on by default
[INFO] [stdout] help: replace the `Into` implementation with `From<struct_info::field_info::FieldScan>`
[INFO] [stdout]    |
[INFO] [stdout] 79 ~ impl From<FieldScan> for FieldInfo {
[INFO] [stdout] 80 ~     fn from(val: FieldScan) -> Self {
[INFO] [stdout] 81 |         FieldInfo::new(
[INFO] [stdout] 82 ~             val.field_name.clone(),
[INFO] [stdout] 83 ~             val.get_key(),
[INFO] [stdout] 84 ~             val.field_type,
[INFO] [stdout] 85 ~             val.field_syn_type,
[INFO] [stdout] 86 ~             val.ignore,
[INFO] [stdout] 87 ~             val.is_option,
[INFO] [stdout] 88 ~             val.is_serde,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/struct_info/field_info.rs:97:17
[INFO] [stdout]    |
[INFO] [stdout] 97 |                 return segment;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -                 return segment;
[INFO] [stdout] 97 +                 segment
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:118:50
[INFO] [stdout]     |
[INFO] [stdout] 118 |                 syn::GenericArgument::Type(t) => return t.clone(),
[INFO] [stdout]     |                                                  ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 118 -                 syn::GenericArgument::Type(t) => return t.clone(),
[INFO] [stdout] 118 +                 syn::GenericArgument::Type(t) => t.clone(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:187:9
[INFO] [stdout]     |
[INFO] [stdout] 187 |         return Key::Key(self.key.clone());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 187 -         return Key::Key(self.key.clone());
[INFO] [stdout] 187 +         Key::Key(self.key.clone())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:221:9
[INFO] [stdout]     |
[INFO] [stdout] 221 |         return field_scan.into();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 221 -         return field_scan.into();
[INFO] [stdout] 221 +         field_scan.into()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/struct_info/field_info.rs:193:45
[INFO] [stdout]     |
[INFO] [stdout] 193 |         let mut field_scan = FieldScan::new(&field);
[INFO] [stdout]     |                                             ^^^^^^ help: change this to: `field`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/field_info.rs:217:17
[INFO] [stdout]     |
[INFO] [stdout] 217 |                 return Ok(());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 217 -                 return Ok(());
[INFO] [stdout] 217 +                 Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]  --> src/struct_info/key.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 |     Key(String),
[INFO] [stdout]   |     ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]   = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/struct_info/mod.rs:84:9
[INFO] [stdout]    |
[INFO] [stdout] 84 |         return struct_info;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 84 -         return struct_info;
[INFO] [stdout] 84 +         struct_info
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/struct_info/mod.rs:63:21
[INFO] [stdout]    |
[INFO] [stdout] 63 |                     return Ok(());
[INFO] [stdout]    |                     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -                     return Ok(());
[INFO] [stdout] 63 +                     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used
[INFO] [stdout]   --> src/struct_info/mod.rs:79:38
[INFO] [stdout]    |
[INFO] [stdout] 79 |             struct_info.insert_field(FieldInfo::try_from(field).unwrap());
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: converting `&Field` to `FieldInfo` cannot fail
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 79 -             struct_info.insert_field(FieldInfo::try_from(field).unwrap());
[INFO] [stdout] 79 +             struct_info.insert_field(FieldInfo::from(field));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/struct_info/mod.rs:152:9
[INFO] [stdout]     |
[INFO] [stdout] 152 |         return pk.clone();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 152 -         return pk.clone();
[INFO] [stdout] 152 +         pk.clone()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator
[INFO] [stdout]    --> src/struct_info/mod.rs:164:9
[INFO] [stdout]     |
[INFO] [stdout] 164 | /         let Some(sk_field) = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_))) else {
[INFO] [stdout] 165 | |             return None;
[INFO] [stdout] 166 | |         };
[INFO] [stdout]     | |__________^ help: replace it with: `let sk_field = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_)))?;`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]     = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/struct_info/mod.rs:218:12
[INFO] [stdout]     |
[INFO] [stdout] 218 |         if !(struct_has_pk || struct_has_pk_value) && !field_has_pk {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(struct_has_pk || struct_has_pk_value || field_has_pk)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.96s
[INFO] running `Command { std: "docker" "inspect" "8decc8bd9c651e1f2791c3b5ed443ae23cb4c216a0d081c0a61b5db768022b83", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8decc8bd9c651e1f2791c3b5ed443ae23cb4c216a0d081c0a61b5db768022b83", kill_on_drop: false }`
[INFO] [stdout] 8decc8bd9c651e1f2791c3b5ed443ae23cb4c216a0d081c0a61b5db768022b83