[INFO] fetching crate dwarvish 0.0.1...
[INFO] linting dwarvish-0.0.1 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate dwarvish 0.0.1 into /workspace/builds/worker-5-tc1/source
[INFO] started tweaking crates.io crate dwarvish 0.0.1
[INFO] finished tweaking crates.io crate dwarvish 0.0.1
[INFO] tweaked toml for crates.io crate dwarvish 0.0.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate dwarvish 0.0.1 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate dwarvish 0.0.1 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 727daf2eb1473b471f0f70b6a964dc7f8ed07ba6bb7b51811f97cd7bad65af47
[INFO] running `Command { std: "docker" "start" "-a" "727daf2eb1473b471f0f70b6a964dc7f8ed07ba6bb7b51811f97cd7bad65af47", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "727daf2eb1473b471f0f70b6a964dc7f8ed07ba6bb7b51811f97cd7bad65af47", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "727daf2eb1473b471f0f70b6a964dc7f8ed07ba6bb7b51811f97cd7bad65af47", kill_on_drop: false }`
[INFO] [stdout] 727daf2eb1473b471f0f70b6a964dc7f8ed07ba6bb7b51811f97cd7bad65af47
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 4a099093138cab9f9889cd24df7ededb6802e2d7f33807415a437e6474ce549b
[INFO] running `Command { std: "docker" "start" "-a" "4a099093138cab9f9889cd24df7ededb6802e2d7f33807415a437e6474ce549b", kill_on_drop: false }`
[INFO] [stderr]    Compiling signal-hook v0.3.17
[INFO] [stderr]    Compiling dwarvish v0.0.1 (/opt/rustwide/workdir)
[INFO] [stderr]     Checking signal-hook-registry v1.4.1
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]  --> build.rs:6:19
[INFO] [stdout]   |
[INFO] [stdout] 6 |             .args(&["rev-parse", "HEAD"])
[INFO] [stdout]   |                   ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "HEAD"]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]   = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/path.rs:21:33
[INFO] [stdout]    |
[INFO] [stdout] 21 |     let path = env::var("PATH").unwrap_or(String::new());
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `while let` loop
[INFO] [stdout]   --> src/path.rs:24:5
[INFO] [stdout]    |
[INFO] [stdout] 24 | /     loop {
[INFO] [stdout] 25 | |         let p = match path.next() {
[INFO] [stdout] 26 | |             Some(p) => p,
[INFO] [stdout] 27 | |             None => break,
[INFO] [stdout] ...  |
[INFO] [stdout] 42 | |     }
[INFO] [stdout]    | |_____^ help: try: `while let Some(p) = path.next() { .. }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stdout]    = note: `#[warn(clippy::while_let_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::env::Vars`
[INFO] [stdout]   --> src/poem/anthology/export.rs:35:42
[INFO] [stdout]    |
[INFO] [stdout] 35 |             let sorted: BTreeMap<_, _> = env::vars().into_iter().collect();
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `env::vars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/poem/anthology/source.rs:43:47
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let poetry = match fs::read_to_string(&file) {
[INFO] [stdout]    |                                               ^^^^^ help: change this to: `file`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/poem/anthology.rs:30:31
[INFO] [stdout]    |
[INFO] [stdout] 30 |     INDEX.iter().position(|v| v.to_string() == verb)
[INFO] [stdout]    |                               ^^^^^^^^^^^^^ help: try: `*v`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this can be `std::io::Error::other(_)`
[INFO] [stdout]    --> src/poem/anthology.rs:193:25
[INFO] [stdout]     |
[INFO] [stdout] 193 |             None => Err(io::Error::new(io::ErrorKind::Other, "not spawned")),
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
[INFO] [stdout]     = note: `#[warn(clippy::io_other_error)]` on by default
[INFO] [stdout] help: use `std::io::Error::other`
[INFO] [stdout]     |
[INFO] [stdout] 193 -             None => Err(io::Error::new(io::ErrorKind::Other, "not spawned")),
[INFO] [stdout] 193 +             None => Err(io::Error::other("not spawned")),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: doc list item overindented
[INFO] [stdout]   --> src/poem/elements/verse.rs:78:9
[INFO] [stdout]    |
[INFO] [stdout] 78 |     ///               this command succeeds (`;` or a newline in a file)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^ help: try using `  ` (2 spaces)
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
[INFO] [stdout]    = note: `#[warn(clippy::doc_overindented_list_items)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/poem/elements/verse.rs:170:12
[INFO] [stdout]     |
[INFO] [stdout] 170 |         if self.poems.len() > 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.poems.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/poem/elements/verse.rs:264:36
[INFO] [stdout]     |
[INFO] [stdout] 264 |     pub fn spellcheck(&self, bins: &Vec<String>) -> Option<Spelling> {
[INFO] [stdout]     |                                    ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 264 -     pub fn spellcheck(&self, bins: &Vec<String>) -> Option<Spelling> {
[INFO] [stdout] 264 +     pub fn spellcheck(&self, bins: &[String]) -> Option<Spelling> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/poem/elements/verse.rs:275:9
[INFO] [stdout]     |
[INFO] [stdout] 275 | /         match i {
[INFO] [stdout] 276 | |             Some(i) => return Some(Spelling::BuiltIn(i)),
[INFO] [stdout] 277 | |             None => {}
[INFO] [stdout] 278 | |         };
[INFO] [stdout]     | |_________^ help: try: `if let Some(i) = i { return Some(Spelling::BuiltIn(i)) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/poem/elements/verse.rs:286:20
[INFO] [stdout]     |
[INFO] [stdout] 286 |                 if path.split('/').last().unwrap() == self.verb() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 286 -                 if path.split('/').last().unwrap() == self.verb() {
[INFO] [stdout] 286 +                 if path.split('/').next_back().unwrap() == self.verb() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]   --> src/poem/read/parse.rs:34:18
[INFO] [stdout]    |
[INFO] [stdout] 34 |         for c in s[j..].chars().into_iter() {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s[j..].chars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/poem/read.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     ParseMishap(usize, usize, char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/poem/read.rs:27:5
[INFO] [stdout]    |
[INFO] [stdout] 27 |     IOMishap(usize, usize, char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/poem/read.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     PartialMishap(usize, usize, char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: all variants have the same postfix: `Mishap`
[INFO] [stdout]   --> src/poem/read.rs:13:1
[INFO] [stdout]    |
[INFO] [stdout] 13 | / pub enum Mishap {
[INFO] [stdout] 14 | |     /// Generic parser error
[INFO] [stdout] 15 | |     ParseMishap(usize, usize, char),
[INFO] [stdout] ...  |
[INFO] [stdout] 40 | |     PartialMishap(usize, usize, char),
[INFO] [stdout] 41 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]    --> src/poem/read.rs:192:25
[INFO] [stdout]     |
[INFO] [stdout] 192 |         let mut chars = poetry.chars().into_iter();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `poetry.chars()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/poem/recite.rs:155:20
[INFO] [stdout]     |
[INFO] [stdout] 155 |                 if !spell.is_some() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^ help: try: `spell.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/poem/recite.rs:158:24
[INFO] [stdout]     |
[INFO] [stdout] 158 |                     if !spell.is_some() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: try: `spell.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `j` is used as a loop counter
[INFO] [stdout]   --> src/poem/recite.rs:91:17
[INFO] [stdout]    |
[INFO] [stdout] 91 |                 for wordp in wordps {
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, wordp) in wordps.into_iter().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/poem/recite.rs:107:33
[INFO] [stdout]     |
[INFO] [stdout] 107 | / ...                   if *last == b'\n' {
[INFO] [stdout] 108 | | ...                       out.remove(out.len() - 1);
[INFO] [stdout] 109 | | ...                   }
[INFO] [stdout]     | |_______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 106 ~                             Some(last)
[INFO] [stdout] 107 ~                                 if *last == b'\n' => {
[INFO] [stdout] 108 |                                     out.remove(out.len() - 1);
[INFO] [stdout] 109 ~                                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/poem/recite.rs:105:25
[INFO] [stdout]     |
[INFO] [stdout] 105 | /                         match out.last() {
[INFO] [stdout] 106 | |                             Some(last) => {
[INFO] [stdout] 107 | |                                 if *last == b'\n' {
[INFO] [stdout] 108 | |                                     out.remove(out.len() - 1);
[INFO] [stdout] ...   |
[INFO] [stdout] 111 | |                             None => {}
[INFO] [stdout] 112 | |                         }
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 105 ~                         if let Some(last) = out.last() {
[INFO] [stdout] 106 +                             if *last == b'\n' {
[INFO] [stdout] 107 +                                 out.remove(out.len() - 1);
[INFO] [stdout] 108 +                             }
[INFO] [stdout] 109 +                         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/poem/recite.rs:140:13
[INFO] [stdout]     |
[INFO] [stdout] 140 | /             match new_stanza {
[INFO] [stdout] 141 | |                 Some(stanza) => {
[INFO] [stdout] 142 | |                     let mut stanza = stanza.clone();
[INFO] [stdout] 143 | |                     verse.stanza.append(&mut stanza);
[INFO] [stdout] 144 | |                 }
[INFO] [stdout] 145 | |                 None => {}
[INFO] [stdout] 146 | |             };
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 140 ~             if let Some(stanza) = new_stanza {
[INFO] [stdout] 141 +                 let mut stanza = stanza.clone();
[INFO] [stdout] 142 +                 verse.stanza.append(&mut stanza);
[INFO] [stdout] 143 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/compose.rs:87:13
[INFO] [stdout]    |
[INFO] [stdout] 87 |             return;
[INFO] [stdout]    |             ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -             eprintln!("dwvsh: {}", e.to_string().to_lowercase());
[INFO] [stdout] 87 -             return;
[INFO] [stdout] 86 +             eprintln!("dwvsh: {}", e.to_string().to_lowercase());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless `fn main` in doctest
[INFO] [stdout]   --> src/main.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /// fn main() {
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main
[INFO] [stdout]    = note: `#[warn(clippy::needless_doctest_main)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/main.rs:100:13
[INFO] [stdout]     |
[INFO] [stdout] 100 | /             if args.len() > 1 && !arg.starts_with('-') {
[INFO] [stdout] 101 | |                 let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] 102 | |                     .expect(format!("dwvsh: can't open input file: {}", arg).as_str());
[INFO] [stdout] 103 | |                 let poem = Poem::read(poetry, env);
[INFO] [stdout] ...   |
[INFO] [stdout] 119 | |                 std::process::exit(0);
[INFO] [stdout] 120 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  99 ~         Some(arg)
[INFO] [stdout] 100 ~             if args.len() > 1 && !arg.starts_with('-') => {
[INFO] [stdout] 101 |                 let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] ...
[INFO] [stdout] 119 |                 std::process::exit(0);
[INFO] [stdout] 120 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:98:5
[INFO] [stdout]     |
[INFO] [stdout]  98 | /     match args.last() {
[INFO] [stdout]  99 | |         Some(arg) => {
[INFO] [stdout] 100 | |             if args.len() > 1 && !arg.starts_with('-') {
[INFO] [stdout] 101 | |                 let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] ...   |
[INFO] [stdout] 122 | |         None => {}
[INFO] [stdout] 123 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  98 ~     if let Some(arg) = args.last() {
[INFO] [stdout]  99 +         if args.len() > 1 && !arg.starts_with('-') {
[INFO] [stdout] 100 +             let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] 101 +                 .expect(format!("dwvsh: can't open input file: {}", arg).as_str());
[INFO] [stdout] 102 +             let poem = Poem::read(poetry, env);
[INFO] [stdout] 103 +             let poem = match poem {
[INFO] [stdout] 104 +                 Ok(poem) => poem,
[INFO] [stdout] 105 +                 Err(e) => {
[INFO] [stdout] 106 +                     eprintln!("dwvsh: {}", e.to_string().to_lowercase());
[INFO] [stdout] 107 +                     std::process::exit(1);
[INFO] [stdout] 108 +                 }
[INFO] [stdout] 109 +             };
[INFO] [stdout] 110 + 
[INFO] [stdout] 111 +             // Recite the poem
[INFO] [stdout] 112 +             match poem.recite(env) {
[INFO] [stdout] 113 +                 Ok(_) => {}
[INFO] [stdout] 114 +                 Err(e) => eprintln!("dwvsh: {}", e.to_string().to_lowercase()),
[INFO] [stdout] 115 +             }
[INFO] [stdout] 116 + 
[INFO] [stdout] 117 +             // Quit
[INFO] [stdout] 118 +             std::process::exit(0);
[INFO] [stdout] 119 +         }
[INFO] [stdout] 120 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]    --> src/main.rs:102:22
[INFO] [stdout]     |
[INFO] [stdout] 102 |                     .expect(format!("dwvsh: can't open input file: {}", arg).as_str());
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("dwvsh: can't open input file: {}", arg))`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]     = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/path.rs:21:33
[INFO] [stdout]    |
[INFO] [stdout] 21 |     let path = env::var("PATH").unwrap_or(String::new());
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `while let` loop
[INFO] [stdout]   --> src/path.rs:24:5
[INFO] [stdout]    |
[INFO] [stdout] 24 | /     loop {
[INFO] [stdout] 25 | |         let p = match path.next() {
[INFO] [stdout] 26 | |             Some(p) => p,
[INFO] [stdout] 27 | |             None => break,
[INFO] [stdout] ...  |
[INFO] [stdout] 42 | |     }
[INFO] [stdout]    | |_____^ help: try: `while let Some(p) = path.next() { .. }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stdout]    = note: `#[warn(clippy::while_let_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::env::Vars`
[INFO] [stdout]   --> src/poem/anthology/export.rs:35:42
[INFO] [stdout]    |
[INFO] [stdout] 35 |             let sorted: BTreeMap<_, _> = env::vars().into_iter().collect();
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `env::vars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/poem/anthology/source.rs:43:47
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let poetry = match fs::read_to_string(&file) {
[INFO] [stdout]    |                                               ^^^^^ help: change this to: `file`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/poem/anthology.rs:30:31
[INFO] [stdout]    |
[INFO] [stdout] 30 |     INDEX.iter().position(|v| v.to_string() == verb)
[INFO] [stdout]    |                               ^^^^^^^^^^^^^ help: try: `*v`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this can be `std::io::Error::other(_)`
[INFO] [stdout]    --> src/poem/anthology.rs:193:25
[INFO] [stdout]     |
[INFO] [stdout] 193 |             None => Err(io::Error::new(io::ErrorKind::Other, "not spawned")),
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
[INFO] [stdout]     = note: `#[warn(clippy::io_other_error)]` on by default
[INFO] [stdout] help: use `std::io::Error::other`
[INFO] [stdout]     |
[INFO] [stdout] 193 -             None => Err(io::Error::new(io::ErrorKind::Other, "not spawned")),
[INFO] [stdout] 193 +             None => Err(io::Error::other("not spawned")),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: doc list item overindented
[INFO] [stdout]   --> src/poem/elements/verse.rs:78:9
[INFO] [stdout]    |
[INFO] [stdout] 78 |     ///               this command succeeds (`;` or a newline in a file)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^ help: try using `  ` (2 spaces)
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
[INFO] [stdout]    = note: `#[warn(clippy::doc_overindented_list_items)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/poem/elements/verse.rs:170:12
[INFO] [stdout]     |
[INFO] [stdout] 170 |         if self.poems.len() > 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.poems.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/poem/elements/verse.rs:264:36
[INFO] [stdout]     |
[INFO] [stdout] 264 |     pub fn spellcheck(&self, bins: &Vec<String>) -> Option<Spelling> {
[INFO] [stdout]     |                                    ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 264 -     pub fn spellcheck(&self, bins: &Vec<String>) -> Option<Spelling> {
[INFO] [stdout] 264 +     pub fn spellcheck(&self, bins: &[String]) -> Option<Spelling> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/poem/elements/verse.rs:275:9
[INFO] [stdout]     |
[INFO] [stdout] 275 | /         match i {
[INFO] [stdout] 276 | |             Some(i) => return Some(Spelling::BuiltIn(i)),
[INFO] [stdout] 277 | |             None => {}
[INFO] [stdout] 278 | |         };
[INFO] [stdout]     | |_________^ help: try: `if let Some(i) = i { return Some(Spelling::BuiltIn(i)) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/poem/elements/verse.rs:286:20
[INFO] [stdout]     |
[INFO] [stdout] 286 |                 if path.split('/').last().unwrap() == self.verb() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 286 -                 if path.split('/').last().unwrap() == self.verb() {
[INFO] [stdout] 286 +                 if path.split('/').next_back().unwrap() == self.verb() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]   --> src/poem/read/parse.rs:34:18
[INFO] [stdout]    |
[INFO] [stdout] 34 |         for c in s[j..].chars().into_iter() {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s[j..].chars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/poem/read.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     ParseMishap(usize, usize, char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/poem/read.rs:27:5
[INFO] [stdout]    |
[INFO] [stdout] 27 |     IOMishap(usize, usize, char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/poem/read.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     PartialMishap(usize, usize, char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: all variants have the same postfix: `Mishap`
[INFO] [stdout]   --> src/poem/read.rs:13:1
[INFO] [stdout]    |
[INFO] [stdout] 13 | / pub enum Mishap {
[INFO] [stdout] 14 | |     /// Generic parser error
[INFO] [stdout] 15 | |     ParseMishap(usize, usize, char),
[INFO] [stdout] ...  |
[INFO] [stdout] 40 | |     PartialMishap(usize, usize, char),
[INFO] [stdout] 41 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]    --> src/poem/read.rs:192:25
[INFO] [stdout]     |
[INFO] [stdout] 192 |         let mut chars = poetry.chars().into_iter();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `poetry.chars()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/poem/recite.rs:155:20
[INFO] [stdout]     |
[INFO] [stdout] 155 |                 if !spell.is_some() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^ help: try: `spell.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/poem/recite.rs:158:24
[INFO] [stdout]     |
[INFO] [stdout] 158 |                     if !spell.is_some() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: try: `spell.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `j` is used as a loop counter
[INFO] [stdout]   --> src/poem/recite.rs:91:17
[INFO] [stdout]    |
[INFO] [stdout] 91 |                 for wordp in wordps {
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, wordp) in wordps.into_iter().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/poem/recite.rs:107:33
[INFO] [stdout]     |
[INFO] [stdout] 107 | / ...                   if *last == b'\n' {
[INFO] [stdout] 108 | | ...                       out.remove(out.len() - 1);
[INFO] [stdout] 109 | | ...                   }
[INFO] [stdout]     | |_______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 106 ~                             Some(last)
[INFO] [stdout] 107 ~                                 if *last == b'\n' => {
[INFO] [stdout] 108 |                                     out.remove(out.len() - 1);
[INFO] [stdout] 109 ~                                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/poem/recite.rs:105:25
[INFO] [stdout]     |
[INFO] [stdout] 105 | /                         match out.last() {
[INFO] [stdout] 106 | |                             Some(last) => {
[INFO] [stdout] 107 | |                                 if *last == b'\n' {
[INFO] [stdout] 108 | |                                     out.remove(out.len() - 1);
[INFO] [stdout] ...   |
[INFO] [stdout] 111 | |                             None => {}
[INFO] [stdout] 112 | |                         }
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 105 ~                         if let Some(last) = out.last() {
[INFO] [stdout] 106 +                             if *last == b'\n' {
[INFO] [stdout] 107 +                                 out.remove(out.len() - 1);
[INFO] [stdout] 108 +                             }
[INFO] [stdout] 109 +                         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/poem/recite.rs:140:13
[INFO] [stdout]     |
[INFO] [stdout] 140 | /             match new_stanza {
[INFO] [stdout] 141 | |                 Some(stanza) => {
[INFO] [stdout] 142 | |                     let mut stanza = stanza.clone();
[INFO] [stdout] 143 | |                     verse.stanza.append(&mut stanza);
[INFO] [stdout] 144 | |                 }
[INFO] [stdout] 145 | |                 None => {}
[INFO] [stdout] 146 | |             };
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 140 ~             if let Some(stanza) = new_stanza {
[INFO] [stdout] 141 +                 let mut stanza = stanza.clone();
[INFO] [stdout] 142 +                 verse.stanza.append(&mut stanza);
[INFO] [stdout] 143 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/poem.rs:401:9
[INFO] [stdout]     |
[INFO] [stdout] 401 |         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 401 -         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout] 401 +         assert!(Poem::read(poetry, &mut Environment::new()).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/poem.rs:404:9
[INFO] [stdout]     |
[INFO] [stdout] 404 |         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 404 -         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout] 404 +         assert!(Poem::read(poetry, &mut Environment::new()).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/poem.rs:407:9
[INFO] [stdout]     |
[INFO] [stdout] 407 |         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 407 -         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout] 407 +         assert!(Poem::read(poetry, &mut Environment::new()).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/poem.rs:413:9
[INFO] [stdout]     |
[INFO] [stdout] 413 |         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 413 -         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout] 413 +         assert!(Poem::read(poetry, &mut Environment::new()).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/poem.rs:416:9
[INFO] [stdout]     |
[INFO] [stdout] 416 |         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 416 -         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout] 416 +         assert!(Poem::read(poetry, &mut Environment::new()).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/poem.rs:419:9
[INFO] [stdout]     |
[INFO] [stdout] 419 |         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 419 -         assert_eq!(Poem::read(poetry, &mut Environment::new()).is_err(), true);
[INFO] [stdout] 419 +         assert!(Poem::read(poetry, &mut Environment::new()).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/compose.rs:87:13
[INFO] [stdout]    |
[INFO] [stdout] 87 |             return;
[INFO] [stdout]    |             ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -             eprintln!("dwvsh: {}", e.to_string().to_lowercase());
[INFO] [stdout] 87 -             return;
[INFO] [stdout] 86 +             eprintln!("dwvsh: {}", e.to_string().to_lowercase());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless `fn main` in doctest
[INFO] [stdout]   --> src/main.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /// fn main() {
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main
[INFO] [stdout]    = note: `#[warn(clippy::needless_doctest_main)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/main.rs:100:13
[INFO] [stdout]     |
[INFO] [stdout] 100 | /             if args.len() > 1 && !arg.starts_with('-') {
[INFO] [stdout] 101 | |                 let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] 102 | |                     .expect(format!("dwvsh: can't open input file: {}", arg).as_str());
[INFO] [stdout] 103 | |                 let poem = Poem::read(poetry, env);
[INFO] [stdout] ...   |
[INFO] [stdout] 119 | |                 std::process::exit(0);
[INFO] [stdout] 120 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  99 ~         Some(arg)
[INFO] [stdout] 100 ~             if args.len() > 1 && !arg.starts_with('-') => {
[INFO] [stdout] 101 |                 let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] ...
[INFO] [stdout] 119 |                 std::process::exit(0);
[INFO] [stdout] 120 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:98:5
[INFO] [stdout]     |
[INFO] [stdout]  98 | /     match args.last() {
[INFO] [stdout]  99 | |         Some(arg) => {
[INFO] [stdout] 100 | |             if args.len() > 1 && !arg.starts_with('-') {
[INFO] [stdout] 101 | |                 let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] ...   |
[INFO] [stdout] 122 | |         None => {}
[INFO] [stdout] 123 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  98 ~     if let Some(arg) = args.last() {
[INFO] [stdout]  99 +         if args.len() > 1 && !arg.starts_with('-') {
[INFO] [stdout] 100 +             let poetry = std::fs::read_to_string(arg)
[INFO] [stdout] 101 +                 .expect(format!("dwvsh: can't open input file: {}", arg).as_str());
[INFO] [stdout] 102 +             let poem = Poem::read(poetry, env);
[INFO] [stdout] 103 +             let poem = match poem {
[INFO] [stdout] 104 +                 Ok(poem) => poem,
[INFO] [stdout] 105 +                 Err(e) => {
[INFO] [stdout] 106 +                     eprintln!("dwvsh: {}", e.to_string().to_lowercase());
[INFO] [stdout] 107 +                     std::process::exit(1);
[INFO] [stdout] 108 +                 }
[INFO] [stdout] 109 +             };
[INFO] [stdout] 110 + 
[INFO] [stdout] 111 +             // Recite the poem
[INFO] [stdout] 112 +             match poem.recite(env) {
[INFO] [stdout] 113 +                 Ok(_) => {}
[INFO] [stdout] 114 +                 Err(e) => eprintln!("dwvsh: {}", e.to_string().to_lowercase()),
[INFO] [stdout] 115 +             }
[INFO] [stdout] 116 + 
[INFO] [stdout] 117 +             // Quit
[INFO] [stdout] 118 +             std::process::exit(0);
[INFO] [stdout] 119 +         }
[INFO] [stdout] 120 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]    --> src/main.rs:102:22
[INFO] [stdout]     |
[INFO] [stdout] 102 |                     .expect(format!("dwvsh: can't open input file: {}", arg).as_str());
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("dwvsh: can't open input file: {}", arg))`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]     = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/poem.rs:73:13
[INFO] [stdout]    |
[INFO] [stdout] 73 |             vec!["lolcat"]
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: you can use an array directly: `["lolcat"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]    = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/poem.rs:80:13
[INFO] [stdout]    |
[INFO] [stdout] 80 |             vec!["src/main.rs"]
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["src/main.rs"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/poem.rs:99:13
[INFO] [stdout]    |
[INFO] [stdout] 99 |             vec!["cat", "src/main.rs"]
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cat", "src/main.rs"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:106:13
[INFO] [stdout]     |
[INFO] [stdout] 106 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:125:13
[INFO] [stdout]     |
[INFO] [stdout] 125 |             vec!["cat", "src/main.rs"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cat", "src/main.rs"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:132:13
[INFO] [stdout]     |
[INFO] [stdout] 132 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:151:13
[INFO] [stdout]     |
[INFO] [stdout] 151 |             vec!["cat", "src/main.rs"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cat", "src/main.rs"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:158:13
[INFO] [stdout]     |
[INFO] [stdout] 158 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:165:13
[INFO] [stdout]     |
[INFO] [stdout] 165 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:184:13
[INFO] [stdout]     |
[INFO] [stdout] 184 |             vec!["cat", "src/main.rs"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cat", "src/main.rs"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:191:13
[INFO] [stdout]     |
[INFO] [stdout] 191 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:210:13
[INFO] [stdout]     |
[INFO] [stdout] 210 |             vec!["cat", "src/main.rs"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cat", "src/main.rs"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:217:13
[INFO] [stdout]     |
[INFO] [stdout] 217 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:236:13
[INFO] [stdout]     |
[INFO] [stdout] 236 |             vec!["cat", "src/main.rs"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cat", "src/main.rs"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:243:13
[INFO] [stdout]     |
[INFO] [stdout] 243 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/poem.rs:250:13
[INFO] [stdout]     |
[INFO] [stdout] 250 |             vec!["/dev/null"]
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["/dev/null"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.30s
[INFO] running `Command { std: "docker" "inspect" "4a099093138cab9f9889cd24df7ededb6802e2d7f33807415a437e6474ce549b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "4a099093138cab9f9889cd24df7ededb6802e2d7f33807415a437e6474ce549b", kill_on_drop: false }`
[INFO] [stdout] 4a099093138cab9f9889cd24df7ededb6802e2d7f33807415a437e6474ce549b