[INFO] fetching crate dummy-library- 0.0.2... [INFO] linting dummy-library--0.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate dummy-library- 0.0.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate dummy-library- 0.0.2 [INFO] finished tweaking crates.io crate dummy-library- 0.0.2 [INFO] tweaked toml for crates.io crate dummy-library- 0.0.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate dummy-library- 0.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78dac68ea6610ea1eb2c3cd522fa91e3f1b3680d622e8569b6b13af7dee3ff2d [INFO] running `Command { std: "docker" "start" "-a" "78dac68ea6610ea1eb2c3cd522fa91e3f1b3680d622e8569b6b13af7dee3ff2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78dac68ea6610ea1eb2c3cd522fa91e3f1b3680d622e8569b6b13af7dee3ff2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78dac68ea6610ea1eb2c3cd522fa91e3f1b3680d622e8569b6b13af7dee3ff2d", kill_on_drop: false }` [INFO] [stdout] 78dac68ea6610ea1eb2c3cd522fa91e3f1b3680d622e8569b6b13af7dee3ff2d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24d4cc95f2d2a65af04b31ee06e6afc5a122d27c44392ee1fd3da832816cd8b8 [INFO] running `Command { std: "docker" "start" "-a" "24d4cc95f2d2a65af04b31ee06e6afc5a122d27c44392ee1fd3da832816cd8b8", kill_on_drop: false }` [INFO] [stderr] Checking dummy-library- v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/i128.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if !(r > 0 && z >= 0) { [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if r <= 0 || z < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return match x.checked_mul(y) { [INFO] [stdout] 24 | | Some(r) => r.checked_div(z), [INFO] [stdout] 25 | | None => { [INFO] [stdout] 26 | | let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] ... | [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ match x.checked_mul(y) { [INFO] [stdout] 24 + Some(r) => r.checked_div(z), [INFO] [stdout] 25 + None => { [INFO] [stdout] 26 + let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] 27 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 28 + return None; [INFO] [stdout] 29 + } [INFO] [stdout] 30 + Some(res_u128 as u64) [INFO] [stdout] 31 + } [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / return match x.checked_mul(y) { [INFO] [stdout] 38 | | Some(r) => { [INFO] [stdout] 39 | | let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] ... | [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ match x.checked_mul(y) { [INFO] [stdout] 38 + Some(r) => { [INFO] [stdout] 39 + let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] 40 + // div overflow will be caught by checked_rem_euclid [INFO] [stdout] 41 + (r / z).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 42 + } [INFO] [stdout] 43 + None => { [INFO] [stdout] 44 + // TODO: safe cast [INFO] [stdout] 45 + let r_u128 = (x as u128).checked_mul(y as u128)?; [INFO] [stdout] 46 + let remainder = r_u128.checked_rem_euclid(z as u128)?; [INFO] [stdout] 47 + let res_u128 = r_u128 / (z as u128); [INFO] [stdout] 48 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 49 + return None; [INFO] [stdout] 50 + } [INFO] [stdout] 51 + (res_u128 as u64).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 52 + } [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/i128.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if !(r > 0 && z >= 0) { [INFO] [stdout] | [INFO] [stdout] 40 - if r <= 0 || (r > 0 && z < 0) { [INFO] [stdout] 40 + if r <= 0 || z < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return match x.checked_mul(y) { [INFO] [stdout] 24 | | Some(r) => r.checked_div(z), [INFO] [stdout] 25 | | None => { [INFO] [stdout] 26 | | let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] ... | [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ match x.checked_mul(y) { [INFO] [stdout] 24 + Some(r) => r.checked_div(z), [INFO] [stdout] 25 + None => { [INFO] [stdout] 26 + let res_u128 = (x as u128).checked_mul(y as u128)?.checked_div(z as u128)?; [INFO] [stdout] 27 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 28 + return None; [INFO] [stdout] 29 + } [INFO] [stdout] 30 + Some(res_u128 as u64) [INFO] [stdout] 31 + } [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u64.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / return match x.checked_mul(y) { [INFO] [stdout] 38 | | Some(r) => { [INFO] [stdout] 39 | | let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] ... | [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ match x.checked_mul(y) { [INFO] [stdout] 38 + Some(r) => { [INFO] [stdout] 39 + let remainder = r.checked_rem_euclid(z)?; [INFO] [stdout] 40 + // div overflow will be caught by checked_rem_euclid [INFO] [stdout] 41 + (r / z).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 42 + } [INFO] [stdout] 43 + None => { [INFO] [stdout] 44 + // TODO: safe cast [INFO] [stdout] 45 + let r_u128 = (x as u128).checked_mul(y as u128)?; [INFO] [stdout] 46 + let remainder = r_u128.checked_rem_euclid(z as u128)?; [INFO] [stdout] 47 + let res_u128 = r_u128 / (z as u128); [INFO] [stdout] 48 + if res_u128 > u64::MAX as u128 { [INFO] [stdout] 49 + return None; [INFO] [stdout] 50 + } [INFO] [stdout] 51 + (res_u128 as u64).checked_add(if remainder > 0 { 1 } else { 0 }) [INFO] [stdout] 52 + } [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s [INFO] running `Command { std: "docker" "inspect" "24d4cc95f2d2a65af04b31ee06e6afc5a122d27c44392ee1fd3da832816cd8b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24d4cc95f2d2a65af04b31ee06e6afc5a122d27c44392ee1fd3da832816cd8b8", kill_on_drop: false }` [INFO] [stdout] 24d4cc95f2d2a65af04b31ee06e6afc5a122d27c44392ee1fd3da832816cd8b8