[INFO] fetching crate duid-core 0.1.0... [INFO] linting duid-core-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate duid-core 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate duid-core 0.1.0 [INFO] finished tweaking crates.io crate duid-core 0.1.0 [INFO] tweaked toml for crates.io crate duid-core 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate duid-core 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding console_log v0.2.2 (available: v1.0.0) [INFO] [stderr] Adding jss v0.5.1 (available: v0.6.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded indextree-macros v0.1.3 [INFO] [stderr] Downloaded jss v0.5.1 [INFO] [stderr] Downloaded indextree v4.7.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff28445432d7cb92731992abb5edc5eeae8e43f5fed194562bb3938862fa5a3c [INFO] running `Command { std: "docker" "start" "-a" "ff28445432d7cb92731992abb5edc5eeae8e43f5fed194562bb3938862fa5a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff28445432d7cb92731992abb5edc5eeae8e43f5fed194562bb3938862fa5a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff28445432d7cb92731992abb5edc5eeae8e43f5fed194562bb3938862fa5a3c", kill_on_drop: false }` [INFO] [stdout] ff28445432d7cb92731992abb5edc5eeae8e43f5fed194562bb3938862fa5a3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4a039d5de81b0a14f2e3d76e08d07860540d0afb746dedbb9febd43d8542710 [INFO] running `Command { std: "docker" "start" "-a" "a4a039d5de81b0a14f2e3d76e08d07860540d0afb746dedbb9febd43d8542710", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.114 [INFO] [stderr] Compiling bumpalo v3.20.2 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling wasm-bindgen v0.2.114 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.64 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking wasm-bindgen-test-shared v0.2.114 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.114 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling strum v0.27.2 [INFO] [stderr] Compiling indextree-macros v0.1.3 [INFO] [stderr] Checking indextree v4.7.4 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.114 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking js-sys v0.3.91 [INFO] [stderr] Checking jss v0.5.1 [INFO] [stderr] Checking web-sys v0.3.91 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.64 [INFO] [stderr] Checking wasm-bindgen-test v0.3.64 [INFO] [stderr] Checking console_log v0.2.2 [INFO] [stderr] Checking duid-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:240:7 [INFO] [stdout] | [INFO] [stdout] 240 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:278:11 [INFO] [stdout] | [INFO] [stdout] 278 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:280:11 [INFO] [stdout] | [INFO] [stdout] 280 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/attributes/attribute_macros.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | / declare_html_attributes! { [INFO] [stdout] 75 | | accept; [INFO] [stdout] 76 | | accesskey; [INFO] [stdout] 77 | | action; [INFO] [stdout] ... | [INFO] [stdout] 189 | | wrap; [INFO] [stdout] 190 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_html_attributes` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/attributes/attribute_macros.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 192 | / declare_html_attributes_special! { [INFO] [stdout] 193 | | accept_charset => "accept-charset"; [INFO] [stdout] 194 | | [INFO] [stdout] 195 | | r#async => "async"; [INFO] [stdout] ... | [INFO] [stdout] 205 | | r#type => "type"; [INFO] [stdout] 206 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_html_attributes_special` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/core/html/attributes/attribute_macros.rs:18:47 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn $name(v: V) -> crate::core::html::attributes::Attribute [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-dom` [INFO] [stdout] --> src/core/html/attributes/mod.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | #[cfg(not(feature = "with-dom"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-dom` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-dom` [INFO] [stdout] --> src/core/html/attributes/mod.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | #[cfg(feature = "with-dom")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-dom` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 77 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | / declare_common_tags_and_macro! { [INFO] [stdout] 119 | | head; [INFO] [stdout] 120 | | body; [INFO] [stdout] 121 | | address; [INFO] [stdout] ... | [INFO] [stdout] 216 | | template; [INFO] [stdout] 217 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_common_tags_and_macro` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 219 | / declare_tags_non_common! { [INFO] [stdout] 220 | | style; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_tags_non_common` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 113 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 223 | / declare_tags_and_macro_non_common! { [INFO] [stdout] 224 | | title; [INFO] [stdout] 225 | | slot; [INFO] [stdout] 226 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_tags_and_macro_non_common` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:64:15 [INFO] [stdout] | [INFO] [stdout] 64 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 228 | / declare_sc_tags! { [INFO] [stdout] 229 | | area; [INFO] [stdout] 230 | | base; [INFO] [stdout] 231 | | br; [INFO] [stdout] ... | [INFO] [stdout] 244 | | wbr; [INFO] [stdout] 245 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_sc_tags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/attributes.rs:36:15 [INFO] [stdout] | [INFO] [stdout] 36 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | / declare_svg_attributes! { [INFO] [stdout] 55 | | accumulate; [INFO] [stdout] 56 | | additive; [INFO] [stdout] 57 | | allowReorder; [INFO] [stdout] ... | [INFO] [stdout] 223 | | zoomAndPan; [INFO] [stdout] 224 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_attributes` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/attributes.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 226 | / declare_svg_attributes_special! { [INFO] [stdout] 227 | | accent_height => "accent-height"; [INFO] [stdout] 228 | | alignment_baseline => "alignment-baseline"; [INFO] [stdout] 229 | | arabic_form => "arabic-form"; [INFO] [stdout] ... | [INFO] [stdout] 302 | | in_ => "in"; [INFO] [stdout] 303 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_attributes_special` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/attributes.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 305 | / declare_xlink_attributes! { [INFO] [stdout] 306 | | xlink_actuate => "actuate"; [INFO] [stdout] 307 | | xlink_arcrole => "arcrole"; [INFO] [stdout] 308 | | xlink_href => "href"; [INFO] [stdout] ... | [INFO] [stdout] 312 | | xlink_type => "type"; [INFO] [stdout] 313 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_xlink_attributes` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:240:7 [INFO] [stdout] | [INFO] [stdout] 240 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:278:11 [INFO] [stdout] | [INFO] [stdout] 278 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `web_sys_unstable_apis` [INFO] [stdout] --> src/core/events/mod.rs:280:11 [INFO] [stdout] | [INFO] [stdout] 280 | #[cfg(web_sys_unstable_apis)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(web_sys_unstable_apis)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(web_sys_unstable_apis)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/tags.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | / declare_common_svg_tags_and_macro! { [INFO] [stdout] 101 | | animate; [INFO] [stdout] 102 | | animateMotion; [INFO] [stdout] 103 | | animateTransform; [INFO] [stdout] ... | [INFO] [stdout] 166 | | view; [INFO] [stdout] 167 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_common_svg_tags_and_macro` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/tags.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 168 | / declare_svg_tags_special! { [INFO] [stdout] 169 | | color_profile => "color-profile"; [INFO] [stdout] 170 | | r#use => "use"; [INFO] [stdout] 171 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_tags_special` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/tags.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | / declare_svg_tags_non_common! { [INFO] [stdout] 174 | | script; [INFO] [stdout] 175 | | style; [INFO] [stdout] 176 | | text; [INFO] [stdout] 177 | | a; [INFO] [stdout] 178 | | title; [INFO] [stdout] 179 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_tags_non_common` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/attributes/attribute_macros.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | / declare_html_attributes! { [INFO] [stdout] 75 | | accept; [INFO] [stdout] 76 | | accesskey; [INFO] [stdout] 77 | | action; [INFO] [stdout] ... | [INFO] [stdout] 189 | | wrap; [INFO] [stdout] 190 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_html_attributes` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/attributes/attribute_macros.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 192 | / declare_html_attributes_special! { [INFO] [stdout] 193 | | accept_charset => "accept-charset"; [INFO] [stdout] 194 | | [INFO] [stdout] 195 | | r#async => "async"; [INFO] [stdout] ... | [INFO] [stdout] 205 | | r#type => "type"; [INFO] [stdout] 206 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_html_attributes_special` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/core/html/attributes/attribute_macros.rs:18:47 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn $name(v: V) -> crate::core::html::attributes::Attribute [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-dom` [INFO] [stdout] --> src/core/html/attributes/mod.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | #[cfg(not(feature = "with-dom"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-dom` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-dom` [INFO] [stdout] --> src/core/html/attributes/mod.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | #[cfg(feature = "with-dom")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-dom` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 77 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | / declare_common_tags_and_macro! { [INFO] [stdout] 119 | | head; [INFO] [stdout] 120 | | body; [INFO] [stdout] 121 | | address; [INFO] [stdout] ... | [INFO] [stdout] 216 | | template; [INFO] [stdout] 217 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_common_tags_and_macro` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 219 | / declare_tags_non_common! { [INFO] [stdout] 220 | | style; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_tags_non_common` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 113 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 223 | / declare_tags_and_macro_non_common! { [INFO] [stdout] 224 | | title; [INFO] [stdout] 225 | | slot; [INFO] [stdout] 226 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_tags_and_macro_non_common` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/html/tags.rs:64:15 [INFO] [stdout] | [INFO] [stdout] 64 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 228 | / declare_sc_tags! { [INFO] [stdout] 229 | | area; [INFO] [stdout] 230 | | base; [INFO] [stdout] 231 | | br; [INFO] [stdout] ... | [INFO] [stdout] 244 | | wbr; [INFO] [stdout] 245 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_sc_tags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/attributes.rs:36:15 [INFO] [stdout] | [INFO] [stdout] 36 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | / declare_svg_attributes! { [INFO] [stdout] 55 | | accumulate; [INFO] [stdout] 56 | | additive; [INFO] [stdout] 57 | | allowReorder; [INFO] [stdout] ... | [INFO] [stdout] 223 | | zoomAndPan; [INFO] [stdout] 224 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_attributes` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/attributes.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 226 | / declare_svg_attributes_special! { [INFO] [stdout] 227 | | accent_height => "accent-height"; [INFO] [stdout] 228 | | alignment_baseline => "alignment-baseline"; [INFO] [stdout] 229 | | arabic_form => "arabic-form"; [INFO] [stdout] ... | [INFO] [stdout] 302 | | in_ => "in"; [INFO] [stdout] 303 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_attributes_special` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/attributes.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 305 | / declare_xlink_attributes! { [INFO] [stdout] 306 | | xlink_actuate => "actuate"; [INFO] [stdout] 307 | | xlink_arcrole => "arcrole"; [INFO] [stdout] 308 | | xlink_href => "href"; [INFO] [stdout] ... | [INFO] [stdout] 312 | | xlink_type => "type"; [INFO] [stdout] 313 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_xlink_attributes` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/tags.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | / declare_common_svg_tags_and_macro! { [INFO] [stdout] 101 | | animate; [INFO] [stdout] 102 | | animateMotion; [INFO] [stdout] 103 | | animateTransform; [INFO] [stdout] ... | [INFO] [stdout] 166 | | view; [INFO] [stdout] 167 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_common_svg_tags_and_macro` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/tags.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 168 | / declare_svg_tags_special! { [INFO] [stdout] 169 | | color_profile => "color-profile"; [INFO] [stdout] 170 | | r#use => "use"; [INFO] [stdout] 171 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_tags_special` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `with-lookup` [INFO] [stdout] --> src/core/svg/tags.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | #[cfg(feature = "with-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | / declare_svg_tags_non_common! { [INFO] [stdout] 174 | | script; [INFO] [stdout] 175 | | style; [INFO] [stdout] 176 | | text; [INFO] [stdout] 177 | | a; [INFO] [stdout] 178 | | title; [INFO] [stdout] 179 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `js-sys`, `wasm-bindgen`, `web-sys`, and `with-request-animation-frame` [INFO] [stdout] = help: consider adding `with-lookup` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `declare_svg_tags_non_common` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `web_sys::HtmlMenuItemElement`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | HtmlLiElement, HtmlLinkElement, HtmlMenuItemElement, HtmlMeterElement, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `web_sys::HtmlMenuItemElement`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:283:59 [INFO] [stdout] | [INFO] [stdout] 283 | } else if let Some(menu_item) = element.dyn_ref::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `web_sys::HtmlMenuItemElement`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:314:53 [INFO] [stdout] | [INFO] [stdout] 314 | } else if let Some(elm) = element.dyn_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `web_sys::HtmlMenuItemElement`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | HtmlLiElement, HtmlLinkElement, HtmlMenuItemElement, HtmlMeterElement, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `web_sys::HtmlMenuItemElement`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:283:59 [INFO] [stdout] | [INFO] [stdout] 283 | } else if let Some(menu_item) = element.dyn_ref::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `web_sys::HtmlMenuItemElement`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:314:53 [INFO] [stdout] | [INFO] [stdout] 314 | } else if let Some(elm) = element.dyn_ref::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `web_sys::HtmlMenuItemElement::set_checked`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:285:23 [INFO] [stdout] | [INFO] [stdout] 285 | menu_item.set_checked(is_checked); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `web_sys::HtmlMenuItemElement::set_disabled`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | elm.set_disabled(is_disabled); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `web_sys::HtmlMenuItemElement::set_checked`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:285:23 [INFO] [stdout] | [INFO] [stdout] 285 | menu_item.set_checked(is_checked); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `web_sys::HtmlMenuItemElement::set_disabled`: Absent in all major browsers [INFO] [stdout] --> src/core/v_node/virtual_node.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | elm.set_disabled(is_disabled); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dom/apply_patches.rs:140:29 [INFO] [stdout] | [INFO] [stdout] 140 | let mut text_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dom/apply_patches.rs:140:29 [INFO] [stdout] | [INFO] [stdout] 140 | let mut text_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/core/duid_events/subscribe.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | messages: messages.into_iter().map(|msg| msg).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/core/duid_events/subscribe.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | messages: messages.into_iter().map(|msg| msg).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/core/html/node.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / match self { [INFO] [stdout] 27 | | Node::Element(e) => {e.children.extend(children);}, [INFO] [stdout] 28 | | _ => {}, [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ help: try: `if let Node::Element(e) = self {e.children.extend(children);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/core/html/node.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / match self { [INFO] [stdout] 27 | | Node::Element(e) => {e.children.extend(children);}, [INFO] [stdout] 28 | | _ => {}, [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ help: try: `if let Node::Element(e) = self {e.children.extend(children);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/core/html/attributes/style.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if self.name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/html/attributes/attribute.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | &self.name [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/html/attributes/attribute.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | grouped.push((&attr.name, vec![attr])) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `attr.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/core/html/attributes/style.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if self.name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/html/attributes/attribute.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | &self.name [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/html/attributes/attribute.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | grouped.push((&attr.name, vec![attr])) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `attr.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core/v_node/view_builder.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 51 | / let text_node = arena.new_node(VirtualNode { [INFO] [stdout] 52 | | tag: leaf.tag, [INFO] [stdout] 53 | | node_type: VirtualNodeType::Text, [INFO] [stdout] 54 | | namespace: leaf.namespace, [INFO] [stdout] ... | [INFO] [stdout] 58 | | active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 59 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 60 | text_node [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 51 ~ [INFO] [stdout] 52 ~ arena.new_node(VirtualNode { [INFO] [stdout] 53 + tag: leaf.tag, [INFO] [stdout] 54 + node_type: VirtualNodeType::Text, [INFO] [stdout] 55 + namespace: leaf.namespace, [INFO] [stdout] 56 + props: leaf.props, [INFO] [stdout] 57 + value: Some(leaf.value), [INFO] [stdout] 58 + real_node: Rc::new(RefCell::new(None)), [INFO] [stdout] 59 + active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 60 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core/v_node/view_builder.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 63 | / let com_node = arena.new_node(VirtualNode { [INFO] [stdout] 64 | | tag: leaf.tag, [INFO] [stdout] 65 | | node_type: VirtualNodeType::Comment, [INFO] [stdout] 66 | | namespace: leaf.namespace, [INFO] [stdout] ... | [INFO] [stdout] 70 | | active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 71 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 72 | com_node [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 63 ~ [INFO] [stdout] 64 ~ arena.new_node(VirtualNode { [INFO] [stdout] 65 + tag: leaf.tag, [INFO] [stdout] 66 + node_type: VirtualNodeType::Comment, [INFO] [stdout] 67 + namespace: leaf.namespace, [INFO] [stdout] 68 + props: leaf.props, [INFO] [stdout] 69 + value: Some(leaf.value), [INFO] [stdout] 70 + real_node: Rc::new(RefCell::new(None)), [INFO] [stdout] 71 + active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 72 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core/v_node/view_builder.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 75 | / let doc_node = arena.new_node(VirtualNode { [INFO] [stdout] 76 | | tag: leaf.tag, [INFO] [stdout] 77 | | node_type: VirtualNodeType::DocType, [INFO] [stdout] 78 | | namespace: leaf.namespace, [INFO] [stdout] ... | [INFO] [stdout] 82 | | active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 83 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 84 | doc_node [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 75 ~ [INFO] [stdout] 76 ~ arena.new_node(VirtualNode { [INFO] [stdout] 77 + tag: leaf.tag, [INFO] [stdout] 78 + node_type: VirtualNodeType::DocType, [INFO] [stdout] 79 + namespace: leaf.namespace, [INFO] [stdout] 80 + props: leaf.props, [INFO] [stdout] 81 + value: Some(leaf.value), [INFO] [stdout] 82 + real_node: Rc::new(RefCell::new(None)), [INFO] [stdout] 83 + active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 84 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node.rs:58:56 [INFO] [stdout] | [INFO] [stdout] 58 | let element = if let Some(namespace) = self.namespace.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/v_node/virtual_node.rs:60:49 [INFO] [stdout] | [INFO] [stdout] 60 | .create_element_ns(Some(&namespace), &self.tag) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/v_node/virtual_node.rs:60:62 [INFO] [stdout] | [INFO] [stdout] 60 | .create_element_ns(Some(&namespace), &self.tag) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `self.tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/v_node/virtual_node.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 64 | .create_element(&self.tag) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `self.tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/core/v_node/virtual_node.rs:67:46 [INFO] [stdout] | [INFO] [stdout] 67 | let attrs = self.props.iter().map(|attr| attr).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/core/v_node/virtual_node.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | let attrs = self.props.iter().map(|attr| attr).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:159:30 [INFO] [stdout] | [INFO] [stdout] 159 | ... .map(|v| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 160 | | ... v.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 161 | | ... }) [INFO] [stdout] 162 | | ... .flatten() [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 159 ~ .and_then(|v| { [INFO] [stdout] 160 + v.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 161 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:160:48 [INFO] [stdout] | [INFO] [stdout] 160 | ... v.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_bool())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:169:30 [INFO] [stdout] | [INFO] [stdout] 169 | ... .map(|av| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 170 | | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 171 | | ... }) [INFO] [stdout] 172 | | ... .flatten() [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 169 ~ .and_then(|av| { [INFO] [stdout] 170 + av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 171 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:170:49 [INFO] [stdout] | [INFO] [stdout] 170 | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_bool())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:179:30 [INFO] [stdout] | [INFO] [stdout] 179 | ... .map(|av| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 180 | | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 181 | | ... }) [INFO] [stdout] 182 | | ... .flatten() [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 179 ~ .and_then(|av| { [INFO] [stdout] 180 + av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 181 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:180:49 [INFO] [stdout] | [INFO] [stdout] 180 | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_bool())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `event_id` is used as a loop counter [INFO] [stdout] --> src/core/v_node/virtual_node.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | for listener in listeners { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (event_id, listener) in (1..).zip(listeners.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:359:14 [INFO] [stdout] | [INFO] [stdout] 359 | .map(|v| v.get_simple().map(|v| v.as_i32()).flatten()) [INFO] [stdout] | ______________^ [INFO] [stdout] 360 | | .flatten(); [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.get_simple().map(|v| v.as_i32()).flatten())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:359:37 [INFO] [stdout] | [INFO] [stdout] 359 | .map(|v| v.get_simple().map(|v| v.as_i32()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_i32())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:364:14 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|v| v.get_simple().map(|v| v.as_f64()).flatten()) [INFO] [stdout] | ______________^ [INFO] [stdout] 365 | | .flatten(); [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.get_simple().map(|v| v.as_f64()).flatten())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:364:37 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|v| v.get_simple().map(|v| v.as_f64()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_f64())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | if props_changes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!props_changes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 60 | ... exist.namespace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exist.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | ... exist.namespace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exist.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:92:25 [INFO] [stdout] | [INFO] [stdout] 92 | new_attr.namespace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_attr.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/core/mod.rs:14:53 [INFO] [stdout] | [INFO] [stdout] 14 | thread_local!(static NODE_ID_COUNTER: Cell = Cell::new(1)); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(1) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Descendants<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/dom_builder.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | for node_id in root_node_id.descendants(&self.borrow()).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `root_node_id.descendants(&self.borrow())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_builder.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 32 | let node = node_borrow.get(node_id).expect(&format!("The {node_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_builder.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | node.build_node(program, &doc, style_map, >::into(node_id)); [INFO] [stdout] | ^^^^ help: change this to: `doc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Descendants<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/dom_builder.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | for node_id in root_node_id.descendants(&self.borrow()).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `root_node_id.descendants(&self.borrow())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_builder.rs:39:49 [INFO] [stdout] | [INFO] [stdout] 39 | let node = node_borrow.get(node_id).expect(&format!("The {node_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Children<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/dom_builder.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 41 | for child_id in node_id.children(&self.borrow()).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `node_id.children(&self.borrow())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_builder.rs:42:55 [INFO] [stdout] | [INFO] [stdout] 42 | let child = node_borrow.get(child_id).expect(&format!("The {node_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_builder.rs:45:63 [INFO] [stdout] | [INFO] [stdout] 45 | let _ = real_node_parent.append_child(&real_node_child); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `real_node_child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core/v_node/view_builder.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 51 | / let text_node = arena.new_node(VirtualNode { [INFO] [stdout] 52 | | tag: leaf.tag, [INFO] [stdout] 53 | | node_type: VirtualNodeType::Text, [INFO] [stdout] 54 | | namespace: leaf.namespace, [INFO] [stdout] ... | [INFO] [stdout] 58 | | active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 59 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 60 | text_node [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 51 ~ [INFO] [stdout] 52 ~ arena.new_node(VirtualNode { [INFO] [stdout] 53 + tag: leaf.tag, [INFO] [stdout] 54 + node_type: VirtualNodeType::Text, [INFO] [stdout] 55 + namespace: leaf.namespace, [INFO] [stdout] 56 + props: leaf.props, [INFO] [stdout] 57 + value: Some(leaf.value), [INFO] [stdout] 58 + real_node: Rc::new(RefCell::new(None)), [INFO] [stdout] 59 + active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 60 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core/v_node/view_builder.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 63 | / let com_node = arena.new_node(VirtualNode { [INFO] [stdout] 64 | | tag: leaf.tag, [INFO] [stdout] 65 | | node_type: VirtualNodeType::Comment, [INFO] [stdout] 66 | | namespace: leaf.namespace, [INFO] [stdout] ... | [INFO] [stdout] 70 | | active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 71 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 72 | com_node [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 63 ~ [INFO] [stdout] 64 ~ arena.new_node(VirtualNode { [INFO] [stdout] 65 + tag: leaf.tag, [INFO] [stdout] 66 + node_type: VirtualNodeType::Comment, [INFO] [stdout] 67 + namespace: leaf.namespace, [INFO] [stdout] 68 + props: leaf.props, [INFO] [stdout] 69 + value: Some(leaf.value), [INFO] [stdout] 70 + real_node: Rc::new(RefCell::new(None)), [INFO] [stdout] 71 + active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 72 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core/v_node/view_builder.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 75 | / let doc_node = arena.new_node(VirtualNode { [INFO] [stdout] 76 | | tag: leaf.tag, [INFO] [stdout] 77 | | node_type: VirtualNodeType::DocType, [INFO] [stdout] 78 | | namespace: leaf.namespace, [INFO] [stdout] ... | [INFO] [stdout] 82 | | active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 83 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 84 | doc_node [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 75 ~ [INFO] [stdout] 76 ~ arena.new_node(VirtualNode { [INFO] [stdout] 77 + tag: leaf.tag, [INFO] [stdout] 78 + node_type: VirtualNodeType::DocType, [INFO] [stdout] 79 + namespace: leaf.namespace, [INFO] [stdout] 80 + props: leaf.props, [INFO] [stdout] 81 + value: Some(leaf.value), [INFO] [stdout] 82 + real_node: Rc::new(RefCell::new(None)), [INFO] [stdout] 83 + active_closures: Rc::new(RefCell::new(ActiveClosure::with_capacity(0))) [INFO] [stdout] 84 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:25:53 [INFO] [stdout] | [INFO] [stdout] 25 | let old_node = old_arena.get(*root_node_id).expect(&format!("The {root_node_id:?} node does not exists on old!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {root_node_id:?} node does not exists on old!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:26:53 [INFO] [stdout] | [INFO] [stdout] 26 | let new_node = new_arena.get(*root_node_id).expect(&format!("The {root_node_id:?} node does not exists on new!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {root_node_id:?} node does not exists on new!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node.rs:58:56 [INFO] [stdout] | [INFO] [stdout] 58 | let element = if let Some(namespace) = self.namespace.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/v_node/virtual_node.rs:60:49 [INFO] [stdout] | [INFO] [stdout] 60 | .create_element_ns(Some(&namespace), &self.tag) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/v_node/virtual_node.rs:60:62 [INFO] [stdout] | [INFO] [stdout] 60 | .create_element_ns(Some(&namespace), &self.tag) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `self.tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/v_node/virtual_node.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 64 | .create_element(&self.tag) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `self.tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/core/v_node/virtual_node.rs:67:46 [INFO] [stdout] | [INFO] [stdout] 67 | let attrs = self.props.iter().map(|attr| attr).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/core/v_node/virtual_node.rs:77:50 [INFO] [stdout] | [INFO] [stdout] 77 | let attrs = self.props.iter().map(|attr| attr).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:159:30 [INFO] [stdout] | [INFO] [stdout] 159 | ... .map(|v| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 160 | | ... v.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 161 | | ... }) [INFO] [stdout] 162 | | ... .flatten() [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 159 ~ .and_then(|v| { [INFO] [stdout] 160 + v.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 161 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:160:48 [INFO] [stdout] | [INFO] [stdout] 160 | ... v.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_bool())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | match old_node.diff(&new_node) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:169:30 [INFO] [stdout] | [INFO] [stdout] 169 | ... .map(|av| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 170 | | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 171 | | ... }) [INFO] [stdout] 172 | | ... .flatten() [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 169 ~ .and_then(|av| { [INFO] [stdout] 170 + av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 171 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:170:49 [INFO] [stdout] | [INFO] [stdout] 170 | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_bool())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:179:30 [INFO] [stdout] | [INFO] [stdout] 179 | ... .map(|av| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 180 | | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 181 | | ... }) [INFO] [stdout] 182 | | ... .flatten() [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 179 ~ .and_then(|av| { [INFO] [stdout] 180 + av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] 181 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:58:63 [INFO] [stdout] | [INFO] [stdout] 58 | let new_node_children = root_node_id.children(&new_arena); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:66:66 [INFO] [stdout] | [INFO] [stdout] 66 | diff_children(&old_child_id, &old_arena, &new_arena, &mut patches); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:180:49 [INFO] [stdout] | [INFO] [stdout] 180 | ... av.get_simple().map(|v| v.as_bool()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_bool())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dom/dom_diff.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - patches.push(Patch::Replace(*node_id, *node_id)); [INFO] [stdout] 117 - return; [INFO] [stdout] 116 + patches.push(Patch::Replace(*node_id, *node_id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:80:44 [INFO] [stdout] | [INFO] [stdout] 80 | let old_node = old_arena.get(*node_id).expect(&format!("The {node_id:?} node does not exists on old!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists on old!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:81:44 [INFO] [stdout] | [INFO] [stdout] 81 | let new_node = new_arena.get(*node_id).expect(&format!("The {node_id:?} node does not exists on new!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists on new!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `event_id` is used as a loop counter [INFO] [stdout] --> src/core/v_node/virtual_node.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | for listener in listeners { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (event_id, listener) in (1..).zip(listeners.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | match old_node.diff(&new_node) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:112:54 [INFO] [stdout] | [INFO] [stdout] 112 | let old_node_children = node_id.children(&old_arena); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `old_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:113:54 [INFO] [stdout] | [INFO] [stdout] 113 | let new_node_children = node_id.children(&new_arena); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:121:50 [INFO] [stdout] | [INFO] [stdout] 121 | diff_children(&old_child_id, &old_arena, &new_arena, patches); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `old_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:121:62 [INFO] [stdout] | [INFO] [stdout] 121 | diff_children(&old_child_id, &old_arena, &new_arena, patches); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:38:59 [INFO] [stdout] | [INFO] [stdout] 38 | let new_node = new_arena.get(*new_id).expect(&format!("The {new_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {new_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Children<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/apply_patches.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | for child_id in new_id.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `new_id.children(&new_arena)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:49:53 [INFO] [stdout] | [INFO] [stdout] 49 | for child_id in new_id.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:50:61 [INFO] [stdout] | [INFO] [stdout] 50 | let child = new_arena.get(child_id).expect(&format!("The {child_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {child_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... &new_arena [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:359:14 [INFO] [stdout] | [INFO] [stdout] 359 | .map(|v| v.get_simple().map(|v| v.as_i32()).flatten()) [INFO] [stdout] | ______________^ [INFO] [stdout] 360 | | .flatten(); [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.get_simple().map(|v| v.as_i32()).flatten())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:359:37 [INFO] [stdout] | [INFO] [stdout] 359 | .map(|v| v.get_simple().map(|v| v.as_i32()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_i32())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:364:14 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|v| v.get_simple().map(|v| v.as_f64()).flatten()) [INFO] [stdout] | ______________^ [INFO] [stdout] 365 | | .flatten(); [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.get_simple().map(|v| v.as_f64()).flatten())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/core/v_node/virtual_node.rs:364:37 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|v| v.get_simple().map(|v| v.as_f64()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.as_f64())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:74:41 [INFO] [stdout] | [INFO] [stdout] 74 | self.build(program, &doc, &new_node_to_insert, style_map); [INFO] [stdout] | ^^^^ help: change this to: `doc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:77:60 [INFO] [stdout] | [INFO] [stdout] 77 | let parent = borrow.get(parent_id).expect(&format!("The {parent_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {parent_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:78:67 [INFO] [stdout] | [INFO] [stdout] 78 | ....get(new_node_to_insert).expect(&format!("The {new_node_to_insert:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {new_node_to_insert:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:88:60 [INFO] [stdout] | [INFO] [stdout] 88 | let old_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:108:60 [INFO] [stdout] | [INFO] [stdout] 108 | let old_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dom/apply_patches.rs:109:50 [INFO] [stdout] | [INFO] [stdout] 109 | old_node.props.retain(|prop| !(prop.name == attr_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prop.name != attr_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:119:60 [INFO] [stdout] | [INFO] [stdout] 119 | let old_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dom/apply_patches.rs:120:50 [INFO] [stdout] | [INFO] [stdout] 120 | old_node.props.retain(|prop| !(prop.name == *attr_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prop.name != *attr_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:140:69 [INFO] [stdout] | [INFO] [stdout] 140 | let mut text_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | if props_changes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!props_changes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/dom/apply_patches.rs:143:25 [INFO] [stdout] | [INFO] [stdout] 143 | let _ = text_real_node.as_ref().unwrap().set_text_content(Some(text_node.value.as_ref().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 143 - let _ = text_real_node.as_ref().unwrap().set_text_content(Some(text_node.value.as_ref().unwrap())); [INFO] [stdout] 143 + text_real_node.as_ref().unwrap().set_text_content(Some(text_node.value.as_ref().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:160:48 [INFO] [stdout] | [INFO] [stdout] 160 | let new_node = new_arena.get(*parent_node).expect(&format!("The {parent_node:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {parent_node:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Children<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/apply_patches.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | for child_id in parent_node.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parent_node.children(&new_arena)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:171:42 [INFO] [stdout] | [INFO] [stdout] 171 | for child_id in parent_node.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:172:45 [INFO] [stdout] | [INFO] [stdout] 172 | let child = new_arena.get(child_id).expect(&format!("The {child_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {child_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 60 | ... exist.namespace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exist.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | &new_arena [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | ... exist.namespace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exist.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&str>` which implements the `Copy` trait [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:92:25 [INFO] [stdout] | [INFO] [stdout] 92 | new_attr.namespace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_attr.namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `DSP` goes unused in function definition [INFO] [stdout] --> src/dom/mod.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the parameter [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/mod.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 61 | .expect(&format!("element with id {:?} not present", mount)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("element with id {:?} not present", mount))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/mod.rs:88:51 [INFO] [stdout] | [INFO] [stdout] 88 | self.arena.build(program, &self.document, &self.arena_root_node_id.as_ref().unwrap(), &mut style_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.arena_root_node_id.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/mod.rs:129:39 [INFO] [stdout] | [INFO] [stdout] 129 | .append_child(&node) [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/core/mod.rs:14:53 [INFO] [stdout] | [INFO] [stdout] 14 | thread_local!(static NODE_ID_COUNTER: Cell = Cell::new(1)); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(1) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/mod.rs:133:39 [INFO] [stdout] | [INFO] [stdout] 133 | .append_child(&node) [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Descendants<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/dom_builder.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | for node_id in root_node_id.descendants(&self.borrow()).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `root_node_id.descendants(&self.borrow())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_builder.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 32 | let node = node_borrow.get(node_id).expect(&format!("The {node_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_builder.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | node.build_node(program, &doc, style_map, >::into(node_id)); [INFO] [stdout] | ^^^^ help: change this to: `doc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Descendants<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/dom_builder.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | for node_id in root_node_id.descendants(&self.borrow()).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `root_node_id.descendants(&self.borrow())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_builder.rs:39:49 [INFO] [stdout] | [INFO] [stdout] 39 | let node = node_borrow.get(node_id).expect(&format!("The {node_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/effects/mod.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / match cmd_type { [INFO] [stdout] 20 | | CmdType::Normal => { [INFO] [stdout] 21 | | messages.push(msg); [INFO] [stdout] 22 | | }, [INFO] [stdout] 23 | | _ => () [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ if let CmdType::Normal = cmd_type { [INFO] [stdout] 20 + messages.push(msg); [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Children<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/dom_builder.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 41 | for child_id in node_id.children(&self.borrow()).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `node_id.children(&self.borrow())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_builder.rs:42:55 [INFO] [stdout] | [INFO] [stdout] 42 | let child = node_borrow.get(child_id).expect(&format!("The {node_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_builder.rs:45:63 [INFO] [stdout] | [INFO] [stdout] 45 | let _ = real_node_parent.append_child(&real_node_child); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `real_node_child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/html/attributes/mod.rs:241:11 [INFO] [stdout] | [INFO] [stdout] 241 | attr: &Attribute, [INFO] [stdout] | ^^^^^^^^^^^^^^^ the lifetime is elided here [INFO] [stdout] 242 | ) -> SegregatedAttributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 242 | ) -> SegregatedAttributes<'_, MSG> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:25:53 [INFO] [stdout] | [INFO] [stdout] 25 | let old_node = old_arena.get(*root_node_id).expect(&format!("The {root_node_id:?} node does not exists on old!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {root_node_id:?} node does not exists on old!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/html/attributes/attribute.rs:77:31 [INFO] [stdout] | [INFO] [stdout] 77 | name: att.name.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:26:53 [INFO] [stdout] | [INFO] [stdout] 26 | let new_node = new_arena.get(*root_node_id).expect(&format!("The {root_node_id:?} node does not exists on new!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {root_node_id:?} node does not exists on new!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | match old_node.diff(&new_node) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:58:63 [INFO] [stdout] | [INFO] [stdout] 58 | let new_node_children = root_node_id.children(&new_arena); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:66:66 [INFO] [stdout] | [INFO] [stdout] 66 | diff_children(&old_child_id, &old_arena, &new_arena, &mut patches); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dom/dom_diff.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - patches.push(Patch::Replace(*node_id, *node_id)); [INFO] [stdout] 117 - return; [INFO] [stdout] 116 + patches.push(Patch::Replace(*node_id, *node_id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:59:86 [INFO] [stdout] | [INFO] [stdout] 59 | ... changes.push(PropsChangeType::UpdatedPropValues(old_attr.name.clone().to_owned(), Attribute::with_multiple_values( [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:74:86 [INFO] [stdout] | [INFO] [stdout] 74 | ... changes.push(PropsChangeType::UpdatedPropValues(old_attr.name.clone().to_owned(), Attribute::with_multiple_values( [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:82:76 [INFO] [stdout] | [INFO] [stdout] 82 | changes.push(PropsChangeType::RemovedProp(old_attr.name.clone().to_owned())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:80:44 [INFO] [stdout] | [INFO] [stdout] 80 | let old_node = old_arena.get(*node_id).expect(&format!("The {node_id:?} node does not exists on old!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists on old!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/dom_diff.rs:81:44 [INFO] [stdout] | [INFO] [stdout] 81 | let new_node = new_arena.get(*node_id).expect(&format!("The {node_id:?} node does not exists on new!")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {node_id:?} node does not exists on new!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | match old_node.diff(&new_node) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:112:54 [INFO] [stdout] | [INFO] [stdout] 112 | let old_node_children = node_id.children(&old_arena); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `old_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:113:54 [INFO] [stdout] | [INFO] [stdout] 113 | let new_node_children = node_id.children(&new_arena); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:121:50 [INFO] [stdout] | [INFO] [stdout] 121 | diff_children(&old_child_id, &old_arena, &new_arena, patches); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `old_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/dom_diff.rs:121:62 [INFO] [stdout] | [INFO] [stdout] 121 | diff_children(&old_child_id, &old_arena, &new_arena, patches); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:38:59 [INFO] [stdout] | [INFO] [stdout] 38 | let new_node = new_arena.get(*new_id).expect(&format!("The {new_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {new_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Children<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/apply_patches.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | for child_id in new_id.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `new_id.children(&new_arena)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:49:53 [INFO] [stdout] | [INFO] [stdout] 49 | for child_id in new_id.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:50:61 [INFO] [stdout] | [INFO] [stdout] 50 | let child = new_arena.get(child_id).expect(&format!("The {child_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {child_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... &new_arena [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:74:41 [INFO] [stdout] | [INFO] [stdout] 74 | self.build(program, &doc, &new_node_to_insert, style_map); [INFO] [stdout] | ^^^^ help: change this to: `doc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:77:60 [INFO] [stdout] | [INFO] [stdout] 77 | let parent = borrow.get(parent_id).expect(&format!("The {parent_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {parent_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:78:67 [INFO] [stdout] | [INFO] [stdout] 78 | ....get(new_node_to_insert).expect(&format!("The {new_node_to_insert:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {new_node_to_insert:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:88:60 [INFO] [stdout] | [INFO] [stdout] 88 | let old_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:108:60 [INFO] [stdout] | [INFO] [stdout] 108 | let old_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dom/apply_patches.rs:109:50 [INFO] [stdout] | [INFO] [stdout] 109 | old_node.props.retain(|prop| !(prop.name == attr_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prop.name != attr_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:119:60 [INFO] [stdout] | [INFO] [stdout] 119 | let old_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dom/apply_patches.rs:120:50 [INFO] [stdout] | [INFO] [stdout] 120 | old_node.props.retain(|prop| !(prop.name == *attr_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prop.name != *attr_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:140:69 [INFO] [stdout] | [INFO] [stdout] 140 | let mut text_node = borrow.get_mut(*old_id).expect(&format!("The {old_id:?} node does not exists")).get_mut(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {old_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/dom/apply_patches.rs:143:25 [INFO] [stdout] | [INFO] [stdout] 143 | let _ = text_real_node.as_ref().unwrap().set_text_content(Some(text_node.value.as_ref().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 143 - let _ = text_real_node.as_ref().unwrap().set_text_content(Some(text_node.value.as_ref().unwrap())); [INFO] [stdout] 143 + text_real_node.as_ref().unwrap().set_text_content(Some(text_node.value.as_ref().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:160:48 [INFO] [stdout] | [INFO] [stdout] 160 | let new_node = new_arena.get(*parent_node).expect(&format!("The {parent_node:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {parent_node:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `indextree::Children<'_, core::v_node::virtual_node::VirtualNode>` [INFO] [stdout] --> src/dom/apply_patches.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | for child_id in parent_node.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `parent_node.children(&new_arena)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:171:42 [INFO] [stdout] | [INFO] [stdout] 171 | for child_id in parent_node.children(&new_arena).into_iter() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/apply_patches.rs:172:45 [INFO] [stdout] | [INFO] [stdout] 172 | let child = new_arena.get(child_id).expect(&format!("The {child_id:?} node does not exists")).get(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {child_id:?} node does not exists"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/apply_patches.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | &new_arena [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `new_arena` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `DSP` goes unused in function definition [INFO] [stdout] --> src/dom/mod.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the parameter [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/dom/mod.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 61 | .expect(&format!("element with id {:?} not present", mount)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("element with id {:?} not present", mount))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/mod.rs:88:51 [INFO] [stdout] | [INFO] [stdout] 88 | self.arena.build(program, &self.document, &self.arena_root_node_id.as_ref().unwrap(), &mut style_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.arena_root_node_id.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/mod.rs:129:39 [INFO] [stdout] | [INFO] [stdout] 129 | .append_child(&node) [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/mod.rs:133:39 [INFO] [stdout] | [INFO] [stdout] 133 | .append_child(&node) [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/effects/mod.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / match cmd_type { [INFO] [stdout] 20 | | CmdType::Normal => { [INFO] [stdout] 21 | | messages.push(msg); [INFO] [stdout] 22 | | }, [INFO] [stdout] 23 | | _ => () [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ if let CmdType::Normal = cmd_type { [INFO] [stdout] 20 + messages.push(msg); [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/html/attributes/mod.rs:241:11 [INFO] [stdout] | [INFO] [stdout] 241 | attr: &Attribute, [INFO] [stdout] | ^^^^^^^^^^^^^^^ the lifetime is elided here [INFO] [stdout] 242 | ) -> SegregatedAttributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 242 | ) -> SegregatedAttributes<'_, MSG> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/html/attributes/attribute.rs:77:31 [INFO] [stdout] | [INFO] [stdout] 77 | name: att.name.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:59:86 [INFO] [stdout] | [INFO] [stdout] 59 | ... changes.push(PropsChangeType::UpdatedPropValues(old_attr.name.clone().to_owned(), Attribute::with_multiple_values( [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:74:86 [INFO] [stdout] | [INFO] [stdout] 74 | ... changes.push(PropsChangeType::UpdatedPropValues(old_attr.name.clone().to_owned(), Attribute::with_multiple_values( [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/v_node/virtual_node_changes.rs:82:76 [INFO] [stdout] | [INFO] [stdout] 82 | changes.push(PropsChangeType::RemovedProp(old_attr.name.clone().to_owned())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.44s [INFO] running `Command { std: "docker" "inspect" "a4a039d5de81b0a14f2e3d76e08d07860540d0afb746dedbb9febd43d8542710", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4a039d5de81b0a14f2e3d76e08d07860540d0afb746dedbb9febd43d8542710", kill_on_drop: false }` [INFO] [stdout] a4a039d5de81b0a14f2e3d76e08d07860540d0afb746dedbb9febd43d8542710