[INFO] fetching crate dtb_parser 0.2.3... [INFO] linting dtb_parser-0.2.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate dtb_parser 0.2.3 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate dtb_parser 0.2.3 [INFO] finished tweaking crates.io crate dtb_parser 0.2.3 [INFO] tweaked toml for crates.io crate dtb_parser 0.2.3 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate dtb_parser 0.2.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9315388e3bf5b21a7382e3ee326fef9bfa81115ce5382376fd991a8227a6bae [INFO] running `Command { std: "docker" "start" "-a" "a9315388e3bf5b21a7382e3ee326fef9bfa81115ce5382376fd991a8227a6bae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9315388e3bf5b21a7382e3ee326fef9bfa81115ce5382376fd991a8227a6bae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9315388e3bf5b21a7382e3ee326fef9bfa81115ce5382376fd991a8227a6bae", kill_on_drop: false }` [INFO] [stdout] a9315388e3bf5b21a7382e3ee326fef9bfa81115ce5382376fd991a8227a6bae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e195323251054a7264e84cd0050910fa03194f7d3891b7a24690f506f144a19 [INFO] running `Command { std: "docker" "start" "-a" "0e195323251054a7264e84cd0050910fa03194f7d3891b7a24690f506f144a19", kill_on_drop: false }` [INFO] [stderr] Checking dtb_parser v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/byte_utils.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | (raw_size + BLOCK_SIZE - 1) / BLOCK_SIZE [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `raw_size.div_ceil(BLOCK_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/byte_utils.rs:35:41 [INFO] [stdout] | [INFO] [stdout] 35 | read_aligned_block(data, index).map(|block| u32::from_be_bytes(block)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `u32::from_be_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/byte_utils.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | 0 | 1 | 2 => read_aligned_be_number(data, index, block_size).map(|f| f as u128), [INFO] [stdout] | ^^^^^^^^^ help: try: `0..=2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/byte_utils.rs:81:28 [INFO] [stdout] | [INFO] [stdout] 81 | while data[end] != '\0' as u8 { [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/byte_utils.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | end = end + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `end += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/byte_utils.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / match core::str::from_utf8(&data[first..end]) { [INFO] [stdout] 85 | | Ok(s) => Some(s), [INFO] [stdout] 86 | | _ => None, [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ help: replace with: `core::str::from_utf8(&data[first..end]).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/device_tree.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if slices.len() > 0 && self.root.name() == slices[0] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!slices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/device_tree.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return false; [INFO] [stdout] 163 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/byte_utils.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | (raw_size + BLOCK_SIZE - 1) / BLOCK_SIZE [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `raw_size.div_ceil(BLOCK_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/byte_utils.rs:35:41 [INFO] [stdout] | [INFO] [stdout] 35 | read_aligned_block(data, index).map(|block| u32::from_be_bytes(block)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `u32::from_be_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/byte_utils.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | 0 | 1 | 2 => read_aligned_be_number(data, index, block_size).map(|f| f as u128), [INFO] [stdout] | ^^^^^^^^^ help: try: `0..=2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/byte_utils.rs:81:28 [INFO] [stdout] | [INFO] [stdout] 81 | while data[end] != '\0' as u8 { [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/byte_utils.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | end = end + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `end += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/byte_utils.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / match core::str::from_utf8(&data[first..end]) { [INFO] [stdout] 85 | | Ok(s) => Some(s), [INFO] [stdout] 86 | | _ => None, [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ help: replace with: `core::str::from_utf8(&data[first..end]).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | / if let Err(err) = writeln!(f, "{} {{", self.name) { [INFO] [stdout] 182 | | return Err(err); [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ help: replace it with: `..?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | / if let Err(err) = writeln!(f, "\t{}", i) { [INFO] [stdout] 186 | | return Err(err); [INFO] [stdout] 187 | | } [INFO] [stdout] | |_____________^ help: replace it with: `..?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | / if let Err(err) = write!(buffer, "\t{}", i) { [INFO] [stdout] 192 | | return Err(err); [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________^ help: replace it with: `..?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | / if let Err(err) = write!(f, "\t") { [INFO] [stdout] 198 | | return Err(err); [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____________________^ help: replace it with: `..?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | / if let Err(err) = writeln!(f, "{}", j) { [INFO] [stdout] 204 | | return Err(err); [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________________^ help: replace it with: `..?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/device_tree.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if slices.len() > 0 && self.root.name() == slices[0] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!slices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/device_tree.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return false; [INFO] [stdout] 163 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/prop.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some(name) = read_name(data, (header.off_dt_strings + name_offset) as usize) [INFO] [stdout] 105 | | { [INFO] [stdout] 106 | | Some(( [INFO] [stdout] 107 | | name.to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 116 | | None [INFO] [stdout] 117 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 104 ~ read_name(data, (header.off_dt_strings + name_offset) as usize).map(|name| ( [INFO] [stdout] 105 + name.to_owned(), [INFO] [stdout] 106 + prop_val_size, [INFO] [stdout] 107 + if prop_val_size > 0 { [INFO] [stdout] 108 + 3 + align_size(prop_val_size as usize) [INFO] [stdout] 109 + } else { [INFO] [stdout] 110 + 3 [INFO] [stdout] 111 + }, [INFO] [stdout] 112 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/prop.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / return Ok(Self { [INFO] [stdout] 140 | | block_count: meta.2, [INFO] [stdout] 141 | | name: meta.0, [INFO] [stdout] 142 | | value, [INFO] [stdout] 143 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ Ok(Self { [INFO] [stdout] 140 + block_count: meta.2, [INFO] [stdout] 141 + name: meta.0, [INFO] [stdout] 142 + value, [INFO] [stdout] 143 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/prop.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | if !a || a && b { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 - if !a || a && b { [INFO] [stdout] 284 + if !(a && !b) { [INFO] [stdout] | [INFO] [stdout] 284 - if !a || a && b { [INFO] [stdout] 284 + if !a || b { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/prop.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let a = raw_value.len() as usize % BLOCK_SIZE == 0; // str or int | must str [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(raw_value.len() as usize).is_multiple_of(BLOCK_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/prop.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let a = raw_value.len() as usize % BLOCK_SIZE == 0; // str or int | must str [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw_value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/prop.rs:282:34 [INFO] [stdout] | [INFO] [stdout] 282 | && raw_value[(raw_value.len() - 1) as usize] == b'\0' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((raw_value.len() - 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/prop.rs:299:32 [INFO] [stdout] | [INFO] [stdout] 299 | let size = raw_value.len() as usize / BLOCK_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw_value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | / if let Err(err) = writeln!(f, "{} {{", self.name) { [INFO] [stdout] 182 | | return Err(err); [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ help: replace it with: `..?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | / if let Err(err) = writeln!(f, "\t{}", i) { [INFO] [stdout] 186 | | return Err(err); [INFO] [stdout] 187 | | } [INFO] [stdout] | |_____________^ help: replace it with: `..?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | / if let Err(err) = write!(buffer, "\t{}", i) { [INFO] [stdout] 192 | | return Err(err); [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________^ help: replace it with: `..?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | / if let Err(err) = write!(f, "\t") { [INFO] [stdout] 198 | | return Err(err); [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____________________^ help: replace it with: `..?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/node.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | / if let Err(err) = writeln!(f, "{}", j) { [INFO] [stdout] 204 | | return Err(err); [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________________^ help: replace it with: `..?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/prop.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some(name) = read_name(data, (header.off_dt_strings + name_offset) as usize) [INFO] [stdout] 105 | | { [INFO] [stdout] 106 | | Some(( [INFO] [stdout] 107 | | name.to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 116 | | None [INFO] [stdout] 117 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 104 ~ read_name(data, (header.off_dt_strings + name_offset) as usize).map(|name| ( [INFO] [stdout] 105 + name.to_owned(), [INFO] [stdout] 106 + prop_val_size, [INFO] [stdout] 107 + if prop_val_size > 0 { [INFO] [stdout] 108 + 3 + align_size(prop_val_size as usize) [INFO] [stdout] 109 + } else { [INFO] [stdout] 110 + 3 [INFO] [stdout] 111 + }, [INFO] [stdout] 112 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/prop.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / return Ok(Self { [INFO] [stdout] 140 | | block_count: meta.2, [INFO] [stdout] 141 | | name: meta.0, [INFO] [stdout] 142 | | value, [INFO] [stdout] 143 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ Ok(Self { [INFO] [stdout] 140 + block_count: meta.2, [INFO] [stdout] 141 + name: meta.0, [INFO] [stdout] 142 + value, [INFO] [stdout] 143 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/prop.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | if !a || a && b { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 - if !a || a && b { [INFO] [stdout] 284 + if !(a && !b) { [INFO] [stdout] | [INFO] [stdout] 284 - if !a || a && b { [INFO] [stdout] 284 + if !a || b { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/prop.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let a = raw_value.len() as usize % BLOCK_SIZE == 0; // str or int | must str [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(raw_value.len() as usize).is_multiple_of(BLOCK_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/prop.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | let a = raw_value.len() as usize % BLOCK_SIZE == 0; // str or int | must str [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw_value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/prop.rs:282:34 [INFO] [stdout] | [INFO] [stdout] 282 | && raw_value[(raw_value.len() - 1) as usize] == b'\0' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((raw_value.len() - 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/prop.rs:299:32 [INFO] [stdout] | [INFO] [stdout] 299 | let size = raw_value.len() as usize / BLOCK_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw_value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(!matches!(tree.root().find_child("cpus"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.root().find_child("cpus").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | assert!(!matches!(tree.root().find_child("memory@0"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.root().find_child("memory@0").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | assert!(matches!(tree.root().find_child("cpu@0"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.root().find_child("cpu@0").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 18 | assert!(!matches!(tree.root().find_prop("model"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.root().find_prop("model").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(!matches!(tree.root().find_prop("#address-cells"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.root().find_prop("#address-cells").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | assert!(matches!(tree.root().find_prop("#interrupt-cells"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.root().find_prop("#interrupt-cells").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 23 | assert!(!matches!(soc, None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `soc.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | assert!(matches!(soc.unwrap().find_child("soc_gpio1"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `soc.unwrap().find_child("soc_gpio1").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> tests/index.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | assert!(!matches!(tree.find_node("/cpus/cpu@0"), None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.find_node("/cpus/cpu@0").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `Command { std: "docker" "inspect" "0e195323251054a7264e84cd0050910fa03194f7d3891b7a24690f506f144a19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e195323251054a7264e84cd0050910fa03194f7d3891b7a24690f506f144a19", kill_on_drop: false }` [INFO] [stdout] 0e195323251054a7264e84cd0050910fa03194f7d3891b7a24690f506f144a19