[INFO] fetching crate ds-heightmap 0.2.1... [INFO] linting ds-heightmap-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ds-heightmap 0.2.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate ds-heightmap 0.2.1 [INFO] finished tweaking crates.io crate ds-heightmap 0.2.1 [INFO] tweaked toml for crates.io crate ds-heightmap 0.2.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ds-heightmap 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding getrandom v0.2.17 (available: v0.4.2) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding rand_distr v0.4.3 (available: v0.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d38b3d36434ff5e9e21f78ee9369c7dae724dcb7cbb86c62f3c3801e98a569e3 [INFO] running `Command { std: "docker" "start" "-a" "d38b3d36434ff5e9e21f78ee9369c7dae724dcb7cbb86c62f3c3801e98a569e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d38b3d36434ff5e9e21f78ee9369c7dae724dcb7cbb86c62f3c3801e98a569e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d38b3d36434ff5e9e21f78ee9369c7dae724dcb7cbb86c62f3c3801e98a569e3", kill_on_drop: false }` [INFO] [stdout] d38b3d36434ff5e9e21f78ee9369c7dae724dcb7cbb86c62f3c3801e98a569e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f2711c93893c80ccff4ccb5e82cd41dadf8b81eb800dd1d2fd9783fcf525ee5 [INFO] running `Command { std: "docker" "start" "-a" "8f2711c93893c80ccff4ccb5e82cd41dadf8b81eb800dd1d2fd9783fcf525ee5", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking ds-heightmap v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Runner` [INFO] [stdout] --> src/lib.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn new() -> Self { [INFO] [stdout] 99 | | let mut runner = Self { [INFO] [stdout] 100 | | data: Vec::new(), [INFO] [stdout] 101 | | max: f32::MIN, [INFO] [stdout] ... | [INFO] [stdout] 111 | | runner [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 96 + impl Default for Runner { [INFO] [stdout] 97 + fn default() -> Self { [INFO] [stdout] 98 + Self::new() [INFO] [stdout] 99 + } [INFO] [stdout] 100 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + !(y != 0.0 && y != p || x != 0.0 && x != p) [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + (x == p || x == 0.0) && (y == p || y == 0.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + !(x != 0.0 || y != 0.0 && y != p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + (y == p || y == 0.0) && x == 0.0 || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | (2 as usize).pow((n + if n % 1.0 == 0.0 { 0.0 } else { 1.0 }).floor() as u32) + 1 [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Runner` [INFO] [stdout] --> src/lib.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn new() -> Self { [INFO] [stdout] 99 | | let mut runner = Self { [INFO] [stdout] 100 | | data: Vec::new(), [INFO] [stdout] 101 | | max: f32::MIN, [INFO] [stdout] ... | [INFO] [stdout] 111 | | runner [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 96 + impl Default for Runner { [INFO] [stdout] 97 + fn default() -> Self { [INFO] [stdout] 98 + Self::new() [INFO] [stdout] 99 + } [INFO] [stdout] 100 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + !(y != 0.0 && y != p || x != 0.0 && x != p) [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + (x == p || x == 0.0) && (y == p || y == 0.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + !(x != 0.0 || y != 0.0 && y != p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | [INFO] [stdout] 223 - (x == 0.0 && y == 0.0) || (x == 0.0 && y == p) || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] 223 + (y == p || y == 0.0) && x == 0.0 || (x == p && y == 0.0) || (x == p && y == p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/lib.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | (2 as usize).pow((n + if n % 1.0 == 0.0 { 0.0 } else { 1.0 }).floor() as u32) + 1 [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `Command { std: "docker" "inspect" "8f2711c93893c80ccff4ccb5e82cd41dadf8b81eb800dd1d2fd9783fcf525ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f2711c93893c80ccff4ccb5e82cd41dadf8b81eb800dd1d2fd9783fcf525ee5", kill_on_drop: false }` [INFO] [stdout] 8f2711c93893c80ccff4ccb5e82cd41dadf8b81eb800dd1d2fd9783fcf525ee5