[INFO] fetching crate droid-wrap-macros 0.4.1... [INFO] linting droid-wrap-macros-0.4.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate droid-wrap-macros 0.4.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate droid-wrap-macros 0.4.1 [INFO] finished tweaking crates.io crate droid-wrap-macros 0.4.1 [INFO] tweaked toml for crates.io crate droid-wrap-macros 0.4.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate droid-wrap-macros 0.4.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate droid-wrap-macros 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7f161d56fdc955a984ffbb57990e4507444a3b395fffd63c3889d16a4ea12aa [INFO] running `Command { std: "docker" "start" "-a" "b7f161d56fdc955a984ffbb57990e4507444a3b395fffd63c3889d16a4ea12aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7f161d56fdc955a984ffbb57990e4507444a3b395fffd63c3889d16a4ea12aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7f161d56fdc955a984ffbb57990e4507444a3b395fffd63c3889d16a4ea12aa", kill_on_drop: false }` [INFO] [stdout] b7f161d56fdc955a984ffbb57990e4507444a3b395fffd63c3889d16a4ea12aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f15c6d146dd8f06ab6224c573fc9b7a86371e798031971199314241dbbf78c3 [INFO] running `Command { std: "docker" "start" "-a" "7f15c6d146dd8f06ab6224c573fc9b7a86371e798031971199314241dbbf78c3", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking proc-macro2 v1.0.103 [INFO] [stderr] Checking quote v1.0.41 [INFO] [stderr] Checking syn v2.0.108 [INFO] [stderr] Checking droid-wrap-macros v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `overload` after checking its variant with `is_none` [INFO] [stdout] --> src/java.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 226 | let name = if overload.is_none() { [INFO] [stdout] | --------------------- help: try: `if let Some() = overload` [INFO] [stdout] ... [INFO] [stdout] 229 | overload.unwrap().to_token_stream().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `overload` after checking its variant with `is_none` [INFO] [stdout] --> src/java.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 226 | let name = if overload.is_none() { [INFO] [stdout] | --------------------- help: try: `if let Some() = overload` [INFO] [stdout] ... [INFO] [stdout] 229 | overload.unwrap().to_token_stream().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/java.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 279 | if !self_.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self_.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/java.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 279 | if !self_.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self_.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/java.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | / match item { [INFO] [stdout] 347 | | ImplItem::Fn(f) => { [INFO] [stdout] 348 | | let name = f.sig.ident.clone(); [INFO] [stdout] 349 | | if name.to_string().starts_with("_") { [INFO] [stdout] ... | [INFO] [stdout] 399 | | _ => {} [INFO] [stdout] 400 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 346 ~ if let ImplItem::Fn(f) = item { [INFO] [stdout] 347 + let name = f.sig.ident.clone(); [INFO] [stdout] 348 + if name.to_string().starts_with("_") { [INFO] [stdout] 349 ~ // 跳过下划线开头的函数 [INFO] [stdout] 350 + continue; [INFO] [stdout] 351 + } [INFO] [stdout] 352 + let name_camel = f.sig.ident.to_string().to_lower_camel_case(); [INFO] [stdout] 353 + let (self_, arg_types, _, _, _, ret_type) = [INFO] [stdout] 354 + parse_function_signature(&f.sig, &vec![]); [INFO] [stdout] 355 + if self_.is_none() { [INFO] [stdout] 356 + continue; [INFO] [stdout] 357 + } [INFO] [stdout] 358 + [INFO] [stdout] 359 + let ret_token = match ret_type.to_string().as_str() { [INFO] [stdout] 360 + "()" => quote! {droid_wrap_utils::null_value(env)}, [INFO] [stdout] 361 + "bool" => quote! {droid_wrap_utils::wrapper_bool_value(_ret, env)}, [INFO] [stdout] 362 + "i32" => quote! {droid_wrap_utils::wrapper_integer_value(_ret, env)}, [INFO] [stdout] 363 + "u32" => quote! {droid_wrap_utils::wrapper_integer_value(_ret as u32, env)}, [INFO] [stdout] 364 + "i64" => quote! {droid_wrap_utils::wrapper_long_value(_ret, env)}, [INFO] [stdout] 365 + "u64" => quote! {droid_wrap_utils::wrapper_long_value(_ret as u64, env)}, [INFO] [stdout] 366 + _ => quote! {_ret.java_ref()}, [INFO] [stdout] 367 + }; [INFO] [stdout] 368 + [INFO] [stdout] 369 + let mut arg_tokens = TokenStream::new(); [INFO] [stdout] 370 + for i in 0..arg_types.len() { [INFO] [stdout] 371 + let (unwrapped_ty, origin_ty) = &arg_types[i]; [INFO] [stdout] 372 + let ty_str = unwrapped_ty.to_string(); [INFO] [stdout] 373 + let ar = if [ [INFO] [stdout] 374 + "bool", "char", "i16", "u16", "i32", "u32", "i64", "u64", "f32", "f64", [INFO] [stdout] 375 + ] [INFO] [stdout] 376 + .contains(&ty_str.as_str()) [INFO] [stdout] 377 + { [INFO] [stdout] 378 + quote! { [INFO] [stdout] 379 + droid_wrap_utils::ParseJObjectType::<#unwrapped_ty>::parse(&args2[#i], env) [INFO] [stdout] 380 + } [INFO] [stdout] 381 + } else { [INFO] [stdout] 382 + quote! {{ [INFO] [stdout] 383 + let r = env.new_global_ref(&args2[#i])?; [INFO] [stdout] 384 + #unwrapped_ty::_new(&r, Default::default()) [INFO] [stdout] 385 + }} [INFO] [stdout] 386 + }; [INFO] [stdout] 387 + let arg_form = get_type_form(&origin_ty, &None); [INFO] [stdout] 388 + arg_tokens.extend(quote! {#ar #arg_form,}); [INFO] [stdout] 389 + } [INFO] [stdout] 390 + methods.extend(quote! { [INFO] [stdout] 391 + #name_camel => { [INFO] [stdout] 392 + let args2 = droid_wrap_utils::to_vec(env, &args).unwrap_or_default(); [INFO] [stdout] 393 + let _ret = self_.#name(#arg_tokens); [INFO] [stdout] 394 + #ret_token [INFO] [stdout] 395 + }, [INFO] [stdout] 396 + }) [INFO] [stdout] 397 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/java.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | / match item { [INFO] [stdout] 347 | | ImplItem::Fn(f) => { [INFO] [stdout] 348 | | let name = f.sig.ident.clone(); [INFO] [stdout] 349 | | if name.to_string().starts_with("_") { [INFO] [stdout] ... | [INFO] [stdout] 399 | | _ => {} [INFO] [stdout] 400 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 346 ~ if let ImplItem::Fn(f) = item { [INFO] [stdout] 347 + let name = f.sig.ident.clone(); [INFO] [stdout] 348 + if name.to_string().starts_with("_") { [INFO] [stdout] 349 ~ // 跳过下划线开头的函数 [INFO] [stdout] 350 + continue; [INFO] [stdout] 351 + } [INFO] [stdout] 352 + let name_camel = f.sig.ident.to_string().to_lower_camel_case(); [INFO] [stdout] 353 + let (self_, arg_types, _, _, _, ret_type) = [INFO] [stdout] 354 + parse_function_signature(&f.sig, &vec![]); [INFO] [stdout] 355 + if self_.is_none() { [INFO] [stdout] 356 + continue; [INFO] [stdout] 357 + } [INFO] [stdout] 358 + [INFO] [stdout] 359 + let ret_token = match ret_type.to_string().as_str() { [INFO] [stdout] 360 + "()" => quote! {droid_wrap_utils::null_value(env)}, [INFO] [stdout] 361 + "bool" => quote! {droid_wrap_utils::wrapper_bool_value(_ret, env)}, [INFO] [stdout] 362 + "i32" => quote! {droid_wrap_utils::wrapper_integer_value(_ret, env)}, [INFO] [stdout] 363 + "u32" => quote! {droid_wrap_utils::wrapper_integer_value(_ret as u32, env)}, [INFO] [stdout] 364 + "i64" => quote! {droid_wrap_utils::wrapper_long_value(_ret, env)}, [INFO] [stdout] 365 + "u64" => quote! {droid_wrap_utils::wrapper_long_value(_ret as u64, env)}, [INFO] [stdout] 366 + _ => quote! {_ret.java_ref()}, [INFO] [stdout] 367 + }; [INFO] [stdout] 368 + [INFO] [stdout] 369 + let mut arg_tokens = TokenStream::new(); [INFO] [stdout] 370 + for i in 0..arg_types.len() { [INFO] [stdout] 371 + let (unwrapped_ty, origin_ty) = &arg_types[i]; [INFO] [stdout] 372 + let ty_str = unwrapped_ty.to_string(); [INFO] [stdout] 373 + let ar = if [ [INFO] [stdout] 374 + "bool", "char", "i16", "u16", "i32", "u32", "i64", "u64", "f32", "f64", [INFO] [stdout] 375 + ] [INFO] [stdout] 376 + .contains(&ty_str.as_str()) [INFO] [stdout] 377 + { [INFO] [stdout] 378 + quote! { [INFO] [stdout] 379 + droid_wrap_utils::ParseJObjectType::<#unwrapped_ty>::parse(&args2[#i], env) [INFO] [stdout] 380 + } [INFO] [stdout] 381 + } else { [INFO] [stdout] 382 + quote! {{ [INFO] [stdout] 383 + let r = env.new_global_ref(&args2[#i])?; [INFO] [stdout] 384 + #unwrapped_ty::_new(&r, Default::default()) [INFO] [stdout] 385 + }} [INFO] [stdout] 386 + }; [INFO] [stdout] 387 + let arg_form = get_type_form(&origin_ty, &None); [INFO] [stdout] 388 + arg_tokens.extend(quote! {#ar #arg_form,}); [INFO] [stdout] 389 + } [INFO] [stdout] 390 + methods.extend(quote! { [INFO] [stdout] 391 + #name_camel => { [INFO] [stdout] 392 + let args2 = droid_wrap_utils::to_vec(env, &args).unwrap_or_default(); [INFO] [stdout] 393 + let _ret = self_.#name(#arg_tokens); [INFO] [stdout] 394 + #ret_token [INFO] [stdout] 395 + }, [INFO] [stdout] 396 + }) [INFO] [stdout] 397 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `arg_types` [INFO] [stdout] --> src/java.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 371 | for i in 0..arg_types.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 371 - for i in 0..arg_types.len() { [INFO] [stdout] 371 + for (i, ) in arg_types.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `arg_types` [INFO] [stdout] --> src/java.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 371 | for i in 0..arg_types.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 371 - for i in 0..arg_types.len() { [INFO] [stdout] 371 + for (i, ) in arg_types.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/java.rs:388:50 [INFO] [stdout] | [INFO] [stdout] 388 | let arg_form = get_type_form(&origin_ty, &None); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `origin_ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/java.rs:388:50 [INFO] [stdout] | [INFO] [stdout] 388 | let arg_form = get_type_form(&origin_ty, &None); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `origin_ty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/utils.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | let based = match attrs.iter().find(|i| i.path.is_ident("extends")) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 40 | | Some(o) => Some(o.value.clone()), [INFO] [stdout] 41 | | None => None, [INFO] [stdout] 42 | | }; [INFO] [stdout] | |_________^ help: try: `attrs.iter().find(|i| i.path.is_ident("extends")).map(|o| o.value.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/utils.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | let based = match attrs.iter().find(|i| i.path.is_ident("extends")) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 40 | | Some(o) => Some(o.value.clone()), [INFO] [stdout] 41 | | None => None, [INFO] [stdout] 42 | | }; [INFO] [stdout] | |_________^ help: try: `attrs.iter().find(|i| i.path.is_ident("extends")).map(|o| o.value.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/utils.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 57 | let default_value = match attrs.iter().find(|i| i.path.is_ident("default_value")) { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 58 | | None => None, [INFO] [stdout] 59 | | Some(v) => Some(v.value.clone()), [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ help: try: `attrs.iter().find(|i| i.path.is_ident("default_value")).map(|v| v.value.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | / match item.value { [INFO] [stdout] 98 | | Expr::Tuple(ref t) => { [INFO] [stdout] 99 | | type_bounds.push(( [INFO] [stdout] 100 | | t.elems.first().to_token_stream(), [INFO] [stdout] ... | [INFO] [stdout] 104 | | _ => {} [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Expr::Tuple(ref t) = item.value { [INFO] [stdout] 98 + type_bounds.push(( [INFO] [stdout] 99 + t.elems.first().to_token_stream(), [INFO] [stdout] 100 + t.elems.iter().nth(1).to_token_stream(), [INFO] [stdout] 101 + )); [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/utils.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 57 | let default_value = match attrs.iter().find(|i| i.path.is_ident("default_value")) { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 58 | | None => None, [INFO] [stdout] 59 | | Some(v) => Some(v.value.clone()), [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ help: try: `attrs.iter().find(|i| i.path.is_ident("default_value")).map(|v| v.value.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | / match item.value { [INFO] [stdout] 98 | | Expr::Tuple(ref t) => { [INFO] [stdout] 99 | | type_bounds.push(( [INFO] [stdout] 100 | | t.elems.first().to_token_stream(), [INFO] [stdout] ... | [INFO] [stdout] 104 | | _ => {} [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Expr::Tuple(ref t) = item.value { [INFO] [stdout] 98 + type_bounds.push(( [INFO] [stdout] 99 + t.elems.first().to_token_stream(), [INFO] [stdout] 100 + t.elems.iter().nth(1).to_token_stream(), [INFO] [stdout] 101 + )); [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 135 | type_bounds: &Vec<(TokenStream, TokenStream)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 135 - type_bounds: &Vec<(TokenStream, TokenStream)>, [INFO] [stdout] 135 + type_bounds: &[(TokenStream, TokenStream)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 159 | .find(|i| i.ident.to_string() == ty.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `i.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 135 | type_bounds: &Vec<(TokenStream, TokenStream)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 135 - type_bounds: &Vec<(TokenStream, TokenStream)>, [INFO] [stdout] 135 + type_bounds: &[(TokenStream, TokenStream)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 159 | .find(|i| i.ident.to_string() == ty.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `i.ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/utils.rs:186:6 [INFO] [stdout] | [INFO] [stdout] 186 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 187 | | Option, [INFO] [stdout] 188 | | Vec<(TokenStream, TokenStream)>, [INFO] [stdout] 189 | | TokenStream, [INFO] [stdout] ... | [INFO] [stdout] 192 | | TokenStream, [INFO] [stdout] 193 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/utils.rs:186:6 [INFO] [stdout] | [INFO] [stdout] 186 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 187 | | Option, [INFO] [stdout] 188 | | Vec<(TokenStream, TokenStream)>, [INFO] [stdout] 189 | | TokenStream, [INFO] [stdout] ... | [INFO] [stdout] 192 | | TokenStream, [INFO] [stdout] 193 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SelfValue` which implements the `Copy` trait [INFO] [stdout] --> src/utils.rs:201:30 [INFO] [stdout] | [INFO] [stdout] 201 | self_ = Some(r.self_token.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r.self_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SelfValue` which implements the `Copy` trait [INFO] [stdout] --> src/utils.rs:201:30 [INFO] [stdout] | [INFO] [stdout] 201 | self_ = Some(r.self_token.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r.self_token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:228:87 [INFO] [stdout] | [INFO] [stdout] 228 | let arg_sig = get_type_descriptor_token(&unwrapped_ty, &sig.generics, &type_bounds); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `type_bounds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:228:87 [INFO] [stdout] | [INFO] [stdout] 228 | let arg_sig = get_type_descriptor_token(&unwrapped_ty, &sig.generics, &type_bounds); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `type_bounds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:259:75 [INFO] [stdout] | [INFO] [stdout] 259 | let ret_type_sig = get_type_descriptor_token(&unwrapped_ty, generics, &type_bounds); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `type_bounds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:259:75 [INFO] [stdout] | [INFO] [stdout] 259 | let ret_type_sig = get_type_descriptor_token(&unwrapped_ty, generics, &type_bounds); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `type_bounds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.04s [INFO] running `Command { std: "docker" "inspect" "7f15c6d146dd8f06ab6224c573fc9b7a86371e798031971199314241dbbf78c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f15c6d146dd8f06ab6224c573fc9b7a86371e798031971199314241dbbf78c3", kill_on_drop: false }` [INFO] [stdout] 7f15c6d146dd8f06ab6224c573fc9b7a86371e798031971199314241dbbf78c3