[INFO] fetching crate draviavemal-xml_rs 1.0.3-alpha.1... [INFO] linting draviavemal-xml_rs-1.0.3-alpha.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate draviavemal-xml_rs 1.0.3-alpha.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate draviavemal-xml_rs 1.0.3-alpha.1 [INFO] finished tweaking crates.io crate draviavemal-xml_rs 1.0.3-alpha.1 [INFO] tweaked toml for crates.io crate draviavemal-xml_rs 1.0.3-alpha.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate draviavemal-xml_rs 1.0.3-alpha.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate draviavemal-xml_rs 1.0.3-alpha.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a5acd0ac70243daf19af4546e1f63f95ac63a8ac5fdb6b312aa3b4947950f4f [INFO] running `Command { std: "docker" "start" "-a" "9a5acd0ac70243daf19af4546e1f63f95ac63a8ac5fdb6b312aa3b4947950f4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a5acd0ac70243daf19af4546e1f63f95ac63a8ac5fdb6b312aa3b4947950f4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a5acd0ac70243daf19af4546e1f63f95ac63a8ac5fdb6b312aa3b4947950f4f", kill_on_drop: false }` [INFO] [stdout] 9a5acd0ac70243daf19af4546e1f63f95ac63a8ac5fdb6b312aa3b4947950f4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2307c89782b9e358696e985f0473170fa728a74a9b1c7a221afacfb3f9b5529a [INFO] running `Command { std: "docker" "start" "-a" "2307c89782b9e358696e985f0473170fa728a74a9b1c7a221afacfb3f9b5529a", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Compiling draviavemal-xml_rs v1.0.3-alpha.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stdout] warning: glob import doesn't reexport anything with visibility `pub` because no imported item is public enough [INFO] [stdout] --> src/dom/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub use xpath::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the most public imported item is `pub(crate)` [INFO] [stdout] --> src/dom/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub use xpath::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = help: reduce the glob import's visibility or increase visibility of imported items [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xpath_handler` [INFO] [stdout] --> src/dom/document.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | let xpath_handler = XPathHandler::new(query_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xpath_handler` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XPathPart` is never constructed [INFO] [stdout] --> src/dom/xpath.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct XPathPart{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `primary_query`, `path_type`, and `path_group` are never read [INFO] [stdout] --> src/dom/xpath.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) struct XPathHandler { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 18 | primary_query: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 19 | path_type: PathType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 20 | path_group: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XPathHandler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: glob import doesn't reexport anything with visibility `pub` because no imported item is public enough [INFO] [stdout] --> src/dom/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub use xpath::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the most public imported item is `pub(crate)` [INFO] [stdout] --> src/dom/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub use xpath::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = help: reduce the glob import's visibility or increase visibility of imported items [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clone` can be confused for the standard trait method `std::clone::Clone::clone` [INFO] [stdout] --> src/dom/document.rs:321:5 [INFO] [stdout] | [INFO] [stdout] 321 | / pub fn clone(&self) -> XmlDocument { [INFO] [stdout] 322 | | XmlDocument { [INFO] [stdout] 323 | | version: self.version.clone(), [INFO] [stdout] 324 | | encoding: self.encoding.clone(), [INFO] [stdout] ... | [INFO] [stdout] 334 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::clone::Clone` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/dom/document.rs:460:40 [INFO] [stdout] | [INFO] [stdout] 460 | return Ok(Some(child_id.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*child_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dom/element.rs:100:35 [INFO] [stdout] | [INFO] [stdout] 100 | attributes.retain(|a| !(a.get_ns_name() == ns_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(a.get_ns_name() != ns_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/dom/element.rs:228:31 [INFO] [stdout] | [INFO] [stdout] 228 | .filter(|content| match content { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 229 | | XmlElementContentType::Element(_) => true, [INFO] [stdout] 230 | | _ => false, [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 228 - .filter(|content| match content { [INFO] [stdout] 229 - XmlElementContentType::Element(_) => true, [INFO] [stdout] 230 - _ => false, [INFO] [stdout] 231 - }) [INFO] [stdout] 228 + .filter(|content| matches!(content, XmlElementContentType::Element(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/dom/element.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | *first_id as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*first_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/dom/element.rs:574:17 [INFO] [stdout] | [INFO] [stdout] 574 | *first_id as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*first_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/dom/element.rs:669:24 [INFO] [stdout] | [INFO] [stdout] 669 | parent_id: self.parent_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.parent_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/element.rs:751:30 [INFO] [stdout] | [INFO] [stdout] 751 | if is_valid_xml_name(&tag) { [INFO] [stdout] | ^^^^ help: change this to: `tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xpath_handler` [INFO] [stdout] --> src/dom/document.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | let xpath_handler = XPathHandler::new(query_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xpath_handler` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XPathPart` is never constructed [INFO] [stdout] --> src/dom/xpath.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct XPathPart{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `primary_query`, `path_type`, and `path_group` are never read [INFO] [stdout] --> src/dom/xpath.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) struct XPathHandler { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 18 | primary_query: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 19 | path_type: PathType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 20 | path_group: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XPathHandler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clone` can be confused for the standard trait method `std::clone::Clone::clone` [INFO] [stdout] --> src/dom/document.rs:321:5 [INFO] [stdout] | [INFO] [stdout] 321 | / pub fn clone(&self) -> XmlDocument { [INFO] [stdout] 322 | | XmlDocument { [INFO] [stdout] 323 | | version: self.version.clone(), [INFO] [stdout] 324 | | encoding: self.encoding.clone(), [INFO] [stdout] ... | [INFO] [stdout] 334 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::clone::Clone` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/dom/document.rs:460:40 [INFO] [stdout] | [INFO] [stdout] 460 | return Ok(Some(child_id.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*child_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dom/element.rs:100:35 [INFO] [stdout] | [INFO] [stdout] 100 | attributes.retain(|a| !(a.get_ns_name() == ns_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(a.get_ns_name() != ns_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.89s [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/dom/element.rs:228:31 [INFO] [stdout] | [INFO] [stdout] 228 | .filter(|content| match content { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 229 | | XmlElementContentType::Element(_) => true, [INFO] [stdout] 230 | | _ => false, [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 228 - .filter(|content| match content { [INFO] [stdout] 229 - XmlElementContentType::Element(_) => true, [INFO] [stdout] 230 - _ => false, [INFO] [stdout] 231 - }) [INFO] [stdout] 228 + .filter(|content| matches!(content, XmlElementContentType::Element(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/dom/element.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | *first_id as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*first_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/dom/element.rs:574:17 [INFO] [stdout] | [INFO] [stdout] 574 | *first_id as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(*first_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/dom/element.rs:669:24 [INFO] [stdout] | [INFO] [stdout] 669 | parent_id: self.parent_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.parent_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dom/element.rs:751:30 [INFO] [stdout] | [INFO] [stdout] 751 | if is_valid_xml_name(&tag) { [INFO] [stdout] | ^^^^ help: change this to: `tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "2307c89782b9e358696e985f0473170fa728a74a9b1c7a221afacfb3f9b5529a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2307c89782b9e358696e985f0473170fa728a74a9b1c7a221afacfb3f9b5529a", kill_on_drop: false }` [INFO] [stdout] 2307c89782b9e358696e985f0473170fa728a74a9b1c7a221afacfb3f9b5529a