[INFO] fetching crate dptree 0.5.1... [INFO] linting dptree-0.5.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate dptree 0.5.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate dptree 0.5.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate dptree 0.5.1 [INFO] tweaked toml for crates.io crate dptree 0.5.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate dptree 0.5.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate dptree 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio v1.45.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca20a42c99fd616034757caf645ad5b984e240851115a6c10cb3080a4c577928 [INFO] running `Command { std: "docker" "start" "-a" "ca20a42c99fd616034757caf645ad5b984e240851115a6c10cb3080a4c577928", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca20a42c99fd616034757caf645ad5b984e240851115a6c10cb3080a4c577928", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca20a42c99fd616034757caf645ad5b984e240851115a6c10cb3080a4c577928", kill_on_drop: false }` [INFO] [stdout] ca20a42c99fd616034757caf645ad5b984e240851115a6c10cb3080a4c577928 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6c5a9ad784fee36075ed51e4baa1c4ec968563cc3cbb91e30f9ba0019617b67 [INFO] running `Command { std: "docker" "start" "-a" "b6c5a9ad784fee36075ed51e4baa1c4ec968563cc3cbb91e30f9ba0019617b67", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking dptree v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> src/handler/core.rs:630:25 [INFO] [stdout] | [INFO] [stdout] 630 | / obligations.iter().filter_map(|(ty, _location)| { [INFO] [stdout] 631 | | if !container_types.contains(ty) { [INFO] [stdout] 632 | | Some(ty) [INFO] [stdout] 633 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 636 | | }), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 630 ~ obligations.keys().filter_map(|ty| { [INFO] [stdout] 631 + if !container_types.contains(ty) { [INFO] [stdout] 632 + Some(ty) [INFO] [stdout] 633 + } else { [INFO] [stdout] 634 + None [INFO] [stdout] 635 + } [INFO] [stdout] 636 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/di.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | keys1.len() == keys2.len() && keys1.zip(keys2).map(|(k1, k2)| k1 == k2).all(|x| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 96 - keys1.len() == keys2.len() && keys1.zip(keys2).map(|(k1, k2)| k1 == k2).all(|x| x) [INFO] [stdout] 96 + keys1.len() == keys2.len() && keys1.zip(keys2).all(|(k1, k2)| k1 == k2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> src/handler/core.rs:630:25 [INFO] [stdout] | [INFO] [stdout] 630 | / obligations.iter().filter_map(|(ty, _location)| { [INFO] [stdout] 631 | | if !container_types.contains(ty) { [INFO] [stdout] 632 | | Some(ty) [INFO] [stdout] 633 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 636 | | }), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 630 ~ obligations.keys().filter_map(|ty| { [INFO] [stdout] 631 + if !container_types.contains(ty) { [INFO] [stdout] 632 + Some(ty) [INFO] [stdout] 633 + } else { [INFO] [stdout] 634 + None [INFO] [stdout] 635 + } [INFO] [stdout] 636 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handler/core.rs:1007:17 [INFO] [stdout] | [INFO] [stdout] 1007 | assert!(!(ta1 == ta2)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(ta1 != ta2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handler/core.rs:1009:17 [INFO] [stdout] | [INFO] [stdout] 1009 | assert!(!(ta1 > ta2)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(ta1 <= ta2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).all(identity)` [INFO] [stdout] --> src/di.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | keys1.len() == keys2.len() && keys1.zip(keys2).map(|(k1, k2)| k1 == k2).all(|x| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.all(...)` instead [INFO] [stdout] | [INFO] [stdout] 96 - keys1.len() == keys2.len() && keys1.zip(keys2).map(|(k1, k2)| k1 == k2).all(|x| x) [INFO] [stdout] 96 + keys1.len() == keys2.len() && keys1.zip(keys2).all(|(k1, k2)| k1 == k2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.01s [INFO] running `Command { std: "docker" "inspect" "b6c5a9ad784fee36075ed51e4baa1c4ec968563cc3cbb91e30f9ba0019617b67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6c5a9ad784fee36075ed51e4baa1c4ec968563cc3cbb91e30f9ba0019617b67", kill_on_drop: false }` [INFO] [stdout] b6c5a9ad784fee36075ed51e4baa1c4ec968563cc3cbb91e30f9ba0019617b67