[INFO] fetching crate dough 0.1.3... [INFO] linting dough-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate dough 0.1.3 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate dough 0.1.3 [INFO] finished tweaking crates.io crate dough 0.1.3 [INFO] tweaked toml for crates.io crate dough 0.1.3 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate dough 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96218230df2c04b89c2a6be2a1d105c47843b3299afd8bda0ccd80e725c8668b [INFO] running `Command { std: "docker" "start" "-a" "96218230df2c04b89c2a6be2a1d105c47843b3299afd8bda0ccd80e725c8668b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96218230df2c04b89c2a6be2a1d105c47843b3299afd8bda0ccd80e725c8668b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96218230df2c04b89c2a6be2a1d105c47843b3299afd8bda0ccd80e725c8668b", kill_on_drop: false }` [INFO] [stdout] 96218230df2c04b89c2a6be2a1d105c47843b3299afd8bda0ccd80e725c8668b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7e751d3375afd3ccf9967aa740dfc0aa2288465d236eb182622df1619968dc0 [INFO] running `Command { std: "docker" "start" "-a" "d7e751d3375afd3ccf9967aa740dfc0aa2288465d236eb182622df1619968dc0", kill_on_drop: false }` [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking dough v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ctor.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return { [INFO] [stdout] 29 | | quote! { [INFO] [stdout] 30 | | impl #impl_gen #struct_name #ty_gen #where_clause { [INFO] [stdout] 31 | | #func new() -> Self { [INFO] [stdout] ... | [INFO] [stdout] 37 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ { [INFO] [stdout] 29 + quote! { [INFO] [stdout] 30 + impl #impl_gen #struct_name #ty_gen #where_clause { [INFO] [stdout] 31 + #func new() -> Self { [INFO] [stdout] 32 + Self {} [INFO] [stdout] 33 + } [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] 36 + } [INFO] [stdout] 37 ~ .into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gtor.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if (is_skipped && is_explicitly_copy) || (is_explicitly_copy && is_phantom) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - if (is_skipped && is_explicitly_copy) || (is_explicitly_copy && is_phantom) { [INFO] [stdout] 68 + if !(!is_explicitly_copy || !is_skipped && !is_phantom) { [INFO] [stdout] | [INFO] [stdout] 68 - if (is_skipped && is_explicitly_copy) || (is_explicitly_copy && is_phantom) { [INFO] [stdout] 68 + if (is_phantom || is_skipped) && is_explicitly_copy { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gtor.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | return "".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return "".parse().unwrap(); [INFO] [stdout] 145 + "".parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/stor.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return "".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return "".parse().unwrap(); [INFO] [stdout] 57 + "".parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stor.rs:28:73 [INFO] [stdout] | [INFO] [stdout] 28 | let is_skipped = ok_else_ret!(util::single_instance_of_attr(&attrs, ATTR_STOR_SKIP)); [INFO] [stdout] | ^^^^^^ help: change this to: `attrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/util.rs:15:6 [INFO] [stdout] | [INFO] [stdout] 15 | ) -> Result)>, TokenStream> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ctor.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return { [INFO] [stdout] 29 | | quote! { [INFO] [stdout] 30 | | impl #impl_gen #struct_name #ty_gen #where_clause { [INFO] [stdout] 31 | | #func new() -> Self { [INFO] [stdout] ... | [INFO] [stdout] 37 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ { [INFO] [stdout] 29 + quote! { [INFO] [stdout] 30 + impl #impl_gen #struct_name #ty_gen #where_clause { [INFO] [stdout] 31 + #func new() -> Self { [INFO] [stdout] 32 + Self {} [INFO] [stdout] 33 + } [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] 36 + } [INFO] [stdout] 37 ~ .into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gtor.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if (is_skipped && is_explicitly_copy) || (is_explicitly_copy && is_phantom) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - if (is_skipped && is_explicitly_copy) || (is_explicitly_copy && is_phantom) { [INFO] [stdout] 68 + if !(!is_explicitly_copy || !is_skipped && !is_phantom) { [INFO] [stdout] | [INFO] [stdout] 68 - if (is_skipped && is_explicitly_copy) || (is_explicitly_copy && is_phantom) { [INFO] [stdout] 68 + if (is_phantom || is_skipped) && is_explicitly_copy { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gtor.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | return "".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return "".parse().unwrap(); [INFO] [stdout] 145 + "".parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/stor.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return "".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return "".parse().unwrap(); [INFO] [stdout] 57 + "".parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stor.rs:28:73 [INFO] [stdout] | [INFO] [stdout] 28 | let is_skipped = ok_else_ret!(util::single_instance_of_attr(&attrs, ATTR_STOR_SKIP)); [INFO] [stdout] | ^^^^^^ help: change this to: `attrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/util.rs:15:6 [INFO] [stdout] | [INFO] [stdout] 15 | ) -> Result)>, TokenStream> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.16s [INFO] running `Command { std: "docker" "inspect" "d7e751d3375afd3ccf9967aa740dfc0aa2288465d236eb182622df1619968dc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7e751d3375afd3ccf9967aa740dfc0aa2288465d236eb182622df1619968dc0", kill_on_drop: false }` [INFO] [stdout] d7e751d3375afd3ccf9967aa740dfc0aa2288465d236eb182622df1619968dc0