[INFO] fetching crate docify_macros_clone 0.0.5... [INFO] linting docify_macros_clone-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate docify_macros_clone 0.0.5 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate docify_macros_clone 0.0.5 [INFO] finished tweaking crates.io crate docify_macros_clone 0.0.5 [INFO] tweaked toml for crates.io crate docify_macros_clone 0.0.5 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate docify_macros_clone 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 198 packages to latest compatible versions [INFO] [stderr] Adding git2 v0.13.25 (available: v0.20.4) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] [stderr] Adding toml v0.8.23 (available: v1.0.7+spec-1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 850205d90f354000188c38776a76b71d7a70d5605a3ead89d22f89b430a922e2 [INFO] running `Command { std: "docker" "start" "-a" "850205d90f354000188c38776a76b71d7a70d5605a3ead89d22f89b430a922e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "850205d90f354000188c38776a76b71d7a70d5605a3ead89d22f89b430a922e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "850205d90f354000188c38776a76b71d7a70d5605a3ead89d22f89b430a922e2", kill_on_drop: false }` [INFO] [stdout] 850205d90f354000188c38776a76b71d7a70d5605a3ead89d22f89b430a922e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd2c208fee482c9de043b0319d9d6c6289dd781693d11aca4c26ee2f4dbf0f23 [INFO] running `Command { std: "docker" "start" "-a" "fd2c208fee482c9de043b0319d9d6c6289dd781693d11aca4c26ee2f4dbf0f23", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.183 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking serde_core v1.0.228 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking winnow v0.7.15 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking syn v2.0.117 [INFO] [stderr] Compiling derive-syn-parse v0.2.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking common-path v1.0.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling libz-sys v1.1.25 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.12.26+1.3.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking git2 v0.13.25 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking docify_macros_clone v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:170:19 [INFO] [stdout] | [INFO] [stdout] 170 | const DOCIFYING: &'static str = " Docifying "; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:170:19 [INFO] [stdout] | [INFO] [stdout] 170 | const DOCIFYING: &'static str = " Docifying "; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 110 | let source = fix_leading_indentation(source); [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 111 | source [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 110 ~ [INFO] [stdout] 111 ~ fix_leading_indentation(source) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:134:54 [INFO] [stdout] | [INFO] [stdout] 134 | let Ok(cargo_toml) = std::fs::read_to_string(&entry.path()) else { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 110 | let source = fix_leading_indentation(source); [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 111 | source [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 110 ~ [INFO] [stdout] 111 ~ fix_leading_indentation(source) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 177 | if let Err(_) = write!(&mut stdout, "{}", st.as_ref()) { [INFO] [stdout] | -------^^^^^^----------------------------------------- help: try: `if write!(&mut stdout, "{}", st.as_ref()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:134:54 [INFO] [stdout] | [INFO] [stdout] 134 | let Ok(cargo_toml) = std::fs::read_to_string(&entry.path()) else { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/lib.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 177 | if let Err(_) = write!(&mut stdout, "{}", st.as_ref()) { [INFO] [stdout] | -------^^^^^^----------------------------------------- help: try: `if write!(&mut stdout, "{}", st.as_ref()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:304:18 [INFO] [stdout] | [INFO] [stdout] 304 | _ => &EMPTY, [INFO] [stdout] | ^^^^^^ help: change this to: `EMPTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 329 | _ => &EMPTY, [INFO] [stdout] | ^^^^^^ help: change this to: `EMPTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:304:18 [INFO] [stdout] | [INFO] [stdout] 304 | _ => &EMPTY, [INFO] [stdout] | ^^^^^^ help: change this to: `EMPTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 329 | _ => &EMPTY, [INFO] [stdout] | ^^^^^^ help: change this to: `EMPTY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 645 | for attr in attrs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (i, attr) in attrs.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/lib.rs:669:37 [INFO] [stdout] | [INFO] [stdout] 669 | Meta::List(list) => match parse2::(list.tokens.clone()) { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 670 | | Ok(ident) => Some(ident), [INFO] [stdout] 671 | | Err(_) => None, [INFO] [stdout] 672 | | }, [INFO] [stdout] | |_________________^ help: replace with: `parse2::(list.tokens.clone()).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 645 | for attr in attrs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (i, attr) in attrs.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/lib.rs:669:37 [INFO] [stdout] | [INFO] [stdout] 669 | Meta::List(list) => match parse2::(list.tokens.clone()) { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 670 | | Ok(ident) => Some(ident), [INFO] [stdout] 671 | | Err(_) => None, [INFO] [stdout] 672 | | }, [INFO] [stdout] | |_________________^ help: replace with: `parse2::(list.tokens.clone()).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:768:34 [INFO] [stdout] | [INFO] [stdout] 768 | pub fn claim(&self, claimed: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 768 - pub fn claim(&self, claimed: &mut Vec) { [INFO] [stdout] 768 + pub fn claim(&self, claimed: &mut [bool]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:775:39 [INFO] [stdout] | [INFO] [stdout] 775 | pub fn is_claimed(&self, claimed: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 775 - pub fn is_claimed(&self, claimed: &Vec) -> bool { [INFO] [stdout] 775 + pub fn is_claimed(&self, claimed: &[bool]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:768:34 [INFO] [stdout] | [INFO] [stdout] 768 | pub fn claim(&self, claimed: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 768 - pub fn claim(&self, claimed: &mut Vec) { [INFO] [stdout] 768 + pub fn claim(&self, claimed: &mut [bool]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `CompressedString` [INFO] [stdout] --> src/lib.rs:797:5 [INFO] [stdout] | [INFO] [stdout] 797 | / fn to_string(&self) -> String { [INFO] [stdout] 798 | | self.chars_arr.iter().map(|c| c.char).collect() [INFO] [stdout] 799 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `CompressedString` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:775:39 [INFO] [stdout] | [INFO] [stdout] 775 | pub fn is_claimed(&self, claimed: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 775 - pub fn is_claimed(&self, claimed: &Vec) -> bool { [INFO] [stdout] 775 + pub fn is_claimed(&self, claimed: &[bool]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `CompressedString` [INFO] [stdout] --> src/lib.rs:797:5 [INFO] [stdout] | [INFO] [stdout] 797 | / fn to_string(&self) -> String { [INFO] [stdout] 798 | | self.chars_arr.iter().map(|c| c.char).collect() [INFO] [stdout] 799 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `CompressedString` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:879:23 [INFO] [stdout] | [INFO] [stdout] 879 | fn get_content_tokens<'a>(item: &'a Item) -> TokenStream2 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 879 - fn get_content_tokens<'a>(item: &'a Item) -> TokenStream2 { [INFO] [stdout] 879 + fn get_content_tokens(item: &Item) -> TokenStream2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:879:23 [INFO] [stdout] | [INFO] [stdout] 879 | fn get_content_tokens<'a>(item: &'a Item) -> TokenStream2 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 879 - fn get_content_tokens<'a>(item: &'a Item) -> TokenStream2 { [INFO] [stdout] 879 + fn get_content_tokens(item: &Item) -> TokenStream2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:959:24 [INFO] [stdout] | [INFO] [stdout] 959 | .filter(|line| !(DOCIFY_ATTRIBUTES.is_match(line) && !line.trim().starts_with("//"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!DOCIFY_ATTRIBUTES.is_match(line) || line.trim().starts_with("//")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:959:24 [INFO] [stdout] | [INFO] [stdout] 959 | .filter(|line| !(DOCIFY_ATTRIBUTES.is_match(line) && !line.trim().starts_with("//"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!DOCIFY_ATTRIBUTES.is_match(line) || line.trim().starts_with("//")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/lib.rs:1073:21 [INFO] [stdout] | [INFO] [stdout] 1073 | "=>", // TODO: fancy arrow [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1071 ~ "{} => {}", [INFO] [stdout] 1072 ~ prettify_path(&input_path).display(), // TODO: fancy arrow [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/lib.rs:1073:21 [INFO] [stdout] | [INFO] [stdout] 1073 | "=>", // TODO: fancy arrow [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1071 ~ "{} => {}", [INFO] [stdout] 1072 ~ prettify_path(&input_path).display(), // TODO: fancy arrow [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:1169:55 [INFO] [stdout] | [INFO] [stdout] 1169 | let dest_path = transpose_subpath(&input_dir, &src_path, &output_dir); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `src_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/lib.rs:1175:17 [INFO] [stdout] | [INFO] [stdout] 1175 | "=>", // TODO: fancy arrow [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1173 ~ "{} => {}", [INFO] [stdout] 1174 ~ prettify_path(&src_path).display(), // TODO: fancy arrow [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:1174:31 [INFO] [stdout] | [INFO] [stdout] 1174 | prettify_path(&src_path).display(), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `src_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:1169:55 [INFO] [stdout] | [INFO] [stdout] 1169 | let dest_path = transpose_subpath(&input_dir, &src_path, &output_dir); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `src_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/lib.rs:1175:17 [INFO] [stdout] | [INFO] [stdout] 1175 | "=>", // TODO: fancy arrow [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1173 ~ "{} => {}", [INFO] [stdout] 1174 ~ prettify_path(&src_path).display(), // TODO: fancy arrow [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:1174:31 [INFO] [stdout] | [INFO] [stdout] 1174 | prettify_path(&src_path).display(), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `src_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.15s [INFO] running `Command { std: "docker" "inspect" "fd2c208fee482c9de043b0319d9d6c6289dd781693d11aca4c26ee2f4dbf0f23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd2c208fee482c9de043b0319d9d6c6289dd781693d11aca4c26ee2f4dbf0f23", kill_on_drop: false }` [INFO] [stdout] fd2c208fee482c9de043b0319d9d6c6289dd781693d11aca4c26ee2f4dbf0f23