[INFO] fetching crate direct-asm 0.0.1-alpha...
[INFO] linting direct-asm-0.0.1-alpha against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate direct-asm 0.0.1-alpha into /workspace/builds/worker-0-tc1/source
[INFO] started tweaking crates.io crate direct-asm 0.0.1-alpha
[INFO] finished tweaking crates.io crate direct-asm 0.0.1-alpha
[INFO] tweaked toml for crates.io crate direct-asm 0.0.1-alpha written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate direct-asm 0.0.1-alpha on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 20 packages to latest compatible versions
[INFO] [stderr]       Adding rand v0.7.3 (available: v0.10.0)
[INFO] [stderr]       Adding syn v1.0.109 (available: v2.0.117)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded dynasm-lib v0.1.0-alpha
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0de7008080aa0c5f19fa760ba67ad185042df9357584712261e54d4ce0c610c9
[INFO] running `Command { std: "docker" "start" "-a" "0de7008080aa0c5f19fa760ba67ad185042df9357584712261e54d4ce0c610c9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0de7008080aa0c5f19fa760ba67ad185042df9357584712261e54d4ce0c610c9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0de7008080aa0c5f19fa760ba67ad185042df9357584712261e54d4ce0c610c9", kill_on_drop: false }`
[INFO] [stdout] 0de7008080aa0c5f19fa760ba67ad185042df9357584712261e54d4ce0c610c9
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] fd2e9179afbe20b17124ae06ef9a115b8a7b9cc0df75bcf7ac3607f5cbe5021f
[INFO] running `Command { std: "docker" "start" "-a" "fd2e9179afbe20b17124ae06ef9a115b8a7b9cc0df75bcf7ac3607f5cbe5021f", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.183
[INFO] [stderr]     Checking lazy_static v1.5.0
[INFO] [stderr]     Checking byteorder v1.5.0
[INFO] [stderr]     Checking bitflags v1.3.2
[INFO] [stderr]    Compiling zerocopy v0.8.42
[INFO] [stderr]    Compiling getrandom v0.1.16
[INFO] [stderr]     Checking syn v1.0.109
[INFO] [stderr]     Checking dynasm-lib v0.1.0-alpha
[INFO] [stderr]     Checking rand_core v0.5.1
[INFO] [stderr]     Checking ppv-lite86 v0.2.21
[INFO] [stderr]     Checking rand_chacha v0.2.2
[INFO] [stderr]     Checking rand v0.7.3
[INFO] [stderr]     Checking direct-asm v0.0.1-alpha (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused variable: `st`
[INFO] [stdout]    --> src/att.rs:324:17
[INFO] [stdout]     |
[INFO] [stdout] 324 |     fn from_str(st: &str) -> Result<Self, Error> {
[INFO] [stdout]     |                 ^^ help: if this is intentional, prefix it with an underscore: `_st`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `st`
[INFO] [stdout]    --> src/att.rs:324:17
[INFO] [stdout]     |
[INFO] [stdout] 324 |     fn from_str(st: &str) -> Result<Self, Error> {
[INFO] [stdout]     |                 ^^ help: if this is intentional, prefix it with an underscore: `_st`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/att.rs:97:21
[INFO] [stdout]    |
[INFO] [stdout] 97 |                     arg.push_str(" ");
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `arg.push(' ')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]    = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/att.rs:104:37
[INFO] [stdout]     |
[INFO] [stdout] 104 |                       let last_name = self.name_parts.pop()
[INFO] [stdout]     |  _____________________________________^
[INFO] [stdout] 105 | |                         .ok_or_else(|| Error::NoOpcodeOnlyArguments)?;
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 105 -                         .ok_or_else(|| Error::NoOpcodeOnlyArguments)?;
[INFO] [stdout] 105 +                         .ok_or(Error::NoOpcodeOnlyArguments)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/att.rs:114:17
[INFO] [stdout]     |
[INFO] [stdout] 114 | /                 if self.arguments.is_empty() {
[INFO] [stdout] 115 | |                     if self.name_parts.len() > 1 {
[INFO] [stdout] 116 | |                         self.arguments.push(self.name_parts.pop().unwrap());
[INFO] [stdout] 117 | |                     }
[INFO] [stdout] 118 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 114 ~                 if self.arguments.is_empty()
[INFO] [stdout] 115 ~                     && self.name_parts.len() > 1 {
[INFO] [stdout] 116 |                         self.arguments.push(self.name_parts.pop().unwrap());
[INFO] [stdout] 117 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/att.rs:174:35
[INFO] [stdout]     |
[INFO] [stdout] 174 |                     let closing = after.find(')').ok_or_else(|| Error::NoClosingParen)?;
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 174 -                     let closing = after.find(')').ok_or_else(|| Error::NoClosingParen)?;
[INFO] [stdout] 174 +                     let closing = after.find(')').ok_or(Error::NoClosingParen)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/att.rs:210:23
[INFO] [stdout]     |
[INFO] [stdout] 210 |                 name: st[1..].to_string(),
[INFO] [stdout]     |                       ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/att.rs:208:9
[INFO] [stdout]     |
[INFO] [stdout] 208 |         if st.starts_with('.') {
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]     = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 208 ~         if let Some(<stripped>) = st.strip_prefix('.') {
[INFO] [stdout] 209 |             LineKind::Directive(Directive {
[INFO] [stdout] 210 ~                 name: <stripped>.to_string(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]    --> src/att.rs:238:42
[INFO] [stdout]     |
[INFO] [stdout] 238 |             LineKind::Statement(stmt) => Ok(stmt.add_prefix_or_name(arg)),
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout]     = note: `#[warn(clippy::unit_arg)]` on by default
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]     |
[INFO] [stdout] 238 ~             LineKind::Statement(stmt) => {
[INFO] [stdout] 239 +                 let _: () = stmt.add_prefix_or_name(arg);
[INFO] [stdout] 240 +                 Ok(())
[INFO] [stdout] 241 ~             },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]    --> src/att.rs:245:47
[INFO] [stdout]     |
[INFO] [stdout] 245 |             LineKind::Directive(directive) => Ok(directive.add_argument(arg)),
[INFO] [stdout]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]     |
[INFO] [stdout] 245 ~             LineKind::Directive(directive) => {
[INFO] [stdout] 246 +                 let _: () = directive.add_argument(arg);
[INFO] [stdout] 247 +                 Ok(())
[INFO] [stdout] 248 ~             },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]    --> src/att.rs:267:17
[INFO] [stdout]     |
[INFO] [stdout] 267 |                 Ok(self.arguments.push(argument))
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]     |
[INFO] [stdout] 267 ~                 self.arguments.push(argument);
[INFO] [stdout] 268 +                 Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout] 276 | |     || ch == ':'
[INFO] [stdout] 277 | |     || ch == '('
[INFO] [stdout] 278 | |     || ch == ' '
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';' || ch == ':' || ch == '(' || ch == ' '`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout] 276 | |     || ch == ':'
[INFO] [stdout] 277 | |     || ch == '('
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';' || ch == ':' || ch == '('`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout] 276 | |     || ch == ':'
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';' || ch == ':'`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';'`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout]     | |________________^ help: try: `ch == ','`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `as_statement` and `as_directive` are never used
[INFO] [stdout]    --> src/att.rs:193:12
[INFO] [stdout]     |
[INFO] [stdout] 192 | impl LineKind {
[INFO] [stdout]     | ------------- methods in this implementation
[INFO] [stdout] 193 |     pub fn as_statement(&self) -> Option<&Statement> {
[INFO] [stdout]     |            ^^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 200 |     pub fn as_directive(&self) -> Option<&Directive> {
[INFO] [stdout]     |            ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/att.rs:313:35
[INFO] [stdout]     |
[INFO] [stdout] 313 |             Ok(Argument::Register(st[1..].to_string()))
[INFO] [stdout]     |                                   ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/att.rs:312:16
[INFO] [stdout]     |
[INFO] [stdout] 312 |         } else if st.starts_with('%') {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 312 ~         } else if let Some(<stripped>) = st.strip_prefix('%') {
[INFO] [stdout] 313 ~             Ok(Argument::Register(<stripped>.to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/att.rs:315:25
[INFO] [stdout]     |
[INFO] [stdout] 315 |             let value = st.parse().ok().ok_or_else(|| Error::InvalidImmediateValue)?;
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 315 -             let value = st.parse().ok().ok_or_else(|| Error::InvalidImmediateValue)?;
[INFO] [stdout] 315 +             let value = st.parse().ok().ok_or(Error::InvalidImmediateValue)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/att.rs:97:21
[INFO] [stdout]    |
[INFO] [stdout] 97 |                     arg.push_str(" ");
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `arg.push(' ')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]    = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/att.rs:104:37
[INFO] [stdout]     |
[INFO] [stdout] 104 |                       let last_name = self.name_parts.pop()
[INFO] [stdout]     |  _____________________________________^
[INFO] [stdout] 105 | |                         .ok_or_else(|| Error::NoOpcodeOnlyArguments)?;
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 105 -                         .ok_or_else(|| Error::NoOpcodeOnlyArguments)?;
[INFO] [stdout] 105 +                         .ok_or(Error::NoOpcodeOnlyArguments)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/att.rs:114:17
[INFO] [stdout]     |
[INFO] [stdout] 114 | /                 if self.arguments.is_empty() {
[INFO] [stdout] 115 | |                     if self.name_parts.len() > 1 {
[INFO] [stdout] 116 | |                         self.arguments.push(self.name_parts.pop().unwrap());
[INFO] [stdout] 117 | |                     }
[INFO] [stdout] 118 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 114 ~                 if self.arguments.is_empty()
[INFO] [stdout] 115 ~                     && self.name_parts.len() > 1 {
[INFO] [stdout] 116 |                         self.arguments.push(self.name_parts.pop().unwrap());
[INFO] [stdout] 117 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/x86/mod.rs:105:38
[INFO] [stdout]     |
[INFO] [stdout] 105 |                   let (reg_id, size) = x64::parser::X64_REGISTER_MAP.get(reg.as_str())
[INFO] [stdout]     |  ______________________________________^
[INFO] [stdout] 106 | |                     .copied()
[INFO] [stdout] 107 | |                     .ok_or_else(|| Error::InvalidX64Register)?;
[INFO] [stdout]     | |_____________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 107 -                     .ok_or_else(|| Error::InvalidX64Register)?;
[INFO] [stdout] 107 +                     .ok_or(Error::InvalidX64Register)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/lib.rs:116:5
[INFO] [stdout]     |
[INFO] [stdout] 116 |     let body;
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `body` here and remove the assignments from the `match` arms
[INFO] [stdout]     |
[INFO] [stdout] 116 ~     
[INFO] [stdout] 117 ~     let body = match &block.into_iter().next() {
[INFO] [stdout] 118 |         Some(TokenTree::Group(group)) if group.delimiter() == Delimiter::Brace => {
[INFO] [stdout] 119 ~             group.stream()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/att.rs:174:35
[INFO] [stdout]     |
[INFO] [stdout] 174 |                     let closing = after.find(')').ok_or_else(|| Error::NoClosingParen)?;
[INFO] [stdout]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 174 -                     let closing = after.find(')').ok_or_else(|| Error::NoClosingParen)?;
[INFO] [stdout] 174 +                     let closing = after.find(')').ok_or(Error::NoClosingParen)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/att.rs:210:23
[INFO] [stdout]     |
[INFO] [stdout] 210 |                 name: st[1..].to_string(),
[INFO] [stdout]     |                       ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/att.rs:208:9
[INFO] [stdout]     |
[INFO] [stdout] 208 |         if st.starts_with('.') {
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]     = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 208 ~         if let Some(<stripped>) = st.strip_prefix('.') {
[INFO] [stdout] 209 |             LineKind::Directive(Directive {
[INFO] [stdout] 210 ~                 name: <stripped>.to_string(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:179:15
[INFO] [stdout]     |
[INFO] [stdout] 179 |         .args(&["-f", "bin", "-o", "/proc/self/fd/1", "target/indirection.in"])
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-f", "bin", "-o", "/proc/self/fd/1", "target/indirection.in"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]    --> src/att.rs:238:42
[INFO] [stdout]     |
[INFO] [stdout] 238 |             LineKind::Statement(stmt) => Ok(stmt.add_prefix_or_name(arg)),
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout]     = note: `#[warn(clippy::unit_arg)]` on by default
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]     |
[INFO] [stdout] 238 ~             LineKind::Statement(stmt) => {
[INFO] [stdout] 239 +                 let _: () = stmt.add_prefix_or_name(arg);
[INFO] [stdout] 240 +                 Ok(())
[INFO] [stdout] 241 ~             },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]    --> src/att.rs:245:47
[INFO] [stdout]     |
[INFO] [stdout] 245 |             LineKind::Directive(directive) => Ok(directive.add_argument(arg)),
[INFO] [stdout]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]     |
[INFO] [stdout] 245 ~             LineKind::Directive(directive) => {
[INFO] [stdout] 246 +                 let _: () = directive.add_argument(arg);
[INFO] [stdout] 247 +                 Ok(())
[INFO] [stdout] 248 ~             },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual backwards iteration
[INFO] [stdout]    --> src/lib.rs:206:34
[INFO] [stdout]     |
[INFO] [stdout] 206 |         if original_input.chars().rev().next() != Some('\n') {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^ help: use: `.next_back()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back
[INFO] [stdout]     = note: `#[warn(clippy::manual_next_back)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]    --> src/att.rs:267:17
[INFO] [stdout]     |
[INFO] [stdout] 267 |                 Ok(self.arguments.push(argument))
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]     |
[INFO] [stdout] 267 ~                 self.arguments.push(argument);
[INFO] [stdout] 268 +                 Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:225:19
[INFO] [stdout]     |
[INFO] [stdout] 225 |             .args(&["-o", ASSEMBLED_FILE])
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-o", ASSEMBLED_FILE]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout] 276 | |     || ch == ':'
[INFO] [stdout] 277 | |     || ch == '('
[INFO] [stdout] 278 | |     || ch == ' '
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';' || ch == ':' || ch == '(' || ch == ' '`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:245:19
[INFO] [stdout]     |
[INFO] [stdout] 245 |             .args(&["-O", "binary"])
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^ help: change this to: `["-O", "binary"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout] 276 | |     || ch == ':'
[INFO] [stdout] 277 | |     || ch == '('
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';' || ch == ':' || ch == '('`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout] 276 | |     || ch == ':'
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';' || ch == ':'`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout] 275 | |     || ch == ';'
[INFO] [stdout]     | |________________^ help: try: `ch == ',' || ch == ';'`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/att.rs:273:5
[INFO] [stdout]     |
[INFO] [stdout] 273 | /     false
[INFO] [stdout] 274 | |     || ch == ','
[INFO] [stdout]     | |________________^ help: try: `ch == ','`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/att.rs:313:35
[INFO] [stdout]     |
[INFO] [stdout] 313 |             Ok(Argument::Register(st[1..].to_string()))
[INFO] [stdout]     |                                   ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/att.rs:312:16
[INFO] [stdout]     |
[INFO] [stdout] 312 |         } else if st.starts_with('%') {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 312 ~         } else if let Some(<stripped>) = st.strip_prefix('%') {
[INFO] [stdout] 313 ~             Ok(Argument::Register(<stripped>.to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/att.rs:315:25
[INFO] [stdout]     |
[INFO] [stdout] 315 |             let value = st.parse().ok().ok_or_else(|| Error::InvalidImmediateValue)?;
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 315 -             let value = st.parse().ok().ok_or_else(|| Error::InvalidImmediateValue)?;
[INFO] [stdout] 315 +             let value = st.parse().ok().ok_or(Error::InvalidImmediateValue)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/x86/mod.rs:105:38
[INFO] [stdout]     |
[INFO] [stdout] 105 |                   let (reg_id, size) = x64::parser::X64_REGISTER_MAP.get(reg.as_str())
[INFO] [stdout]     |  ______________________________________^
[INFO] [stdout] 106 | |                     .copied()
[INFO] [stdout] 107 | |                     .ok_or_else(|| Error::InvalidX64Register)?;
[INFO] [stdout]     | |_____________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 107 -                     .ok_or_else(|| Error::InvalidX64Register)?;
[INFO] [stdout] 107 +                     .ok_or(Error::InvalidX64Register)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/lib.rs:116:5
[INFO] [stdout]     |
[INFO] [stdout] 116 |     let body;
[INFO] [stdout]     |     ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `body` here and remove the assignments from the `match` arms
[INFO] [stdout]     |
[INFO] [stdout] 116 ~     
[INFO] [stdout] 117 ~     let body = match &block.into_iter().next() {
[INFO] [stdout] 118 |         Some(TokenTree::Group(group)) if group.delimiter() == Delimiter::Brace => {
[INFO] [stdout] 119 ~             group.stream()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:179:15
[INFO] [stdout]     |
[INFO] [stdout] 179 |         .args(&["-f", "bin", "-o", "/proc/self/fd/1", "target/indirection.in"])
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-f", "bin", "-o", "/proc/self/fd/1", "target/indirection.in"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual backwards iteration
[INFO] [stdout]    --> src/lib.rs:206:34
[INFO] [stdout]     |
[INFO] [stdout] 206 |         if original_input.chars().rev().next() != Some('\n') {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^ help: use: `.next_back()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back
[INFO] [stdout]     = note: `#[warn(clippy::manual_next_back)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:225:19
[INFO] [stdout]     |
[INFO] [stdout] 225 |             .args(&["-o", ASSEMBLED_FILE])
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-o", ASSEMBLED_FILE]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/lib.rs:245:19
[INFO] [stdout]     |
[INFO] [stdout] 245 |             .args(&["-O", "binary"])
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^ help: change this to: `["-O", "binary"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.45s
[INFO] running `Command { std: "docker" "inspect" "fd2e9179afbe20b17124ae06ef9a115b8a7b9cc0df75bcf7ac3607f5cbe5021f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "fd2e9179afbe20b17124ae06ef9a115b8a7b9cc0df75bcf7ac3607f5cbe5021f", kill_on_drop: false }`
[INFO] [stdout] fd2e9179afbe20b17124ae06ef9a115b8a7b9cc0df75bcf7ac3607f5cbe5021f