[INFO] fetching crate dircolors-hd 0.2.0... [INFO] linting dircolors-hd-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate dircolors-hd 0.2.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate dircolors-hd 0.2.0 [INFO] finished tweaking crates.io crate dircolors-hd 0.2.0 [INFO] tweaked toml for crates.io crate dircolors-hd 0.2.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate dircolors-hd 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rgb v0.8.53 [INFO] [stderr] Downloaded ansi_colours v1.2.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f79e40339ac0a44f940aac9e123b0870756569eb7749313a04b27a35743beff [INFO] running `Command { std: "docker" "start" "-a" "5f79e40339ac0a44f940aac9e123b0870756569eb7749313a04b27a35743beff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f79e40339ac0a44f940aac9e123b0870756569eb7749313a04b27a35743beff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f79e40339ac0a44f940aac9e123b0870756569eb7749313a04b27a35743beff", kill_on_drop: false }` [INFO] [stdout] 5f79e40339ac0a44f940aac9e123b0870756569eb7749313a04b27a35743beff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1962e3dcb8cd341f84d31291d3c3a499105e8120a61cb0fcf44608cce870b84 [INFO] running `Command { std: "docker" "start" "-a" "c1962e3dcb8cd341f84d31291d3c3a499105e8120a61cb0fcf44608cce870b84", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rgb v0.8.53 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking ansi_colours v1.2.3 [INFO] [stderr] Checking dircolors-hd v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:21:63 [INFO] [stdout] | [INFO] [stdout] 21 | DircolorsError::IoError(e) => write!(fmt, "{}", e.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:22:72 [INFO] [stdout] | [INFO] [stdout] 22 | DircolorsError::YamlParsingError(e) => write!(fmt, "{}", e.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:21:63 [INFO] [stdout] | [INFO] [stdout] 21 | DircolorsError::IoError(e) => write!(fmt, "{}", e.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:22:72 [INFO] [stdout] | [INFO] [stdout] 22 | DircolorsError::YamlParsingError(e) => write!(fmt, "{}", e.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/filetypes.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | let docs = YamlLoader::load_from_str(&contents)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `contents` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/filetypes.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | if !result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/filetypes.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | let docs = YamlLoader::load_from_str(&contents)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `contents` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/filetypes.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | if !result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/theme.rs:41:50 [INFO] [stdout] | [INFO] [stdout] 41 | let mut docs = YamlLoader::load_from_str(&contents)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `contents` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/theme.rs:51:76 [INFO] [stdout] | [INFO] [stdout] 51 | ... colors.insert(key.clone(), Color::from_hex_str(&value)?); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/theme.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / if map.contains_key(&Yaml::String("foreground".into())) [INFO] [stdout] 77 | | || map.contains_key(&Yaml::String("background".into())) [INFO] [stdout] 78 | | || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 76 ~ if (map.contains_key(&Yaml::String("foreground".into())) [INFO] [stdout] 77 | || map.contains_key(&Yaml::String("background".into())) [INFO] [stdout] 78 ~ || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stdout] 79 ~ || map.contains_key(&Yaml::String("font-style".into()))) [INFO] [stdout] 80 | { [INFO] [stdout] 81 ~ && map.get(&Yaml::String(key.clone())).is_none() { [INFO] [stdout] 82 | // We can not specialize further [INFO] [stdout] 83 | break; [INFO] [stdout] 84 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/theme.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 87 | item = &value; [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/theme.rs:41:50 [INFO] [stdout] | [INFO] [stdout] 41 | let mut docs = YamlLoader::load_from_str(&contents)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `contents` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/theme.rs:51:76 [INFO] [stdout] | [INFO] [stdout] 51 | ... colors.insert(key.clone(), Color::from_hex_str(&value)?); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/theme.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / if map.contains_key(&Yaml::String("foreground".into())) [INFO] [stdout] 77 | | || map.contains_key(&Yaml::String("background".into())) [INFO] [stdout] 78 | | || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 76 ~ if (map.contains_key(&Yaml::String("foreground".into())) [INFO] [stdout] 77 | || map.contains_key(&Yaml::String("background".into())) [INFO] [stdout] 78 ~ || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stdout] 79 ~ || map.contains_key(&Yaml::String("font-style".into()))) [INFO] [stdout] 80 | { [INFO] [stdout] 81 ~ && map.get(&Yaml::String(key.clone())).is_none() { [INFO] [stdout] 82 | // We can not specialize further [INFO] [stdout] 83 | break; [INFO] [stdout] 84 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/theme.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 87 | item = &value; [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:73:46 [INFO] [stdout] | [INFO] [stdout] 73 | let filetypes = FileTypes::from_file(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:76:38 [INFO] [stdout] | [INFO] [stdout] 76 | let theme = Theme::from_file(&theme_path, color_mode)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `theme_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:84:71 [INFO] [stdout] | [INFO] [stdout] 84 | ls_colors.push(format!("{}={}", filetype, theme.get_style(&category)?)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `category` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:73:46 [INFO] [stdout] | [INFO] [stdout] 73 | let filetypes = FileTypes::from_file(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:76:38 [INFO] [stdout] | [INFO] [stdout] 76 | let theme = Theme::from_file(&theme_path, color_mode)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `theme_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:84:71 [INFO] [stdout] | [INFO] [stdout] 84 | ls_colors.push(format!("{}={}", filetype, theme.get_style(&category)?)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `category` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `Command { std: "docker" "inspect" "c1962e3dcb8cd341f84d31291d3c3a499105e8120a61cb0fcf44608cce870b84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1962e3dcb8cd341f84d31291d3c3a499105e8120a61cb0fcf44608cce870b84", kill_on_drop: false }` [INFO] [stdout] c1962e3dcb8cd341f84d31291d3c3a499105e8120a61cb0fcf44608cce870b84