[INFO] fetching crate delaunay-rs 0.1.0... [INFO] linting delaunay-rs-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate delaunay-rs 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate delaunay-rs 0.1.0 [INFO] finished tweaking crates.io crate delaunay-rs 0.1.0 [INFO] tweaked toml for crates.io crate delaunay-rs 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate delaunay-rs 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f000b919dbd5937eedefba253d2dceb2bb4e836cd1afba24c2fe627121740871 [INFO] running `Command { std: "docker" "start" "-a" "f000b919dbd5937eedefba253d2dceb2bb4e836cd1afba24c2fe627121740871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f000b919dbd5937eedefba253d2dceb2bb4e836cd1afba24c2fe627121740871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f000b919dbd5937eedefba253d2dceb2bb4e836cd1afba24c2fe627121740871", kill_on_drop: false }` [INFO] [stdout] f000b919dbd5937eedefba253d2dceb2bb4e836cd1afba24c2fe627121740871 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a1b971e1034ddec65e669f5225fddaab3ae6fa6f9d8b8ab2c570819097e5c99a [INFO] running `Command { std: "docker" "start" "-a" "a1b971e1034ddec65e669f5225fddaab3ae6fa6f9d8b8ab2c570819097e5c99a", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking delaunay-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/edge.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | Edge {p1: p1, p2: p2} [INFO] [stdout] | ^^^^^^ help: replace it with: `p1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/edge.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | Edge {p1: p1, p2: p2} [INFO] [stdout] | ^^^^^^ help: replace it with: `p2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/point.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | Point {x: x, y: y} [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/point.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | Point {x: x, y: y} [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/triangle.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | p1: p1, [INFO] [stdout] | ^^^^^^ help: replace it with: `p1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/triangle.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | p2: p2, [INFO] [stdout] | ^^^^^^ help: replace it with: `p2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/triangle.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | p3: p3, [INFO] [stdout] | ^^^^^^ help: replace it with: `p3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/edge.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | Edge {p1: p1, p2: p2} [INFO] [stdout] | ^^^^^^ help: replace it with: `p1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/edge.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | Edge {p1: p1, p2: p2} [INFO] [stdout] | ^^^^^^ help: replace it with: `p2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/point.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | Point {x: x, y: y} [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/point.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | Point {x: x, y: y} [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/triangle.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | p1: p1, [INFO] [stdout] | ^^^^^^ help: replace it with: `p1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/triangle.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | p2: p2, [INFO] [stdout] | ^^^^^^ help: replace it with: `p2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/triangle.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | p3: p3, [INFO] [stdout] | ^^^^^^ help: replace it with: `p3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/delaunay.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 56 | if !(triangle == other_triangle) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(triangle != other_triangle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Edge` which implements the `Copy` trait [INFO] [stdout] --> src/delaunay.rs:67:36 [INFO] [stdout] | [INFO] [stdout] 67 | polygon.insert(edge.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*edge` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Point` which implements the `Copy` trait [INFO] [stdout] --> src/delaunay.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | point.clone() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*point` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/delaunay.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 56 | if !(triangle == other_triangle) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(triangle != other_triangle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/point.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | let nr = Point::slope(p1, p2).recip() * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-Point::slope(p1, p2).recip()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Edge` which implements the `Copy` trait [INFO] [stdout] --> src/delaunay.rs:67:36 [INFO] [stdout] | [INFO] [stdout] 67 | polygon.insert(edge.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*edge` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Point` which implements the `Copy` trait [INFO] [stdout] --> src/delaunay.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | point.clone() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*point` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/point.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | let nr = Point::slope(p1, p2).recip() * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-Point::slope(p1, p2).recip()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/triangle.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | assert!(triangle.contains(p4) == true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `triangle.contains(p4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/triangle.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | assert!(triangle.contains(p5) == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!triangle.contains(p5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s [INFO] running `Command { std: "docker" "inspect" "a1b971e1034ddec65e669f5225fddaab3ae6fa6f9d8b8ab2c570819097e5c99a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1b971e1034ddec65e669f5225fddaab3ae6fa6f9d8b8ab2c570819097e5c99a", kill_on_drop: false }` [INFO] [stdout] a1b971e1034ddec65e669f5225fddaab3ae6fa6f9d8b8ab2c570819097e5c99a