[INFO] fetching crate declarative_lock 0.1.0... [INFO] linting declarative_lock-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate declarative_lock 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate declarative_lock 0.1.0 [INFO] finished tweaking crates.io crate declarative_lock 0.1.0 [INFO] tweaked toml for crates.io crate declarative_lock 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate declarative_lock 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate declarative_lock 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc40bb9e213a12007b5f2131893d6931267c4662984e390e94224deebd40a0f5 [INFO] running `Command { std: "docker" "start" "-a" "dc40bb9e213a12007b5f2131893d6931267c4662984e390e94224deebd40a0f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc40bb9e213a12007b5f2131893d6931267c4662984e390e94224deebd40a0f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc40bb9e213a12007b5f2131893d6931267c4662984e390e94224deebd40a0f5", kill_on_drop: false }` [INFO] [stdout] dc40bb9e213a12007b5f2131893d6931267c4662984e390e94224deebd40a0f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e7a7e282d3e6676fefa22cb66d21baaad01134b80eed9d38afcdea2de36f5a0 [INFO] running `Command { std: "docker" "start" "-a" "8e7a7e282d3e6676fefa22cb66d21baaad01134b80eed9d38afcdea2de36f5a0", kill_on_drop: false }` [INFO] [stderr] Checking declarative_lock v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | /// [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / self.declared [INFO] [stdout] 63 | | .lock() [INFO] [stdout] 64 | | .unwrap() [INFO] [stdout] 65 | | .get(&tid) [INFO] [stdout] 66 | | .map_or(false, |set| set.contains(resource)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - .map_or(false, |set| set.contains(resource)) [INFO] [stdout] 66 + .is_some_and(|set| set.contains(resource)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DeclarativeLock` [INFO] [stdout] --> src/lib.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | / pub fn new() -> Self { [INFO] [stdout] 72 | | Self { [INFO] [stdout] 73 | | core: Arc::new(Core { [INFO] [stdout] 74 | | declared: Mutex::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 70 + impl Default for DeclarativeLock { [INFO] [stdout] 71 + fn default() -> Self { [INFO] [stdout] 72 + Self::new() [INFO] [stdout] 73 + } [INFO] [stdout] 74 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if !declared.get(&tid).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `declared.get(&tid).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:105:55 [INFO] [stdout] | [INFO] [stdout] 105 | *thread_id != tid && set.contains(&r) [INFO] [stdout] | ^^ help: change this to: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/lib.rs:114:41 [INFO] [stdout] | [INFO] [stdout] 114 | let entry = declared.entry(tid).or_insert_with(HashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/lib.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | /// [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / self.declared [INFO] [stdout] 63 | | .lock() [INFO] [stdout] 64 | | .unwrap() [INFO] [stdout] 65 | | .get(&tid) [INFO] [stdout] 66 | | .map_or(false, |set| set.contains(resource)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - .map_or(false, |set| set.contains(resource)) [INFO] [stdout] 66 + .is_some_and(|set| set.contains(resource)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DeclarativeLock` [INFO] [stdout] --> src/lib.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | / pub fn new() -> Self { [INFO] [stdout] 72 | | Self { [INFO] [stdout] 73 | | core: Arc::new(Core { [INFO] [stdout] 74 | | declared: Mutex::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 70 + impl Default for DeclarativeLock { [INFO] [stdout] 71 + fn default() -> Self { [INFO] [stdout] 72 + Self::new() [INFO] [stdout] 73 + } [INFO] [stdout] 74 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if !declared.get(&tid).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `declared.get(&tid).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:105:55 [INFO] [stdout] | [INFO] [stdout] 105 | *thread_id != tid && set.contains(&r) [INFO] [stdout] | ^^ help: change this to: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/lib.rs:114:41 [INFO] [stdout] | [INFO] [stdout] 114 | let entry = declared.entry(tid).or_insert_with(HashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "8e7a7e282d3e6676fefa22cb66d21baaad01134b80eed9d38afcdea2de36f5a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e7a7e282d3e6676fefa22cb66d21baaad01134b80eed9d38afcdea2de36f5a0", kill_on_drop: false }` [INFO] [stdout] 8e7a7e282d3e6676fefa22cb66d21baaad01134b80eed9d38afcdea2de36f5a0