[INFO] fetching crate dce-cli 1.0.0... [INFO] linting dce-cli-1.0.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate dce-cli 1.0.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate dce-cli 1.0.0 [INFO] finished tweaking crates.io crate dce-cli 1.0.0 [INFO] tweaked toml for crates.io crate dce-cli 1.0.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate dce-cli 1.0.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dce-util v1.0.0 [INFO] [stderr] Downloaded dce-macro v1.0.0 [INFO] [stderr] Downloaded dce-router v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c142cb662834b94ade31d693c1f1199f8dcd2c80b97352448e042c653635e0ab [INFO] running `Command { std: "docker" "start" "-a" "c142cb662834b94ade31d693c1f1199f8dcd2c80b97352448e042c653635e0ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c142cb662834b94ade31d693c1f1199f8dcd2c80b97352448e042c653635e0ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c142cb662834b94ade31d693c1f1199f8dcd2c80b97352448e042c653635e0ab", kill_on_drop: false }` [INFO] [stdout] c142cb662834b94ade31d693c1f1199f8dcd2c80b97352448e042c653635e0ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d666d3d37df2d3eb239d08bc1a37552e75ffe088729cc64d2be98f87c4542222 [INFO] running `Command { std: "docker" "start" "-a" "d666d3d37df2d3eb239d08bc1a37552e75ffe088729cc64d2be98f87c4542222", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling dce-util v1.0.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling dce-router v1.0.0 [INFO] [stderr] Compiling dce-macro v1.0.0 [INFO] [stderr] Checking dce-cli v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/protocol.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 63 | let mut cli = Self::from(raw.iter().skip(base).map(|a| a.clone()).collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `raw.iter().skip(base).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/protocol.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return if let Some((left, right)) = arg.split_once("=") { [INFO] [stdout] 70 | | ArgType::AssignExpr(left.to_string(), right.to_string()) [INFO] [stdout] 71 | | } else if arg.starts_with("-") { [INFO] [stdout] 72 | | if arg == PASS_SEPARATOR { return ArgType::DownFlowSeparator } [INFO] [stdout] ... | [INFO] [stdout] 75 | | ArgType::Path [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ if let Some((left, right)) = arg.split_once("=") { [INFO] [stdout] 70 + ArgType::AssignExpr(left.to_string(), right.to_string()) [INFO] [stdout] 71 + } else if arg.starts_with("-") { [INFO] [stdout] 72 + if arg == PASS_SEPARATOR { return ArgType::DownFlowSeparator } [INFO] [stdout] 73 + ArgType::PrefixName [INFO] [stdout] 74 + } else { [INFO] [stdout] 75 + ArgType::Path [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/protocol.rs:91:44 [INFO] [stdout] | [INFO] [stdout] 91 | args.insert(arg, match value.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/protocol.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | impl Into for CliProtocol { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 107 ~ impl From for String { [INFO] [stdout] 108 ~ fn from(mut val: CliProtocol) -> Self { [INFO] [stdout] 109 | #[allow(unused_mut)] [INFO] [stdout] 110 ~ let mut resp = match val.resp_mut().take() { [INFO] [stdout] 111 ~ Some(Response::Serialized(sd)) => val.pack_resp(sd), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/protocol.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if ! result.is_err() && ! context.api().map_or(false, |a| a.unresponsive()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/protocol.rs:161:35 [INFO] [stdout] | [INFO] [stdout] 161 | if ! result.is_err() && ! context.api().map_or(false, |a| a.unresponsive()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 161 - if ! result.is_err() && ! context.api().map_or(false, |a| a.unresponsive()) { [INFO] [stdout] 161 + if ! result.is_err() && ! context.api().is_some_and(|a| a.unresponsive()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/protocol.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 63 | let mut cli = Self::from(raw.iter().skip(base).map(|a| a.clone()).collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `raw.iter().skip(base).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/protocol.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / return if let Some((left, right)) = arg.split_once("=") { [INFO] [stdout] 70 | | ArgType::AssignExpr(left.to_string(), right.to_string()) [INFO] [stdout] 71 | | } else if arg.starts_with("-") { [INFO] [stdout] 72 | | if arg == PASS_SEPARATOR { return ArgType::DownFlowSeparator } [INFO] [stdout] ... | [INFO] [stdout] 75 | | ArgType::Path [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ if let Some((left, right)) = arg.split_once("=") { [INFO] [stdout] 70 + ArgType::AssignExpr(left.to_string(), right.to_string()) [INFO] [stdout] 71 + } else if arg.starts_with("-") { [INFO] [stdout] 72 + if arg == PASS_SEPARATOR { return ArgType::DownFlowSeparator } [INFO] [stdout] 73 + ArgType::PrefixName [INFO] [stdout] 74 + } else { [INFO] [stdout] 75 + ArgType::Path [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/protocol.rs:91:44 [INFO] [stdout] | [INFO] [stdout] 91 | args.insert(arg, match value.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/protocol.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | impl Into for CliProtocol { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 107 ~ impl From for String { [INFO] [stdout] 108 ~ fn from(mut val: CliProtocol) -> Self { [INFO] [stdout] 109 | #[allow(unused_mut)] [INFO] [stdout] 110 ~ let mut resp = match val.resp_mut().take() { [INFO] [stdout] 111 ~ Some(Response::Serialized(sd)) => val.pack_resp(sd), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/protocol.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if ! result.is_err() && ! context.api().map_or(false, |a| a.unresponsive()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/protocol.rs:161:35 [INFO] [stdout] | [INFO] [stdout] 161 | if ! result.is_err() && ! context.api().map_or(false, |a| a.unresponsive()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 161 - if ! result.is_err() && ! context.api().map_or(false, |a| a.unresponsive()) { [INFO] [stdout] 161 + if ! result.is_err() && ! context.api().is_some_and(|a| a.unresponsive()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.24s [INFO] running `Command { std: "docker" "inspect" "d666d3d37df2d3eb239d08bc1a37552e75ffe088729cc64d2be98f87c4542222", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d666d3d37df2d3eb239d08bc1a37552e75ffe088729cc64d2be98f87c4542222", kill_on_drop: false }` [INFO] [stdout] d666d3d37df2d3eb239d08bc1a37552e75ffe088729cc64d2be98f87c4542222