[INFO] fetching crate date_time 2.2.0... [INFO] linting date_time-2.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate date_time 2.2.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate date_time 2.2.0 [INFO] finished tweaking crates.io crate date_time 2.2.0 [INFO] tweaked toml for crates.io crate date_time 2.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate date_time 2.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e417949bef552060b21b6d1709b239c4a0774974e91775c66748f1cbee1a871 [INFO] running `Command { std: "docker" "start" "-a" "6e417949bef552060b21b6d1709b239c4a0774974e91775c66748f1cbee1a871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e417949bef552060b21b6d1709b239c4a0774974e91775c66748f1cbee1a871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e417949bef552060b21b6d1709b239c4a0774974e91775c66748f1cbee1a871", kill_on_drop: false }` [INFO] [stdout] 6e417949bef552060b21b6d1709b239c4a0774974e91775c66748f1cbee1a871 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc79684d8945ca6e76f26d24118a467a26afe89f57305745adf88499967314c9 [INFO] running `Command { std: "docker" "start" "-a" "cc79684d8945ca6e76f26d24118a467a26afe89f57305745adf88499967314c9", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking date_time v2.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/date_time_tuple.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/date_tuple.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 328 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/month_tuple.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 201 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/time_tuple.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/time_tuple.rs:402:12 [INFO] [stdout] | [INFO] [stdout] 402 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/date_time_tuple.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/date_tuple.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 328 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/month_tuple.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 201 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/time_tuple.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin` [INFO] [stdout] --> src/time_tuple.rs:402:12 [INFO] [stdout] | [INFO] [stdout] 402 | #[cfg_attr(tarpaulin, skip)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/date_time_tuple.rs:42:61 [INFO] [stdout] | [INFO] [stdout] 42 | format!("{} {}", self.d.to_readable_string(), self.t.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/date_time_tuple.rs:52:34 [INFO] [stdout] | [INFO] [stdout] 52 | write!(f, "{}@{}", self.d.to_string(), self.t.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/date_time_tuple.rs:52:54 [INFO] [stdout] | [INFO] [stdout] 52 | write!(f, "{}@{}", self.d.to_string(), self.t.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/date_time_tuple.rs:81:1 [INFO] [stdout] | [INFO] [stdout] 81 | / impl PartialOrd for DateTimeTuple { [INFO] [stdout] 82 | | fn partial_cmp(&self, other: &DateTimeTuple) -> Option { [INFO] [stdout] 83 | | if self.d == other.d { [INFO] [stdout] 84 | | self.t.partial_cmp(&other.t) [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn partial_cmp(&self, other: &DateTimeTuple) -> Option { [INFO] [stdout] 83 - if self.d == other.d { [INFO] [stdout] 84 - self.t.partial_cmp(&other.t) [INFO] [stdout] 85 - } else { [INFO] [stdout] 86 - self.d.partial_cmp(&other.d) [INFO] [stdout] 87 - } [INFO] [stdout] 88 - } [INFO] [stdout] 82 + fn partial_cmp(&self, other: &DateTimeTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/date_tuple.rs:314:1 [INFO] [stdout] | [INFO] [stdout] 314 | / impl PartialOrd for DateTuple { [INFO] [stdout] 315 | | fn partial_cmp(&self, other: &DateTuple) -> Option { [INFO] [stdout] 316 | | if self.y == other.y { [INFO] [stdout] 317 | | if self.m == other.m { [INFO] [stdout] ... | [INFO] [stdout] 326 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 315 - fn partial_cmp(&self, other: &DateTuple) -> Option { [INFO] [stdout] 316 - if self.y == other.y { [INFO] [stdout] 317 - if self.m == other.m { [INFO] [stdout] 318 - self.d.partial_cmp(&other.d) [INFO] [stdout] 319 - } else { [INFO] [stdout] 320 - self.m.partial_cmp(&other.m) [INFO] [stdout] 321 - } [INFO] [stdout] 322 - } else { [INFO] [stdout] 323 - self.y.partial_cmp(&other.y) [INFO] [stdout] 324 - } [INFO] [stdout] 325 - } [INFO] [stdout] 315 + fn partial_cmp(&self, other: &DateTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/date_utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/date_utils.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `!year.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/date_utils.rs:14:42 [INFO] [stdout] | [INFO] [stdout] 14 | year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(400)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/date_time_tuple.rs:42:61 [INFO] [stdout] | [INFO] [stdout] 42 | format!("{} {}", self.d.to_readable_string(), self.t.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/date_time_tuple.rs:52:34 [INFO] [stdout] | [INFO] [stdout] 52 | write!(f, "{}@{}", self.d.to_string(), self.t.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/date_time_tuple.rs:52:54 [INFO] [stdout] | [INFO] [stdout] 52 | write!(f, "{}@{}", self.d.to_string(), self.t.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/date_time_tuple.rs:81:1 [INFO] [stdout] | [INFO] [stdout] 81 | / impl PartialOrd for DateTimeTuple { [INFO] [stdout] 82 | | fn partial_cmp(&self, other: &DateTimeTuple) -> Option { [INFO] [stdout] 83 | | if self.d == other.d { [INFO] [stdout] 84 | | self.t.partial_cmp(&other.t) [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn partial_cmp(&self, other: &DateTimeTuple) -> Option { [INFO] [stdout] 83 - if self.d == other.d { [INFO] [stdout] 84 - self.t.partial_cmp(&other.t) [INFO] [stdout] 85 - } else { [INFO] [stdout] 86 - self.d.partial_cmp(&other.d) [INFO] [stdout] 87 - } [INFO] [stdout] 88 - } [INFO] [stdout] 82 + fn partial_cmp(&self, other: &DateTimeTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/month_tuple.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | Some(s) => return format!("{} {:04}", s, self.y), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - Some(s) => return format!("{} {:04}", s, self.y), [INFO] [stdout] 147 + Some(s) => format!("{} {:04}", s, self.y), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a slice [INFO] [stdout] --> src/month_tuple.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 146 | match MONTH_STRINGS.iter().nth(self.m as usize - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] = note: `#[warn(clippy::iter_nth)]` on by default [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 146 - match MONTH_STRINGS.iter().nth(self.m as usize - 1) { [INFO] [stdout] 146 + match MONTH_STRINGS.get(self.m as usize - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/month_tuple.rs:191:1 [INFO] [stdout] | [INFO] [stdout] 191 | / impl PartialOrd for MonthTuple { [INFO] [stdout] 192 | | fn partial_cmp(&self, other: &MonthTuple) -> Option { [INFO] [stdout] 193 | | if self.y == other.y { [INFO] [stdout] 194 | | self.m.partial_cmp(&other.m) [INFO] [stdout] ... | [INFO] [stdout] 199 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 192 - fn partial_cmp(&self, other: &MonthTuple) -> Option { [INFO] [stdout] 193 - if self.y == other.y { [INFO] [stdout] 194 - self.m.partial_cmp(&other.m) [INFO] [stdout] 195 - } else { [INFO] [stdout] 196 - self.y.partial_cmp(&other.y) [INFO] [stdout] 197 - } [INFO] [stdout] 198 - } [INFO] [stdout] 192 + fn partial_cmp(&self, other: &MonthTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/time_tuple.rs:173:1 [INFO] [stdout] | [INFO] [stdout] 173 | / impl PartialOrd for TimeTuple { [INFO] [stdout] 174 | | fn partial_cmp(&self, other: &TimeTuple) -> Option { [INFO] [stdout] 175 | | self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 176 | | } [INFO] [stdout] 177 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 174 - fn partial_cmp(&self, other: &TimeTuple) -> Option { [INFO] [stdout] 175 - self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 176 - } [INFO] [stdout] 174 + fn partial_cmp(&self, other: &TimeTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/date_tuple.rs:314:1 [INFO] [stdout] | [INFO] [stdout] 314 | / impl PartialOrd for DateTuple { [INFO] [stdout] 315 | | fn partial_cmp(&self, other: &DateTuple) -> Option { [INFO] [stdout] 316 | | if self.y == other.y { [INFO] [stdout] 317 | | if self.m == other.m { [INFO] [stdout] ... | [INFO] [stdout] 326 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 315 - fn partial_cmp(&self, other: &DateTuple) -> Option { [INFO] [stdout] 316 - if self.y == other.y { [INFO] [stdout] 317 - if self.m == other.m { [INFO] [stdout] 318 - self.d.partial_cmp(&other.d) [INFO] [stdout] 319 - } else { [INFO] [stdout] 320 - self.m.partial_cmp(&other.m) [INFO] [stdout] 321 - } [INFO] [stdout] 322 - } else { [INFO] [stdout] 323 - self.y.partial_cmp(&other.y) [INFO] [stdout] 324 - } [INFO] [stdout] 325 - } [INFO] [stdout] 315 + fn partial_cmp(&self, other: &DateTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/date_utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/date_utils.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `!year.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/date_utils.rs:14:42 [INFO] [stdout] | [INFO] [stdout] 14 | year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(400)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/time_tuple.rs:396:1 [INFO] [stdout] | [INFO] [stdout] 396 | / impl PartialOrd for Duration { [INFO] [stdout] 397 | | fn partial_cmp(&self, other: &Duration) -> Option { [INFO] [stdout] 398 | | self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 399 | | } [INFO] [stdout] 400 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 397 - fn partial_cmp(&self, other: &Duration) -> Option { [INFO] [stdout] 398 - self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 399 - } [INFO] [stdout] 397 + fn partial_cmp(&self, other: &Duration) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/month_tuple.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | Some(s) => return format!("{} {:04}", s, self.y), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - Some(s) => return format!("{} {:04}", s, self.y), [INFO] [stdout] 147 + Some(s) => format!("{} {:04}", s, self.y), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a slice [INFO] [stdout] --> src/month_tuple.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 146 | match MONTH_STRINGS.iter().nth(self.m as usize - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] = note: `#[warn(clippy::iter_nth)]` on by default [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 146 - match MONTH_STRINGS.iter().nth(self.m as usize - 1) { [INFO] [stdout] 146 + match MONTH_STRINGS.get(self.m as usize - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/month_tuple.rs:191:1 [INFO] [stdout] | [INFO] [stdout] 191 | / impl PartialOrd for MonthTuple { [INFO] [stdout] 192 | | fn partial_cmp(&self, other: &MonthTuple) -> Option { [INFO] [stdout] 193 | | if self.y == other.y { [INFO] [stdout] 194 | | self.m.partial_cmp(&other.m) [INFO] [stdout] ... | [INFO] [stdout] 199 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 192 - fn partial_cmp(&self, other: &MonthTuple) -> Option { [INFO] [stdout] 193 - if self.y == other.y { [INFO] [stdout] 194 - self.m.partial_cmp(&other.m) [INFO] [stdout] 195 - } else { [INFO] [stdout] 196 - self.y.partial_cmp(&other.y) [INFO] [stdout] 197 - } [INFO] [stdout] 198 - } [INFO] [stdout] 192 + fn partial_cmp(&self, other: &MonthTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/time_tuple.rs:173:1 [INFO] [stdout] | [INFO] [stdout] 173 | / impl PartialOrd for TimeTuple { [INFO] [stdout] 174 | | fn partial_cmp(&self, other: &TimeTuple) -> Option { [INFO] [stdout] 175 | | self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 176 | | } [INFO] [stdout] 177 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 174 - fn partial_cmp(&self, other: &TimeTuple) -> Option { [INFO] [stdout] 175 - self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 176 - } [INFO] [stdout] 174 + fn partial_cmp(&self, other: &TimeTuple) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/time_tuple.rs:396:1 [INFO] [stdout] | [INFO] [stdout] 396 | / impl PartialOrd for Duration { [INFO] [stdout] 397 | | fn partial_cmp(&self, other: &Duration) -> Option { [INFO] [stdout] 398 | | self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 399 | | } [INFO] [stdout] 400 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 397 - fn partial_cmp(&self, other: &Duration) -> Option { [INFO] [stdout] 398 - self.to_seconds().partial_cmp(&other.to_seconds()) [INFO] [stdout] 399 - } [INFO] [stdout] 397 + fn partial_cmp(&self, other: &Duration) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/month_tuple_tests.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | assert!(!(tuple1 < tuple2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(tuple1 >= tuple2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/date_tuple_tests.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | assert!(!(tuple1 < tuple2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(tuple1 >= tuple2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `date_time::time_tuple::Duration::to_hours_and_minutes_string`: Replace with to_hhmm_string() [INFO] [stdout] --> tests/time_tuple_tests.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | duration.to_hours_and_minutes_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.02s [INFO] running `Command { std: "docker" "inspect" "cc79684d8945ca6e76f26d24118a467a26afe89f57305745adf88499967314c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc79684d8945ca6e76f26d24118a467a26afe89f57305745adf88499967314c9", kill_on_drop: false }` [INFO] [stdout] cc79684d8945ca6e76f26d24118a467a26afe89f57305745adf88499967314c9