[INFO] fetching crate datalocker 0.3.1... [INFO] linting datalocker-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate datalocker 0.3.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate datalocker 0.3.1 [INFO] finished tweaking crates.io crate datalocker 0.3.1 [INFO] tweaked toml for crates.io crate datalocker 0.3.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate datalocker 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 247 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding mysql v24.0.0 (available: v28.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded frunk_proc_macros v0.1.4 [INFO] [stderr] Downloaded saturating v0.1.0 [INFO] [stderr] Downloaded mysql-common-derive v0.30.2 [INFO] [stderr] Downloaded frunk_derives v0.4.4 [INFO] [stderr] Downloaded frunk v0.4.4 [INFO] [stderr] Downloaded io-enum v1.2.1 [INFO] [stderr] Downloaded derive_utils v0.15.1 [INFO] [stderr] Downloaded lru v0.10.1 [INFO] [stderr] Downloaded mysql v24.0.0 [INFO] [stderr] Downloaded frunk_core v0.4.4 [INFO] [stderr] Downloaded subprocess v0.2.15 [INFO] [stderr] Downloaded lexical v6.1.1 [INFO] [stderr] Downloaded named_pipe v0.4.1 [INFO] [stderr] Downloaded frunk_proc_macro_helpers v0.1.4 [INFO] [stderr] Downloaded mysql_common v0.30.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 290fb220d52cd74a71b9737c05a58ca289777c5148bac7e211750cb9b15fec7a [INFO] running `Command { std: "docker" "start" "-a" "290fb220d52cd74a71b9737c05a58ca289777c5148bac7e211750cb9b15fec7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "290fb220d52cd74a71b9737c05a58ca289777c5148bac7e211750cb9b15fec7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "290fb220d52cd74a71b9737c05a58ca289777c5148bac7e211750cb9b15fec7a", kill_on_drop: false }` [INFO] [stdout] 290fb220d52cd74a71b9737c05a58ca289777c5148bac7e211750cb9b15fec7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 826eef14fe19f1d98331166f7ac25a231abe492b1cf8aeb6aeec1374bbfd0447 [INFO] running `Command { std: "docker" "start" "-a" "826eef14fe19f1d98331166f7ac25a231abe492b1cf8aeb6aeec1374bbfd0447", kill_on_drop: false }` [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling frunk_core v0.4.4 [INFO] [stderr] Compiling bindgen v0.72.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling libz-sys v1.1.25 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling frunk_proc_macro_helpers v0.1.4 [INFO] [stderr] Compiling subprocess v0.2.15 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling frunk_derives v0.4.4 [INFO] [stderr] Compiling frunk_proc_macros v0.1.4 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking bigdecimal v0.3.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking lexical v6.1.1 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Compiling derive_utils v0.15.1 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Checking saturating v0.1.0 [INFO] [stderr] Checking frunk v0.4.4 [INFO] [stderr] Compiling mysql v24.0.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking lru v0.10.1 [INFO] [stderr] Compiling io-enum v1.2.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking pem v2.0.1 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling mysql-common-derive v0.30.2 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Compiling mysql_common v0.30.6 [INFO] [stderr] Checking datalocker v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `TestDataStruct` is never constructed [INFO] [stdout] --> src/lib.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | struct TestDataStruct { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lockers/mysql_locker.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return self.query(&q) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return self.query(&q) [INFO] [stdout] 118 + self.query(&q) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lockers/mysql_locker.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | return self.query(&q); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return self.query(&q); [INFO] [stdout] 127 + self.query(&q) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lockers/builders/mysql.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | q += &", "; [INFO] [stdout] | ^^^^^ help: change this to: `", "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:23:22 [INFO] [stdout] | [INFO] [stdout] 23 | q += &")"; [INFO] [stdout] | ^^^^ help: change this to: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lockers/builders/mysql.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | String::from(q) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `q` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lockers/builders/mysql.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if data.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match where_clause { [INFO] [stdout] 65 | | Some(wc) => { [INFO] [stdout] 66 | | q = q + " WHERE " + wc; [INFO] [stdout] ... | [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if let Some(wc) = where_clause { [INFO] [stdout] 65 + q = q + " WHERE " + wc; [INFO] [stdout] 66 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / match order_by { [INFO] [stdout] 74 | | Some(ob) => { [INFO] [stdout] 75 | | q = q + " " + ob [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ if let Some(ob) = order_by { [INFO] [stdout] 74 + q = q + " " + ob [INFO] [stdout] 75 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / match limit { [INFO] [stdout] 83 | | Some(l) => { [INFO] [stdout] 84 | | q = q + " " + l [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ if let Some(l) = limit { [INFO] [stdout] 83 + q = q + " " + l [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | / match where_clause { [INFO] [stdout] 101 | | Some(wc) => { [INFO] [stdout] 102 | | q = q + " WHERE " + wc; [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Some(wc) = where_clause { [INFO] [stdout] 101 + q = q + " WHERE " + wc; [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lockers/builders/mysql.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:121:25 [INFO] [stdout] | [INFO] [stdout] 121 | sets += &", "; [INFO] [stdout] | ^^^^^ help: change this to: `", "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lockers/builders/mysql.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | sets += &", "; [INFO] [stdout] | ^^^^^ help: change this to: `", "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lockers/builders/clause.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | if self.where_clauses.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.where_clauses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/lockers/builders/clause.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | let ob_dir = match ob2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 107 | | Some(o) => o, [INFO] [stdout] 108 | | None => "ASC" [INFO] [stdout] 109 | | }; [INFO] [stdout] | |_________^ help: replace with: `ob2.unwrap_or("ASC")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lockers/builders/clause.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if self.where_clauses.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.where_clauses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lockers/builders/clause.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | let part2 = format!("{}", wheres); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `wheres.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lib.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl Default for TestDataStruct { [INFO] [stdout] 22 | | fn default() -> TestDataStruct { [INFO] [stdout] 23 | | TestDataStruct { [INFO] [stdout] 24 | | id: None, [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 14 + #[derive(Default)] [INFO] [stdout] 15 | struct TestDataStruct { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/lib.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / impl ToString for TestDataStruct { [INFO] [stdout] 33 | | fn to_string(&self) -> String { [INFO] [stdout] 34 | | match self.id { [INFO] [stdout] 35 | | Some(id) => format!("{} {} {} {}", id, self.name, self.address, self.age), [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lockers/mysql_locker.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return self.query(&q) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return self.query(&q) [INFO] [stdout] 118 + self.query(&q) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lockers/mysql_locker.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | return self.query(&q); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return self.query(&q); [INFO] [stdout] 127 + self.query(&q) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lockers/builders/mysql.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | q += &", "; [INFO] [stdout] | ^^^^^ help: change this to: `", "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:23:22 [INFO] [stdout] | [INFO] [stdout] 23 | q += &")"; [INFO] [stdout] | ^^^^ help: change this to: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lockers/builders/mysql.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | String::from(q) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `q` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lockers/builders/mysql.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if data.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match where_clause { [INFO] [stdout] 65 | | Some(wc) => { [INFO] [stdout] 66 | | q = q + " WHERE " + wc; [INFO] [stdout] ... | [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if let Some(wc) = where_clause { [INFO] [stdout] 65 + q = q + " WHERE " + wc; [INFO] [stdout] 66 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / match order_by { [INFO] [stdout] 74 | | Some(ob) => { [INFO] [stdout] 75 | | q = q + " " + ob [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ if let Some(ob) = order_by { [INFO] [stdout] 74 + q = q + " " + ob [INFO] [stdout] 75 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / match limit { [INFO] [stdout] 83 | | Some(l) => { [INFO] [stdout] 84 | | q = q + " " + l [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ if let Some(l) = limit { [INFO] [stdout] 83 + q = q + " " + l [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lockers/builders/mysql.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | / match where_clause { [INFO] [stdout] 101 | | Some(wc) => { [INFO] [stdout] 102 | | q = q + " WHERE " + wc; [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Some(wc) = where_clause { [INFO] [stdout] 101 + q = q + " WHERE " + wc; [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lockers/builders/mysql.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:121:25 [INFO] [stdout] | [INFO] [stdout] 121 | sets += &", "; [INFO] [stdout] | ^^^^^ help: change this to: `", "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lockers/builders/mysql.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lockers/builders/mysql.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | sets += &", "; [INFO] [stdout] | ^^^^^ help: change this to: `", "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lockers/builders/clause.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | if self.where_clauses.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.where_clauses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/lockers/builders/clause.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | let ob_dir = match ob2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 107 | | Some(o) => o, [INFO] [stdout] 108 | | None => "ASC" [INFO] [stdout] 109 | | }; [INFO] [stdout] | |_________^ help: replace with: `ob2.unwrap_or("ASC")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lockers/builders/clause.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if self.where_clauses.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.where_clauses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lockers/builders/clause.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | let part2 = format!("{}", wheres); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `wheres.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lib.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl Default for TestDataStruct { [INFO] [stdout] 22 | | fn default() -> TestDataStruct { [INFO] [stdout] 23 | | TestDataStruct { [INFO] [stdout] 24 | | id: None, [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 14 + #[derive(Default)] [INFO] [stdout] 15 | struct TestDataStruct { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/lib.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / impl ToString for TestDataStruct { [INFO] [stdout] 33 | | fn to_string(&self) -> String { [INFO] [stdout] 34 | | match self.id { [INFO] [stdout] 35 | | Some(id) => format!("{} {} {} {}", id, self.name, self.address, self.age), [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | assert_eq!(r2.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 93 - assert_eq!(r2.is_ok(), true); [INFO] [stdout] 93 + assert!(r2.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | assert_eq!(rdrop.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 96 - assert_eq!(rdrop.is_ok(), true); [INFO] [stdout] 96 + assert!(rdrop.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | assert_eq!(r3.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 106 - assert_eq!(r3.is_ok(), true); [INFO] [stdout] 106 + assert!(r3.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | assert_eq!(r4.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 118 - assert_eq!(r4.is_ok(), true); [INFO] [stdout] 118 + assert!(r4.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | assert_eq!(r5.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 122 - assert_eq!(r5.is_ok(), true); [INFO] [stdout] 122 + assert!(r5.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | assert_eq!(r6.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 139 - assert_eq!(r6.is_ok(), true); [INFO] [stdout] 139 + assert!(r6.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | assert_eq!(r7.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 157 - assert_eq!(r7.is_ok(), true); [INFO] [stdout] 157 + assert!(r7.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | assert_eq!(r9.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 170 - assert_eq!(r9.is_ok(), true); [INFO] [stdout] 170 + assert!(r9.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | assert_eq!(r10.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 172 - assert_eq!(r10.is_ok(), true); [INFO] [stdout] 172 + assert!(r10.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | assert_eq!(r8.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 177 - assert_eq!(r8.is_ok(), true); [INFO] [stdout] 177 + assert!(r8.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | assert_eq!(r11.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 190 - assert_eq!(r11.is_ok(), true); [INFO] [stdout] 190 + assert!(r11.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | assert_eq!(r12.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 198 - assert_eq!(r12.is_ok(), true); [INFO] [stdout] 198 + assert!(r12.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | assert_eq!(r8.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 201 - assert_eq!(r8.is_ok(), true); [INFO] [stdout] 201 + assert!(r8.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.13s [INFO] running `Command { std: "docker" "inspect" "826eef14fe19f1d98331166f7ac25a231abe492b1cf8aeb6aeec1374bbfd0447", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "826eef14fe19f1d98331166f7ac25a231abe492b1cf8aeb6aeec1374bbfd0447", kill_on_drop: false }` [INFO] [stdout] 826eef14fe19f1d98331166f7ac25a231abe492b1cf8aeb6aeec1374bbfd0447