[INFO] fetching crate data-transform 0.1.4... [INFO] linting data-transform-0.1.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate data-transform 0.1.4 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate data-transform 0.1.4 [INFO] finished tweaking crates.io crate data-transform 0.1.4 [INFO] tweaked toml for crates.io crate data-transform 0.1.4 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate data-transform 0.1.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate data-transform 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.21.2 [INFO] [stderr] Downloaded pyo3-build-config v0.21.2 [INFO] [stderr] Downloaded pyo3-ffi v0.21.2 [INFO] [stderr] Downloaded multiversion-macros v0.7.4 [INFO] [stderr] Downloaded polars-schema v0.44.2 [INFO] [stderr] Downloaded polars-json v0.44.2 [INFO] [stderr] Downloaded polars-error v0.44.2 [INFO] [stderr] Downloaded polars-row v0.44.2 [INFO] [stderr] Downloaded polars-mem-engine v0.44.2 [INFO] [stderr] Downloaded polars-expr v0.44.2 [INFO] [stderr] Downloaded polars-sql v0.44.2 [INFO] [stderr] Downloaded polars-pipe v0.44.2 [INFO] [stderr] Downloaded polars v0.44.2 [INFO] [stderr] Downloaded polars-stream v0.44.2 [INFO] [stderr] Downloaded sysinfo v0.31.4 [INFO] [stderr] Downloaded polars-io v0.44.2 [INFO] [stderr] Downloaded polars-ops v0.44.2 [INFO] [stderr] Downloaded polars-parquet v0.44.2 [INFO] [stderr] Downloaded object_store v0.10.2 [INFO] [stderr] Downloaded sqlparser v0.49.0 [INFO] [stderr] Downloaded polars-lazy v0.44.2 [INFO] [stderr] Downloaded polars-plan v0.44.2 [INFO] [stderr] Downloaded argminmax v0.6.3 [INFO] [stderr] Downloaded jsonpath_lib_polars_vendor v0.0.1 [INFO] [stderr] Downloaded polars-time v0.44.2 [INFO] [stderr] Downloaded rustyline v14.0.0 [INFO] [stderr] Downloaded polars-compute v0.44.2 [INFO] [stderr] Downloaded polars-arrow v0.44.2 [INFO] [stderr] Downloaded polars-core v0.44.2 [INFO] [stderr] Downloaded pyo3 v0.21.2 [INFO] [stderr] Downloaded ethnum v1.5.2 [INFO] [stderr] Downloaded fast-float v0.2.0 [INFO] [stderr] Downloaded fs4 v0.9.1 [INFO] [stderr] Downloaded pyo3-macros-backend v0.21.2 [INFO] [stderr] Downloaded atoi_simd v0.15.6 [INFO] [stderr] Downloaded target-features v0.1.6 [INFO] [stderr] Downloaded polars-utils v0.44.2 [INFO] [stderr] Downloaded multiversion v0.7.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16e026f730256f1940f5af5b80680276bd212aac6775f79d153e71f673b08790 [INFO] running `Command { std: "docker" "start" "-a" "16e026f730256f1940f5af5b80680276bd212aac6775f79d153e71f673b08790", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16e026f730256f1940f5af5b80680276bd212aac6775f79d153e71f673b08790", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16e026f730256f1940f5af5b80680276bd212aac6775f79d153e71f673b08790", kill_on_drop: false }` [INFO] [stdout] 16e026f730256f1940f5af5b80680276bd212aac6775f79d153e71f673b08790 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9249b14c57f5c48e6542ab2139c614f3d321f7e7f8e8de370c8a41906d89e6b6 [INFO] running `Command { std: "docker" "start" "-a" "9249b14c57f5c48e6542ab2139c614f3d321f7e7f8e8de370c8a41906d89e6b6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling object v0.32.2 [INFO] [stderr] Checking itoa v1.0.16 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling target-features v0.1.6 [INFO] [stderr] Checking array-init-cursor v0.2.1 [INFO] [stderr] Checking ryu v1.0.21 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Compiling polars-utils v0.44.2 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking planus v0.3.1 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Compiling polars-schema v0.44.2 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Compiling polars-arrow v0.44.2 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking ethnum v1.5.2 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling polars-compute v0.44.2 [INFO] [stderr] Compiling serde_json v1.0.147 [INFO] [stderr] Checking zmij v0.1.9 [INFO] [stderr] Compiling polars-core v0.44.2 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Compiling polars-ops v0.44.2 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking brotli-decompressor v4.0.3 [INFO] [stderr] Checking argminmax v0.6.3 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Checking polars-parquet-format v0.1.0 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling polars-plan v0.44.2 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling pest v2.8.4 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling polars-lazy v0.44.2 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling polars v0.44.2 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling recursive-proc-macro-impl v0.1.1 [INFO] [stderr] Compiling stacker v0.1.22 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Compiling pest_meta v2.8.4 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking fd-lock v4.0.4 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking comfy-table v7.2.1 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Compiling pest_generator v2.8.4 [INFO] [stderr] Compiling ar_archive_writer v0.2.0 [INFO] [stderr] Checking rustyline v14.0.0 [INFO] [stderr] Compiling psm v0.1.28 [INFO] [stderr] Compiling pest_derive v2.8.4 [INFO] [stderr] Checking recursive v0.1.1 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking polars-arrow-format v0.1.0 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking value-trait v0.10.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking simd-json v0.14.3 [INFO] [stderr] Checking polars-error v0.44.2 [INFO] [stderr] Checking polars-row v0.44.2 [INFO] [stderr] Checking polars-json v0.44.2 [INFO] [stderr] Checking lz4 v1.28.1 [INFO] [stderr] Checking polars-parquet v0.44.2 [INFO] [stderr] Checking polars-time v0.44.2 [INFO] [stderr] Checking polars-io v0.44.2 [INFO] [stderr] Checking polars-expr v0.44.2 [INFO] [stderr] Checking polars-mem-engine v0.44.2 [INFO] [stderr] Checking data-transform v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/executor/mod.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 68 | delimiter_counts.entry(delim).or_insert_with(Vec::new).push(count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Executor` [INFO] [stdout] --> src/executor/mod.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | variables: HashMap::new(), [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 133 + impl Default for Executor { [INFO] [stdout] 134 + fn default() -> Self { [INFO] [stdout] 135 + Self::new() [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.delimiter` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 255 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 265 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.trim_whitespace` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:265:45 [INFO] [stdout] | [INFO] [stdout] 255 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 265 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.delimiter` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:362:22 [INFO] [stdout] | [INFO] [stdout] 352 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 362 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.trim_whitespace` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:362:45 [INFO] [stdout] | [INFO] [stdout] 352 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 362 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/executor/mod.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 68 | delimiter_counts.entry(delim).or_insert_with(Vec::new).push(count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Executor` [INFO] [stdout] --> src/executor/mod.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | variables: HashMap::new(), [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 133 + impl Default for Executor { [INFO] [stdout] 134 + fn default() -> Self { [INFO] [stdout] 135 + Self::new() [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.delimiter` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 255 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 265 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.trim_whitespace` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:265:45 [INFO] [stdout] | [INFO] [stdout] 255 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 265 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.delimiter` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:362:22 [INFO] [stdout] | [INFO] [stdout] 352 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 362 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `op.trim_whitespace` after checking its variant with `is_none` [INFO] [stdout] --> src/executor/mod.rs:362:45 [INFO] [stdout] | [INFO] [stdout] 352 | let (delimiter, trim_whitespace) = if op.delimiter.is_none() || op.trim_whitespace.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 362 | (op.delimiter.unwrap(), op.trim_whitespace.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/executor/mod.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 514 | df: &DataFrame, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_df` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/executor/mod.rs:578:69 [INFO] [stdout] | [INFO] [stdout] 578 | let excluded = self.resolve_selector(inner, schema, df)?; [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 586 | let left_cols = self.resolve_selector(left, schema, df)?; [INFO] [stdout] | ^^ [INFO] [stdout] 587 | let right_cols = self.resolve_selector(right, schema, df)?; [INFO] [stdout] | ^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/executor/mod.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 514 | df: &DataFrame, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_df` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/executor/mod.rs:578:69 [INFO] [stdout] | [INFO] [stdout] 578 | let excluded = self.resolve_selector(inner, schema, df)?; [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 586 | let left_cols = self.resolve_selector(left, schema, df)?; [INFO] [stdout] | ^^ [INFO] [stdout] 587 | let right_cols = self.resolve_selector(right, schema, df)?; [INFO] [stdout] | ^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:891:30 [INFO] [stdout] | [INFO] [stdout] 891 | .map_err(|e| DtransformError::PolarsError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:1004:30 [INFO] [stdout] | [INFO] [stdout] 1004 | .map_err(|e| DtransformError::PolarsError(e))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:1009:30 [INFO] [stdout] | [INFO] [stdout] 1009 | .map_err(|e| DtransformError::PolarsError(e))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/executor/mod.rs:1055:56 [INFO] [stdout] | [INFO] [stdout] 1055 | (DataType::String, value_dtype) if matches!( [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 1056 | | value_dtype, [INFO] [stdout] 1057 | | DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 | [INFO] [stdout] 1058 | | DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 | [INFO] [stdout] 1059 | | DataType::Float32 | DataType::Float64 [INFO] [stdout] 1060 | | ) => { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1055 ~ (DataType::String, DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 | [INFO] [stdout] 1056 + DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 | [INFO] [stdout] 1057 ~ DataType::Float32 | DataType::Float64) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:891:30 [INFO] [stdout] | [INFO] [stdout] 891 | .map_err(|e| DtransformError::PolarsError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:1069:38 [INFO] [stdout] | [INFO] [stdout] 1069 | ... .map_err(|e| DtransformError::PolarsError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:1004:30 [INFO] [stdout] | [INFO] [stdout] 1004 | .map_err(|e| DtransformError::PolarsError(e))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:1009:30 [INFO] [stdout] | [INFO] [stdout] 1009 | .map_err(|e| DtransformError::PolarsError(e))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/executor/mod.rs:1055:56 [INFO] [stdout] | [INFO] [stdout] 1055 | (DataType::String, value_dtype) if matches!( [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 1056 | | value_dtype, [INFO] [stdout] 1057 | | DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 | [INFO] [stdout] 1058 | | DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 | [INFO] [stdout] 1059 | | DataType::Float32 | DataType::Float64 [INFO] [stdout] 1060 | | ) => { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1055 ~ (DataType::String, DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 | [INFO] [stdout] 1056 + DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 | [INFO] [stdout] 1057 ~ DataType::Float32 | DataType::Float64) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/executor/mod.rs:1210:34 [INFO] [stdout] | [INFO] [stdout] 1210 | ... .zip(right_str.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1210 - .zip(right_str.into_iter()) [INFO] [stdout] 1210 + .zip(&*right_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/executor/mod.rs:1069:38 [INFO] [stdout] | [INFO] [stdout] 1069 | ... .map_err(|e| DtransformError::PolarsError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DtransformError::PolarsError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/executor/mod.rs:1210:34 [INFO] [stdout] | [INFO] [stdout] 1210 | ... .zip(right_str.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1210 - .zip(right_str.into_iter()) [INFO] [stdout] 1210 + .zip(&*right_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / match inner_pair.as_rule() { [INFO] [stdout] 72 | | Rule::operation => { [INFO] [stdout] 73 | | operations.push(parse_operation(inner_pair)?); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 ~ if inner_pair.as_rule() == Rule::operation { [INFO] [stdout] 72 + operations.push(parse_operation(inner_pair)?); [INFO] [stdout] 73 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / match inner_pair.as_rule() { [INFO] [stdout] 72 | | Rule::operation => { [INFO] [stdout] 73 | | operations.push(parse_operation(inner_pair)?); [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 71 ~ if inner_pair.as_rule() == Rule::operation { [INFO] [stdout] 72 + operations.push(parse_operation(inner_pair)?); [INFO] [stdout] 73 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/mod.rs:573:13 [INFO] [stdout] | [INFO] [stdout] 573 | / return Err(DtransformError::ParseError( [INFO] [stdout] 574 | | "split() must be followed by [index]. Example: split(text, ':')[0]".to_string() [INFO] [stdout] 575 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 573 ~ Err(DtransformError::ParseError( [INFO] [stdout] 574 + "split() must be followed by [index]. Example: split(text, ':')[0]".to_string() [INFO] [stdout] 575 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser/mod.rs:573:13 [INFO] [stdout] | [INFO] [stdout] 573 | / return Err(DtransformError::ParseError( [INFO] [stdout] 574 | | "split() must be followed by [index]. Example: split(text, ':')[0]".to_string() [INFO] [stdout] 575 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 573 ~ Err(DtransformError::ParseError( [INFO] [stdout] 574 + "split() must be followed by [index]. Example: split(text, ':')[0]".to_string() [INFO] [stdout] 575 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `Command { std: "docker" "inspect" "9249b14c57f5c48e6542ab2139c614f3d321f7e7f8e8de370c8a41906d89e6b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9249b14c57f5c48e6542ab2139c614f3d321f7e7f8e8de370c8a41906d89e6b6", kill_on_drop: false }` [INFO] [stdout] 9249b14c57f5c48e6542ab2139c614f3d321f7e7f8e8de370c8a41906d89e6b6