[INFO] fetching crate css-color-parser2 1.0.1... [INFO] linting css-color-parser2-1.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate css-color-parser2 1.0.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate css-color-parser2 1.0.1 [INFO] finished tweaking crates.io crate css-color-parser2 1.0.1 [INFO] tweaked toml for crates.io crate css-color-parser2 1.0.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate css-color-parser2 1.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e8c7e51eeb4a12d14e3a9ce044ed2ee66a799737ca168af00a2bef758844d4c [INFO] running `Command { std: "docker" "start" "-a" "3e8c7e51eeb4a12d14e3a9ce044ed2ee66a799737ca168af00a2bef758844d4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e8c7e51eeb4a12d14e3a9ce044ed2ee66a799737ca168af00a2bef758844d4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e8c7e51eeb4a12d14e3a9ce044ed2ee66a799737ca168af00a2bef758844d4c", kill_on_drop: false }` [INFO] [stdout] 3e8c7e51eeb4a12d14e3a9ce044ed2ee66a799737ca168af00a2bef758844d4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9ba8c243cd8a6e7c09b0fa3b387c82df5c0f97fc21b3ce7996449e56fa7a7f7 [INFO] running `Command { std: "docker" "start" "-a" "d9ba8c243cd8a6e7c09b0fa3b387c82df5c0f97fc21b3ce7996449e56fa7a7f7", kill_on_drop: false }` [INFO] [stderr] Checking css-color-parser2 v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | //! use css_color_parser::Color as CssColor; [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | //! .unwrap_or(transparent_black)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:80:7 [INFO] [stdout] | [INFO] [stdout] 80 | //! println!("{:?}", "hsl(900, 15%, 90%)".parse::() [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | //! // NOTE: not spec compliant. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | //! println!("{:?}", "hsl(900, 0.15, 90%)".parse::() [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:211:25 [INFO] [stdout] | [INFO] [stdout] 211 | rgb_color = Color { a: a, ..rgb_color }; [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | r: r, [INFO] [stdout] | ^^^^ help: replace it with: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | g: g, [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | b: b, [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:251:25 [INFO] [stdout] | [INFO] [stdout] 251 | rgb_color = Color { a: a, ..rgb_color }; [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | r: r, [INFO] [stdout] | ^^^^ help: replace it with: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | g: g, [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | b: b, [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | //! use css_color_parser::Color as CssColor; [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | //! .unwrap_or(transparent_black)); [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:80:7 [INFO] [stdout] | [INFO] [stdout] 80 | //! println!("{:?}", "hsl(900, 15%, 90%)".parse::() [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | //! // NOTE: not spec compliant. [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using tabs in doc comments is not recommended [INFO] [stdout] --> src/lib.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | //! println!("{:?}", "hsl(900, 0.15, 90%)".parse::() [INFO] [stdout] | ^^^^ help: consider using four spaces per tab [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:211:25 [INFO] [stdout] | [INFO] [stdout] 211 | rgb_color = Color { a: a, ..rgb_color }; [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | r: r, [INFO] [stdout] | ^^^^ help: replace it with: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | g: g, [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | b: b, [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:251:25 [INFO] [stdout] | [INFO] [stdout] 251 | rgb_color = Color { a: a, ..rgb_color }; [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | r: r, [INFO] [stdout] | ^^^^ help: replace it with: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | g: g, [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/color/color.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | b: b, [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/color/mod.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | pub mod color; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:154:27 [INFO] [stdout] | [INFO] [stdout] 154 | assert_eq!(c, Color { r: r, g: g, b: b, a: 1.0 }); [INFO] [stdout] | ^^^^ help: replace it with: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:154:33 [INFO] [stdout] | [INFO] [stdout] 154 | assert_eq!(c, Color { r: r, g: g, b: b, a: 1.0 }); [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:154:39 [INFO] [stdout] | [INFO] [stdout] 154 | assert_eq!(c, Color { r: r, g: g, b: b, a: 1.0 }); [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | assert_eq!(c, Color { r: r, g: g, b: b, a: a }); [INFO] [stdout] | ^^^^ help: replace it with: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:173:34 [INFO] [stdout] | [INFO] [stdout] 173 | assert_eq!(c, Color { r: r, g: g, b: b, a: a }); [INFO] [stdout] | ^^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:173:40 [INFO] [stdout] | [INFO] [stdout] 173 | assert_eq!(c, Color { r: r, g: g, b: b, a: a }); [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/tests.rs:173:46 [INFO] [stdout] | [INFO] [stdout] 173 | assert_eq!(c, Color { r: r, g: g, b: b, a: a }); [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return ColorParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return ColorParseError; [INFO] [stdout] 65 + ColorParseError [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return ColorParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return ColorParseError; [INFO] [stdout] 72 + ColorParseError [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/color/color.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | if !(iv <= 0xfff) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(iv > 0xfff)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/color/color.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 138 | if !(iv <= 0xffffff) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(iv > 0xffffff)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return Err(ColorParseError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return Err(ColorParseError); [INFO] [stdout] 195 + Err(ColorParseError) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | return Ok(rgb_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Ok(rgb_color); [INFO] [stdout] 213 + Ok(rgb_color) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | / return Ok(Color { [INFO] [stdout] 231 | | r: r, [INFO] [stdout] 232 | | g: g, [INFO] [stdout] 233 | | b: b, [INFO] [stdout] 234 | | a: 1.0, [INFO] [stdout] 235 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 ~ Ok(Color { [INFO] [stdout] 231 + r: r, [INFO] [stdout] 232 + g: g, [INFO] [stdout] 233 + b: b, [INFO] [stdout] 234 + a: 1.0, [INFO] [stdout] 235 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | return Ok(rgb_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return Ok(rgb_color); [INFO] [stdout] 253 + Ok(rgb_color) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | / return Ok(Color { [INFO] [stdout] 292 | | r: r, [INFO] [stdout] 293 | | g: g, [INFO] [stdout] 294 | | b: b, [INFO] [stdout] 295 | | a: 1.0, [INFO] [stdout] 296 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 ~ Ok(Color { [INFO] [stdout] 292 + r: r, [INFO] [stdout] 293 + g: g, [INFO] [stdout] 294 + b: b, [INFO] [stdout] 295 + a: 1.0, [INFO] [stdout] 296 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/color/color.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | let m2: f32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `m2` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 277 ~ [INFO] [stdout] 278 | [INFO] [stdout] 279 ~ let m2: f32 = if l <= 0.5 { [INFO] [stdout] 280 ~ l * (s + 1.0) [INFO] [stdout] 281 | } else { [INFO] [stdout] 282 ~ l + s - l * s [INFO] [stdout] 283 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | return Ok(clamp_css_float(fv)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return Ok(clamp_css_float(fv)); [INFO] [stdout] 312 + Ok(clamp_css_float(fv)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 328 | return Ok(clamp_css_byte(iv)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return Ok(clamp_css_byte(iv)); [INFO] [stdout] 328 + Ok(clamp_css_byte(iv)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/color/color.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | / if fv < 0.0 { [INFO] [stdout] 335 | | 0.0 [INFO] [stdout] 336 | | } else if fv > 1.0 { [INFO] [stdout] 337 | | 1.0 [INFO] [stdout] 338 | | } else { [INFO] [stdout] 339 | | fv [INFO] [stdout] 340 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `fv.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | return m1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return m1; [INFO] [stdout] 381 + m1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/color/mod.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | pub mod color; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return ColorParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return ColorParseError; [INFO] [stdout] 65 + ColorParseError [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return ColorParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return ColorParseError; [INFO] [stdout] 72 + ColorParseError [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/color/color.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | if !(iv <= 0xfff) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(iv > 0xfff)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/color/color.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 138 | if !(iv <= 0xffffff) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(iv > 0xffffff)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return Err(ColorParseError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return Err(ColorParseError); [INFO] [stdout] 195 + Err(ColorParseError) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | return Ok(rgb_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Ok(rgb_color); [INFO] [stdout] 213 + Ok(rgb_color) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | / return Ok(Color { [INFO] [stdout] 231 | | r: r, [INFO] [stdout] 232 | | g: g, [INFO] [stdout] 233 | | b: b, [INFO] [stdout] 234 | | a: 1.0, [INFO] [stdout] 235 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 ~ Ok(Color { [INFO] [stdout] 231 + r: r, [INFO] [stdout] 232 + g: g, [INFO] [stdout] 233 + b: b, [INFO] [stdout] 234 + a: 1.0, [INFO] [stdout] 235 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | return Ok(rgb_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return Ok(rgb_color); [INFO] [stdout] 253 + Ok(rgb_color) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | / return Ok(Color { [INFO] [stdout] 292 | | r: r, [INFO] [stdout] 293 | | g: g, [INFO] [stdout] 294 | | b: b, [INFO] [stdout] 295 | | a: 1.0, [INFO] [stdout] 296 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 ~ Ok(Color { [INFO] [stdout] 292 + r: r, [INFO] [stdout] 293 + g: g, [INFO] [stdout] 294 + b: b, [INFO] [stdout] 295 + a: 1.0, [INFO] [stdout] 296 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/color/color.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | let m2: f32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `m2` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 277 ~ [INFO] [stdout] 278 | [INFO] [stdout] 279 ~ let m2: f32 = if l <= 0.5 { [INFO] [stdout] 280 ~ l * (s + 1.0) [INFO] [stdout] 281 | } else { [INFO] [stdout] 282 ~ l + s - l * s [INFO] [stdout] 283 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | return Ok(clamp_css_float(fv)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return Ok(clamp_css_float(fv)); [INFO] [stdout] 312 + Ok(clamp_css_float(fv)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 328 | return Ok(clamp_css_byte(iv)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return Ok(clamp_css_byte(iv)); [INFO] [stdout] 328 + Ok(clamp_css_byte(iv)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/color/color.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | / if fv < 0.0 { [INFO] [stdout] 335 | | 0.0 [INFO] [stdout] 336 | | } else if fv > 1.0 { [INFO] [stdout] 337 | | 1.0 [INFO] [stdout] 338 | | } else { [INFO] [stdout] 339 | | fv [INFO] [stdout] 340 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `fv.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/color/color.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | return m1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return m1; [INFO] [stdout] 381 + m1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `Command { std: "docker" "inspect" "d9ba8c243cd8a6e7c09b0fa3b387c82df5c0f97fc21b3ce7996449e56fa7a7f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9ba8c243cd8a6e7c09b0fa3b387c82df5c0f97fc21b3ce7996449e56fa7a7f7", kill_on_drop: false }` [INFO] [stdout] d9ba8c243cd8a6e7c09b0fa3b387c82df5c0f97fc21b3ce7996449e56fa7a7f7