[INFO] fetching crate csheap 0.1.12... [INFO] linting csheap-0.1.12 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate csheap 0.1.12 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate csheap 0.1.12 [INFO] finished tweaking crates.io crate csheap 0.1.12 [INFO] tweaked toml for crates.io crate csheap 0.1.12 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate csheap 0.1.12 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 25ad7ce9a92c1b9f3b48faf1e315f6d715806d177868f1376b273574e0e0f64e [INFO] running `Command { std: "docker" "start" "-a" "25ad7ce9a92c1b9f3b48faf1e315f6d715806d177868f1376b273574e0e0f64e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "25ad7ce9a92c1b9f3b48faf1e315f6d715806d177868f1376b273574e0e0f64e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25ad7ce9a92c1b9f3b48faf1e315f6d715806d177868f1376b273574e0e0f64e", kill_on_drop: false }` [INFO] [stdout] 25ad7ce9a92c1b9f3b48faf1e315f6d715806d177868f1376b273574e0e0f64e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70b5141c92064600b4caedf79fade44f28ff7e6b83dd468f031c00fcd878f53f [INFO] running `Command { std: "docker" "start" "-a" "70b5141c92064600b4caedf79fade44f28ff7e6b83dd468f031c00fcd878f53f", kill_on_drop: false }` [INFO] [stderr] Checking csheap v0.1.12 (/opt/rustwide/workdir) [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stdout] warning: the feature `is_sorted` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(is_sorted)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | i = i - 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.data.get(0)` [INFO] [stdout] --> src/lib.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | self.data.get(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if !data.get(l_index).is_none() && comparator(&data[affected_index], &data[l_index]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.get(l_index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | if !data.get(r_index).is_none() && comparator(&data[affected_index], &data[r_index]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.get(r_index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: the feature `is_sorted` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(is_sorted)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | i = i - 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.data.get(0)` [INFO] [stdout] --> src/lib.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | self.data.get(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if !data.get(l_index).is_none() && comparator(&data[affected_index], &data[l_index]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.get(l_index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | if !data.get(r_index).is_none() && comparator(&data[affected_index], &data[r_index]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.get(r_index).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `input` [INFO] [stdout] --> src/lib.rs:252:18 [INFO] [stdout] | [INFO] [stdout] 252 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 252 - for i in 0..input.len() { [INFO] [stdout] 252 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `input` [INFO] [stdout] --> src/lib.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 268 - for i in 0..input.len() { [INFO] [stdout] 268 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `Command { std: "docker" "inspect" "70b5141c92064600b4caedf79fade44f28ff7e6b83dd468f031c00fcd878f53f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70b5141c92064600b4caedf79fade44f28ff7e6b83dd468f031c00fcd878f53f", kill_on_drop: false }` [INFO] [stdout] 70b5141c92064600b4caedf79fade44f28ff7e6b83dd468f031c00fcd878f53f