[INFO] fetching crate cryptnox_rs 0.1.0... [INFO] linting cryptnox_rs-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cryptnox_rs 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate cryptnox_rs 0.1.0 [INFO] finished tweaking crates.io crate cryptnox_rs 0.1.0 [INFO] tweaked toml for crates.io crate cryptnox_rs 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cryptnox_rs 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 252 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding nfc1 v0.4.1 (available: v0.7.1) [INFO] [stderr] Adding ouroboros v0.13.0 (available: v0.18.5) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pcsc v2.9.0 [INFO] [stderr] Downloaded usb-compat-01-sys v0.2.6 [INFO] [stderr] Downloaded nfc1 v0.4.1 [INFO] [stderr] Downloaded pcsc-sys v1.3.0 [INFO] [stderr] Downloaded nfc1-sys v0.2.1 [INFO] [stderr] Downloaded libusb1-sys v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb0161b6ceb4eb0fb7e4ae8c7ebbe092f884d33e53a2264969b41adef3490bd0 [INFO] running `Command { std: "docker" "start" "-a" "eb0161b6ceb4eb0fb7e4ae8c7ebbe092f884d33e53a2264969b41adef3490bd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb0161b6ceb4eb0fb7e4ae8c7ebbe092f884d33e53a2264969b41adef3490bd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb0161b6ceb4eb0fb7e4ae8c7ebbe092f884d33e53a2264969b41adef3490bd0", kill_on_drop: false }` [INFO] [stdout] eb0161b6ceb4eb0fb7e4ae8c7ebbe092f884d33e53a2264969b41adef3490bd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec62bb61e390e65db2ce1733f8a389bb4daca06f832f160455c7372ca0c42354 [INFO] running `Command { std: "docker" "start" "-a" "ec62bb61e390e65db2ce1733f8a389bb4daca06f832f160455c7372ca0c42354", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling bindgen v0.65.1 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling unicode-width v0.1.14 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling bindgen v0.58.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling libusb1-sys v0.5.0 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling pcsc-sys v1.3.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling ouroboros_macro v0.13.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking pcsc v2.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling env_logger v0.8.4 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking ouroboros v0.13.0 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking sha256 v1.6.0 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling usb-compat-01-sys v0.2.6 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Compiling nfc1-sys v0.2.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking nfc1 v0.4.1 [INFO] [stderr] Checking cryptnox_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 36 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 36 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 39 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] 39 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:60:19 [INFO] [stdout] | [INFO] [stdout] 60 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 60 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 60 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 63 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 63 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 66 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 84 | fn derive(self: &mut Self, key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 84 - fn derive(self: &mut Self, key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] 84 + fn derive(&mut self, key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 91 | fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 91 - fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] 91 + fn dual_seed_public_key(&mut self, _pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:94:23 [INFO] [stdout] | [INFO] [stdout] 94 | fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 94 - fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] 94 + fn dual_seed_load(&mut self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:97:28 [INFO] [stdout] | [INFO] [stdout] 97 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 97 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 97 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 100 - fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] 100 + fn generate_random_number(&mut self, _size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 103 - fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 103 + fn generate_seed(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:118:23 [INFO] [stdout] | [INFO] [stdout] 118 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 118 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] 118 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 168 - fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 168 + fn history(&mut self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 171 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 171 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 171 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 174 - fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] 174 + fn load_seed(&mut self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 202 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 202 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 202 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 205 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 205 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:208:14 [INFO] [stdout] | [INFO] [stdout] 208 | fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 208 - fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] 208 + fn reset(&mut self, puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 223 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 223 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:226:31 [INFO] [stdout] | [INFO] [stdout] 226 | fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 226 - fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 226 + fn set_pin_authentication(&mut self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:230:25 [INFO] [stdout] | [INFO] [stdout] 230 | fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 230 - fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 230 + fn set_pinless_path(&mut self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:233:32 [INFO] [stdout] | [INFO] [stdout] 233 | fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 233 - fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] 233 + fn set_extended_public_key(&mut self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filt... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 236 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] 236 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:299:24 [INFO] [stdout] | [INFO] [stdout] 299 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 299 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 299 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:302:20 [INFO] [stdout] | [INFO] [stdout] 302 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 302 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] 302 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:306:18 [INFO] [stdout] | [INFO] [stdout] 306 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 306 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 306 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:309:24 [INFO] [stdout] | [INFO] [stdout] 309 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 309 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 309 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:312:21 [INFO] [stdout] | [INFO] [stdout] 312 | fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 312 - fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] 312 + fn user_key_add(&mut self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:315:24 [INFO] [stdout] | [INFO] [stdout] 315 | fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 315 - fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 315 + fn user_key_delete(&mut self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:318:22 [INFO] [stdout] | [INFO] [stdout] 318 | fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 318 + fn user_key_info(&mut self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:321:25 [INFO] [stdout] | [INFO] [stdout] 321 | fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 321 - fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] 321 + fn user_key_enabled(&self, _slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:324:42 [INFO] [stdout] | [INFO] [stdout] 324 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 324 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 324 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:327:41 [INFO] [stdout] | [INFO] [stdout] 327 | fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 327 - fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] 327 + fn user_key_challenge_response_open(&mut self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:330:32 [INFO] [stdout] | [INFO] [stdout] 330 | fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 330 - fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] 330 + fn user_key_signature_open(&mut self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:333:18 [INFO] [stdout] | [INFO] [stdout] 333 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 333 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 333 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:336:18 [INFO] [stdout] | [INFO] [stdout] 336 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 336 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 336 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:339:18 [INFO] [stdout] | [INFO] [stdout] 339 | fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 339 - fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 339 + fn valid_puk(&self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 361 - fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 361 + fn sign_eos(&mut self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 365 - fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] 365 + fn get_info(&mut self) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:373:24 [INFO] [stdout] | [INFO] [stdout] 373 | fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 373 - fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] 373 + fn signature_check(&mut self, _nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:379:14 [INFO] [stdout] | [INFO] [stdout] 379 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 379 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 379 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:396:26 [INFO] [stdout] | [INFO] [stdout] 396 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 396 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 396 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:399:22 [INFO] [stdout] | [INFO] [stdout] 399 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 399 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 399 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:402:30 [INFO] [stdout] | [INFO] [stdout] 402 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 402 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 402 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:405:22 [INFO] [stdout] | [INFO] [stdout] 405 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 405 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 405 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:408:26 [INFO] [stdout] | [INFO] [stdout] 408 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 408 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 408 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:411:25 [INFO] [stdout] | [INFO] [stdout] 411 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 411 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 411 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 37 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 37 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 40 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] 40 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 61 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 61 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 64 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 64 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 67 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn derive(self: &mut Self, _key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 85 - fn derive(self: &mut Self, _key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] 85 + fn derive(&mut self, _key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 103 - fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 103 + fn dual_seed_public_key(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 117 - fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] 117 + fn dual_seed_load(&mut self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:131:28 [INFO] [stdout] | [INFO] [stdout] 131 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 131 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 131 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:134:31 [INFO] [stdout] | [INFO] [stdout] 134 | fn generate_random_number(self: &mut Self, size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 134 - fn generate_random_number(self: &mut Self, size: u8) -> Result { [INFO] [stdout] 134 + fn generate_random_number(&mut self, size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 137 | fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 137 - fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 137 + fn generate_seed(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 161 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 161 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] 161 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 212 - fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 212 + fn history(&mut self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:221:23 [INFO] [stdout] | [INFO] [stdout] 221 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 221 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 221 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 224 | fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 224 - fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] 224 + fn load_seed(&mut self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 252 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 252 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 252 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:255:24 [INFO] [stdout] | [INFO] [stdout] 255 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 255 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 255 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:258:14 [INFO] [stdout] | [INFO] [stdout] 258 | fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 258 - fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] 258 + fn reset(&mut self, puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:272:20 [INFO] [stdout] | [INFO] [stdout] 272 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 272 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 272 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:285:31 [INFO] [stdout] | [INFO] [stdout] 285 | fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 285 - fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) -> Result<(),Error> { [INFO] [stdout] 285 + fn set_pin_authentication(&mut self, status: bool, puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:298:25 [INFO] [stdout] | [INFO] [stdout] 298 | fn set_pinless_path(self: &mut Self, path: String, puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 298 - fn set_pinless_path(self: &mut Self, path: String, puk: &str) -> Result<(),Error> { [INFO] [stdout] 298 + fn set_pinless_path(&mut self, path: String, puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:318:32 [INFO] [stdout] | [INFO] [stdout] 318 | fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] 318 + fn set_extended_public_key(&mut self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filt... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 333 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] 333 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:397:24 [INFO] [stdout] | [INFO] [stdout] 397 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 397 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 397 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:404:20 [INFO] [stdout] | [INFO] [stdout] 404 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 404 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] 404 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 415 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 415 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 415 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:418:24 [INFO] [stdout] | [INFO] [stdout] 418 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 418 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 418 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:421:21 [INFO] [stdout] | [INFO] [stdout] 421 | fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 421 - fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] 421 + fn user_key_add(&mut self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:468:24 [INFO] [stdout] | [INFO] [stdout] 468 | fn user_key_delete(self: &mut Self, slot: u8, puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 468 - fn user_key_delete(self: &mut Self, slot: u8, puk: &str) -> Result<(),Error> { [INFO] [stdout] 468 + fn user_key_delete(&mut self, slot: u8, puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:493:22 [INFO] [stdout] | [INFO] [stdout] 493 | fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 493 - fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 493 + fn user_key_info(&mut self, slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:513:25 [INFO] [stdout] | [INFO] [stdout] 513 | fn user_key_enabled(self: &Self, slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 513 - fn user_key_enabled(self: &Self, slot: u8) -> bool { [INFO] [stdout] 513 + fn user_key_enabled(&self, slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:516:42 [INFO] [stdout] | [INFO] [stdout] 516 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 516 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 516 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:525:41 [INFO] [stdout] | [INFO] [stdout] 525 | fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 525 - fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool { [INFO] [stdout] 525 + fn user_key_challenge_response_open(&mut self, slot: u8, signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:547:32 [INFO] [stdout] | [INFO] [stdout] 547 | fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 547 - fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool { [INFO] [stdout] 547 + fn user_key_signature_open(&mut self, slot: u8, message: Bytes, signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:558:18 [INFO] [stdout] | [INFO] [stdout] 558 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 558 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 558 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:561:18 [INFO] [stdout] | [INFO] [stdout] 561 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 561 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 561 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:564:18 [INFO] [stdout] | [INFO] [stdout] 564 | fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 564 - fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 564 + fn valid_puk(&self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 586 - fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 586 + fn sign_eos(&mut self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:590:17 [INFO] [stdout] | [INFO] [stdout] 590 | fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 590 - fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] 590 + fn get_info(&mut self) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:598:24 [INFO] [stdout] | [INFO] [stdout] 598 | fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 598 - fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] 598 + fn signature_check(&mut self, _nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:604:14 [INFO] [stdout] | [INFO] [stdout] 604 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 604 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 604 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:621:26 [INFO] [stdout] | [INFO] [stdout] 621 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 621 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 621 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:624:22 [INFO] [stdout] | [INFO] [stdout] 624 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 624 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 624 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:627:30 [INFO] [stdout] | [INFO] [stdout] 627 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 627 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 627 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:630:22 [INFO] [stdout] | [INFO] [stdout] 630 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 630 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 630 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:633:26 [INFO] [stdout] | [INFO] [stdout] 633 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 633 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 633 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:636:25 [INFO] [stdout] | [INFO] [stdout] 636 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 636 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 636 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 44 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 44 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 47 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] 47 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 68 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 68 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 71 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 71 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 74 - fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 74 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 153 | fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 153 - fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] 153 + fn derive(&mut self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 156 | fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 156 - fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 156 + fn dual_seed_public_key(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:170:23 [INFO] [stdout] | [INFO] [stdout] 170 | fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 170 - fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] 170 + fn dual_seed_load(&mut self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:184:28 [INFO] [stdout] | [INFO] [stdout] 184 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 184 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 184 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:187:31 [INFO] [stdout] | [INFO] [stdout] 187 | fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 187 - fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] 187 + fn generate_random_number(&mut self, _size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:190:22 [INFO] [stdout] | [INFO] [stdout] 190 | fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 190 - fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 190 + fn generate_seed(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:214:23 [INFO] [stdout] | [INFO] [stdout] 214 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 214 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] 214 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:265:16 [INFO] [stdout] | [INFO] [stdout] 265 | fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 265 - fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 265 + fn history(&mut self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:274:23 [INFO] [stdout] | [INFO] [stdout] 274 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 274 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 274 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 277 | fn load_seed(self: &mut Self, _seed: Option, _pin: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 277 - fn load_seed(self: &mut Self, _seed: Option, _pin: Option)-> Result<(),Error> { [INFO] [stdout] 277 + fn load_seed(&mut self, _seed: Option, _pin: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:280:27 [INFO] [stdout] | [INFO] [stdout] 280 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 280 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 280 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:283:24 [INFO] [stdout] | [INFO] [stdout] 283 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 283 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 283 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:286:14 [INFO] [stdout] | [INFO] [stdout] 286 | fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 286 - fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] 286 + fn reset(&mut self, puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:301:20 [INFO] [stdout] | [INFO] [stdout] 301 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 301 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 301 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:314:31 [INFO] [stdout] | [INFO] [stdout] 314 | fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 314 - fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 314 + fn set_pin_authentication(&mut self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 318 + fn set_pinless_path(&mut self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:321:32 [INFO] [stdout] | [INFO] [stdout] 321 | fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 321 - fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] 321 + fn set_extended_public_key(&mut self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filt... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 336 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] 336 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:400:24 [INFO] [stdout] | [INFO] [stdout] 400 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 400 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 400 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:407:20 [INFO] [stdout] | [INFO] [stdout] 407 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 407 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] 407 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:411:18 [INFO] [stdout] | [INFO] [stdout] 411 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 411 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 411 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:414:24 [INFO] [stdout] | [INFO] [stdout] 414 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 414 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 414 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 417 | fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 417 - fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] 417 + fn user_key_add(&mut self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:420:24 [INFO] [stdout] | [INFO] [stdout] 420 | fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 420 - fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 420 + fn user_key_delete(&mut self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:423:22 [INFO] [stdout] | [INFO] [stdout] 423 | fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 423 - fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 423 + fn user_key_info(&mut self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:426:25 [INFO] [stdout] | [INFO] [stdout] 426 | fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 426 - fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] 426 + fn user_key_enabled(&self, _slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:429:42 [INFO] [stdout] | [INFO] [stdout] 429 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 429 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 429 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:432:41 [INFO] [stdout] | [INFO] [stdout] 432 | fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 432 - fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] 432 + fn user_key_challenge_response_open(&mut self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:435:32 [INFO] [stdout] | [INFO] [stdout] 435 | fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 435 - fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] 435 + fn user_key_signature_open(&mut self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:438:18 [INFO] [stdout] | [INFO] [stdout] 438 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 438 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 438 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:441:18 [INFO] [stdout] | [INFO] [stdout] 441 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 441 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 441 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:444:18 [INFO] [stdout] | [INFO] [stdout] 444 | fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 444 - fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 444 + fn valid_puk(&self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:466:17 [INFO] [stdout] | [INFO] [stdout] 466 | fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 466 - fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 466 + fn sign_eos(&mut self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:470:17 [INFO] [stdout] | [INFO] [stdout] 470 | fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 470 - fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] 470 + fn get_info(&mut self) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:477:24 [INFO] [stdout] | [INFO] [stdout] 477 | fn signature_check(self: &mut Self, nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 477 - fn signature_check(self: &mut Self, nonce: Bytes) -> Result{ [INFO] [stdout] 477 + fn signature_check(&mut self, nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:494:14 [INFO] [stdout] | [INFO] [stdout] 494 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 494 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 494 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:511:26 [INFO] [stdout] | [INFO] [stdout] 511 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 511 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 511 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:514:22 [INFO] [stdout] | [INFO] [stdout] 514 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 514 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 514 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:517:30 [INFO] [stdout] | [INFO] [stdout] 517 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 517 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 517 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:520:22 [INFO] [stdout] | [INFO] [stdout] 520 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 520 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 520 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:523:26 [INFO] [stdout] | [INFO] [stdout] 523 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 523 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 523 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:526:25 [INFO] [stdout] | [INFO] [stdout] 526 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 526 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 526 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/card/basic.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | serial: serial, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 57 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 57 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 60 | fn change_pairing_key(self: &mut Self, _index: u8, _pairing_key: &[u8], _puk: String)-> std::result::Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 60 - fn change_pairing_key(self: &mut Self, _index: u8, _pairing_key: &[u8], _puk: String)-> std::result::Result<(), Error> { [INFO] [stdout] 60 + fn change_pairing_key(&mut self, _index: u8, _pairing_key: &[u8], _puk: String)-> std::result::Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 63 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 63 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 76 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 76 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 91 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 163 | fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 163 - fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] 163 + fn derive(&mut self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:166:29 [INFO] [stdout] | [INFO] [stdout] 166 | fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 166 - fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] 166 + fn dual_seed_public_key(&mut self, _pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 36 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 36 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:169:23 [INFO] [stdout] | [INFO] [stdout] 169 | fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 169 - fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] 169 + fn dual_seed_load(&mut self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 39 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] 39 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:60:19 [INFO] [stdout] | [INFO] [stdout] 60 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 60 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 60 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 172 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 172 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 172 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 63 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 63 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 66 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 84 | fn derive(self: &mut Self, key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 84 - fn derive(self: &mut Self, key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] 84 + fn derive(&mut self, key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:175:31 [INFO] [stdout] | [INFO] [stdout] 175 | fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 175 - fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] 175 + fn generate_random_number(&mut self, _size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 91 | fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 91 - fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] 91 + fn dual_seed_public_key(&mut self, _pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:94:23 [INFO] [stdout] | [INFO] [stdout] 94 | fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 94 - fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] 94 + fn dual_seed_load(&mut self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:97:28 [INFO] [stdout] | [INFO] [stdout] 97 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 97 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 97 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:178:22 [INFO] [stdout] | [INFO] [stdout] 178 | fn generate_seed(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 178 - fn generate_seed(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] 178 + fn generate_seed(&mut self, _pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 100 - fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] 100 + fn generate_random_number(&mut self, _size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 103 - fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 103 + fn generate_seed(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:181:23 [INFO] [stdout] | [INFO] [stdout] 181 | fn get_public_key(self: &mut Self, _derivation: u8, _key_type: Option, _path: Option, _compressed: Option) -... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 181 - fn get_public_key(self: &mut Self, _derivation: u8, _key_type: Option, _path: Option, _compressed: Option) -> Result { [INFO] [stdout] 181 + fn get_public_key(&mut self, _derivation: u8, _key_type: Option, _path: Option, _compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:118:23 [INFO] [stdout] | [INFO] [stdout] 118 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 118 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] 118 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 168 - fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 168 + fn history(&mut self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 171 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 171 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 171 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 174 - fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] 174 + fn load_seed(&mut self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:184:16 [INFO] [stdout] | [INFO] [stdout] 184 | fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 184 - fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 184 + fn history(&mut self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:187:23 [INFO] [stdout] | [INFO] [stdout] 187 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 187 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 187 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:190:18 [INFO] [stdout] | [INFO] [stdout] 190 | fn load_seed(self: &mut Self, _seed: Option,_pinn: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 190 - fn load_seed(self: &mut Self, _seed: Option,_pinn: Option)-> Result<(),Error> { [INFO] [stdout] 190 + fn load_seed(&mut self, _seed: Option,_pinn: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:193:27 [INFO] [stdout] | [INFO] [stdout] 193 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 193 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 193 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 196 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 196 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 196 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:199:14 [INFO] [stdout] | [INFO] [stdout] 199 | fn reset(self: &mut Self, _puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 199 - fn reset(self: &mut Self, _puk: &str) { [INFO] [stdout] 199 + fn reset(&mut self, _puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:202:20 [INFO] [stdout] | [INFO] [stdout] 202 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 202 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 202 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:205:31 [INFO] [stdout] | [INFO] [stdout] 205 | fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 205 - fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] 205 + fn set_pin_authentication(&mut self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:208:25 [INFO] [stdout] | [INFO] [stdout] 208 | fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 208 - fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 208 + fn set_pinless_path(&mut self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 211 | fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 211 - fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str)-> Result<(),Error> { [INFO] [stdout] 211 + fn set_extended_public_key(&mut self, _status: bool, _puk: &str)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | fn sign(self: &mut Self, _data: Bytes,_derivationn: Option, _key_type: Option, _path: Option<&str>,_pin: Option<&str>,_... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 214 - fn sign(self: &mut Self, _data: Bytes,_derivationn: Option, _key_type: Option, _path: Option<&str>,_pin: Option<&str>,_filter_eos: Option) -> Result{ [INFO] [stdout] 214 + fn sign(&mut self, _data: Bytes,_derivationn: Option, _key_type: Option, _path: Option<&str>,_pin: Option<&str>,_filter_eos: Option) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:217:24 [INFO] [stdout] | [INFO] [stdout] 217 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 217 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 217 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:220:20 [INFO] [stdout] | [INFO] [stdout] 220 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 220 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 220 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:237:18 [INFO] [stdout] | [INFO] [stdout] 237 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 237 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 237 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:240:24 [INFO] [stdout] | [INFO] [stdout] 240 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 240 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 240 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:243:21 [INFO] [stdout] | [INFO] [stdout] 243 | fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 243 - fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ->Result<(),Error>{ [INFO] [stdout] 243 + fn user_key_add(&mut self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ->Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:246:24 [INFO] [stdout] | [INFO] [stdout] 246 | fn user_key_delete(self: &mut Self, _slot: u8, _puk_code: &str) ->Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 246 - fn user_key_delete(self: &mut Self, _slot: u8, _puk_code: &str) ->Result<(),Error>{ [INFO] [stdout] 246 + fn user_key_delete(&mut self, _slot: u8, _puk_code: &str) ->Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 249 | fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 249 - fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 249 + fn user_key_info(&mut self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 202 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 202 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 202 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:252:25 [INFO] [stdout] | [INFO] [stdout] 252 | fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 252 - fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] 252 + fn user_key_enabled(&self, _slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:255:42 [INFO] [stdout] | [INFO] [stdout] 255 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 255 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 255 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:258:41 [INFO] [stdout] | [INFO] [stdout] 258 | fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 258 - fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] 258 + fn user_key_challenge_response_open(&mut self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:261:32 [INFO] [stdout] | [INFO] [stdout] 261 | fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 261 - fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] 261 + fn user_key_signature_open(&mut self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:264:18 [INFO] [stdout] | [INFO] [stdout] 264 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 264 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 264 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:267:18 [INFO] [stdout] | [INFO] [stdout] 267 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 267 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 267 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | fn valid_puk(self: &Self, puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 282 - fn valid_puk(self: &Self, puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 282 + fn valid_puk(&self, puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:304:17 [INFO] [stdout] | [INFO] [stdout] 304 | fn sign_eos(self: &mut Self, _apdu: &[u32], _data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 304 - fn sign_eos(self: &mut Self, _apdu: &[u32], _data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 304 + fn sign_eos(&mut self, _apdu: &[u32], _data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:308:17 [INFO] [stdout] | [INFO] [stdout] 308 | fn get_info(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 308 - fn get_info(self: &mut Self) -> Result { [INFO] [stdout] 308 + fn get_info(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:312:24 [INFO] [stdout] | [INFO] [stdout] 312 | fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 312 - fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] 312 + fn signature_check(&mut self, _nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:318:14 [INFO] [stdout] | [INFO] [stdout] 318 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 318 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:321:26 [INFO] [stdout] | [INFO] [stdout] 321 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 321 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 321 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:324:22 [INFO] [stdout] | [INFO] [stdout] 324 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 324 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 324 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:327:30 [INFO] [stdout] | [INFO] [stdout] 327 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 327 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 327 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:330:22 [INFO] [stdout] | [INFO] [stdout] 330 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 330 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 330 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:333:26 [INFO] [stdout] | [INFO] [stdout] 333 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 333 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 333 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 336 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 336 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 336 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 205 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 205 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:208:14 [INFO] [stdout] | [INFO] [stdout] 208 | fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 208 - fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] 208 + fn reset(&mut self, puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 223 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 223 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:226:31 [INFO] [stdout] | [INFO] [stdout] 226 | fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 226 - fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 226 + fn set_pin_authentication(&mut self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:230:25 [INFO] [stdout] | [INFO] [stdout] 230 | fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 230 - fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 230 + fn set_pinless_path(&mut self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:233:32 [INFO] [stdout] | [INFO] [stdout] 233 | fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 233 - fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] 233 + fn set_extended_public_key(&mut self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filt... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 236 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] 236 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:299:24 [INFO] [stdout] | [INFO] [stdout] 299 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 299 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 299 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:302:20 [INFO] [stdout] | [INFO] [stdout] 302 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 302 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] 302 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:306:18 [INFO] [stdout] | [INFO] [stdout] 306 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 306 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 306 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 135 | fn puk_rule(self: &Self) -> String; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 135 - fn puk_rule(self: &Self) -> String; [INFO] [stdout] 135 + fn puk_rule(&self) -> String; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:309:24 [INFO] [stdout] | [INFO] [stdout] 309 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 309 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 309 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:312:21 [INFO] [stdout] | [INFO] [stdout] 312 | fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 312 - fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] 312 + fn user_key_add(&mut self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:315:24 [INFO] [stdout] | [INFO] [stdout] 315 | fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 315 - fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 315 + fn user_key_delete(&mut self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | fn is_alive(self: &mut Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 137 - fn is_alive(self: &mut Self) -> bool { [INFO] [stdout] 137 + fn is_alive(&mut self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:318:22 [INFO] [stdout] | [INFO] [stdout] 318 | fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 318 + fn user_key_info(&mut self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:321:25 [INFO] [stdout] | [INFO] [stdout] 321 | fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 321 - fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] 321 + fn user_key_enabled(&self, _slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:324:42 [INFO] [stdout] | [INFO] [stdout] 324 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 324 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 324 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:327:41 [INFO] [stdout] | [INFO] [stdout] 327 | fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 327 - fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] 327 + fn user_key_challenge_response_open(&mut self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:158:27 [INFO] [stdout] | [INFO] [stdout] 158 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 158 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error>; [INFO] [stdout] 158 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:330:32 [INFO] [stdout] | [INFO] [stdout] 330 | fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 330 - fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] 330 + fn user_key_signature_open(&mut self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 159 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error>; [INFO] [stdout] 159 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:333:18 [INFO] [stdout] | [INFO] [stdout] 333 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 333 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 333 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 160 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error>; [INFO] [stdout] 160 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:336:18 [INFO] [stdout] | [INFO] [stdout] 336 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 336 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 336 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option,nfc_sign: Option) -> Result,Error>; [INFO] [stdout] 161 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option) -> Result,Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 162 | fn derive(self: &mut Self,key_type: Option, path: Option) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 162 - fn derive(self: &mut Self,key_type: Option, path: Option) -> Result<(),Error>; [INFO] [stdout] 162 + fn derive(&mut self,key_type: Option, path: Option) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:163:29 [INFO] [stdout] | [INFO] [stdout] 163 | fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 163 - fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] 163 + fn dual_seed_public_key(&mut self, pin: &str) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str)-> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 164 - fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str)-> Result<(),Error>; [INFO] [stdout] 164 + fn dual_seed_load(&mut self,data: Bytes, pin: &str)-> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:165:28 [INFO] [stdout] | [INFO] [stdout] 165 | fn extended_public_key(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 165 - fn extended_public_key(self: &Self) -> bool; [INFO] [stdout] 165 + fn extended_public_key(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 166 | fn generate_random_number(self: &mut Self, size: u8) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 166 - fn generate_random_number(self: &mut Self, size: u8) -> Result; [INFO] [stdout] 166 + fn generate_random_number(&mut self, size: u8) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:167:22 [INFO] [stdout] | [INFO] [stdout] 167 | fn generate_seed(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 167 - fn generate_seed(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] 167 + fn generate_seed(&mut self, pin: &str) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:168:23 [INFO] [stdout] | [INFO] [stdout] 168 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 168 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result; [INFO] [stdout] 168 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:169:16 [INFO] [stdout] | [INFO] [stdout] 169 | fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 169 - fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error>; [INFO] [stdout] 169 + fn history(&mut self, index: u8) -> Result<(u32,Bytes),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | fn info(self: &mut Self) -> CardInfo { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 170 - fn info(self: &mut Self) -> CardInfo { [INFO] [stdout] 170 + fn info(&mut self) -> CardInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:181:23 [INFO] [stdout] | [INFO] [stdout] 181 | fn is_initialized(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 181 - fn is_initialized(self: &Self) -> bool; [INFO] [stdout] 181 + fn is_initialized(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | fn load_seed(self: &mut Self, seed: Option, pin: Option) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 182 - fn load_seed(self: &mut Self, seed: Option, pin: Option) -> Result<(),Error>; [INFO] [stdout] 182 + fn load_seed(&mut self, seed: Option, pin: Option) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:183:16 [INFO] [stdout] | [INFO] [stdout] 183 | fn is_open(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 183 - fn is_open(self: &Self) -> bool { [INFO] [stdout] 183 + fn is_open(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:186:15 [INFO] [stdout] | [INFO] [stdout] 186 | fn origin(self: &mut Self) -> CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 186 - fn origin(self: &mut Self) -> CardOrigin { [INFO] [stdout] 186 + fn origin(&mut self) -> CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:192:27 [INFO] [stdout] | [INFO] [stdout] 192 | fn pin_authentication(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 192 - fn pin_authentication(self: &Self) -> bool; [INFO] [stdout] 192 + fn pin_authentication(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | fn pinless_enabled(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 193 - fn pinless_enabled(self: &Self) -> bool; [INFO] [stdout] 193 + fn pinless_enabled(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:339:18 [INFO] [stdout] | [INFO] [stdout] 339 | fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 339 - fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 339 + fn valid_puk(&self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 361 - fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 361 + fn sign_eos(&mut self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 365 - fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] 365 + fn get_info(&mut self) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:373:24 [INFO] [stdout] | [INFO] [stdout] 373 | fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 373 - fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] 373 + fn signature_check(&mut self, _nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:379:14 [INFO] [stdout] | [INFO] [stdout] 379 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 379 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 379 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:396:26 [INFO] [stdout] | [INFO] [stdout] 396 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 396 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 396 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:399:22 [INFO] [stdout] | [INFO] [stdout] 399 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 399 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 399 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:402:30 [INFO] [stdout] | [INFO] [stdout] 402 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 402 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 402 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:405:22 [INFO] [stdout] | [INFO] [stdout] 405 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 405 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 405 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:408:26 [INFO] [stdout] | [INFO] [stdout] 408 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 408 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 408 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen0.rs:411:25 [INFO] [stdout] | [INFO] [stdout] 411 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 411 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 411 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 37 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 37 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 40 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] 40 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 61 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 61 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 64 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 64 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 67 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn derive(self: &mut Self, _key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 85 - fn derive(self: &mut Self, _key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] 85 + fn derive(&mut self, _key_type: Option, path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 103 - fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 103 + fn dual_seed_public_key(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 117 - fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] 117 + fn dual_seed_load(&mut self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:131:28 [INFO] [stdout] | [INFO] [stdout] 131 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 131 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 131 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:134:31 [INFO] [stdout] | [INFO] [stdout] 134 | fn generate_random_number(self: &mut Self, size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 134 - fn generate_random_number(self: &mut Self, size: u8) -> Result { [INFO] [stdout] 134 + fn generate_random_number(&mut self, size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 137 | fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 137 - fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 137 + fn generate_seed(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:194:14 [INFO] [stdout] | [INFO] [stdout] 194 | fn reset(self: &mut Self, puk: &str); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 194 - fn reset(self: &mut Self, puk: &str); [INFO] [stdout] 194 + fn reset(&mut self, puk: &str); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:195:20 [INFO] [stdout] | [INFO] [stdout] 195 | fn seed_source(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 195 - fn seed_source(self: &mut Self) -> Result; [INFO] [stdout] 195 + fn seed_source(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:196:31 [INFO] [stdout] | [INFO] [stdout] 196 | fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) ->Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 196 - fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) ->Result<(),Error>; [INFO] [stdout] 196 + fn set_pin_authentication(&mut self, status: bool, puk: &str) ->Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:197:25 [INFO] [stdout] | [INFO] [stdout] 197 | fn set_pinless_path(self: &mut Self, path: String, puk: &str)-> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 197 - fn set_pinless_path(self: &mut Self, path: String, puk: &str)-> Result<(),Error>; [INFO] [stdout] 197 + fn set_pinless_path(&mut self, path: String, puk: &str)-> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:198:32 [INFO] [stdout] | [INFO] [stdout] 198 | fn set_extended_public_key(self: &mut Self, status: bool, puk: &str)-> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 198 - fn set_extended_public_key(self: &mut Self, status: bool, puk: &str)-> Result<(),Error>; [INFO] [stdout] 198 + fn set_extended_public_key(&mut self, status: bool, puk: &str)-> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>,pin: Option<&str>,filter... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 199 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>,pin: Option<&str>,filter_eos: Option) -> Result; [INFO] [stdout] 199 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>,pin: Option<&str>,filter_eos: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:200:24 [INFO] [stdout] | [INFO] [stdout] 200 | fn signing_counter(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 200 - fn signing_counter(self: &mut Self) -> Result; [INFO] [stdout] 200 + fn signing_counter(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:201:20 [INFO] [stdout] | [INFO] [stdout] 201 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 201 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>; [INFO] [stdout] 201 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 202 | fn user_data(self: &Self) -> Bytes; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 202 - fn user_data(self: &Self) -> Bytes; [INFO] [stdout] 202 + fn user_data(&self) -> Bytes; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | fn write_user_data(self: &Self, value: Bytes); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 203 - fn write_user_data(self: &Self, value: Bytes); [INFO] [stdout] 203 + fn write_user_data(&self, value: Bytes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 204 | fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 204 - fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>; [INFO] [stdout] 204 + fn user_key_add(&mut self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | fn user_key_delete(self: &mut Self, slot: u8, puk_code: &str) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 205 - fn user_key_delete(self: &mut Self, slot: u8, puk_code: &str) -> Result<(),Error>; [INFO] [stdout] 205 + fn user_key_delete(&mut self, slot: u8, puk_code: &str) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 206 - fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error>; [INFO] [stdout] 206 + fn user_key_info(&mut self, slot: u8) -> Result<(String,Bytes),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | fn user_key_enabled(self: &Self, slot: u8) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 207 - fn user_key_enabled(self: &Self, slot: u8) -> bool; [INFO] [stdout] 207 + fn user_key_enabled(&self, slot: u8) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:208:42 [INFO] [stdout] | [INFO] [stdout] 208 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 208 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result; [INFO] [stdout] 208 + fn user_key_challenge_response_nonce(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:209:41 [INFO] [stdout] | [INFO] [stdout] 209 | fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 209 - fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool; [INFO] [stdout] 209 + fn user_key_challenge_response_open(&mut self, slot: u8, signature: Bytes) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:210:32 [INFO] [stdout] | [INFO] [stdout] 210 | fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 210 - fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool; [INFO] [stdout] 210 + fn user_key_signature_open(&mut self, slot: u8, message: Bytes, signature: Bytes) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:211:18 [INFO] [stdout] | [INFO] [stdout] 211 | fn valid_key(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 211 - fn valid_key(self: &Self) -> bool; [INFO] [stdout] 211 + fn valid_key(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:212:18 [INFO] [stdout] | [INFO] [stdout] 212 | fn valid_pin(self: &Self,pin: String,pin_name: Option) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 212 - fn valid_pin(self: &Self,pin: String,pin_name: Option) -> Result; [INFO] [stdout] 212 + fn valid_pin(&self,pin: String,pin_name: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:213:18 [INFO] [stdout] | [INFO] [stdout] 213 | fn valid_puk(self: &Self,puk: String,puk_name: Option) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 213 - fn valid_puk(self: &Self,puk: String,puk_name: Option) -> Result; [INFO] [stdout] 213 + fn valid_puk(&self,puk: String,puk_name: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | fn verify_pin(self: &mut Self, pin: &str); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 214 - fn verify_pin(self: &mut Self, pin: &str); [INFO] [stdout] 214 + fn verify_pin(&mut self, pin: &str); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | fn sign_eos(self: &mut Self,apdu: &[u32],data: Bytes,pin: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 215 - fn sign_eos(self: &mut Self,apdu: &[u32],data: Bytes,pin: &str) -> Result; [INFO] [stdout] 215 + fn sign_eos(&mut self,apdu: &[u32],data: Bytes,pin: &str) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 161 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 161 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] 161 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 212 - fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 212 + fn history(&mut self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:221:23 [INFO] [stdout] | [INFO] [stdout] 221 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 221 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 221 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 224 | fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 224 - fn load_seed(self: &mut Self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] 224 + fn load_seed(&mut self, seed: Option, pin: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 252 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 252 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 252 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:255:24 [INFO] [stdout] | [INFO] [stdout] 255 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 255 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 255 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:258:14 [INFO] [stdout] | [INFO] [stdout] 258 | fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 258 - fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] 258 + fn reset(&mut self, puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:272:20 [INFO] [stdout] | [INFO] [stdout] 272 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 272 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 272 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:285:31 [INFO] [stdout] | [INFO] [stdout] 285 | fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 285 - fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) -> Result<(),Error> { [INFO] [stdout] 285 + fn set_pin_authentication(&mut self, status: bool, puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:298:25 [INFO] [stdout] | [INFO] [stdout] 298 | fn set_pinless_path(self: &mut Self, path: String, puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 298 - fn set_pinless_path(self: &mut Self, path: String, puk: &str) -> Result<(),Error> { [INFO] [stdout] 298 + fn set_pinless_path(&mut self, path: String, puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:318:32 [INFO] [stdout] | [INFO] [stdout] 318 | fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] 318 + fn set_extended_public_key(&mut self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filt... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 333 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] 333 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:397:24 [INFO] [stdout] | [INFO] [stdout] 397 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 397 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 397 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:404:20 [INFO] [stdout] | [INFO] [stdout] 404 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 404 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] 404 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:216:17 [INFO] [stdout] | [INFO] [stdout] 216 | fn get_info(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 216 - fn get_info(self: &mut Self) -> Result; [INFO] [stdout] 216 + fn get_info(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:217:24 [INFO] [stdout] | [INFO] [stdout] 217 | fn signature_check(self: &mut Self, nonce: Bytes) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 217 - fn signature_check(self: &mut Self, nonce: Bytes) -> Result; [INFO] [stdout] 217 + fn signature_check(&mut self, nonce: Bytes) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:222:14 [INFO] [stdout] | [INFO] [stdout] 222 | fn owner(self: &mut Self) -> CardUser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 222 - fn owner(self: &mut Self) -> CardUser; [INFO] [stdout] 222 + fn owner(&mut self) -> CardUser; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:223:25 [INFO] [stdout] | [INFO] [stdout] 223 | fn borrow_auth_type(self: &Self) -> &AuthType; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 223 - fn borrow_auth_type(self: &Self) -> &AuthType; [INFO] [stdout] 223 + fn borrow_auth_type(&self) -> &AuthType; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:224:26 [INFO] [stdout] | [INFO] [stdout] 224 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 224 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection; [INFO] [stdout] 224 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:225:22 [INFO] [stdout] | [INFO] [stdout] 225 | fn serial_number(self: &Self) -> u64; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 225 - fn serial_number(self: &Self) -> u64; [INFO] [stdout] 225 + fn serial_number(&self) -> u64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | fn borrow_applet_version(self: &Self) -> &Vec; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 226 - fn borrow_applet_version(self: &Self) -> &Vec; [INFO] [stdout] 226 + fn borrow_applet_version(&self) -> &Vec; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:227:22 [INFO] [stdout] | [INFO] [stdout] 227 | fn borrow_origin(self: &Self) -> &CardOrigin; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 227 - fn borrow_origin(self: &Self) -> &CardOrigin; [INFO] [stdout] 227 + fn borrow_origin(&self) -> &CardOrigin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:228:26 [INFO] [stdout] | [INFO] [stdout] 228 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 228 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin; [INFO] [stdout] 228 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 415 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 415 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 415 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/reader.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | fn connect(self: &mut Self) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 11 - fn connect(self: &mut Self) -> Result<()>; [INFO] [stdout] 11 + fn connect(&mut self) -> Result<()>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:418:24 [INFO] [stdout] | [INFO] [stdout] 418 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 418 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 418 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:421:21 [INFO] [stdout] | [INFO] [stdout] 421 | fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 421 - fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] 421 + fn user_key_add(&mut self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:468:24 [INFO] [stdout] | [INFO] [stdout] 468 | fn user_key_delete(self: &mut Self, slot: u8, puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 468 - fn user_key_delete(self: &mut Self, slot: u8, puk: &str) -> Result<(),Error> { [INFO] [stdout] 468 + fn user_key_delete(&mut self, slot: u8, puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:493:22 [INFO] [stdout] | [INFO] [stdout] 493 | fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 493 - fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 493 + fn user_key_info(&mut self, slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:513:25 [INFO] [stdout] | [INFO] [stdout] 513 | fn user_key_enabled(self: &Self, slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 513 - fn user_key_enabled(self: &Self, slot: u8) -> bool { [INFO] [stdout] 513 + fn user_key_enabled(&self, slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:516:42 [INFO] [stdout] | [INFO] [stdout] 516 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 516 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 516 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/reader.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | fn send(self: &Self, apdu: &[u8]) -> Result<(Vec, u8, u8)>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 13 - fn send(self: &Self, apdu: &[u8]) -> Result<(Vec, u8, u8)>; [INFO] [stdout] 13 + fn send(&self, apdu: &[u8]) -> Result<(Vec, u8, u8)>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/reader.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | fn active_connection(self: &mut Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 14 - fn active_connection(self: &mut Self) -> bool; [INFO] [stdout] 14 + fn active_connection(&mut self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:525:41 [INFO] [stdout] | [INFO] [stdout] 525 | fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 525 - fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool { [INFO] [stdout] 525 + fn user_key_challenge_response_open(&mut self, slot: u8, signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:547:32 [INFO] [stdout] | [INFO] [stdout] 547 | fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 547 - fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool { [INFO] [stdout] 547 + fn user_key_signature_open(&mut self, slot: u8, message: Bytes, signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:558:18 [INFO] [stdout] | [INFO] [stdout] 558 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 558 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 558 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:561:18 [INFO] [stdout] | [INFO] [stdout] 561 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 561 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 561 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:564:18 [INFO] [stdout] | [INFO] [stdout] 564 | fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 564 - fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 564 + fn valid_puk(&self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 586 - fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 586 + fn sign_eos(&mut self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:590:17 [INFO] [stdout] | [INFO] [stdout] 590 | fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 590 - fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] 590 + fn get_info(&mut self) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:598:24 [INFO] [stdout] | [INFO] [stdout] 598 | fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 598 - fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] 598 + fn signature_check(&mut self, _nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:604:14 [INFO] [stdout] | [INFO] [stdout] 604 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 604 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 604 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:621:26 [INFO] [stdout] | [INFO] [stdout] 621 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 621 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 621 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:624:22 [INFO] [stdout] | [INFO] [stdout] 624 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 624 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 624 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:627:30 [INFO] [stdout] | [INFO] [stdout] 627 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 627 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 627 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:630:22 [INFO] [stdout] | [INFO] [stdout] 630 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 630 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 630 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:633:26 [INFO] [stdout] | [INFO] [stdout] 633 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 633 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 633 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/gen1.rs:636:25 [INFO] [stdout] | [INFO] [stdout] 636 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 636 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 636 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 44 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 44 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 47 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] 47 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 68 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 68 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 71 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 71 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 74 - fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 74 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 153 | fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 153 - fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] 153 + fn derive(&mut self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 156 | fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 156 - fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 156 + fn dual_seed_public_key(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:170:23 [INFO] [stdout] | [INFO] [stdout] 170 | fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 170 - fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] 170 + fn dual_seed_load(&mut self,data: Bytes, pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:184:28 [INFO] [stdout] | [INFO] [stdout] 184 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 184 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 184 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:187:31 [INFO] [stdout] | [INFO] [stdout] 187 | fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 187 - fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] 187 + fn generate_random_number(&mut self, _size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:190:22 [INFO] [stdout] | [INFO] [stdout] 190 | fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 190 - fn generate_seed(self: &mut Self, pin: &str) -> Result { [INFO] [stdout] 190 + fn generate_seed(&mut self, pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:214:23 [INFO] [stdout] | [INFO] [stdout] 214 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 214 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] 214 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:265:16 [INFO] [stdout] | [INFO] [stdout] 265 | fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 265 - fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 265 + fn history(&mut self, index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:274:23 [INFO] [stdout] | [INFO] [stdout] 274 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 274 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 274 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 277 | fn load_seed(self: &mut Self, _seed: Option, _pin: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 277 - fn load_seed(self: &mut Self, _seed: Option, _pin: Option)-> Result<(),Error> { [INFO] [stdout] 277 + fn load_seed(&mut self, _seed: Option, _pin: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:280:27 [INFO] [stdout] | [INFO] [stdout] 280 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 280 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 280 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:283:24 [INFO] [stdout] | [INFO] [stdout] 283 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 283 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 283 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:286:14 [INFO] [stdout] | [INFO] [stdout] 286 | fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 286 - fn reset(self: &mut Self, puk: &str) { [INFO] [stdout] 286 + fn reset(&mut self, puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:301:20 [INFO] [stdout] | [INFO] [stdout] 301 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 301 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 301 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:314:31 [INFO] [stdout] | [INFO] [stdout] 314 | fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 314 - fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 314 + fn set_pin_authentication(&mut self, _status: bool, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 318 + fn set_pinless_path(&mut self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:321:32 [INFO] [stdout] | [INFO] [stdout] 321 | fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 321 - fn set_extended_public_key(self: &mut Self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] 321 + fn set_extended_public_key(&mut self, status: bool, puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filt... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 336 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] 336 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>, pin: Option<&str>, filter_eos: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:400:24 [INFO] [stdout] | [INFO] [stdout] 400 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 400 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 400 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:407:20 [INFO] [stdout] | [INFO] [stdout] 407 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 407 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] 407 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:411:18 [INFO] [stdout] | [INFO] [stdout] 411 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 411 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 411 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:414:24 [INFO] [stdout] | [INFO] [stdout] 414 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 414 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 414 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 417 | fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 417 - fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] 417 + fn user_key_add(&mut self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:420:24 [INFO] [stdout] | [INFO] [stdout] 420 | fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 420 - fn user_key_delete(self: &mut Self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 420 + fn user_key_delete(&mut self, _slot: u8, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:423:22 [INFO] [stdout] | [INFO] [stdout] 423 | fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 423 - fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 423 + fn user_key_info(&mut self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:426:25 [INFO] [stdout] | [INFO] [stdout] 426 | fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 426 - fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] 426 + fn user_key_enabled(&self, _slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:429:42 [INFO] [stdout] | [INFO] [stdout] 429 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 429 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 429 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:432:41 [INFO] [stdout] | [INFO] [stdout] 432 | fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 432 - fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] 432 + fn user_key_challenge_response_open(&mut self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:435:32 [INFO] [stdout] | [INFO] [stdout] 435 | fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 435 - fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] 435 + fn user_key_signature_open(&mut self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:438:18 [INFO] [stdout] | [INFO] [stdout] 438 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 438 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 438 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:441:18 [INFO] [stdout] | [INFO] [stdout] 441 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 441 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 441 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:444:18 [INFO] [stdout] | [INFO] [stdout] 444 | fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 444 - fn valid_puk(self: &Self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 444 + fn valid_puk(&self,puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:466:17 [INFO] [stdout] | [INFO] [stdout] 466 | fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 466 - fn sign_eos(self: &mut Self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 466 + fn sign_eos(&mut self,_apdu: &[u32],_data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:470:17 [INFO] [stdout] | [INFO] [stdout] 470 | fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 470 - fn get_info(self: &mut Self) -> Result{ [INFO] [stdout] 470 + fn get_info(&mut self) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:477:24 [INFO] [stdout] | [INFO] [stdout] 477 | fn signature_check(self: &mut Self, nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 477 - fn signature_check(self: &mut Self, nonce: Bytes) -> Result{ [INFO] [stdout] 477 + fn signature_check(&mut self, nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:494:14 [INFO] [stdout] | [INFO] [stdout] 494 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 494 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 494 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:511:26 [INFO] [stdout] | [INFO] [stdout] 511 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 511 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 511 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:514:22 [INFO] [stdout] | [INFO] [stdout] 514 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 514 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 514 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:517:30 [INFO] [stdout] | [INFO] [stdout] 517 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 517 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 517 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:520:22 [INFO] [stdout] | [INFO] [stdout] 520 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 520 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 520 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:523:26 [INFO] [stdout] | [INFO] [stdout] 523 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 523 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 523 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic/nft.rs:526:25 [INFO] [stdout] | [INFO] [stdout] 526 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 526 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 526 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/card/basic.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | serial: serial, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | fn puk_rule(self: &Self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 57 - fn puk_rule(self: &Self) -> String { [INFO] [stdout] 57 + fn puk_rule(&self) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 60 | fn change_pairing_key(self: &mut Self, _index: u8, _pairing_key: &[u8], _puk: String)-> std::result::Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 60 - fn change_pairing_key(self: &mut Self, _index: u8, _pairing_key: &[u8], _puk: String)-> std::result::Result<(), Error> { [INFO] [stdout] 60 + fn change_pairing_key(&mut self, _index: u8, _pairing_key: &[u8], _puk: String)-> std::result::Result<(), Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 63 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 63 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 76 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] 76 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] 91 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,_nfc_sign: Option) -> Result,Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 163 | fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 163 - fn derive(self: &mut Self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] 163 + fn derive(&mut self, _key_type: Option, _path: Option) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:166:29 [INFO] [stdout] | [INFO] [stdout] 166 | fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 166 - fn dual_seed_public_key(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] 166 + fn dual_seed_public_key(&mut self, _pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:169:23 [INFO] [stdout] | [INFO] [stdout] 169 | fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 169 - fn dual_seed_load(self: &mut Self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] 169 + fn dual_seed_load(&mut self,_data: Bytes, _pin: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 172 | fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 172 - fn extended_public_key(self: &Self) -> bool { [INFO] [stdout] 172 + fn extended_public_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:175:31 [INFO] [stdout] | [INFO] [stdout] 175 | fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 175 - fn generate_random_number(self: &mut Self, _size: u8) -> Result { [INFO] [stdout] 175 + fn generate_random_number(&mut self, _size: u8) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:178:22 [INFO] [stdout] | [INFO] [stdout] 178 | fn generate_seed(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 178 - fn generate_seed(self: &mut Self, _pin: &str) -> Result { [INFO] [stdout] 178 + fn generate_seed(&mut self, _pin: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:181:23 [INFO] [stdout] | [INFO] [stdout] 181 | fn get_public_key(self: &mut Self, _derivation: u8, _key_type: Option, _path: Option, _compressed: Option) -... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 181 - fn get_public_key(self: &mut Self, _derivation: u8, _key_type: Option, _path: Option, _compressed: Option) -> Result { [INFO] [stdout] 181 + fn get_public_key(&mut self, _derivation: u8, _key_type: Option, _path: Option, _compressed: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:184:16 [INFO] [stdout] | [INFO] [stdout] 184 | fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 184 - fn history(self: &mut Self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] 184 + fn history(&mut self, _index: u8) -> Result<(u32,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:187:23 [INFO] [stdout] | [INFO] [stdout] 187 | fn is_initialized(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 187 - fn is_initialized(self: &Self) -> bool { [INFO] [stdout] 187 + fn is_initialized(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:190:18 [INFO] [stdout] | [INFO] [stdout] 190 | fn load_seed(self: &mut Self, _seed: Option,_pinn: Option)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 190 - fn load_seed(self: &mut Self, _seed: Option,_pinn: Option)-> Result<(),Error> { [INFO] [stdout] 190 + fn load_seed(&mut self, _seed: Option,_pinn: Option)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:193:27 [INFO] [stdout] | [INFO] [stdout] 193 | fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 193 - fn pin_authentication(self: &Self) -> bool { [INFO] [stdout] 193 + fn pin_authentication(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 196 | fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 196 - fn pinless_enabled(self: &Self) -> bool { [INFO] [stdout] 196 + fn pinless_enabled(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:199:14 [INFO] [stdout] | [INFO] [stdout] 199 | fn reset(self: &mut Self, _puk: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 199 - fn reset(self: &mut Self, _puk: &str) { [INFO] [stdout] 199 + fn reset(&mut self, _puk: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:202:20 [INFO] [stdout] | [INFO] [stdout] 202 | fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 202 - fn seed_source(self: &mut Self) -> Result { [INFO] [stdout] 202 + fn seed_source(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:205:31 [INFO] [stdout] | [INFO] [stdout] 205 | fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 205 - fn set_pin_authentication(self: &mut Self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] 205 + fn set_pin_authentication(&mut self, _status: bool, _puk: &str) -> Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:208:25 [INFO] [stdout] | [INFO] [stdout] 208 | fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 208 - fn set_pinless_path(self: &mut Self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] 208 + fn set_pinless_path(&mut self, _path: String, _puk: &str) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 211 | fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str)-> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 211 - fn set_extended_public_key(self: &mut Self, _status: bool, _puk: &str)-> Result<(),Error> { [INFO] [stdout] 211 + fn set_extended_public_key(&mut self, _status: bool, _puk: &str)-> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | fn sign(self: &mut Self, _data: Bytes,_derivationn: Option, _key_type: Option, _path: Option<&str>,_pin: Option<&str>,_... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 214 - fn sign(self: &mut Self, _data: Bytes,_derivationn: Option, _key_type: Option, _path: Option<&str>,_pin: Option<&str>,_filter_eos: Option) -> Result{ [INFO] [stdout] 214 + fn sign(&mut self, _data: Bytes,_derivationn: Option, _key_type: Option, _path: Option<&str>,_pin: Option<&str>,_filter_eos: Option) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:217:24 [INFO] [stdout] | [INFO] [stdout] 217 | fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 217 - fn signing_counter(self: &mut Self) -> Result { [INFO] [stdout] 217 + fn signing_counter(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:220:20 [INFO] [stdout] | [INFO] [stdout] 220 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 220 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error> { [INFO] [stdout] 220 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:237:18 [INFO] [stdout] | [INFO] [stdout] 237 | fn user_data(self: &Self) -> Bytes { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 237 - fn user_data(self: &Self) -> Bytes { [INFO] [stdout] 237 + fn user_data(&self) -> Bytes { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:240:24 [INFO] [stdout] | [INFO] [stdout] 240 | fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 240 - fn write_user_data(self: &Self, _value: Bytes) { [INFO] [stdout] 240 + fn write_user_data(&self, _value: Bytes) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:243:21 [INFO] [stdout] | [INFO] [stdout] 243 | fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 243 - fn user_key_add(self: &mut Self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ->Result<(),Error>{ [INFO] [stdout] 243 + fn user_key_add(&mut self, _slot_index: u8, _data_info : &str, _public_key: Bytes, _puk: &str, _cred_id : Option) ->Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:246:24 [INFO] [stdout] | [INFO] [stdout] 246 | fn user_key_delete(self: &mut Self, _slot: u8, _puk_code: &str) ->Result<(),Error>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 246 - fn user_key_delete(self: &mut Self, _slot: u8, _puk_code: &str) ->Result<(),Error>{ [INFO] [stdout] 246 + fn user_key_delete(&mut self, _slot: u8, _puk_code: &str) ->Result<(),Error>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 249 | fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 249 - fn user_key_info(self: &mut Self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] 249 + fn user_key_info(&mut self, _slot: u8) -> Result<(String,Bytes),Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:252:25 [INFO] [stdout] | [INFO] [stdout] 252 | fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 252 - fn user_key_enabled(self: &Self, _slot: u8) -> bool { [INFO] [stdout] 252 + fn user_key_enabled(&self, _slot: u8) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:255:42 [INFO] [stdout] | [INFO] [stdout] 255 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 255 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result { [INFO] [stdout] 255 + fn user_key_challenge_response_nonce(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:258:41 [INFO] [stdout] | [INFO] [stdout] 258 | fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 258 - fn user_key_challenge_response_open(self: &mut Self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] 258 + fn user_key_challenge_response_open(&mut self, _slot: u8, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:261:32 [INFO] [stdout] | [INFO] [stdout] 261 | fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 261 - fn user_key_signature_open(self: &mut Self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] 261 + fn user_key_signature_open(&mut self, _slot: u8, _message: Bytes, _signature: Bytes) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:264:18 [INFO] [stdout] | [INFO] [stdout] 264 | fn valid_key(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 264 - fn valid_key(self: &Self) -> bool { [INFO] [stdout] 264 + fn valid_key(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:267:18 [INFO] [stdout] | [INFO] [stdout] 267 | fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 267 - fn valid_pin(self: &Self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] 267 + fn valid_pin(&self,pin: String, _pin_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | fn valid_puk(self: &Self, puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 282 - fn valid_puk(self: &Self, puk: String, _puk_name: Option) -> Result { [INFO] [stdout] 282 + fn valid_puk(&self, puk: String, _puk_name: Option) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:304:17 [INFO] [stdout] | [INFO] [stdout] 304 | fn sign_eos(self: &mut Self, _apdu: &[u32], _data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 304 - fn sign_eos(self: &mut Self, _apdu: &[u32], _data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] 304 + fn sign_eos(&mut self, _apdu: &[u32], _data: Bytes, _pin: &str) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:308:17 [INFO] [stdout] | [INFO] [stdout] 308 | fn get_info(self: &mut Self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 308 - fn get_info(self: &mut Self) -> Result { [INFO] [stdout] 308 + fn get_info(&mut self) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:312:24 [INFO] [stdout] | [INFO] [stdout] 312 | fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 312 - fn signature_check(self: &mut Self, _nonce: Bytes) -> Result{ [INFO] [stdout] 312 + fn signature_check(&mut self, _nonce: Bytes) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:318:14 [INFO] [stdout] | [INFO] [stdout] 318 | fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 318 - fn owner(self: &mut Self) -> CardUser { [INFO] [stdout] 318 + fn owner(&mut self) -> CardUser { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:321:26 [INFO] [stdout] | [INFO] [stdout] 321 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 321 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection { [INFO] [stdout] 321 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:324:22 [INFO] [stdout] | [INFO] [stdout] 324 | fn serial_number(self: &Self) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 324 - fn serial_number(self: &Self) -> u64 { [INFO] [stdout] 324 + fn serial_number(&self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:327:30 [INFO] [stdout] | [INFO] [stdout] 327 | fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 327 - fn borrow_applet_version(self: &Self) -> &Vec { [INFO] [stdout] 327 + fn borrow_applet_version(&self) -> &Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:330:22 [INFO] [stdout] | [INFO] [stdout] 330 | fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 330 - fn borrow_origin(self: &Self) -> &CardOrigin { [INFO] [stdout] 330 + fn borrow_origin(&self) -> &CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:333:26 [INFO] [stdout] | [INFO] [stdout] 333 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 333 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin { [INFO] [stdout] 333 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card/basic.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 336 | fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 336 - fn borrow_auth_type(self: &Self) -> &AuthType { [INFO] [stdout] 336 + fn borrow_auth_type(&self) -> &AuthType { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 135 | fn puk_rule(self: &Self) -> String; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 135 - fn puk_rule(self: &Self) -> String; [INFO] [stdout] 135 + fn puk_rule(&self) -> String; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | fn is_alive(self: &mut Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 137 - fn is_alive(self: &mut Self) -> bool { [INFO] [stdout] 137 + fn is_alive(&mut self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:158:27 [INFO] [stdout] | [INFO] [stdout] 158 | fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 158 - fn change_pairing_key(self: &mut Self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error>; [INFO] [stdout] 158 + fn change_pairing_key(&mut self, index: u8, pairing_key: &[u8], puk: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 159 - fn change_pin(self: &mut Self, new_pin: String) -> Result<(),Error>; [INFO] [stdout] 159 + fn change_pin(&mut self, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 160 - fn change_puk(self: &mut Self, current_puk: String, new_puk: String) -> Result<(),Error>; [INFO] [stdout] 160 + fn change_puk(&mut self, current_puk: String, new_puk: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | fn init(self: &Self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option,nfc_sign: Option) -> Result,Error>; [INFO] [stdout] 161 + fn init(&self, name: String, email: String, pin: String, puk: String, pairing_secret: Option,nfc_sign: Option) -> Result,Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 162 | fn derive(self: &mut Self,key_type: Option, path: Option) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 162 - fn derive(self: &mut Self,key_type: Option, path: Option) -> Result<(),Error>; [INFO] [stdout] 162 + fn derive(&mut self,key_type: Option, path: Option) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:163:29 [INFO] [stdout] | [INFO] [stdout] 163 | fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 163 - fn dual_seed_public_key(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] 163 + fn dual_seed_public_key(&mut self, pin: &str) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str)-> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 164 - fn dual_seed_load(self: &mut Self,data: Bytes, pin: &str)-> Result<(),Error>; [INFO] [stdout] 164 + fn dual_seed_load(&mut self,data: Bytes, pin: &str)-> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:165:28 [INFO] [stdout] | [INFO] [stdout] 165 | fn extended_public_key(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 165 - fn extended_public_key(self: &Self) -> bool; [INFO] [stdout] 165 + fn extended_public_key(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 166 | fn generate_random_number(self: &mut Self, size: u8) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 166 - fn generate_random_number(self: &mut Self, size: u8) -> Result; [INFO] [stdout] 166 + fn generate_random_number(&mut self, size: u8) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:167:22 [INFO] [stdout] | [INFO] [stdout] 167 | fn generate_seed(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 167 - fn generate_seed(self: &mut Self, pin: &str) -> Result; [INFO] [stdout] 167 + fn generate_seed(&mut self, pin: &str) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:168:23 [INFO] [stdout] | [INFO] [stdout] 168 | fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 168 - fn get_public_key(self: &mut Self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result; [INFO] [stdout] 168 + fn get_public_key(&mut self, derivation: u8, key_type: Option, path: Option, compressed: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:169:16 [INFO] [stdout] | [INFO] [stdout] 169 | fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 169 - fn history(self: &mut Self, index: u8) -> Result<(u32,Bytes),Error>; [INFO] [stdout] 169 + fn history(&mut self, index: u8) -> Result<(u32,Bytes),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | fn info(self: &mut Self) -> CardInfo { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 170 - fn info(self: &mut Self) -> CardInfo { [INFO] [stdout] 170 + fn info(&mut self) -> CardInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:181:23 [INFO] [stdout] | [INFO] [stdout] 181 | fn is_initialized(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 181 - fn is_initialized(self: &Self) -> bool; [INFO] [stdout] 181 + fn is_initialized(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | fn load_seed(self: &mut Self, seed: Option, pin: Option) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 182 - fn load_seed(self: &mut Self, seed: Option, pin: Option) -> Result<(),Error>; [INFO] [stdout] 182 + fn load_seed(&mut self, seed: Option, pin: Option) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:183:16 [INFO] [stdout] | [INFO] [stdout] 183 | fn is_open(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 183 - fn is_open(self: &Self) -> bool { [INFO] [stdout] 183 + fn is_open(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:186:15 [INFO] [stdout] | [INFO] [stdout] 186 | fn origin(self: &mut Self) -> CardOrigin { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 186 - fn origin(self: &mut Self) -> CardOrigin { [INFO] [stdout] 186 + fn origin(&mut self) -> CardOrigin { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:192:27 [INFO] [stdout] | [INFO] [stdout] 192 | fn pin_authentication(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 192 - fn pin_authentication(self: &Self) -> bool; [INFO] [stdout] 192 + fn pin_authentication(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | fn pinless_enabled(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 193 - fn pinless_enabled(self: &Self) -> bool; [INFO] [stdout] 193 + fn pinless_enabled(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:194:14 [INFO] [stdout] | [INFO] [stdout] 194 | fn reset(self: &mut Self, puk: &str); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 194 - fn reset(self: &mut Self, puk: &str); [INFO] [stdout] 194 + fn reset(&mut self, puk: &str); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:195:20 [INFO] [stdout] | [INFO] [stdout] 195 | fn seed_source(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 195 - fn seed_source(self: &mut Self) -> Result; [INFO] [stdout] 195 + fn seed_source(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:196:31 [INFO] [stdout] | [INFO] [stdout] 196 | fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) ->Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 196 - fn set_pin_authentication(self: &mut Self, status: bool, puk: &str) ->Result<(),Error>; [INFO] [stdout] 196 + fn set_pin_authentication(&mut self, status: bool, puk: &str) ->Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:197:25 [INFO] [stdout] | [INFO] [stdout] 197 | fn set_pinless_path(self: &mut Self, path: String, puk: &str)-> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 197 - fn set_pinless_path(self: &mut Self, path: String, puk: &str)-> Result<(),Error>; [INFO] [stdout] 197 + fn set_pinless_path(&mut self, path: String, puk: &str)-> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:198:32 [INFO] [stdout] | [INFO] [stdout] 198 | fn set_extended_public_key(self: &mut Self, status: bool, puk: &str)-> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 198 - fn set_extended_public_key(self: &mut Self, status: bool, puk: &str)-> Result<(),Error>; [INFO] [stdout] 198 + fn set_extended_public_key(&mut self, status: bool, puk: &str)-> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>,pin: Option<&str>,filter... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 199 - fn sign(self: &mut Self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>,pin: Option<&str>,filter_eos: Option) -> Result; [INFO] [stdout] 199 + fn sign(&mut self, data: Bytes, derivation: Option, key_type: Option, path: Option<&str>,pin: Option<&str>,filter_eos: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:200:24 [INFO] [stdout] | [INFO] [stdout] 200 | fn signing_counter(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 200 - fn signing_counter(self: &mut Self) -> Result; [INFO] [stdout] 200 + fn signing_counter(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:201:20 [INFO] [stdout] | [INFO] [stdout] 201 | fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 201 - fn unblock_pin(self: &mut Self, puk: String, new_pin: String) -> Result<(),Error>; [INFO] [stdout] 201 + fn unblock_pin(&mut self, puk: String, new_pin: String) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 202 | fn user_data(self: &Self) -> Bytes; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 202 - fn user_data(self: &Self) -> Bytes; [INFO] [stdout] 202 + fn user_data(&self) -> Bytes; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | fn write_user_data(self: &Self, value: Bytes); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 203 - fn write_user_data(self: &Self, value: Bytes); [INFO] [stdout] 203 + fn write_user_data(&self, value: Bytes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 204 | fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Re... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 204 - fn user_key_add(self: &mut Self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>; [INFO] [stdout] 204 + fn user_key_add(&mut self, slot_index: u8, data_info : &str, public_key: Bytes, puk: &str, cred_id : Option) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:205:24 [INFO] [stdout] | [INFO] [stdout] 205 | fn user_key_delete(self: &mut Self, slot: u8, puk_code: &str) -> Result<(),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 205 - fn user_key_delete(self: &mut Self, slot: u8, puk_code: &str) -> Result<(),Error>; [INFO] [stdout] 205 + fn user_key_delete(&mut self, slot: u8, puk_code: &str) -> Result<(),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 206 - fn user_key_info(self: &mut Self, slot: u8) -> Result<(String,Bytes),Error>; [INFO] [stdout] 206 + fn user_key_info(&mut self, slot: u8) -> Result<(String,Bytes),Error>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | fn user_key_enabled(self: &Self, slot: u8) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 207 - fn user_key_enabled(self: &Self, slot: u8) -> bool; [INFO] [stdout] 207 + fn user_key_enabled(&self, slot: u8) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:208:42 [INFO] [stdout] | [INFO] [stdout] 208 | fn user_key_challenge_response_nonce(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 208 - fn user_key_challenge_response_nonce(self: &mut Self) -> Result; [INFO] [stdout] 208 + fn user_key_challenge_response_nonce(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:209:41 [INFO] [stdout] | [INFO] [stdout] 209 | fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 209 - fn user_key_challenge_response_open(self: &mut Self, slot: u8, signature: Bytes) -> bool; [INFO] [stdout] 209 + fn user_key_challenge_response_open(&mut self, slot: u8, signature: Bytes) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:210:32 [INFO] [stdout] | [INFO] [stdout] 210 | fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 210 - fn user_key_signature_open(self: &mut Self, slot: u8, message: Bytes, signature: Bytes) -> bool; [INFO] [stdout] 210 + fn user_key_signature_open(&mut self, slot: u8, message: Bytes, signature: Bytes) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:211:18 [INFO] [stdout] | [INFO] [stdout] 211 | fn valid_key(self: &Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 211 - fn valid_key(self: &Self) -> bool; [INFO] [stdout] 211 + fn valid_key(&self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:212:18 [INFO] [stdout] | [INFO] [stdout] 212 | fn valid_pin(self: &Self,pin: String,pin_name: Option) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 212 - fn valid_pin(self: &Self,pin: String,pin_name: Option) -> Result; [INFO] [stdout] 212 + fn valid_pin(&self,pin: String,pin_name: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:213:18 [INFO] [stdout] | [INFO] [stdout] 213 | fn valid_puk(self: &Self,puk: String,puk_name: Option) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 213 - fn valid_puk(self: &Self,puk: String,puk_name: Option) -> Result; [INFO] [stdout] 213 + fn valid_puk(&self,puk: String,puk_name: Option) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | fn verify_pin(self: &mut Self, pin: &str); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 214 - fn verify_pin(self: &mut Self, pin: &str); [INFO] [stdout] 214 + fn verify_pin(&mut self, pin: &str); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | fn sign_eos(self: &mut Self,apdu: &[u32],data: Bytes,pin: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 215 - fn sign_eos(self: &mut Self,apdu: &[u32],data: Bytes,pin: &str) -> Result; [INFO] [stdout] 215 + fn sign_eos(&mut self,apdu: &[u32],data: Bytes,pin: &str) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:216:17 [INFO] [stdout] | [INFO] [stdout] 216 | fn get_info(self: &mut Self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 216 - fn get_info(self: &mut Self) -> Result; [INFO] [stdout] 216 + fn get_info(&mut self) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:217:24 [INFO] [stdout] | [INFO] [stdout] 217 | fn signature_check(self: &mut Self, nonce: Bytes) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 217 - fn signature_check(self: &mut Self, nonce: Bytes) -> Result; [INFO] [stdout] 217 + fn signature_check(&mut self, nonce: Bytes) -> Result; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:222:14 [INFO] [stdout] | [INFO] [stdout] 222 | fn owner(self: &mut Self) -> CardUser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 222 - fn owner(self: &mut Self) -> CardUser; [INFO] [stdout] 222 + fn owner(&mut self) -> CardUser; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:223:25 [INFO] [stdout] | [INFO] [stdout] 223 | fn borrow_auth_type(self: &Self) -> &AuthType; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 223 - fn borrow_auth_type(self: &Self) -> &AuthType; [INFO] [stdout] 223 + fn borrow_auth_type(&self) -> &AuthType; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:224:26 [INFO] [stdout] | [INFO] [stdout] 224 | fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 224 - fn borrow_connection(self: &mut Self) -> &mut crate::connection::Connection; [INFO] [stdout] 224 + fn borrow_connection(&mut self) -> &mut crate::connection::Connection; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:225:22 [INFO] [stdout] | [INFO] [stdout] 225 | fn serial_number(self: &Self) -> u64; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 225 - fn serial_number(self: &Self) -> u64; [INFO] [stdout] 225 + fn serial_number(&self) -> u64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:226:30 [INFO] [stdout] | [INFO] [stdout] 226 | fn borrow_applet_version(self: &Self) -> &Vec; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 226 - fn borrow_applet_version(self: &Self) -> &Vec; [INFO] [stdout] 226 + fn borrow_applet_version(&self) -> &Vec; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:227:22 [INFO] [stdout] | [INFO] [stdout] 227 | fn borrow_origin(self: &Self) -> &CardOrigin; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 227 - fn borrow_origin(self: &Self) -> &CardOrigin; [INFO] [stdout] 227 + fn borrow_origin(&self) -> &CardOrigin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/card.rs:228:26 [INFO] [stdout] | [INFO] [stdout] 228 | fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 228 - fn borrow_origin_mut(self: &mut Self) -> &mut CardOrigin; [INFO] [stdout] 228 + fn borrow_origin_mut(&mut self) -> &mut CardOrigin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/reader.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | fn connect(self: &mut Self) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 11 - fn connect(self: &mut Self) -> Result<()>; [INFO] [stdout] 11 + fn connect(&mut self) -> Result<()>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/reader.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | fn send(self: &Self, apdu: &[u8]) -> Result<(Vec, u8, u8)>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 13 - fn send(self: &Self, apdu: &[u8]) -> Result<(Vec, u8, u8)>; [INFO] [stdout] 13 + fn send(&self, apdu: &[u8]) -> Result<(Vec, u8, u8)>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/reader.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | fn active_connection(self: &mut Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 14 - fn active_connection(self: &mut Self) -> bool; [INFO] [stdout] 14 + fn active_connection(&mut self) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `sha256::digest_bytes`: Use new function `digest()` instead [INFO] [stdout] --> src/genuineness.rs:22:50 [INFO] [stdout] | [INFO] [stdout] 22 | let hashed_certificate = decode_hex(&sha256::digest_bytes(&certificate)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `sha256::digest_bytes`: Use new function `digest()` instead [INFO] [stdout] --> src/genuineness.rs:54:40 [INFO] [stdout] | [INFO] [stdout] 54 | let hashed_card_cert_msg = sha256::digest_bytes(&decode_hex(&card_cert_msg).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `sha256::digest_bytes`: Use new function `digest()` instead [INFO] [stdout] --> src/genuineness.rs:22:50 [INFO] [stdout] | [INFO] [stdout] 22 | let hashed_certificate = decode_hex(&sha256::digest_bytes(&certificate)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `sha256::digest_bytes`: Use new function `digest()` instead [INFO] [stdout] --> src/genuineness.rs:54:40 [INFO] [stdout] | [INFO] [stdout] 54 | let hashed_card_cert_msg = sha256::digest_bytes(&decode_hex(&card_cert_msg).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `active_connection` is never used [INFO] [stdout] --> src/reader.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Reader { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 14 | fn active_connection(self: &mut Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x01].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x01].to_vec(); [INFO] [stdout] 28 + [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x01].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return String::from("15 digits and/or letters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return String::from("15 digits and/or letters"); [INFO] [stdout] 37 + String::from("15 digits and/or letters") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/card/basic/gen0.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if ! (index > 0) && (index <=7){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(index <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return Ok(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return Ok(result.unwrap()); [INFO] [stdout] 116 + Ok(result.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen0.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | let _valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `_valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 104 ~ [INFO] [stdout] 105 ~ let _valid_pin = if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 106 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 107 | }else{ [INFO] [stdout] 108 ~ pin.to_string() [INFO] [stdout] 109 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card/basic/gen0.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 105 - if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 105 + if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/card/basic/gen0.rs:149:41 [INFO] [stdout] | [INFO] [stdout] 148 | if path.is_some(){ [INFO] [stdout] | ----------------- help: try: `if let Some() = path` [INFO] [stdout] 149 | binary_path = path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return Ok(result); [INFO] [stdout] 165 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen0.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 147 ~ [INFO] [stdout] 148 ~ let binary_path : Bytes = if path.is_some(){ [INFO] [stdout] 149 ~ path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()) [INFO] [stdout] 150 | }else{ [INFO] [stdout] 151 ~ Bytes::from("") [INFO] [stdout] 152 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/card/basic/gen0.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if comp_bool == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `comp_bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] 172 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `active_connection` is never used [INFO] [stdout] --> src/reader.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Reader { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 14 | fn active_connection(self: &mut Self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 293 - return Ok(res); [INFO] [stdout] 293 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | return Err(Error::DataException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return Err(Error::DataException); [INFO] [stdout] 295 + Err(Error::DataException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/card/basic/gen0.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 287 | if valid_pin != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!valid_pin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x01].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x01].to_vec(); [INFO] [stdout] 28 + [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x01].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] 334 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return String::from("15 digits and/or letters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return String::from("15 digits and/or letters"); [INFO] [stdout] 37 + String::from("15 digits and/or letters") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] 337 + self.basic_state.valid_pin(pin, Some("".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/card/basic/gen0.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if ! (index > 0) && (index <=7){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(index <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 348 - return Ok(puk); [INFO] [stdout] 348 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return Ok(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return Ok(result.unwrap()); [INFO] [stdout] 116 + Ok(result.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen0.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | let _valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `_valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 104 ~ [INFO] [stdout] 105 ~ let _valid_pin = if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 106 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 107 | }else{ [INFO] [stdout] 108 ~ pin.to_string() [INFO] [stdout] 109 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card/basic/gen0.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 105 - if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 105 + if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/card/basic/gen0.rs:149:41 [INFO] [stdout] | [INFO] [stdout] 148 | if path.is_some(){ [INFO] [stdout] | ----------------- help: try: `if let Some() = path` [INFO] [stdout] 149 | binary_path = path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return Ok(result); [INFO] [stdout] 165 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] 29 + [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return String::from("12 digits and/or letters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return String::from("12 digits and/or letters"); [INFO] [stdout] 38 + String::from("12 digits and/or letters") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen0.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 147 ~ [INFO] [stdout] 148 ~ let binary_path : Bytes = if path.is_some(){ [INFO] [stdout] 149 ~ path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()) [INFO] [stdout] 150 | }else{ [INFO] [stdout] 151 ~ Bytes::from("") [INFO] [stdout] 152 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/card/basic/gen1.rs:86:28 [INFO] [stdout] | [INFO] [stdout] 86 | let pathbuf = path.unwrap_or(PathBuf::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/card/basic/gen0.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if comp_bool == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `comp_bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] 172 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 91 ~ [INFO] [stdout] 92 ~ let binary_path : Bytes = if pathbuf.clone().into_os_string().into_string().unwrap() != ""{ [INFO] [stdout] 93 ~ path_to_bytes(pathbuf.into_os_string().into_string().unwrap()) [INFO] [stdout] 94 | }else{ [INFO] [stdout] 95 ~ Bytes::from("".to_string()) [INFO] [stdout] 96 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return Ok(result); [INFO] [stdout] 115 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 104 ~ [INFO] [stdout] 105 ~ let valid_pin = if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] 106 ~ self.valid_pin(pin.to_string(),Some("puk".to_string())).unwrap() [INFO] [stdout] 107 | }else{ [INFO] [stdout] 108 ~ pin.clone().to_string() [INFO] [stdout] 109 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 118 ~ [INFO] [stdout] 119 ~ let valid_pin = if self.borrow_auth_type() == &AuthType::PIN{ [INFO] [stdout] 120 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 121 | }else{ [INFO] [stdout] 122 ~ pin.clone().to_string() [INFO] [stdout] 123 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 293 - return Ok(res); [INFO] [stdout] 293 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | return Err(Error::DataException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return Err(Error::DataException); [INFO] [stdout] 295 + Err(Error::DataException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] 132 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return self.basic_state.connection.send_encrypted(&[0x80, 0xD3, size, 0x00], Bytes::from(""), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return self.basic_state.connection.send_encrypted(&[0x80, 0xD3, size, 0x00], Bytes::from(""), false); [INFO] [stdout] 135 + self.basic_state.connection.send_encrypted(&[0x80, 0xD3, size, 0x00], Bytes::from(""), false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Ok(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Ok(result.unwrap()); [INFO] [stdout] 159 + Ok(result.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/card/basic/gen0.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 287 | if valid_pin != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!valid_pin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 138 ~ [INFO] [stdout] 139 ~ let valid_pin = if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 140 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 141 | }else{ [INFO] [stdout] 142 ~ pin.to_string() [INFO] [stdout] 143 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card/basic/gen1.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 139 - if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 139 + if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 334 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] 334 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] 337 + self.basic_state.valid_pin(pin, Some("".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/card/basic/gen1.rs:193:41 [INFO] [stdout] | [INFO] [stdout] 192 | if path.is_some(){ [INFO] [stdout] | ----------------- help: try: `if let Some() = path` [INFO] [stdout] 193 | binary_path = path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return Ok(result); [INFO] [stdout] 209 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen0.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 348 - return Ok(puk); [INFO] [stdout] 348 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ let binary_path : Bytes = if path.is_some(){ [INFO] [stdout] 193 ~ path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()) [INFO] [stdout] 194 | }else{ [INFO] [stdout] 195 ~ Bytes::from("") [INFO] [stdout] 196 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/card/basic/gen1.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 205 | if comp_bool == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `comp_bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] 222 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] 29 + [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] 253 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return String::from("12 digits and/or letters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return String::from("12 digits and/or letters"); [INFO] [stdout] 38 + String::from("12 digits and/or letters") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] 256 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/card/basic/gen1.rs:86:28 [INFO] [stdout] | [INFO] [stdout] 86 | let pathbuf = path.unwrap_or(PathBuf::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against true can be replaced by a negation [INFO] [stdout] --> src/card/basic/gen1.rs:287:46 [INFO] [stdout] | [INFO] [stdout] 287 | let status_bytes = Bytes::from(vec![(status != true) as u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 91 ~ [INFO] [stdout] 92 ~ let binary_path : Bytes = if pathbuf.clone().into_os_string().into_string().unwrap() != ""{ [INFO] [stdout] 93 ~ path_to_bytes(pathbuf.into_os_string().into_string().unwrap()) [INFO] [stdout] 94 | }else{ [INFO] [stdout] 95 ~ Bytes::from("".to_string()) [INFO] [stdout] 96 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return Ok(result); [INFO] [stdout] 115 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 104 ~ [INFO] [stdout] 105 ~ let valid_pin = if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] 106 ~ self.valid_pin(pin.to_string(),Some("puk".to_string())).unwrap() [INFO] [stdout] 107 | }else{ [INFO] [stdout] 108 ~ pin.clone().to_string() [INFO] [stdout] 109 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 118 ~ [INFO] [stdout] 119 ~ let valid_pin = if self.borrow_auth_type() == &AuthType::PIN{ [INFO] [stdout] 120 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 121 | }else{ [INFO] [stdout] 122 ~ pin.clone().to_string() [INFO] [stdout] 123 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] 132 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return self.basic_state.connection.send_encrypted(&[0x80, 0xD3, size, 0x00], Bytes::from(""), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return self.basic_state.connection.send_encrypted(&[0x80, 0xD3, size, 0x00], Bytes::from(""), false); [INFO] [stdout] 135 + self.basic_state.connection.send_encrypted(&[0x80, 0xD3, size, 0x00], Bytes::from(""), false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 - return Ok(res); [INFO] [stdout] 391 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:393:13 [INFO] [stdout] | [INFO] [stdout] 393 | return Err(Error::DataException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 393 - return Err(Error::DataException); [INFO] [stdout] 393 + Err(Error::DataException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Ok(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Ok(result.unwrap()); [INFO] [stdout] 159 + Ok(result.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 138 ~ [INFO] [stdout] 139 ~ let valid_pin = if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 140 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 141 | }else{ [INFO] [stdout] 142 ~ pin.to_string() [INFO] [stdout] 143 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card/basic/gen1.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 139 - if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 139 + if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/card/basic/gen1.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 385 | if valid_pin != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!valid_pin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/card/basic/gen1.rs:193:41 [INFO] [stdout] | [INFO] [stdout] 192 | if path.is_some(){ [INFO] [stdout] | ----------------- help: try: `if let Some() = path` [INFO] [stdout] 193 | binary_path = path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return Ok(result); [INFO] [stdout] 209 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/card/basic/gen1.rs:399:67 [INFO] [stdout] | [INFO] [stdout] 399 | let position = 1 + (result[1] as usize) + (result[(result[1 as usize] +2) as usize] as usize) + 2; [INFO] [stdout] | ^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ let binary_path : Bytes = if path.is_some(){ [INFO] [stdout] 193 ~ path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()) [INFO] [stdout] 194 | }else{ [INFO] [stdout] 195 ~ Bytes::from("") [INFO] [stdout] 196 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/card/basic/gen1.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 205 | if comp_bool == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `comp_bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:432:9 [INFO] [stdout] | [INFO] [stdout] 432 | let slot ; [INFO] [stdout] | ^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 441 | slot = slot_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `slot` here [INFO] [stdout] | [INFO] [stdout] 432 ~ [INFO] [stdout] 433 | [INFO] [stdout] ... [INFO] [stdout] 440 | [INFO] [stdout] 441 ~ let slot = slot_index; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] 222 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] 253 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] 256 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 514 | return (self.basic_state.data.clone().unwrap()[3] & slot) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 514 - return (self.basic_state.data.clone().unwrap()[3] & slot) != 0; [INFO] [stdout] 514 + (self.basic_state.data.clone().unwrap()[3] & slot) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against true can be replaced by a negation [INFO] [stdout] --> src/card/basic/gen1.rs:287:46 [INFO] [stdout] | [INFO] [stdout] 287 | let status_bytes = Bytes::from(vec![(status != true) as u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/card/basic/gen1.rs:526:17 [INFO] [stdout] | [INFO] [stdout] 526 | let _ = match slot.try_into(){ [INFO] [stdout] | _________________^ [INFO] [stdout] 527 | | Ok(SlotIndex::EC256R1) => Ok(SlotIndex::EC256R1), [INFO] [stdout] 528 | | Ok(SlotIndex::RSA) => Ok(SlotIndex::RSA), [INFO] [stdout] 529 | | Ok(SlotIndex::FIDO) => Ok(SlotIndex::FIDO), [INFO] [stdout] 530 | | Err(error) => Err(error), [INFO] [stdout] 531 | | }; [INFO] [stdout] | |_________^ help: replace it with: `slot.try_into()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/card/basic/gen1.rs:538:30 [INFO] [stdout] | [INFO] [stdout] 538 | let result = (bytes[0] as u8) == 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `bytes[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:553:17 [INFO] [stdout] | [INFO] [stdout] 553 | return (bytes[0] as u8) == 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 553 - return (bytes[0] as u8) == 0x01; [INFO] [stdout] 553 + (bytes[0] as u8) == 0x01 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/card/basic/gen1.rs:553:24 [INFO] [stdout] | [INFO] [stdout] 553 | return (bytes[0] as u8) == 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `bytes[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 - return Ok(res); [INFO] [stdout] 391 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:393:13 [INFO] [stdout] | [INFO] [stdout] 393 | return Err(Error::DataException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 393 - return Err(Error::DataException); [INFO] [stdout] 393 + Err(Error::DataException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 559 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] 559 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:562:9 [INFO] [stdout] | [INFO] [stdout] 562 | return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 562 - return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] 562 + self.basic_state.valid_pin(pin, Some("".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 573 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 573 - return Ok(puk); [INFO] [stdout] 573 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/card/basic/gen1.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 385 | if valid_pin != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!valid_pin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/card/basic/gen1.rs:399:67 [INFO] [stdout] | [INFO] [stdout] 399 | let position = 1 + (result[1] as usize) + (result[(result[1 as usize] +2) as usize] as usize) + 2; [INFO] [stdout] | ^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/gen1.rs:432:9 [INFO] [stdout] | [INFO] [stdout] 432 | let slot ; [INFO] [stdout] | ^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 441 | slot = slot_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `slot` here [INFO] [stdout] | [INFO] [stdout] 432 ~ [INFO] [stdout] 433 | [INFO] [stdout] ... [INFO] [stdout] 440 | [INFO] [stdout] 441 ~ let slot = slot_index; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] 36 + [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return String::from("12 digits and/or letters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return String::from("12 digits and/or letters"); [INFO] [stdout] 45 + String::from("12 digits and/or letters") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 514 | return (self.basic_state.data.clone().unwrap()[3] & slot) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 514 - return (self.basic_state.data.clone().unwrap()[3] & slot) != 0; [INFO] [stdout] 514 + (self.basic_state.data.clone().unwrap()[3] & slot) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] 151 + Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/card/basic/gen1.rs:526:17 [INFO] [stdout] | [INFO] [stdout] 526 | let _ = match slot.try_into(){ [INFO] [stdout] | _________________^ [INFO] [stdout] 527 | | Ok(SlotIndex::EC256R1) => Ok(SlotIndex::EC256R1), [INFO] [stdout] 528 | | Ok(SlotIndex::RSA) => Ok(SlotIndex::RSA), [INFO] [stdout] 529 | | Ok(SlotIndex::FIDO) => Ok(SlotIndex::FIDO), [INFO] [stdout] 530 | | Err(error) => Err(error), [INFO] [stdout] 531 | | }; [INFO] [stdout] | |_________^ help: replace it with: `slot.try_into()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/card/basic/nft.rs:107:24 [INFO] [stdout] | [INFO] [stdout] 107 | .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 107 - .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] 107 + .chain(session_public_key_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/card/basic/nft.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / let mut data = Vec::new(); [INFO] [stdout] 105 | | data.push(session_public_key_bytes.len() as u8); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let data = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/card/basic/gen1.rs:538:30 [INFO] [stdout] | [INFO] [stdout] 538 | let result = (bytes[0] as u8) == 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `bytes[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:553:17 [INFO] [stdout] | [INFO] [stdout] 553 | return (bytes[0] as u8) == 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 553 - return (bytes[0] as u8) == 0x01; [INFO] [stdout] 553 + (bytes[0] as u8) == 0x01 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic/nft.rs:131:37 [INFO] [stdout] | [INFO] [stdout] 131 | let valid_pin_slice:&[u8] = &valid_pin.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `valid_pin.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/card/basic/gen1.rs:553:24 [INFO] [stdout] | [INFO] [stdout] 553 | return (bytes[0] as u8) == 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `bytes[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic/nft.rs:132:31 [INFO] [stdout] | [INFO] [stdout] 132 | let puk_slice:&[u8] = &puk.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `puk.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 559 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] 559 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:562:9 [INFO] [stdout] | [INFO] [stdout] 562 | return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 562 - return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] 562 + self.basic_state.valid_pin(pin, Some("".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/gen1.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 573 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 573 - return Ok(puk); [INFO] [stdout] 573 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Ok(result); [INFO] [stdout] 168 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 ~ let valid_pin = if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] 159 ~ self.valid_pin(pin.to_string(),Some("puk".to_string())).unwrap() [INFO] [stdout] 160 | }else{ [INFO] [stdout] 161 ~ pin.clone().to_string() [INFO] [stdout] 162 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 171 ~ [INFO] [stdout] 172 ~ let valid_pin = if self.borrow_auth_type() == &AuthType::PIN{ [INFO] [stdout] 173 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 174 | }else{ [INFO] [stdout] 175 ~ pin.clone().to_string() [INFO] [stdout] 176 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] 185 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | return Ok(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Ok(result.unwrap()); [INFO] [stdout] 212 + Ok(result.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ let valid_pin = if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 193 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 194 | }else{ [INFO] [stdout] 195 ~ pin.to_string() [INFO] [stdout] 196 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec(); [INFO] [stdout] 36 + [0xA0, 0x00, 0x00, 0x10, 0x00, 0x01, 0x12].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card/basic/nft.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 192 - if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 192 + if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/card/basic/nft.rs:246:41 [INFO] [stdout] | [INFO] [stdout] 245 | if path.is_some(){ [INFO] [stdout] | ----------------- help: try: `if let Some() = path` [INFO] [stdout] 246 | binary_path = path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return String::from("12 digits and/or letters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return String::from("12 digits and/or letters"); [INFO] [stdout] 45 + String::from("12 digits and/or letters") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return Ok(result); [INFO] [stdout] 262 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] 151 + Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 244 ~ [INFO] [stdout] 245 ~ let binary_path : Bytes = if path.is_some(){ [INFO] [stdout] 246 ~ path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()) [INFO] [stdout] 247 | }else{ [INFO] [stdout] 248 ~ Bytes::from("") [INFO] [stdout] 249 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/card/basic/nft.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 258 | if comp_bool == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `comp_bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/card/basic/nft.rs:107:24 [INFO] [stdout] | [INFO] [stdout] 107 | .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 107 - .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] 107 + .chain(session_public_key_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/card/basic/nft.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / let mut data = Vec::new(); [INFO] [stdout] 105 | | data.push(session_public_key_bytes.len() as u8); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let data = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] 275 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] 281 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] 284 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic/nft.rs:131:37 [INFO] [stdout] | [INFO] [stdout] 131 | let valid_pin_slice:&[u8] = &valid_pin.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `valid_pin.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic/nft.rs:132:31 [INFO] [stdout] | [INFO] [stdout] 132 | let puk_slice:&[u8] = &puk.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `puk.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Ok(result); [INFO] [stdout] 168 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 ~ let valid_pin = if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] 159 ~ self.valid_pin(pin.to_string(),Some("puk".to_string())).unwrap() [INFO] [stdout] 160 | }else{ [INFO] [stdout] 161 ~ pin.clone().to_string() [INFO] [stdout] 162 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 394 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return Ok(res); [INFO] [stdout] 394 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:396:13 [INFO] [stdout] | [INFO] [stdout] 396 | return Err(Error::DataException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 396 - return Err(Error::DataException); [INFO] [stdout] 396 + Err(Error::DataException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/card/basic/nft.rs:388:12 [INFO] [stdout] | [INFO] [stdout] 388 | if valid_pin != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!valid_pin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/card/basic/nft.rs:402:67 [INFO] [stdout] | [INFO] [stdout] 402 | let position = 1 + (result[1] as usize) + (result[(result[1 as usize] +2) as usize] as usize) + 2; [INFO] [stdout] | ^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 171 ~ [INFO] [stdout] 172 ~ let valid_pin = if self.borrow_auth_type() == &AuthType::PIN{ [INFO] [stdout] 173 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 174 | }else{ [INFO] [stdout] 175 ~ pin.clone().to_string() [INFO] [stdout] 176 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0; [INFO] [stdout] 185 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00000100", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | return Ok(result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Ok(result.unwrap()); [INFO] [stdout] 212 + Ok(result.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | let valid_pin; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `valid_pin` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ let valid_pin = if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 193 ~ self.valid_pin(pin.to_string(),Some("pin".to_string())).unwrap() [INFO] [stdout] 194 | }else{ [INFO] [stdout] 195 ~ pin.to_string() [INFO] [stdout] 196 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/card/basic/nft.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 192 - if &self.basic_state.auth_type == &AuthType::PIN{ [INFO] [stdout] 192 + if self.basic_state.auth_type == AuthType::PIN{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/card/basic/nft.rs:246:41 [INFO] [stdout] | [INFO] [stdout] 245 | if path.is_some(){ [INFO] [stdout] | ----------------- help: try: `if let Some() = path` [INFO] [stdout] 246 | binary_path = path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return Ok(result); [INFO] [stdout] 262 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] 439 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/card/basic/nft.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | let binary_path : Bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `binary_path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 244 ~ [INFO] [stdout] 245 ~ let binary_path : Bytes = if path.is_some(){ [INFO] [stdout] 246 ~ path_to_bytes(path.unwrap().into_os_string().into_string().unwrap()) [INFO] [stdout] 247 | }else{ [INFO] [stdout] 248 ~ Bytes::from("") [INFO] [stdout] 249 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 442 - return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] 442 + self.basic_state.valid_pin(pin, Some("".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/card/basic/nft.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 258 | if comp_bool == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `comp_bool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return Ok(puk); [INFO] [stdout] 453 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0; [INFO] [stdout] 275 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("01000000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0; [INFO] [stdout] 281 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00010000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0; [INFO] [stdout] 284 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00001000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 394 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return Ok(res); [INFO] [stdout] 394 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:396:13 [INFO] [stdout] | [INFO] [stdout] 396 | return Err(Error::DataException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 396 - return Err(Error::DataException); [INFO] [stdout] 396 + Err(Error::DataException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/card/basic/nft.rs:388:12 [INFO] [stdout] | [INFO] [stdout] 388 | if valid_pin != ""{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!valid_pin.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] 159 + Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/card/basic/nft.rs:402:67 [INFO] [stdout] | [INFO] [stdout] 402 | let position = 1 + (result[1] as usize) + (result[(result[1 as usize] +2) as usize] as usize) + 2; [INFO] [stdout] | ^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/card/basic.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 120 | .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 120 - .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] 120 + .chain(session_public_key_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/card/basic.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | / let mut data = Vec::new(); [INFO] [stdout] 118 | | data.push(session_public_key_bytes.len() as u8); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let data = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0; [INFO] [stdout] 439 + (self.basic_state.data.clone().unwrap()[1] & isize::from_str_radix("00100000", 2).unwrap() as u8) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 442 - return self.basic_state.valid_pin(pin, Some("".to_string())); [INFO] [stdout] 442 + self.basic_state.valid_pin(pin, Some("".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic/nft.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return Ok(puk); [INFO] [stdout] 453 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic.rs:144:37 [INFO] [stdout] | [INFO] [stdout] 144 | let valid_pin_slice:&[u8] = &valid_pin.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `valid_pin.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | let puk_slice:&[u8] = &puk.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `puk.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | return (self.data.as_ref().unwrap()[1] & u8::from_str_radix("01000000", 2).unwrap()) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 188 - return (self.data.as_ref().unwrap()[1] & u8::from_str_radix("01000000", 2).unwrap()) != 0; [INFO] [stdout] 188 + (self.data.as_ref().unwrap()[1] & u8::from_str_radix("01000000", 2).unwrap()) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()); [INFO] [stdout] 159 + Ok([Bytes::from([0].to_vec()),valid_pairing_secrect].concat()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | return Ok(padded_pin) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return Ok(padded_pin) [INFO] [stdout] 280 + Ok(padded_pin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ok(puk); [INFO] [stdout] 291 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/card/basic.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 120 | .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 120 - .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] 120 + .chain(session_public_key_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/card/basic.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | / let mut data = Vec::new(); [INFO] [stdout] 118 | | data.push(session_public_key_bytes.len() as u8); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let data = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic.rs:144:37 [INFO] [stdout] | [INFO] [stdout] 144 | let valid_pin_slice:&[u8] = &valid_pin.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `valid_pin.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/card/basic.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | let puk_slice:&[u8] = &puk.as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `puk.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | return (self.data.as_ref().unwrap()[1] & u8::from_str_radix("01000000", 2).unwrap()) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 188 - return (self.data.as_ref().unwrap()[1] & u8::from_str_radix("01000000", 2).unwrap()) != 0; [INFO] [stdout] 188 + (self.data.as_ref().unwrap()[1] & u8::from_str_radix("01000000", 2).unwrap()) != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | return Ok(padded_pin) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return Ok(padded_pin) [INFO] [stdout] 280 + Ok(padded_pin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card/basic.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | return Ok(puk); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ok(puk); [INFO] [stdout] 291 + Ok(puk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/connection.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 56 - .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] 56 + .chain(session_public_key_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/connection.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / let mut data = Vec::new(); [INFO] [stdout] 54 | | data.push(session_public_key_bytes.len() as u8); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let data = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:72:35 [INFO] [stdout] | [INFO] [stdout] 72 | let iv = Bytes::from_iter(std::iter::repeat(1).take(16)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(1, 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/connection.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 87 | let ret = deriver.derive_to_vec()?; [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 88 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ deriver.derive_to_vec()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/connection.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | pairing_secret: Bytes::from(pairing_secret), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Bytes::from()`: `pairing_secret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:95:38 [INFO] [stdout] | [INFO] [stdout] 95 | mac_iv: Bytes::from_iter(std::iter::repeat(0).take(16)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/connection.rs:120:67 [INFO] [stdout] | [INFO] [stdout] 120 | self.setup_secure_channel(self.pairing_secret.clone().unwrap_or(Bytes::default()), 0)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/connection.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 56 - .chain(session_public_key_bytes.into_iter()) [INFO] [stdout] 56 + .chain(session_public_key_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/connection.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / let mut data = Vec::new(); [INFO] [stdout] 54 | | data.push(session_public_key_bytes.len() as u8); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let data = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:72:35 [INFO] [stdout] | [INFO] [stdout] 72 | let iv = Bytes::from_iter(std::iter::repeat(1).take(16)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(1, 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/connection.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 87 | let ret = deriver.derive_to_vec()?; [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 88 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ deriver.derive_to_vec()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:207:17 [INFO] [stdout] | [INFO] [stdout] 207 | std::iter::repeat(0).take(13).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 13)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:213:17 [INFO] [stdout] | [INFO] [stdout] 213 | std::iter::repeat(0).take(15).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/connection.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | pairing_secret: Bytes::from(pairing_secret), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Bytes::from()`: `pairing_secret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:95:38 [INFO] [stdout] | [INFO] [stdout] 95 | mac_iv: Bytes::from_iter(std::iter::repeat(0).take(16)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | std::iter::repeat(0).take(9).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/connection.rs:120:67 [INFO] [stdout] | [INFO] [stdout] 120 | self.setup_secure_channel(self.pairing_secret.clone().unwrap_or(Bytes::default()), 0)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | std::iter::repeat(0).take(11).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 11)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/connection.rs:302:64 [INFO] [stdout] | [INFO] [stdout] 302 | .send_apdu(Bytes::from_iter(cmdh.into_iter().chain(data_apdu.into_iter())).as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 302 - .send_apdu(Bytes::from_iter(cmdh.into_iter().chain(data_apdu.into_iter())).as_ref()) [INFO] [stdout] 302 + .send_apdu(Bytes::from_iter(cmdh.into_iter().chain(data_apdu)).as_ref()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:207:17 [INFO] [stdout] | [INFO] [stdout] 207 | std::iter::repeat(0).take(13).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 13)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:213:17 [INFO] [stdout] | [INFO] [stdout] 213 | std::iter::repeat(0).take(15).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | std::iter::repeat(0).take(9).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/connection.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | std::iter::repeat(0).take(11).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(0, 11)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/connection.rs:302:64 [INFO] [stdout] | [INFO] [stdout] 302 | .send_apdu(Bytes::from_iter(cmdh.into_iter().chain(data_apdu.into_iter())).as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 302 - .send_apdu(Bytes::from_iter(cmdh.into_iter().chain(data_apdu.into_iter())).as_ref()) [INFO] [stdout] 302 + .send_apdu(Bytes::from_iter(cmdh.into_iter().chain(data_apdu)).as_ref()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return CardOrigin::Fake; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return CardOrigin::Fake; [INFO] [stdout] 39 + CardOrigin::Fake [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/genuineness.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if valid == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `valid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(card_cert_hex[18..148].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(card_cert_hex[18..148].to_string()); [INFO] [stdout] 63 + Ok(card_cert_hex[18..148].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return Ok(ret); [INFO] [stdout] 86 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/genuineness.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | let ret; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 71 ~ [INFO] [stdout] 72 ~ let ret = if response.0.is_empty() { [INFO] [stdout] 73 ~ vec![] [INFO] [stdout] 74 | } else { [INFO] [stdout] ... [INFO] [stdout] 83 | let certificate = response[2..].into_iter().map(ToOwned::to_owned).collect(); [INFO] [stdout] 84 ~ certificate [INFO] [stdout] 85 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/genuineness.rs:83:41 [INFO] [stdout] | [INFO] [stdout] 83 | let certificate = response[2..].into_iter().map(ToOwned::to_owned).collect(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | return rt.block_on(fetch_certificates()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return rt.block_on(fetch_certificates()) [INFO] [stdout] 122 + rt.block_on(fetch_certificates()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return pub_key; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return pub_key; [INFO] [stdout] 99 + pub_key [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return results.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return results.unwrap(); [INFO] [stdout] 110 + results.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return CardOrigin::Fake; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return CardOrigin::Fake; [INFO] [stdout] 39 + CardOrigin::Fake [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/genuineness.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if valid == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `valid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(card_cert_hex[18..148].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(card_cert_hex[18..148].to_string()); [INFO] [stdout] 63 + Ok(card_cert_hex[18..148].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return true; [INFO] [stdout] 134 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/genuineness.rs:125:34 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn _check_signature(message: &Vec, public_key: EcKey, signature: Vec) -> bool{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn _check_signature(message: &Vec, public_key: EcKey, signature: Vec) -> bool{ [INFO] [stdout] 125 + pub fn _check_signature(message: &[u8], public_key: EcKey, signature: Vec) -> bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/genuineness.rs:130:8 [INFO] [stdout] | [INFO] [stdout] 130 | if result == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | ... return Ok(vec![certificate[..split_idx].to_vec(),certificate[(split_idx+&decode_hex(_PUBLIC_K1_OID).unwrap().len())..].to_vec()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return Ok(vec![certificate[..split_idx].to_vec(),certificate[(split_idx+&decode_hex(_PUBLIC_K1_OID).unwrap().len())..].to_vec()]); [INFO] [stdout] 141 + Ok(vec![certificate[..split_idx].to_vec(),certificate[(split_idx+&decode_hex(_PUBLIC_K1_OID).unwrap().len())..].to_vec()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return Err(Error::GenuineCheckException); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return Err(Error::GenuineCheckException); [INFO] [stdout] 143 + Err(Error::GenuineCheckException) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/genuineness.rs:141:70 [INFO] [stdout] | [INFO] [stdout] 141 | ...it_idx].to_vec(),certificate[(split_idx+&decode_hex(_PUBLIC_K1_OID).unwrap().len())..].to_vec()]); [INFO] [stdout] | ^^^^^^^^^^^------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `decode_hex(_PUBLIC_K1_OID).unwrap().len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return public_key_bytes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return public_key_bytes; [INFO] [stdout] 156 + public_key_bytes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return Ok(ret); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return Ok(ret); [INFO] [stdout] 86 + Ok(ret) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/genuineness.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | let ret; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 71 ~ [INFO] [stdout] 72 ~ let ret = if response.0.is_empty() { [INFO] [stdout] 73 ~ vec![] [INFO] [stdout] 74 | } else { [INFO] [stdout] ... [INFO] [stdout] 83 | let certificate = response[2..].into_iter().map(ToOwned::to_owned).collect(); [INFO] [stdout] 84 ~ certificate [INFO] [stdout] 85 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/genuineness.rs:83:41 [INFO] [stdout] | [INFO] [stdout] 83 | let certificate = response[2..].into_iter().map(ToOwned::to_owned).collect(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | return rt.block_on(fetch_certificates()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return rt.block_on(fetch_certificates()) [INFO] [stdout] 122 + rt.block_on(fetch_certificates()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return pub_key; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return pub_key; [INFO] [stdout] 99 + pub_key [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return result; [INFO] [stdout] 172 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | return card_cert_hex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return card_cert_hex; [INFO] [stdout] 193 + card_cert_hex [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return results.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return results.unwrap(); [INFO] [stdout] 110 + results.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | return decode_hex(signature.as_str()).unwrap().to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return decode_hex(signature.as_str()).unwrap().to_vec(); [INFO] [stdout] 214 + decode_hex(signature.as_str()).unwrap().to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/genuineness.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | return vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [WARN] too many lines in the log, truncating it