[INFO] fetching crate crowbook-intl 0.2.1... [INFO] linting crowbook-intl-0.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate crowbook-intl 0.2.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate crowbook-intl 0.2.1 [INFO] finished tweaking crates.io crate crowbook-intl 0.2.1 [INFO] tweaked toml for crates.io crate crowbook-intl 0.2.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate crowbook-intl 0.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding lazy_static v0.2.11 (available: v1.5.0) [INFO] [stderr] Adding regex v0.2.11 (available: v1.12.3) [INFO] [stderr] Adding walkdir v1.0.7 (available: v2.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded utf8-ranges v1.0.5 [INFO] [stderr] Downloaded thread_local v0.3.6 [INFO] [stderr] Downloaded ucd-util v0.1.10 [INFO] [stderr] Downloaded aho-corasick v0.6.10 [INFO] [stderr] Downloaded regex v0.2.11 [INFO] [stderr] Downloaded regex-syntax v0.5.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98460e84332f411e9bcb4c33586e2ab19e8f8dcec241e1b651f24e1148340e2b [INFO] running `Command { std: "docker" "start" "-a" "98460e84332f411e9bcb4c33586e2ab19e8f8dcec241e1b651f24e1148340e2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98460e84332f411e9bcb4c33586e2ab19e8f8dcec241e1b651f24e1148340e2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98460e84332f411e9bcb4c33586e2ab19e8f8dcec241e1b651f24e1148340e2b", kill_on_drop: false }` [INFO] [stdout] 98460e84332f411e9bcb4c33586e2ab19e8f8dcec241e1b651f24e1148340e2b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2bdc71a6f35ce2a26237709013273580236ecf5753a106aa2e26d8995cedb04 [INFO] running `Command { std: "docker" "start" "-a" "d2bdc71a6f35ce2a26237709013273580236ecf5753a106aa2e26d8995cedb04", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking same-file v0.1.3 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking walkdir v1.0.7 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking crowbook-intl v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lang.rs:56:35 [INFO] [stdout] | [INFO] [stdout] 56 | key.push_str(&try!(find_string(s.as_bytes()).map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lang.rs:77:41 [INFO] [stdout] | [INFO] [stdout] 77 | value.push_str(&try!(find_string(s.as_bytes()).map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/localizer.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | extractor: extractor, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extractor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | try!(f.read_to_string(&mut content) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | let mut f = try!(File::open(file) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:85:36 [INFO] [stdout] | [INFO] [stdout] 85 | let orig_msg: String = try!(find_string(bytes) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | try!(self.add_messages_from_file(&filename)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | try!(f.write_all(content.as_bytes()) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | let mut f = try!(File::create(file).map_err(|e| Error::new(format!("Could not create file {}: {}", [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/extractor.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 148 | const POT_HEADER: &'static str = r#"# SOME DESCRIPTIVE TITLE [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lang.rs:56:35 [INFO] [stdout] | [INFO] [stdout] 56 | key.push_str(&try!(find_string(s.as_bytes()).map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lang.rs:77:41 [INFO] [stdout] | [INFO] [stdout] 77 | value.push_str(&try!(find_string(s.as_bytes()).map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/localizer.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | extractor: extractor, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extractor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/common.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / lazy_static! { [INFO] [stdout] 17 | | static ref REGEX:Regex = Regex::new(r#"\\\n\s*"#).unwrap(); [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/extractor.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / lazy_static! { [INFO] [stdout] 64 | | static ref REMOVE_COMMS: Regex = Regex::new(r#"//[^\n]*"#).unwrap(); [INFO] [stdout] 65 | | static ref FIND_MSGS: Regex = Regex::new(r#"lformat!\("#).unwrap(); [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/extractor.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / lazy_static! { [INFO] [stdout] 64 | | static ref REMOVE_COMMS: Regex = Regex::new(r#"//[^\n]*"#).unwrap(); [INFO] [stdout] 65 | | static ref FIND_MSGS: Regex = Regex::new(r#"lformat!\("#).unwrap(); [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | try!(f.read_to_string(&mut content) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | let mut f = try!(File::open(file) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:85:36 [INFO] [stdout] | [INFO] [stdout] 85 | let orig_msg: String = try!(find_string(bytes) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | try!(self.add_messages_from_file(&filename)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | try!(f.write_all(content.as_bytes()) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/extractor.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | let mut f = try!(File::create(file).map_err(|e| Error::new(format!("Could not create file {}: {}", [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/extractor.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 148 | const POT_HEADER: &'static str = r#"# SOME DESCRIPTIVE TITLE [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/common.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / lazy_static! { [INFO] [stdout] 17 | | static ref REGEX:Regex = Regex::new(r#"\\\n\s*"#).unwrap(); [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/extractor.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / lazy_static! { [INFO] [stdout] 64 | | static ref REMOVE_COMMS: Regex = Regex::new(r#"//[^\n]*"#).unwrap(); [INFO] [stdout] 65 | | static ref FIND_MSGS: Regex = Regex::new(r#"lformat!\("#).unwrap(); [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/extractor.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / lazy_static! { [INFO] [stdout] 64 | | static ref REMOVE_COMMS: Regex = Regex::new(r#"//[^\n]*"#).unwrap(); [INFO] [stdout] 65 | | static ref FIND_MSGS: Regex = Regex::new(r#"lformat!\("#).unwrap(); [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/common.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / match bytes[i] { [INFO] [stdout] 37 | | b'"' => if begin.is_some() { [INFO] [stdout] 38 | | if bytes[i-1] != b'\\' { [INFO] [stdout] 39 | | break [INFO] [stdout] ... | [INFO] [stdout] 47 | | _ => (), [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ if bytes[i] == b'"' { if begin.is_some() { [INFO] [stdout] 37 + if bytes[i-1] != b'\\' { [INFO] [stdout] 38 + break [INFO] [stdout] 39 + } [INFO] [stdout] 40 + } else { [INFO] [stdout] 41 + if i + 1 >= bytes.len() { [INFO] [stdout] 42 + return Err(Error::new("")); [INFO] [stdout] 43 + } [INFO] [stdout] 44 + begin = Some(i + 1); [INFO] [stdout] 45 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/common.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / match bytes[i] { [INFO] [stdout] 37 | | b'"' => if begin.is_some() { [INFO] [stdout] 38 | | if bytes[i-1] != b'\\' { [INFO] [stdout] 39 | | break [INFO] [stdout] ... | [INFO] [stdout] 47 | | _ => (), [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ if bytes[i] == b'"' { if begin.is_some() { [INFO] [stdout] 37 + if bytes[i-1] != b'\\' { [INFO] [stdout] 38 + break [INFO] [stdout] 39 + } [INFO] [stdout] 40 + } else { [INFO] [stdout] 41 + if i + 1 >= bytes.len() { [INFO] [stdout] 42 + return Err(Error::new("")); [INFO] [stdout] 43 + } [INFO] [stdout] 44 + begin = Some(i + 1); [INFO] [stdout] 45 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/macrogen.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let ref mut hash = curr[i].content; [INFO] [stdout] | ----^^^^^^^^^^^^------------------- help: try: `let hash = &mut curr[i].content;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/macrogen.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | let ref mut hash = other_lang.content; [INFO] [stdout] | ----^^^^^^^^^^^^---------------------- help: try: `let hash = &mut other_lang.content;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/macrogen.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let ref mut hash = curr[i].content; [INFO] [stdout] | ----^^^^^^^^^^^^------------------- help: try: `let hash = &mut curr[i].content;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/macrogen.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | let ref mut hash = other_lang.content; [INFO] [stdout] | ----^^^^^^^^^^^^---------------------- help: try: `let hash = &mut other_lang.content;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macrogen.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | return !(c == next_c); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(c != next_c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macrogen.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | return !(c == next_c); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(c != next_c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/macrogen.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | assert_eq!(has_arguments("foo bar"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 125 - assert_eq!(has_arguments("foo bar"), false); [INFO] [stdout] 125 + assert!(!has_arguments("foo bar")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/macrogen.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | assert_eq!(has_arguments("foo {}"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 126 - assert_eq!(has_arguments("foo {}"), true); [INFO] [stdout] 126 + assert!(has_arguments("foo {}")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/macrogen.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | assert_eq!(has_arguments("foo {{bar}}"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 127 - assert_eq!(has_arguments("foo {{bar}}"), false); [INFO] [stdout] 127 + assert!(!has_arguments("foo {{bar}}")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lang.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lang.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | ... i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lang.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/localizer.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | /// similarly to gettext `mo` files. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 55 | /// similarly to gettext `mo` files. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lang.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | ... i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Extractor` [INFO] [stdout] --> src/extractor.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / pub fn new() -> Extractor { [INFO] [stdout] 48 | | Extractor { [INFO] [stdout] 49 | | messages: HashMap::new(), [INFO] [stdout] 50 | | orig_strings: HashMap::new(), [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 45 + impl Default for Extractor { [INFO] [stdout] 46 + fn default() -> Self { [INFO] [stdout] 47 + Self::new() [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/extractor.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn original_strings<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 57 - pub fn original_strings<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] 57 + pub fn original_strings(&self) -> &HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/localizer.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | /// similarly to gettext `mo` files. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 55 | /// similarly to gettext `mo` files. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `as_bytes` after slicing a string [INFO] [stdout] --> src/extractor.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | let bytes = content[pos..].as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&content.as_bytes()[pos..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#sliced_string_as_bytes [INFO] [stdout] = note: `#[warn(clippy::sliced_string_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Extractor` [INFO] [stdout] --> src/extractor.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / pub fn new() -> Extractor { [INFO] [stdout] 48 | | Extractor { [INFO] [stdout] 49 | | messages: HashMap::new(), [INFO] [stdout] 50 | | orig_strings: HashMap::new(), [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 45 + impl Default for Extractor { [INFO] [stdout] 46 + fn default() -> Self { [INFO] [stdout] 47 + Self::new() [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/extractor.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn original_strings<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 57 - pub fn original_strings<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] 57 + pub fn original_strings(&self) -> &HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `as_bytes` after slicing a string [INFO] [stdout] --> src/extractor.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | let bytes = content[pos..].as_bytes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&content.as_bytes()[pos..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#sliced_string_as_bytes [INFO] [stdout] = note: `#[warn(clippy::sliced_string_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.46s [INFO] running `Command { std: "docker" "inspect" "d2bdc71a6f35ce2a26237709013273580236ecf5753a106aa2e26d8995cedb04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2bdc71a6f35ce2a26237709013273580236ecf5753a106aa2e26d8995cedb04", kill_on_drop: false }` [INFO] [stdout] d2bdc71a6f35ce2a26237709013273580236ecf5753a106aa2e26d8995cedb04