[INFO] fetching crate copy_cli 0.1.0... [INFO] linting copy_cli-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate copy_cli 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate copy_cli 0.1.0 [INFO] finished tweaking crates.io crate copy_cli 0.1.0 [INFO] tweaked toml for crates.io crate copy_cli 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate copy_cli 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate copy_cli 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff503005c1a596a395a11a61bb367b0e0beeb76779fa943a1925d7e9c4c73cf5 [INFO] running `Command { std: "docker" "start" "-a" "ff503005c1a596a395a11a61bb367b0e0beeb76779fa943a1925d7e9c4c73cf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff503005c1a596a395a11a61bb367b0e0beeb76779fa943a1925d7e9c4c73cf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff503005c1a596a395a11a61bb367b0e0beeb76779fa943a1925d7e9c4c73cf5", kill_on_drop: false }` [INFO] [stdout] ff503005c1a596a395a11a61bb367b0e0beeb76779fa943a1925d7e9c4c73cf5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fcb341dcfe97dcbc4b69eb2b8d834754ccff6ba544a5d1c085a8fade7270006c [INFO] running `Command { std: "docker" "start" "-a" "fcb341dcfe97dcbc4b69eb2b8d834754ccff6ba544a5d1c085a8fade7270006c", kill_on_drop: false }` [INFO] [stderr] Checking copy_cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !fs::metadata(source_file).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(source_file).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | let source_ext = source_file.split('.').last().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 - let source_ext = source_file.split('.').last().unwrap_or_default(); [INFO] [stdout] 37 + let source_ext = source_file.split('.').next_back().unwrap_or_default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | let dest_ext = destination_file.split('.').last().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - let dest_ext = destination_file.split('.').last().unwrap_or_default(); [INFO] [stdout] 38 + let dest_ext = destination_file.split('.').next_back().unwrap_or_default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !fs::metadata(source_file).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(source_file).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | let source_ext = source_file.split('.').last().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 - let source_ext = source_file.split('.').last().unwrap_or_default(); [INFO] [stdout] 37 + let source_ext = source_file.split('.').next_back().unwrap_or_default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | let dest_ext = destination_file.split('.').last().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - let dest_ext = destination_file.split('.').last().unwrap_or_default(); [INFO] [stdout] 38 + let dest_ext = destination_file.split('.').next_back().unwrap_or_default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s [INFO] running `Command { std: "docker" "inspect" "fcb341dcfe97dcbc4b69eb2b8d834754ccff6ba544a5d1c085a8fade7270006c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcb341dcfe97dcbc4b69eb2b8d834754ccff6ba544a5d1c085a8fade7270006c", kill_on_drop: false }` [INFO] [stdout] fcb341dcfe97dcbc4b69eb2b8d834754ccff6ba544a5d1c085a8fade7270006c