[INFO] fetching crate congregation 0.2.9... [INFO] linting congregation-0.2.9 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate congregation 0.2.9 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate congregation 0.2.9 [INFO] finished tweaking crates.io crate congregation 0.2.9 [INFO] tweaked toml for crates.io crate congregation 0.2.9 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate congregation 0.2.9 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate congregation 0.2.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77efb475c56f2592d4d3d04190feda473e03dea58790d963c23cf53b326252a6 [INFO] running `Command { std: "docker" "start" "-a" "77efb475c56f2592d4d3d04190feda473e03dea58790d963c23cf53b326252a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77efb475c56f2592d4d3d04190feda473e03dea58790d963c23cf53b326252a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77efb475c56f2592d4d3d04190feda473e03dea58790d963c23cf53b326252a6", kill_on_drop: false }` [INFO] [stdout] 77efb475c56f2592d4d3d04190feda473e03dea58790d963c23cf53b326252a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e952211edb24c4dca2bd0166f40e771ee2f221c8546b513ec3ea3f68c20d6d3 [INFO] running `Command { std: "docker" "start" "-a" "0e952211edb24c4dca2bd0166f40e771ee2f221c8546b513ec3ea3f68c20d6d3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking vte v0.14.1 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking strip-ansi-escapes v0.2.1 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking ctrlc v3.4.7 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking congregation v0.2.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/task.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct Task { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 27 | pub id: usize, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Task` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/arg_parser.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !args.next().is_some_and(|arg| arg == "run") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.next().is_none_or(|arg| arg != "run")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|arg| arg.as_str())` on an `Option` value [INFO] [stdout] --> src/arg_parser.rs:31:15 [INFO] [stdout] | [INFO] [stdout] 31 | match args.next().as_ref().map(|arg| arg.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `args.next().as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/arg_parser.rs:118:18 [INFO] [stdout] | [INFO] [stdout] 118 | .map(|path| PathBuf::from(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/diagnostics.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/renderer.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / match event { [INFO] [stdout] 84 | | Event::Key(event) => match event.code { [INFO] [stdout] 85 | | KeyCode::Char('c') if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 86 | | return false [INFO] [stdout] ... | [INFO] [stdout] 111 | | _ => {} [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 83 ~ if let Event::Key(event) = event { match event.code { [INFO] [stdout] 84 + KeyCode::Char('c') if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 85 + return false [INFO] [stdout] 86 + } [INFO] [stdout] 87 + KeyCode::Char('q') => return false, [INFO] [stdout] 88 + KeyCode::Char('d') | KeyCode::PageDown => self.scroll_down(self.viewport_height), [INFO] [stdout] 89 + KeyCode::Char('u') | KeyCode::PageUp => self.scroll_up(self.viewport_height), [INFO] [stdout] 90 + KeyCode::Down if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 91 + self.scroll_down(self.viewport_height) [INFO] [stdout] 92 + } [INFO] [stdout] 93 + KeyCode::Up if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 94 + self.scroll_up(self.viewport_height) [INFO] [stdout] 95 + } [INFO] [stdout] 96 + KeyCode::Down | KeyCode::Char('j') => self.scroll_down(1), [INFO] [stdout] 97 + KeyCode::Up | KeyCode::Char('k') => self.scroll_up(1), [INFO] [stdout] 98 + KeyCode::Left if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 99 + self.scroll_x = 0 [INFO] [stdout] 100 + } [INFO] [stdout] 101 + KeyCode::Home | KeyCode::Char('0') => self.scroll_x = 0, [INFO] [stdout] 102 + KeyCode::Right if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 103 + self.scroll_to_end() [INFO] [stdout] 104 + } [INFO] [stdout] 105 + KeyCode::End | KeyCode::Char('$') => self.scroll_to_end(), [INFO] [stdout] 106 + KeyCode::Left | KeyCode::Char('h') => self.scroll_left(1), [INFO] [stdout] 107 + KeyCode::Right | KeyCode::Char('l') => self.scroll_right(1), [INFO] [stdout] 108 + _ => {} [INFO] [stdout] 109 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/task.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct Task { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 27 | pub id: usize, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Task` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/arg_parser.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !args.next().is_some_and(|arg| arg == "run") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.next().is_none_or(|arg| arg != "run")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|arg| arg.as_str())` on an `Option` value [INFO] [stdout] --> src/arg_parser.rs:31:15 [INFO] [stdout] | [INFO] [stdout] 31 | match args.next().as_ref().map(|arg| arg.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `args.next().as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/arg_parser.rs:118:18 [INFO] [stdout] | [INFO] [stdout] 118 | .map(|path| PathBuf::from(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/diagnostics.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/renderer.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / match event { [INFO] [stdout] 84 | | Event::Key(event) => match event.code { [INFO] [stdout] 85 | | KeyCode::Char('c') if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 86 | | return false [INFO] [stdout] ... | [INFO] [stdout] 111 | | _ => {} [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 83 ~ if let Event::Key(event) = event { match event.code { [INFO] [stdout] 84 + KeyCode::Char('c') if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 85 + return false [INFO] [stdout] 86 + } [INFO] [stdout] 87 + KeyCode::Char('q') => return false, [INFO] [stdout] 88 + KeyCode::Char('d') | KeyCode::PageDown => self.scroll_down(self.viewport_height), [INFO] [stdout] 89 + KeyCode::Char('u') | KeyCode::PageUp => self.scroll_up(self.viewport_height), [INFO] [stdout] 90 + KeyCode::Down if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 91 + self.scroll_down(self.viewport_height) [INFO] [stdout] 92 + } [INFO] [stdout] 93 + KeyCode::Up if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 94 + self.scroll_up(self.viewport_height) [INFO] [stdout] 95 + } [INFO] [stdout] 96 + KeyCode::Down | KeyCode::Char('j') => self.scroll_down(1), [INFO] [stdout] 97 + KeyCode::Up | KeyCode::Char('k') => self.scroll_up(1), [INFO] [stdout] 98 + KeyCode::Left if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 99 + self.scroll_x = 0 [INFO] [stdout] 100 + } [INFO] [stdout] 101 + KeyCode::Home | KeyCode::Char('0') => self.scroll_x = 0, [INFO] [stdout] 102 + KeyCode::Right if event.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 103 + self.scroll_to_end() [INFO] [stdout] 104 + } [INFO] [stdout] 105 + KeyCode::End | KeyCode::Char('$') => self.scroll_to_end(), [INFO] [stdout] 106 + KeyCode::Left | KeyCode::Char('h') => self.scroll_left(1), [INFO] [stdout] 107 + KeyCode::Right | KeyCode::Char('l') => self.scroll_right(1), [INFO] [stdout] 108 + _ => {} [INFO] [stdout] 109 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.76s [INFO] running `Command { std: "docker" "inspect" "0e952211edb24c4dca2bd0166f40e771ee2f221c8546b513ec3ea3f68c20d6d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e952211edb24c4dca2bd0166f40e771ee2f221c8546b513ec3ea3f68c20d6d3", kill_on_drop: false }` [INFO] [stdout] 0e952211edb24c4dca2bd0166f40e771ee2f221c8546b513ec3ea3f68c20d6d3