[INFO] fetching crate confitul 0.1.4...
[INFO] linting confitul-0.1.4 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate confitul 0.1.4 into /workspace/builds/worker-7-tc1/source
[INFO] started tweaking crates.io crate confitul 0.1.4
[INFO] finished tweaking crates.io crate confitul 0.1.4
[INFO] tweaked toml for crates.io crate confitul 0.1.4 written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate confitul 0.1.4 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 87 packages to latest compatible versions
[INFO] [stderr]       Adding bincode v1.3.3 (available: v3.0.0)
[INFO] [stderr]       Adding ckey v0.1.1 (available: v0.4.3)
[INFO] [stderr]       Adding ed25519 v1.5.3 (available: v2.2.3)
[INFO] [stderr]       Adding ed25519-dalek v1.0.1 (available: v2.2.0)
[INFO] [stderr]       Adding generic-array v0.14.7 (available: v0.14.9)
[INFO] [stderr]       Adding gethostname v0.2.3 (available: v1.1.0)
[INFO] [stderr]       Adding hashlru v0.6.1 (available: v0.11.1)
[INFO] [stderr]       Adding rand v0.7.3 (available: v0.10.0)
[INFO] [stderr]       Adding rand v0.8.5 (available: v0.10.0)
[INFO] [stderr]       Adding rand_core v0.6.4 (available: v0.10.0)
[INFO] [stderr]       Adding sha2 v0.9.9 (available: v0.10.9)
[INFO] [stderr]       Adding signature v1.6.4 (available: v2.2.0)
[INFO] [stderr]       Adding vclock v0.2.3 (available: v0.4.4)
[INFO] [stderr]       Adding zeroize v1.3.0 (available: v1.8.2)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded gethostname v0.2.3
[INFO] [stderr]   Downloaded vclock v0.2.3
[INFO] [stderr]   Downloaded ckey v0.1.1
[INFO] [stderr]   Downloaded hashlru v0.6.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 211e5860a8c9e393697e130ba40d30d2da811a8240144c6bf5743c1c380aec99
[INFO] running `Command { std: "docker" "start" "-a" "211e5860a8c9e393697e130ba40d30d2da811a8240144c6bf5743c1c380aec99", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "211e5860a8c9e393697e130ba40d30d2da811a8240144c6bf5743c1c380aec99", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "211e5860a8c9e393697e130ba40d30d2da811a8240144c6bf5743c1c380aec99", kill_on_drop: false }`
[INFO] [stdout] 211e5860a8c9e393697e130ba40d30d2da811a8240144c6bf5743c1c380aec99
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a35650adca7f0fad4f87a1d7aa1f8bc0bf91657dac94bf515acdc10fc5230366
[INFO] running `Command { std: "docker" "start" "-a" "a35650adca7f0fad4f87a1d7aa1f8bc0bf91657dac94bf515acdc10fc5230366", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.183
[INFO] [stderr]     Checking stable_deref_trait v1.2.1
[INFO] [stderr]    Compiling typenum v1.19.0
[INFO] [stderr]     Checking litemap v0.8.1
[INFO] [stderr]    Compiling getrandom v0.1.16
[INFO] [stderr]     Checking writeable v0.6.2
[INFO] [stderr]    Compiling icu_properties_data v2.1.2
[INFO] [stderr]    Compiling icu_normalizer_data v2.1.1
[INFO] [stderr]    Compiling serde_core v1.0.228
[INFO] [stderr]    Compiling generic-array v0.14.7
[INFO] [stderr]    Compiling serde v1.0.228
[INFO] [stderr]     Checking smallvec v1.15.1
[INFO] [stderr]     Checking cpufeatures v0.2.17
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]     Checking byteorder v1.5.0
[INFO] [stderr]     Checking percent-encoding v2.3.2
[INFO] [stderr]     Checking subtle v2.6.1
[INFO] [stderr]     Checking utf8_iter v1.0.4
[INFO] [stderr]     Checking opaque-debug v0.3.1
[INFO] [stderr]     Checking signature v1.6.4
[INFO] [stderr]     Checking hex v0.4.3
[INFO] [stderr]     Checking form_urlencoded v1.2.2
[INFO] [stderr]     Checking getrandom v0.2.17
[INFO] [stderr]     Checking gethostname v0.2.3
[INFO] [stderr]     Checking block-buffer v0.10.4
[INFO] [stderr]     Checking digest v0.9.0
[INFO] [stderr]     Checking crypto-common v0.1.7
[INFO] [stderr]     Checking block-buffer v0.9.0
[INFO] [stderr]     Checking rand_core v0.5.1
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking sha2 v0.9.9
[INFO] [stderr]     Checking rand_chacha v0.2.2
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.7.3
[INFO] [stderr]     Checking sha2 v0.10.9
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking serde_json v1.0.149
[INFO] [stderr]     Checking serde_bytes v0.11.19
[INFO] [stderr]    Compiling synstructure v0.13.2
[INFO] [stderr]    Compiling zerovec-derive v0.11.2
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]    Compiling zeroize_derive v1.4.3
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.8.1
[INFO] [stderr]     Checking zeroize v1.3.0
[INFO] [stderr]     Checking curve25519-dalek v3.2.1
[INFO] [stderr]     Checking zerofrom v0.1.6
[INFO] [stderr]     Checking yoke v0.8.1
[INFO] [stderr]     Checking zerotrie v0.2.3
[INFO] [stderr]     Checking zerovec v0.11.5
[INFO] [stderr]     Checking tinystr v0.8.2
[INFO] [stderr]     Checking potential_utf v0.1.4
[INFO] [stderr]     Checking icu_collections v2.1.1
[INFO] [stderr]     Checking icu_locale_core v2.1.1
[INFO] [stderr]     Checking icu_provider v2.1.1
[INFO] [stderr]     Checking icu_properties v2.1.2
[INFO] [stderr]     Checking icu_normalizer v2.1.1
[INFO] [stderr]     Checking bincode v1.3.3
[INFO] [stderr]     Checking serde_cbor v0.11.2
[INFO] [stderr]     Checking ed25519 v1.5.3
[INFO] [stderr]     Checking hashlru v0.6.1
[INFO] [stderr]     Checking ed25519-dalek v1.0.1
[INFO] [stderr]     Checking vclock v0.2.3
[INFO] [stderr]     Checking ckey v0.1.1
[INFO] [stderr]     Checking idna_adapter v1.2.1
[INFO] [stderr]     Checking idna v1.1.0
[INFO] [stderr]     Checking url v2.5.8
[INFO] [stderr]     Checking confitul v0.1.4 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/crypto.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/crypto.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use signature;
[INFO] [stdout]   | ^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]  --> src/crypto.rs:6:21
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub const CONTEXT: &'static [u8] = env!("CARGO_PKG_HOMEPAGE").as_bytes();
[INFO] [stdout]   |                    -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]   = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/host.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use signature;
[INFO] [stdout]   | ^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/host_id.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/local_host.rs:6:1
[INFO] [stdout]   |
[INFO] [stdout] 6 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/local_host.rs:53:13
[INFO] [stdout]    |
[INFO] [stdout] 53 |             keypair: keypair,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `keypair`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/remote_host.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]   --> src/cluster_options.rs:65:5
[INFO] [stdout]    |
[INFO] [stdout] 65 |     use serde_json;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]    = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/crypto.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/crypto.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use signature;
[INFO] [stdout]   | ^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]  --> src/crypto.rs:6:21
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub const CONTEXT: &'static [u8] = env!("CARGO_PKG_HOMEPAGE").as_bytes();
[INFO] [stdout]   |                    -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]   = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/host.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use signature;
[INFO] [stdout]   | ^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/host_id.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/local_host.rs:6:1
[INFO] [stdout]   |
[INFO] [stdout] 6 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/local_host.rs:53:13
[INFO] [stdout]    |
[INFO] [stdout] 53 |             keypair: keypair,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `keypair`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]    --> src/local_host.rs:169:5
[INFO] [stdout]     |
[INFO] [stdout] 169 |     use serde_json;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]    --> src/local_host_options.rs:117:5
[INFO] [stdout]     |
[INFO] [stdout] 117 |     use serde_json;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/remote_host.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | use ed25519_dalek;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]   --> src/remote_host.rs:77:5
[INFO] [stdout]    |
[INFO] [stdout] 77 |     use serde_json;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/cluster.rs:28:36
[INFO] [stdout]    |
[INFO] [stdout] 28 |         let real_options = options.unwrap_or(ClusterOptions::default());
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `CKey` which implements the `Copy` trait
[INFO] [stdout]   --> src/cluster.rs:42:29
[INFO] [stdout]    |
[INFO] [stdout] 42 |             let to_remove = self.nodes.iter().next().unwrap().0.clone();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.nodes.iter().next().unwrap().0`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/cluster.rs:47:13
[INFO] [stdout]    |
[INFO] [stdout] 47 | /             match self.nodes.insert(node.key, node) {
[INFO] [stdout] ...  |
[INFO] [stdout] 52 | |                 None => {}
[INFO] [stdout] 53 | |             }
[INFO] [stdout]    | |_____________^ help: try: `if let Some(_) = self.nodes.insert(node.key, node) { panic!("duplicate node key") }`
[INFO] [stdout]    |
[INFO] [stdout]    = note: you might want to preserve the comments from inside the `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default()
[INFO] [stdout]   --> src/cluster_options.rs:19:9
[INFO] [stdout]    |
[INFO] [stdout] 19 |         cluster_options.local_host = real_local_host_options;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: consider initializing the variable with `cluster_options::ClusterOptions { local_host: real_local_host_options, ..Default::default() }` and removing relevant reassignments
[INFO] [stdout]   --> src/cluster_options.rs:18:9
[INFO] [stdout]    |
[INFO] [stdout] 18 |         let mut cluster_options = Self::default();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
[INFO] [stdout]    = note: `#[warn(clippy::field_reassign_with_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/cluster_options.rs:17:58
[INFO] [stdout]    |
[INFO] [stdout] 17 |         let real_local_host_options = local_host_options.unwrap_or(LocalHostOptions::default());
[INFO] [stdout]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/crypto.rs:34:8
[INFO] [stdout]    |
[INFO] [stdout] 34 |     if CONTEXT.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `CONTEXT.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/host.rs:130:59
[INFO] [stdout]     |
[INFO] [stdout] 130 |         self.verify_msg(&self.info().content_to_verify(), &self.sig())
[INFO] [stdout]     |                                                           ^^^^^^^^^^^ help: change this to: `self.sig()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `[u8; 32]`
[INFO] [stdout]   --> src/host_id.rs:18:20
[INFO] [stdout]    |
[INFO] [stdout] 18 |             value: <[u8; HOST_ID_LEN]>::try_from(key.public.to_bytes())
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider removing `<[u8; HOST_ID_LEN]>::try_from()`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/cluster.rs:28:36
[INFO] [stdout]    |
[INFO] [stdout] 28 |         let real_options = options.unwrap_or(ClusterOptions::default());
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/local_host.rs:44:36
[INFO] [stdout]    |
[INFO] [stdout] 44 |         let real_options = options.unwrap_or(LocalHostOptions::default());
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `CKey` which implements the `Copy` trait
[INFO] [stdout]   --> src/cluster.rs:42:29
[INFO] [stdout]    |
[INFO] [stdout] 42 |             let to_remove = self.nodes.iter().next().unwrap().0.clone();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.nodes.iter().next().unwrap().0`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/cluster.rs:47:13
[INFO] [stdout]    |
[INFO] [stdout] 47 | /             match self.nodes.insert(node.key, node) {
[INFO] [stdout] ...  |
[INFO] [stdout] 52 | |                 None => {}
[INFO] [stdout] 53 | |             }
[INFO] [stdout]    | |_____________^ help: try: `if let Some(_) = self.nodes.insert(node.key, node) { panic!("duplicate node key") }`
[INFO] [stdout]    |
[INFO] [stdout]    = note: you might want to preserve the comments from inside the `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/local_host_options.rs:76:20
[INFO] [stdout]    |
[INFO] [stdout] 76 |                 if hostname.len() > 0 {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hostname.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/local_host_options.rs:90:12
[INFO] [stdout]    |
[INFO] [stdout] 90 |         if self.name.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.name.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default()
[INFO] [stdout]   --> src/cluster_options.rs:19:9
[INFO] [stdout]    |
[INFO] [stdout] 19 |         cluster_options.local_host = real_local_host_options;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: consider initializing the variable with `cluster_options::ClusterOptions { local_host: real_local_host_options, ..Default::default() }` and removing relevant reassignments
[INFO] [stdout]   --> src/cluster_options.rs:18:9
[INFO] [stdout]    |
[INFO] [stdout] 18 |         let mut cluster_options = Self::default();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
[INFO] [stdout]    = note: `#[warn(clippy::field_reassign_with_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/cluster_options.rs:17:58
[INFO] [stdout]    |
[INFO] [stdout] 17 |         let real_local_host_options = local_host_options.unwrap_or(LocalHostOptions::default());
[INFO] [stdout]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `MemoryStore<C, V>`
[INFO] [stdout]   --> src/memory_store.rs:42:5
[INFO] [stdout]    |
[INFO] [stdout] 42 | /     pub fn new() -> Self {
[INFO] [stdout] 43 | |         MemoryStore::<C, V> {
[INFO] [stdout] 44 | |             items: Arc::new(RwLock::new(Cache::new(MEMORY_STORE_ITEMS_SIZE))),
[INFO] [stdout] 45 | |             conflicts: Arc::new(RwLock::new(SizedQueue::new(MEMORY_STORE_CONFLICTS_SIZE))),
[INFO] [stdout] ...  |
[INFO] [stdout] 49 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 37 + impl<C, V> Default for MemoryStore<C, V>
[INFO] [stdout] 38 + where
[INFO] [stdout] 39 +     C: Eq + Hash + Clone,
[INFO] [stdout] 40 +     V: Clone,
[INFO] [stdout] 41 +  {
[INFO] [stdout] 42 +     fn default() -> Self {
[INFO] [stdout] 43 +         Self::new()
[INFO] [stdout] 44 +     }
[INFO] [stdout] 45 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/memory_store.rs:185:9
[INFO] [stdout]     |
[INFO] [stdout] 185 | /         match items.get(key) {
[INFO] [stdout] ...   |
[INFO] [stdout] 193 | |             None => None,
[INFO] [stdout] 194 | |         }
[INFO] [stdout]     | |_________^ help: try: `items.get(key).map(|v| v.clone())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/memory_store.rs:207:24
[INFO] [stdout]     |
[INFO] [stdout] 207 |               Some(v) => match &v.value {
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 208 | |                 Some(value) => Some(value.clone()),
[INFO] [stdout] 209 | |                 None => None,
[INFO] [stdout] 210 | |             },
[INFO] [stdout]     | |_____________^ help: try: `v.value.as_ref().map(|value| value.clone())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/memory_store.rs:231:49
[INFO] [stdout]     |
[INFO] [stdout] 231 |         self.items.read().unwrap().contains_key(&key)
[INFO] [stdout]     |                                                 ^^^^ help: change this to: `key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/memory_store.rs:238:24
[INFO] [stdout]     |
[INFO] [stdout] 238 |             Some(v) => !v.value.is_none(),
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^ help: try: `v.value.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this call to `map()` won't have an effect on the call to `count()`
[INFO] [stdout]    --> src/memory_store.rs:289:9
[INFO] [stdout]     |
[INFO] [stdout] 289 | /         suggestions
[INFO] [stdout] 290 | |             .map(|suggestion| self.assign_versioned(suggestion.key, suggestion.versioned))
[INFO] [stdout] 291 | |             .count()
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: make sure you did not confuse `map` with `filter`, `for_each` or `inspect`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_map
[INFO] [stdout]     = note: `#[warn(clippy::suspicious_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/memory_store.rs:333:24
[INFO] [stdout]     |
[INFO] [stdout] 333 |                     if !versioned.value.is_none() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `versioned.value.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/memory_store.rs:333:21
[INFO] [stdout]     |
[INFO] [stdout] 333 | /                     if !versioned.value.is_none() {
[INFO] [stdout] 334 | |                         return Some(versioned.clone());
[INFO] [stdout] 335 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 332 ~                 Some(versioned)
[INFO] [stdout] 333 ~                     if !versioned.value.is_none() => {
[INFO] [stdout] 334 |                         return Some(versioned.clone());
[INFO] [stdout] 335 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/memory_store.rs:331:13
[INFO] [stdout]     |
[INFO] [stdout] 331 | /             match self.items.read().unwrap().peek(&self.keys[self.pos]) {
[INFO] [stdout] 332 | |                 Some(versioned) => {
[INFO] [stdout] 333 | |                     if !versioned.value.is_none() {
[INFO] [stdout] 334 | |                         return Some(versioned.clone());
[INFO] [stdout] ...   |
[INFO] [stdout] 337 | |                 None => (),
[INFO] [stdout] 338 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 331 ~             if let Some(versioned) = self.items.read().unwrap().peek(&self.keys[self.pos]) {
[INFO] [stdout] 332 +                 if !versioned.value.is_none() {
[INFO] [stdout] 333 +                     return Some(versioned.clone());
[INFO] [stdout] 334 +                 }
[INFO] [stdout] 335 +             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/crypto.rs:34:8
[INFO] [stdout]    |
[INFO] [stdout] 34 |     if CONTEXT.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `CONTEXT.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline
[INFO] [stdout]   --> src/remote_host.rs:49:9
[INFO] [stdout]    |
[INFO] [stdout] 49 |         print!("{:?}\n", remote_host.info.sig.as_ref().unwrap());
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stdout]    = note: `#[warn(clippy::print_with_newline)]` on by default
[INFO] [stdout] help: use `println!` instead
[INFO] [stdout]    |
[INFO] [stdout] 49 -         print!("{:?}\n", remote_host.info.sig.as_ref().unwrap());
[INFO] [stdout] 49 +         println!("{:?}", remote_host.info.sig.as_ref().unwrap());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline
[INFO] [stdout]   --> src/remote_host.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         print!("{:?}\n", info.sig.as_ref().unwrap());
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stdout] help: use `println!` instead
[INFO] [stdout]    |
[INFO] [stdout] 50 -         print!("{:?}\n", info.sig.as_ref().unwrap());
[INFO] [stdout] 50 +         println!("{:?}", info.sig.as_ref().unwrap());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `SizedQueue` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/sized_queue.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 |     pub fn len(&self) -> usize {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/sized_queue.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 27 | /         let dropped = if old_size > size {
[INFO] [stdout] 28 | |             self.queue.truncate(size);
[INFO] [stdout] 29 | |             old_size - size
[INFO] [stdout] 30 | |         } else {
[INFO] [stdout] ...  |
[INFO] [stdout] 34 | |             0
[INFO] [stdout] 35 | |         };
[INFO] [stdout]    | |__________- unnecessary `let` binding
[INFO] [stdout] 36 |
[INFO] [stdout] 37 |           dropped
[INFO] [stdout]    |           ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 27 ~         
[INFO] [stdout] 28 |
[INFO] [stdout] 29 ~         if old_size > size {
[INFO] [stdout] 30 +             self.queue.truncate(size);
[INFO] [stdout] 31 +             old_size - size
[INFO] [stdout] 32 +         } else {
[INFO] [stdout] 33 +             if size > old_size {
[INFO] [stdout] 34 +                 self.queue.try_reserve(size - old_size).ok();
[INFO] [stdout] 35 +             }
[INFO] [stdout] 36 +             0
[INFO] [stdout] 37 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `while let` loop
[INFO] [stdout]   --> src/sized_queue_drain.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | /         loop {
[INFO] [stdout] 12 | |             match old_queue.pop() {
[INFO] [stdout] 13 | |                 Some(v) => new_queue.push_back(v),
[INFO] [stdout] 14 | |                 None => break,
[INFO] [stdout] 15 | |             }
[INFO] [stdout] 16 | |         }
[INFO] [stdout]    | |_________^ help: try: `while let Some(v) = old_queue.pop() { .. }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stdout]    = note: `#[warn(clippy::while_let_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]   --> src/crypto.rs:88:17
[INFO] [stdout]    |
[INFO] [stdout] 88 |         assert!(matches!(verify(&keypair.public, foo, &sig_bar), Err(_)));
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&keypair.public, foo, &sig_bar).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]   --> src/crypto.rs:90:17
[INFO] [stdout]    |
[INFO] [stdout] 90 |         assert!(matches!(verify(&keypair.public, bar, &sig_foo), Err(_)));
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&keypair.public, bar, &sig_foo).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/crypto.rs:106:17
[INFO] [stdout]     |
[INFO] [stdout] 106 |         assert!(matches!(verify(&public, foo, &sig_bar), Err(_)));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&public, foo, &sig_bar).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/crypto.rs:108:17
[INFO] [stdout]     |
[INFO] [stdout] 108 |         assert!(matches!(verify(&public, bar, &sig_foo), Err(_)));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&public, bar, &sig_foo).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/host.rs:130:59
[INFO] [stdout]     |
[INFO] [stdout] 130 |         self.verify_msg(&self.info().content_to_verify(), &self.sig())
[INFO] [stdout]     |                                                           ^^^^^^^^^^^ help: change this to: `self.sig()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `[u8; 32]`
[INFO] [stdout]   --> src/host_id.rs:18:20
[INFO] [stdout]    |
[INFO] [stdout] 18 |             value: <[u8; HOST_ID_LEN]>::try_from(key.public.to_bytes())
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider removing `<[u8; HOST_ID_LEN]>::try_from()`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]   --> src/local_host.rs:44:36
[INFO] [stdout]    |
[INFO] [stdout] 44 |         let real_options = options.unwrap_or(LocalHostOptions::default());
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/local_host_options.rs:76:20
[INFO] [stdout]    |
[INFO] [stdout] 76 |                 if hostname.len() > 0 {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hostname.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/local_host_options.rs:90:12
[INFO] [stdout]    |
[INFO] [stdout] 90 |         if self.name.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.name.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `MemoryStore<C, V>`
[INFO] [stdout]   --> src/memory_store.rs:42:5
[INFO] [stdout]    |
[INFO] [stdout] 42 | /     pub fn new() -> Self {
[INFO] [stdout] 43 | |         MemoryStore::<C, V> {
[INFO] [stdout] 44 | |             items: Arc::new(RwLock::new(Cache::new(MEMORY_STORE_ITEMS_SIZE))),
[INFO] [stdout] 45 | |             conflicts: Arc::new(RwLock::new(SizedQueue::new(MEMORY_STORE_CONFLICTS_SIZE))),
[INFO] [stdout] ...  |
[INFO] [stdout] 49 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 37 + impl<C, V> Default for MemoryStore<C, V>
[INFO] [stdout] 38 + where
[INFO] [stdout] 39 +     C: Eq + Hash + Clone,
[INFO] [stdout] 40 +     V: Clone,
[INFO] [stdout] 41 +  {
[INFO] [stdout] 42 +     fn default() -> Self {
[INFO] [stdout] 43 +         Self::new()
[INFO] [stdout] 44 +     }
[INFO] [stdout] 45 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/memory_store.rs:185:9
[INFO] [stdout]     |
[INFO] [stdout] 185 | /         match items.get(key) {
[INFO] [stdout] ...   |
[INFO] [stdout] 193 | |             None => None,
[INFO] [stdout] 194 | |         }
[INFO] [stdout]     | |_________^ help: try: `items.get(key).map(|v| v.clone())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/memory_store.rs:207:24
[INFO] [stdout]     |
[INFO] [stdout] 207 |               Some(v) => match &v.value {
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 208 | |                 Some(value) => Some(value.clone()),
[INFO] [stdout] 209 | |                 None => None,
[INFO] [stdout] 210 | |             },
[INFO] [stdout]     | |_____________^ help: try: `v.value.as_ref().map(|value| value.clone())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/memory_store.rs:231:49
[INFO] [stdout]     |
[INFO] [stdout] 231 |         self.items.read().unwrap().contains_key(&key)
[INFO] [stdout]     |                                                 ^^^^ help: change this to: `key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/memory_store.rs:238:24
[INFO] [stdout]     |
[INFO] [stdout] 238 |             Some(v) => !v.value.is_none(),
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^ help: try: `v.value.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this call to `map()` won't have an effect on the call to `count()`
[INFO] [stdout]    --> src/memory_store.rs:289:9
[INFO] [stdout]     |
[INFO] [stdout] 289 | /         suggestions
[INFO] [stdout] 290 | |             .map(|suggestion| self.assign_versioned(suggestion.key, suggestion.versioned))
[INFO] [stdout] 291 | |             .count()
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: make sure you did not confuse `map` with `filter`, `for_each` or `inspect`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_map
[INFO] [stdout]     = note: `#[warn(clippy::suspicious_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/memory_store.rs:333:24
[INFO] [stdout]     |
[INFO] [stdout] 333 |                     if !versioned.value.is_none() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `versioned.value.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/memory_store.rs:333:21
[INFO] [stdout]     |
[INFO] [stdout] 333 | /                     if !versioned.value.is_none() {
[INFO] [stdout] 334 | |                         return Some(versioned.clone());
[INFO] [stdout] 335 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 332 ~                 Some(versioned)
[INFO] [stdout] 333 ~                     if !versioned.value.is_none() => {
[INFO] [stdout] 334 |                         return Some(versioned.clone());
[INFO] [stdout] 335 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/memory_store.rs:331:13
[INFO] [stdout]     |
[INFO] [stdout] 331 | /             match self.items.read().unwrap().peek(&self.keys[self.pos]) {
[INFO] [stdout] 332 | |                 Some(versioned) => {
[INFO] [stdout] 333 | |                     if !versioned.value.is_none() {
[INFO] [stdout] 334 | |                         return Some(versioned.clone());
[INFO] [stdout] ...   |
[INFO] [stdout] 337 | |                 None => (),
[INFO] [stdout] 338 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 331 ~             if let Some(versioned) = self.items.read().unwrap().peek(&self.keys[self.pos]) {
[INFO] [stdout] 332 +                 if !versioned.value.is_none() {
[INFO] [stdout] 333 +                     return Some(versioned.clone());
[INFO] [stdout] 334 +                 }
[INFO] [stdout] 335 +             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline
[INFO] [stdout]   --> src/remote_host.rs:49:9
[INFO] [stdout]    |
[INFO] [stdout] 49 |         print!("{:?}\n", remote_host.info.sig.as_ref().unwrap());
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stdout]    = note: `#[warn(clippy::print_with_newline)]` on by default
[INFO] [stdout] help: use `println!` instead
[INFO] [stdout]    |
[INFO] [stdout] 49 -         print!("{:?}\n", remote_host.info.sig.as_ref().unwrap());
[INFO] [stdout] 49 +         println!("{:?}", remote_host.info.sig.as_ref().unwrap());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline
[INFO] [stdout]   --> src/remote_host.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         print!("{:?}\n", info.sig.as_ref().unwrap());
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stdout] help: use `println!` instead
[INFO] [stdout]    |
[INFO] [stdout] 50 -         print!("{:?}\n", info.sig.as_ref().unwrap());
[INFO] [stdout] 50 +         println!("{:?}", info.sig.as_ref().unwrap());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `SizedQueue` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/sized_queue.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 |     pub fn len(&self) -> usize {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/sized_queue.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 27 | /         let dropped = if old_size > size {
[INFO] [stdout] 28 | |             self.queue.truncate(size);
[INFO] [stdout] 29 | |             old_size - size
[INFO] [stdout] 30 | |         } else {
[INFO] [stdout] ...  |
[INFO] [stdout] 34 | |             0
[INFO] [stdout] 35 | |         };
[INFO] [stdout]    | |__________- unnecessary `let` binding
[INFO] [stdout] 36 |
[INFO] [stdout] 37 |           dropped
[INFO] [stdout]    |           ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 27 ~         
[INFO] [stdout] 28 |
[INFO] [stdout] 29 ~         if old_size > size {
[INFO] [stdout] 30 +             self.queue.truncate(size);
[INFO] [stdout] 31 +             old_size - size
[INFO] [stdout] 32 +         } else {
[INFO] [stdout] 33 +             if size > old_size {
[INFO] [stdout] 34 +                 self.queue.try_reserve(size - old_size).ok();
[INFO] [stdout] 35 +             }
[INFO] [stdout] 36 +             0
[INFO] [stdout] 37 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `while let` loop
[INFO] [stdout]   --> src/sized_queue_drain.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | /         loop {
[INFO] [stdout] 12 | |             match old_queue.pop() {
[INFO] [stdout] 13 | |                 Some(v) => new_queue.push_back(v),
[INFO] [stdout] 14 | |                 None => break,
[INFO] [stdout] 15 | |             }
[INFO] [stdout] 16 | |         }
[INFO] [stdout]    | |_________^ help: try: `while let Some(v) = old_queue.pop() { .. }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stdout]    = note: `#[warn(clippy::while_let_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.03s
[INFO] running `Command { std: "docker" "inspect" "a35650adca7f0fad4f87a1d7aa1f8bc0bf91657dac94bf515acdc10fc5230366", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a35650adca7f0fad4f87a1d7aa1f8bc0bf91657dac94bf515acdc10fc5230366", kill_on_drop: false }`
[INFO] [stdout] a35650adca7f0fad4f87a1d7aa1f8bc0bf91657dac94bf515acdc10fc5230366