[INFO] fetching crate columnrs 0.1.1... [INFO] linting columnrs-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate columnrs 0.1.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate columnrs 0.1.1 [INFO] finished tweaking crates.io crate columnrs 0.1.1 [INFO] tweaked toml for crates.io crate columnrs 0.1.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate columnrs 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate columnrs 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.18 [INFO] [stderr] Downloaded clap_builder v4.5.18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb73f0e7c18b00768aa4ae4131c66f172b31847c3404a43f850b65a031aa89cf [INFO] running `Command { std: "docker" "start" "-a" "eb73f0e7c18b00768aa4ae4131c66f172b31847c3404a43f850b65a031aa89cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb73f0e7c18b00768aa4ae4131c66f172b31847c3404a43f850b65a031aa89cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb73f0e7c18b00768aa4ae4131c66f172b31847c3404a43f850b65a031aa89cf", kill_on_drop: false }` [INFO] [stdout] eb73f0e7c18b00768aa4ae4131c66f172b31847c3404a43f850b65a031aa89cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cde4091535ac8fdc75034daa0f00911fee6f4615926b0c90fc37ca303e447c17 [INFO] running `Command { std: "docker" "start" "-a" "cde4091535ac8fdc75034daa0f00911fee6f4615926b0c90fc37ca303e447c17", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking columnrs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / for line in stdin.lock().lines() { [INFO] [stdout] 26 | | if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ for line in stdin.lock().lines().flatten() { [INFO] [stdout] 26 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | / for line in reader.lines() { [INFO] [stdout] 37 | | if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ for line in reader.lines().flatten() { [INFO] [stdout] 37 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 91 | let align_left = !is_numeric[j] ||(left_align_numeric && is_numeric[j] && i > 0); // Don't right-align header [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_numeric[j] || left_align_numeric && i > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / for line in stdin.lock().lines() { [INFO] [stdout] 26 | | if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Ok(line) = line { [INFO] [stdout] 27 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ for line in stdin.lock().lines().flatten() { [INFO] [stdout] 26 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | / for line in reader.lines() { [INFO] [stdout] 37 | | if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Ok(line) = line { [INFO] [stdout] 38 | | process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ for line in reader.lines().flatten() { [INFO] [stdout] 37 + process_line(&mut all_lines, &line, args.empty); [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 91 | let align_left = !is_numeric[j] ||(left_align_numeric && is_numeric[j] && i > 0); // Don't right-align header [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_numeric[j] || left_align_numeric && i > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.25s [INFO] running `Command { std: "docker" "inspect" "cde4091535ac8fdc75034daa0f00911fee6f4615926b0c90fc37ca303e447c17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cde4091535ac8fdc75034daa0f00911fee6f4615926b0c90fc37ca303e447c17", kill_on_drop: false }` [INFO] [stdout] cde4091535ac8fdc75034daa0f00911fee6f4615926b0c90fc37ca303e447c17