[INFO] fetching crate coin 0.5.0... [INFO] linting coin-0.5.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate coin 0.5.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate coin 0.5.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate coin 0.5.0 [INFO] tweaked toml for crates.io crate coin 0.5.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate coin 0.5.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate coin 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tungstenite v0.26.1 [INFO] [stderr] Downloaded tokio-tungstenite v0.26.1 [INFO] [stderr] Downloaded ethnum v1.5.0 [INFO] [stderr] Downloaded thiserror-impl v2.0.10 [INFO] [stderr] Downloaded thiserror v2.0.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 905e9ae4e77b0a9e1d83cddd1239849718d490394030fd0c09983b9465642726 [INFO] running `Command { std: "docker" "start" "-a" "905e9ae4e77b0a9e1d83cddd1239849718d490394030fd0c09983b9465642726", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "905e9ae4e77b0a9e1d83cddd1239849718d490394030fd0c09983b9465642726", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "905e9ae4e77b0a9e1d83cddd1239849718d490394030fd0c09983b9465642726", kill_on_drop: false }` [INFO] [stdout] 905e9ae4e77b0a9e1d83cddd1239849718d490394030fd0c09983b9465642726 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f9eb431ac0f9e4fccfd90df98fecbcb0a43b863e5ab618556587e7dc588fc81 [INFO] running `Command { std: "docker" "start" "-a" "6f9eb431ac0f9e4fccfd90df98fecbcb0a43b863e5ab618556587e7dc588fc81", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Compiling thiserror v2.0.10 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.10 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.42.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking tungstenite v0.26.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-tungstenite v0.26.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking serdect v0.2.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.133 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking k256 v0.13.4 [INFO] [stderr] Checking coin v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/frametype.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Buf` and `BytesMut` [INFO] [stdout] --> src/frametype.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | use bytes::{Buf, BytesMut}; [INFO] [stdout] | ^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/frametype.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Buf` and `BytesMut` [INFO] [stdout] --> src/frametype.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | use bytes::{Buf, BytesMut}; [INFO] [stdout] | ^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::StreamExt` [INFO] [stdout] --> src/frametype.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use futures::StreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::StreamExt` [INFO] [stdout] --> src/frametype.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use futures::StreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | || !my_verifying_key [INFO] [stdout] | ________________^ [INFO] [stdout] 100 | | .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature) [INFO] [stdout] 101 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 ~ || my_verifying_key [INFO] [stdout] 100 + .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:90:46 [INFO] [stdout] | [INFO] [stdout] 90 | let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 91 | | "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 | | 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 | | 93973C55E85382F90F2935E", [INFO] [stdout] 94 | | ) [INFO] [stdout] 95 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 90 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] 91 + "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 + 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 + 93973C55E85382F90F2935E", [INFO] [stdout] 94 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/block.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 143 | if self.blocks.len() == 0 { return 0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.blocks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | hasher.update(&prev_block.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `prev_block.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | &self.blocks.last().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.blocks.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 276 - work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] 276 + work += u64::MAX / block.get_work_amount(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Block` [INFO] [stdout] --> src/block.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | / pub fn new() -> Self { [INFO] [stdout] 304 | | Self { [INFO] [stdout] 305 | | version: 1, [INFO] [stdout] 306 | | time_stamp: 0, [INFO] [stdout] ... | [INFO] [stdout] 311 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 291 + impl Default for Block { [INFO] [stdout] 292 + fn default() -> Self { [INFO] [stdout] 293 + Self::new() [INFO] [stdout] 294 + } [INFO] [stdout] 295 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:295:38 [INFO] [stdout] | [INFO] [stdout] 295 | pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 295 - pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] 295 + pub const WORK_DIFFICULTY: u64 = u64::MAX / 1_000_000; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/block.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / pub fn transact( [INFO] [stdout] 323 | | &mut self, [INFO] [stdout] 324 | | utxo_set: &mut HashMap, [INFO] [stdout] 325 | | spender_priv: &SigningKey, [INFO] [stdout] 326 | | recipient_pub: &VerifyingKey, [INFO] [stdout] 327 | | amount: u64, [INFO] [stdout] 328 | | ) -> Result<&Tx, ()> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VerifyingKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:330:64 [INFO] [stdout] | [INFO] [stdout] 330 | let recipient_pub = PublicKey::from(VerifyingKey::from(recipient_pub.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:362:54 [INFO] [stdout] | [INFO] [stdout] 362 | new_output.spender = TxPredicate::Pubkey(spender_pub.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `spender_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:363:36 [INFO] [stdout] | [INFO] [stdout] 363 | new_output.recipient = recipient_pub.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:410:12 [INFO] [stdout] | [INFO] [stdout] 410 | Ok(&self.txs.last().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.txs.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/block.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 426 | let work_hash_64 = u64::from_le_bytes(work_hash[0..8].try_into().unwrap()); [INFO] [stdout] | --------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 427 | [INFO] [stdout] 428 | work_hash_64 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 426 ~ [INFO] [stdout] 427 | [INFO] [stdout] 428 ~ u64::from_le_bytes(work_hash[0..8].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:458:46 [INFO] [stdout] | [INFO] [stdout] 458 | let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 459 | | E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E").into(); [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 458 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] 459 ~ E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:523:23 [INFO] [stdout] | [INFO] [stdout] 523 | hasher.update(&self.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | || !my_verifying_key [INFO] [stdout] | ________________^ [INFO] [stdout] 100 | | .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature) [INFO] [stdout] 101 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 ~ || my_verifying_key [INFO] [stdout] 100 + .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | TxPredicate::Pubkey(key) => &key, [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | bytes.extend_from_slice(&key.to_encoded_point(false).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `key.to_encoded_point(false).as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tx` [INFO] [stdout] --> src/tx.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | inputs: Vec::new(), [INFO] [stdout] 137 | | outputs: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 104 + impl Default for Tx { [INFO] [stdout] 105 + fn default() -> Self { [INFO] [stdout] 106 + Self::new() [INFO] [stdout] 107 + } [INFO] [stdout] 108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:90:46 [INFO] [stdout] | [INFO] [stdout] 90 | let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 91 | | "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 | | 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 | | 93973C55E85382F90F2935E", [INFO] [stdout] 94 | | ) [INFO] [stdout] 95 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 90 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] 91 + "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 + 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 + 93973C55E85382F90F2935E", [INFO] [stdout] 94 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn try_from_priv(priv_key: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn try_public_from_str(public_key: &str) -> Result, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/block.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 143 | if self.blocks.len() == 0 { return 0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.blocks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | hasher.update(&prev_block.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `prev_block.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | &self.blocks.last().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.blocks.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 276 - work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] 276 + work += u64::MAX / block.get_work_amount(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Block` [INFO] [stdout] --> src/block.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | / pub fn new() -> Self { [INFO] [stdout] 304 | | Self { [INFO] [stdout] 305 | | version: 1, [INFO] [stdout] 306 | | time_stamp: 0, [INFO] [stdout] ... | [INFO] [stdout] 311 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 291 + impl Default for Block { [INFO] [stdout] 292 + fn default() -> Self { [INFO] [stdout] 293 + Self::new() [INFO] [stdout] 294 + } [INFO] [stdout] 295 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:295:38 [INFO] [stdout] | [INFO] [stdout] 295 | pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 295 - pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] 295 + pub const WORK_DIFFICULTY: u64 = u64::MAX / 1_000_000; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/block.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / pub fn transact( [INFO] [stdout] 323 | | &mut self, [INFO] [stdout] 324 | | utxo_set: &mut HashMap, [INFO] [stdout] 325 | | spender_priv: &SigningKey, [INFO] [stdout] 326 | | recipient_pub: &VerifyingKey, [INFO] [stdout] 327 | | amount: u64, [INFO] [stdout] 328 | | ) -> Result<&Tx, ()> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VerifyingKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:330:64 [INFO] [stdout] | [INFO] [stdout] 330 | let recipient_pub = PublicKey::from(VerifyingKey::from(recipient_pub.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:362:54 [INFO] [stdout] | [INFO] [stdout] 362 | new_output.spender = TxPredicate::Pubkey(spender_pub.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `spender_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:363:36 [INFO] [stdout] | [INFO] [stdout] 363 | new_output.recipient = recipient_pub.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:410:12 [INFO] [stdout] | [INFO] [stdout] 410 | Ok(&self.txs.last().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.txs.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/block.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 426 | let work_hash_64 = u64::from_le_bytes(work_hash[0..8].try_into().unwrap()); [INFO] [stdout] | --------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 427 | [INFO] [stdout] 428 | work_hash_64 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 426 ~ [INFO] [stdout] 427 | [INFO] [stdout] 428 ~ u64::from_le_bytes(work_hash[0..8].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:458:46 [INFO] [stdout] | [INFO] [stdout] 458 | let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 459 | | E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E").into(); [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 458 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] 459 ~ E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:523:23 [INFO] [stdout] | [INFO] [stdout] 523 | hasher.update(&self.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | TxPredicate::Pubkey(key) => &key, [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | bytes.extend_from_slice(&key.to_encoded_point(false).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `key.to_encoded_point(false).as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tx` [INFO] [stdout] --> src/tx.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | inputs: Vec::new(), [INFO] [stdout] 137 | | outputs: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 104 + impl Default for Tx { [INFO] [stdout] 105 + fn default() -> Self { [INFO] [stdout] 106 + Self::new() [INFO] [stdout] 107 + } [INFO] [stdout] 108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn try_from_priv(priv_key: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn try_public_from_str(public_key: &str) -> Result, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Method` and `Request` [INFO] [stdout] --> src/bin/spender.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | use tungstenite::{http::{Method, Request}, client::*}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `url::Url` [INFO] [stdout] --> src/bin/spender.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use url::Url; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verifying` [INFO] [stdout] --> src/bin/spender.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | let (signing, verifying) = keys_from_str(&fs::read_to_string("private_key.txt").unwrap()); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verifying` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `url::Url` [INFO] [stdout] --> src/bin/miner.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use url::Url; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bincode::deserialize` [INFO] [stdout] --> src/bin/miner.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use bincode::deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SecretKey` and `ecdsa::Signature` [INFO] [stdout] --> src/bin/miner.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | use k256::{SecretKey, ecdsa::Signature}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/bin/miner.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::consts::OS` [INFO] [stdout] --> src/bin/miner.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use std::env::consts::OS; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `coin::user::*` [INFO] [stdout] --> src/bin/miner.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use coin::user::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::*` [INFO] [stdout] --> src/bin/miner.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use serde::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/bin/miner.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/bin/miner.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TcpListener` and `TcpStream` [INFO] [stdout] --> src/bin/miner.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | use tokio::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_util::codec::Framed` [INFO] [stdout] --> src/bin/miner.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | use tokio_util::codec::Framed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::consts::OS` [INFO] [stdout] --> src/bin/server.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::env::consts::OS; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Framed` [INFO] [stdout] --> src/bin/server.rs:5:25 [INFO] [stdout] | [INFO] [stdout] 5 | use tokio_util::codec::{Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `join` [INFO] [stdout] --> src/bin/server.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | use tokio::{join, net::TcpListener}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `k256::ecdsa::Signature` [INFO] [stdout] --> tests/test.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use k256::ecdsa::Signature; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `coin::block::*` [INFO] [stdout] --> tests/test.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use coin::block::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `coin::tx::*` [INFO] [stdout] --> tests/test.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | use coin::tx::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `coin::user::*` [INFO] [stdout] --> tests/test.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use coin::user::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/server.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 56 | let mut frame = bincode::deserialize(&msg).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `num_txs` [INFO] [stdout] --> src/bin/server.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | let num_txs = block.txs.len(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_txs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_task` [INFO] [stdout] --> src/bin/server.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let new_task = tokio::spawn(async move { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_task` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Method` and `Request` [INFO] [stdout] --> src/bin/spender.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | use tungstenite::{http::{Method, Request}, client::*}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `url::Url` [INFO] [stdout] --> src/bin/spender.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use url::Url; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/server.rs:87:25 [INFO] [stdout] | [INFO] [stdout] 87 | ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 87 | let _ = ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/server.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 99 | let _ = ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/server.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 106 | ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 106 | let _ = ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::consts::OS` [INFO] [stdout] --> src/bin/server.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::env::consts::OS; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Framed` [INFO] [stdout] --> src/bin/server.rs:5:25 [INFO] [stdout] | [INFO] [stdout] 5 | use tokio_util::codec::{Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `join` [INFO] [stdout] --> src/bin/server.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | use tokio::{join, net::TcpListener}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `genesis` [INFO] [stdout] --> tests/test.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let genesis = Block::genesis_block(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_genesis` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `url::Url` [INFO] [stdout] --> src/bin/miner.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use url::Url; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bincode::deserialize` [INFO] [stdout] --> src/bin/miner.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use bincode::deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SecretKey` and `ecdsa::Signature` [INFO] [stdout] --> src/bin/miner.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | use k256::{SecretKey, ecdsa::Signature}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/bin/miner.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::consts::OS` [INFO] [stdout] --> src/bin/miner.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use std::env::consts::OS; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `coin::user::*` [INFO] [stdout] --> src/bin/miner.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use coin::user::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::*` [INFO] [stdout] --> src/bin/miner.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use serde::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/bin/miner.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/bin/miner.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TcpListener` and `TcpStream` [INFO] [stdout] --> src/bin/miner.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | use tokio::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_util::codec::Framed` [INFO] [stdout] --> src/bin/miner.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | use tokio_util::codec::Framed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sender_priv` [INFO] [stdout] --> tests/test.rs:153:14 [INFO] [stdout] | [INFO] [stdout] 153 | let (sender_priv, _) = genesis_keys(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sender_priv` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `max_timestamp` is assigned to, but never used [INFO] [stdout] --> tests/test.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | let mut max_timestamp = 3000 + 2*60*60; // 3000 + 7200 = 10200 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_max_timestamp` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `max_timestamp` is never read [INFO] [stdout] --> tests/test.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | max_timestamp = state.blocks.last().unwrap().time_stamp + 2*60*60; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/test.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | keys_from_str(&priv_key.trim()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `priv_key.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/test.rs:108:58 [INFO] [stdout] | [INFO] [stdout] 108 | .transact(&mut state.utxo_set, &sender_priv, &sender_priv.verifying_key(), 10) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sender_priv.verifying_key()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verifying` [INFO] [stdout] --> src/bin/spender.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | let (signing, verifying) = keys_from_str(&fs::read_to_string("private_key.txt").unwrap()); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verifying` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/server.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 56 | let mut frame = bincode::deserialize(&msg).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `tokio_tungstenite::tungstenite::Bytes` [INFO] [stdout] --> src/bin/miner.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | ws_sender.send(Message::Binary(Bytes::from(serialized_bytes.clone()))).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Bytes::from()`: `serialized_bytes.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `num_txs` [INFO] [stdout] --> src/bin/server.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | let num_txs = block.txs.len(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_txs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_task` [INFO] [stdout] --> src/bin/server.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let new_task = tokio::spawn(async move { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_task` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/miner.rs:120:69 [INFO] [stdout] | [INFO] [stdout] 120 | if let Ok(new_utxo_set) = state.verify_block(&utxo_set, &prev_block, &new_block, state.median_time_stamp(None), true) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `prev_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/server.rs:87:25 [INFO] [stdout] | [INFO] [stdout] 87 | ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 87 | let _ = ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/server.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 99 | let _ = ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/server.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 106 | ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 106 | let _ = ws_stream.send(Message::Binary(Bytes::from(serialized))).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `tokio_tungstenite::tungstenite::Bytes` [INFO] [stdout] --> src/bin/miner.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | ws_sender.send(Message::Binary(Bytes::from(serialized_bytes.clone()))).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Bytes::from()`: `serialized_bytes.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/miner.rs:120:69 [INFO] [stdout] | [INFO] [stdout] 120 | if let Ok(new_utxo_set) = state.verify_block(&utxo_set, &prev_block, &new_block, state.median_time_stamp(None), true) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `prev_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_block` [INFO] [stdout] --> src/main.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | let new_block = Block::new(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_block` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | TxPredicate::Pubkey(key) => &key, [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | bytes.extend_from_slice(&key.to_encoded_point(false).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `key.to_encoded_point(false).as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tx` [INFO] [stdout] --> src/tx.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | inputs: Vec::new(), [INFO] [stdout] 137 | | outputs: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 104 + impl Default for Tx { [INFO] [stdout] 105 + fn default() -> Self { [INFO] [stdout] 106 + Self::new() [INFO] [stdout] 107 + } [INFO] [stdout] 108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | || !my_verifying_key [INFO] [stdout] | ________________^ [INFO] [stdout] 100 | | .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature) [INFO] [stdout] 101 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 ~ || my_verifying_key [INFO] [stdout] 100 + .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:90:46 [INFO] [stdout] | [INFO] [stdout] 90 | let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 91 | | "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 | | 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 | | 93973C55E85382F90F2935E", [INFO] [stdout] 94 | | ) [INFO] [stdout] 95 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 90 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] 91 + "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 + 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 + 93973C55E85382F90F2935E", [INFO] [stdout] 94 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_block` [INFO] [stdout] --> src/main.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | let new_block = Block::new(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_block` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/block.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 143 | if self.blocks.len() == 0 { return 0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.blocks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | hasher.update(&prev_block.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `prev_block.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | &self.blocks.last().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.blocks.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 276 - work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] 276 + work += u64::MAX / block.get_work_amount(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Block` [INFO] [stdout] --> src/block.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | / pub fn new() -> Self { [INFO] [stdout] 304 | | Self { [INFO] [stdout] 305 | | version: 1, [INFO] [stdout] 306 | | time_stamp: 0, [INFO] [stdout] ... | [INFO] [stdout] 311 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 291 + impl Default for Block { [INFO] [stdout] 292 + fn default() -> Self { [INFO] [stdout] 293 + Self::new() [INFO] [stdout] 294 + } [INFO] [stdout] 295 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:295:38 [INFO] [stdout] | [INFO] [stdout] 295 | pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 295 - pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] 295 + pub const WORK_DIFFICULTY: u64 = u64::MAX / 1_000_000; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/block.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / pub fn transact( [INFO] [stdout] 323 | | &mut self, [INFO] [stdout] 324 | | utxo_set: &mut HashMap, [INFO] [stdout] 325 | | spender_priv: &SigningKey, [INFO] [stdout] 326 | | recipient_pub: &VerifyingKey, [INFO] [stdout] 327 | | amount: u64, [INFO] [stdout] 328 | | ) -> Result<&Tx, ()> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VerifyingKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:330:64 [INFO] [stdout] | [INFO] [stdout] 330 | let recipient_pub = PublicKey::from(VerifyingKey::from(recipient_pub.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:362:54 [INFO] [stdout] | [INFO] [stdout] 362 | new_output.spender = TxPredicate::Pubkey(spender_pub.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `spender_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:363:36 [INFO] [stdout] | [INFO] [stdout] 363 | new_output.recipient = recipient_pub.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:410:12 [INFO] [stdout] | [INFO] [stdout] 410 | Ok(&self.txs.last().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.txs.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/block.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 426 | let work_hash_64 = u64::from_le_bytes(work_hash[0..8].try_into().unwrap()); [INFO] [stdout] | --------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 427 | [INFO] [stdout] 428 | work_hash_64 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 426 ~ [INFO] [stdout] 427 | [INFO] [stdout] 428 ~ u64::from_le_bytes(work_hash[0..8].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:458:46 [INFO] [stdout] | [INFO] [stdout] 458 | let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 459 | | E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E").into(); [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 458 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] 459 ~ E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:523:23 [INFO] [stdout] | [INFO] [stdout] 523 | hasher.update(&self.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn try_from_priv(priv_key: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn try_public_from_str(public_key: &str) -> Result, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 68 | TxPredicate::Pubkey(key) => &key, [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tx.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | bytes.extend_from_slice(&key.to_encoded_point(false).as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `key.to_encoded_point(false).as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tx` [INFO] [stdout] --> src/tx.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | inputs: Vec::new(), [INFO] [stdout] 137 | | outputs: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 104 + impl Default for Tx { [INFO] [stdout] 105 + fn default() -> Self { [INFO] [stdout] 106 + Self::new() [INFO] [stdout] 107 + } [INFO] [stdout] 108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | || !my_verifying_key [INFO] [stdout] | ________________^ [INFO] [stdout] 100 | | .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature) [INFO] [stdout] 101 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 ~ || my_verifying_key [INFO] [stdout] 100 + .verify(&prev_block.txs[0].txid, &prev_block.txs[0].signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:90:46 [INFO] [stdout] | [INFO] [stdout] 90 | let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 91 | | "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 | | 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 | | 93973C55E85382F90F2935E", [INFO] [stdout] 94 | | ) [INFO] [stdout] 95 | | .into(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 90 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str( [INFO] [stdout] 91 + "04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E82\ [INFO] [stdout] 92 + 61ABE15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B3\ [INFO] [stdout] 93 + 93973C55E85382F90F2935E", [INFO] [stdout] 94 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/block.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 143 | if self.blocks.len() == 0 { return 0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.blocks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | hasher.update(&prev_block.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `prev_block.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | &self.blocks.last().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.blocks.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 276 - work += u64::max_value() / block.get_work_amount(); [INFO] [stdout] 276 + work += u64::MAX / block.get_work_amount(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Block` [INFO] [stdout] --> src/block.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | / pub fn new() -> Self { [INFO] [stdout] 304 | | Self { [INFO] [stdout] 305 | | version: 1, [INFO] [stdout] 306 | | time_stamp: 0, [INFO] [stdout] ... | [INFO] [stdout] 311 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 291 + impl Default for Block { [INFO] [stdout] 292 + fn default() -> Self { [INFO] [stdout] 293 + Self::new() [INFO] [stdout] 294 + } [INFO] [stdout] 295 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/block.rs:295:38 [INFO] [stdout] | [INFO] [stdout] 295 | pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 295 - pub const WORK_DIFFICULTY: u64 = u64::max_value() / 1_000_000; [INFO] [stdout] 295 + pub const WORK_DIFFICULTY: u64 = u64::MAX / 1_000_000; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/block.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / pub fn transact( [INFO] [stdout] 323 | | &mut self, [INFO] [stdout] 324 | | utxo_set: &mut HashMap, [INFO] [stdout] 325 | | spender_priv: &SigningKey, [INFO] [stdout] 326 | | recipient_pub: &VerifyingKey, [INFO] [stdout] 327 | | amount: u64, [INFO] [stdout] 328 | | ) -> Result<&Tx, ()> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VerifyingKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:330:64 [INFO] [stdout] | [INFO] [stdout] 330 | let recipient_pub = PublicKey::from(VerifyingKey::from(recipient_pub.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:362:54 [INFO] [stdout] | [INFO] [stdout] 362 | new_output.spender = TxPredicate::Pubkey(spender_pub.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `spender_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `PublicKey` which implements the `Copy` trait [INFO] [stdout] --> src/block.rs:363:36 [INFO] [stdout] | [INFO] [stdout] 363 | new_output.recipient = recipient_pub.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `recipient_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:410:12 [INFO] [stdout] | [INFO] [stdout] 410 | Ok(&self.txs.last().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.txs.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/block.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 426 | let work_hash_64 = u64::from_le_bytes(work_hash[0..8].try_into().unwrap()); [INFO] [stdout] | --------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 427 | [INFO] [stdout] 428 | work_hash_64 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 426 ~ [INFO] [stdout] 427 | [INFO] [stdout] 428 ~ u64::from_le_bytes(work_hash[0..8].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ecdsa::verifying::VerifyingKey` [INFO] [stdout] --> src/block.rs:458:46 [INFO] [stdout] | [INFO] [stdout] 458 | let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 459 | | E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E").into(); [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 458 ~ let my_verifying_key: VerifyingKey = vk_from_encoded_str("04B0B5D59947A744C8ED5032F8B5EC77F56BFF09A724466397E8261AB\ [INFO] [stdout] 459 ~ E15BB1F1EC90871F5034A7B2BBF43F33C99225EF70C6F463B393973C55E85382F90F2935E"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/block.rs:523:23 [INFO] [stdout] | [INFO] [stdout] 523 | hasher.update(&self.as_bytes_no_nonce()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.as_bytes_no_nonce()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn try_from_priv(priv_key: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/user.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn try_public_from_str(public_key: &str) -> Result, ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.78s [INFO] running `Command { std: "docker" "inspect" "6f9eb431ac0f9e4fccfd90df98fecbcb0a43b863e5ab618556587e7dc588fc81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f9eb431ac0f9e4fccfd90df98fecbcb0a43b863e5ab618556587e7dc588fc81", kill_on_drop: false }` [INFO] [stdout] 6f9eb431ac0f9e4fccfd90df98fecbcb0a43b863e5ab618556587e7dc588fc81