[INFO] fetching crate codo 0.0.1... [INFO] linting codo-0.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate codo 0.0.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate codo 0.0.1 [INFO] finished tweaking crates.io crate codo 0.0.1 [INFO] tweaked toml for crates.io crate codo 0.0.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate codo 0.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate codo 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ignore v0.4.20 [INFO] [stderr] Downloaded grep v0.2.12 [INFO] [stderr] Downloaded globset v0.4.13 [INFO] [stderr] Downloaded walkdir v2.4.0 [INFO] [stderr] Downloaded anstyle-wincon v3.0.1 [INFO] [stderr] Downloaded grep-searcher v0.1.11 [INFO] [stderr] Downloaded clap_lex v0.6.0 [INFO] [stderr] Downloaded bytecount v0.6.7 [INFO] [stderr] Downloaded anstream v0.6.4 [INFO] [stderr] Downloaded anstyle-parse v0.2.2 [INFO] [stderr] Downloaded grep-printer v0.1.7 [INFO] [stderr] Downloaded base64 v0.20.0 [INFO] [stderr] Downloaded serde_json v1.0.108 [INFO] [stderr] Downloaded serde v1.0.190 [INFO] [stderr] Downloaded grep-regex v0.1.11 [INFO] [stderr] Downloaded clap_derive v4.4.7 [INFO] [stderr] Downloaded clap v4.4.7 [INFO] [stderr] Downloaded clap_builder v4.4.7 [INFO] [stderr] Downloaded grep-cli v0.1.9 [INFO] [stderr] Downloaded encoding_rs_io v0.1.7 [INFO] [stderr] Downloaded grep-matcher v0.1.6 [INFO] [stderr] Downloaded serde_derive v1.0.190 [INFO] [stderr] Downloaded anstyle v1.0.4 [INFO] [stderr] Downloaded bstr v1.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6098e568cba8ac8a7426481d7a8f36b7090931f0cf73502100b00741c49ccd04 [INFO] running `Command { std: "docker" "start" "-a" "6098e568cba8ac8a7426481d7a8f36b7090931f0cf73502100b00741c49ccd04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6098e568cba8ac8a7426481d7a8f36b7090931f0cf73502100b00741c49ccd04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6098e568cba8ac8a7426481d7a8f36b7090931f0cf73502100b00741c49ccd04", kill_on_drop: false }` [INFO] [stdout] 6098e568cba8ac8a7426481d7a8f36b7090931f0cf73502100b00741c49ccd04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7046758e0c82e5244a9e3f824e413e37ea42aa2aaaae20cb948727663514408b [INFO] running `Command { std: "docker" "start" "-a" "7046758e0c82e5244a9e3f824e413e37ea42aa2aaaae20cb948727663514408b", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking grep-matcher v0.1.6 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking bstr v1.7.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking globset v0.4.13 [INFO] [stderr] Checking grep-searcher v0.1.11 [INFO] [stderr] Checking grep-regex v0.1.11 [INFO] [stderr] Checking grep-cli v0.1.9 [INFO] [stderr] Checking ignore v0.4.20 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking grep-printer v0.1.7 [INFO] [stderr] Checking grep v0.2.12 [INFO] [stderr] Checking codo v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/main.rs:483:5 [INFO] [stdout] | [INFO] [stdout] 483 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/main.rs:483:5 [INFO] [stdout] | [INFO] [stdout] 483 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | info.push(format!("{}", issue.as_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `issue.as_string().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:120:30 [INFO] [stdout] | [INFO] [stdout] 120 | if numbered.is_match(&str) { [INFO] [stdout] | ^^^^ help: change this to: `str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:156:41 [INFO] [stdout] | [INFO] [stdout] 156 | if part.starts_with('@') && assignee == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `assignee.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:163:46 [INFO] [stdout] | [INFO] [stdout] 163 | if date_format.is_match(part) && due == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_none()` instead: `due.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | value == None [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `value.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:419:20 [INFO] [stdout] | [INFO] [stdout] 419 | parts.push(format!("{}", issue.as_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `issue.as_string().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:427:20 [INFO] [stdout] | [INFO] [stdout] 427 | parts.push(format!("{}", due)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `due.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/main.rs:462:50 [INFO] [stdout] | [INFO] [stdout] 462 | let leading_whitespace = line.split(&update.delimiter).nth(0).unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `line.split(&update.delimiter).next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/main.rs:501:26 [INFO] [stdout] | [INFO] [stdout] 501 | let error_list = self [INFO] [stdout] | __________________________^ [INFO] [stdout] 502 | | .errors [INFO] [stdout] 503 | | .to_owned() [INFO] [stdout] 504 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 501 ~ let error_list = self [INFO] [stdout] 502 + .errors.iter().cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:537:34 [INFO] [stdout] | [INFO] [stdout] 537 | if !allowed.contains(&assignee) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `assignee` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 549 | let valid_format = match (format, issue.to_owned()) { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 550 | | (IssueFormat::Numbered, Issue::Numbered(_)) => true, [INFO] [stdout] 551 | | (IssueFormat::ProjectKey, Issue::ProjectKey { .. }) => true, [INFO] [stdout] 552 | | _ => false, [INFO] [stdout] 553 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 549 - let valid_format = match (format, issue.to_owned()) { [INFO] [stdout] 550 - (IssueFormat::Numbered, Issue::Numbered(_)) => true, [INFO] [stdout] 551 - (IssueFormat::ProjectKey, Issue::ProjectKey { .. }) => true, [INFO] [stdout] 552 - _ => false, [INFO] [stdout] 553 - }; [INFO] [stdout] 549 + let valid_format = matches!((format, issue.to_owned()), (IssueFormat::Numbered, Issue::Numbered(_)) | (IssueFormat::ProjectKey, Issue::ProjectKey { .. })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:606:20 [INFO] [stdout] | [INFO] [stdout] 606 | if is_file == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `is_file.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:631:36 [INFO] [stdout] | [INFO] [stdout] 631 | let meta = match meta_capture { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 632 | | Some(meta_match) => Some(line[meta_match].to_string()), [INFO] [stdout] 633 | | None => None, [INFO] [stdout] 634 | | }; [INFO] [stdout] | |_________________________^ help: try: `meta_capture.map(|meta_match| line[meta_match].to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:920:36 [INFO] [stdout] | [INFO] [stdout] 920 | .filter(|todo| !todo.metadata.issue.is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `todo.metadata.issue.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1036:36 [INFO] [stdout] | [INFO] [stdout] 1036 | .filter(|todo| todo.metadata.assignee != None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `todo.metadata.assignee.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1093:36 [INFO] [stdout] | [INFO] [stdout] 1093 | .filter(|todo| todo.metadata.assignee == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `todo.metadata.assignee.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1153:36 [INFO] [stdout] | [INFO] [stdout] 1153 | .filter(|todo| todo.metadata.due != None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `todo.metadata.due.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1180:36 [INFO] [stdout] | [INFO] [stdout] 1180 | .filter(|todo| todo.metadata.due == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `todo.metadata.due.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | info.push(format!("{}", issue.as_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `issue.as_string().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:120:30 [INFO] [stdout] | [INFO] [stdout] 120 | if numbered.is_match(&str) { [INFO] [stdout] | ^^^^ help: change this to: `str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:156:41 [INFO] [stdout] | [INFO] [stdout] 156 | if part.starts_with('@') && assignee == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `assignee.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:163:46 [INFO] [stdout] | [INFO] [stdout] 163 | if date_format.is_match(part) && due == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_none()` instead: `due.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | value == None [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `value.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:419:20 [INFO] [stdout] | [INFO] [stdout] 419 | parts.push(format!("{}", issue.as_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `issue.as_string().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:427:20 [INFO] [stdout] | [INFO] [stdout] 427 | parts.push(format!("{}", due)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `due.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/main.rs:462:50 [INFO] [stdout] | [INFO] [stdout] 462 | let leading_whitespace = line.split(&update.delimiter).nth(0).unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `line.split(&update.delimiter).next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/main.rs:501:26 [INFO] [stdout] | [INFO] [stdout] 501 | let error_list = self [INFO] [stdout] | __________________________^ [INFO] [stdout] 502 | | .errors [INFO] [stdout] 503 | | .to_owned() [INFO] [stdout] 504 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 501 ~ let error_list = self [INFO] [stdout] 502 + .errors.iter().cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:537:34 [INFO] [stdout] | [INFO] [stdout] 537 | if !allowed.contains(&assignee) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `assignee` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 549 | let valid_format = match (format, issue.to_owned()) { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 550 | | (IssueFormat::Numbered, Issue::Numbered(_)) => true, [INFO] [stdout] 551 | | (IssueFormat::ProjectKey, Issue::ProjectKey { .. }) => true, [INFO] [stdout] 552 | | _ => false, [INFO] [stdout] 553 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 549 - let valid_format = match (format, issue.to_owned()) { [INFO] [stdout] 550 - (IssueFormat::Numbered, Issue::Numbered(_)) => true, [INFO] [stdout] 551 - (IssueFormat::ProjectKey, Issue::ProjectKey { .. }) => true, [INFO] [stdout] 552 - _ => false, [INFO] [stdout] 553 - }; [INFO] [stdout] 549 + let valid_format = matches!((format, issue.to_owned()), (IssueFormat::Numbered, Issue::Numbered(_)) | (IssueFormat::ProjectKey, Issue::ProjectKey { .. })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:606:20 [INFO] [stdout] | [INFO] [stdout] 606 | if is_file == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `is_file.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:631:36 [INFO] [stdout] | [INFO] [stdout] 631 | let meta = match meta_capture { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 632 | | Some(meta_match) => Some(line[meta_match].to_string()), [INFO] [stdout] 633 | | None => None, [INFO] [stdout] 634 | | }; [INFO] [stdout] | |_________________________^ help: try: `meta_capture.map(|meta_match| line[meta_match].to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:920:36 [INFO] [stdout] | [INFO] [stdout] 920 | .filter(|todo| !todo.metadata.issue.is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `todo.metadata.issue.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1036:36 [INFO] [stdout] | [INFO] [stdout] 1036 | .filter(|todo| todo.metadata.assignee != None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `todo.metadata.assignee.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1093:36 [INFO] [stdout] | [INFO] [stdout] 1093 | .filter(|todo| todo.metadata.assignee == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `todo.metadata.assignee.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1153:36 [INFO] [stdout] | [INFO] [stdout] 1153 | .filter(|todo| todo.metadata.due != None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `todo.metadata.due.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:1180:36 [INFO] [stdout] | [INFO] [stdout] 1180 | .filter(|todo| todo.metadata.due == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `todo.metadata.due.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.65s [INFO] running `Command { std: "docker" "inspect" "7046758e0c82e5244a9e3f824e413e37ea42aa2aaaae20cb948727663514408b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7046758e0c82e5244a9e3f824e413e37ea42aa2aaaae20cb948727663514408b", kill_on_drop: false }` [INFO] [stdout] 7046758e0c82e5244a9e3f824e413e37ea42aa2aaaae20cb948727663514408b