[INFO] fetching crate codepack 0.11.7... [INFO] linting codepack-0.11.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate codepack 0.11.7 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate codepack 0.11.7 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate codepack 0.11.7 [INFO] tweaked toml for crates.io crate codepack 0.11.7 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate codepack 0.11.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate codepack 0.11.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded getrandom v0.3.2 [INFO] [stderr] Downloaded wit-bindgen-rt v0.39.0 [INFO] [stderr] Downloaded errno v0.3.10 [INFO] [stderr] Downloaded is-terminal v0.4.16 [INFO] [stderr] Downloaded tempfile v3.19.1 [INFO] [stderr] Downloaded dirs-next v2.0.0 [INFO] [stderr] Downloaded anstyle v1.0.10 [INFO] [stderr] Downloaded anstyle-query v1.1.2 [INFO] [stderr] Downloaded colorchoice v1.0.3 [INFO] [stderr] Downloaded clap_lex v0.7.4 [INFO] [stderr] Downloaded libredox v0.1.3 [INFO] [stderr] Downloaded anstyle-wincon v3.0.7 [INFO] [stderr] Downloaded redox_users v0.4.6 [INFO] [stderr] Downloaded bitflags v2.9.0 [INFO] [stderr] Downloaded dirs-sys-next v0.1.2 [INFO] [stderr] Downloaded anstyle-parse v0.2.6 [INFO] [stderr] Downloaded quote v1.0.40 [INFO] [stderr] Downloaded anstream v0.6.18 [INFO] [stderr] Downloaded globset v0.4.16 [INFO] [stderr] Downloaded hermit-abi v0.5.0 [INFO] [stderr] Downloaded console v0.15.11 [INFO] [stderr] Downloaded r-efi v5.2.0 [INFO] [stderr] Downloaded clap_derive v4.5.32 [INFO] [stderr] Downloaded rustversion v1.0.20 [INFO] [stderr] Downloaded csv-core v0.1.12 [INFO] [stderr] Downloaded term v0.7.0 [INFO] [stderr] Downloaded anyhow v1.0.97 [INFO] [stderr] Downloaded proc-macro2 v1.0.94 [INFO] [stderr] Downloaded log v0.4.27 [INFO] [stderr] Downloaded serde v1.0.219 [INFO] [stderr] Downloaded clap v4.5.35 [INFO] [stderr] Downloaded unicode-ident v1.0.18 [INFO] [stderr] Downloaded ignore v0.4.23 [INFO] [stderr] Downloaded serde_derive v1.0.219 [INFO] [stderr] Downloaded wasi v0.14.2+wasi-0.2.4 [INFO] [stderr] Downloaded prettytable v0.10.0 [INFO] [stderr] Downloaded clap_builder v4.5.35 [INFO] [stderr] Downloaded portable-atomic v1.11.0 [INFO] [stderr] Downloaded syn v2.0.100 [INFO] [stderr] Downloaded bstr v1.11.3 [INFO] [stderr] Downloaded rustix v1.0.5 [INFO] [stderr] Downloaded csv v1.3.1 [INFO] [stderr] Downloaded linux-raw-sys v0.9.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b9b904c0ffd1c8f2bcf8959e664156b39feffbdd3bc5978581932093aed8432 [INFO] running `Command { std: "docker" "start" "-a" "8b9b904c0ffd1c8f2bcf8959e664156b39feffbdd3bc5978581932093aed8432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b9b904c0ffd1c8f2bcf8959e664156b39feffbdd3bc5978581932093aed8432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b9b904c0ffd1c8f2bcf8959e664156b39feffbdd3bc5978581932093aed8432", kill_on_drop: false }` [INFO] [stdout] 8b9b904c0ffd1c8f2bcf8959e664156b39feffbdd3bc5978581932093aed8432 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 202643410f8a3afb080c98a784b665e16707bd003392274b8d387ba4398004ab [INFO] running `Command { std: "docker" "start" "-a" "202643410f8a3afb080c98a784b665e16707bd003392274b8d387ba4398004ab", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking clap_builder v4.5.35 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking linux-raw-sys v0.9.3 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.11.3 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Checking globset v0.4.16 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking clap v4.5.35 [INFO] [stderr] Checking codepack v0.11.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | pub const UNSUPPORTED_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | pub const UNSUPPORTED_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 14 | pub const DEFAULT_EXCLUSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:14:42 [INFO] [stdout] | [INFO] [stdout] 14 | pub const DEFAULT_EXCLUSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | pub const UNSUPPORTED_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | pub const UNSUPPORTED_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 14 | pub const DEFAULT_EXCLUSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/constants.rs:14:42 [INFO] [stdout] | [INFO] [stdout] 14 | pub const DEFAULT_EXCLUSIONS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:178:20 [INFO] [stdout] | [INFO] [stdout] 178 | return path [INFO] [stdout] | ____________________^ [INFO] [stdout] 179 | | .extension() [INFO] [stdout] 180 | | .and_then(|ext| ext.to_str()) [INFO] [stdout] 181 | | .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)); [INFO] [stdout] | |______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 181 - .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)); [INFO] [stdout] 181 + .is_some_and(|ext| self.extensions.iter().any(|e| e == ext)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / path.extension() [INFO] [stdout] 221 | | .and_then(|ext| ext.to_str()) [INFO] [stdout] 222 | | .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 222 - .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)) [INFO] [stdout] 222 + .is_some_and(|ext| self.extensions.iter().any(|e| e == ext)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> src/lib.rs:259:32 [INFO] [stdout] | [INFO] [stdout] 259 | return Err(err.into()); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:178:20 [INFO] [stdout] | [INFO] [stdout] 178 | return path [INFO] [stdout] | ____________________^ [INFO] [stdout] 179 | | .extension() [INFO] [stdout] 180 | | .and_then(|ext| ext.to_str()) [INFO] [stdout] 181 | | .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)); [INFO] [stdout] | |______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 181 - .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)); [INFO] [stdout] 181 + .is_some_and(|ext| self.extensions.iter().any(|e| e == ext)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / path.extension() [INFO] [stdout] 221 | | .and_then(|ext| ext.to_str()) [INFO] [stdout] 222 | | .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 222 - .map_or(false, |ext| self.extensions.iter().any(|e| e == ext)) [INFO] [stdout] 222 + .is_some_and(|ext| self.extensions.iter().any(|e| e == ext)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> src/lib.rs:259:32 [INFO] [stdout] | [INFO] [stdout] 259 | return Err(err.into()); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | if !args.output.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.output.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | if !args.output.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.output.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.87s [INFO] running `Command { std: "docker" "inspect" "202643410f8a3afb080c98a784b665e16707bd003392274b8d387ba4398004ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "202643410f8a3afb080c98a784b665e16707bd003392274b8d387ba4398004ab", kill_on_drop: false }` [INFO] [stdout] 202643410f8a3afb080c98a784b665e16707bd003392274b8d387ba4398004ab