[INFO] fetching crate codemelted 26.0.0... [INFO] linting codemelted-26.0.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate codemelted 26.0.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate codemelted 26.0.0 [INFO] finished tweaking crates.io crate codemelted 26.0.0 [INFO] tweaked toml for crates.io crate codemelted 26.0.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate codemelted 26.0.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate codemelted 26.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: file `/workspace/builds/worker-6-tc1/source/codemelted.rs` found to be present in multiple build targets: [INFO] [stderr] * `lib` target `codemelted` [INFO] [stderr] * `bin` target `codemelted` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.94 [INFO] [stderr] Downloaded idna_adapter v1.2.0 [INFO] [stderr] Downloaded windows-strings v0.4.0 [INFO] [stderr] Downloaded smallvec v1.15.0 [INFO] [stderr] Downloaded yoke v0.7.5 [INFO] [stderr] Downloaded iana-time-zone v0.1.63 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.50 [INFO] [stderr] Downloaded sha1_smol v1.0.1 [INFO] [stderr] Downloaded gzip-header v1.0.0 [INFO] [stderr] Downloaded libredox v0.1.3 [INFO] [stderr] Downloaded buf_redux v0.8.4 [INFO] [stderr] Downloaded futures-sink v0.3.31 [INFO] [stderr] Downloaded slab v0.4.9 [INFO] [stderr] Downloaded winapi-util v0.1.9 [INFO] [stderr] Downloaded serde_bytes v0.11.17 [INFO] [stderr] Downloaded async-trait v0.1.88 [INFO] [stderr] Downloaded dbus-tokio v0.7.6 [INFO] [stderr] Downloaded xml-rs v0.8.26 [INFO] [stderr] Downloaded jni v0.19.0 [INFO] [stderr] Downloaded futures v0.3.31 [INFO] [stderr] Downloaded dbus v0.9.7 [INFO] [stderr] Downloaded tower-http v0.6.6 [INFO] [stderr] Downloaded itertools v0.13.0 [INFO] [stderr] Downloaded btleplug v0.11.8 [INFO] [stderr] Downloaded objc2 v0.5.2 [INFO] [stderr] Downloaded hyper v1.6.0 [INFO] [stderr] Downloaded h2 v0.4.10 [INFO] [stderr] Downloaded zerocopy v0.8.25 [INFO] [stderr] Downloaded objc2-foundation v0.2.2 [INFO] [stderr] Downloaded tokio-util v0.7.15 [INFO] [stderr] Downloaded openssl v0.10.72 [INFO] [stderr] Downloaded rustix v1.0.7 [INFO] [stderr] Downloaded iri-string v0.7.9 [INFO] [stderr] Downloaded rustls v0.23.27 [INFO] [stderr] Downloaded reqwest v0.12.24 [INFO] [stderr] Downloaded brotli-decompressor v2.5.1 [INFO] [stderr] Downloaded rusqlite v0.37.0 [INFO] [stderr] Downloaded icu_properties_data v1.5.1 [INFO] [stderr] Downloaded syn v2.0.100 [INFO] [stderr] Downloaded hyper-util v0.1.17 [INFO] [stderr] Downloaded http v1.3.1 [INFO] [stderr] Downloaded objc2-io-kit v0.3.1 [INFO] [stderr] Downloaded jni-utils v0.1.1 [INFO] [stderr] Downloaded json v0.12.4 [INFO] [stderr] Downloaded tracing v0.1.41 [INFO] [stderr] Downloaded openssl-sys v0.9.108 [INFO] [stderr] Downloaded web-sys v0.3.77 [INFO] [stderr] Downloaded security-framework v2.11.1 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.53.0 [INFO] [stderr] Downloaded sysinfo v0.37.2 [INFO] [stderr] Downloaded libc v0.2.177 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.53.0 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.53.0 [INFO] [stderr] Downloaded uuid v1.16.0 [INFO] [stderr] Downloaded windows_i686_gnullvm v0.53.0 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.53.0 [INFO] [stderr] Downloaded rustls-webpki v0.103.3 [INFO] [stderr] Downloaded socket2 v0.5.9 [INFO] [stderr] Downloaded windows_i686_gnu v0.53.0 [INFO] [stderr] Downloaded windows_i686_msvc v0.53.0 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.53.0 [INFO] [stderr] Downloaded tracing-core v0.1.33 [INFO] [stderr] Downloaded rustls-pki-types v1.12.0 [INFO] [stderr] Downloaded objc2-core-foundation v0.3.1 [INFO] [stderr] Downloaded icu_collections v1.5.0 [INFO] [stderr] Downloaded dashmap v5.5.3 [INFO] [stderr] Downloaded schannel v0.1.27 [INFO] [stderr] Downloaded native-tls v0.2.14 [INFO] [stderr] Downloaded bluez-async v0.8.0 [INFO] [stderr] Downloaded block2 v0.5.1 [INFO] [stderr] Downloaded objc-sys v0.3.5 [INFO] [stderr] Downloaded hyper-rustls v0.27.5 [INFO] [stderr] Downloaded security-framework-sys v2.14.0 [INFO] [stderr] Downloaded futures-macro v0.3.31 [INFO] [stderr] Downloaded bumpalo v3.17.0 [INFO] [stderr] Downloaded serde_json v1.0.140 [INFO] [stderr] Downloaded bluez-generated v0.4.0 [INFO] [stderr] Downloaded serde-xml-rs v0.6.0 [INFO] [stderr] Downloaded futures-executor v0.3.31 [INFO] [stderr] Downloaded tokio-rustls v0.26.2 [INFO] [stderr] Downloaded windows-registry v0.5.1 [INFO] [stderr] Downloaded hashbrown v0.15.3 [INFO] [stderr] Downloaded ntapi v0.4.1 [INFO] [stderr] Downloaded serialport v4.8.1 [INFO] [stderr] Downloaded mio v1.0.3 [INFO] [stderr] Downloaded objc2-core-bluetooth v0.2.2 [INFO] [stderr] Downloaded online v4.0.2 [INFO] [stderr] Downloaded futures-io v0.3.31 [INFO] [stderr] Downloaded multipart v0.18.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.25 [INFO] [stderr] Downloaded memchr v2.7.4 [INFO] [stderr] Downloaded bytes v1.10.1 [INFO] [stderr] Downloaded icu_locid v1.5.0 [INFO] [stderr] Downloaded brotli v3.5.0 [INFO] [stderr] Downloaded icu_provider v1.5.0 [INFO] [stderr] Downloaded libdbus-sys v0.2.5 [INFO] [stderr] Downloaded deflate v1.0.0 [INFO] [stderr] Downloaded r-efi v5.2.0 [INFO] [stderr] Downloaded rouille v3.6.2 [INFO] [stderr] Downloaded cc v1.2.18 [INFO] [stderr] Downloaded icu_locid_transform_data v1.5.1 [INFO] [stderr] Downloaded tinystr v0.7.6 [INFO] [stderr] Downloaded rustversion v1.0.20 [INFO] [stderr] Downloaded ascii v1.1.0 [INFO] [stderr] Downloaded tiny_http v0.12.0 [INFO] [stderr] Downloaded mach2 v0.4.2 [INFO] [stderr] Downloaded unescaper v0.1.6 [INFO] [stderr] Downloaded lock_api v0.4.12 [INFO] [stderr] Downloaded parking_lot_core v0.9.10 [INFO] [stderr] Downloaded icu_normalizer_data v1.5.1 [INFO] [stderr] Downloaded litemap v0.7.5 [INFO] [stderr] Downloaded zerovec v0.10.4 [INFO] [stderr] Downloaded tempfile v3.20.0 [INFO] [stderr] Downloaded twoway v0.1.8 [INFO] [stderr] Downloaded io-kit-sys v0.4.1 [INFO] [stderr] Downloaded windows-future v0.2.0 [INFO] [stderr] Downloaded bitflags v2.9.0 [INFO] [stderr] Downloaded icu_locid_transform v1.5.0 [INFO] [stderr] Downloaded fallible-iterator v0.3.0 [INFO] [stderr] Downloaded libudev-sys v0.1.4 [INFO] [stderr] Downloaded simple-mermaid v0.2.0 [INFO] [stderr] Downloaded parking_lot v0.12.3 [INFO] [stderr] Downloaded signal-hook-registry v1.4.5 [INFO] [stderr] Downloaded icu_normalizer v1.5.0 [INFO] [stderr] Downloaded quick-error v1.2.3 [INFO] [stderr] Downloaded safemem v0.3.3 [INFO] [stderr] Downloaded errno v0.3.12 [INFO] [stderr] Downloaded threadpool v1.8.1 [INFO] [stderr] Downloaded fallible-streaming-iterator v0.1.9 [INFO] [stderr] Downloaded windows-interface v0.59.1 [INFO] [stderr] Downloaded windows-core v0.61.0 [INFO] [stderr] Downloaded writeable v0.5.5 [INFO] [stderr] Downloaded hermit-abi v0.3.9 [INFO] [stderr] Downloaded num_cpus v1.16.0 [INFO] [stderr] Downloaded rtoolbox v0.0.2 [INFO] [stderr] Downloaded core-foundation v0.10.0 [INFO] [stderr] Downloaded libudev v0.3.0 [INFO] [stderr] Downloaded windows-collections v0.2.0 [INFO] [stderr] Downloaded windows-implement v0.60.0 [INFO] [stderr] Downloaded windows-link v0.1.1 [INFO] [stderr] Downloaded icu_provider_macros v1.5.0 [INFO] [stderr] Downloaded adler32 v1.2.0 [INFO] [stderr] Downloaded linux-raw-sys v0.9.4 [INFO] [stderr] Downloaded filetime v0.2.25 [INFO] [stderr] Downloaded chunked_transfer v1.5.0 [INFO] [stderr] Downloaded windows-result v0.3.2 [INFO] [stderr] Downloaded windows-numerics v0.2.0 [INFO] [stderr] Downloaded autocfg v1.4.0 [INFO] [stderr] Downloaded redox_syscall v0.5.11 [INFO] [stderr] Downloaded write16 v1.0.0 [INFO] [stderr] Downloaded yoke-derive v0.7.5 [INFO] [stderr] Downloaded zerovec-derive v0.10.3 [INFO] [stderr] Downloaded icu_properties v1.5.1 [INFO] [stderr] Downloaded wasi v0.11.0+wasi-snapshot-preview1 [INFO] [stderr] Downloaded utf16_iter v1.0.5 [INFO] [stderr] Downloaded stable_deref_trait v1.2.0 [INFO] [stderr] Downloaded synstructure v0.13.1 [INFO] [stderr] Downloaded libsqlite3-sys v0.35.0 [INFO] [stderr] Downloaded windows v0.61.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e63ece0886f7aeb7b7a81acf0ac9e258588aa509c435ae9bafd72986ad0585e [INFO] running `Command { std: "docker" "start" "-a" "6e63ece0886f7aeb7b7a81acf0ac9e258588aa509c435ae9bafd72986ad0585e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e63ece0886f7aeb7b7a81acf0ac9e258588aa509c435ae9bafd72986ad0585e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e63ece0886f7aeb7b7a81acf0ac9e258588aa509c435ae9bafd72986ad0585e", kill_on_drop: false }` [INFO] [stdout] 6e63ece0886f7aeb7b7a81acf0ac9e258588aa509c435ae9bafd72986ad0585e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28b0e2f2752ff13e36b286468f67c61e4773abefcdf3b75ac4e1df46a3ffb791 [INFO] running `Command { std: "docker" "start" "-a" "28b0e2f2752ff13e36b286468f67c61e4773abefcdf3b75ac4e1df46a3ffb791", kill_on_drop: false }` [INFO] [stderr] warning: file `/opt/rustwide/workdir/codemelted.rs` found to be present in multiple build targets: [INFO] [stderr] * `lib` target `codemelted` [INFO] [stderr] * `bin` target `codemelted` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Checking litemap v0.7.5 [INFO] [stderr] Compiling cc v1.2.18 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking xml-rs v0.8.26 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking gzip-header v1.0.0 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Compiling openssl-sys v0.9.108 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling libsqlite3-sys v0.35.0 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking rpassword v7.4.0 [INFO] [stderr] Checking sysinfo v0.37.2 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking simple-mermaid v0.2.0 [INFO] [stderr] Checking online v4.0.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking unescaper v0.1.6 [INFO] [stderr] Checking serialport v4.8.1 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking uuid v1.16.0 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking serde_bytes v0.11.17 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking h2 v0.4.10 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking bluez-generated v0.4.0 [INFO] [stderr] Checking dbus-tokio v0.7.6 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking bluez-async v0.8.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking btleplug v0.11.8 [INFO] [stderr] Checking rouille v3.6.2 [INFO] [stderr] Checking rusqlite v0.37.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking codemelted v26.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> codemelted.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | Err(why) => Err(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | std::io::ErrorKind::Other, why.to_string()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 104 ~ Err(why) => Err(std::io::Error::other( [INFO] [stdout] 105 ~ why.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> codemelted.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | Err(why) => Err(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | std::io::ErrorKind::Other, why.to_string()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 104 ~ Err(why) => Err(std::io::Error::other( [INFO] [stdout] 105 ~ why.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:190:7 [INFO] [stdout] | [INFO] [stdout] 190 | / loop { [INFO] [stdout] 191 | | // Block until we get data via post_message. [INFO] [stdout] 192 | | match thread_rx.recv() { [INFO] [stdout] 193 | | Ok(v) => { [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = thread_rx.recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:190:7 [INFO] [stdout] | [INFO] [stdout] 190 | / loop { [INFO] [stdout] 191 | | // Block until we get data via post_message. [INFO] [stdout] 192 | | match thread_rx.recv() { [INFO] [stdout] 193 | | Ok(v) => { [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = thread_rx.recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:449:6 [INFO] [stdout] | [INFO] [stdout] 449 | if choices.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> codemelted.rs:455:11 [INFO] [stdout] | [INFO] [stdout] 455 | _ => &format!("{}", message), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:468:5 [INFO] [stdout] | [INFO] [stdout] 468 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:476:11 [INFO] [stdout] | [INFO] [stdout] 476 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:478:11 [INFO] [stdout] | [INFO] [stdout] 478 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:449:6 [INFO] [stdout] | [INFO] [stdout] 449 | if choices.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> codemelted.rs:455:11 [INFO] [stdout] | [INFO] [stdout] 455 | _ => &format!("{}", message), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:468:5 [INFO] [stdout] | [INFO] [stdout] 468 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:476:11 [INFO] [stdout] | [INFO] [stdout] 476 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:478:11 [INFO] [stdout] | [INFO] [stdout] 478 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:507:3 [INFO] [stdout] | [INFO] [stdout] 507 | String::from(password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:525:3 [INFO] [stdout] | [INFO] [stdout] 525 | String::from(answer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `answer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> codemelted.rs:589:7 [INFO] [stdout] | [INFO] [stdout] 589 | / match sql { [INFO] [stdout] 590 | | // Welp, we were asked to perform the DDL statement. Go do it [INFO] [stdout] 591 | | // and see what happens. [INFO] [stdout] 592 | | Some(stmt) => { [INFO] [stdout] ... | [INFO] [stdout] 600 | | None => {}, [INFO] [stdout] 601 | | } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 589 ~ if let Some(stmt) = sql { [INFO] [stdout] 590 + match conn.execute(stmt, ()) { [INFO] [stdout] 591 + Ok(_) => {}, [INFO] [stdout] 592 + Err(why) => panic!("SyntaxError: db_manage {}", why), [INFO] [stdout] 593 + } [INFO] [stdout] 594 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:507:3 [INFO] [stdout] | [INFO] [stdout] 507 | String::from(password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:525:3 [INFO] [stdout] | [INFO] [stdout] 525 | String::from(answer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `answer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> codemelted.rs:589:7 [INFO] [stdout] | [INFO] [stdout] 589 | / match sql { [INFO] [stdout] 590 | | // Welp, we were asked to perform the DDL statement. Go do it [INFO] [stdout] 591 | | // and see what happens. [INFO] [stdout] 592 | | Some(stmt) => { [INFO] [stdout] ... | [INFO] [stdout] 600 | | None => {}, [INFO] [stdout] 601 | | } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 589 ~ if let Some(stmt) = sql { [INFO] [stdout] 590 + match conn.execute(stmt, ()) { [INFO] [stdout] 591 + Ok(_) => {}, [INFO] [stdout] 592 + Err(why) => panic!("SyntaxError: db_manage {}", why), [INFO] [stdout] 593 + } [INFO] [stdout] 594 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1056:16 [INFO] [stdout] | [INFO] [stdout] 1056 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1056 - Ok(_) => return Ok(()), [INFO] [stdout] 1056 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1057:19 [INFO] [stdout] | [INFO] [stdout] 1057 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1057 - Err(why) => return Err(why), [INFO] [stdout] 1057 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1062:16 [INFO] [stdout] | [INFO] [stdout] 1062 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1062 - Ok(_) => return Ok(()), [INFO] [stdout] 1062 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1063:19 [INFO] [stdout] | [INFO] [stdout] 1063 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1063 - Err(why) => return Err(why), [INFO] [stdout] 1063 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> codemelted.rs:1097:8 [INFO] [stdout] | [INFO] [stdout] 1097 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1102:7 [INFO] [stdout] | [INFO] [stdout] 1102 | let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1102 - let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] 1102 + std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1105:7 [INFO] [stdout] | [INFO] [stdout] 1105 | let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1105 - let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] 1105 + std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1056:16 [INFO] [stdout] | [INFO] [stdout] 1056 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1056 - Ok(_) => return Ok(()), [INFO] [stdout] 1056 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1057:19 [INFO] [stdout] | [INFO] [stdout] 1057 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1057 - Err(why) => return Err(why), [INFO] [stdout] 1057 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1062:16 [INFO] [stdout] | [INFO] [stdout] 1062 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1062 - Ok(_) => return Ok(()), [INFO] [stdout] 1062 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1063:19 [INFO] [stdout] | [INFO] [stdout] 1063 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1063 - Err(why) => return Err(why), [INFO] [stdout] 1063 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> codemelted.rs:1097:8 [INFO] [stdout] | [INFO] [stdout] 1097 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1102:7 [INFO] [stdout] | [INFO] [stdout] 1102 | let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1102 - let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] 1102 + std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1105:7 [INFO] [stdout] | [INFO] [stdout] 1105 | let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1105 - let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] 1105 + std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1309:5 [INFO] [stdout] | [INFO] [stdout] 1309 | / match self.port_ref().name() { [INFO] [stdout] 1310 | | Some(v) => v, [INFO] [stdout] 1311 | | None => String::from(""), [INFO] [stdout] 1312 | | } [INFO] [stdout] | |_____^ help: replace it with: `self.port_ref().name().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1309:5 [INFO] [stdout] | [INFO] [stdout] 1309 | / match self.port_ref().name() { [INFO] [stdout] 1310 | | Some(v) => v, [INFO] [stdout] 1311 | | None => String::from(""), [INFO] [stdout] 1312 | | } [INFO] [stdout] | |_____^ help: replace it with: `self.port_ref().name().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> codemelted.rs:1554:19 [INFO] [stdout] | [INFO] [stdout] 1554 | let central = adapters.into_iter().nth(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `adapters.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> codemelted.rs:1554:19 [INFO] [stdout] | [INFO] [stdout] 1554 | let central = adapters.into_iter().nth(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `adapters.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:1707:22 [INFO] [stdout] | [INFO] [stdout] 1707 | let data_check = String::from(data.to_lowercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `data.to_lowercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1741:3 [INFO] [stdout] | [INFO] [stdout] 1741 | / match answer { [INFO] [stdout] 1742 | | Some(v) => v, [INFO] [stdout] 1743 | | _ => false, [INFO] [stdout] 1744 | | } [INFO] [stdout] | |___^ help: replace it with: `answer.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:1791:3 [INFO] [stdout] | [INFO] [stdout] 1791 | / match answer { [INFO] [stdout] 1792 | | Some(v) => Some(String::from(v)), [INFO] [stdout] 1793 | | _ => None, [INFO] [stdout] 1794 | | } [INFO] [stdout] | |___^ help: try: `answer.map(String::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:1707:22 [INFO] [stdout] | [INFO] [stdout] 1707 | let data_check = String::from(data.to_lowercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `data.to_lowercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1741:3 [INFO] [stdout] | [INFO] [stdout] 1741 | / match answer { [INFO] [stdout] 1742 | | Some(v) => v, [INFO] [stdout] 1743 | | _ => false, [INFO] [stdout] 1744 | | } [INFO] [stdout] | |___^ help: replace it with: `answer.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> codemelted.rs:1920:28 [INFO] [stdout] | [INFO] [stdout] 1920 | let answer = json::parse(&data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:1921:3 [INFO] [stdout] | [INFO] [stdout] 1921 | / match answer { [INFO] [stdout] 1922 | | Ok(v) => Some(v), [INFO] [stdout] 1923 | | _ => None, [INFO] [stdout] 1924 | | } [INFO] [stdout] | |___^ help: replace with: `answer.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:1791:3 [INFO] [stdout] | [INFO] [stdout] 1791 | / match answer { [INFO] [stdout] 1792 | | Some(v) => Some(String::from(v)), [INFO] [stdout] 1793 | | _ => None, [INFO] [stdout] 1794 | | } [INFO] [stdout] | |___^ help: try: `answer.map(String::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> codemelted.rs:1952:16 [INFO] [stdout] | [INFO] [stdout] 1952 | let answer = !(url::Url::parse(data).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `url::Url::parse(data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> codemelted.rs:1920:28 [INFO] [stdout] | [INFO] [stdout] 1920 | let answer = json::parse(&data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:1921:3 [INFO] [stdout] | [INFO] [stdout] 1921 | / match answer { [INFO] [stdout] 1922 | | Ok(v) => Some(v), [INFO] [stdout] 1923 | | _ => None, [INFO] [stdout] 1924 | | } [INFO] [stdout] | |___^ help: replace with: `answer.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> codemelted.rs:1952:16 [INFO] [stdout] | [INFO] [stdout] 1952 | let answer = !(url::Url::parse(data).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `url::Url::parse(data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CComponentMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2213:3 [INFO] [stdout] | [INFO] [stdout] 2213 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2232:9 [INFO] [stdout] | [INFO] [stdout] 2232 | / match v.temperature() { [INFO] [stdout] 2233 | | Some(v) => v, [INFO] [stdout] 2234 | | None => f32::NAN, [INFO] [stdout] 2235 | | } [INFO] [stdout] | |_________^ help: replace with: `v.temperature().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2245:9 [INFO] [stdout] | [INFO] [stdout] 2245 | / match v.max() { [INFO] [stdout] 2246 | | Some(v) => v, [INFO] [stdout] 2247 | | None => f32::NAN, [INFO] [stdout] 2248 | | } [INFO] [stdout] | |_________^ help: replace with: `v.max().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CComponentMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2213:3 [INFO] [stdout] | [INFO] [stdout] 2213 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2259:9 [INFO] [stdout] | [INFO] [stdout] 2259 | / match v.critical() { [INFO] [stdout] 2260 | | Some(v) => v, [INFO] [stdout] 2261 | | None => f32::NAN, [INFO] [stdout] 2262 | | } [INFO] [stdout] | |_________^ help: replace with: `v.critical().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2232:9 [INFO] [stdout] | [INFO] [stdout] 2232 | / match v.temperature() { [INFO] [stdout] 2233 | | Some(v) => v, [INFO] [stdout] 2234 | | None => f32::NAN, [INFO] [stdout] 2235 | | } [INFO] [stdout] | |_________^ help: replace with: `v.temperature().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2245:9 [INFO] [stdout] | [INFO] [stdout] 2245 | / match v.max() { [INFO] [stdout] 2246 | | Some(v) => v, [INFO] [stdout] 2247 | | None => f32::NAN, [INFO] [stdout] 2248 | | } [INFO] [stdout] | |_________^ help: replace with: `v.max().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2259:9 [INFO] [stdout] | [INFO] [stdout] 2259 | / match v.critical() { [INFO] [stdout] 2260 | | Some(v) => v, [INFO] [stdout] 2261 | | None => f32::NAN, [INFO] [stdout] 2262 | | } [INFO] [stdout] | |_________^ help: replace with: `v.critical().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CDiskMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2317:3 [INFO] [stdout] | [INFO] [stdout] 2317 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CDiskMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2317:3 [INFO] [stdout] | [INFO] [stdout] 2317 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2740:5 [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2741:5 [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2743:5 [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> codemelted.rs:2764:28 [INFO] [stdout] | [INFO] [stdout] 2764 | for (pid, _process) in self.sys.processes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 2764 - for (pid, _process) in self.sys.processes() { [INFO] [stdout] 2764 + for pid in self.sys.processes().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2740:5 [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2741:5 [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2743:5 [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> codemelted.rs:2764:28 [INFO] [stdout] | [INFO] [stdout] 2764 | for (pid, _process) in self.sys.processes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 2764 - for (pid, _process) in self.sys.processes() { [INFO] [stdout] 2764 + for pid in self.sys.processes().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:2881:9 [INFO] [stdout] | [INFO] [stdout] 2881 | / match v.open_files() { [INFO] [stdout] 2882 | | Some(v) => v, [INFO] [stdout] 2883 | | None => 0, [INFO] [stdout] 2884 | | } [INFO] [stdout] | |_________^ help: ascribe the type usize and replace your expression with: `v.open_files().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:2881:9 [INFO] [stdout] | [INFO] [stdout] 2881 | / match v.open_files() { [INFO] [stdout] 2882 | | Some(v) => v, [INFO] [stdout] 2883 | | None => 0, [INFO] [stdout] 2884 | | } [INFO] [stdout] | |_________^ help: ascribe the type usize and replace your expression with: `v.open_files().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2994:23 [INFO] [stdout] | [INFO] [stdout] 2994 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2997:19 [INFO] [stdout] | [INFO] [stdout] 2997 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2994:23 [INFO] [stdout] | [INFO] [stdout] 2994 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2997:19 [INFO] [stdout] | [INFO] [stdout] 2997 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:3258:17 [INFO] [stdout] | [INFO] [stdout] 3258 | / match json_parse(&data_as_string) { [INFO] [stdout] 3259 | | Some(v) => Some(v), [INFO] [stdout] 3260 | | None => None, [INFO] [stdout] 3261 | | } [INFO] [stdout] | |_________________^ help: try: `json_parse(&data_as_string).map(|v| v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:3268:34 [INFO] [stdout] | [INFO] [stdout] 3268 | let data_as_string = match resp.text().await { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 3269 | | Ok(v) => Some(v), [INFO] [stdout] 3270 | | Err(_) => None, [INFO] [stdout] 3271 | | }; [INFO] [stdout] | |_____________^ help: replace with: `resp.text().await.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:3258:17 [INFO] [stdout] | [INFO] [stdout] 3258 | / match json_parse(&data_as_string) { [INFO] [stdout] 3259 | | Some(v) => Some(v), [INFO] [stdout] 3260 | | None => None, [INFO] [stdout] 3261 | | } [INFO] [stdout] | |_________________^ help: try: `json_parse(&data_as_string).map(|v| v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:3268:34 [INFO] [stdout] | [INFO] [stdout] 3268 | let data_as_string = match resp.text().await { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 3269 | | Ok(v) => Some(v), [INFO] [stdout] 3270 | | Err(_) => None, [INFO] [stdout] 3271 | | }; [INFO] [stdout] | |_____________^ help: replace with: `resp.text().await.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:3748:7 [INFO] [stdout] | [INFO] [stdout] 3748 | return dist_meters / time_s; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3748 - return dist_meters / time_s; [INFO] [stdout] 3748 + dist_meters / time_s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:3748:7 [INFO] [stdout] | [INFO] [stdout] 3748 | return dist_meters / time_s; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3748 - return dist_meters / time_s; [INFO] [stdout] 3748 + dist_meters / time_s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:3990:7 [INFO] [stdout] | [INFO] [stdout] 3990 | / loop { [INFO] [stdout] 3991 | | match self.protocol_stderr_rx.try_recv() { [INFO] [stdout] 3992 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 3993 | | Err(_) => break, [INFO] [stdout] 3994 | | }; [INFO] [stdout] 3995 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stderr_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:3990:7 [INFO] [stdout] | [INFO] [stdout] 3990 | / loop { [INFO] [stdout] 3991 | | match self.protocol_stderr_rx.try_recv() { [INFO] [stdout] 3992 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 3993 | | Err(_) => break, [INFO] [stdout] 3994 | | }; [INFO] [stdout] 3995 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stderr_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:4004:7 [INFO] [stdout] | [INFO] [stdout] 4004 | / loop { [INFO] [stdout] 4005 | | match self.protocol_stdout_rx.try_recv() { [INFO] [stdout] 4006 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 4007 | | Err(_) => break, [INFO] [stdout] 4008 | | }; [INFO] [stdout] 4009 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stdout_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:4004:7 [INFO] [stdout] | [INFO] [stdout] 4004 | / loop { [INFO] [stdout] 4005 | | match self.protocol_stdout_rx.try_recv() { [INFO] [stdout] 4006 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 4007 | | Err(_) => break, [INFO] [stdout] 4008 | | }; [INFO] [stdout] 4009 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stdout_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4175:3 [INFO] [stdout] | [INFO] [stdout] 4175 | / match sysinfo::System::physical_core_count() { [INFO] [stdout] 4176 | | Some(v) => v, [INFO] [stdout] 4177 | | None => 1, [INFO] [stdout] 4178 | | } [INFO] [stdout] | |___^ help: replace with: `sysinfo::System::physical_core_count().unwrap_or(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:4192:3 [INFO] [stdout] | [INFO] [stdout] 4192 | / match std::env::var(key) { [INFO] [stdout] 4193 | | Ok(val) => Some(val), [INFO] [stdout] 4194 | | Err(_) => None, [INFO] [stdout] 4195 | | } [INFO] [stdout] | |___^ help: replace with: `std::env::var(key).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4175:3 [INFO] [stdout] | [INFO] [stdout] 4175 | / match sysinfo::System::physical_core_count() { [INFO] [stdout] 4176 | | Some(v) => v, [INFO] [stdout] 4177 | | None => 1, [INFO] [stdout] 4178 | | } [INFO] [stdout] | |___^ help: replace with: `sysinfo::System::physical_core_count().unwrap_or(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:4192:3 [INFO] [stdout] | [INFO] [stdout] 4192 | / match std::env::var(key) { [INFO] [stdout] 4193 | | Ok(val) => Some(val), [INFO] [stdout] 4194 | | Err(_) => None, [INFO] [stdout] 4195 | | } [INFO] [stdout] | |___^ help: replace with: `std::env::var(key).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:4422:12 [INFO] [stdout] | [INFO] [stdout] 4422 | if contents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:4422:12 [INFO] [stdout] | [INFO] [stdout] 4422 | if contents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4587:22 [INFO] [stdout] | [INFO] [stdout] 4587 | fn cli_async(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4587 - fn cli_async(params: &Vec) { [INFO] [stdout] 4587 + fn cli_async(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4587:22 [INFO] [stdout] | [INFO] [stdout] 4587 | fn cli_async(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4587 - fn cli_async(params: &Vec) { [INFO] [stdout] 4587 + fn cli_async(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:4595:15 [INFO] [stdout] | [INFO] [stdout] 4595 | / match v.as_u64() { [INFO] [stdout] 4596 | | Some(delay_ms) => delay_ms, [INFO] [stdout] 4597 | | None => 0, [INFO] [stdout] 4598 | | } [INFO] [stdout] | |_______________^ help: ascribe the type u64 and replace your expression with: `v.as_u64().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:4595:15 [INFO] [stdout] | [INFO] [stdout] 4595 | / match v.as_u64() { [INFO] [stdout] 4596 | | Some(delay_ms) => delay_ms, [INFO] [stdout] 4597 | | None => 0, [INFO] [stdout] 4598 | | } [INFO] [stdout] | |_______________^ help: ascribe the type u64 and replace your expression with: `v.as_u64().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4612:24 [INFO] [stdout] | [INFO] [stdout] 4612 | fn cli_console(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4612 - fn cli_console(params: &Vec) { [INFO] [stdout] 4612 + fn cli_console(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4612:24 [INFO] [stdout] | [INFO] [stdout] 4612 | fn cli_console(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4612 - fn cli_console(params: &Vec) { [INFO] [stdout] 4612 + fn cli_console(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4652:20 [INFO] [stdout] | [INFO] [stdout] 4652 | fn cli_npu(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4652 - fn cli_npu(params: &Vec) { [INFO] [stdout] 4652 + fn cli_npu(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4652:20 [INFO] [stdout] | [INFO] [stdout] 4652 | fn cli_npu(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4652 - fn cli_npu(params: &Vec) { [INFO] [stdout] 4652 + fn cli_npu(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4677:22 [INFO] [stdout] | [INFO] [stdout] 4677 | Some(v) => match v.as_f64() { [INFO] [stdout] | ______________________^ [INFO] [stdout] 4678 | | Some(v) => v, [INFO] [stdout] 4679 | | None => f64::NAN [INFO] [stdout] 4680 | | }, [INFO] [stdout] | |___________^ help: replace with: `v.as_f64().unwrap_or(f64::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4677:22 [INFO] [stdout] | [INFO] [stdout] 4677 | Some(v) => match v.as_f64() { [INFO] [stdout] | ______________________^ [INFO] [stdout] 4678 | | Some(v) => v, [INFO] [stdout] 4679 | | None => f64::NAN [INFO] [stdout] 4680 | | }, [INFO] [stdout] | |___________^ help: replace with: `v.as_f64().unwrap_or(f64::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> codemelted.rs:4790:5 [INFO] [stdout] | [INFO] [stdout] 4790 | assert_eq!(true, f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4790 - assert_eq!(true, f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] 4790 + assert!(f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting float literal to `f64` is unnecessary [INFO] [stdout] --> codemelted.rs:4790:34 [INFO] [stdout] | [INFO] [stdout] 4790 | assert_eq!(true, f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(-1.0_f64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> codemelted.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | Err(why) => Err(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | std::io::ErrorKind::Other, why.to_string()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 104 ~ Err(why) => Err(std::io::Error::other( [INFO] [stdout] 105 ~ why.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:190:7 [INFO] [stdout] | [INFO] [stdout] 190 | / loop { [INFO] [stdout] 191 | | // Block until we get data via post_message. [INFO] [stdout] 192 | | match thread_rx.recv() { [INFO] [stdout] 193 | | Ok(v) => { [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = thread_rx.recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:449:6 [INFO] [stdout] | [INFO] [stdout] 449 | if choices.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> codemelted.rs:455:11 [INFO] [stdout] | [INFO] [stdout] 455 | _ => &format!("{}", message), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:468:5 [INFO] [stdout] | [INFO] [stdout] 468 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:476:11 [INFO] [stdout] | [INFO] [stdout] 476 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:478:11 [INFO] [stdout] | [INFO] [stdout] 478 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:507:3 [INFO] [stdout] | [INFO] [stdout] 507 | String::from(password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:525:3 [INFO] [stdout] | [INFO] [stdout] 525 | String::from(answer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `answer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> codemelted.rs:589:7 [INFO] [stdout] | [INFO] [stdout] 589 | / match sql { [INFO] [stdout] 590 | | // Welp, we were asked to perform the DDL statement. Go do it [INFO] [stdout] 591 | | // and see what happens. [INFO] [stdout] 592 | | Some(stmt) => { [INFO] [stdout] ... | [INFO] [stdout] 600 | | None => {}, [INFO] [stdout] 601 | | } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 589 ~ if let Some(stmt) = sql { [INFO] [stdout] 590 + match conn.execute(stmt, ()) { [INFO] [stdout] 591 + Ok(_) => {}, [INFO] [stdout] 592 + Err(why) => panic!("SyntaxError: db_manage {}", why), [INFO] [stdout] 593 + } [INFO] [stdout] 594 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1056:16 [INFO] [stdout] | [INFO] [stdout] 1056 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1056 - Ok(_) => return Ok(()), [INFO] [stdout] 1056 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1057:19 [INFO] [stdout] | [INFO] [stdout] 1057 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1057 - Err(why) => return Err(why), [INFO] [stdout] 1057 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1062:16 [INFO] [stdout] | [INFO] [stdout] 1062 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1062 - Ok(_) => return Ok(()), [INFO] [stdout] 1062 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1063:19 [INFO] [stdout] | [INFO] [stdout] 1063 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1063 - Err(why) => return Err(why), [INFO] [stdout] 1063 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> codemelted.rs:1097:8 [INFO] [stdout] | [INFO] [stdout] 1097 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1102:7 [INFO] [stdout] | [INFO] [stdout] 1102 | let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1102 - let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] 1102 + std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1105:7 [INFO] [stdout] | [INFO] [stdout] 1105 | let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1105 - let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] 1105 + std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1309:5 [INFO] [stdout] | [INFO] [stdout] 1309 | / match self.port_ref().name() { [INFO] [stdout] 1310 | | Some(v) => v, [INFO] [stdout] 1311 | | None => String::from(""), [INFO] [stdout] 1312 | | } [INFO] [stdout] | |_____^ help: replace it with: `self.port_ref().name().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> codemelted.rs:1554:19 [INFO] [stdout] | [INFO] [stdout] 1554 | let central = adapters.into_iter().nth(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `adapters.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:1707:22 [INFO] [stdout] | [INFO] [stdout] 1707 | let data_check = String::from(data.to_lowercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `data.to_lowercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1741:3 [INFO] [stdout] | [INFO] [stdout] 1741 | / match answer { [INFO] [stdout] 1742 | | Some(v) => v, [INFO] [stdout] 1743 | | _ => false, [INFO] [stdout] 1744 | | } [INFO] [stdout] | |___^ help: replace it with: `answer.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:1791:3 [INFO] [stdout] | [INFO] [stdout] 1791 | / match answer { [INFO] [stdout] 1792 | | Some(v) => Some(String::from(v)), [INFO] [stdout] 1793 | | _ => None, [INFO] [stdout] 1794 | | } [INFO] [stdout] | |___^ help: try: `answer.map(String::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> codemelted.rs:1920:28 [INFO] [stdout] | [INFO] [stdout] 1920 | let answer = json::parse(&data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:1921:3 [INFO] [stdout] | [INFO] [stdout] 1921 | / match answer { [INFO] [stdout] 1922 | | Ok(v) => Some(v), [INFO] [stdout] 1923 | | _ => None, [INFO] [stdout] 1924 | | } [INFO] [stdout] | |___^ help: replace with: `answer.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> codemelted.rs:1952:16 [INFO] [stdout] | [INFO] [stdout] 1952 | let answer = !(url::Url::parse(data).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `url::Url::parse(data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CComponentMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2213:3 [INFO] [stdout] | [INFO] [stdout] 2213 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2232:9 [INFO] [stdout] | [INFO] [stdout] 2232 | / match v.temperature() { [INFO] [stdout] 2233 | | Some(v) => v, [INFO] [stdout] 2234 | | None => f32::NAN, [INFO] [stdout] 2235 | | } [INFO] [stdout] | |_________^ help: replace with: `v.temperature().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2245:9 [INFO] [stdout] | [INFO] [stdout] 2245 | / match v.max() { [INFO] [stdout] 2246 | | Some(v) => v, [INFO] [stdout] 2247 | | None => f32::NAN, [INFO] [stdout] 2248 | | } [INFO] [stdout] | |_________^ help: replace with: `v.max().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2259:9 [INFO] [stdout] | [INFO] [stdout] 2259 | / match v.critical() { [INFO] [stdout] 2260 | | Some(v) => v, [INFO] [stdout] 2261 | | None => f32::NAN, [INFO] [stdout] 2262 | | } [INFO] [stdout] | |_________^ help: replace with: `v.critical().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CDiskMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2317:3 [INFO] [stdout] | [INFO] [stdout] 2317 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2740:5 [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2741:5 [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2743:5 [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> codemelted.rs:2764:28 [INFO] [stdout] | [INFO] [stdout] 2764 | for (pid, _process) in self.sys.processes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 2764 - for (pid, _process) in self.sys.processes() { [INFO] [stdout] 2764 + for pid in self.sys.processes().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:2881:9 [INFO] [stdout] | [INFO] [stdout] 2881 | / match v.open_files() { [INFO] [stdout] 2882 | | Some(v) => v, [INFO] [stdout] 2883 | | None => 0, [INFO] [stdout] 2884 | | } [INFO] [stdout] | |_________^ help: ascribe the type usize and replace your expression with: `v.open_files().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2994:23 [INFO] [stdout] | [INFO] [stdout] 2994 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2997:19 [INFO] [stdout] | [INFO] [stdout] 2997 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:3258:17 [INFO] [stdout] | [INFO] [stdout] 3258 | / match json_parse(&data_as_string) { [INFO] [stdout] 3259 | | Some(v) => Some(v), [INFO] [stdout] 3260 | | None => None, [INFO] [stdout] 3261 | | } [INFO] [stdout] | |_________________^ help: try: `json_parse(&data_as_string).map(|v| v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:3268:34 [INFO] [stdout] | [INFO] [stdout] 3268 | let data_as_string = match resp.text().await { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 3269 | | Ok(v) => Some(v), [INFO] [stdout] 3270 | | Err(_) => None, [INFO] [stdout] 3271 | | }; [INFO] [stdout] | |_____________^ help: replace with: `resp.text().await.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:3748:7 [INFO] [stdout] | [INFO] [stdout] 3748 | return dist_meters / time_s; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3748 - return dist_meters / time_s; [INFO] [stdout] 3748 + dist_meters / time_s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:3990:7 [INFO] [stdout] | [INFO] [stdout] 3990 | / loop { [INFO] [stdout] 3991 | | match self.protocol_stderr_rx.try_recv() { [INFO] [stdout] 3992 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 3993 | | Err(_) => break, [INFO] [stdout] 3994 | | }; [INFO] [stdout] 3995 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stderr_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:4004:7 [INFO] [stdout] | [INFO] [stdout] 4004 | / loop { [INFO] [stdout] 4005 | | match self.protocol_stdout_rx.try_recv() { [INFO] [stdout] 4006 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 4007 | | Err(_) => break, [INFO] [stdout] 4008 | | }; [INFO] [stdout] 4009 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stdout_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4175:3 [INFO] [stdout] | [INFO] [stdout] 4175 | / match sysinfo::System::physical_core_count() { [INFO] [stdout] 4176 | | Some(v) => v, [INFO] [stdout] 4177 | | None => 1, [INFO] [stdout] 4178 | | } [INFO] [stdout] | |___^ help: replace with: `sysinfo::System::physical_core_count().unwrap_or(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:4192:3 [INFO] [stdout] | [INFO] [stdout] 4192 | / match std::env::var(key) { [INFO] [stdout] 4193 | | Ok(val) => Some(val), [INFO] [stdout] 4194 | | Err(_) => None, [INFO] [stdout] 4195 | | } [INFO] [stdout] | |___^ help: replace with: `std::env::var(key).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:4422:12 [INFO] [stdout] | [INFO] [stdout] 4422 | if contents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4587:22 [INFO] [stdout] | [INFO] [stdout] 4587 | fn cli_async(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4587 - fn cli_async(params: &Vec) { [INFO] [stdout] 4587 + fn cli_async(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:4595:15 [INFO] [stdout] | [INFO] [stdout] 4595 | / match v.as_u64() { [INFO] [stdout] 4596 | | Some(delay_ms) => delay_ms, [INFO] [stdout] 4597 | | None => 0, [INFO] [stdout] 4598 | | } [INFO] [stdout] | |_______________^ help: ascribe the type u64 and replace your expression with: `v.as_u64().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4612:24 [INFO] [stdout] | [INFO] [stdout] 4612 | fn cli_console(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4612 - fn cli_console(params: &Vec) { [INFO] [stdout] 4612 + fn cli_console(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4652:20 [INFO] [stdout] | [INFO] [stdout] 4652 | fn cli_npu(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4652 - fn cli_npu(params: &Vec) { [INFO] [stdout] 4652 + fn cli_npu(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4677:22 [INFO] [stdout] | [INFO] [stdout] 4677 | Some(v) => match v.as_f64() { [INFO] [stdout] | ______________________^ [INFO] [stdout] 4678 | | Some(v) => v, [INFO] [stdout] 4679 | | None => f64::NAN [INFO] [stdout] 4680 | | }, [INFO] [stdout] | |___________^ help: replace with: `v.as_f64().unwrap_or(f64::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> codemelted.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | Err(why) => Err(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | std::io::ErrorKind::Other, why.to_string()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 104 ~ Err(why) => Err(std::io::Error::other( [INFO] [stdout] 105 ~ why.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:190:7 [INFO] [stdout] | [INFO] [stdout] 190 | / loop { [INFO] [stdout] 191 | | // Block until we get data via post_message. [INFO] [stdout] 192 | | match thread_rx.recv() { [INFO] [stdout] 193 | | Ok(v) => { [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = thread_rx.recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:449:6 [INFO] [stdout] | [INFO] [stdout] 449 | if choices.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> codemelted.rs:455:11 [INFO] [stdout] | [INFO] [stdout] 455 | _ => &format!("{}", message), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:468:5 [INFO] [stdout] | [INFO] [stdout] 468 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:476:11 [INFO] [stdout] | [INFO] [stdout] 476 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:478:11 [INFO] [stdout] | [INFO] [stdout] 478 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:482:9 [INFO] [stdout] | [INFO] [stdout] 482 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> codemelted.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:507:3 [INFO] [stdout] | [INFO] [stdout] 507 | String::from(password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:525:3 [INFO] [stdout] | [INFO] [stdout] 525 | String::from(answer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `answer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> codemelted.rs:589:7 [INFO] [stdout] | [INFO] [stdout] 589 | / match sql { [INFO] [stdout] 590 | | // Welp, we were asked to perform the DDL statement. Go do it [INFO] [stdout] 591 | | // and see what happens. [INFO] [stdout] 592 | | Some(stmt) => { [INFO] [stdout] ... | [INFO] [stdout] 600 | | None => {}, [INFO] [stdout] 601 | | } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 589 ~ if let Some(stmt) = sql { [INFO] [stdout] 590 + match conn.execute(stmt, ()) { [INFO] [stdout] 591 + Ok(_) => {}, [INFO] [stdout] 592 + Err(why) => panic!("SyntaxError: db_manage {}", why), [INFO] [stdout] 593 + } [INFO] [stdout] 594 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1056:16 [INFO] [stdout] | [INFO] [stdout] 1056 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1056 - Ok(_) => return Ok(()), [INFO] [stdout] 1056 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1057:19 [INFO] [stdout] | [INFO] [stdout] 1057 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1057 - Err(why) => return Err(why), [INFO] [stdout] 1057 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1062:16 [INFO] [stdout] | [INFO] [stdout] 1062 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1062 - Ok(_) => return Ok(()), [INFO] [stdout] 1062 + Ok(_) => Ok(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:1063:19 [INFO] [stdout] | [INFO] [stdout] 1063 | Err(why) => return Err(why), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1063 - Err(why) => return Err(why), [INFO] [stdout] 1063 + Err(why) => Err(why), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> codemelted.rs:1097:8 [INFO] [stdout] | [INFO] [stdout] 1097 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1102:7 [INFO] [stdout] | [INFO] [stdout] 1102 | let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1102 - let _ = std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] 1102 + std::io::Write::write_all(&mut file, &data)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> codemelted.rs:1105:7 [INFO] [stdout] | [INFO] [stdout] 1105 | let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 1105 - let _ = std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] 1105 + std::io::Write::write_all(&mut file, data.as_bytes())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1309:5 [INFO] [stdout] | [INFO] [stdout] 1309 | / match self.port_ref().name() { [INFO] [stdout] 1310 | | Some(v) => v, [INFO] [stdout] 1311 | | None => String::from(""), [INFO] [stdout] 1312 | | } [INFO] [stdout] | |_____^ help: replace it with: `self.port_ref().name().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> codemelted.rs:1554:19 [INFO] [stdout] | [INFO] [stdout] 1554 | let central = adapters.into_iter().nth(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `adapters.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> codemelted.rs:1707:22 [INFO] [stdout] | [INFO] [stdout] 1707 | let data_check = String::from(data.to_lowercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `data.to_lowercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:1741:3 [INFO] [stdout] | [INFO] [stdout] 1741 | / match answer { [INFO] [stdout] 1742 | | Some(v) => v, [INFO] [stdout] 1743 | | _ => false, [INFO] [stdout] 1744 | | } [INFO] [stdout] | |___^ help: replace it with: `answer.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:1791:3 [INFO] [stdout] | [INFO] [stdout] 1791 | / match answer { [INFO] [stdout] 1792 | | Some(v) => Some(String::from(v)), [INFO] [stdout] 1793 | | _ => None, [INFO] [stdout] 1794 | | } [INFO] [stdout] | |___^ help: try: `answer.map(String::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> codemelted.rs:1920:28 [INFO] [stdout] | [INFO] [stdout] 1920 | let answer = json::parse(&data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:1921:3 [INFO] [stdout] | [INFO] [stdout] 1921 | / match answer { [INFO] [stdout] 1922 | | Ok(v) => Some(v), [INFO] [stdout] 1923 | | _ => None, [INFO] [stdout] 1924 | | } [INFO] [stdout] | |___^ help: replace with: `answer.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> codemelted.rs:1952:16 [INFO] [stdout] | [INFO] [stdout] 1952 | let answer = !(url::Url::parse(data).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `url::Url::parse(data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CComponentMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2213:3 [INFO] [stdout] | [INFO] [stdout] 2213 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2232:9 [INFO] [stdout] | [INFO] [stdout] 2232 | / match v.temperature() { [INFO] [stdout] 2233 | | Some(v) => v, [INFO] [stdout] 2234 | | None => f32::NAN, [INFO] [stdout] 2235 | | } [INFO] [stdout] | |_________^ help: replace with: `v.temperature().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2245:9 [INFO] [stdout] | [INFO] [stdout] 2245 | / match v.max() { [INFO] [stdout] 2246 | | Some(v) => v, [INFO] [stdout] 2247 | | None => f32::NAN, [INFO] [stdout] 2248 | | } [INFO] [stdout] | |_________^ help: replace with: `v.max().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:2259:9 [INFO] [stdout] | [INFO] [stdout] 2259 | / match v.critical() { [INFO] [stdout] 2260 | | Some(v) => v, [INFO] [stdout] 2261 | | None => f32::NAN, [INFO] [stdout] 2262 | | } [INFO] [stdout] | |_________^ help: replace with: `v.critical().unwrap_or(f32::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CDiskMonitor` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> codemelted.rs:2317:3 [INFO] [stdout] | [INFO] [stdout] 2317 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2740:5 [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2740 | /// the user running the application. If a panic occurs that may be the [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2741:5 [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2741 | /// reason._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> codemelted.rs:2743:5 [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2743 | /// if a String return type or 0 if a integer based field._ [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> codemelted.rs:2764:28 [INFO] [stdout] | [INFO] [stdout] 2764 | for (pid, _process) in self.sys.processes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 2764 - for (pid, _process) in self.sys.processes() { [INFO] [stdout] 2764 + for pid in self.sys.processes().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:2881:9 [INFO] [stdout] | [INFO] [stdout] 2881 | / match v.open_files() { [INFO] [stdout] 2882 | | Some(v) => v, [INFO] [stdout] 2883 | | None => 0, [INFO] [stdout] 2884 | | } [INFO] [stdout] | |_________^ help: ascribe the type usize and replace your expression with: `v.open_files().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2994:23 [INFO] [stdout] | [INFO] [stdout] 2994 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> codemelted.rs:2997:19 [INFO] [stdout] | [INFO] [stdout] 2997 | None => -1 as i32, [INFO] [stdout] | ^^^^^^^^^ help: try: `-1_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> codemelted.rs:3258:17 [INFO] [stdout] | [INFO] [stdout] 3258 | / match json_parse(&data_as_string) { [INFO] [stdout] 3259 | | Some(v) => Some(v), [INFO] [stdout] 3260 | | None => None, [INFO] [stdout] 3261 | | } [INFO] [stdout] | |_________________^ help: try: `json_parse(&data_as_string).map(|v| v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:3268:34 [INFO] [stdout] | [INFO] [stdout] 3268 | let data_as_string = match resp.text().await { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 3269 | | Ok(v) => Some(v), [INFO] [stdout] 3270 | | Err(_) => None, [INFO] [stdout] 3271 | | }; [INFO] [stdout] | |_____________^ help: replace with: `resp.text().await.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> codemelted.rs:3748:7 [INFO] [stdout] | [INFO] [stdout] 3748 | return dist_meters / time_s; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 3748 - return dist_meters / time_s; [INFO] [stdout] 3748 + dist_meters / time_s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:3990:7 [INFO] [stdout] | [INFO] [stdout] 3990 | / loop { [INFO] [stdout] 3991 | | match self.protocol_stderr_rx.try_recv() { [INFO] [stdout] 3992 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 3993 | | Err(_) => break, [INFO] [stdout] 3994 | | }; [INFO] [stdout] 3995 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stderr_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> codemelted.rs:4004:7 [INFO] [stdout] | [INFO] [stdout] 4004 | / loop { [INFO] [stdout] 4005 | | match self.protocol_stdout_rx.try_recv() { [INFO] [stdout] 4006 | | Ok(v) => rx_buf.push(v), [INFO] [stdout] 4007 | | Err(_) => break, [INFO] [stdout] 4008 | | }; [INFO] [stdout] 4009 | | } [INFO] [stdout] | |_______^ help: try: `while let Ok(v) = self.protocol_stdout_rx.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4175:3 [INFO] [stdout] | [INFO] [stdout] 4175 | / match sysinfo::System::physical_core_count() { [INFO] [stdout] 4176 | | Some(v) => v, [INFO] [stdout] 4177 | | None => 1, [INFO] [stdout] 4178 | | } [INFO] [stdout] | |___^ help: replace with: `sysinfo::System::physical_core_count().unwrap_or(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> codemelted.rs:4192:3 [INFO] [stdout] | [INFO] [stdout] 4192 | / match std::env::var(key) { [INFO] [stdout] 4193 | | Ok(val) => Some(val), [INFO] [stdout] 4194 | | Err(_) => None, [INFO] [stdout] 4195 | | } [INFO] [stdout] | |___^ help: replace with: `std::env::var(key).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> codemelted.rs:4422:12 [INFO] [stdout] | [INFO] [stdout] 4422 | if contents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4587:22 [INFO] [stdout] | [INFO] [stdout] 4587 | fn cli_async(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4587 - fn cli_async(params: &Vec) { [INFO] [stdout] 4587 + fn cli_async(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> codemelted.rs:4595:15 [INFO] [stdout] | [INFO] [stdout] 4595 | / match v.as_u64() { [INFO] [stdout] 4596 | | Some(delay_ms) => delay_ms, [INFO] [stdout] 4597 | | None => 0, [INFO] [stdout] 4598 | | } [INFO] [stdout] | |_______________^ help: ascribe the type u64 and replace your expression with: `v.as_u64().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4612:24 [INFO] [stdout] | [INFO] [stdout] 4612 | fn cli_console(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4612 - fn cli_console(params: &Vec) { [INFO] [stdout] 4612 + fn cli_console(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> codemelted.rs:4652:20 [INFO] [stdout] | [INFO] [stdout] 4652 | fn cli_npu(params: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4652 - fn cli_npu(params: &Vec) { [INFO] [stdout] 4652 + fn cli_npu(params: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> codemelted.rs:4677:22 [INFO] [stdout] | [INFO] [stdout] 4677 | Some(v) => match v.as_f64() { [INFO] [stdout] | ______________________^ [INFO] [stdout] 4678 | | Some(v) => v, [INFO] [stdout] 4679 | | None => f64::NAN [INFO] [stdout] 4680 | | }, [INFO] [stdout] | |___________^ help: replace with: `v.as_f64().unwrap_or(f64::NAN)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> codemelted.rs:4790:5 [INFO] [stdout] | [INFO] [stdout] 4790 | assert_eq!(true, f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 4790 - assert_eq!(true, f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] 4790 + assert!(f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting float literal to `f64` is unnecessary [INFO] [stdout] --> codemelted.rs:4790:34 [INFO] [stdout] | [INFO] [stdout] 4790 | assert_eq!(true, f64::is_nan((-1.0 as f64).sqrt())); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(-1.0_f64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 04s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, multipart v0.18.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "28b0e2f2752ff13e36b286468f67c61e4773abefcdf3b75ac4e1df46a3ffb791", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28b0e2f2752ff13e36b286468f67c61e4773abefcdf3b75ac4e1df46a3ffb791", kill_on_drop: false }` [INFO] [stdout] 28b0e2f2752ff13e36b286468f67c61e4773abefcdf3b75ac4e1df46a3ffb791