[INFO] fetching crate codegridfx 0.9.0... [INFO] linting codegridfx-0.9.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate codegridfx 0.9.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate codegridfx 0.9.0 [INFO] finished tweaking crates.io crate codegridfx 0.9.0 [INFO] tweaked toml for crates.io crate codegridfx 0.9.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate codegridfx 0.9.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate codegridfx 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded vectorize v0.2.0 [INFO] [stderr] Downloaded approx v0.5.1 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.106 [INFO] [stderr] Downloaded dpi v0.1.2 [INFO] [stderr] Downloaded core-graphics-types v0.1.3 [INFO] [stderr] Downloaded foreign-types-shared v0.3.1 [INFO] [stderr] Downloaded foreign-types v0.5.0 [INFO] [stderr] Downloaded cursor-icon v1.2.0 [INFO] [stderr] Downloaded as-raw-xcb-connection v1.0.1 [INFO] [stderr] Downloaded foreign-types-macros v0.2.3 [INFO] [stderr] Downloaded quote v1.0.43 [INFO] [stderr] Downloaded toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Downloaded core-graphics v0.23.2 [INFO] [stderr] Downloaded owned_ttf_parser v0.25.1 [INFO] [stderr] Downloaded wayland-csd-frame v0.3.0 [INFO] [stderr] Downloaded simd_helpers v0.1.0 [INFO] [stderr] Downloaded interpolate_name v0.2.4 [INFO] [stderr] Downloaded new_debug_unreachable v1.0.6 [INFO] [stderr] Downloaded equator-macro v0.4.2 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Downloaded drm-fourcc v2.2.0 [INFO] [stderr] Downloaded avif-serialize v0.8.6 [INFO] [stderr] Downloaded color_quant v1.1.0 [INFO] [stderr] Downloaded ravif v0.12.0 [INFO] [stderr] Downloaded av1-grain v0.2.5 [INFO] [stderr] Downloaded bit_field v0.10.3 [INFO] [stderr] Downloaded error-code v3.3.2 [INFO] [stderr] Downloaded clipboard-win v5.4.1 [INFO] [stderr] Downloaded arboard v3.6.1 [INFO] [stderr] Downloaded nom v8.0.0 [INFO] [stderr] Downloaded moxcms v0.7.11 [INFO] [stderr] Downloaded rayon v1.11.0 [INFO] [stderr] Downloaded markdown v1.0.0 [INFO] [stderr] Downloaded scoped-tls v1.0.1 [INFO] [stderr] Downloaded num_enum_derive v0.7.5 [INFO] [stderr] Downloaded image v0.25.9 [INFO] [stderr] Downloaded byteorder-lite v0.1.0 [INFO] [stderr] Downloaded as-slice v0.2.1 [INFO] [stderr] Downloaded bstr v1.12.1 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.10 [INFO] [stderr] Downloaded arg_enum_proc_macro v0.3.4 [INFO] [stderr] Downloaded av-scenechange v0.14.1 [INFO] [stderr] Downloaded objc2-core-data v0.2.2 [INFO] [stderr] Downloaded objc2-core-image v0.2.2 [INFO] [stderr] Downloaded hermit-abi v0.5.2 [INFO] [stderr] Downloaded objc2-app-kit v0.3.2 [INFO] [stderr] Downloaded objc2-contacts v0.2.2 [INFO] [stderr] Downloaded uuid-macro-internal v1.19.0 [INFO] [stderr] Downloaded redox_syscall v0.4.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.105 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.56 [INFO] [stderr] Downloaded onig_sys v69.9.1 [INFO] [stderr] Downloaded objc2-cloud-kit v0.2.2 [INFO] [stderr] Downloaded wayland-scanner v0.31.8 [INFO] [stderr] Downloaded syntect v5.3.0 [INFO] [stderr] Downloaded gif v0.14.1 [INFO] [stderr] Downloaded concurrent-queue v2.5.0 [INFO] [stderr] Downloaded ttf-parser v0.21.1 [INFO] [stderr] Downloaded fontdue v0.9.3 [INFO] [stderr] Downloaded tiny-skia-path v0.11.4 [INFO] [stderr] Downloaded js-sys v0.3.83 [INFO] [stderr] Downloaded rust-embed v8.9.0 [INFO] [stderr] Downloaded objc2-metal v0.2.2 [INFO] [stderr] Downloaded wayland-backend v0.3.12 [INFO] [stderr] Downloaded image-webp v0.2.4 [INFO] [stderr] Downloaded toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Downloaded cc v1.2.52 [INFO] [stderr] Downloaded qoi v0.4.1 [INFO] [stderr] Downloaded calloop v0.13.0 [INFO] [stderr] Downloaded ndk v0.9.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.33 [INFO] [stderr] Downloaded xkeysym v0.2.1 [INFO] [stderr] Downloaded smithay-client-toolkit v0.19.2 [INFO] [stderr] Downloaded wasip2 v1.0.1+wasi-0.2.4 [INFO] [stderr] Downloaded vek v0.17.2 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Downloaded wayland-protocols v0.32.10 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.10 [INFO] [stderr] Downloaded x11-dl v2.21.0 [INFO] [stderr] Downloaded wayland-client v0.31.12 [INFO] [stderr] Downloaded objc2 v0.5.2 [INFO] [stderr] Downloaded x11rb v0.13.2 [INFO] [stderr] Downloaded rav1e v0.8.1 [INFO] [stderr] Downloaded exr v1.74.0 [INFO] [stderr] Downloaded objc2-foundation v0.2.2 [INFO] [stderr] Downloaded zerocopy v0.8.33 [INFO] [stderr] Downloaded objc2-ui-kit v0.2.2 [INFO] [stderr] Downloaded syn v2.0.114 [INFO] [stderr] Downloaded objc2-app-kit v0.2.2 [INFO] [stderr] Downloaded tiff v0.10.3 [INFO] [stderr] Downloaded rustix v0.38.44 [INFO] [stderr] Downloaded ttf-parser v0.25.1 [INFO] [stderr] Downloaded tiny-skia v0.11.4 [INFO] [stderr] Downloaded quick-xml v0.38.4 [INFO] [stderr] Downloaded wit-bindgen v0.46.0 [INFO] [stderr] Downloaded pin-project v1.1.10 [INFO] [stderr] Downloaded bytemuck v1.24.0 [INFO] [stderr] Downloaded x11rb-protocol v0.13.2 [INFO] [stderr] Downloaded sctk-adwaita v0.10.1 [INFO] [stderr] Downloaded polling v3.11.0 [INFO] [stderr] Downloaded zeno v0.3.3 [INFO] [stderr] Downloaded rand_core v0.9.3 [INFO] [stderr] Downloaded pin-project-internal v1.1.10 [INFO] [stderr] Downloaded winit v0.30.12 [INFO] [stderr] Downloaded ab_glyph v0.2.32 [INFO] [stderr] Downloaded web-sys v0.3.83 [INFO] [stderr] Downloaded linux-raw-sys v0.6.5 [INFO] [stderr] Downloaded memmap2 v0.9.9 [INFO] [stderr] Downloaded bitflags v2.10.0 [INFO] [stderr] Downloaded uuid v1.19.0 [INFO] [stderr] Downloaded find-msvc-tools v0.1.7 [INFO] [stderr] Downloaded libc v0.2.180 [INFO] [stderr] Downloaded raw-window-handle v0.6.2 [INFO] [stderr] Downloaded xkbcommon-dl v0.4.2 [INFO] [stderr] Downloaded objc2-quartz-core v0.2.2 [INFO] [stderr] Downloaded block2 v0.5.1 [INFO] [stderr] Downloaded objc-sys v0.3.5 [INFO] [stderr] Downloaded objc2-user-notifications v0.2.2 [INFO] [stderr] Downloaded pxfm v0.1.27 [INFO] [stderr] Downloaded redox_syscall v0.7.0 [INFO] [stderr] Downloaded bytemuck_derive v1.10.2 [INFO] [stderr] Downloaded slab v0.4.11 [INFO] [stderr] Downloaded pastey v0.1.1 [INFO] [stderr] Downloaded y4m v0.8.0 [INFO] [stderr] Downloaded num_enum v0.7.5 [INFO] [stderr] Downloaded android-activity v0.6.0 [INFO] [stderr] Downloaded objc2-uniform-type-identifiers v0.2.2 [INFO] [stderr] Downloaded wayland-cursor v0.31.12 [INFO] [stderr] Downloaded smol_str v0.2.2 [INFO] [stderr] Downloaded wayland-sys v0.31.8 [INFO] [stderr] Downloaded proc-macro-crate v3.4.0 [INFO] [stderr] Downloaded gethostname v1.1.0 [INFO] [stderr] Downloaded objc2-core-foundation v0.3.2 [INFO] [stderr] Downloaded libfuzzer-sys v0.4.10 [INFO] [stderr] Downloaded time v0.3.44 [INFO] [stderr] Downloaded allocator-api2 v0.2.21 [INFO] [stderr] Downloaded png v0.18.0 [INFO] [stderr] Downloaded png v0.17.16 [INFO] [stderr] Downloaded dispatch v0.2.0 [INFO] [stderr] Downloaded strict-num v0.1.1 [INFO] [stderr] Downloaded orbclient v0.3.50 [INFO] [stderr] Downloaded console_log v1.0.0 [INFO] [stderr] Downloaded fancy-regex v0.16.2 [INFO] [stderr] Downloaded ndk-sys v0.6.0+11769913 [INFO] [stderr] Downloaded flags v0.1.5 [INFO] [stderr] Downloaded imgref v1.12.0 [INFO] [stderr] Downloaded zune-jpeg v0.5.8 [INFO] [stderr] Downloaded rayon-core v1.13.0 [INFO] [stderr] Downloaded rfd v0.17.1 [INFO] [stderr] Downloaded objc2-core-graphics v0.3.2 [INFO] [stderr] Downloaded flate2 v1.1.5 [INFO] [stderr] Downloaded bytes v1.11.0 [INFO] [stderr] Downloaded dlib v0.5.2 [INFO] [stderr] Downloaded lebe v0.5.3 [INFO] [stderr] Downloaded zune-inflate v0.2.54 [INFO] [stderr] Downloaded anyhow v1.0.100 [INFO] [stderr] Downloaded half v2.7.1 [INFO] [stderr] Downloaded weezl v0.1.12 [INFO] [stderr] Downloaded zune-jpeg v0.4.21 [INFO] [stderr] Downloaded maths-rs v0.2.7 [INFO] [stderr] Downloaded typenum v1.19.0 [INFO] [stderr] Downloaded drm v0.14.1 [INFO] [stderr] Downloaded block2 v0.6.2 [INFO] [stderr] Downloaded dispatch2 v0.3.0 [INFO] [stderr] Downloaded softbuffer v0.4.8 [INFO] [stderr] Downloaded crc32fast v1.5.0 [INFO] [stderr] Downloaded plist v1.8.0 [INFO] [stderr] Downloaded thiserror v2.0.17 [INFO] [stderr] Downloaded yaml-rust v0.4.5 [INFO] [stderr] Downloaded core2 v0.4.0 [INFO] [stderr] Downloaded bitstream-io v4.9.0 [INFO] [stderr] Downloaded built v0.8.0 [INFO] [stderr] Downloaded arbitrary v1.4.2 [INFO] [stderr] Downloaded ahash v0.8.12 [INFO] [stderr] Downloaded downcast-rs v1.2.1 [INFO] [stderr] Downloaded zune-core v0.5.0 [INFO] [stderr] Downloaded unicode-id v0.3.6 [INFO] [stderr] Downloaded globset v0.4.18 [INFO] [stderr] Downloaded sha2 v0.10.9 [INFO] [stderr] Downloaded bit-vec v0.8.0 [INFO] [stderr] Downloaded simd-adler32 v0.3.8 [INFO] [stderr] Downloaded deranged v0.5.5 [INFO] [stderr] Downloaded objc2-core-location v0.2.2 [INFO] [stderr] Downloaded calloop-wayland-source v0.3.0 [INFO] [stderr] Downloaded linux-raw-sys v0.4.15 [INFO] [stderr] Downloaded v_frame v0.3.9 [INFO] [stderr] Downloaded fdeflate v0.3.7 [INFO] [stderr] Downloaded objc2-quartz-core v0.3.2 [INFO] [stderr] Downloaded tiny-xlib v0.2.4 [INFO] [stderr] Downloaded onig v6.5.1 [INFO] [stderr] Downloaded time-macros v0.2.24 [INFO] [stderr] Downloaded zmij v1.0.13 [INFO] [stderr] Downloaded thiserror-impl v2.0.17 [INFO] [stderr] Downloaded objc2-link-presentation v0.2.2 [INFO] [stderr] Downloaded xcursor v0.3.10 [INFO] [stderr] Downloaded loop9 v0.1.5 [INFO] [stderr] Downloaded aligned v0.4.3 [INFO] [stderr] Downloaded num-rational v0.4.2 [INFO] [stderr] Downloaded maybe-rayon v0.1.1 [INFO] [stderr] Downloaded rgb v0.8.52 [INFO] [stderr] Downloaded quick-error v2.0.1 [INFO] [stderr] Downloaded zune-core v0.4.12 [INFO] [stderr] Downloaded pollster v0.4.0 [INFO] [stderr] Downloaded crypto-common v0.1.7 [INFO] [stderr] Downloaded objc2-io-surface v0.3.2 [INFO] [stderr] Downloaded equator v0.4.2 [INFO] [stderr] Downloaded crunchy v0.2.4 [INFO] [stderr] Downloaded rust-embed-utils v8.9.0 [INFO] [stderr] Downloaded drm-sys v0.8.0 [INFO] [stderr] Downloaded ctor-lite v0.1.1 [INFO] [stderr] Downloaded bit-set v0.8.0 [INFO] [stderr] Downloaded num-conv v0.1.0 [INFO] [stderr] Downloaded time-core v0.1.6 [INFO] [stderr] Downloaded android-properties v0.2.2 [INFO] [stderr] Downloaded objc2-symbols v0.2.2 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.106 [INFO] [stderr] Downloaded aligned-vec v0.6.4 [INFO] [stderr] Downloaded fax_derive v0.2.0 [INFO] [stderr] Downloaded rust-embed-impl v8.9.0 [INFO] [stderr] Downloaded linked-hash-map v0.5.6 [INFO] [stderr] Downloaded noop_proc_macro v0.3.0 [INFO] [stderr] Downloaded profiling-procmacros v1.0.17 [INFO] [stderr] Downloaded profiling v1.0.17 [INFO] [stderr] Downloaded fax v0.2.6 [INFO] [stderr] Downloaded drm-ffi v0.9.0 [INFO] [stderr] Downloaded libloading v0.8.9 [INFO] [stderr] Downloaded wasm-bindgen v0.2.106 [INFO] [stderr] Downloaded theframework v0.9.0 [INFO] [stderr] Downloaded rusteria v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 25bdd4e58e225a848a680850a2af4fed17534211d12d7e19d61ee2af9389301b [INFO] running `Command { std: "docker" "start" "-a" "25bdd4e58e225a848a680850a2af4fed17534211d12d7e19d61ee2af9389301b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "25bdd4e58e225a848a680850a2af4fed17534211d12d7e19d61ee2af9389301b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25bdd4e58e225a848a680850a2af4fed17534211d12d7e19d61ee2af9389301b", kill_on_drop: false }` [INFO] [stdout] 25bdd4e58e225a848a680850a2af4fed17534211d12d7e19d61ee2af9389301b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ffe3869060c44d3888a1eb4e823e5b43af7563d8842f2e08ba70d41fca3b56ef [INFO] running `Command { std: "docker" "start" "-a" "ffe3869060c44d3888a1eb4e823e5b43af7563d8842f2e08ba70d41fca3b56ef", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling find-msvc-tools v0.1.7 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Compiling zmij v1.0.13 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling crypto-common v0.1.7 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Compiling drm-sys v0.8.0 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Compiling bstr v1.12.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling drm-fourcc v2.2.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking linux-raw-sys v0.6.5 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling tiny-xlib v0.2.4 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking time-core v0.1.6 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking zune-core v0.5.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking zune-jpeg v0.5.8 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking drm-ffi v0.9.0 [INFO] [stderr] Compiling vek v0.17.2 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Compiling rfd v0.17.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking ctor-lite v0.1.1 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling globset v0.4.18 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rust-embed-utils v8.9.0 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking unicode-id v0.3.6 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Compiling rust-embed-impl v8.9.0 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Compiling uuid-macro-internal v1.19.0 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking rust-embed v8.9.0 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking markdown v1.0.0 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking drm v0.14.1 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking zeno v0.3.3 [INFO] [stderr] Checking flags v0.1.5 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking plist v1.8.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking maths-rs v0.2.7 [INFO] [stderr] Checking vectorize v0.2.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking syntect v5.3.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking softbuffer v0.4.8 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking theframework v0.9.0 [INFO] [stderr] Checking rusteria v0.9.0 [INFO] [stderr] Checking codegridfx v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/module.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | / /// Read out the colors out of the style. [INFO] [stdout] ... | [INFO] [stdout] 371 | | [INFO] [stdout] | |_^ [INFO] [stdout] 372 | pub fn build_canvas(&mut self, ctx: &mut TheContext, name: &str) -> TheCanvas { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `build_canvas` then comment it out [INFO] [stdout] | [INFO] [stdout] 361 | // /// Read out the colors out of the style. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/module.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | / /// Read out the colors out of the style. [INFO] [stdout] ... | [INFO] [stdout] 371 | | [INFO] [stdout] | |_^ [INFO] [stdout] 372 | pub fn build_canvas(&mut self, ctx: &mut TheContext, name: &str) -> TheCanvas { [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `build_canvas` then comment it out [INFO] [stdout] | [INFO] [stdout] 361 | // /// Read out the colors out of the style. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cell.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 355 | | match s { [INFO] [stdout] 356 | | "Var = .." => Some(Cell::ConstructAssignBlock), [INFO] [stdout] 357 | | "Color = .." => Some(Cell::ConstructColorAssignBlock), [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `cell::Cell` [INFO] [stdout] --> src/cell.rs:453:5 [INFO] [stdout] | [INFO] [stdout] 453 | / pub fn to_string(&self) -> String { [INFO] [stdout] 454 | | match &self { [INFO] [stdout] 455 | | Variable(var_name) => { [INFO] [stdout] 456 | | if var_name == "myself" { [INFO] [stdout] ... | [INFO] [stdout] 567 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `cell::Cell` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cell.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 355 | | match s { [INFO] [stdout] 356 | | "Var = .." => Some(Cell::ConstructAssignBlock), [INFO] [stdout] 357 | | "Color = .." => Some(Cell::ConstructColorAssignBlock), [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `cell::Cell` [INFO] [stdout] --> src/cell.rs:453:5 [INFO] [stdout] | [INFO] [stdout] 453 | / pub fn to_string(&self) -> String { [INFO] [stdout] 454 | | match &self { [INFO] [stdout] 455 | | Variable(var_name) => { [INFO] [stdout] 456 | | if var_name == "myself" { [INFO] [stdout] ... | [INFO] [stdout] 567 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `cell::Cell` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/cellitem.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | / pub fn draw( [INFO] [stdout] 86 | | &mut self, [INFO] [stdout] 87 | | buffer: &mut TheRGBABuffer, [INFO] [stdout] 88 | | rect: &TheDim, [INFO] [stdout] ... | [INFO] [stdout] 95 | | debug: Option<&DebugModule>, [INFO] [stdout] 96 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:236:21 [INFO] [stdout] | [INFO] [stdout] 236 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:286:21 [INFO] [stdout] | [INFO] [stdout] 286 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | / if let Some(debug) = debug { [INFO] [stdout] 304 | | if let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 305 | | let color = if debug.has_error(id, event, pos.0, pos.1) { [INFO] [stdout] 306 | | &error_color [INFO] [stdout] ... | [INFO] [stdout] 325 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 303 ~ if let Some(debug) = debug [INFO] [stdout] 304 ~ && let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 305 | let color = if debug.has_error(id, event, pos.0, pos.1) { [INFO] [stdout] ... [INFO] [stdout] 323 | ); [INFO] [stdout] 324 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:476:17 [INFO] [stdout] | [INFO] [stdout] 476 | / if let Some(debug) = debug { [INFO] [stdout] 477 | | if let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 478 | | let desc = ctx [INFO] [stdout] 479 | | .draw [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 476 ~ if let Some(debug) = debug [INFO] [stdout] 477 ~ && let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 478 | let desc = ctx [INFO] [stdout] ... [INFO] [stdout] 489 | size.x = size.x.max(desc); [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cellitem.rs:701:26 [INFO] [stdout] | [INFO] [stdout] 701 | *v = if val == 0 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `val == 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:705:17 [INFO] [stdout] | [INFO] [stdout] 705 | / if let Some(val) = value.to_i32() { [INFO] [stdout] 706 | | if let Some(o) = ComparisonOp::from_index(val as usize) { [INFO] [stdout] 707 | | *op = o; [INFO] [stdout] 708 | | } [INFO] [stdout] 709 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 705 ~ if let Some(val) = value.to_i32() [INFO] [stdout] 706 ~ && let Some(o) = ComparisonOp::from_index(val as usize) { [INFO] [stdout] 707 | *op = o; [INFO] [stdout] 708 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:712:17 [INFO] [stdout] | [INFO] [stdout] 712 | / if let Some(val) = value.to_i32() { [INFO] [stdout] 713 | | if let Some(o) = ArithmeticOp::from_index(val as usize) { [INFO] [stdout] 714 | | *op = o; [INFO] [stdout] 715 | | } [INFO] [stdout] 716 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 712 ~ if let Some(val) = value.to_i32() [INFO] [stdout] 713 ~ && let Some(o) = ArithmeticOp::from_index(val as usize) { [INFO] [stdout] 714 | *op = o; [INFO] [stdout] 715 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:724:17 [INFO] [stdout] | [INFO] [stdout] 724 | / if let Some(val) = value.to_i32() { [INFO] [stdout] 725 | | if let Some(kind) = PatternKind::from_index(val as usize) { [INFO] [stdout] 726 | | *str = kind.display_name().to_string(); [INFO] [stdout] 727 | | } [INFO] [stdout] 728 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 724 ~ if let Some(val) = value.to_i32() [INFO] [stdout] 725 ~ && let Some(kind) = PatternKind::from_index(val as usize) { [INFO] [stdout] 726 | *str = kind.display_name().to_string(); [INFO] [stdout] 727 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/cellitem.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | / pub fn draw( [INFO] [stdout] 86 | | &mut self, [INFO] [stdout] 87 | | buffer: &mut TheRGBABuffer, [INFO] [stdout] 88 | | rect: &TheDim, [INFO] [stdout] ... | [INFO] [stdout] 95 | | debug: Option<&DebugModule>, [INFO] [stdout] 96 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:236:21 [INFO] [stdout] | [INFO] [stdout] 236 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:286:21 [INFO] [stdout] | [INFO] [stdout] 286 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cellitem.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | &color, [INFO] [stdout] | ^^^^^^ help: change this to: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | / if let Some(debug) = debug { [INFO] [stdout] 304 | | if let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 305 | | let color = if debug.has_error(id, event, pos.0, pos.1) { [INFO] [stdout] 306 | | &error_color [INFO] [stdout] ... | [INFO] [stdout] 325 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 303 ~ if let Some(debug) = debug [INFO] [stdout] 304 ~ && let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 305 | let color = if debug.has_error(id, event, pos.0, pos.1) { [INFO] [stdout] ... [INFO] [stdout] 323 | ); [INFO] [stdout] 324 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:476:17 [INFO] [stdout] | [INFO] [stdout] 476 | / if let Some(debug) = debug { [INFO] [stdout] 477 | | if let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 478 | | let desc = ctx [INFO] [stdout] 479 | | .draw [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 476 ~ if let Some(debug) = debug [INFO] [stdout] 477 ~ && let Some(value) = debug.get_value(id, event, pos.0, pos.1) { [INFO] [stdout] 478 | let desc = ctx [INFO] [stdout] ... [INFO] [stdout] 489 | size.x = size.x.max(desc); [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cellitem.rs:701:26 [INFO] [stdout] | [INFO] [stdout] 701 | *v = if val == 0 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `val == 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:705:17 [INFO] [stdout] | [INFO] [stdout] 705 | / if let Some(val) = value.to_i32() { [INFO] [stdout] 706 | | if let Some(o) = ComparisonOp::from_index(val as usize) { [INFO] [stdout] 707 | | *op = o; [INFO] [stdout] 708 | | } [INFO] [stdout] 709 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 705 ~ if let Some(val) = value.to_i32() [INFO] [stdout] 706 ~ && let Some(o) = ComparisonOp::from_index(val as usize) { [INFO] [stdout] 707 | *op = o; [INFO] [stdout] 708 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:712:17 [INFO] [stdout] | [INFO] [stdout] 712 | / if let Some(val) = value.to_i32() { [INFO] [stdout] 713 | | if let Some(o) = ArithmeticOp::from_index(val as usize) { [INFO] [stdout] 714 | | *op = o; [INFO] [stdout] 715 | | } [INFO] [stdout] 716 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 712 ~ if let Some(val) = value.to_i32() [INFO] [stdout] 713 ~ && let Some(o) = ArithmeticOp::from_index(val as usize) { [INFO] [stdout] 714 | *op = o; [INFO] [stdout] 715 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cellitem.rs:724:17 [INFO] [stdout] | [INFO] [stdout] 724 | / if let Some(val) = value.to_i32() { [INFO] [stdout] 725 | | if let Some(kind) = PatternKind::from_index(val as usize) { [INFO] [stdout] 726 | | *str = kind.display_name().to_string(); [INFO] [stdout] 727 | | } [INFO] [stdout] 728 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 724 ~ if let Some(val) = value.to_i32() [INFO] [stdout] 725 ~ && let Some(kind) = PatternKind::from_index(val as usize) { [INFO] [stdout] 726 | *str = kind.display_name().to_string(); [INFO] [stdout] 727 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/cellitem.rs:2286:9 [INFO] [stdout] | [INFO] [stdout] 2286 | / match &self.cell { [INFO] [stdout] 2287 | | _ => { [INFO] [stdout] 2288 | | context_menu.add(TheContextMenuItem::new( [INFO] [stdout] 2289 | | str!("Assignment"), [INFO] [stdout] ... | [INFO] [stdout] 2293 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 2286 ~ { [INFO] [stdout] 2287 + context_menu.add(TheContextMenuItem::new( [INFO] [stdout] 2288 + str!("Assignment"), [INFO] [stdout] 2289 + TheId::named("CGFAssignment"), [INFO] [stdout] 2290 + )); [INFO] [stdout] 2291 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / if let Some(item) = self.grid.get(&((at.0 as i32 + x_offset) as u32, at.1)) { [INFO] [stdout] 46 | | if item.cell.role() == role { [INFO] [stdout] 47 | | return true; [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if let Some(item) = self.grid.get(&((at.0 as i32 + x_offset) as u32, at.1)) [INFO] [stdout] 46 ~ && item.cell.role() == role { [INFO] [stdout] 47 | return true; [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/grid.rs:107:33 [INFO] [stdout] | [INFO] [stdout] 107 | for (&(col, row), _) in &self.grid { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 107 - for (&(col, row), _) in &self.grid { [INFO] [stdout] 107 + for &(col, row) in self.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | / if let Some(&lead_col) = cols [INFO] [stdout] 114 | | .iter() [INFO] [stdout] 115 | | .filter(|&&c| { [INFO] [stdout] 116 | | if let Some(ci) = self.grid.get(&(c, row)) { [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ .min() [INFO] [stdout] 123 ~ && let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 124 | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 125 | leading_is_else = true; [INFO] [stdout] 126 | } [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 124 | / if let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 125 | | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 126 | | leading_is_else = true; [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if let Some(ci) = self.grid.get(&(lead_col, row)) [INFO] [stdout] 125 ~ && matches!(ci.cell, Cell::Else) { [INFO] [stdout] 126 | leading_is_else = true; [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/cellitem.rs:2286:9 [INFO] [stdout] | [INFO] [stdout] 2286 | / match &self.cell { [INFO] [stdout] 2287 | | _ => { [INFO] [stdout] 2288 | | context_menu.add(TheContextMenuItem::new( [INFO] [stdout] 2289 | | str!("Assignment"), [INFO] [stdout] ... | [INFO] [stdout] 2293 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 2286 ~ { [INFO] [stdout] 2287 + context_menu.add(TheContextMenuItem::new( [INFO] [stdout] 2288 + str!("Assignment"), [INFO] [stdout] 2289 + TheId::named("CGFAssignment"), [INFO] [stdout] 2290 + )); [INFO] [stdout] 2291 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | / if first_row_exists { [INFO] [stdout] 228 | | if let Some(cur) = existing_first_indent { [INFO] [stdout] 229 | | if cur > base_indent { [INFO] [stdout] 230 | | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] ... | [INFO] [stdout] 233 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 227 ~ if first_row_exists [INFO] [stdout] 228 ~ && let Some(cur) = existing_first_indent { [INFO] [stdout] 229 | if cur > base_indent { [INFO] [stdout] 230 | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] 231 | } [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:228:17 [INFO] [stdout] | [INFO] [stdout] 228 | / if let Some(cur) = existing_first_indent { [INFO] [stdout] 229 | | if cur > base_indent { [INFO] [stdout] 230 | | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] 231 | | } [INFO] [stdout] 232 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 228 ~ if let Some(cur) = existing_first_indent [INFO] [stdout] 229 ~ && cur > base_indent { [INFO] [stdout] 230 | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] 231 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `next_row` is used as a loop counter [INFO] [stdout] --> src/grid.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | for level in (0..=start_level).rev() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (next_row, level) in (base_row + 1..).zip((0..=start_level).rev())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/grid.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | for (&(c, r), _) in &self.grid { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 247 - for (&(c, r), _) in &self.grid { [INFO] [stdout] 247 + for &(c, r) in self.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/grid.rs:340:33 [INFO] [stdout] | [INFO] [stdout] 340 | for (&(col, row), _) in &self.grid { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 340 - for (&(col, row), _) in &self.grid { [INFO] [stdout] 340 + for &(col, row) in self.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 346 | / if let Some(&lead_col) = cols [INFO] [stdout] 347 | | .iter() [INFO] [stdout] 348 | | .filter(|&&c| { [INFO] [stdout] 349 | | if let Some(ci) = self.grid.get(&(c, row)) { [INFO] [stdout] ... | [INFO] [stdout] 362 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 355 ~ .min() [INFO] [stdout] 356 ~ && let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 357 | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 358 | leading_is_else = true; [INFO] [stdout] 359 | } [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 358 | | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 359 | | leading_is_else = true; [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(ci) = self.grid.get(&(lead_col, row)) [INFO] [stdout] 358 ~ && matches!(ci.cell, Cell::Else) { [INFO] [stdout] 359 | leading_is_else = true; [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/grid.rs:389:32 [INFO] [stdout] | [INFO] [stdout] 389 | to_remove.push(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | / if let Some(c0) = lead_col { [INFO] [stdout] 437 | | if let Some(ci) = self.grid.get(&(c0, row)) { [INFO] [stdout] 438 | | is_control = matches!(ci.cell, Cell::If /* | Cell::For | Cell::While */); [INFO] [stdout] 439 | | } [INFO] [stdout] 440 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 436 ~ if let Some(c0) = lead_col [INFO] [stdout] 437 ~ && let Some(ci) = self.grid.get(&(c0, row)) { [INFO] [stdout] 438 | is_control = matches!(ci.cell, Cell::If /* | Cell::For | Cell::While */); [INFO] [stdout] 439 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grid.rs:541:13 [INFO] [stdout] | [INFO] [stdout] 541 | any && true [INFO] [stdout] | ^^^^^^^^^^^ help: try: `any` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/grid.rs:712:5 [INFO] [stdout] | [INFO] [stdout] 712 | / pub fn size( [INFO] [stdout] 713 | | &mut self, [INFO] [stdout] 714 | | ctx: &TheContext, [INFO] [stdout] 715 | | grid_ctx: &GridCtx, [INFO] [stdout] ... | [INFO] [stdout] 720 | | debug: Option<&DebugModule>, [INFO] [stdout] 721 | | ) -> Vec2 { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid.rs:780:46 [INFO] [stdout] | [INFO] [stdout] 780 | .map(|r| row_heights[&r]) [INFO] [stdout] | ^^ help: change this to: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / if let Some(item) = self.grid.get(&((at.0 as i32 + x_offset) as u32, at.1)) { [INFO] [stdout] 46 | | if item.cell.role() == role { [INFO] [stdout] 47 | | return true; [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if let Some(item) = self.grid.get(&((at.0 as i32 + x_offset) as u32, at.1)) [INFO] [stdout] 46 ~ && item.cell.role() == role { [INFO] [stdout] 47 | return true; [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/grid.rs:107:33 [INFO] [stdout] | [INFO] [stdout] 107 | for (&(col, row), _) in &self.grid { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 107 - for (&(col, row), _) in &self.grid { [INFO] [stdout] 107 + for &(col, row) in self.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | / if let Some(&lead_col) = cols [INFO] [stdout] 114 | | .iter() [INFO] [stdout] 115 | | .filter(|&&c| { [INFO] [stdout] 116 | | if let Some(ci) = self.grid.get(&(c, row)) { [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ .min() [INFO] [stdout] 123 ~ && let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 124 | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 125 | leading_is_else = true; [INFO] [stdout] 126 | } [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 124 | / if let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 125 | | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 126 | | leading_is_else = true; [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if let Some(ci) = self.grid.get(&(lead_col, row)) [INFO] [stdout] 125 ~ && matches!(ci.cell, Cell::Else) { [INFO] [stdout] 126 | leading_is_else = true; [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/module.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / match self { [INFO] [stdout] 102 | | ModuleType::CharacterInstance | ModuleType::ItemInstance => true, [INFO] [stdout] 103 | | _ => false, [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 101 - match self { [INFO] [stdout] 102 - ModuleType::CharacterInstance | ModuleType::ItemInstance => true, [INFO] [stdout] 103 - _ => false, [INFO] [stdout] 104 - } [INFO] [stdout] 101 + matches!(self, ModuleType::CharacterInstance | ModuleType::ItemInstance) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/module.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / match self { [INFO] [stdout] 109 | | ModuleType::Shader => true, [INFO] [stdout] 110 | | _ => false, [INFO] [stdout] 111 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 108 - match self { [INFO] [stdout] 109 - ModuleType::Shader => true, [INFO] [stdout] 110 - _ => false, [INFO] [stdout] 111 - } [INFO] [stdout] 108 + matches!(self, ModuleType::Shader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | / if first_row_exists { [INFO] [stdout] 228 | | if let Some(cur) = existing_first_indent { [INFO] [stdout] 229 | | if cur > base_indent { [INFO] [stdout] 230 | | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] ... | [INFO] [stdout] 233 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 227 ~ if first_row_exists [INFO] [stdout] 228 ~ && let Some(cur) = existing_first_indent { [INFO] [stdout] 229 | if cur > base_indent { [INFO] [stdout] 230 | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] 231 | } [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:228:17 [INFO] [stdout] | [INFO] [stdout] 228 | / if let Some(cur) = existing_first_indent { [INFO] [stdout] 229 | | if cur > base_indent { [INFO] [stdout] 230 | | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] 231 | | } [INFO] [stdout] 232 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 228 ~ if let Some(cur) = existing_first_indent [INFO] [stdout] 229 ~ && cur > base_indent { [INFO] [stdout] 230 | self.row_indents.insert(first_row, base_indent); [INFO] [stdout] 231 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `next_row` is used as a loop counter [INFO] [stdout] --> src/grid.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | for level in (0..=start_level).rev() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (next_row, level) in (base_row + 1..).zip((0..=start_level).rev())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/grid.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | for (&(c, r), _) in &self.grid { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 247 - for (&(c, r), _) in &self.grid { [INFO] [stdout] 247 + for &(c, r) in self.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/grid.rs:340:33 [INFO] [stdout] | [INFO] [stdout] 340 | for (&(col, row), _) in &self.grid { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 340 - for (&(col, row), _) in &self.grid { [INFO] [stdout] 340 + for &(col, row) in self.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 346 | / if let Some(&lead_col) = cols [INFO] [stdout] 347 | | .iter() [INFO] [stdout] 348 | | .filter(|&&c| { [INFO] [stdout] 349 | | if let Some(ci) = self.grid.get(&(c, row)) { [INFO] [stdout] ... | [INFO] [stdout] 362 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 355 ~ .min() [INFO] [stdout] 356 ~ && let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 357 | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 358 | leading_is_else = true; [INFO] [stdout] 359 | } [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(ci) = self.grid.get(&(lead_col, row)) { [INFO] [stdout] 358 | | if matches!(ci.cell, Cell::Else) { [INFO] [stdout] 359 | | leading_is_else = true; [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(ci) = self.grid.get(&(lead_col, row)) [INFO] [stdout] 358 ~ && matches!(ci.cell, Cell::Else) { [INFO] [stdout] 359 | leading_is_else = true; [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/grid.rs:389:32 [INFO] [stdout] | [INFO] [stdout] 389 | to_remove.push(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grid.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | / if let Some(c0) = lead_col { [INFO] [stdout] 437 | | if let Some(ci) = self.grid.get(&(c0, row)) { [INFO] [stdout] 438 | | is_control = matches!(ci.cell, Cell::If /* | Cell::For | Cell::While */); [INFO] [stdout] 439 | | } [INFO] [stdout] 440 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 436 ~ if let Some(c0) = lead_col [INFO] [stdout] 437 ~ && let Some(ci) = self.grid.get(&(c0, row)) { [INFO] [stdout] 438 | is_control = matches!(ci.cell, Cell::If /* | Cell::For | Cell::While */); [INFO] [stdout] 439 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grid.rs:541:13 [INFO] [stdout] | [INFO] [stdout] 541 | any && true [INFO] [stdout] | ^^^^^^^^^^^ help: try: `any` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:345:44 [INFO] [stdout] | [INFO] [stdout] 345 | let routine = Routine::new("shader".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"shader"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:350:44 [INFO] [stdout] | [INFO] [stdout] 350 | let routine = Routine::new("instantiation".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"instantiation"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:353:16 [INFO] [stdout] | [INFO] [stdout] 353 | } else if self.module_type != ModuleType::Unknown { [INFO] [stdout] | ________________^ [INFO] [stdout] 354 | | if !self.contains("startup") { [INFO] [stdout] 355 | | let routine = Routine::new("startup".into()); [INFO] [stdout] 356 | | self.routines.insert(routine.id, routine); [INFO] [stdout] 357 | | } [INFO] [stdout] 358 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 353 ~ } else if self.module_type != ModuleType::Unknown [INFO] [stdout] 354 ~ && !self.contains("startup") { [INFO] [stdout] 355 | let routine = Routine::new("startup".into()); [INFO] [stdout] 356 | self.routines.insert(routine.id, routine); [INFO] [stdout] 357 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:355:44 [INFO] [stdout] | [INFO] [stdout] 355 | let routine = Routine::new("startup".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"startup"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/grid.rs:712:5 [INFO] [stdout] | [INFO] [stdout] 712 | / pub fn size( [INFO] [stdout] 713 | | &mut self, [INFO] [stdout] 714 | | ctx: &TheContext, [INFO] [stdout] 715 | | grid_ctx: &GridCtx, [INFO] [stdout] ... | [INFO] [stdout] 720 | | debug: Option<&DebugModule>, [INFO] [stdout] 721 | | ) -> Vec2 { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid.rs:780:46 [INFO] [stdout] | [INFO] [stdout] 780 | .map(|r| row_heights[&r]) [INFO] [stdout] | ^^ help: change this to: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:531:58 [INFO] [stdout] | [INFO] [stdout] 531 | buffer.copy_into(self.grid_ctx.offset_x, y as i32, &r.buffer); [INFO] [stdout] | ^^^^^^^^ help: try: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/module.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 587 | / for r in self.routines.values_mut() { [INFO] [stdout] 588 | | if Some(r.id) == self.grid_ctx.selected_routine { [INFO] [stdout] 589 | | return Some(r); [INFO] [stdout] ... | [INFO] [stdout] 592 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.routines.values_mut().find(|r| Some(r.id) == self.grid_ctx.selected_routine).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:613:17 [INFO] [stdout] | [INFO] [stdout] 613 | / if loc.y < header_height { [INFO] [stdout] 614 | | if let Some(shader) = module.routines.get_index(0) { [INFO] [stdout] 615 | | r.id = *shader.0; [INFO] [stdout] 616 | | r.grid = shader.1.grid.clone(); [INFO] [stdout] ... | [INFO] [stdout] 619 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 613 ~ if loc.y < header_height [INFO] [stdout] 614 ~ && let Some(shader) = module.routines.get_index(0) { [INFO] [stdout] 615 | r.id = *shader.0; [INFO] [stdout] 616 | r.grid = shader.1.grid.clone(); [INFO] [stdout] 617 | return true; [INFO] [stdout] 618 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:637:17 [INFO] [stdout] | [INFO] [stdout] 637 | / if id.name == self.get_view_name() { [INFO] [stdout] 638 | | self.redraw(ui, ctx); [INFO] [stdout] 639 | | [INFO] [stdout] 640 | | redraw = true; [INFO] [stdout] 641 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 636 ~ TheEvent::WidgetResized(id, _dim) [INFO] [stdout] 637 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 638 | self.redraw(ui, ctx); [INFO] [stdout] 639 | [INFO] [stdout] 640 | redraw = true; [INFO] [stdout] 641 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:644:17 [INFO] [stdout] | [INFO] [stdout] 644 | / if id.name == self.get_view_name() { [INFO] [stdout] 645 | | if let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] 646 | | let view_port_height = renderview.dim().height; [INFO] [stdout] 647 | | let view_port_width = renderview.dim().width; [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 643 ~ TheEvent::RenderViewScrollBy(id, coord) [INFO] [stdout] 644 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 645 | if let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] ... [INFO] [stdout] 687 | } [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:929:17 [INFO] [stdout] | [INFO] [stdout] 929 | / if id.name == "Code Editor Code List Item" { [INFO] [stdout] 930 | | // if let Some(atom) = Some(self.create_atom(text.as_str(), id.uuid)) { [INFO] [stdout] 931 | | let mut drop = TheDrop::new(TheId::named("Code Editor Atom")); [INFO] [stdout] ... | [INFO] [stdout] 938 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 928 ~ TheEvent::DragStarted(id, text, offset) [INFO] [stdout] 929 ~ if id.name == "Code Editor Code List Item" => { [INFO] [stdout] 930 | // if let Some(atom) = Some(self.create_atom(text.as_str(), id.uuid)) { [INFO] [stdout] ... [INFO] [stdout] 937 | // } [INFO] [stdout] 938 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:1025:17 [INFO] [stdout] | [INFO] [stdout] 1025 | / if id.name == self.get_view_name() { [INFO] [stdout] 1026 | | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] 1027 | | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] 1028 | | for r in self.routines.values_mut() { [INFO] [stdout] ... | [INFO] [stdout] 1048 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1024 ~ TheEvent::RenderViewContext(id, coord) [INFO] [stdout] 1025 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 1026 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] ... [INFO] [stdout] 1047 | } [INFO] [stdout] 1048 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:1051:17 [INFO] [stdout] | [INFO] [stdout] 1051 | / if id.name == self.get_view_name() { [INFO] [stdout] 1052 | | let mut settings: Option = None; [INFO] [stdout] 1053 | | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] 1054 | | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] ... | [INFO] [stdout] 1088 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1050 ~ TheEvent::RenderViewClicked(id, coord) [INFO] [stdout] 1051 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 1052 | let mut settings: Option = None; [INFO] [stdout] ... [INFO] [stdout] 1087 | } [INFO] [stdout] 1088 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:644:17 [INFO] [stdout] | [INFO] [stdout] 644 | / if id.name == self.get_view_name() { [INFO] [stdout] 645 | | if let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] 646 | | let view_port_height = renderview.dim().height; [INFO] [stdout] 647 | | let view_port_width = renderview.dim().width; [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 644 ~ if id.name == self.get_view_name() [INFO] [stdout] 645 ~ && let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] 646 | let view_port_height = renderview.dim().height; [INFO] [stdout] ... [INFO] [stdout] 686 | self.draw(renderview.render_buffer_mut()); [INFO] [stdout] 687 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:654:40 [INFO] [stdout] | [INFO] [stdout] 654 | let vp_h_i32 = view_port_height as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `view_port_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:672:40 [INFO] [stdout] | [INFO] [stdout] 672 | let vp_w_i32 = view_port_width as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `view_port_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:694:17 [INFO] [stdout] | [INFO] [stdout] 694 | / if let Some(focus) = &ctx.ui.focus { [INFO] [stdout] 695 | | if focus.name == self.get_view_name() { [INFO] [stdout] 696 | | let prev = self.to_json(); [INFO] [stdout] 697 | | if let Some(key_code) = key.to_key_code() { [INFO] [stdout] ... | [INFO] [stdout] 775 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 694 ~ if let Some(focus) = &ctx.ui.focus [INFO] [stdout] 695 ~ && focus.name == self.get_view_name() { [INFO] [stdout] 696 | let prev = self.to_json(); [INFO] [stdout] ... [INFO] [stdout] 773 | } [INFO] [stdout] 774 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/module.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / match self { [INFO] [stdout] 102 | | ModuleType::CharacterInstance | ModuleType::ItemInstance => true, [INFO] [stdout] 103 | | _ => false, [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 101 - match self { [INFO] [stdout] 102 - ModuleType::CharacterInstance | ModuleType::ItemInstance => true, [INFO] [stdout] 103 - _ => false, [INFO] [stdout] 104 - } [INFO] [stdout] 101 + matches!(self, ModuleType::CharacterInstance | ModuleType::ItemInstance) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/module.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / match self { [INFO] [stdout] 109 | | ModuleType::Shader => true, [INFO] [stdout] 110 | | _ => false, [INFO] [stdout] 111 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 108 - match self { [INFO] [stdout] 109 - ModuleType::Shader => true, [INFO] [stdout] 110 - _ => false, [INFO] [stdout] 111 - } [INFO] [stdout] 108 + matches!(self, ModuleType::Shader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(u32, u32)>` which implements the `Copy` trait [INFO] [stdout] --> src/module.rs:699:52 [INFO] [stdout] | [INFO] [stdout] 699 | ... if let Some(sel) = self.grid_ctx.current_cell.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.grid_ctx.current_cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(u32, u32)>` which implements the `Copy` trait [INFO] [stdout] --> src/module.rs:738:52 [INFO] [stdout] | [INFO] [stdout] 738 | ... if let Some(sel) = self.grid_ctx.current_cell.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.grid_ctx.current_cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:345:44 [INFO] [stdout] | [INFO] [stdout] 345 | let routine = Routine::new("shader".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"shader"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:350:44 [INFO] [stdout] | [INFO] [stdout] 350 | let routine = Routine::new("instantiation".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"instantiation"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:353:16 [INFO] [stdout] | [INFO] [stdout] 353 | } else if self.module_type != ModuleType::Unknown { [INFO] [stdout] | ________________^ [INFO] [stdout] 354 | | if !self.contains("startup") { [INFO] [stdout] 355 | | let routine = Routine::new("startup".into()); [INFO] [stdout] 356 | | self.routines.insert(routine.id, routine); [INFO] [stdout] 357 | | } [INFO] [stdout] 358 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 353 ~ } else if self.module_type != ModuleType::Unknown [INFO] [stdout] 354 ~ && !self.contains("startup") { [INFO] [stdout] 355 | let routine = Routine::new("startup".into()); [INFO] [stdout] 356 | self.routines.insert(routine.id, routine); [INFO] [stdout] 357 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:790:24 [INFO] [stdout] | [INFO] [stdout] 790 | } else if id.name == "cgfxEventName" { [INFO] [stdout] | ________________________^ [INFO] [stdout] 791 | | if let Some(text) = value.to_string() { [INFO] [stdout] 792 | | if self.grid_ctx.selected_routine.is_none() { [INFO] [stdout] 793 | | if let Some((id, _)) = self.routines.first() { [INFO] [stdout] ... | [INFO] [stdout] 831 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 790 ~ } else if id.name == "cgfxEventName" [INFO] [stdout] 791 ~ && let Some(text) = value.to_string() { [INFO] [stdout] 792 | if self.grid_ctx.selected_routine.is_none() { [INFO] [stdout] ... [INFO] [stdout] 829 | } [INFO] [stdout] 830 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:355:44 [INFO] [stdout] | [INFO] [stdout] 355 | let routine = Routine::new("startup".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"startup"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:792:25 [INFO] [stdout] | [INFO] [stdout] 792 | / if self.grid_ctx.selected_routine.is_none() { [INFO] [stdout] 793 | | if let Some((id, _)) = self.routines.first() { [INFO] [stdout] 794 | | self.grid_ctx.selected_routine = Some(*id); [INFO] [stdout] 795 | | } [INFO] [stdout] 796 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 792 ~ if self.grid_ctx.selected_routine.is_none() [INFO] [stdout] 793 ~ && let Some((id, _)) = self.routines.first() { [INFO] [stdout] 794 | self.grid_ctx.selected_routine = Some(*id); [INFO] [stdout] 795 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:808:33 [INFO] [stdout] | [INFO] [stdout] 808 | / ... if let Some(routine) = self.routines.get_mut(&selected_id) { [INFO] [stdout] 809 | | ... if routine.name != text { [INFO] [stdout] 810 | | ... routine.name = text; [INFO] [stdout] 811 | | ... changed = true; [INFO] [stdout] 812 | | ... } [INFO] [stdout] 813 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 808 ~ if let Some(routine) = self.routines.get_mut(&selected_id) [INFO] [stdout] 809 ~ && routine.name != text { [INFO] [stdout] 810 | routine.name = text; [INFO] [stdout] 811 | changed = true; [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:834:21 [INFO] [stdout] | [INFO] [stdout] 834 | / if let Some(value) = value.to_i32() { [INFO] [stdout] 835 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 836 | | event.pixelization = value; [INFO] [stdout] ... | [INFO] [stdout] 848 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 834 ~ if let Some(value) = value.to_i32() [INFO] [stdout] 835 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 836 | event.pixelization = value; [INFO] [stdout] ... [INFO] [stdout] 846 | )); [INFO] [stdout] 847 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:851:21 [INFO] [stdout] | [INFO] [stdout] 851 | / if let Some(value) = value.to_i32() { [INFO] [stdout] 852 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 853 | | event.color_steps = value; [INFO] [stdout] ... | [INFO] [stdout] 865 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 851 ~ if let Some(value) = value.to_i32() [INFO] [stdout] 852 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 853 | event.color_steps = value; [INFO] [stdout] ... [INFO] [stdout] 863 | )); [INFO] [stdout] 864 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:868:21 [INFO] [stdout] | [INFO] [stdout] 868 | / if let Some(value) = value.to_f32() { [INFO] [stdout] 869 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 870 | | event.rotation = value; [INFO] [stdout] ... | [INFO] [stdout] 882 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 868 ~ if let Some(value) = value.to_f32() [INFO] [stdout] 869 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 870 | event.rotation = value; [INFO] [stdout] ... [INFO] [stdout] 880 | )); [INFO] [stdout] 881 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:885:21 [INFO] [stdout] | [INFO] [stdout] 885 | / if let Some(value) = value.to_f32() { [INFO] [stdout] 886 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 887 | | event.scale = value; [INFO] [stdout] ... | [INFO] [stdout] 899 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 885 ~ if let Some(value) = value.to_f32() [INFO] [stdout] 886 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 887 | event.scale = value; [INFO] [stdout] ... [INFO] [stdout] 897 | )); [INFO] [stdout] 898 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:904:25 [INFO] [stdout] | [INFO] [stdout] 904 | / if Some(r.id) == self.grid_ctx.selected_routine { [INFO] [stdout] 905 | | if let Some(coord) = self.grid_ctx.current_cell { [INFO] [stdout] 906 | | if let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] 907 | | needs_update = [INFO] [stdout] ... | [INFO] [stdout] 912 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 904 ~ if Some(r.id) == self.grid_ctx.selected_routine [INFO] [stdout] 905 ~ && let Some(coord) = self.grid_ctx.current_cell { [INFO] [stdout] 906 | if let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] ... [INFO] [stdout] 910 | } [INFO] [stdout] 911 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:905:29 [INFO] [stdout] | [INFO] [stdout] 905 | / ... if let Some(coord) = self.grid_ctx.current_cell { [INFO] [stdout] 906 | | ... if let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] 907 | | ... needs_update = [INFO] [stdout] 908 | | ... item.apply_value(&id.name, value, self.module_type); [INFO] [stdout] ... | [INFO] [stdout] 911 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 905 ~ if let Some(coord) = self.grid_ctx.current_cell [INFO] [stdout] 906 ~ && let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] 907 | needs_update = [INFO] [stdout] 908 | item.apply_value(&id.name, value, self.module_type); [INFO] [stdout] 909 | r.draw(ctx, &self.grid_ctx, 0, None, None); [INFO] [stdout] 910 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:944:33 [INFO] [stdout] | [INFO] [stdout] 944 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:945:33 [INFO] [stdout] | [INFO] [stdout] 945 | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:952:48 [INFO] [stdout] | [INFO] [stdout] 952 | let routine = Routine::new("custom".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"custom"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:531:58 [INFO] [stdout] | [INFO] [stdout] 531 | buffer.copy_into(self.grid_ctx.offset_x, y as i32, &r.buffer); [INFO] [stdout] | ^^^^^^^^ help: try: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1026:37 [INFO] [stdout] | [INFO] [stdout] 1026 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1027:37 [INFO] [stdout] | [INFO] [stdout] 1027 | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `draw` doesn't need a mutable reference [INFO] [stdout] --> src/module.rs:1036:45 [INFO] [stdout] | [INFO] [stdout] 1036 | ... r.draw(ctx, &mut self.grid_ctx, 0, None, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1036 - r.draw(ctx, &mut self.grid_ctx, 0, None, None); [INFO] [stdout] 1036 + r.draw(ctx, &self.grid_ctx, 0, None, None); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1053:37 [INFO] [stdout] | [INFO] [stdout] 1053 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1054:37 [INFO] [stdout] | [INFO] [stdout] 1054 | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/module.rs:1071:36 [INFO] [stdout] | [INFO] [stdout] 1071 | ... if self.grid_ctx.current_cell == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.grid_ctx.current_cell.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/module.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 587 | / for r in self.routines.values_mut() { [INFO] [stdout] 588 | | if Some(r.id) == self.grid_ctx.selected_routine { [INFO] [stdout] 589 | | return Some(r); [INFO] [stdout] ... | [INFO] [stdout] 592 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.routines.values_mut().find(|r| Some(r.id) == self.grid_ctx.selected_routine).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:613:17 [INFO] [stdout] | [INFO] [stdout] 613 | / if loc.y < header_height { [INFO] [stdout] 614 | | if let Some(shader) = module.routines.get_index(0) { [INFO] [stdout] 615 | | r.id = *shader.0; [INFO] [stdout] 616 | | r.grid = shader.1.grid.clone(); [INFO] [stdout] ... | [INFO] [stdout] 619 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 613 ~ if loc.y < header_height [INFO] [stdout] 614 ~ && let Some(shader) = module.routines.get_index(0) { [INFO] [stdout] 615 | r.id = *shader.0; [INFO] [stdout] 616 | r.grid = shader.1.grid.clone(); [INFO] [stdout] 617 | return true; [INFO] [stdout] 618 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:1103:17 [INFO] [stdout] | [INFO] [stdout] 1103 | / if let Some(pos) = self.grid_ctx.current_cell { [INFO] [stdout] 1104 | | if let Some(item) = r.grid.grid.get(&pos) { [INFO] [stdout] 1105 | | let nodeui = item.create_settings(&palette, self.module_type); [INFO] [stdout] 1106 | | self.apply_toolbar_settings(ui, ctx, &nodeui); [INFO] [stdout] ... | [INFO] [stdout] 1109 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1103 ~ if let Some(pos) = self.grid_ctx.current_cell [INFO] [stdout] 1104 ~ && let Some(item) = r.grid.grid.get(&pos) { [INFO] [stdout] 1105 | let nodeui = item.create_settings(&palette, self.module_type); [INFO] [stdout] 1106 | self.apply_toolbar_settings(ui, ctx, &nodeui); [INFO] [stdout] 1107 | handled = true; [INFO] [stdout] 1108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:637:17 [INFO] [stdout] | [INFO] [stdout] 637 | / if id.name == self.get_view_name() { [INFO] [stdout] 638 | | self.redraw(ui, ctx); [INFO] [stdout] 639 | | [INFO] [stdout] 640 | | redraw = true; [INFO] [stdout] 641 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 636 ~ TheEvent::WidgetResized(id, _dim) [INFO] [stdout] 637 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 638 | self.redraw(ui, ctx); [INFO] [stdout] 639 | [INFO] [stdout] 640 | redraw = true; [INFO] [stdout] 641 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:644:17 [INFO] [stdout] | [INFO] [stdout] 644 | / if id.name == self.get_view_name() { [INFO] [stdout] 645 | | if let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] 646 | | let view_port_height = renderview.dim().height; [INFO] [stdout] 647 | | let view_port_width = renderview.dim().width; [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 643 ~ TheEvent::RenderViewScrollBy(id, coord) [INFO] [stdout] 644 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 645 | if let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] ... [INFO] [stdout] 687 | } [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:929:17 [INFO] [stdout] | [INFO] [stdout] 929 | / if id.name == "Code Editor Code List Item" { [INFO] [stdout] 930 | | // if let Some(atom) = Some(self.create_atom(text.as_str(), id.uuid)) { [INFO] [stdout] 931 | | let mut drop = TheDrop::new(TheId::named("Code Editor Atom")); [INFO] [stdout] ... | [INFO] [stdout] 938 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 928 ~ TheEvent::DragStarted(id, text, offset) [INFO] [stdout] 929 ~ if id.name == "Code Editor Code List Item" => { [INFO] [stdout] 930 | // if let Some(atom) = Some(self.create_atom(text.as_str(), id.uuid)) { [INFO] [stdout] ... [INFO] [stdout] 937 | // } [INFO] [stdout] 938 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:1025:17 [INFO] [stdout] | [INFO] [stdout] 1025 | / if id.name == self.get_view_name() { [INFO] [stdout] 1026 | | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] 1027 | | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] 1028 | | for r in self.routines.values_mut() { [INFO] [stdout] ... | [INFO] [stdout] 1048 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1024 ~ TheEvent::RenderViewContext(id, coord) [INFO] [stdout] 1025 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 1026 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] ... [INFO] [stdout] 1047 | } [INFO] [stdout] 1048 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/module.rs:1051:17 [INFO] [stdout] | [INFO] [stdout] 1051 | / if id.name == self.get_view_name() { [INFO] [stdout] 1052 | | let mut settings: Option = None; [INFO] [stdout] 1053 | | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] 1054 | | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] ... | [INFO] [stdout] 1088 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1050 ~ TheEvent::RenderViewClicked(id, coord) [INFO] [stdout] 1051 ~ if id.name == self.get_view_name() => { [INFO] [stdout] 1052 | let mut settings: Option = None; [INFO] [stdout] ... [INFO] [stdout] 1087 | } [INFO] [stdout] 1088 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:644:17 [INFO] [stdout] | [INFO] [stdout] 644 | / if id.name == self.get_view_name() { [INFO] [stdout] 645 | | if let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] 646 | | let view_port_height = renderview.dim().height; [INFO] [stdout] 647 | | let view_port_width = renderview.dim().width; [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 644 ~ if id.name == self.get_view_name() [INFO] [stdout] 645 ~ && let Some(renderview) = ui.get_render_view(&self.get_view_name()) { [INFO] [stdout] 646 | let view_port_height = renderview.dim().height; [INFO] [stdout] ... [INFO] [stdout] 686 | self.draw(renderview.render_buffer_mut()); [INFO] [stdout] 687 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:1226:9 [INFO] [stdout] | [INFO] [stdout] 1226 | / if self.module_type == ModuleType::Shader { [INFO] [stdout] 1227 | | if let Some((_, routine)) = self.routines.first_mut() { [INFO] [stdout] 1228 | | routine.shader_background = buffer; [INFO] [stdout] 1229 | | self.redraw(ui, ctx); [INFO] [stdout] 1230 | | } [INFO] [stdout] 1231 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1226 ~ if self.module_type == ModuleType::Shader [INFO] [stdout] 1227 ~ && let Some((_, routine)) = self.routines.first_mut() { [INFO] [stdout] 1228 | routine.shader_background = buffer; [INFO] [stdout] 1229 | self.redraw(ui, ctx); [INFO] [stdout] 1230 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:654:40 [INFO] [stdout] | [INFO] [stdout] 654 | let vp_h_i32 = view_port_height as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `view_port_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:672:40 [INFO] [stdout] | [INFO] [stdout] 672 | let vp_w_i32 = view_port_width as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `view_port_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/module.rs:1296:9 [INFO] [stdout] | [INFO] [stdout] 1296 | return self.view_name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1296 - return self.view_name.clone(); [INFO] [stdout] 1296 + self.view_name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:694:17 [INFO] [stdout] | [INFO] [stdout] 694 | / if let Some(focus) = &ctx.ui.focus { [INFO] [stdout] 695 | | if focus.name == self.get_view_name() { [INFO] [stdout] 696 | | let prev = self.to_json(); [INFO] [stdout] 697 | | if let Some(key_code) = key.to_key_code() { [INFO] [stdout] ... | [INFO] [stdout] 775 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 694 ~ if let Some(focus) = &ctx.ui.focus [INFO] [stdout] 695 ~ && focus.name == self.get_view_name() { [INFO] [stdout] 696 | let prev = self.to_json(); [INFO] [stdout] ... [INFO] [stdout] 773 | } [INFO] [stdout] 774 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/routine.rs:130:51 [INFO] [stdout] | [INFO] [stdout] 130 | &TheDim::rect(0, 0, header_width_i32, header_height as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `header_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:180:33 [INFO] [stdout] | [INFO] [stdout] 180 | && Some(coord.clone()) == grid_ctx.current_cell; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/routine.rs:183:25 [INFO] [stdout] | [INFO] [stdout] 183 | &rect, [INFO] [stdout] | ^^^^^ help: change this to: `rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/routine.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 206 | for (c, _) in &self.grid.grid { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 206 - for (c, _) in &self.grid.grid { [INFO] [stdout] 206 + for c in self.grid.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/routine.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / pub fn drop_at( [INFO] [stdout] 216 | | &mut self, [INFO] [stdout] 217 | | loc: Vec2, [INFO] [stdout] 218 | | ctx: &mut TheContext, [INFO] [stdout] ... | [INFO] [stdout] 223 | | settings: &mut Option, [INFO] [stdout] 224 | | ) -> bool { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | / if let Some(rect) = self.grid.grid_rects.get(coord) { [INFO] [stdout] 233 | | if rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 234 | | if item.replaceable { [INFO] [stdout] 235 | | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] ... | [INFO] [stdout] 243 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 232 ~ if let Some(rect) = self.grid.grid_rects.get(coord) [INFO] [stdout] 233 ~ && rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 234 | if item.replaceable { [INFO] [stdout] ... [INFO] [stdout] 241 | break; [INFO] [stdout] 242 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:236:58 [INFO] [stdout] | [INFO] [stdout] 236 | ... grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:237:40 [INFO] [stdout] | [INFO] [stdout] 237 | ... pos = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | / if let Some(pos) = pos { [INFO] [stdout] 248 | | if let Some(cell) = Cell::from_str(&drop.title) { [INFO] [stdout] 249 | | let mut item = CellItem::new(cell); [INFO] [stdout] 250 | | let mut insert = true; [INFO] [stdout] ... | [INFO] [stdout] 316 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 247 ~ if let Some(pos) = pos [INFO] [stdout] 248 ~ && let Some(cell) = Cell::from_str(&drop.title) { [INFO] [stdout] 249 | let mut item = CellItem::new(cell); [INFO] [stdout] ... [INFO] [stdout] 314 | } [INFO] [stdout] 315 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/routine.rs:265:21 [INFO] [stdout] | [INFO] [stdout] 265 | / if self.grid.is_role_at(pos, -1, CellRole::Value) [INFO] [stdout] 266 | | || self.grid.is_role_at(pos, -1, CellRole::Function) [INFO] [stdout] 267 | | { [INFO] [stdout] 268 | | insert = true; [INFO] [stdout] 269 | | } else { [INFO] [stdout] 270 | | insert = false; [INFO] [stdout] 271 | | } [INFO] [stdout] | |_____________________^ help: you can reduce it to: `insert = self.grid.is_role_at(pos, -1, CellRole::Value) || self.grid.is_role_at(pos, -1, CellRole::Function);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/routine.rs:278:21 [INFO] [stdout] | [INFO] [stdout] 278 | / if self.grid.is_role_at(pos, -1, CellRole::Operator) { [INFO] [stdout] 279 | | insert = true; [INFO] [stdout] 280 | | } else { [INFO] [stdout] 281 | | insert = false; [INFO] [stdout] 282 | | } [INFO] [stdout] | |_____________________^ help: you can reduce it to: `insert = self.grid.is_role_at(pos, -1, CellRole::Operator);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:306:44 [INFO] [stdout] | [INFO] [stdout] 306 | item.replaceable = old_item.replaceable.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_item.replaceable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:307:45 [INFO] [stdout] | [INFO] [stdout] 307 | item.dependend_on = old_item.dependend_on.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_item.dependend_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(u32, u32)>` which implements the `Copy` trait [INFO] [stdout] --> src/module.rs:699:52 [INFO] [stdout] | [INFO] [stdout] 699 | ... if let Some(sel) = self.grid_ctx.current_cell.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.grid_ctx.current_cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(rect) = self.grid.grid_rects.get(coord) { [INFO] [stdout] 358 | | if rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 359 | | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] 360 | | if grid_ctx.current_cell != Some(coord.clone()) { [INFO] [stdout] ... | [INFO] [stdout] 371 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(rect) = self.grid.grid_rects.get(coord) [INFO] [stdout] 358 ~ && rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 359 | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] ... [INFO] [stdout] 369 | break; [INFO] [stdout] 370 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:360:58 [INFO] [stdout] | [INFO] [stdout] 360 | if grid_ctx.current_cell != Some(coord.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:361:58 [INFO] [stdout] | [INFO] [stdout] 361 | ... grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:386:13 [INFO] [stdout] | [INFO] [stdout] 386 | / if let Some(rect) = self.grid.grid_rects.get(coord) { [INFO] [stdout] 387 | | if rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 388 | | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] 389 | | grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] ... | [INFO] [stdout] 392 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 386 ~ if let Some(rect) = self.grid.grid_rects.get(coord) [INFO] [stdout] 387 ~ && rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 388 | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] 389 | grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] 390 | return Some(item.generate_context()); [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:389:50 [INFO] [stdout] | [INFO] [stdout] 389 | grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(u32, u32)>` which implements the `Copy` trait [INFO] [stdout] --> src/module.rs:738:52 [INFO] [stdout] | [INFO] [stdout] 738 | ... if let Some(sel) = self.grid_ctx.current_cell.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.grid_ctx.current_cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:790:24 [INFO] [stdout] | [INFO] [stdout] 790 | } else if id.name == "cgfxEventName" { [INFO] [stdout] | ________________________^ [INFO] [stdout] 791 | | if let Some(text) = value.to_string() { [INFO] [stdout] 792 | | if self.grid_ctx.selected_routine.is_none() { [INFO] [stdout] 793 | | if let Some((id, _)) = self.routines.first() { [INFO] [stdout] ... | [INFO] [stdout] 831 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 790 ~ } else if id.name == "cgfxEventName" [INFO] [stdout] 791 ~ && let Some(text) = value.to_string() { [INFO] [stdout] 792 | if self.grid_ctx.selected_routine.is_none() { [INFO] [stdout] ... [INFO] [stdout] 829 | } [INFO] [stdout] 830 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:792:25 [INFO] [stdout] | [INFO] [stdout] 792 | / if self.grid_ctx.selected_routine.is_none() { [INFO] [stdout] 793 | | if let Some((id, _)) = self.routines.first() { [INFO] [stdout] 794 | | self.grid_ctx.selected_routine = Some(*id); [INFO] [stdout] 795 | | } [INFO] [stdout] 796 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 792 ~ if self.grid_ctx.selected_routine.is_none() [INFO] [stdout] 793 ~ && let Some((id, _)) = self.routines.first() { [INFO] [stdout] 794 | self.grid_ctx.selected_routine = Some(*id); [INFO] [stdout] 795 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:808:33 [INFO] [stdout] | [INFO] [stdout] 808 | / ... if let Some(routine) = self.routines.get_mut(&selected_id) { [INFO] [stdout] 809 | | ... if routine.name != text { [INFO] [stdout] 810 | | ... routine.name = text; [INFO] [stdout] 811 | | ... changed = true; [INFO] [stdout] 812 | | ... } [INFO] [stdout] 813 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 808 ~ if let Some(routine) = self.routines.get_mut(&selected_id) [INFO] [stdout] 809 ~ && routine.name != text { [INFO] [stdout] 810 | routine.name = text; [INFO] [stdout] 811 | changed = true; [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:834:21 [INFO] [stdout] | [INFO] [stdout] 834 | / if let Some(value) = value.to_i32() { [INFO] [stdout] 835 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 836 | | event.pixelization = value; [INFO] [stdout] ... | [INFO] [stdout] 848 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 834 ~ if let Some(value) = value.to_i32() [INFO] [stdout] 835 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 836 | event.pixelization = value; [INFO] [stdout] ... [INFO] [stdout] 846 | )); [INFO] [stdout] 847 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:851:21 [INFO] [stdout] | [INFO] [stdout] 851 | / if let Some(value) = value.to_i32() { [INFO] [stdout] 852 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 853 | | event.color_steps = value; [INFO] [stdout] ... | [INFO] [stdout] 865 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 851 ~ if let Some(value) = value.to_i32() [INFO] [stdout] 852 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 853 | event.color_steps = value; [INFO] [stdout] ... [INFO] [stdout] 863 | )); [INFO] [stdout] 864 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:868:21 [INFO] [stdout] | [INFO] [stdout] 868 | / if let Some(value) = value.to_f32() { [INFO] [stdout] 869 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 870 | | event.rotation = value; [INFO] [stdout] ... | [INFO] [stdout] 882 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 868 ~ if let Some(value) = value.to_f32() [INFO] [stdout] 869 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 870 | event.rotation = value; [INFO] [stdout] ... [INFO] [stdout] 880 | )); [INFO] [stdout] 881 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:885:21 [INFO] [stdout] | [INFO] [stdout] 885 | / if let Some(value) = value.to_f32() { [INFO] [stdout] 886 | | if let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 887 | | event.scale = value; [INFO] [stdout] ... | [INFO] [stdout] 899 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 885 ~ if let Some(value) = value.to_f32() [INFO] [stdout] 886 ~ && let Some(event) = self.get_selected_routine_mut() { [INFO] [stdout] 887 | event.scale = value; [INFO] [stdout] ... [INFO] [stdout] 897 | )); [INFO] [stdout] 898 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:514:13 [INFO] [stdout] | [INFO] [stdout] 514 | / if self.name.starts_with("intent: ") { [INFO] [stdout] 515 | | if let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 516 | | *out += &format!( [INFO] [stdout] 517 | | "{:indent$}if event == \"intent\" && value == \"{}\" {{\n", [INFO] [stdout] ... | [INFO] [stdout] 522 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 514 ~ if self.name.starts_with("intent: ") [INFO] [stdout] 515 ~ && let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 516 | *out += &format!( [INFO] [stdout] ... [INFO] [stdout] 520 | handled = true; [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:904:25 [INFO] [stdout] | [INFO] [stdout] 904 | / if Some(r.id) == self.grid_ctx.selected_routine { [INFO] [stdout] 905 | | if let Some(coord) = self.grid_ctx.current_cell { [INFO] [stdout] 906 | | if let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] 907 | | needs_update = [INFO] [stdout] ... | [INFO] [stdout] 912 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 904 ~ if Some(r.id) == self.grid_ctx.selected_routine [INFO] [stdout] 905 ~ && let Some(coord) = self.grid_ctx.current_cell { [INFO] [stdout] 906 | if let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] ... [INFO] [stdout] 910 | } [INFO] [stdout] 911 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:905:29 [INFO] [stdout] | [INFO] [stdout] 905 | / ... if let Some(coord) = self.grid_ctx.current_cell { [INFO] [stdout] 906 | | ... if let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] 907 | | ... needs_update = [INFO] [stdout] 908 | | ... item.apply_value(&id.name, value, self.module_type); [INFO] [stdout] ... | [INFO] [stdout] 911 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 905 ~ if let Some(coord) = self.grid_ctx.current_cell [INFO] [stdout] 906 ~ && let Some(item) = r.grid.grid.get_mut(&coord) { [INFO] [stdout] 907 | needs_update = [INFO] [stdout] 908 | item.apply_value(&id.name, value, self.module_type); [INFO] [stdout] 909 | r.draw(ctx, &self.grid_ctx, 0, None, None); [INFO] [stdout] 910 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:944:33 [INFO] [stdout] | [INFO] [stdout] 944 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:945:33 [INFO] [stdout] | [INFO] [stdout] 945 | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/routine.rs:575:51 [INFO] [stdout] | [INFO] [stdout] 575 | for (_, (item, pos)) in row.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 575 - for (_, (item, pos)) in row.iter().enumerate() { [INFO] [stdout] 575 + for (item, pos) in row.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/module.rs:952:48 [INFO] [stdout] | [INFO] [stdout] 952 | let routine = Routine::new("custom".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"custom"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1026:37 [INFO] [stdout] | [INFO] [stdout] 1026 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1027:37 [INFO] [stdout] | [INFO] [stdout] 1027 | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `draw` doesn't need a mutable reference [INFO] [stdout] --> src/module.rs:1036:45 [INFO] [stdout] | [INFO] [stdout] 1036 | ... r.draw(ctx, &mut self.grid_ctx, 0, None, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1036 - r.draw(ctx, &mut self.grid_ctx, 0, None, None); [INFO] [stdout] 1036 + r.draw(ctx, &self.grid_ctx, 0, None, None); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1053:37 [INFO] [stdout] | [INFO] [stdout] 1053 | let content_x = coord.x as i32 - self.grid_ctx.offset_x; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/module.rs:1054:37 [INFO] [stdout] | [INFO] [stdout] 1054 | let content_y = coord.y as i32 - self.grid_ctx.offset_y; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `coord.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/module.rs:1071:36 [INFO] [stdout] | [INFO] [stdout] 1071 | ... if self.grid_ctx.current_cell == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.grid_ctx.current_cell.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:673:9 [INFO] [stdout] | [INFO] [stdout] 673 | / if self.name.starts_with("intent: ") { [INFO] [stdout] 674 | | if let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 675 | | return format!("Send on '{}' intent", cmd); [INFO] [stdout] 676 | | } [INFO] [stdout] 677 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 673 ~ if self.name.starts_with("intent: ") [INFO] [stdout] 674 ~ && let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 675 | return format!("Send on '{}' intent", cmd); [INFO] [stdout] 676 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:1103:17 [INFO] [stdout] | [INFO] [stdout] 1103 | / if let Some(pos) = self.grid_ctx.current_cell { [INFO] [stdout] 1104 | | if let Some(item) = r.grid.grid.get(&pos) { [INFO] [stdout] 1105 | | let nodeui = item.create_settings(&palette, self.module_type); [INFO] [stdout] 1106 | | self.apply_toolbar_settings(ui, ctx, &nodeui); [INFO] [stdout] ... | [INFO] [stdout] 1109 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1103 ~ if let Some(pos) = self.grid_ctx.current_cell [INFO] [stdout] 1104 ~ && let Some(item) = r.grid.grid.get(&pos) { [INFO] [stdout] 1105 | let nodeui = item.create_settings(&palette, self.module_type); [INFO] [stdout] 1106 | self.apply_toolbar_settings(ui, ctx, &nodeui); [INFO] [stdout] 1107 | handled = true; [INFO] [stdout] 1108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/routine.rs:420:29 [INFO] [stdout] | [INFO] [stdout] 420 | let reserved_vars = vec![ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 421 | | "color", [INFO] [stdout] 422 | | "roughness", [INFO] [stdout] 423 | | "metallic", [INFO] [stdout] ... | [INFO] [stdout] 427 | | "opacity", [INFO] [stdout] 428 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 420 ~ let reserved_vars = ["color", [INFO] [stdout] 421 + "roughness", [INFO] [stdout] 422 + "metallic", [INFO] [stdout] 423 + "uv", [INFO] [stdout] 424 + "normal", [INFO] [stdout] 425 + "bump", [INFO] [stdout] 426 ~ "opacity"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/module.rs:1226:9 [INFO] [stdout] | [INFO] [stdout] 1226 | / if self.module_type == ModuleType::Shader { [INFO] [stdout] 1227 | | if let Some((_, routine)) = self.routines.first_mut() { [INFO] [stdout] 1228 | | routine.shader_background = buffer; [INFO] [stdout] 1229 | | self.redraw(ui, ctx); [INFO] [stdout] 1230 | | } [INFO] [stdout] 1231 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1226 ~ if self.module_type == ModuleType::Shader [INFO] [stdout] 1227 ~ && let Some((_, routine)) = self.routines.first_mut() { [INFO] [stdout] 1228 | routine.shader_background = buffer; [INFO] [stdout] 1229 | self.redraw(ui, ctx); [INFO] [stdout] 1230 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/module.rs:1296:9 [INFO] [stdout] | [INFO] [stdout] 1296 | return self.view_name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1296 - return self.view_name.clone(); [INFO] [stdout] 1296 + self.view_name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/routine.rs:130:51 [INFO] [stdout] | [INFO] [stdout] 130 | &TheDim::rect(0, 0, header_width_i32, header_height as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `header_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:180:33 [INFO] [stdout] | [INFO] [stdout] 180 | && Some(coord.clone()) == grid_ctx.current_cell; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/routine.rs:183:25 [INFO] [stdout] | [INFO] [stdout] 183 | &rect, [INFO] [stdout] | ^^^^^ help: change this to: `rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/routine.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 206 | for (c, _) in &self.grid.grid { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 206 - for (c, _) in &self.grid.grid { [INFO] [stdout] 206 + for c in self.grid.grid.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/routine.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / pub fn drop_at( [INFO] [stdout] 216 | | &mut self, [INFO] [stdout] 217 | | loc: Vec2, [INFO] [stdout] 218 | | ctx: &mut TheContext, [INFO] [stdout] ... | [INFO] [stdout] 223 | | settings: &mut Option, [INFO] [stdout] 224 | | ) -> bool { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | / if let Some(rect) = self.grid.grid_rects.get(coord) { [INFO] [stdout] 233 | | if rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 234 | | if item.replaceable { [INFO] [stdout] 235 | | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] ... | [INFO] [stdout] 243 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 232 ~ if let Some(rect) = self.grid.grid_rects.get(coord) [INFO] [stdout] 233 ~ && rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 234 | if item.replaceable { [INFO] [stdout] ... [INFO] [stdout] 241 | break; [INFO] [stdout] 242 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:236:58 [INFO] [stdout] | [INFO] [stdout] 236 | ... grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:237:40 [INFO] [stdout] | [INFO] [stdout] 237 | ... pos = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | / if let Some(pos) = pos { [INFO] [stdout] 248 | | if let Some(cell) = Cell::from_str(&drop.title) { [INFO] [stdout] 249 | | let mut item = CellItem::new(cell); [INFO] [stdout] 250 | | let mut insert = true; [INFO] [stdout] ... | [INFO] [stdout] 316 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 247 ~ if let Some(pos) = pos [INFO] [stdout] 248 ~ && let Some(cell) = Cell::from_str(&drop.title) { [INFO] [stdout] 249 | let mut item = CellItem::new(cell); [INFO] [stdout] ... [INFO] [stdout] 314 | } [INFO] [stdout] 315 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/routine.rs:265:21 [INFO] [stdout] | [INFO] [stdout] 265 | / if self.grid.is_role_at(pos, -1, CellRole::Value) [INFO] [stdout] 266 | | || self.grid.is_role_at(pos, -1, CellRole::Function) [INFO] [stdout] 267 | | { [INFO] [stdout] 268 | | insert = true; [INFO] [stdout] 269 | | } else { [INFO] [stdout] 270 | | insert = false; [INFO] [stdout] 271 | | } [INFO] [stdout] | |_____________________^ help: you can reduce it to: `insert = self.grid.is_role_at(pos, -1, CellRole::Value) || self.grid.is_role_at(pos, -1, CellRole::Function);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/routine.rs:278:21 [INFO] [stdout] | [INFO] [stdout] 278 | / if self.grid.is_role_at(pos, -1, CellRole::Operator) { [INFO] [stdout] 279 | | insert = true; [INFO] [stdout] 280 | | } else { [INFO] [stdout] 281 | | insert = false; [INFO] [stdout] 282 | | } [INFO] [stdout] | |_____________________^ help: you can reduce it to: `insert = self.grid.is_role_at(pos, -1, CellRole::Operator);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:306:44 [INFO] [stdout] | [INFO] [stdout] 306 | item.replaceable = old_item.replaceable.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_item.replaceable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:307:45 [INFO] [stdout] | [INFO] [stdout] 307 | item.dependend_on = old_item.dependend_on.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_item.dependend_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(rect) = self.grid.grid_rects.get(coord) { [INFO] [stdout] 358 | | if rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 359 | | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] 360 | | if grid_ctx.current_cell != Some(coord.clone()) { [INFO] [stdout] ... | [INFO] [stdout] 371 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(rect) = self.grid.grid_rects.get(coord) [INFO] [stdout] 358 ~ && rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 359 | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] ... [INFO] [stdout] 369 | break; [INFO] [stdout] 370 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:360:58 [INFO] [stdout] | [INFO] [stdout] 360 | if grid_ctx.current_cell != Some(coord.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:361:58 [INFO] [stdout] | [INFO] [stdout] 361 | ... grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:386:13 [INFO] [stdout] | [INFO] [stdout] 386 | / if let Some(rect) = self.grid.grid_rects.get(coord) { [INFO] [stdout] 387 | | if rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 388 | | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] 389 | | grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] ... | [INFO] [stdout] 392 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 386 ~ if let Some(rect) = self.grid.grid_rects.get(coord) [INFO] [stdout] 387 ~ && rect.contains(Vec2::new(loc.x as i32, loc.y as i32)) { [INFO] [stdout] 388 | grid_ctx.selected_routine = Some(self.id); [INFO] [stdout] 389 | grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] 390 | return Some(item.generate_context()); [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u32, u32)` which implements the `Copy` trait [INFO] [stdout] --> src/routine.rs:389:50 [INFO] [stdout] | [INFO] [stdout] 389 | grid_ctx.current_cell = Some(coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:514:13 [INFO] [stdout] | [INFO] [stdout] 514 | / if self.name.starts_with("intent: ") { [INFO] [stdout] 515 | | if let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 516 | | *out += &format!( [INFO] [stdout] 517 | | "{:indent$}if event == \"intent\" && value == \"{}\" {{\n", [INFO] [stdout] ... | [INFO] [stdout] 522 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 514 ~ if self.name.starts_with("intent: ") [INFO] [stdout] 515 ~ && let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 516 | *out += &format!( [INFO] [stdout] ... [INFO] [stdout] 520 | handled = true; [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/routine.rs:575:51 [INFO] [stdout] | [INFO] [stdout] 575 | for (_, (item, pos)) in row.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 575 - for (_, (item, pos)) in row.iter().enumerate() { [INFO] [stdout] 575 + for (item, pos) in row.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/routine.rs:673:9 [INFO] [stdout] | [INFO] [stdout] 673 | / if self.name.starts_with("intent: ") { [INFO] [stdout] 674 | | if let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 675 | | return format!("Send on '{}' intent", cmd); [INFO] [stdout] 676 | | } [INFO] [stdout] 677 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 673 ~ if self.name.starts_with("intent: ") [INFO] [stdout] 674 ~ && let Some(cmd) = self.name.strip_prefix("intent: ") { [INFO] [stdout] 675 | return format!("Send on '{}' intent", cmd); [INFO] [stdout] 676 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/routine.rs:420:29 [INFO] [stdout] | [INFO] [stdout] 420 | let reserved_vars = vec![ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 421 | | "color", [INFO] [stdout] 422 | | "roughness", [INFO] [stdout] 423 | | "metallic", [INFO] [stdout] ... | [INFO] [stdout] 427 | | "opacity", [INFO] [stdout] 428 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 420 ~ let reserved_vars = ["color", [INFO] [stdout] 421 + "roughness", [INFO] [stdout] 422 + "metallic", [INFO] [stdout] 423 + "uv", [INFO] [stdout] 424 + "normal", [INFO] [stdout] 425 + "bump", [INFO] [stdout] 426 ~ "opacity"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 06s [INFO] running `Command { std: "docker" "inspect" "ffe3869060c44d3888a1eb4e823e5b43af7563d8842f2e08ba70d41fca3b56ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffe3869060c44d3888a1eb4e823e5b43af7563d8842f2e08ba70d41fca3b56ef", kill_on_drop: false }` [INFO] [stdout] ffe3869060c44d3888a1eb4e823e5b43af7563d8842f2e08ba70d41fca3b56ef