[INFO] fetching crate code-tester 0.1.0-base.2... [INFO] linting code-tester-0.1.0-base.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate code-tester 0.1.0-base.2 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate code-tester 0.1.0-base.2 [INFO] finished tweaking crates.io crate code-tester 0.1.0-base.2 [INFO] tweaked toml for crates.io crate code-tester 0.1.0-base.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate code-tester 0.1.0-base.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate code-tester 0.1.0-base.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jobserver v0.1.33 [INFO] [stderr] Downloaded wasm-bindgen v0.2.100 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.100 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.100 [INFO] [stderr] Downloaded constant_time_eq v0.3.1 [INFO] [stderr] Downloaded wit-bindgen-rt v0.39.0 [INFO] [stderr] Downloaded derive_arbitrary v1.4.1 [INFO] [stderr] Downloaded once_cell_polyfill v1.70.1 [INFO] [stderr] Downloaded anstyle-wincon v3.0.9 [INFO] [stderr] Downloaded crypto-common v0.1.6 [INFO] [stderr] Downloaded anstyle v1.0.11 [INFO] [stderr] Downloaded clap_lex v0.7.5 [INFO] [stderr] Downloaded pbkdf2 v0.12.2 [INFO] [stderr] Downloaded num-conv v0.1.0 [INFO] [stderr] Downloaded thiserror-impl v2.0.12 [INFO] [stderr] Downloaded zeroize_derive v1.4.2 [INFO] [stderr] Downloaded is_terminal_polyfill v1.70.1 [INFO] [stderr] Downloaded time-core v0.1.4 [INFO] [stderr] Downloaded cfg-if v1.0.1 [INFO] [stderr] Downloaded thiserror v2.0.12 [INFO] [stderr] Downloaded anstyle-query v1.1.3 [INFO] [stderr] Downloaded clap_derive v4.5.40 [INFO] [stderr] Downloaded colored v2.2.0 [INFO] [stderr] Downloaded clap v4.5.40 [INFO] [stderr] Downloaded indexmap v2.9.0 [INFO] [stderr] Downloaded memchr v2.7.5 [INFO] [stderr] Downloaded typenum v1.18.0 [INFO] [stderr] Downloaded clap_builder v4.5.40 [INFO] [stderr] Downloaded hashbrown v0.15.4 [INFO] [stderr] Downloaded time v0.3.41 [INFO] [stderr] Downloaded wasi v0.14.2+wasi-0.2.4 [INFO] [stderr] Downloaded flate2 v1.1.2 [INFO] [stderr] Downloaded serde v1.0.219 [INFO] [stderr] Downloaded zopfli v0.8.2 [INFO] [stderr] Downloaded zip v2.4.2 [INFO] [stderr] Downloaded crc32fast v1.4.2 [INFO] [stderr] Downloaded syn v2.0.104 [INFO] [stderr] Downloaded js-sys v0.3.77 [INFO] [stderr] Downloaded proc-macro2 v1.0.95 [INFO] [stderr] Downloaded arbitrary v1.4.1 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded bitflags v2.9.1 [INFO] [stderr] Downloaded log v0.4.27 [INFO] [stderr] Downloaded quote v1.0.40 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.100 [INFO] [stderr] Downloaded unicode-ident v1.0.18 [INFO] [stderr] Downloaded cc v1.2.27 [INFO] [stderr] Downloaded anstream v0.6.19 [INFO] [stderr] Downloaded bzip2 v0.5.2 [INFO] [stderr] Downloaded deflate64 v0.1.9 [INFO] [stderr] Downloaded serde_derive v1.0.219 [INFO] [stderr] Downloaded zeroize v1.8.1 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.100 [INFO] [stderr] Downloaded deranged v0.4.0 [INFO] [stderr] Downloaded xz2 v0.1.7 [INFO] [stderr] Downloaded bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Downloaded getrandom v0.3.3 [INFO] [stderr] Downloaded zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Downloaded libc v0.2.174 [INFO] [stderr] Downloaded lzma-sys v0.1.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2475eb31838c4c27e4d7d8b052946209f268d1875562d2754884bc66153babe [INFO] running `Command { std: "docker" "start" "-a" "b2475eb31838c4c27e4d7d8b052946209f268d1875562d2754884bc66153babe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2475eb31838c4c27e4d7d8b052946209f268d1875562d2754884bc66153babe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2475eb31838c4c27e4d7d8b052946209f268d1875562d2754884bc66153babe", kill_on_drop: false }` [INFO] [stdout] b2475eb31838c4c27e4d7d8b052946209f268d1875562d2754884bc66153babe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fee7e725227037ec41290d7acc1ba0ac6f230e03356bd4093da32855854eb231 [INFO] running `Command { std: "docker" "start" "-a" "fee7e725227037ec41290d7acc1ba0ac6f230e03356bd4093da32855854eb231", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking zopfli v0.8.2 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling cc v1.2.27 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking bzip2 v0.5.2 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking code-tester v0.1.0-base.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/test/runner.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 40 | / let child = Command::new(self.file.get_file_path()) [INFO] [stdout] 41 | | .stdin(Stdio::piped()) [INFO] [stdout] 42 | | .stdout(Stdio::piped()) [INFO] [stdout] 43 | | .spawn().unwrap(); [INFO] [stdout] | |______________________________________- unnecessary `let` binding [INFO] [stdout] 44 | child [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ Command::new(self.file.get_file_path()) [INFO] [stdout] 42 + .stdin(Stdio::piped()) [INFO] [stdout] 43 + .stdout(Stdio::piped()) [INFO] [stdout] 44 + .spawn().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/test/runner.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 47 | / let child = Command::new(get_default_python()) [INFO] [stdout] 48 | | .arg(self.file.get_file_path()) [INFO] [stdout] 49 | | .stdin(Stdio::piped()) [INFO] [stdout] 50 | | .stdout(Stdio::piped()) [INFO] [stdout] 51 | | .spawn().unwrap(); [INFO] [stdout] | |______________________________________- unnecessary `let` binding [INFO] [stdout] 52 | child [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 ~ Command::new(get_default_python()) [INFO] [stdout] 49 + .arg(self.file.get_file_path()) [INFO] [stdout] 50 + .stdin(Stdio::piped()) [INFO] [stdout] 51 + .stdout(Stdio::piped()) [INFO] [stdout] 52 + .spawn().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/test/runner.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | std::io::Error::new(std::io::ErrorKind::Other, "Failed to open stdin") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 - std::io::Error::new(std::io::ErrorKind::Other, "Failed to open stdin") [INFO] [stdout] 60 + std::io::Error::other("Failed to open stdin") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/test/runner.rs:96:37 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(running_time) = self.running_time.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.running_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Io` [INFO] [stdout] --> src/test/mod.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / enum IoMethod { [INFO] [stdout] 28 | | NormalIo, [INFO] [stdout] 29 | | FolderMultipleIo, [INFO] [stdout] 30 | | ZipMultipleIo, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/test/mod.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(file: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 ~ pub fn new(file: &str, [INFO] [stdout] 35 | input_file: &Option, [INFO] [stdout] ... [INFO] [stdout] 40 | Self { [INFO] [stdout] 41 ~ file: file.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/test/mod.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | time_limit: time_limit.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*time_limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/test/mod.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 46 | no_input: no_input.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*no_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/test/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | if !self.data.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/test/mod.rs:73:43 [INFO] [stdout] | [INFO] [stdout] 73 | let file_path_o = format!("{}", path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/test/mod.rs:76:89 [INFO] [stdout] | [INFO] [stdout] 76 | if file.exists() || (file_o.exists() && path[path.len()-4..] == ".zip".to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*".zip"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/test/mod.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | / match &result.status { [INFO] [stdout] 112 | | CheckerStatus::True => { [INFO] [stdout] 113 | | score += 1 [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 ~ if let CheckerStatus::True = &result.status { [INFO] [stdout] 112 + score += 1 [INFO] [stdout] 113 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/test/mod.rs:130:55 [INFO] [stdout] | [INFO] [stdout] 130 | } else if path[path.len()-4..] == ".zip".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*".zip"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/test/mod.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 131 | ((&path).clone(), path[..path.len()-4].to_string()) [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/test/mod.rs:159:71 [INFO] [stdout] | [INFO] [stdout] 159 | ... let input_file = read_zip_file(&zip_path, &*in_path).unwrap().trim().to_string(); [INFO] [stdout] | ^^^^^^^^^ help: try: `&in_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/test/mod.rs:160:69 [INFO] [stdout] | [INFO] [stdout] 160 | ... let ans_file = read_zip_file(&zip_path, &*ans_path).unwrap().trim().to_string(); [INFO] [stdout] | ^^^^^^^^^^ help: try: `&ans_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/test/mod.rs:171:25 [INFO] [stdout] | [INFO] [stdout] 171 | / match &result.status { [INFO] [stdout] 172 | | CheckerStatus::True => { [INFO] [stdout] 173 | | score += 1 [INFO] [stdout] ... | [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 171 ~ if let CheckerStatus::True = &result.status { [INFO] [stdout] 172 + score += 1 [INFO] [stdout] 173 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/test/mod.rs:194:43 [INFO] [stdout] | [INFO] [stdout] 194 | let ans_file = File::new(&(&self.ans_file).clone().unwrap(), FileType::Text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.ans_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/mod.rs:225:42 [INFO] [stdout] | [INFO] [stdout] 225 | let ans_file = File::new(&ans_file_path, FileType::Text); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `ans_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `result_status` [INFO] [stdout] --> src/test/mod.rs:311:18 [INFO] [stdout] | [INFO] [stdout] 311 | for i in 0..result_status.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 311 - for i in 0..result_status.len() { [INFO] [stdout] 311 + for (i, ) in result_status.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/test/runner.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 40 | / let child = Command::new(self.file.get_file_path()) [INFO] [stdout] 41 | | .stdin(Stdio::piped()) [INFO] [stdout] 42 | | .stdout(Stdio::piped()) [INFO] [stdout] 43 | | .spawn().unwrap(); [INFO] [stdout] | |______________________________________- unnecessary `let` binding [INFO] [stdout] 44 | child [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ Command::new(self.file.get_file_path()) [INFO] [stdout] 42 + .stdin(Stdio::piped()) [INFO] [stdout] 43 + .stdout(Stdio::piped()) [INFO] [stdout] 44 + .spawn().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/test/runner.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 47 | / let child = Command::new(get_default_python()) [INFO] [stdout] 48 | | .arg(self.file.get_file_path()) [INFO] [stdout] 49 | | .stdin(Stdio::piped()) [INFO] [stdout] 50 | | .stdout(Stdio::piped()) [INFO] [stdout] 51 | | .spawn().unwrap(); [INFO] [stdout] | |______________________________________- unnecessary `let` binding [INFO] [stdout] 52 | child [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 ~ Command::new(get_default_python()) [INFO] [stdout] 49 + .arg(self.file.get_file_path()) [INFO] [stdout] 50 + .stdin(Stdio::piped()) [INFO] [stdout] 51 + .stdout(Stdio::piped()) [INFO] [stdout] 52 + .spawn().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/test/runner.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | std::io::Error::new(std::io::ErrorKind::Other, "Failed to open stdin") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 - std::io::Error::new(std::io::ErrorKind::Other, "Failed to open stdin") [INFO] [stdout] 60 + std::io::Error::other("Failed to open stdin") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/test/runner.rs:96:37 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(running_time) = self.running_time.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.running_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Io` [INFO] [stdout] --> src/test/mod.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / enum IoMethod { [INFO] [stdout] 28 | | NormalIo, [INFO] [stdout] 29 | | FolderMultipleIo, [INFO] [stdout] 30 | | ZipMultipleIo, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/test/mod.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(file: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 ~ pub fn new(file: &str, [INFO] [stdout] 35 | input_file: &Option, [INFO] [stdout] ... [INFO] [stdout] 40 | Self { [INFO] [stdout] 41 ~ file: file.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/test/mod.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | time_limit: time_limit.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*time_limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/test/mod.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 46 | no_input: no_input.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*no_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/test/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | if !self.data.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/test/mod.rs:73:43 [INFO] [stdout] | [INFO] [stdout] 73 | let file_path_o = format!("{}", path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/test/mod.rs:76:89 [INFO] [stdout] | [INFO] [stdout] 76 | if file.exists() || (file_o.exists() && path[path.len()-4..] == ".zip".to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*".zip"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/test/mod.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | / match &result.status { [INFO] [stdout] 112 | | CheckerStatus::True => { [INFO] [stdout] 113 | | score += 1 [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 ~ if let CheckerStatus::True = &result.status { [INFO] [stdout] 112 + score += 1 [INFO] [stdout] 113 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/test/mod.rs:130:55 [INFO] [stdout] | [INFO] [stdout] 130 | } else if path[path.len()-4..] == ".zip".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*".zip"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/test/mod.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 131 | ((&path).clone(), path[..path.len()-4].to_string()) [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/test/mod.rs:159:71 [INFO] [stdout] | [INFO] [stdout] 159 | ... let input_file = read_zip_file(&zip_path, &*in_path).unwrap().trim().to_string(); [INFO] [stdout] | ^^^^^^^^^ help: try: `&in_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/test/mod.rs:160:69 [INFO] [stdout] | [INFO] [stdout] 160 | ... let ans_file = read_zip_file(&zip_path, &*ans_path).unwrap().trim().to_string(); [INFO] [stdout] | ^^^^^^^^^^ help: try: `&ans_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/test/mod.rs:171:25 [INFO] [stdout] | [INFO] [stdout] 171 | / match &result.status { [INFO] [stdout] 172 | | CheckerStatus::True => { [INFO] [stdout] 173 | | score += 1 [INFO] [stdout] ... | [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 171 ~ if let CheckerStatus::True = &result.status { [INFO] [stdout] 172 + score += 1 [INFO] [stdout] 173 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/test/mod.rs:194:43 [INFO] [stdout] | [INFO] [stdout] 194 | let ans_file = File::new(&(&self.ans_file).clone().unwrap(), FileType::Text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.ans_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/mod.rs:225:42 [INFO] [stdout] | [INFO] [stdout] 225 | let ans_file = File::new(&ans_file_path, FileType::Text); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `ans_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `result_status` [INFO] [stdout] --> src/test/mod.rs:311:18 [INFO] [stdout] | [INFO] [stdout] 311 | for i in 0..result_status.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 311 - for i in 0..result_status.len() { [INFO] [stdout] 311 + for (i, ) in result_status.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.60s [INFO] running `Command { std: "docker" "inspect" "fee7e725227037ec41290d7acc1ba0ac6f230e03356bd4093da32855854eb231", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fee7e725227037ec41290d7acc1ba0ac6f230e03356bd4093da32855854eb231", kill_on_drop: false }` [INFO] [stdout] fee7e725227037ec41290d7acc1ba0ac6f230e03356bd4093da32855854eb231