[INFO] fetching crate cnfg 0.1.2... [INFO] linting cnfg-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cnfg 0.1.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate cnfg 0.1.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cnfg 0.1.2 [INFO] tweaked toml for crates.io crate cnfg 0.1.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cnfg 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate cnfg 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cnfg-derive v0.1.1 [INFO] [stderr] Downloaded tempfile v3.22.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e08de50ccb84e19581921d70a171c26149059afab3c0adf8c7e1b3d4313c989e [INFO] running `Command { std: "docker" "start" "-a" "e08de50ccb84e19581921d70a171c26149059afab3c0adf8c7e1b3d4313c989e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e08de50ccb84e19581921d70a171c26149059afab3c0adf8c7e1b3d4313c989e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e08de50ccb84e19581921d70a171c26149059afab3c0adf8c7e1b3d4313c989e", kill_on_drop: false }` [INFO] [stdout] e08de50ccb84e19581921d70a171c26149059afab3c0adf8c7e1b3d4313c989e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42044621cb27705eaf2886e168e18cca460edb0b72ced582fecab55592e048fd [INFO] running `Command { std: "docker" "start" "-a" "42044621cb27705eaf2886e168e18cca460edb0b72ced582fecab55592e048fd", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde_core v1.0.226 [INFO] [stderr] Compiling serde v1.0.226 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking tempfile v3.22.0 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.226 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling cnfg-derive v0.1.1 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking cnfg v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/loader.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(env_name) = spec.env { [INFO] [stdout] 119 | | if let Ok(val) = env::var(env_name) { [INFO] [stdout] 120 | | let parsed = parse_literal(&val, spec.kind) [INFO] [stdout] 121 | | .map_err(|msg| CnfgError::Env(format!("{env_name}: {msg}")))?; [INFO] [stdout] ... | [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(env_name) = spec.env [INFO] [stdout] 119 ~ && let Ok(val) = env::var(env_name) { [INFO] [stdout] 120 | let parsed = parse_literal(&val, spec.kind) [INFO] [stdout] 121 | .map_err(|msg| CnfgError::Env(format!("{env_name}: {msg}")))?; [INFO] [stdout] 122 | insert_path(root, &spec.segments(), parsed); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/merge.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if !current.get(*part).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current.get(*part).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/loader.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(env_name) = spec.env { [INFO] [stdout] 119 | | if let Ok(val) = env::var(env_name) { [INFO] [stdout] 120 | | let parsed = parse_literal(&val, spec.kind) [INFO] [stdout] 121 | | .map_err(|msg| CnfgError::Env(format!("{env_name}: {msg}")))?; [INFO] [stdout] ... | [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(env_name) = spec.env [INFO] [stdout] 119 ~ && let Ok(val) = env::var(env_name) { [INFO] [stdout] 120 | let parsed = parse_literal(&val, spec.kind) [INFO] [stdout] 121 | .map_err(|msg| CnfgError::Env(format!("{env_name}: {msg}")))?; [INFO] [stdout] 122 | insert_path(root, &spec.segments(), parsed); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> tests/nested.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | assert!(NestedParent::required_fields() [INFO] [stdout] | _____________^ [INFO] [stdout] 39 | | .iter() [INFO] [stdout] 40 | | .any(|path| *path == "child.url")); [INFO] [stdout] | |_________________________________________^ help: try: `NestedParent::required_fields().contains(&"child.url")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/merge.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if !current.get(*part).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current.get(*part).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.59s [INFO] running `Command { std: "docker" "inspect" "42044621cb27705eaf2886e168e18cca460edb0b72ced582fecab55592e048fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42044621cb27705eaf2886e168e18cca460edb0b72ced582fecab55592e048fd", kill_on_drop: false }` [INFO] [stdout] 42044621cb27705eaf2886e168e18cca460edb0b72ced582fecab55592e048fd