[INFO] fetching crate cmd-macro 0.1.2... [INFO] linting cmd-macro-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cmd-macro 0.1.2 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate cmd-macro 0.1.2 [INFO] finished tweaking crates.io crate cmd-macro 0.1.2 [INFO] tweaked toml for crates.io crate cmd-macro 0.1.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cmd-macro 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded boolinator v2.4.0 [INFO] [stderr] Downloaded cmd-derive v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 817d64240593d1de84527b1fc87f1ce59d4e484b10af17ce326f3fa817ea9643 [INFO] running `Command { std: "docker" "start" "-a" "817d64240593d1de84527b1fc87f1ce59d4e484b10af17ce326f3fa817ea9643", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "817d64240593d1de84527b1fc87f1ce59d4e484b10af17ce326f3fa817ea9643", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "817d64240593d1de84527b1fc87f1ce59d4e484b10af17ce326f3fa817ea9643", kill_on_drop: false }` [INFO] [stdout] 817d64240593d1de84527b1fc87f1ce59d4e484b10af17ce326f3fa817ea9643 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 394919b664bc9f1a287ae458872d77b7a1205d2ca2d73d8aeae2becb8d72a680 [INFO] running `Command { std: "docker" "start" "-a" "394919b664bc9f1a287ae458872d77b7a1205d2ca2d73d8aeae2becb8d72a680", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling cmd-derive v0.1.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking cmd-macro v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/env.rs:404:21 [INFO] [stdout] | [INFO] [stdout] 404 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/env.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | / impl Default for VarOption { [INFO] [stdout] 63 | | fn default() -> Self { [INFO] [stdout] 64 | | VarOption::None [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 51 + #[derive(Default)] [INFO] [stdout] 52 | pub enum VarOption { [INFO] [stdout] 53 ~ #[default] [INFO] [stdout] 54 ~ None, // $VAR or ${VAR} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/env.rs:214:20 [INFO] [stdout] | [INFO] [stdout] 214 | return Ok(parse_var_options(&mut buffer.into_iter().peekable())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 214 - return Ok(parse_var_options(&mut buffer.into_iter().peekable())?); [INFO] [stdout] 214 + return parse_var_options(&mut buffer.into_iter().peekable()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/env.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | if length && !s.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `s.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/env.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | } else if length && name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/env.rs:310:19 [INFO] [stdout] | [INFO] [stdout] 310 | match s.peek().map(|&c| c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `s.peek().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `proc_macro_hygiene` is declared but not used [INFO] [stdout] --> tests/test.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(proc_macro_hygiene)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/env.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | / impl Default for VarOption { [INFO] [stdout] 63 | | fn default() -> Self { [INFO] [stdout] 64 | | VarOption::None [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 51 + #[derive(Default)] [INFO] [stdout] 52 | pub enum VarOption { [INFO] [stdout] 53 ~ #[default] [INFO] [stdout] 54 ~ None, // $VAR or ${VAR} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/env.rs:214:20 [INFO] [stdout] | [INFO] [stdout] 214 | return Ok(parse_var_options(&mut buffer.into_iter().peekable())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 214 - return Ok(parse_var_options(&mut buffer.into_iter().peekable())?); [INFO] [stdout] 214 + return parse_var_options(&mut buffer.into_iter().peekable()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/env.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | if length && !s.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `s.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/env.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | } else if length && name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/env.rs:310:19 [INFO] [stdout] | [INFO] [stdout] 310 | match s.peek().map(|&c| c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `s.peek().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/env.rs:394:17 [INFO] [stdout] | [INFO] [stdout] 394 | let a = 'a' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.07s [INFO] running `Command { std: "docker" "inspect" "394919b664bc9f1a287ae458872d77b7a1205d2ca2d73d8aeae2becb8d72a680", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "394919b664bc9f1a287ae458872d77b7a1205d2ca2d73d8aeae2becb8d72a680", kill_on_drop: false }` [INFO] [stdout] 394919b664bc9f1a287ae458872d77b7a1205d2ca2d73d8aeae2becb8d72a680