[INFO] fetching crate ckc-rs 0.1.18... [INFO] linting ckc-rs-0.1.18 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ckc-rs 0.1.18 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate ckc-rs 0.1.18 [INFO] finished tweaking crates.io crate ckc-rs 0.1.18 [INFO] tweaked toml for crates.io crate ckc-rs 0.1.18 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ckc-rs 0.1.18 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ckc-rs 0.1.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3064407d23177b72a3fc39d345afd07a0b5862b45cf7ca9a4bb97faf274e910f [INFO] running `Command { std: "docker" "start" "-a" "3064407d23177b72a3fc39d345afd07a0b5862b45cf7ca9a4bb97faf274e910f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3064407d23177b72a3fc39d345afd07a0b5862b45cf7ca9a4bb97faf274e910f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3064407d23177b72a3fc39d345afd07a0b5862b45cf7ca9a4bb97faf274e910f", kill_on_drop: false }` [INFO] [stdout] 3064407d23177b72a3fc39d345afd07a0b5862b45cf7ca9a4bb97faf274e910f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0cd4923c6fb0f2ed9e6ebecf28a2eded9c28546e5674791e3e796f6b984fd3e7 [INFO] running `Command { std: "docker" "start" "-a" "0cd4923c6fb0f2ed9e6ebecf28a2eded9c28546e5674791e3e796f6b984fd3e7", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling hashbrown v0.15.4 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Compiling winnow v0.7.11 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling cfg-if v1.0.1 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling rstest_macros v0.25.0 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Compiling strum_macros v0.27.1 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking strum v0.27.1 [INFO] [stderr] Checking rstest v0.25.0 [INFO] [stderr] Checking ckc-rs v0.1.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/cards/five.rs:2116:9 [INFO] [stdout] | [INFO] [stdout] 2116 | assert_eq!("00000000000000001000100000000001", format!("{:032b}", and_bits)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | #![warn(clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2116 - assert_eq!("00000000000000001000100000000001", format!("{:032b}", and_bits)); [INFO] [stdout] 2116 + assert_eq!("00000000000000001000100000000001", format!("{and_bits:032b}")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/cards/five.rs:2170:9 [INFO] [stdout] | [INFO] [stdout] 2170 | assert_eq!("0001111100000000", format!("{:016b}", or)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2170 - assert_eq!("0001111100000000", format!("{:016b}", or)); [INFO] [stdout] 2170 + assert_eq!("0001111100000000", format!("{or:016b}")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/cards/five.rs:2171:9 [INFO] [stdout] | [INFO] [stdout] 2171 | assert_eq!("00000000000000000001111100000000", format!("{:032b}", or)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2171 - assert_eq!("00000000000000000001111100000000", format!("{:032b}", or)); [INFO] [stdout] 2171 + assert_eq!("00000000000000000001111100000000", format!("{or:032b}")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/cards/five.rs:2307:9 [INFO] [stdout] | [INFO] [stdout] 2307 | / assert_eq!( [INFO] [stdout] 2308 | | Five::try_from("4♥ 4D 2S 2C A♥").unwrap().shift_suit(), [INFO] [stdout] 2309 | | Five::try_from("4D 4C 2H 2S AD").unwrap() [INFO] [stdout] 2310 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 2307 | assert_eq!( [INFO] [stdout] 2308 | Five::try_from("4♥ 4D 2S 2C A♥").unwrap().shift_suit(), [INFO] [stdout] 2309 | Five::try_from("4D 4C 2H 2S AD").unwrap() [INFO] [stdout] 2310 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/cards/four.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | / assert_eq!( [INFO] [stdout] 189 | | Four::try_from("AH KH QH JH").unwrap().shift_suit(), [INFO] [stdout] 190 | | Four::try_from("AD KD QD JD").unwrap() [INFO] [stdout] 191 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 188 | assert_eq!( [INFO] [stdout] 189 | Four::try_from("AH KH QH JH").unwrap().shift_suit(), [INFO] [stdout] 190 | Four::try_from("AD KD QD JD").unwrap() [INFO] [stdout] 191 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/cards/seven.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | / assert_eq!( [INFO] [stdout] 328 | | Seven::try_from("A♠ K♠ Q♠ J♠ T♠ 9♠ 8♠").unwrap().shift_suit(), [INFO] [stdout] 329 | | Seven::try_from("A♥ K♥ Q♥ J♥ T♥ 9♥ 8♥").unwrap() [INFO] [stdout] 330 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 327 | assert_eq!( [INFO] [stdout] 328 | Seven::try_from("A♠ K♠ Q♠ J♠ T♠ 9♠ 8♠").unwrap().shift_suit(), [INFO] [stdout] 329 | Seven::try_from("A♥ K♥ Q♥ J♥ T♥ 9♥ 8♥").unwrap() [INFO] [stdout] 330 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/cards/six.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | / assert_eq!( [INFO] [stdout] 287 | | Six::try_from("T♠ A♠ K♠ J♠ Q♠ 9♠").unwrap().shift_suit(), [INFO] [stdout] 288 | | Six::try_from("T♥ A♥ K♥ J♥ Q♥ 9♥").unwrap() [INFO] [stdout] 289 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 286 | assert_eq!( [INFO] [stdout] 287 | Six::try_from("T♠ A♠ K♠ J♠ Q♠ 9♠").unwrap().shift_suit(), [INFO] [stdout] 288 | Six::try_from("T♥ A♥ K♥ J♥ Q♥ 9♥").unwrap() [INFO] [stdout] 289 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/cards/three.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / assert_eq!( [INFO] [stdout] 167 | | Three::try_from("A♠ K♠ Q♠").unwrap().shift_suit(), [INFO] [stdout] 168 | | Three::try_from("AH KH QH").unwrap() [INFO] [stdout] 169 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 166 | assert_eq!( [INFO] [stdout] 167 | Three::try_from("A♠ K♠ Q♠").unwrap().shift_suit(), [INFO] [stdout] 168 | Three::try_from("AH KH QH").unwrap() [INFO] [stdout] 169 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/cards/two.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 376 | / assert_eq!( [INFO] [stdout] 377 | | Two::try_from("AS AD").unwrap().shift_suit(), [INFO] [stdout] 378 | | Two::try_from("AH AC").unwrap() [INFO] [stdout] 379 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 376 | assert_eq!( [INFO] [stdout] 377 | Two::try_from("AS AD").unwrap().shift_suit(), [INFO] [stdout] 378 | Two::try_from("AH AC").unwrap() [INFO] [stdout] 379 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cards/two.rs:386:17 [INFO] [stdout] | [INFO] [stdout] 386 | assert!(!t.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `t.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: strict comparison of `f32` or `f64` [INFO] [stdout] --> src/lib.rs:851:9 [INFO] [stdout] | [INFO] [stdout] 851 | assert_eq!(CKCNumber::from_index(index).get_chen_points(), expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stdout] = note: `#[warn(clippy::float_cmp)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.21s [INFO] running `Command { std: "docker" "inspect" "0cd4923c6fb0f2ed9e6ebecf28a2eded9c28546e5674791e3e796f6b984fd3e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cd4923c6fb0f2ed9e6ebecf28a2eded9c28546e5674791e3e796f6b984fd3e7", kill_on_drop: false }` [INFO] [stdout] 0cd4923c6fb0f2ed9e6ebecf28a2eded9c28546e5674791e3e796f6b984fd3e7