[INFO] fetching crate circus 0.1.1... [INFO] linting circus-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate circus 0.1.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate circus 0.1.1 [INFO] finished tweaking crates.io crate circus 0.1.1 [INFO] tweaked toml for crates.io crate circus 0.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate circus 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate circus 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1242da3e60f8e56193b70f51cc9a14b052deeda9e9efde930afb7969b46b01f8 [INFO] running `Command { std: "docker" "start" "-a" "1242da3e60f8e56193b70f51cc9a14b052deeda9e9efde930afb7969b46b01f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1242da3e60f8e56193b70f51cc9a14b052deeda9e9efde930afb7969b46b01f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1242da3e60f8e56193b70f51cc9a14b052deeda9e9efde930afb7969b46b01f8", kill_on_drop: false }` [INFO] [stdout] 1242da3e60f8e56193b70f51cc9a14b052deeda9e9efde930afb7969b46b01f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 224d4cd0454d926d514b793b4889848592aa59d1ab2b80e3d14420dd96d9be60 [INFO] running `Command { std: "docker" "start" "-a" "224d4cd0454d926d514b793b4889848592aa59d1ab2b80e3d14420dd96d9be60", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking circus v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gate/cnot.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | && !(state.x[i][c5] & pwc > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.x[i][c5] & pwc <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gate/cnot.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | && !(state.z[i][b5] & pwb > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.z[i][b5] & pwb <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `PW` [INFO] [stdout] --> src/state.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 221 | for i in 0..g { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 221 - for i in 0..g { [INFO] [stdout] 221 + for (i, ) in PW.iter().enumerate().take(g) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `l` is only used to index `PW` [INFO] [stdout] --> src/state.rs:236:22 [INFO] [stdout] | [INFO] [stdout] 236 | for l in 0..PW.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 236 - for l in 0..PW.len() { [INFO] [stdout] 236 + for in &PW { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/state.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 307 | s.push_str("1") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/state.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | s.push_str("0") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:373:20 [INFO] [stdout] | [INFO] [stdout] 373 | if (!(self.x[i][j5] & pw > 0)) && (!(self.z[i][j5] & pw > 0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.x[i][j5] & pw <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:373:51 [INFO] [stdout] | [INFO] [stdout] 373 | if (!(self.x[i][j5] & pw > 0)) && (!(self.z[i][j5] & pw > 0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.z[i][j5] & pw <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:376:48 [INFO] [stdout] | [INFO] [stdout] 376 | if (self.x[i][j5] & pw > 0) && (!(self.z[i][j5] & pw > 0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.z[i][j5] & pw <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gate/cnot.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | && !(state.x[i][c5] & pwc > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.x[i][c5] & pwc <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gate/cnot.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | && !(state.z[i][b5] & pwb > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.z[i][b5] & pwb <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `PW` [INFO] [stdout] --> src/state.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 221 | for i in 0..g { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 221 - for i in 0..g { [INFO] [stdout] 221 + for (i, ) in PW.iter().enumerate().take(g) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `l` is only used to index `PW` [INFO] [stdout] --> src/state.rs:236:22 [INFO] [stdout] | [INFO] [stdout] 236 | for l in 0..PW.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 236 - for l in 0..PW.len() { [INFO] [stdout] 236 + for in &PW { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/state.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 307 | s.push_str("1") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('1')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/state.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | s.push_str("0") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:373:20 [INFO] [stdout] | [INFO] [stdout] 373 | if (!(self.x[i][j5] & pw > 0)) && (!(self.z[i][j5] & pw > 0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.x[i][j5] & pw <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:373:51 [INFO] [stdout] | [INFO] [stdout] 373 | if (!(self.x[i][j5] & pw > 0)) && (!(self.z[i][j5] & pw > 0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.z[i][j5] & pw <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:376:48 [INFO] [stdout] | [INFO] [stdout] 376 | if (self.x[i][j5] & pw > 0) && (!(self.z[i][j5] & pw > 0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.z[i][j5] & pw <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `Command { std: "docker" "inspect" "224d4cd0454d926d514b793b4889848592aa59d1ab2b80e3d14420dd96d9be60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "224d4cd0454d926d514b793b4889848592aa59d1ab2b80e3d14420dd96d9be60", kill_on_drop: false }` [INFO] [stdout] 224d4cd0454d926d514b793b4889848592aa59d1ab2b80e3d14420dd96d9be60