[INFO] fetching crate checksumdir 0.3.0... [INFO] linting checksumdir-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate checksumdir 0.3.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate checksumdir 0.3.0 [INFO] finished tweaking crates.io crate checksumdir 0.3.0 [INFO] tweaked toml for crates.io crate checksumdir 0.3.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate checksumdir 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.10.1 (available: v0.22.1) [INFO] [stderr] Adding blake2 v0.8.1 (available: v0.10.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crypto-mac v0.7.0 [INFO] [stderr] Downloaded subtle v1.0.0 [INFO] [stderr] Downloaded blake2 v0.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 327a5670bcb1f161250fd0985dfadbc6f0001f06207573cc0d1871ff390fb668 [INFO] running `Command { std: "docker" "start" "-a" "327a5670bcb1f161250fd0985dfadbc6f0001f06207573cc0d1871ff390fb668", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "327a5670bcb1f161250fd0985dfadbc6f0001f06207573cc0d1871ff390fb668", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "327a5670bcb1f161250fd0985dfadbc6f0001f06207573cc0d1871ff390fb668", kill_on_drop: false }` [INFO] [stdout] 327a5670bcb1f161250fd0985dfadbc6f0001f06207573cc0d1871ff390fb668 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a01263c769c73ac1192acb51e1667cd60899e84001e05700ef5e83a99fbf6b35 [INFO] running `Command { std: "docker" "start" "-a" "a01263c769c73ac1192acb51e1667cd60899e84001e05700ef5e83a99fbf6b35", kill_on_drop: false }` [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking blake2 v0.8.1 [INFO] [stderr] Checking checksumdir v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use base64; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lib.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / impl<'a> Default for ChecksumOptions<'a> { [INFO] [stdout] 37 | | fn default() -> ChecksumOptions<'a> { [INFO] [stdout] 38 | | ChecksumOptions { [INFO] [stdout] 39 | | excluded: HashSet::new(), [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 30 + #[derive(Default)] [INFO] [stdout] 31 | pub struct ChecksumOptions<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | / !(opts.ignore_hidden && is_hidden(e)) && [INFO] [stdout] 72 | | !is_in_list(&opts.excluded, e) [INFO] [stdout] | |______________________________________________^ help: try: `!(is_in_list(&opts.excluded, e) || opts.ignore_hidden && is_hidden(e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | fn is_in_list<'a>(list: &HashSet<&'a str>, entry: &DirEntry) -> bool { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 112 - fn is_in_list<'a>(list: &HashSet<&'a str>, entry: &DirEntry) -> bool { [INFO] [stdout] 112 + fn is_in_list(list: &HashSet<&str>, entry: &DirEntry) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use base64; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lib.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / impl<'a> Default for ChecksumOptions<'a> { [INFO] [stdout] 37 | | fn default() -> ChecksumOptions<'a> { [INFO] [stdout] 38 | | ChecksumOptions { [INFO] [stdout] 39 | | excluded: HashSet::new(), [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 30 + #[derive(Default)] [INFO] [stdout] 31 | pub struct ChecksumOptions<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | / !(opts.ignore_hidden && is_hidden(e)) && [INFO] [stdout] 72 | | !is_in_list(&opts.excluded, e) [INFO] [stdout] | |______________________________________________^ help: try: `!(is_in_list(&opts.excluded, e) || opts.ignore_hidden && is_hidden(e))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | fn is_in_list<'a>(list: &HashSet<&'a str>, entry: &DirEntry) -> bool { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 112 - fn is_in_list<'a>(list: &HashSet<&'a str>, entry: &DirEntry) -> bool { [INFO] [stdout] 112 + fn is_in_list(list: &HashSet<&str>, entry: &DirEntry) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `Command { std: "docker" "inspect" "a01263c769c73ac1192acb51e1667cd60899e84001e05700ef5e83a99fbf6b35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a01263c769c73ac1192acb51e1667cd60899e84001e05700ef5e83a99fbf6b35", kill_on_drop: false }` [INFO] [stdout] a01263c769c73ac1192acb51e1667cd60899e84001e05700ef5e83a99fbf6b35