[INFO] fetching crate chair-rb 0.1.0... [INFO] linting chair-rb-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate chair-rb 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate chair-rb 0.1.0 [INFO] finished tweaking crates.io crate chair-rb 0.1.0 [INFO] tweaked toml for crates.io crate chair-rb 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate chair-rb 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate chair-rb 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcd85106c4b3012ac078f747162c7fdbe7b2ac10a0b10d6f7a3d97de5f818547 [INFO] running `Command { std: "docker" "start" "-a" "dcd85106c4b3012ac078f747162c7fdbe7b2ac10a0b10d6f7a3d97de5f818547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcd85106c4b3012ac078f747162c7fdbe7b2ac10a0b10d6f7a3d97de5f818547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcd85106c4b3012ac078f747162c7fdbe7b2ac10a0b10d6f7a3d97de5f818547", kill_on_drop: false }` [INFO] [stdout] dcd85106c4b3012ac078f747162c7fdbe7b2ac10a0b10d6f7a3d97de5f818547 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7e93c51f25a0084023468114f721164ec19d8f79bec12bb7630a7d13d9c9dd2 [INFO] running `Command { std: "docker" "start" "-a" "d7e93c51f25a0084023468114f721164ec19d8f79bec12bb7630a7d13d9c9dd2", kill_on_drop: false }` [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking chair-rb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `disable_bounds_check` [INFO] [stdout] --> src/concurrent/mod.rs:199:11 [INFO] [stdout] | [INFO] [stdout] 199 | #[cfg(disable_bounds_check)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(disable_bounds_check)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(disable_bounds_check)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `disable_bounds_check` [INFO] [stdout] --> src/concurrent/mod.rs:203:15 [INFO] [stdout] | [INFO] [stdout] 203 | #[cfg(not(disable_bounds_check))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(disable_bounds_check)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(disable_bounds_check)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `disable_bounds_check` [INFO] [stdout] --> src/concurrent/mod.rs:199:11 [INFO] [stdout] | [INFO] [stdout] 199 | #[cfg(disable_bounds_check)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(disable_bounds_check)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(disable_bounds_check)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `disable_bounds_check` [INFO] [stdout] --> src/concurrent/mod.rs:203:15 [INFO] [stdout] | [INFO] [stdout] 203 | #[cfg(not(disable_bounds_check))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(disable_bounds_check)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(disable_bounds_check)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | pub unsafe fn get_volatile(source: *const T) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | pub unsafe fn put_ordered(dest: *mut T, value: T) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | pub unsafe fn get_and_add_i64(src: *const i64, increment: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | pub unsafe fn compare_exchange(address: *const i64, expected: i64, desired: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:93:56 [INFO] [stdout] | [INFO] [stdout] 93 | let to_buffer_end_length = self.capacity - tail_index as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `tail_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / return self [INFO] [stdout] 229 | | .buffer [INFO] [stdout] 230 | | .get_and_add_i64(self.correlation_id_counter_index, 1); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ self [INFO] [stdout] 229 + .buffer [INFO] [stdout] 230 ~ .get_and_add_i64(self.correlation_id_counter_index, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | if !(i < limit) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(i >= limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:302:5 [INFO] [stdout] | [INFO] [stdout] 302 | return all_zeroes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 302 - return all_zeroes; [INFO] [stdout] 302 + all_zeroes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return true; [INFO] [stdout] 148 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | / return self [INFO] [stdout] 207 | | .buffer [INFO] [stdout] 208 | | .get_and_add_i64(self.correlation_id_counter_index, 1); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 ~ self [INFO] [stdout] 207 + .buffer [INFO] [stdout] 208 ~ .get_and_add_i64(self.correlation_id_counter_index, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/mod.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | return original == expected_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return original == expected_value; [INFO] [stdout] 195 + original == expected_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> examples/java/main.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | .args(&["/C", "gradlew", "run"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "gradlew", "run"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> examples/one_to_one.rs:15:33 [INFO] [stdout] | [INFO] [stdout] 15 | let mut buf = Align16::new([0 as u8; 1024 + RingBufferDescriptor::TRAILER_LENGTH as usize]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> examples/one_to_one.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | u32::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 72 - u32::max_value(), [INFO] [stdout] 72 + u32::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | pub unsafe fn get_volatile(source: *const T) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | pub unsafe fn put_ordered(dest: *mut T, value: T) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | pub unsafe fn get_and_add_i64(src: *const i64, increment: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/concurrent/atomic.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | pub unsafe fn compare_exchange(address: *const i64, expected: i64, desired: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:93:56 [INFO] [stdout] | [INFO] [stdout] 93 | let to_buffer_end_length = self.capacity - tail_index as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `tail_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / return self [INFO] [stdout] 229 | | .buffer [INFO] [stdout] 230 | | .get_and_add_i64(self.correlation_id_counter_index, 1); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ self [INFO] [stdout] 229 + .buffer [INFO] [stdout] 230 ~ .get_and_add_i64(self.correlation_id_counter_index, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | if !(i < limit) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(i >= limit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:302:5 [INFO] [stdout] | [INFO] [stdout] 302 | return all_zeroes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 302 - return all_zeroes; [INFO] [stdout] 302 + all_zeroes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:333:48 [INFO] [stdout] | [INFO] [stdout] 333 | let mut buffer = Align16::new(vec![0 as u8; buffer_size]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:334:52 [INFO] [stdout] | [INFO] [stdout] 334 | let mut src_buffer = Align16::new(vec![0 as u8; buffer_size]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:370:46 [INFO] [stdout] | [INFO] [stdout] 370 | let mut test_buffer = *Align16::new([0 as u8; ODD_BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:553:51 [INFO] [stdout] | [INFO] [stdout] 553 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 553 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 553 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:581:51 [INFO] [stdout] | [INFO] [stdout] 581 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 581 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 581 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:620:51 [INFO] [stdout] | [INFO] [stdout] 620 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 620 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 620 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:647:43 [INFO] [stdout] | [INFO] [stdout] 647 | RecordDescriptor::type_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:651:45 [INFO] [stdout] | [INFO] [stdout] 651 | RecordDescriptor::length_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:658:51 [INFO] [stdout] | [INFO] [stdout] 658 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 658 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 658 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:698:43 [INFO] [stdout] | [INFO] [stdout] 698 | RecordDescriptor::type_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:702:45 [INFO] [stdout] | [INFO] [stdout] 702 | RecordDescriptor::length_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:753:43 [INFO] [stdout] | [INFO] [stdout] 753 | RecordDescriptor::type_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:757:45 [INFO] [stdout] | [INFO] [stdout] 757 | RecordDescriptor::length_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:771:17 [INFO] [stdout] | [INFO] [stdout] 771 | u32::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 771 - u32::max_value(), [INFO] [stdout] 771 + u32::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:942:45 [INFO] [stdout] | [INFO] [stdout] 942 | let mut mpsc_buffer = Align16::new([0 as u8; BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:971:35 [INFO] [stdout] | [INFO] [stdout] 971 | (NUM_IDS_PER_THREAD * NUM_PUBLISHERS as i32) as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `NUM_PUBLISHERS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:977:45 [INFO] [stdout] | [INFO] [stdout] 977 | let mut mpsc_buffer = Align16::new([0 as u8; BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:1000:52 [INFO] [stdout] | [INFO] [stdout] 1000 | let mut src_buffer = Align16::new([0 as u8; BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/many_to_one_ring_buffer.rs:1029:17 [INFO] [stdout] | [INFO] [stdout] 1029 | u32::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1029 - u32::max_value(), [INFO] [stdout] 1029 + u32::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return true; [INFO] [stdout] 148 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> examples/many_to_one.rs:17:33 [INFO] [stdout] | [INFO] [stdout] 17 | let mut buf = Align16::new([0 as u8; 1024 + RingBufferDescriptor::TRAILER_LENGTH as usize]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> examples/many_to_one.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | u32::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 89 - u32::max_value(), [INFO] [stdout] 89 + u32::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | / return self [INFO] [stdout] 207 | | .buffer [INFO] [stdout] 208 | | .get_and_add_i64(self.correlation_id_counter_index, 1); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 ~ self [INFO] [stdout] 207 + .buffer [INFO] [stdout] 208 ~ .get_and_add_i64(self.correlation_id_counter_index, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:244:48 [INFO] [stdout] | [INFO] [stdout] 244 | let mut buffer = Align16::new(vec![0 as u8; buffer_size]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:245:52 [INFO] [stdout] | [INFO] [stdout] 245 | let mut src_buffer = Align16::new(vec![0 as u8; buffer_size]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:281:45 [INFO] [stdout] | [INFO] [stdout] 281 | let mut test_buffer = Align16::new([0 as u8; ODD_BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:464:51 [INFO] [stdout] | [INFO] [stdout] 464 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 464 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 464 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:492:51 [INFO] [stdout] | [INFO] [stdout] 492 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 492 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 492 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:531:51 [INFO] [stdout] | [INFO] [stdout] 531 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 531 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 531 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:558:43 [INFO] [stdout] | [INFO] [stdout] 558 | RecordDescriptor::type_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:562:45 [INFO] [stdout] | [INFO] [stdout] 562 | RecordDescriptor::length_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:569:51 [INFO] [stdout] | [INFO] [stdout] 569 | .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 569 - .read(|_, _, _, _| times_called += 1, u32::max_value()); [INFO] [stdout] 569 + .read(|_, _, _, _| times_called += 1, u32::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:609:43 [INFO] [stdout] | [INFO] [stdout] 609 | RecordDescriptor::type_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:613:45 [INFO] [stdout] | [INFO] [stdout] 613 | RecordDescriptor::length_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:664:43 [INFO] [stdout] | [INFO] [stdout] 664 | RecordDescriptor::type_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:668:45 [INFO] [stdout] | [INFO] [stdout] 668 | RecordDescriptor::length_offset(0 + aligned_record_length), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `aligned_record_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:682:17 [INFO] [stdout] | [INFO] [stdout] 682 | u32::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 682 - u32::max_value(), [INFO] [stdout] 682 + u32::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:709:45 [INFO] [stdout] | [INFO] [stdout] 709 | let mut spsc_buffer = Align16::new([0 as u8; BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:744:45 [INFO] [stdout] | [INFO] [stdout] 744 | let mut spsc_buffer = Align16::new([0 as u8; BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:750:48 [INFO] [stdout] | [INFO] [stdout] 750 | let mut src_buffer = Align16::new([0 as u8; BUFFER_SZ]); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/concurrent/ring_buffer/one_to_one_ring_buffer.rs:775:17 [INFO] [stdout] | [INFO] [stdout] 775 | u32::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 775 - u32::max_value(), [INFO] [stdout] 775 + u32::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/concurrent/mod.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | return original == expected_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return original == expected_value; [INFO] [stdout] 195 + original == expected_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `Command { std: "docker" "inspect" "d7e93c51f25a0084023468114f721164ec19d8f79bec12bb7630a7d13d9c9dd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7e93c51f25a0084023468114f721164ec19d8f79bec12bb7630a7d13d9c9dd2", kill_on_drop: false }` [INFO] [stdout] d7e93c51f25a0084023468114f721164ec19d8f79bec12bb7630a7d13d9c9dd2