[INFO] fetching crate cedrus-core 0.1.0... [INFO] linting cedrus-core-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cedrus-core 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate cedrus-core 0.1.0 [INFO] finished tweaking crates.io crate cedrus-core 0.1.0 [INFO] tweaked toml for crates.io crate cedrus-core 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cedrus-core 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate cedrus-core 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded compression-core v0.4.29 [INFO] [stderr] Downloaded rustc_lexer v0.1.0 [INFO] [stderr] Downloaded uuid-macro-internal v1.18.1 [INFO] [stderr] Downloaded compression-codecs v0.4.31 [INFO] [stderr] Downloaded aws-types v1.3.9 [INFO] [stderr] Downloaded linked_hash_set v0.1.5 [INFO] [stderr] Downloaded aws-smithy-observability v0.1.4 [INFO] [stderr] Downloaded nonempty v0.12.0 [INFO] [stderr] Downloaded couch_rs_derive v0.12.1 [INFO] [stderr] Downloaded ascii-canvas v4.0.0 [INFO] [stderr] Downloaded term v1.1.0 [INFO] [stderr] Downloaded logos-codegen v0.15.1 [INFO] [stderr] Downloaded unicode-security v0.1.2 [INFO] [stderr] Downloaded aws-runtime v1.5.12 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.86.0 [INFO] [stderr] Downloaded aws-smithy-runtime v1.9.3 [INFO] [stderr] Downloaded aws-sigv4 v1.3.5 [INFO] [stderr] Downloaded aws-smithy-http-client v1.1.3 [INFO] [stderr] Downloaded cedar-policy v4.7.0 [INFO] [stderr] Downloaded serde_with v3.15.1 [INFO] [stderr] Downloaded async-compression v0.4.32 [INFO] [stderr] Downloaded lalrpop v0.22.2 [INFO] [stderr] Downloaded cedar-policy-formatter v4.7.0 [INFO] [stderr] Downloaded serde_with_macros v3.15.1 [INFO] [stderr] Downloaded aws-smithy-http v0.62.4 [INFO] [stderr] Downloaded aws-smithy-runtime-api v1.9.1 [INFO] [stderr] Downloaded aws-smithy-types v1.3.3 [INFO] [stderr] Downloaded redis v0.32.7 [INFO] [stderr] Downloaded aws-smithy-async v1.2.6 [INFO] [stderr] Downloaded lalrpop-util v0.22.2 [INFO] [stderr] Downloaded logos-derive v0.15.1 [INFO] [stderr] Downloaded pretty v0.12.5 [INFO] [stderr] Downloaded cedrus-cedar v0.1.0 [INFO] [stderr] Downloaded couch_rs v0.12.1 [INFO] [stderr] Downloaded jwt-authorizer v0.15.0 [INFO] [stderr] Downloaded aws-smithy-json v0.61.6 [INFO] [stderr] Downloaded aws-credential-types v1.2.8 [INFO] [stderr] Downloaded crc16 v0.4.0 [INFO] [stderr] Downloaded serde_dynamo v4.2.14 [INFO] [stderr] Downloaded cedar-policy-core v4.7.0 [INFO] [stderr] Downloaded aws-sdk-dynamodb v1.96.0 [INFO] [stderr] Downloaded logos v0.15.1 [INFO] [stderr] Downloaded aws-lc-sys v0.32.1 [INFO] [stderr] Downloaded openssl-src v300.5.1+3.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14e740437ace528f2f9a7dbdc6dd4f90d81ae6f5b8aff3ecb89ef8c3b1cc2bba [INFO] running `Command { std: "docker" "start" "-a" "14e740437ace528f2f9a7dbdc6dd4f90d81ae6f5b8aff3ecb89ef8c3b1cc2bba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14e740437ace528f2f9a7dbdc6dd4f90d81ae6f5b8aff3ecb89ef8c3b1cc2bba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14e740437ace528f2f9a7dbdc6dd4f90d81ae6f5b8aff3ecb89ef8c3b1cc2bba", kill_on_drop: false }` [INFO] [stdout] 14e740437ace528f2f9a7dbdc6dd4f90d81ae6f5b8aff3ecb89ef8c3b1cc2bba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00032b1994c5e5b5e952bb38a5926d8b20e5ef82210089fb2153c082d7848ac0 [INFO] running `Command { std: "docker" "start" "-a" "00032b1994c5e5b5e952bb38a5926d8b20e5ef82210089fb2153c082d7848ac0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking serde_core v1.0.228 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling libloading v0.8.8 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling aws-lc-rs v1.14.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling regex-syntax v0.8.6 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling openssl-src v300.5.1+3.5.1 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling aws-lc-sys v0.32.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling regex-automata v0.4.11 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Compiling log v0.4.28 [INFO] [stderr] Compiling fixedbitset v0.5.7 [INFO] [stderr] Compiling petgraph v0.7.1 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling regex v1.11.3 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling aws-types v1.3.9 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Compiling uuid-macro-internal v1.18.1 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking aws-smithy-async v1.2.6 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking aws-smithy-types v1.3.3 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking aws-smithy-runtime-api v1.9.1 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking aws-credential-types v1.2.8 [INFO] [stderr] Checking aws-smithy-http v0.62.4 [INFO] [stderr] Checking aws-smithy-observability v0.1.4 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling keccak v0.1.5 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling term v1.1.0 [INFO] [stderr] Compiling bit-vec v0.8.0 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking aws-sigv4 v1.3.5 [INFO] [stderr] Compiling ascii-canvas v4.0.0 [INFO] [stderr] Compiling bit-set v0.8.0 [INFO] [stderr] Checking thiserror v2.0.16 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Compiling sha3 v0.10.8 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling lalrpop-util v0.22.2 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling psm v0.1.26 [INFO] [stderr] Compiling logos-codegen v0.15.1 [INFO] [stderr] Compiling pico-args v0.5.0 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling lalrpop v0.22.2 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking brotli v8.0.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking aws-smithy-json v0.61.6 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.1 [INFO] [stderr] Compiling prost-derive v0.13.5 [INFO] [stderr] Compiling stacker v0.1.22 [INFO] [stderr] Compiling ref-cast v1.0.24 [INFO] [stderr] Compiling prettyplease v0.2.35 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Checking compression-core v0.4.29 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Compiling prost v0.13.5 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking compression-codecs v0.4.31 [INFO] [stderr] Compiling enum-ordinalize v4.3.0 [INFO] [stderr] Compiling serde_with_macros v3.15.1 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling ref-cast-impl v1.0.24 [INFO] [stderr] Compiling miette-derive v7.6.0 [INFO] [stderr] Checking unicode-script v0.5.7 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking rustc_lexer v0.1.0 [INFO] [stderr] Compiling tempfile v3.23.0 [INFO] [stderr] Checking unicode-security v0.1.2 [INFO] [stderr] Checking linked_hash_set v0.1.5 [INFO] [stderr] Compiling logos-derive v0.15.1 [INFO] [stderr] Checking serde_with v3.15.1 [INFO] [stderr] Checking miette v7.6.0 [INFO] [stderr] Compiling educe v0.6.0 [INFO] [stderr] Checking async-compression v0.4.32 [INFO] [stderr] Compiling prost-types v0.13.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking smol_str v0.3.2 [INFO] [stderr] Checking nonempty v0.12.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Compiling multimap v0.10.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Compiling prost-build v0.13.5 [INFO] [stderr] Checking pretty v0.12.5 [INFO] [stderr] Checking logos v0.15.1 [INFO] [stderr] Compiling prost-derive v0.14.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Compiling cedar-policy v4.7.0 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-smithy-xml v0.60.10 [INFO] [stderr] Compiling utoipa-gen v5.4.0 [INFO] [stderr] Compiling cedrus-cedar v0.1.0 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking prost v0.14.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking headers v0.4.1 [INFO] [stderr] Checking jsonwebtoken v9.3.1 [INFO] [stderr] Compiling cedar-policy-core v4.7.0 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking prost-types v0.14.1 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Compiling couch_rs_derive v0.12.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking utoipa v5.4.0 [INFO] [stderr] Checking cedar-policy-formatter v4.7.0 [INFO] [stderr] Checking rustls-webpki v0.103.6 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking redis v0.32.7 [INFO] [stderr] Checking aws-smithy-http-client v1.1.3 [INFO] [stderr] Checking aws-smithy-runtime v1.9.3 [INFO] [stderr] Checking aws-runtime v1.5.12 [INFO] [stderr] Checking aws-sdk-ssooidc v1.86.0 [INFO] [stderr] Checking aws-sdk-dynamodb v1.96.0 [INFO] [stderr] Checking aws-sdk-sts v1.86.0 [INFO] [stderr] Checking aws-sdk-sso v1.84.0 [INFO] [stderr] Checking aws-config v1.8.6 [INFO] [stderr] Checking serde_dynamo v4.2.14 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking jwt-authorizer v0.15.0 [INFO] [stderr] Checking couch_rs v0.12.1 [INFO] [stderr] Checking cedrus-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | const TEMPLATE_PROJECT_ADMIN_ROLE: &'static str = "ProjectAdminRole"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/cedrus.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | templates: templates, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/cedrus.rs:376:13 [INFO] [stdout] | [INFO] [stdout] 376 | templates: templates, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/core/project.rs:10:33 [INFO] [stdout] | [INFO] [stdout] 10 | pub const PROJECT_ENTITY_TYPE: &'static str = "Cedrus::Project"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/core/project.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | const ATTR_OWNER: &'static str = "owner"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/core/project.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | const TAG_NAME: &'static str = "name"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/core/project.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | const TEMPLATE_PROJECT_ADMIN_ROLE: &'static str = "ProjectAdminRole"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cache/valkey.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | async fn mset(&self, sets: &Vec<(String, String)>) -> Result<(), RedisError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 105 - async fn mset(&self, sets: &Vec<(String, String)>) -> Result<(), RedisError> { [INFO] [stdout] 105 + async fn mset(&self, sets: &[(String, String)]) -> Result<(), RedisError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `conf.urls.get(0)` [INFO] [stdout] --> src/cache/valkey.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 130 | let url = conf.urls.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `conf.urls.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cache/valkey.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | format!("cedrus:prj:*") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cedrus:prj:*".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/cache/valkey.rs:203:58 [INFO] [stdout] | [INFO] [stdout] 203 | let pattern = format!("cedrus:p:{}:*", project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/cache/valkey.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / for val in vals { [INFO] [stdout] 223 | | if let Some(val) = val { [INFO] [stdout] 224 | | let project = serde_json::from_str(&val).unwrap(); [INFO] [stdout] 225 | | projects.push(project); [INFO] [stdout] 226 | | } [INFO] [stdout] 227 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/cache/valkey.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | / if let Some(val) = val { [INFO] [stdout] 224 | | let project = serde_json::from_str(&val).unwrap(); [INFO] [stdout] 225 | | projects.push(project); [INFO] [stdout] 226 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 ~ for val in vals.into_iter().flatten() { [INFO] [stdout] 223 + let project = serde_json::from_str(&val).unwrap(); [INFO] [stdout] 224 + projects.push(project); [INFO] [stdout] 225 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/cache/valkey.rs:235:40 [INFO] [stdout] | [INFO] [stdout] 235 | let project: Option = match val { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 236 | | Some(val) => Some(serde_json::from_str(&val).unwrap()), [INFO] [stdout] 237 | | None => None, [INFO] [stdout] 238 | | }; [INFO] [stdout] | |_________^ help: try: `val.map(|val| serde_json::from_str(&val).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/cache/valkey.rs:252:58 [INFO] [stdout] | [INFO] [stdout] 252 | let pattern = format!("cedrus:p:{}:*", project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/cache/valkey.rs:261:77 [INFO] [stdout] | [INFO] [stdout] 261 | let pattern = format!("cedrus:p:{}:tl:{}_*", Uuid::nil(), project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/cache/valkey.rs:276:55 [INFO] [stdout] | [INFO] [stdout] 276 | let identity_source: Option = match val { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 277 | | Some(val) => Some(serde_json::from_str(&val).unwrap()), [INFO] [stdout] 278 | | None => None, [INFO] [stdout] 279 | | }; [INFO] [stdout] | |_________^ help: try: `val.map(|val| serde_json::from_str(&val).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/cache/valkey.rs:308:38 [INFO] [stdout] | [INFO] [stdout] 308 | let schema: Option = match val { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 309 | | Some(val) => Some(serde_json::from_str(&val).unwrap()), [INFO] [stdout] 310 | | None => None, [INFO] [stdout] 311 | | }; [INFO] [stdout] | |_________^ help: try: `val.map(|val| serde_json::from_str(&val).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/cache/valkey.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | / for val in vals { [INFO] [stdout] 361 | | if let Some(val) = val { [INFO] [stdout] 362 | | let entity = self.entity_from_val(val); [INFO] [stdout] 363 | | entities.push(entity); [INFO] [stdout] 364 | | } [INFO] [stdout] 365 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/cache/valkey.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | / if let Some(val) = val { [INFO] [stdout] 362 | | let entity = self.entity_from_val(val); [INFO] [stdout] 363 | | entities.push(entity); [INFO] [stdout] 364 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 360 ~ for val in vals.into_iter().flatten() { [INFO] [stdout] 361 + let entity = self.entity_from_val(val); [INFO] [stdout] 362 + entities.push(entity); [INFO] [stdout] 363 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/cache/valkey.rs:428:48 [INFO] [stdout] | [INFO] [stdout] 428 | let policy_id = PolicyId::from(keys[i].split(':').last().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 428 - let policy_id = PolicyId::from(keys[i].split(':').last().unwrap().to_string()); [INFO] [stdout] 428 + let policy_id = PolicyId::from(keys[i].split(':').next_back().unwrap().to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/valkey.rs:429:59 [INFO] [stdout] | [INFO] [stdout] 429 | let policy: Policy = serde_json::from_str(&val).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/cache/valkey.rs:492:48 [INFO] [stdout] | [INFO] [stdout] 492 | let policy_id = PolicyId::from(keys[i].split(':').last().unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 492 - let policy_id = PolicyId::from(keys[i].split(':').last().unwrap().to_string()); [INFO] [stdout] 492 + let policy_id = PolicyId::from(keys[i].split(':').next_back().unwrap().to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/valkey.rs:493:63 [INFO] [stdout] | [INFO] [stdout] 493 | let template: Template = serde_json::from_str(&val).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/cache/valkey.rs:555:9 [INFO] [stdout] | [INFO] [stdout] 555 | / for val in vals { [INFO] [stdout] 556 | | if let Some(val) = val { [INFO] [stdout] 557 | | let template_link: TemplateLink = serde_json::from_str(&val).unwrap(); [INFO] [stdout] 558 | | template_links.push(template_link); [INFO] [stdout] 559 | | } [INFO] [stdout] 560 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/cache/valkey.rs:556:13 [INFO] [stdout] | [INFO] [stdout] 556 | / if let Some(val) = val { [INFO] [stdout] 557 | | let template_link: TemplateLink = serde_json::from_str(&val).unwrap(); [INFO] [stdout] 558 | | template_links.push(template_link); [INFO] [stdout] 559 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 555 ~ for val in vals.into_iter().flatten() { [INFO] [stdout] 556 + let template_link: TemplateLink = serde_json::from_str(&val).unwrap(); [INFO] [stdout] 557 + template_links.push(template_link); [INFO] [stdout] 558 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DashMapCache` [INFO] [stdout] --> src/cache/dashmap.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | Self { [INFO] [stdout] 24 | | projects: DashMap::new(), [INFO] [stdout] 25 | | identity_sources: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for DashMapCache { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/mod.rs:138:91 [INFO] [stdout] | [INFO] [stdout] 138 | crate::core::CacheConfig::ValKeyConfig(conf) => Box::new(valkey::ValKeyCache::new(&conf).await), [INFO] [stdout] | ^^^^^ help: change this to: `conf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/couchdb.rs:78:50 [INFO] [stdout] | [INFO] [stdout] 78 | format!("{}#{}", PROJECT_TYPE, project_id.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/couchdb.rs:106:23 [INFO] [stdout] | [INFO] [stdout] 106 | project_id.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/couchdb.rs:135:57 [INFO] [stdout] | [INFO] [stdout] 135 | format!("{}#{}", PROJECT_SCHEMA_TYPE, project_id.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:167:54 [INFO] [stdout] | [INFO] [stdout] 167 | let id = Self::project_entity_id(project_id, &entity.uid()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entity.uid()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 349 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 349 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 367 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 367 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 367 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 380 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 380 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 380 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 401 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 401 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 414 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 414 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 435 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 435 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:466:59 [INFO] [stdout] | [INFO] [stdout] 466 | let mut value = Self::project_entity_to_value(&project_id, entity)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:480:46 [INFO] [stdout] | [INFO] [stdout] 480 | let id = Self::project_entity_id(&project_id, entity_uid); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:481:13 [INFO] [stdout] | [INFO] [stdout] 481 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 481 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 481 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/db/couchdb.rs:500:13 [INFO] [stdout] | [INFO] [stdout] 500 | / if let Some(policy_id) = doc.get(POLICY_ID_KEY) { [INFO] [stdout] 501 | | if let Some(policy_id) = policy_id.as_str() { [INFO] [stdout] 502 | | datas.insert( [INFO] [stdout] 503 | | policy_id.to_string().into(), [INFO] [stdout] ... | [INFO] [stdout] 507 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 500 ~ if let Some(policy_id) = doc.get(POLICY_ID_KEY) [INFO] [stdout] 501 ~ && let Some(policy_id) = policy_id.as_str() { [INFO] [stdout] 502 | datas.insert( [INFO] [stdout] ... [INFO] [stdout] 505 | ); [INFO] [stdout] 506 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:520:59 [INFO] [stdout] | [INFO] [stdout] 520 | let mut value = Self::project_policy_to_value(&project_id, policy_id, policy)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:534:46 [INFO] [stdout] | [INFO] [stdout] 534 | let id = Self::project_policy_id(&project_id, policy_id); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:535:13 [INFO] [stdout] | [INFO] [stdout] 535 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 535 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 535 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/db/couchdb.rs:554:13 [INFO] [stdout] | [INFO] [stdout] 554 | / if let Some(policy_id) = doc.get(POLICY_ID_KEY) { [INFO] [stdout] 555 | | if let Some(policy_id) = policy_id.as_str() { [INFO] [stdout] 556 | | datas.insert( [INFO] [stdout] 557 | | policy_id.to_string().into(), [INFO] [stdout] ... | [INFO] [stdout] 561 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 554 ~ if let Some(policy_id) = doc.get(POLICY_ID_KEY) [INFO] [stdout] 555 ~ && let Some(policy_id) = policy_id.as_str() { [INFO] [stdout] 556 | datas.insert( [INFO] [stdout] ... [INFO] [stdout] 559 | ); [INFO] [stdout] 560 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:574:61 [INFO] [stdout] | [INFO] [stdout] 574 | let mut value = Self::project_template_to_value(&project_id, template_id, template)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:588:48 [INFO] [stdout] | [INFO] [stdout] 588 | let id = Self::project_template_id(&project_id, template_id); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:589:13 [INFO] [stdout] | [INFO] [stdout] 589 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 589 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 589 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:621:66 [INFO] [stdout] | [INFO] [stdout] 621 | let mut value = Self::project_template_link_to_value(&project_id, template_link)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/couchdb.rs:635:53 [INFO] [stdout] | [INFO] [stdout] 635 | let id = Self::project_template_link_id(&project_id, new_id); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/db/couchdb.rs:636:13 [INFO] [stdout] | [INFO] [stdout] 636 | if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(doc)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 636 - if let Some(doc) = db.get::(&id).await.ok() { [INFO] [stdout] 636 + if let Ok(doc) = db.get::(&id).await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FilterExpression` [INFO] [stdout] --> src/db/dynamodb.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / pub fn new() -> FilterExpression { [INFO] [stdout] 43 | | FilterExpression { [INFO] [stdout] 44 | | expr: String::new(), [INFO] [stdout] 45 | | names: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 41 + impl Default for FilterExpression { [INFO] [stdout] 42 + fn default() -> Self { [INFO] [stdout] 43 + Self::new() [INFO] [stdout] 44 + } [INFO] [stdout] 45 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db/dynamodb.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !self [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | .client [INFO] [stdout] 81 | | .describe_table() [INFO] [stdout] 82 | | .table_name(&self.table_name) [INFO] [stdout] 83 | | .send() [INFO] [stdout] 84 | | .await [INFO] [stdout] 85 | | .is_err() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ if self [INFO] [stdout] 80 + .client [INFO] [stdout] 81 + .describe_table() [INFO] [stdout] 82 + .table_name(&self.table_name) [INFO] [stdout] 83 + .send() [INFO] [stdout] 84 + .await.is_ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:202:59 [INFO] [stdout] | [INFO] [stdout] 202 | let pk = format!("{}#{}", PROJECT_TYPE, project.id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:262:59 [INFO] [stdout] | [INFO] [stdout] 262 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:292:59 [INFO] [stdout] | [INFO] [stdout] 292 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:314:59 [INFO] [stdout] | [INFO] [stdout] 314 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:342:59 [INFO] [stdout] | [INFO] [stdout] 342 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:370:59 [INFO] [stdout] | [INFO] [stdout] 370 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:392:59 [INFO] [stdout] | [INFO] [stdout] 392 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:579:51 [INFO] [stdout] | [INFO] [stdout] 579 | let pk = format!("{}#{}", PROJECT_TYPE, id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:616:51 [INFO] [stdout] | [INFO] [stdout] 616 | let pk = format!("{}#{}", PROJECT_TYPE, id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:652:60 [INFO] [stdout] | [INFO] [stdout] 652 | let pk = format!("{}#{}", PROJECT_TYPE, Uuid::nil().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:653:44 [INFO] [stdout] | [INFO] [stdout] 653 | let sk = format!("{}#TL#{}", pk, id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:713:59 [INFO] [stdout] | [INFO] [stdout] 713 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:755:59 [INFO] [stdout] | [INFO] [stdout] 755 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:777:59 [INFO] [stdout] | [INFO] [stdout] 777 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:819:59 [INFO] [stdout] | [INFO] [stdout] 819 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:853:59 [INFO] [stdout] | [INFO] [stdout] 853 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:924:63 [INFO] [stdout] | [INFO] [stdout] 924 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:961:59 [INFO] [stdout] | [INFO] [stdout] 961 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:1037:63 [INFO] [stdout] | [INFO] [stdout] 1037 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:1074:59 [INFO] [stdout] | [INFO] [stdout] 1074 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:1152:63 [INFO] [stdout] | [INFO] [stdout] 1152 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:1189:59 [INFO] [stdout] | [INFO] [stdout] 1189 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/dynamodb.rs:1262:63 [INFO] [stdout] | [INFO] [stdout] 1262 | let pk = format!("{}#{}", PROJECT_TYPE, project_id.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/db/mod.rs:32:72 [INFO] [stdout] | [INFO] [stdout] 32 | DatabaseError::JsonErro(e) => write!(f, "json error: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/db/mod.rs:34:84 [INFO] [stdout] | [INFO] [stdout] 34 | DatabaseError::SerdeDynamoError(e) => write!(f, "dynamodb error: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/db/mod.rs:104:19 [INFO] [stdout] | [INFO] [stdout] 104 | entities: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `&'life2 [Entity]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/db/mod.rs:109:22 [INFO] [stdout] | [INFO] [stdout] 109 | entity_uids: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `&'life2 [EntityUid]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/db/mod.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | policy_ids: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `&'life2 [PolicyId]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/db/mod.rs:141:23 [INFO] [stdout] | [INFO] [stdout] 141 | template_ids: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `&'life2 [PolicyId]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/db/mod.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | template_links: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&'life2 [TemplateLink]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/db/mod.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 157 | link_ids: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `&'life2 [PolicyId]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/mod.rs:164:46 [INFO] [stdout] | [INFO] [stdout] 164 | Box::new(dynamodb::DynamoDb::new(&conf).await) [INFO] [stdout] | ^^^^^ help: change this to: `conf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/mod.rs:167:44 [INFO] [stdout] | [INFO] [stdout] 167 | let db = couchdb::CouchDb::new(&conf); [INFO] [stdout] | ^^^^^ help: change this to: `conf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `conf.urls.get(0)` [INFO] [stdout] --> src/pubsub/valkey.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | let url = conf.urls.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `conf.urls.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.urls.get(0)` [INFO] [stdout] --> src/pubsub/valkey.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 51 | let url = self.urls.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self.urls.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/pubsub/valkey.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | / match msg.kind { [INFO] [stdout] 64 | | redis::PushKind::Message => { [INFO] [stdout] 65 | | let Some(message) = msg.data.get(1) else { [INFO] [stdout] 66 | | continue; [INFO] [stdout] ... | [INFO] [stdout] 84 | | _ => {} [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 ~ if msg.kind == redis::PushKind::Message { [INFO] [stdout] 64 + let Some(message) = msg.data.get(1) else { [INFO] [stdout] 65 + continue; [INFO] [stdout] 66 + }; [INFO] [stdout] 67 + match message { [INFO] [stdout] 68 + redis::Value::BulkString(data) => { [INFO] [stdout] 69 + let Ok(str) = String::from_utf8(data.clone()) else { [INFO] [stdout] 70 + continue; [INFO] [stdout] 71 + }; [INFO] [stdout] 72 + println!("subscribe2 recv1: {}", str); [INFO] [stdout] 73 + let Ok(message) = serde_json::from_str::(&str) else { [INFO] [stdout] 74 + continue; [INFO] [stdout] 75 + }; [INFO] [stdout] 76 + for op in ops { [INFO] [stdout] 77 + op(message.clone()).await; [INFO] [stdout] 78 + } [INFO] [stdout] 79 + } [INFO] [stdout] 80 + _ => {} [INFO] [stdout] 81 + } [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pubsub/valkey.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 68 | / ... match message { [INFO] [stdout] 69 | | ... redis::Value::BulkString(data) => { [INFO] [stdout] 70 | | ... let Ok(str) = String::from_utf8(data.clone()) else { [INFO] [stdout] 71 | | ... continue; [INFO] [stdout] ... | [INFO] [stdout] 81 | | ... _ => {} [INFO] [stdout] 82 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ if let redis::Value::BulkString(data) = message { [INFO] [stdout] 69 + let Ok(str) = String::from_utf8(data.clone()) else { [INFO] [stdout] 70 + continue; [INFO] [stdout] 71 + }; [INFO] [stdout] 72 + println!("subscribe2 recv1: {}", str); [INFO] [stdout] 73 + let Ok(message) = serde_json::from_str::(&str) else { [INFO] [stdout] 74 + continue; [INFO] [stdout] 75 + }; [INFO] [stdout] 76 + for op in ops { [INFO] [stdout] 77 + op(message.clone()).await; [INFO] [stdout] 78 + } [INFO] [stdout] 79 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/pubsub/valkey.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | / match msg.kind { [INFO] [stdout] 103 | | redis::PushKind::Message => { [INFO] [stdout] 104 | | let Some(message) = msg.data.get(1) else { [INFO] [stdout] 105 | | continue; [INFO] [stdout] ... | [INFO] [stdout] 123 | | _ => {} [INFO] [stdout] 124 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 102 ~ if msg.kind == redis::PushKind::Message { [INFO] [stdout] 103 + let Some(message) = msg.data.get(1) else { [INFO] [stdout] 104 + continue; [INFO] [stdout] 105 + }; [INFO] [stdout] 106 + match message { [INFO] [stdout] 107 + redis::Value::BulkString(data) => { [INFO] [stdout] 108 + let Ok(str) = String::from_utf8(data.clone()) else { [INFO] [stdout] 109 + continue; [INFO] [stdout] 110 + }; [INFO] [stdout] 111 + println!("subscribe2 recv1: {}", str); [INFO] [stdout] 112 + let Ok(message) = serde_json::from_str::(&str) else { [INFO] [stdout] 113 + continue; [INFO] [stdout] 114 + }; [INFO] [stdout] 115 + for op in ops { [INFO] [stdout] 116 + op(message.clone()).await; [INFO] [stdout] 117 + } [INFO] [stdout] 118 + } [INFO] [stdout] 119 + _ => {} [INFO] [stdout] 120 + } [INFO] [stdout] 121 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/pubsub/valkey.rs:107:29 [INFO] [stdout] | [INFO] [stdout] 107 | / ... match message { [INFO] [stdout] 108 | | ... redis::Value::BulkString(data) => { [INFO] [stdout] 109 | | ... let Ok(str) = String::from_utf8(data.clone()) else { [INFO] [stdout] 110 | | ... continue; [INFO] [stdout] ... | [INFO] [stdout] 120 | | ... _ => {} [INFO] [stdout] 121 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 ~ if let redis::Value::BulkString(data) = message { [INFO] [stdout] 108 + let Ok(str) = String::from_utf8(data.clone()) else { [INFO] [stdout] 109 + continue; [INFO] [stdout] 110 + }; [INFO] [stdout] 111 + println!("subscribe2 recv1: {}", str); [INFO] [stdout] 112 + let Ok(message) = serde_json::from_str::(&str) else { [INFO] [stdout] 113 + continue; [INFO] [stdout] 114 + }; [INFO] [stdout] 115 + for op in ops { [INFO] [stdout] 116 + op(message.clone()).await; [INFO] [stdout] 117 + } [INFO] [stdout] 118 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DummyPubSub` [INFO] [stdout] --> src/pubsub/dummy.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Self { [INFO] [stdout] 9 | | Self [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for DummyPubSub { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/pubsub/mod.rs:36:80 [INFO] [stdout] | [INFO] [stdout] 36 | PubSubConfig::ValKeyConfig(conf) => Box::new(valkey::ValKeyPubSub::new(&conf).await), [INFO] [stdout] | ^^^^^ help: change this to: `conf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/core/cedrus.rs:220:34 [INFO] [stdout] | [INFO] [stdout] 220 | cache_schema.map(|s| s.try_into()).transpose()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cedar_policy::SchemaError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/core/cedrus.rs:257:10 [INFO] [stdout] | [INFO] [stdout] 257 | ) -> Result<(), CedrusError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | SchemaError(cedar_policy::SchemaError), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 376 bytes [INFO] [stdout] 272 | EntitiesError(cedar_policy::entities_errors::EntitiesError), [INFO] [stdout] | ----------------------------------------------------------- the variant `EntitiesError` contains at least 376 bytes [INFO] [stdout] 273 | PolicyFromJsonError(cedar_policy::PolicyFromJsonError), [INFO] [stdout] | ------------------------------------------------------ the variant `PolicyFromJsonError` contains at least 376 bytes [INFO] [stdout] 274 | PolicyToJsonError(cedar_policy::PolicyToJsonError), [INFO] [stdout] | -------------------------------------------------- the variant `PolicyToJsonError` contains at least 152 bytes [INFO] [stdout] 275 | PolicySetError(cedar_policy::PolicySetError), [INFO] [stdout] | -------------------------------------------- the variant `PolicySetError` contains at least 376 bytes [INFO] [stdout] 276 | ContextJsonError(cedar_policy::ContextJsonError), [INFO] [stdout] | ------------------------------------------------ the variant `ContextJsonError` contains at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `CedrusError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/core/cedrus.rs:274:10 [INFO] [stdout] | [INFO] [stdout] 274 | ) -> Result<(), CedrusError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | SchemaError(cedar_policy::SchemaError), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 376 bytes [INFO] [stdout] 272 | EntitiesError(cedar_policy::entities_errors::EntitiesError), [INFO] [stdout] | ----------------------------------------------------------- the variant `EntitiesError` contains at least 376 bytes [INFO] [stdout] 273 | PolicyFromJsonError(cedar_policy::PolicyFromJsonError), [INFO] [stdout] | ------------------------------------------------------ the variant `PolicyFromJsonError` contains at least 376 bytes [INFO] [stdout] 274 | PolicyToJsonError(cedar_policy::PolicyToJsonError), [INFO] [stdout] | -------------------------------------------------- the variant `PolicyToJsonError` contains at least 152 bytes [INFO] [stdout] 275 | PolicySetError(cedar_policy::PolicySetError), [INFO] [stdout] | -------------------------------------------- the variant `PolicySetError` contains at least 376 bytes [INFO] [stdout] 276 | ContextJsonError(cedar_policy::ContextJsonError), [INFO] [stdout] | ------------------------------------------------ the variant `ContextJsonError` contains at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `CedrusError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:275:75 [INFO] [stdout] | [INFO] [stdout] 275 | if let Some(cedar_entities) = self.project_cedar_entities.get_mut(&project_id) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `project_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/core/cedrus.rs:415:10 [INFO] [stdout] | [INFO] [stdout] 415 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | SchemaError(cedar_policy::SchemaError), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 376 bytes [INFO] [stdout] 272 | EntitiesError(cedar_policy::entities_errors::EntitiesError), [INFO] [stdout] | ----------------------------------------------------------- the variant `EntitiesError` contains at least 376 bytes [INFO] [stdout] 273 | PolicyFromJsonError(cedar_policy::PolicyFromJsonError), [INFO] [stdout] | ------------------------------------------------------ the variant `PolicyFromJsonError` contains at least 376 bytes [INFO] [stdout] 274 | PolicyToJsonError(cedar_policy::PolicyToJsonError), [INFO] [stdout] | -------------------------------------------------- the variant `PolicyToJsonError` contains at least 152 bytes [INFO] [stdout] 275 | PolicySetError(cedar_policy::PolicySetError), [INFO] [stdout] | -------------------------------------------- the variant `PolicySetError` contains at least 376 bytes [INFO] [stdout] 276 | ContextJsonError(cedar_policy::ContextJsonError), [INFO] [stdout] | ------------------------------------------------ the variant `ContextJsonError` contains at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `CedrusError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/cedrus.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return false; [INFO] [stdout] 439 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/core/cedrus.rs:486:10 [INFO] [stdout] | [INFO] [stdout] 486 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | SchemaError(cedar_policy::SchemaError), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 376 bytes [INFO] [stdout] 272 | EntitiesError(cedar_policy::entities_errors::EntitiesError), [INFO] [stdout] | ----------------------------------------------------------- the variant `EntitiesError` contains at least 376 bytes [INFO] [stdout] 273 | PolicyFromJsonError(cedar_policy::PolicyFromJsonError), [INFO] [stdout] | ------------------------------------------------------ the variant `PolicyFromJsonError` contains at least 376 bytes [INFO] [stdout] 274 | PolicyToJsonError(cedar_policy::PolicyToJsonError), [INFO] [stdout] | -------------------------------------------------- the variant `PolicyToJsonError` contains at least 152 bytes [INFO] [stdout] 275 | PolicySetError(cedar_policy::PolicySetError), [INFO] [stdout] | -------------------------------------------- the variant `PolicySetError` contains at least 376 bytes [INFO] [stdout] 276 | ContextJsonError(cedar_policy::ContextJsonError), [INFO] [stdout] | ------------------------------------------------ the variant `ContextJsonError` contains at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `CedrusError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/core/cedrus.rs:501:42 [INFO] [stdout] | [INFO] [stdout] 501 | let context_schema = match cedar_schema.as_ref() { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 502 | | Some(schema) => Some((schema, &cedar_action)), [INFO] [stdout] 503 | | _ => None, [INFO] [stdout] 504 | | }; [INFO] [stdout] | |_____________________^ help: try: `cedar_schema.as_ref().map(|schema| (schema, &cedar_action))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/core/cedrus.rs:538:10 [INFO] [stdout] | [INFO] [stdout] 538 | ) -> Result, CedrusError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | SchemaError(cedar_policy::SchemaError), [INFO] [stdout] | -------------------------------------- the largest variant contains at least 376 bytes [INFO] [stdout] 272 | EntitiesError(cedar_policy::entities_errors::EntitiesError), [INFO] [stdout] | ----------------------------------------------------------- the variant `EntitiesError` contains at least 376 bytes [INFO] [stdout] 273 | PolicyFromJsonError(cedar_policy::PolicyFromJsonError), [INFO] [stdout] | ------------------------------------------------------ the variant `PolicyFromJsonError` contains at least 376 bytes [INFO] [stdout] 274 | PolicyToJsonError(cedar_policy::PolicyToJsonError), [INFO] [stdout] | -------------------------------------------------- the variant `PolicyToJsonError` contains at least 152 bytes [INFO] [stdout] 275 | PolicySetError(cedar_policy::PolicySetError), [INFO] [stdout] | -------------------------------------------- the variant `PolicySetError` contains at least 376 bytes [INFO] [stdout] 276 | ContextJsonError(cedar_policy::ContextJsonError), [INFO] [stdout] | ------------------------------------------------ the variant `ContextJsonError` contains at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `CedrusError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/core/cedrus.rs:560:46 [INFO] [stdout] | [INFO] [stdout] 560 | let context_schema = match cedar_schema.as_ref() { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 561 | | Some(schema) => Some((schema, &cedar_action)), [INFO] [stdout] 562 | | _ => None, [INFO] [stdout] 563 | | }; [INFO] [stdout] | |_________________________^ help: try: `cedar_schema.as_ref().map(|schema| (schema, &cedar_action))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/core/cedrus.rs:658:54 [INFO] [stdout] | [INFO] [stdout] 658 | project.api_key = BASE64_STANDARD.encode(buf.to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^ help: use: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/core/cedrus.rs:891:39 [INFO] [stdout] | [INFO] [stdout] 891 | let cedar_schema = schema.map(|s| s.try_into()).transpose()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cedar_policy::SchemaError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::IntoKeys` [INFO] [stdout] --> src/core/cedrus.rs:983:26 [INFO] [stdout] | [INFO] [stdout] 983 | let policy_ids = policies.into_keys().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `policies.into_keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::IntoKeys` [INFO] [stdout] --> src/core/cedrus.rs:1053:26 [INFO] [stdout] | [INFO] [stdout] 1053 | let policy_ids = templates.into_keys().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `templates.into_keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/core/cedrus.rs:1219:38 [INFO] [stdout] | [INFO] [stdout] 1219 | cache_schema.map(|s| s.try_into()).transpose().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the `Err`-variant is at least 376 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cedar_policy::SchemaError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1229:43 [INFO] [stdout] | [INFO] [stdout] 1229 | .project_get_entities(&id, &Vec::from_iter(entity_uids.clone())) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1239:45 [INFO] [stdout] | [INFO] [stdout] 1239 | self.project_set_policy_set(&id).await.unwrap(); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1242:45 [INFO] [stdout] | [INFO] [stdout] 1242 | self.project_set_policy_set(&id).await.unwrap(); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1245:45 [INFO] [stdout] | [INFO] [stdout] 1245 | self.project_set_policy_set(&id).await.unwrap(); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1248:45 [INFO] [stdout] | [INFO] [stdout] 1248 | self.project_set_policy_set(&id).await.unwrap(); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1251:45 [INFO] [stdout] | [INFO] [stdout] 1251 | self.project_set_policy_set(&id).await.unwrap(); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/cedrus.rs:1254:45 [INFO] [stdout] | [INFO] [stdout] 1254 | self.project_set_policy_set(&id).await.unwrap(); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/project.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return entity; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return entity; [INFO] [stdout] 62 + entity [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/project.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return links; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return links; [INFO] [stdout] 85 + links [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/mod.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 31 | let user_pool_id = self [INFO] [stdout] | ________________________________^ [INFO] [stdout] 32 | | .user_pool_arn [INFO] [stdout] 33 | | .split('/') [INFO] [stdout] 34 | | .last() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 - .last() [INFO] [stdout] 34 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | / self.user_pool_arn [INFO] [stdout] 45 | | .split('/') [INFO] [stdout] 46 | | .last() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 - .last() [INFO] [stdout] 46 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 40s [INFO] running `Command { std: "docker" "inspect" "00032b1994c5e5b5e952bb38a5926d8b20e5ef82210089fb2153c082d7848ac0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00032b1994c5e5b5e952bb38a5926d8b20e5ef82210089fb2153c082d7848ac0", kill_on_drop: false }` [INFO] [stdout] 00032b1994c5e5b5e952bb38a5926d8b20e5ef82210089fb2153c082d7848ac0