[INFO] fetching crate cdt 0.1.0... [INFO] linting cdt-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cdt 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate cdt 0.1.0 [INFO] finished tweaking crates.io crate cdt 0.1.0 [INFO] tweaked toml for crates.io crate cdt 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cdt 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate cdt 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded owned_ttf_parser v0.6.0 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Downloaded rusttype v0.9.2 [INFO] [stderr] Downloaded geometry-predicates v0.3.0 [INFO] [stderr] Downloaded itertools v0.10.0 [INFO] [stderr] Downloaded ttf-parser v0.6.2 [INFO] [stderr] Downloaded syn v1.0.70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb6f618826039fc83e1e4cacf99d6c9a9e70b3aaa01e2525a8ee9954634a7d04 [INFO] running `Command { std: "docker" "start" "-a" "cb6f618826039fc83e1e4cacf99d6c9a9e70b3aaa01e2525a8ee9954634a7d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb6f618826039fc83e1e4cacf99d6c9a9e70b3aaa01e2525a8ee9954634a7d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb6f618826039fc83e1e4cacf99d6c9a9e70b3aaa01e2525a8ee9954634a7d04", kill_on_drop: false }` [INFO] [stdout] cb6f618826039fc83e1e4cacf99d6c9a9e70b3aaa01e2525a8ee9954634a7d04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c61e538112b76f24cb330c0c33da6bc083f4c2f7bc47e3b827a3b368f4f5a31d [INFO] running `Command { std: "docker" "start" "-a" "c61e538112b76f24cb330c0c33da6bc083f4c2f7bc47e3b827a3b368f4f5a31d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.92 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling syn v1.0.70 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking geometry-predicates v0.3.0 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking cdt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/half.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | / return self.edges.iter() [INFO] [stdout] 141 | | .filter(|e| e.next != EMPTY_EDGE) [INFO] [stdout] 142 | | .map(|e| (e.src, e.dst, e.fixed())) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ self.edges.iter() [INFO] [stdout] 141 + .filter(|e| e.next != EMPTY_EDGE) [INFO] [stdout] 142 + .map(|e| (e.src, e.dst, e.fixed())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/triangulate.rs:155:34 [INFO] [stdout] | [INFO] [stdout] 155 | let arr = min3(&scratch, &points); [INFO] [stdout] | ^^^^^^^ help: change this to: `points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/triangulate.rs:383:30 [INFO] [stdout] | [INFO] [stdout] 383 | Self::new_with_edges(&pts, &edges) [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/half.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | / return self.edges.iter() [INFO] [stdout] 141 | | .filter(|e| e.next != EMPTY_EDGE) [INFO] [stdout] 142 | | .map(|e| (e.src, e.dst, e.fixed())) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ self.edges.iter() [INFO] [stdout] 141 + .filter(|e| e.next != EMPTY_EDGE) [INFO] [stdout] 142 + .map(|e| (e.src, e.dst, e.fixed())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1112:37 [INFO] [stdout] | [INFO] [stdout] 1112 | let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1112 - let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1112 + let (mut xmin, mut xmax) = (f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1112:58 [INFO] [stdout] | [INFO] [stdout] 1112 | let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1112 - let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1112 + let (mut xmin, mut xmax) = (std::f64::INFINITY, -f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1113:37 [INFO] [stdout] | [INFO] [stdout] 1113 | let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1113 - let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1113 + let (mut ymin, mut ymax) = (f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1113:58 [INFO] [stdout] | [INFO] [stdout] 1113 | let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1113 - let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1113 + let (mut ymin, mut ymax) = (std::f64::INFINITY, -f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1250:26 [INFO] [stdout] | [INFO] [stdout] 1250 | let mut array = [(0, std::f64::INFINITY); 3]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1250 - let mut array = [(0, std::f64::INFINITY); 3]; [INFO] [stdout] 1250 + let mut array = [(0, f64::INFINITY); 3]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1261:46 [INFO] [stdout] | [INFO] [stdout] 1261 | if (p0.0 - points[p].0).abs() >= std::f64::EPSILON || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1261 - if (p0.0 - points[p].0).abs() >= std::f64::EPSILON || [INFO] [stdout] 1261 + if (p0.0 - points[p].0).abs() >= f64::EPSILON || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1262:46 [INFO] [stdout] | [INFO] [stdout] 1262 | (p0.1 - points[p].1).abs() >= std::f64::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1262 - (p0.1 - points[p].1).abs() >= std::f64::EPSILON [INFO] [stdout] 1262 + (p0.1 - points[p].1).abs() >= f64::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1272:52 [INFO] [stdout] | [INFO] [stdout] 1272 | if orient2d(p0, p1, points[p]).abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1272 - if orient2d(p0, p1, points[p]).abs() > std::f64::EPSILON { [INFO] [stdout] 1272 + if orient2d(p0, p1, points[p]).abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/triangulate.rs:1313:17 [INFO] [stdout] | [INFO] [stdout] 1313 | assert!(!t.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `t.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 110 | let t = Triangulation::build(&pts)?; [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:121:48 [INFO] [stdout] | [INFO] [stdout] 121 | let t = Triangulation::build_from_contours(&pts, contours)?; [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 132 | let t = Triangulation::build_with_edges(&pts, edges)?; [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/triangulate.rs:155:34 [INFO] [stdout] | [INFO] [stdout] 155 | let arr = min3(&scratch, &points); [INFO] [stdout] | ^^^^^^^ help: change this to: `points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/triangulate.rs:1517:52 [INFO] [stdout] | [INFO] [stdout] 1517 | &[(0.0, 0.0), (1.0, 0.0), (1.0, 1.0)], &vec![]); [INFO] [stdout] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/triangulate.rs:383:30 [INFO] [stdout] | [INFO] [stdout] 383 | Self::new_with_edges(&pts, &edges) [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1112:37 [INFO] [stdout] | [INFO] [stdout] 1112 | let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1112 - let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1112 + let (mut xmin, mut xmax) = (f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1112:58 [INFO] [stdout] | [INFO] [stdout] 1112 | let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1112 - let (mut xmin, mut xmax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1112 + let (mut xmin, mut xmax) = (std::f64::INFINITY, -f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1113:37 [INFO] [stdout] | [INFO] [stdout] 1113 | let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1113 - let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1113 + let (mut ymin, mut ymax) = (f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1113:58 [INFO] [stdout] | [INFO] [stdout] 1113 | let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1113 - let (mut ymin, mut ymax) = (std::f64::INFINITY, -std::f64::INFINITY); [INFO] [stdout] 1113 + let (mut ymin, mut ymax) = (std::f64::INFINITY, -f64::INFINITY); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1250:26 [INFO] [stdout] | [INFO] [stdout] 1250 | let mut array = [(0, std::f64::INFINITY); 3]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1250 - let mut array = [(0, std::f64::INFINITY); 3]; [INFO] [stdout] 1250 + let mut array = [(0, f64::INFINITY); 3]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1261:46 [INFO] [stdout] | [INFO] [stdout] 1261 | if (p0.0 - points[p].0).abs() >= std::f64::EPSILON || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1261 - if (p0.0 - points[p].0).abs() >= std::f64::EPSILON || [INFO] [stdout] 1261 + if (p0.0 - points[p].0).abs() >= f64::EPSILON || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1262:46 [INFO] [stdout] | [INFO] [stdout] 1262 | (p0.1 - points[p].1).abs() >= std::f64::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1262 - (p0.1 - points[p].1).abs() >= std::f64::EPSILON [INFO] [stdout] 1262 + (p0.1 - points[p].1).abs() >= f64::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/triangulate.rs:1272:52 [INFO] [stdout] | [INFO] [stdout] 1272 | if orient2d(p0, p1, points[p]).abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1272 - if orient2d(p0, p1, points[p]).abs() > std::f64::EPSILON { [INFO] [stdout] 1272 + if orient2d(p0, p1, points[p]).abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 110 | let t = Triangulation::build(&pts)?; [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:121:48 [INFO] [stdout] | [INFO] [stdout] 121 | let t = Triangulation::build_from_contours(&pts, contours)?; [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 132 | let t = Triangulation::build_with_edges(&pts, edges)?; [INFO] [stdout] | ^^^^ help: change this to: `pts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> examples/font.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | let data = std::fs::read(&font_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `font_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.64s [INFO] running `Command { std: "docker" "inspect" "c61e538112b76f24cb330c0c33da6bc083f4c2f7bc47e3b827a3b368f4f5a31d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c61e538112b76f24cb330c0c33da6bc083f4c2f7bc47e3b827a3b368f4f5a31d", kill_on_drop: false }` [INFO] [stdout] c61e538112b76f24cb330c0c33da6bc083f4c2f7bc47e3b827a3b368f4f5a31d