[INFO] fetching crate cdcflow 0.1.0... [INFO] linting cdcflow-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cdcflow 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate cdcflow 0.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cdcflow 0.1.0 [INFO] tweaked toml for crates.io crate cdcflow 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cdcflow 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate cdcflow 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded etcetera v0.11.0 [INFO] [stderr] Downloaded docker_credential v1.3.2 [INFO] [stderr] Downloaded murmur3 v0.5.2 [INFO] [stderr] Downloaded array-init v2.1.0 [INFO] [stderr] Downloaded astral-tokio-tar v0.5.6 [INFO] [stderr] Downloaded keyed_priority_queue v0.4.2 [INFO] [stderr] Downloaded lru v0.14.0 [INFO] [stderr] Downloaded typed-builder-macro v0.20.1 [INFO] [stderr] Downloaded flatbuffers v25.12.19 [INFO] [stderr] Downloaded lz4_flex v0.12.0 [INFO] [stderr] Downloaded iceberg-catalog-rest v0.8.0 [INFO] [stderr] Downloaded bollard-buildkit-proto v0.7.0 [INFO] [stderr] Downloaded jiff-static v0.2.21 [INFO] [stderr] Downloaded bollard v0.20.1 [INFO] [stderr] Downloaded mysql_async v0.36.1 [INFO] [stderr] Downloaded rdkafka v0.39.0 [INFO] [stderr] Downloaded arrow-ipc v57.3.0 [INFO] [stderr] Downloaded testcontainers v0.27.1 [INFO] [stderr] Downloaded testcontainers-modules v0.15.0 [INFO] [stderr] Downloaded reqsign v0.16.5 [INFO] [stderr] Downloaded moka v0.12.13 [INFO] [stderr] Downloaded bollard-stubs v1.52.1-rc.29.1.3 [INFO] [stderr] Downloaded ferroid v0.8.9 [INFO] [stderr] Downloaded typed-builder v0.20.1 [INFO] [stderr] Downloaded iceberg v0.8.0 [INFO] [stderr] Downloaded jiff v0.2.21 [INFO] [stderr] Downloaded parquet v57.3.0 [INFO] [stderr] Downloaded opendal v0.55.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e734ff303d091aef605a49b959bffbf4fe760ac56369e8160efa0fbf255941d [INFO] running `Command { std: "docker" "start" "-a" "8e734ff303d091aef605a49b959bffbf4fe760ac56369e8160efa0fbf255941d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e734ff303d091aef605a49b959bffbf4fe760ac56369e8160efa0fbf255941d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e734ff303d091aef605a49b959bffbf4fe760ac56369e8160efa0fbf255941d", kill_on_drop: false }` [INFO] [stdout] 8e734ff303d091aef605a49b959bffbf4fe760ac56369e8160efa0fbf255941d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9708837b88dc0439c1d80b7d1a0a0e24779b866ea049450805b8cddcf4429885 [INFO] running `Command { std: "docker" "start" "-a" "9708837b88dc0439c1d80b7d1a0a0e24779b866ea049450805b8cddcf4429885", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling flatbuffers v25.12.19 [INFO] [stderr] Checking zlib-rs v0.6.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Compiling bigdecimal v0.4.10 [INFO] [stderr] Checking twox-hash v2.1.2 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Compiling bollard-buildkit-proto v0.7.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking lz4_flex v0.12.0 [INFO] [stderr] Checking regex-lite v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking dissimilar v1.0.10 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling seq-macro v0.3.6 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking siphasher v1.0.2 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Compiling mysql_common v0.35.5 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Compiling nix v0.31.2 [INFO] [stderr] Checking roaring v0.11.3 [INFO] [stderr] Checking phf_shared v0.13.1 [INFO] [stderr] Checking expect-test v1.5.1 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking saturating v0.1.0 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking murmur3 v0.5.2 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking as-any v0.3.2 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking getrandom v0.4.1 [INFO] [stderr] Checking rust-ini v0.21.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking whoami v2.1.1 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking keyed_priority_queue v0.4.2 [INFO] [stderr] Checking lru v0.14.0 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking hashlink v0.11.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking etcetera v0.11.0 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking jiff v0.2.21 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libz-sys v1.1.24 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling libsqlite3-sys v0.36.0 [INFO] [stderr] Compiling rdkafka-sys v4.10.0+2.12.1 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerocopy v0.8.39 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling prost-derive v0.14.3 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling serde_with_macros v3.17.0 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling bon-macros v3.9.0 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking serde_with v3.17.0 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Compiling num_enum_derive v0.7.5 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking prost v0.14.3 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking prost-types v0.14.3 [INFO] [stderr] Checking backon v1.6.0 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Compiling typed-builder-macro v0.20.1 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking num_enum v0.7.5 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling mysql-common-derive v0.32.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking arrow-buffer v57.3.0 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking moka v0.12.13 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking arrow-data v57.3.0 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking postgres-protocol v0.6.10 [INFO] [stderr] Compiling parse-display-derive v0.9.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking typed-builder v0.20.1 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking ferroid v0.8.9 [INFO] [stderr] Checking astral-tokio-tar v0.5.6 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking postgres-types v0.2.12 [INFO] [stderr] Checking arrow-array v57.3.0 [INFO] [stderr] Checking docker_credential v1.3.2 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking tokio-postgres v0.7.16 [INFO] [stderr] Checking bon v3.9.0 [INFO] [stderr] Checking apache-avro v0.21.0 [INFO] [stderr] Checking rusqlite v0.38.0 [INFO] [stderr] Checking parse-display v0.9.1 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking arrow-select v57.3.0 [INFO] [stderr] Checking arrow-arith v57.3.0 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking arrow-ord v57.3.0 [INFO] [stderr] Checking arrow-ipc v57.3.0 [INFO] [stderr] Checking arrow-string v57.3.0 [INFO] [stderr] Checking mysql_async v0.36.1 [INFO] [stderr] Checking arrow-cast v57.3.0 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking parquet v57.3.0 [INFO] [stderr] Checking hyperlocal v0.9.1 [INFO] [stderr] Checking rdkafka v0.39.0 [INFO] [stderr] Checking tonic v0.14.5 [INFO] [stderr] Checking tonic-prost v0.14.5 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking ureq v3.2.0 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking reqsign v0.16.5 [INFO] [stderr] Checking opendal v0.55.0 [INFO] [stderr] Checking bollard-stubs v1.52.1-rc.29.1.3 [INFO] [stderr] Checking iceberg v0.8.0 [INFO] [stderr] Checking iceberg-catalog-rest v0.8.0 [INFO] [stderr] Checking bollard v0.20.1 [INFO] [stderr] Checking cdcflow v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking testcontainers v0.27.1 [INFO] [stderr] Checking testcontainers-modules v0.15.0 [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/schema/value.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 140 | let row_new = event.new.as_ref().map(|r| row_to_typed_json(r)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `row_to_typed_json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/schema/value.rs:141:42 [INFO] [stdout] | [INFO] [stdout] 141 | let row_old = event.old.as_ref().map(|r| row_to_typed_json(r)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `row_to_typed_json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 49 | .fields() [INFO] [stdout] | __________________^ [INFO] [stdout] 50 | | .iter() [INFO] [stdout] 51 | | .cloned() [INFO] [stdout] 52 | | .collect(); [INFO] [stdout] | |__________________^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `next_id` is used as a loop counter [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | for col in new_columns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (next_id, col) in (current_schema.highest_field_id() + 1..).zip(new_columns.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 97 | .fields() [INFO] [stdout] | __________________^ [INFO] [stdout] 98 | | .iter() [INFO] [stdout] 99 | | .cloned() [INFO] [stdout] 100 | | .collect(); [INFO] [stdout] | |__________________^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `insert_at` is used as a loop counter [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | for col in new_columns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (insert_at, col) in (old_start..).zip(new_columns.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/source/mysql/snapshot.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / async fn snapshot_table( [INFO] [stdout] 119 | | conn: &mut Conn, [INFO] [stdout] 120 | | schema: &str, [INFO] [stdout] 121 | | table: &str, [INFO] [stdout] ... | [INFO] [stdout] 126 | | sender: &mpsc::Sender, [INFO] [stdout] 127 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/source/postgres/replication_client.rs:303:21 [INFO] [stdout] | [INFO] [stdout] 303 | / if payload.len() >= 2 { [INFO] [stdout] 304 | | num_cols = [INFO] [stdout] 305 | | i16::from_be_bytes(payload[0..2].try_into().unwrap()) as usize; [INFO] [stdout] 306 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 ~ b'T' [INFO] [stdout] 302 | // RowDescription [INFO] [stdout] 303 ~ if payload.len() >= 2 => { [INFO] [stdout] 304 | num_cols = [INFO] [stdout] 305 | i16::from_be_bytes(payload[0..2].try_into().unwrap()) as usize; [INFO] [stdout] 306 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/config/source.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | impl SourceConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/schema/value.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 140 | let row_new = event.new.as_ref().map(|r| row_to_typed_json(r)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `row_to_typed_json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/schema/value.rs:141:42 [INFO] [stdout] | [INFO] [stdout] 141 | let row_old = event.old.as_ref().map(|r| row_to_typed_json(r)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `row_to_typed_json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 49 | .fields() [INFO] [stdout] | __________________^ [INFO] [stdout] 50 | | .iter() [INFO] [stdout] 51 | | .cloned() [INFO] [stdout] 52 | | .collect(); [INFO] [stdout] | |__________________^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `next_id` is used as a loop counter [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | for col in new_columns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (next_id, col) in (current_schema.highest_field_id() + 1..).zip(new_columns.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 97 | .fields() [INFO] [stdout] | __________________^ [INFO] [stdout] 98 | | .iter() [INFO] [stdout] 99 | | .cloned() [INFO] [stdout] 100 | | .collect(); [INFO] [stdout] | |__________________^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `insert_at` is used as a loop counter [INFO] [stdout] --> src/sink/iceberg/schema_evolution.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | for col in new_columns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (insert_at, col) in (old_start..).zip(new_columns.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/source/mysql/snapshot.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / async fn snapshot_table( [INFO] [stdout] 119 | | conn: &mut Conn, [INFO] [stdout] 120 | | schema: &str, [INFO] [stdout] 121 | | table: &str, [INFO] [stdout] ... | [INFO] [stdout] 126 | | sender: &mpsc::Sender, [INFO] [stdout] 127 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/source/postgres/replication_client.rs:303:21 [INFO] [stdout] | [INFO] [stdout] 303 | / if payload.len() >= 2 { [INFO] [stdout] 304 | | num_cols = [INFO] [stdout] 305 | | i16::from_be_bytes(payload[0..2].try_into().unwrap()) as usize; [INFO] [stdout] 306 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 ~ b'T' [INFO] [stdout] 302 | // RowDescription [INFO] [stdout] 303 ~ if payload.len() >= 2 => { [INFO] [stdout] 304 | num_cols = [INFO] [stdout] 305 | i16::from_be_bytes(payload[0..2].try_into().unwrap()) as usize; [INFO] [stdout] 306 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/sink/iceberg/mod.rs:1590:22 [INFO] [stdout] | [INFO] [stdout] 1590 | let events = vec![ [INFO] [stdout] | ______________________^ [INFO] [stdout] 1591 | | make_insert_event("users", "1"), [INFO] [stdout] 1592 | | make_truncate_event("users"), [INFO] [stdout] 1593 | | make_insert_event("users", "2"), [INFO] [stdout] 1594 | | make_insert_event("users", "3"), [INFO] [stdout] 1595 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 1590 ~ let events = [make_insert_event("users", "1"), [INFO] [stdout] 1591 + make_truncate_event("users"), [INFO] [stdout] 1592 + make_insert_event("users", "2"), [INFO] [stdout] 1593 ~ make_insert_event("users", "3")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/sink/iceberg/mod.rs:1608:22 [INFO] [stdout] | [INFO] [stdout] 1608 | let events = vec![make_truncate_event("users")]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[make_truncate_event("users")]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/sink/iceberg/mod.rs:1619:22 [INFO] [stdout] | [INFO] [stdout] 1619 | let events = vec![ [INFO] [stdout] | ______________________^ [INFO] [stdout] 1620 | | make_truncate_event("users"), [INFO] [stdout] 1621 | | make_insert_event("users", "1"), [INFO] [stdout] 1622 | | make_insert_event("users", "2"), [INFO] [stdout] 1623 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 1619 ~ let events = [make_truncate_event("users"), [INFO] [stdout] 1620 + make_insert_event("users", "1"), [INFO] [stdout] 1621 ~ make_insert_event("users", "2")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/sink/iceberg/mod.rs:1634:22 [INFO] [stdout] | [INFO] [stdout] 1634 | let events = vec![ [INFO] [stdout] | ______________________^ [INFO] [stdout] 1635 | | make_insert_event("users", "1"), [INFO] [stdout] 1636 | | make_truncate_event("users"), [INFO] [stdout] 1637 | | make_insert_event("users", "2"), [INFO] [stdout] 1638 | | make_truncate_event("users"), [INFO] [stdout] 1639 | | make_insert_event("users", "3"), [INFO] [stdout] 1640 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 1634 ~ let events = [make_insert_event("users", "1"), [INFO] [stdout] 1635 + make_truncate_event("users"), [INFO] [stdout] 1636 + make_insert_event("users", "2"), [INFO] [stdout] 1637 + make_truncate_event("users"), [INFO] [stdout] 1638 ~ make_insert_event("users", "3")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/sink/iceberg/mod.rs:1651:22 [INFO] [stdout] | [INFO] [stdout] 1651 | let events = vec![ [INFO] [stdout] | ______________________^ [INFO] [stdout] 1652 | | make_insert_event("users", "1"), [INFO] [stdout] 1653 | | make_insert_event("users", "2"), [INFO] [stdout] 1654 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 1651 ~ let events = [make_insert_event("users", "1"), [INFO] [stdout] 1652 ~ make_insert_event("users", "2")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 31s [INFO] running `Command { std: "docker" "inspect" "9708837b88dc0439c1d80b7d1a0a0e24779b866ea049450805b8cddcf4429885", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9708837b88dc0439c1d80b7d1a0a0e24779b866ea049450805b8cddcf4429885", kill_on_drop: false }` [INFO] [stdout] 9708837b88dc0439c1d80b7d1a0a0e24779b866ea049450805b8cddcf4429885