[INFO] fetching crate ccgo 3.3.0... [INFO] linting ccgo-3.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ccgo 3.3.0 into /workspace/builds/worker-2-tc1/source [INFO] removed /workspace/builds/worker-2-tc1/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-2-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate ccgo 3.3.0 [INFO] finished tweaking crates.io crate ccgo 3.3.0 [INFO] tweaked toml for crates.io crate ccgo 3.3.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ccgo 3.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate ccgo 3.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded which v7.0.3 [INFO] [stderr] Downloaded zmij v1.0.6 [INFO] [stderr] Downloaded deflate64 v0.1.10 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded zip v2.4.2 [INFO] [stderr] Downloaded bzip2 v0.5.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bd1690ebb0f7329a1e0692e619040a75b09e70aa71c0aabdaa1c8771d0eacb0 [INFO] running `Command { std: "docker" "start" "-a" "0bd1690ebb0f7329a1e0692e619040a75b09e70aa71c0aabdaa1c8771d0eacb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bd1690ebb0f7329a1e0692e619040a75b09e70aa71c0aabdaa1c8771d0eacb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bd1690ebb0f7329a1e0692e619040a75b09e70aa71c0aabdaa1c8771d0eacb0", kill_on_drop: false }` [INFO] [stdout] 0bd1690ebb0f7329a1e0692e619040a75b09e70aa71c0aabdaa1c8771d0eacb0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbfbeec5dae348991a457dda636db0510be715f73661053f9ffee367644529bc [INFO] running `Command { std: "docker" "start" "-a" "cbfbeec5dae348991a457dda636db0510be715f73661053f9ffee367644529bc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.104 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling find-msvc-tools v0.1.6 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling zmij v1.0.6 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking crc v3.4.0 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Compiling syn v2.0.112 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking bumpalo v3.19.1 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking deflate64 v0.1.10 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling assert_cmd v2.1.1 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Checking open v5.3.3 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking which v7.0.3 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking md5 v0.8.0 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking bzip2 v0.5.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking ccgo v3.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/commands/build.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/commands/search.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DependencyGraph` and `DependencyNode` [INFO] [stdout] --> src/dependency/mod.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub use graph::{DependencyGraph, DependencyNode}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `resolver::DependencyResolver` [INFO] [stdout] --> src/dependency/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use resolver::DependencyResolver; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ConflictStrategy`, `VersionConflict`, `VersionRequirement`, and `VersionResolver` [INFO] [stdout] --> src/dependency/mod.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | pub use version_resolver::{ConflictStrategy, VersionConflict, VersionRequirement, VersionResolver}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt` [INFO] [stdout] --> src/error.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::fmt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/error.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/testing/ci.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CoverageConfig`, `CoverageFormat`, and `CoverageReport` [INFO] [stdout] --> src/testing/mod.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | pub use coverage::{CoverageConfig, CoverageFormat, CoverageReport}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DiscoveredTest` and `TestDiscovery` [INFO] [stdout] --> src/testing/mod.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub use discovery::{DiscoveredTest, TestDiscovery}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TestResultAggregator`, `TestResult`, and `TestSummary` [INFO] [stdout] --> src/testing/mod.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub use results::{TestResult, TestResultAggregator, TestSummary}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BenchmarkComparison`, `BenchmarkResult`, and `BenchmarkStore` [INFO] [stdout] --> src/testing/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | pub use benchmark::{BenchmarkComparison, BenchmarkResult, BenchmarkStore}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CiFormat` and `CiReporter` [INFO] [stdout] --> src/testing/mod.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | pub use ci::{CiFormat, CiReporter}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/workspace/resolver.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/commands/build.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/commands/search.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DependencyGraph` and `DependencyNode` [INFO] [stdout] --> src/dependency/mod.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub use graph::{DependencyGraph, DependencyNode}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `resolver::DependencyResolver` [INFO] [stdout] --> src/dependency/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use resolver::DependencyResolver; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ConflictStrategy`, `VersionConflict`, `VersionRequirement`, and `VersionResolver` [INFO] [stdout] --> src/dependency/mod.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | pub use version_resolver::{ConflictStrategy, VersionConflict, VersionRequirement, VersionResolver}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt` [INFO] [stdout] --> src/error.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::fmt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/error.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/testing/ci.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CoverageConfig`, `CoverageFormat`, and `CoverageReport` [INFO] [stdout] --> src/testing/mod.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | pub use coverage::{CoverageConfig, CoverageFormat, CoverageReport}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DiscoveredTest` and `TestDiscovery` [INFO] [stdout] --> src/testing/mod.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub use discovery::{DiscoveredTest, TestDiscovery}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TestResultAggregator`, `TestResult`, and `TestSummary` [INFO] [stdout] --> src/testing/mod.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub use results::{TestResult, TestResultAggregator, TestSummary}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BenchmarkComparison`, `BenchmarkResult`, and `BenchmarkStore` [INFO] [stdout] --> src/testing/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | pub use benchmark::{BenchmarkComparison, BenchmarkResult, BenchmarkStore}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CiFormat` and `CiReporter` [INFO] [stdout] --> src/testing/mod.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | pub use ci::{CiFormat, CiReporter}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/workspace/resolver.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CcgoConfig`, `PackageConfig`, `WorkspaceConfig`, and `WorkspaceDependency` [INFO] [stdout] --> src/workspace/resolver.rs:176:25 [INFO] [stdout] | [INFO] [stdout] 176 | use crate::config::{CcgoConfig, PackageConfig, WorkspaceConfig, WorkspaceDependency}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_archs` [INFO] [stdout] --> src/commands/build.rs:706:13 [INFO] [stdout] | [INFO] [stdout] 706 | let all_archs: Vec = results [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_archs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `install_path` [INFO] [stdout] --> src/commands/install.rs:965:17 [INFO] [stdout] | [INFO] [stdout] 965 | let install_path = deps_dir.join(&dep.name); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_install_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_archs` [INFO] [stdout] --> src/commands/build.rs:706:13 [INFO] [stdout] | [INFO] [stdout] 706 | let all_archs: Vec = results [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_archs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `install_path` [INFO] [stdout] --> src/commands/install.rs:965:17 [INFO] [stdout] | [INFO] [stdout] 965 | let install_path = deps_dir.join(&dep.name); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_install_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `req1` [INFO] [stdout] --> src/dependency/version_resolver.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_req1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `req2` [INFO] [stdout] --> src/dependency/version_resolver.rs:75:45 [INFO] [stdout] | [INFO] [stdout] 75 | (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_req2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/testing/results.rs:447:21 [INFO] [stdout] | [INFO] [stdout] 447 | let mut test = TestResult::passed(&classname, &name, time); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `deps` [INFO] [stdout] --> src/dependency/resolver.rs:329:43 [INFO] [stdout] | [INFO] [stdout] 329 | fn create_test_dependency(name: &str, deps: Vec<&str>) -> DependencyConfig { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_deps` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `req1` [INFO] [stdout] --> src/dependency/version_resolver.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_req1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `req2` [INFO] [stdout] --> src/dependency/version_resolver.rs:75:45 [INFO] [stdout] | [INFO] [stdout] 75 | (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_req2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `build_dependency_entry` is never used [INFO] [stdout] --> src/commands/add.rs:224:8 [INFO] [stdout] | [INFO] [stdout] 75 | impl AddCommand { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 224 | fn build_dependency_entry(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `roots` is never used [INFO] [stdout] --> src/dependency/graph.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl DependencyGraph { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn roots(&self) -> &HashSet { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `max_depth` is never read [INFO] [stdout] --> src/dependency/graph.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 344 | pub struct DependencyStats { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 355 | pub max_depth: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DependencyStats` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `set_strategy`, `graph`, `version_resolver`, and `has_version_conflicts` are never used [INFO] [stdout] --> src/dependency/resolver.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl DependencyResolver { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 37 | /// Create a new dependency resolver [INFO] [stdout] 38 | pub fn new(project_root: PathBuf, ccgo_home: PathBuf) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn set_strategy(&mut self, strategy: ConflictStrategy) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 279 | pub fn graph(&self) -> &DependencyGraph { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 284 | pub fn version_resolver(&self) -> &VersionResolver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 289 | pub fn has_version_conflicts(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `resolve_dependencies` is never used [INFO] [stdout] --> src/dependency/resolver.rs:295:8 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn resolve_dependencies( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `resolve` is never used [INFO] [stdout] --> src/dependency/version_resolver.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 125 | impl VersionConflict { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 161 | pub fn resolve(&self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_strategy`, `strategy`, and `resolve_package` are never used [INFO] [stdout] --> src/dependency/version_resolver.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 274 | impl VersionResolver { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 292 | pub fn set_strategy(&mut self, strategy: ConflictStrategy) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 297 | pub fn strategy(&self) -> ConflictStrategy { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 347 | pub fn resolve_package(&self, package: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CcgoError` is never used [INFO] [stdout] --> src/error.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | pub enum CcgoError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/error.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 70 | impl CcgoError { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 71 | /// Create a configuration error with a hint [INFO] [stdout] 72 | pub fn config_error(message: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn config_error_with_hint( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn dependency_error( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub fn dependency_error_with_hint( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | pub fn missing_tool( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | pub fn build_failure( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn build_failure_with_diagnostics( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn project_structure_error( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 177 | pub fn version_error( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 190 | pub fn display_with_hints(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ResultExt` is never used [INFO] [stdout] --> src/error.rs:235:11 [INFO] [stdout] | [INFO] [stdout] 235 | pub trait ResultExt { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cmake` is never used [INFO] [stdout] --> src/error.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn cmake() -> &'static str { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `git` is never used [INFO] [stdout] --> src/error.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 283 | pub fn git() -> &'static str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `android_ndk` is never used [INFO] [stdout] --> src/error.rs:291:12 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn android_ndk() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `xcode` is never used [INFO] [stdout] --> src/error.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn xcode() -> &'static str { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `visual_studio` is never used [INFO] [stdout] --> src/error.rs:312:12 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn visual_studio() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mingw` is never used [INFO] [stdout] --> src/error.rs:322:12 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn mingw() -> &'static str { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gradle` is never used [INFO] [stdout] --> src/error.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | pub fn gradle() -> &'static str { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `python` is never used [INFO] [stdout] --> src/error.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn python() -> &'static str { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `doxygen` is never used [INFO] [stdout] --> src/error.rs:346:12 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn doxygen() -> &'static str { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `ccgo_toml_not_found` is never used [INFO] [stdout] --> src/error.rs:354:12 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn ccgo_toml_not_found() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `invalid_ccgo_toml` is never used [INFO] [stdout] --> src/error.rs:365:12 [INFO] [stdout] | [INFO] [stdout] 365 | pub fn invalid_ccgo_toml() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dependency_resolution` is never used [INFO] [stdout] --> src/error.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | pub fn dependency_resolution() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_config` is never used [INFO] [stdout] --> src/error.rs:384:12 [INFO] [stdout] | [INFO] [stdout] 384 | pub fn build_config() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lockfile_mismatch` is never used [INFO] [stdout] --> src/error.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn lockfile_mismatch() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `source_dir`, `format`, `include`, `threshold`, and `fail_under` are never read [INFO] [stdout] --> src/testing/coverage.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub struct CoverageConfig { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 58 | /// Source directory to analyze [INFO] [stdout] 59 | pub source_dir: PathBuf, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub format: CoverageFormat, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub include: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 70 | /// Minimum coverage threshold (0-100) [INFO] [stdout] 71 | pub threshold: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 72 | /// Whether to fail if below threshold [INFO] [stdout] 73 | pub fail_under: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CoverageConfig` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `branch_coverage_percent` and `function_coverage_percent` are never used [INFO] [stdout] --> src/testing/coverage.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 117 | impl FileCoverage { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn branch_coverage_percent(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 137 | pub fn function_coverage_percent(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_json` is never used [INFO] [stdout] --> src/testing/coverage.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 167 | impl CoverageReport { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 282 | pub fn to_json(&self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `verbose` is never read [INFO] [stdout] --> src/testing/discovery.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct TestDiscovery { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 56 | verbose: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `failed` is never used [INFO] [stdout] --> src/testing/results.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 51 | impl TestResult { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn failed(suite: &str, name: &str, duration: f64, message: &str) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `passed_count` and `all_passed` are never used [INFO] [stdout] --> src/testing/results.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 99 | impl TestSuiteResult { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn passed_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 132 | pub fn all_passed(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_json` is never used [INFO] [stdout] --> src/testing/results.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 160 | impl TestSummary { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 267 | pub fn to_json(&self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_result_file` is never used [INFO] [stdout] --> src/testing/results.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 359 | impl TestResultAggregator { [INFO] [stdout] | ------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 369 | pub fn add_result_file(&mut self, path: PathBuf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `auto_detect` is never used [INFO] [stdout] --> src/testing/ci.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 76 | impl CiReporter { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub fn auto_detect() -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root_config` is never read [INFO] [stdout] --> src/workspace/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Workspace { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 28 | pub root_config: CcgoConfig, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Workspace` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `resolve_member_dependencies` is never used [INFO] [stdout] --> src/workspace/mod.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Workspace { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | pub fn resolve_member_dependencies( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path` and `config` are never read [INFO] [stdout] --> src/workspace/members.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct WorkspaceMember { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub config: CcgoConfig, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WorkspaceMember` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_empty` and `filter` are never used [INFO] [stdout] --> src/workspace/members.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl WorkspaceMembers { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 171 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 181 | pub fn filter(&self, predicate: F) -> Vec<&WorkspaceMember> [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `WorkspaceResolver` is never constructed [INFO] [stdout] --> src/workspace/resolver.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct WorkspaceResolver<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/workspace/resolver.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> WorkspaceResolver<'a> { [INFO] [stdout] | ------------------------------ associated items in this implementation [INFO] [stdout] 14 | /// Create a new workspace resolver [INFO] [stdout] 15 | pub fn new(workspace: &'a Workspace) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn resolve_member_dependencies( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | fn find_workspace_dependency(&self, name: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn resolve_all(&self) -> Result>> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn depends_on_member(&self, member: &WorkspaceMember, target: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn build_order(&self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn visit_member<'b>( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/build/archive.rs:939:8 [INFO] [stdout] | [INFO] [stdout] 939 | if &header[..2] == [0x1F, 0x8B] { [INFO] [stdout] | ------------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `header[..2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/build/archive.rs:1024:24 [INFO] [stdout] | [INFO] [stdout] 1024 | let filename = path.split('/').last().unwrap_or(&path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1024 - let filename = path.split('/').last().unwrap_or(&path); [INFO] [stdout] 1024 + let filename = path.split('/').next_back().unwrap_or(&path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/testing/results.rs:447:21 [INFO] [stdout] | [INFO] [stdout] 447 | let mut test = TestResult::passed(&classname, &name, time); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/build/docker.rs:249:54 [INFO] [stdout] | [INFO] [stdout] 249 | .args(["tag", &self.config.remote_image, &self.config.image_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.config.image_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/build/docker.rs:469:32 [INFO] [stdout] | [INFO] [stdout] 469 | ... let download_cmd = format!( [INFO] [stdout] | __________________________^ [INFO] [stdout] 470 | | ... "echo 'Downloading pre-built ccgo from GitHub releases...' && \ [INFO] [stdout] 471 | | ... curl -fsSL https://github.com/zhlinh/ccgo/releases/latest/download/ccgo-x86_64-unknown-linux-gnu.tar.gz -o /tmp/ccgo.t... [INFO] [stdout] 472 | | ... tar xzf /tmp/ccgo.tar.gz -C /tmp && \ [INFO] [stdout] ... | [INFO] [stdout] 476 | | ... exit 1)" [INFO] [stdout] 477 | | ... ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 469 ~ let download_cmd = "echo 'Downloading pre-built ccgo from GitHub releases...' && \ [INFO] [stdout] 470 + curl -fsSL https://github.com/zhlinh/ccgo/releases/latest/download/ccgo-x86_64-unknown-linux-gnu.tar.gz -o /tmp/ccgo.tar.gz && \ [INFO] [stdout] 471 + tar xzf /tmp/ccgo.tar.gz -C /tmp && \ [INFO] [stdout] 472 + chmod +x /tmp/ccgo-x86_64-unknown-linux-gnu/ccgo || \ [INFO] [stdout] 473 + (echo 'ERROR: Failed to download ccgo from GitHub releases.' && \ [INFO] [stdout] 474 + echo 'No release found. Try without --dev flag to use pre-installed ccgo' && \ [INFO] [stdout] 475 ~ exit 1)".to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/build/docker.rs:481:29 [INFO] [stdout] | [INFO] [stdout] 481 | let setup_cmd = format!( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 482 | | "command -v ccgo >/dev/null 2>&1 || \ [INFO] [stdout] 483 | | (pip3 install -q ccgo) || \ [INFO] [stdout] 484 | | (echo 'ERROR: ccgo not found.' && exit 1)" [INFO] [stdout] 485 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 481 ~ let setup_cmd = "command -v ccgo >/dev/null 2>&1 || \ [INFO] [stdout] 482 + (pip3 install -q ccgo) || \ [INFO] [stdout] 483 ~ (echo 'ERROR: ccgo not found.' && exit 1)".to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:127:41 [INFO] [stdout] | [INFO] [stdout] 127 | fn find_libraries(&self, build_dir: &PathBuf, is_shared: bool, link_type: &str, abi: AndroidAbi) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 - fn find_libraries(&self, build_dir: &PathBuf, is_shared: bool, link_type: &str, abi: AndroidAbi) -> Result> { [INFO] [stdout] 127 + fn find_libraries(&self, build_dir: &Path, is_shared: bool, link_type: &str, abi: AndroidAbi) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:237:26 [INFO] [stdout] | [INFO] [stdout] 237 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 237 - symbols_staging: &PathBuf, [INFO] [stdout] 237 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:340:26 [INFO] [stdout] | [INFO] [stdout] 340 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 340 - symbols_staging: &PathBuf, [INFO] [stdout] 340 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:410:39 [INFO] [stdout] | [INFO] [stdout] 410 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 410 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 410 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/android.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | / for dir in possible_dirs { [INFO] [stdout] 418 | | if dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false) { [INFO] [stdout] 419 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 422 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false))` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/build/platforms/android.rs:602:44 [INFO] [stdout] | [INFO] [stdout] 602 | for entry in std::fs::read_dir(&output_dir)? { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:625:26 [INFO] [stdout] | [INFO] [stdout] 625 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 625 - symbols_staging: &PathBuf, [INFO] [stdout] 625 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/build/platforms/benches.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 355 | if !which::which("cmake").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `which::which("cmake").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/conan.rs:218:39 [INFO] [stdout] | [INFO] [stdout] 218 | fn find_lib_dir(&self, build_dir: &PathBuf, _is_release: bool) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 218 - fn find_lib_dir(&self, build_dir: &PathBuf, _is_release: bool) -> Option { [INFO] [stdout] 218 + fn find_lib_dir(&self, build_dir: &Path, _is_release: bool) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/conan.rs:255:43 [INFO] [stdout] | [INFO] [stdout] 255 | fn find_include_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 255 - fn find_include_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 255 + fn find_include_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/conan.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / for dir in possible_dirs { [INFO] [stdout] 263 | | if dir.exists() { [INFO] [stdout] 264 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 267 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists())` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `roots` is never used [INFO] [stdout] --> src/dependency/graph.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl DependencyGraph { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn roots(&self) -> &HashSet { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `max_depth` is never read [INFO] [stdout] --> src/dependency/graph.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 344 | pub struct DependencyStats { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 355 | pub max_depth: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DependencyStats` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_strategy`, `graph`, `version_resolver`, and `has_version_conflicts` are never used [INFO] [stdout] --> src/dependency/resolver.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl DependencyResolver { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn set_strategy(&mut self, strategy: ConflictStrategy) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 279 | pub fn graph(&self) -> &DependencyGraph { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 284 | pub fn version_resolver(&self) -> &VersionResolver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 289 | pub fn has_version_conflicts(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `resolve_dependencies` is never used [INFO] [stdout] --> src/dependency/resolver.rs:295:8 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn resolve_dependencies( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CcgoError` is never used [INFO] [stdout] --> src/error.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | pub enum CcgoError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/error.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 70 | impl CcgoError { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 71 | /// Create a configuration error with a hint [INFO] [stdout] 72 | pub fn config_error(message: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn config_error_with_hint( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn dependency_error( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub fn dependency_error_with_hint( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | pub fn missing_tool( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | pub fn build_failure( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn build_failure_with_diagnostics( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn project_structure_error( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 177 | pub fn version_error( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 190 | pub fn display_with_hints(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ResultExt` is never used [INFO] [stdout] --> src/error.rs:235:11 [INFO] [stdout] | [INFO] [stdout] 235 | pub trait ResultExt { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cmake` is never used [INFO] [stdout] --> src/error.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn cmake() -> &'static str { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `git` is never used [INFO] [stdout] --> src/error.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 283 | pub fn git() -> &'static str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `android_ndk` is never used [INFO] [stdout] --> src/error.rs:291:12 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn android_ndk() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `xcode` is never used [INFO] [stdout] --> src/error.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn xcode() -> &'static str { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `visual_studio` is never used [INFO] [stdout] --> src/error.rs:312:12 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn visual_studio() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mingw` is never used [INFO] [stdout] --> src/error.rs:322:12 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn mingw() -> &'static str { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gradle` is never used [INFO] [stdout] --> src/error.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | pub fn gradle() -> &'static str { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `python` is never used [INFO] [stdout] --> src/error.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn python() -> &'static str { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `doxygen` is never used [INFO] [stdout] --> src/error.rs:346:12 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn doxygen() -> &'static str { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `ccgo_toml_not_found` is never used [INFO] [stdout] --> src/error.rs:354:12 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn ccgo_toml_not_found() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `invalid_ccgo_toml` is never used [INFO] [stdout] --> src/error.rs:365:12 [INFO] [stdout] | [INFO] [stdout] 365 | pub fn invalid_ccgo_toml() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dependency_resolution` is never used [INFO] [stdout] --> src/error.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | pub fn dependency_resolution() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_config` is never used [INFO] [stdout] --> src/error.rs:384:12 [INFO] [stdout] | [INFO] [stdout] 384 | pub fn build_config() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lockfile_mismatch` is never used [INFO] [stdout] --> src/error.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn lockfile_mismatch() -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `source_dir`, `format`, `include`, `threshold`, and `fail_under` are never read [INFO] [stdout] --> src/testing/coverage.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub struct CoverageConfig { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 58 | /// Source directory to analyze [INFO] [stdout] 59 | pub source_dir: PathBuf, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub format: CoverageFormat, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub include: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 70 | /// Minimum coverage threshold (0-100) [INFO] [stdout] 71 | pub threshold: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 72 | /// Whether to fail if below threshold [INFO] [stdout] 73 | pub fail_under: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CoverageConfig` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `branch_coverage_percent` and `function_coverage_percent` are never used [INFO] [stdout] --> src/testing/coverage.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 117 | impl FileCoverage { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn branch_coverage_percent(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 137 | pub fn function_coverage_percent(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_json` is never used [INFO] [stdout] --> src/testing/coverage.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 167 | impl CoverageReport { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 282 | pub fn to_json(&self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `verbose` is never read [INFO] [stdout] --> src/testing/discovery.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct TestDiscovery { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 56 | verbose: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_json` is never used [INFO] [stdout] --> src/testing/results.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 160 | impl TestSummary { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 267 | pub fn to_json(&self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_result_file` is never used [INFO] [stdout] --> src/testing/results.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 359 | impl TestResultAggregator { [INFO] [stdout] | ------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 369 | pub fn add_result_file(&mut self, path: PathBuf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `auto_detect` is never used [INFO] [stdout] --> src/testing/ci.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 76 | impl CiReporter { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub fn auto_detect() -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root_config` is never read [INFO] [stdout] --> src/workspace/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Workspace { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 28 | pub root_config: CcgoConfig, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Workspace` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `resolve_member_dependencies` is never used [INFO] [stdout] --> src/workspace/mod.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Workspace { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | pub fn resolve_member_dependencies( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/workspace/members.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct WorkspaceMember { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WorkspaceMember` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_empty` and `filter` are never used [INFO] [stdout] --> src/workspace/members.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl WorkspaceMembers { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 171 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 181 | pub fn filter(&self, predicate: F) -> Vec<&WorkspaceMember> [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `resolve_all`, `depends_on_member`, `build_order`, and `visit_member` are never used [INFO] [stdout] --> src/workspace/resolver.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> WorkspaceResolver<'a> { [INFO] [stdout] | ------------------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn resolve_all(&self) -> Result>> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn depends_on_member(&self, member: &WorkspaceMember, target: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn build_order(&self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn visit_member<'b>( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/build/platforms/conan.rs:382:54 [INFO] [stdout] | [INFO] [stdout] 382 | let sdk_archive = archive.create_sdk_archive(&[host_arch.clone()], &link_type_str)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(&host_arch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ios.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 58 - build_dir: &PathBuf, [INFO] [stdout] 58 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/ios.rs:89:38 [INFO] [stdout] | [INFO] [stdout] 89 | if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 89 - if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] 89 + if module_libs.len() == 1 && module_libs[0].file_name().is_some_and(|n| n == main_lib_name.as_str()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ios.rs:211:43 [INFO] [stdout] | [INFO] [stdout] 211 | fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 211 - fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] 211 + fn find_libraries(&self, install_dir: &Path, is_shared: bool) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ios.rs:344:39 [INFO] [stdout] | [INFO] [stdout] 344 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 344 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 344 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/ios.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | / for dir in possible_dirs { [INFO] [stdout] 352 | | if dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false) { [INFO] [stdout] 353 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 356 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false))` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 62 - if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] 62 + if entry.path().extension().is_some_and(|e| e == "a") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:83:28 [INFO] [stdout] | [INFO] [stdout] 83 | if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 83 - if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] 83 + if entry.path().extension().is_some_and(|e| e == "a") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:289:24 [INFO] [stdout] | [INFO] [stdout] 289 | if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 289 - if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] 289 + if path.extension().is_some_and(|e| e == "klib") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:301:24 [INFO] [stdout] | [INFO] [stdout] 301 | if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 301 - if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] 301 + if path.extension().is_some_and(|e| e == "klib") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/linux.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - build_dir: &PathBuf, [INFO] [stdout] 32 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/linux.rs:107:38 [INFO] [stdout] | [INFO] [stdout] 107 | if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 107 - if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] 107 + if module_libs.len() == 1 && module_libs[0].file_name().is_some_and(|n| n == main_lib_name.as_str()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/linux.rs:325:39 [INFO] [stdout] | [INFO] [stdout] 325 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 325 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 325 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/linux.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | / for dir in possible_dirs { [INFO] [stdout] 336 | | if dir.exists() { [INFO] [stdout] 337 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 340 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists())` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/linux.rs:487:24 [INFO] [stdout] | [INFO] [stdout] 487 | if path.extension().map_or(false, |ext| ext == "so") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 487 - if path.extension().map_or(false, |ext| ext == "so") { [INFO] [stdout] 487 + if path.extension().is_some_and(|ext| ext == "so") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/macos.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - build_dir: &PathBuf, [INFO] [stdout] 46 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/macos.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | && module_libs[0] [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | .file_name() [INFO] [stdout] 80 | | .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] 80 + .is_some_and(|n| n == main_lib_name.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/macos.rs:222:43 [INFO] [stdout] | [INFO] [stdout] 222 | fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 222 - fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] 222 + fn find_libraries(&self, install_dir: &Path, is_shared: bool) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/macos.rs:333:39 [INFO] [stdout] | [INFO] [stdout] 333 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 333 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 333 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/macos.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | / for dir in possible_dirs { [INFO] [stdout] 341 | | if dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false) { [INFO] [stdout] 342 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 345 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false))` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 116 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 - build_dir: &PathBuf, [INFO] [stdout] 116 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:241:26 [INFO] [stdout] | [INFO] [stdout] 241 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 241 - symbols_staging: &PathBuf, [INFO] [stdout] 241 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/build/archive.rs:939:8 [INFO] [stdout] | [INFO] [stdout] 939 | if &header[..2] == [0x1F, 0x8B] { [INFO] [stdout] | ------------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `header[..2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/build/archive.rs:1024:24 [INFO] [stdout] | [INFO] [stdout] 1024 | let filename = path.split('/').last().unwrap_or(&path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1024 - let filename = path.split('/').last().unwrap_or(&path); [INFO] [stdout] 1024 + let filename = path.split('/').next_back().unwrap_or(&path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:392:21 [INFO] [stdout] | [INFO] [stdout] 392 | output_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 392 - output_dir: &PathBuf, [INFO] [stdout] 392 + output_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:520:26 [INFO] [stdout] | [INFO] [stdout] 520 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 520 - symbols_staging: &PathBuf, [INFO] [stdout] 520 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/tvos.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - build_dir: &PathBuf, [INFO] [stdout] 46 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/build/docker.rs:249:54 [INFO] [stdout] | [INFO] [stdout] 249 | .args(["tag", &self.config.remote_image, &self.config.image_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.config.image_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/tvos.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | && module_libs[0] [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | .file_name() [INFO] [stdout] 80 | | .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] 80 + .is_some_and(|n| n == main_lib_name.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/tvos.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | device_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 208 - device_lib: &PathBuf, [INFO] [stdout] 208 + device_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/tvos.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | simulator_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 209 - simulator_lib: &PathBuf, [INFO] [stdout] 209 + simulator_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/build/docker.rs:469:32 [INFO] [stdout] | [INFO] [stdout] 469 | ... let download_cmd = format!( [INFO] [stdout] | __________________________^ [INFO] [stdout] 470 | | ... "echo 'Downloading pre-built ccgo from GitHub releases...' && \ [INFO] [stdout] 471 | | ... curl -fsSL https://github.com/zhlinh/ccgo/releases/latest/download/ccgo-x86_64-unknown-linux-gnu.tar.gz -o /tmp/ccgo.t... [INFO] [stdout] 472 | | ... tar xzf /tmp/ccgo.tar.gz -C /tmp && \ [INFO] [stdout] ... | [INFO] [stdout] 476 | | ... exit 1)" [INFO] [stdout] 477 | | ... ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 469 ~ let download_cmd = "echo 'Downloading pre-built ccgo from GitHub releases...' && \ [INFO] [stdout] 470 + curl -fsSL https://github.com/zhlinh/ccgo/releases/latest/download/ccgo-x86_64-unknown-linux-gnu.tar.gz -o /tmp/ccgo.tar.gz && \ [INFO] [stdout] 471 + tar xzf /tmp/ccgo.tar.gz -C /tmp && \ [INFO] [stdout] 472 + chmod +x /tmp/ccgo-x86_64-unknown-linux-gnu/ccgo || \ [INFO] [stdout] 473 + (echo 'ERROR: Failed to download ccgo from GitHub releases.' && \ [INFO] [stdout] 474 + echo 'No release found. Try without --dev flag to use pre-installed ccgo' && \ [INFO] [stdout] 475 ~ exit 1)".to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/build/docker.rs:481:29 [INFO] [stdout] | [INFO] [stdout] 481 | let setup_cmd = format!( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 482 | | "command -v ccgo >/dev/null 2>&1 || \ [INFO] [stdout] 483 | | (pip3 install -q ccgo) || \ [INFO] [stdout] 484 | | (echo 'ERROR: ccgo not found.' && exit 1)" [INFO] [stdout] 485 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 481 ~ let setup_cmd = "command -v ccgo >/dev/null 2>&1 || \ [INFO] [stdout] 482 + (pip3 install -q ccgo) || \ [INFO] [stdout] 483 ~ (echo 'ERROR: ccgo not found.' && exit 1)".to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/watchos.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - build_dir: &PathBuf, [INFO] [stdout] 46 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/watchos.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | && module_libs[0] [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | .file_name() [INFO] [stdout] 80 | | .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] 80 + .is_some_and(|n| n == main_lib_name.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/watchos.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | device_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 208 - device_lib: &PathBuf, [INFO] [stdout] 208 + device_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/watchos.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | simulator_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 209 - simulator_lib: &PathBuf, [INFO] [stdout] 209 + simulator_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MSVC` contains a capitalized acronym [INFO] [stdout] --> src/build/platforms/windows.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | MSVC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Msvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/windows.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - build_dir: &PathBuf, [INFO] [stdout] 51 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/windows.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 109 - if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] 109 + if module_libs.len() == 1 && module_libs[0].file_name().is_some_and(|n| n == main_lib_name.as_str()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/windows.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 316 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 316 - build_dir: &PathBuf, [INFO] [stdout] 316 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/build/platforms/windows.rs:389:25 [INFO] [stdout] | [INFO] [stdout] 389 | / if name.ends_with(import_ext) { [INFO] [stdout] 390 | | if !libs.iter().any(|p: &PathBuf| p.file_name() == path.file_name()) { [INFO] [stdout] 391 | | libs.push(path); [INFO] [stdout] 392 | | } [INFO] [stdout] 393 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 389 ~ if name.ends_with(import_ext) [INFO] [stdout] 390 ~ && !libs.iter().any(|p: &PathBuf| p.file_name() == path.file_name()) { [INFO] [stdout] 391 | libs.push(path); [INFO] [stdout] 392 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:127:41 [INFO] [stdout] | [INFO] [stdout] 127 | fn find_libraries(&self, build_dir: &PathBuf, is_shared: bool, link_type: &str, abi: AndroidAbi) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 - fn find_libraries(&self, build_dir: &PathBuf, is_shared: bool, link_type: &str, abi: AndroidAbi) -> Result> { [INFO] [stdout] 127 + fn find_libraries(&self, build_dir: &Path, is_shared: bool, link_type: &str, abi: AndroidAbi) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:237:26 [INFO] [stdout] | [INFO] [stdout] 237 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 237 - symbols_staging: &PathBuf, [INFO] [stdout] 237 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:340:26 [INFO] [stdout] | [INFO] [stdout] 340 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 340 - symbols_staging: &PathBuf, [INFO] [stdout] 340 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:410:39 [INFO] [stdout] | [INFO] [stdout] 410 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 410 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 410 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/android.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | / for dir in possible_dirs { [INFO] [stdout] 418 | | if dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false) { [INFO] [stdout] 419 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 422 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false))` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/build/platforms/android.rs:602:44 [INFO] [stdout] | [INFO] [stdout] 602 | for entry in std::fs::read_dir(&output_dir)? { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/android.rs:625:26 [INFO] [stdout] | [INFO] [stdout] 625 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 625 - symbols_staging: &PathBuf, [INFO] [stdout] 625 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:184:34 [INFO] [stdout] | [INFO] [stdout] 184 | fn find_ndk_in_sdk(sdk_path: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 184 - fn find_ndk_in_sdk(sdk_path: &PathBuf) -> Option { [INFO] [stdout] 184 + fn find_ndk_in_sdk(sdk_path: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | versions.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 - versions.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 207 + versions.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:212:41 [INFO] [stdout] | [INFO] [stdout] 212 | fn parse_version_from_dirname(path: &PathBuf) -> Option<(u32, u32, u32)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 212 - fn parse_version_from_dirname(path: &PathBuf) -> Option<(u32, u32, u32)> { [INFO] [stdout] 212 + fn parse_version_from_dirname(path: &Path) -> Option<(u32, u32, u32)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:225:27 [INFO] [stdout] | [INFO] [stdout] 225 | fn is_valid_ndk(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 225 - fn is_valid_ndk(path: &PathBuf) -> bool { [INFO] [stdout] 225 + fn is_valid_ndk(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:242:36 [INFO] [stdout] | [INFO] [stdout] 242 | fn parse_ndk_version(ndk_path: &PathBuf) -> Result<(String, (u32, u32, u32))> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - fn parse_ndk_version(ndk_path: &PathBuf) -> Result<(String, (u32, u32, u32))> { [INFO] [stdout] 242 + fn parse_ndk_version(ndk_path: &Path) -> Result<(String, (u32, u32, u32))> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/build/platforms/benches.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 355 | if !which::which("cmake").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `which::which("cmake").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/conan.rs:218:39 [INFO] [stdout] | [INFO] [stdout] 218 | fn find_lib_dir(&self, build_dir: &PathBuf, _is_release: bool) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 218 - fn find_lib_dir(&self, build_dir: &PathBuf, _is_release: bool) -> Option { [INFO] [stdout] 218 + fn find_lib_dir(&self, build_dir: &Path, _is_release: bool) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/conan.rs:255:43 [INFO] [stdout] | [INFO] [stdout] 255 | fn find_include_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 255 - fn find_include_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 255 + fn find_include_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/conan.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / for dir in possible_dirs { [INFO] [stdout] 263 | | if dir.exists() { [INFO] [stdout] 264 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 267 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists())` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/build/platforms/conan.rs:382:54 [INFO] [stdout] | [INFO] [stdout] 382 | let sdk_archive = archive.create_sdk_archive(&[host_arch.clone()], &link_type_str)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(&host_arch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/ohos.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 111 | fn detect_version(sdk_path: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - fn detect_version(sdk_path: &PathBuf) -> Option { [INFO] [stdout] 111 + fn detect_version(sdk_path: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ios.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 58 - build_dir: &PathBuf, [INFO] [stdout] 58 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/build/toolchains/ohos.rs:145:41 [INFO] [stdout] | [INFO] [stdout] 145 | if let Some(version_part) = name_str.split('-').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 145 - if let Some(version_part) = name_str.split('-').last() { [INFO] [stdout] 145 + if let Some(version_part) = name_str.split('-').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/ios.rs:89:38 [INFO] [stdout] | [INFO] [stdout] 89 | if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 89 - if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] 89 + if module_libs.len() == 1 && module_libs[0].file_name().is_some_and(|n| n == main_lib_name.as_str()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IOS` contains a capitalized acronym [INFO] [stdout] --> src/build/toolchains/xcode.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | IOS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ios` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ios.rs:211:43 [INFO] [stdout] | [INFO] [stdout] 211 | fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 211 - fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] 211 + fn find_libraries(&self, install_dir: &Path, is_shared: bool) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ios.rs:344:39 [INFO] [stdout] | [INFO] [stdout] 344 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 344 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 344 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/ios.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | / for dir in possible_dirs { [INFO] [stdout] 352 | | if dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false) { [INFO] [stdout] 353 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 356 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false))` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/toolchains/xcode.rs:293:16 [INFO] [stdout] | [INFO] [stdout] 293 | if lib.extension().map_or(false, |e| e == "framework") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 293 - if lib.extension().map_or(false, |e| e == "framework") { [INFO] [stdout] 293 + if lib.extension().is_some_and(|e| e == "framework") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/mod.rs:56:33 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn is_valid_directory(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - pub fn is_valid_directory(path: &PathBuf) -> bool { [INFO] [stdout] 56 + pub fn is_valid_directory(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/mod.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn is_valid_file(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - pub fn is_valid_file(path: &PathBuf) -> bool { [INFO] [stdout] 61 + pub fn is_valid_file(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 62 - if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] 62 + if entry.path().extension().is_some_and(|e| e == "a") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:83:28 [INFO] [stdout] | [INFO] [stdout] 83 | if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 83 - if entry.path().extension().map_or(false, |e| e == "a") { [INFO] [stdout] 83 + if entry.path().extension().is_some_and(|e| e == "a") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:289:24 [INFO] [stdout] | [INFO] [stdout] 289 | if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 289 - if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] 289 + if path.extension().is_some_and(|e| e == "klib") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/kmp.rs:301:24 [INFO] [stdout] | [INFO] [stdout] 301 | if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 301 - if path.extension().map_or(false, |e| e == "klib") { [INFO] [stdout] 301 + if path.extension().is_some_and(|e| e == "klib") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/linux.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - build_dir: &PathBuf, [INFO] [stdout] 32 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/linux.rs:107:38 [INFO] [stdout] | [INFO] [stdout] 107 | if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 107 - if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] 107 + if module_libs.len() == 1 && module_libs[0].file_name().is_some_and(|n| n == main_lib_name.as_str()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/linux.rs:325:39 [INFO] [stdout] | [INFO] [stdout] 325 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 325 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 325 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/linux.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | / for dir in possible_dirs { [INFO] [stdout] 336 | | if dir.exists() { [INFO] [stdout] 337 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 340 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists())` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/linux.rs:487:24 [INFO] [stdout] | [INFO] [stdout] 487 | if path.extension().map_or(false, |ext| ext == "so") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 487 - if path.extension().map_or(false, |ext| ext == "so") { [INFO] [stdout] 487 + if path.extension().is_some_and(|ext| ext == "so") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/macos.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - build_dir: &PathBuf, [INFO] [stdout] 46 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/macos.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | && module_libs[0] [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | .file_name() [INFO] [stdout] 80 | | .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] 80 + .is_some_and(|n| n == main_lib_name.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/macos.rs:222:43 [INFO] [stdout] | [INFO] [stdout] 222 | fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 222 - fn find_libraries(&self, install_dir: &PathBuf, is_shared: bool) -> Result> { [INFO] [stdout] 222 + fn find_libraries(&self, install_dir: &Path, is_shared: bool) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/macos.rs:333:39 [INFO] [stdout] | [INFO] [stdout] 333 | fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 333 - fn find_lib_dir(&self, build_dir: &PathBuf) -> Option { [INFO] [stdout] 333 + fn find_lib_dir(&self, build_dir: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/build/platforms/macos.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | / for dir in possible_dirs { [INFO] [stdout] 341 | | if dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false) { [INFO] [stdout] 342 | | return Some(dir); [INFO] [stdout] ... | [INFO] [stdout] 345 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `possible_dirs.into_iter().find(|dir| dir.exists() && std::fs::read_dir(&dir).map(|d| d.count() > 0).unwrap_or(false))` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 116 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 - build_dir: &PathBuf, [INFO] [stdout] 116 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:241:26 [INFO] [stdout] | [INFO] [stdout] 241 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 241 - symbols_staging: &PathBuf, [INFO] [stdout] 241 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:392:21 [INFO] [stdout] | [INFO] [stdout] 392 | output_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 392 - output_dir: &PathBuf, [INFO] [stdout] 392 + output_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/ohos.rs:520:26 [INFO] [stdout] | [INFO] [stdout] 520 | symbols_staging: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 520 - symbols_staging: &PathBuf, [INFO] [stdout] 520 + symbols_staging: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/tvos.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - build_dir: &PathBuf, [INFO] [stdout] 46 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/tvos.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | && module_libs[0] [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | .file_name() [INFO] [stdout] 80 | | .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] 80 + .is_some_and(|n| n == main_lib_name.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/tvos.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | device_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 208 - device_lib: &PathBuf, [INFO] [stdout] 208 + device_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/tvos.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | simulator_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 209 - simulator_lib: &PathBuf, [INFO] [stdout] 209 + simulator_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/watchos.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - build_dir: &PathBuf, [INFO] [stdout] 46 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/watchos.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | && module_libs[0] [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | .file_name() [INFO] [stdout] 80 | | .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 80 - .map_or(false, |n| n == main_lib_name.as_str()) [INFO] [stdout] 80 + .is_some_and(|n| n == main_lib_name.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/watchos.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | device_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 208 - device_lib: &PathBuf, [INFO] [stdout] 208 + device_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/watchos.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | simulator_lib: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 209 - simulator_lib: &PathBuf, [INFO] [stdout] 209 + simulator_lib: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MSVC` contains a capitalized acronym [INFO] [stdout] --> src/build/platforms/windows.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | MSVC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Msvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/windows.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - build_dir: &PathBuf, [INFO] [stdout] 51 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/platforms/windows.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 109 - if module_libs.len() == 1 && module_libs[0].file_name().map_or(false, |n| n == main_lib_name.as_str()) { [INFO] [stdout] 109 + if module_libs.len() == 1 && module_libs[0].file_name().is_some_and(|n| n == main_lib_name.as_str()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/add.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | ... if tag_info.semver.as_ref().map_or(false, |v| v.is_stable()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 112 - if tag_info.semver.as_ref().map_or(false, |v| v.is_stable()) { [INFO] [stdout] 112 + if tag_info.semver.as_ref().is_some_and(|v| v.is_stable()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/platforms/windows.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 316 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 316 - build_dir: &PathBuf, [INFO] [stdout] 316 + build_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/build/platforms/windows.rs:389:25 [INFO] [stdout] | [INFO] [stdout] 389 | / if name.ends_with(import_ext) { [INFO] [stdout] 390 | | if !libs.iter().any(|p: &PathBuf| p.file_name() == path.file_name()) { [INFO] [stdout] 391 | | libs.push(path); [INFO] [stdout] 392 | | } [INFO] [stdout] 393 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 389 ~ if name.ends_with(import_ext) [INFO] [stdout] 390 ~ && !libs.iter().any(|p: &PathBuf| p.file_name() == path.file_name()) { [INFO] [stdout] 391 | libs.push(path); [INFO] [stdout] 392 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/analytics.rs:264:34 [INFO] [stdout] | [INFO] [stdout] 264 | if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 264 - if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] 264 + if path.is_file() && path.extension().is_some_and(|ext| ext == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:184:34 [INFO] [stdout] | [INFO] [stdout] 184 | fn find_ndk_in_sdk(sdk_path: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 184 - fn find_ndk_in_sdk(sdk_path: &PathBuf) -> Option { [INFO] [stdout] 184 + fn find_ndk_in_sdk(sdk_path: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | versions.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 - versions.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 207 + versions.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:212:41 [INFO] [stdout] | [INFO] [stdout] 212 | fn parse_version_from_dirname(path: &PathBuf) -> Option<(u32, u32, u32)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 212 - fn parse_version_from_dirname(path: &PathBuf) -> Option<(u32, u32, u32)> { [INFO] [stdout] 212 + fn parse_version_from_dirname(path: &Path) -> Option<(u32, u32, u32)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:225:27 [INFO] [stdout] | [INFO] [stdout] 225 | fn is_valid_ndk(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 225 - fn is_valid_ndk(path: &PathBuf) -> bool { [INFO] [stdout] 225 + fn is_valid_ndk(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/android_ndk.rs:242:36 [INFO] [stdout] | [INFO] [stdout] 242 | fn parse_ndk_version(ndk_path: &PathBuf) -> Result<(String, (u32, u32, u32))> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - fn parse_ndk_version(ndk_path: &PathBuf) -> Result<(String, (u32, u32, u32))> { [INFO] [stdout] 242 + fn parse_ndk_version(ndk_path: &Path) -> Result<(String, (u32, u32, u32))> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/bench.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | project_root: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 176 - project_root: &PathBuf, [INFO] [stdout] 176 + project_root: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/ohos.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 111 | fn detect_version(sdk_path: &PathBuf) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - fn detect_version(sdk_path: &PathBuf) -> Option { [INFO] [stdout] 111 + fn detect_version(sdk_path: &Path) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/build/toolchains/ohos.rs:145:41 [INFO] [stdout] | [INFO] [stdout] 145 | if let Some(version_part) = name_str.split('-').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 145 - if let Some(version_part) = name_str.split('-').last() { [INFO] [stdout] 145 + if let Some(version_part) = name_str.split('-').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IOS` contains a capitalized acronym [INFO] [stdout] --> src/build/toolchains/xcode.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | IOS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ios` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/build/toolchains/xcode.rs:293:16 [INFO] [stdout] | [INFO] [stdout] 293 | if lib.extension().map_or(false, |e| e == "framework") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 293 - if lib.extension().map_or(false, |e| e == "framework") { [INFO] [stdout] 293 + if lib.extension().is_some_and(|e| e == "framework") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/mod.rs:56:33 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn is_valid_directory(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - pub fn is_valid_directory(path: &PathBuf) -> bool { [INFO] [stdout] 56 + pub fn is_valid_directory(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/build/toolchains/mod.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn is_valid_file(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - pub fn is_valid_file(path: &PathBuf) -> bool { [INFO] [stdout] 61 + pub fn is_valid_file(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/commands/build.rs:597:5 [INFO] [stdout] | [INFO] [stdout] 597 | / fn print_results( [INFO] [stdout] 598 | | lib_name: &str, [INFO] [stdout] 599 | | version: &str, [INFO] [stdout] 600 | | platform: &str, [INFO] [stdout] ... | [INFO] [stdout] 606 | | jobs: usize, [INFO] [stdout] 607 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/build.rs:670:43 [INFO] [stdout] | [INFO] [stdout] 670 | let archive_type = if archive_path.extension().map_or(false, |e| e == "har") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 670 - let archive_type = if archive_path.extension().map_or(false, |e| e == "har") { [INFO] [stdout] 670 + let archive_type = if archive_path.extension().is_some_and(|e| e == "har") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `version` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:204:27 [INFO] [stdout] | [INFO] [stdout] 203 | if exists && version.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 204 | let ver_str = version.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `version` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:284:27 [INFO] [stdout] | [INFO] [stdout] 283 | if exists && version.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 284 | let ver_str = version.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `android_home` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:311:39 [INFO] [stdout] | [INFO] [stdout] 310 | let sdk_well_formed = if android_home_exists && android_home.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 311 | self.validate_android_sdk(android_home.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `android_home` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:320:41 [INFO] [stdout] | [INFO] [stdout] 318 | if !ndk_home_exists && android_home.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 319 | // Check if NDK is in default location [INFO] [stdout] 320 | let default_ndk = Path::new(android_home.as_ref().unwrap()).join("ndk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `android_home` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:349:46 [INFO] [stdout] | [INFO] [stdout] 348 | let cmdline_tools_exists = if android_home_exists && android_home.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 349 | self.check_android_cmdline_tools(android_home.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ohos_sdk` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:699:40 [INFO] [stdout] | [INFO] [stdout] 698 | if ohos_sdk.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = &ohos_sdk` [INFO] [stdout] 699 | let native_sdk = Path::new(ohos_sdk.as_ref().unwrap()).join("native"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ohos_sdk` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:703:80 [INFO] [stdout] | [INFO] [stdout] 698 | if ohos_sdk.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = ohos_sdk` [INFO] [stdout] ... [INFO] [stdout] 703 | self.print_warning(&format!("OHOS Native SDK not found in {}", ohos_sdk.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/clean.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | / if !self.dry_run && !self.skip_confirm { [INFO] [stdout] 143 | | if !self.confirm_clean(" Remove bin/ directory?") { [INFO] [stdout] 144 | | println!(" ⏭️ Skipped"); [INFO] [stdout] 145 | | return; [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ if !self.dry_run && !self.skip_confirm [INFO] [stdout] 143 ~ && !self.confirm_clean(" Remove bin/ directory?") { [INFO] [stdout] 144 | println!(" ⏭️ Skipped"); [INFO] [stdout] 145 | return; [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/clean.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | / if !self.dry_run && !self.skip_confirm { [INFO] [stdout] 165 | | if !self.confirm_clean(" Remove cmake_build/ directory?") { [INFO] [stdout] 166 | | println!(" ⏭️ Skipped"); [INFO] [stdout] 167 | | return; [INFO] [stdout] 168 | | } [INFO] [stdout] 169 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 164 ~ if !self.dry_run && !self.skip_confirm [INFO] [stdout] 165 ~ && !self.confirm_clean(" Remove cmake_build/ directory?") { [INFO] [stdout] 166 | println!(" ⏭️ Skipped"); [INFO] [stdout] 167 | return; [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/clean.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | / if !self.dry_run && !self.skip_confirm { [INFO] [stdout] 371 | | if !self.confirm_clean("\n⚠️ This will remove ALL build artifacts. Continue?") { [INFO] [stdout] 372 | | println!(" ⏭️ Aborted"); [INFO] [stdout] 373 | | return; [INFO] [stdout] 374 | | } [INFO] [stdout] 375 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 370 ~ if !self.dry_run && !self.skip_confirm [INFO] [stdout] 371 ~ && !self.confirm_clean("\n⚠️ This will remove ALL build artifacts. Continue?") { [INFO] [stdout] 372 | println!(" ⏭️ Aborted"); [INFO] [stdout] 373 | return; [INFO] [stdout] 374 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/add.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | ... if tag_info.semver.as_ref().map_or(false, |v| v.is_stable()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 112 - if tag_info.semver.as_ref().map_or(false, |v| v.is_stable()) { [INFO] [stdout] 112 + if tag_info.semver.as_ref().is_some_and(|v| v.is_stable()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:447:17 [INFO] [stdout] | [INFO] [stdout] 447 | patch.path.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `patch.path.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:448:17 [INFO] [stdout] | [INFO] [stdout] 448 | patch.git.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `patch.git.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:456:17 [INFO] [stdout] | [INFO] [stdout] 456 | dep.path.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `dep.path.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:457:17 [INFO] [stdout] | [INFO] [stdout] 457 | dep.git.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `dep.git.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands/install.rs:563:5 [INFO] [stdout] | [INFO] [stdout] 563 | / fn install_from_git( [INFO] [stdout] 564 | | &self, [INFO] [stdout] 565 | | dep_name: &str, [INFO] [stdout] 566 | | version: &str, [INFO] [stdout] ... | [INFO] [stdout] 571 | | ccgo_home: &Path, [INFO] [stdout] 572 | | ) -> Result { [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:716:19 [INFO] [stdout] | [INFO] [stdout] 716 | .args(&["rev-parse", "--is-inside-work-tree"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--is-inside-work-tree"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:726:19 [INFO] [stdout] | [INFO] [stdout] 726 | .args(&["rev-parse", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:737:19 [INFO] [stdout] | [INFO] [stdout] 737 | .args(&["rev-parse", "--abbrev-ref", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--abbrev-ref", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:748:19 [INFO] [stdout] | [INFO] [stdout] 748 | .args(&["config", "--get", "remote.origin.url"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["config", "--get", "remote.origin.url"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:759:19 [INFO] [stdout] | [INFO] [stdout] 759 | .args(&["status", "--porcelain"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["status", "--porcelain"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/commands/install.rs:990:9 [INFO] [stdout] | [INFO] [stdout] 990 | / directories::BaseDirs::new() [INFO] [stdout] 991 | | .and_then(|dirs| Some(dirs.home_dir().to_path_buf())) [INFO] [stdout] | |_________________________________________________________________^ help: try: `directories::BaseDirs::new().map(|dirs| dirs.home_dir().to_path_buf())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/analytics.rs:264:34 [INFO] [stdout] | [INFO] [stdout] 264 | if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 264 - if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] 264 + if path.is_file() && path.extension().is_some_and(|ext| ext == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/bench.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | project_root: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 176 - project_root: &PathBuf, [INFO] [stdout] 176 + project_root: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/commands/build.rs:597:5 [INFO] [stdout] | [INFO] [stdout] 597 | / fn print_results( [INFO] [stdout] 598 | | lib_name: &str, [INFO] [stdout] 599 | | version: &str, [INFO] [stdout] 600 | | platform: &str, [INFO] [stdout] ... | [INFO] [stdout] 606 | | jobs: usize, [INFO] [stdout] 607 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/build.rs:670:43 [INFO] [stdout] | [INFO] [stdout] 670 | let archive_type = if archive_path.extension().map_or(false, |e| e == "har") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 670 - let archive_type = if archive_path.extension().map_or(false, |e| e == "har") { [INFO] [stdout] 670 + let archive_type = if archive_path.extension().is_some_and(|e| e == "har") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `version` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:204:27 [INFO] [stdout] | [INFO] [stdout] 203 | if exists && version.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 204 | let ver_str = version.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `version` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:284:27 [INFO] [stdout] | [INFO] [stdout] 283 | if exists && version.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 284 | let ver_str = version.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `android_home` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:311:39 [INFO] [stdout] | [INFO] [stdout] 310 | let sdk_well_formed = if android_home_exists && android_home.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 311 | self.validate_android_sdk(android_home.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `android_home` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:320:41 [INFO] [stdout] | [INFO] [stdout] 318 | if !ndk_home_exists && android_home.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 319 | // Check if NDK is in default location [INFO] [stdout] 320 | let default_ndk = Path::new(android_home.as_ref().unwrap()).join("ndk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `android_home` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:349:46 [INFO] [stdout] | [INFO] [stdout] 348 | let cmdline_tools_exists = if android_home_exists && android_home.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 349 | self.check_android_cmdline_tools(android_home.as_ref().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ohos_sdk` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:699:40 [INFO] [stdout] | [INFO] [stdout] 698 | if ohos_sdk.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = &ohos_sdk` [INFO] [stdout] 699 | let native_sdk = Path::new(ohos_sdk.as_ref().unwrap()).join("native"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ohos_sdk` after checking its variant with `is_some` [INFO] [stdout] --> src/commands/check.rs:703:80 [INFO] [stdout] | [INFO] [stdout] 698 | if ohos_sdk.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = ohos_sdk` [INFO] [stdout] ... [INFO] [stdout] 703 | self.print_warning(&format!("OHOS Native SDK not found in {}", ohos_sdk.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/clean.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | / if !self.dry_run && !self.skip_confirm { [INFO] [stdout] 143 | | if !self.confirm_clean(" Remove bin/ directory?") { [INFO] [stdout] 144 | | println!(" ⏭️ Skipped"); [INFO] [stdout] 145 | | return; [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ if !self.dry_run && !self.skip_confirm [INFO] [stdout] 143 ~ && !self.confirm_clean(" Remove bin/ directory?") { [INFO] [stdout] 144 | println!(" ⏭️ Skipped"); [INFO] [stdout] 145 | return; [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/clean.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | / if !self.dry_run && !self.skip_confirm { [INFO] [stdout] 165 | | if !self.confirm_clean(" Remove cmake_build/ directory?") { [INFO] [stdout] 166 | | println!(" ⏭️ Skipped"); [INFO] [stdout] 167 | | return; [INFO] [stdout] 168 | | } [INFO] [stdout] 169 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 164 ~ if !self.dry_run && !self.skip_confirm [INFO] [stdout] 165 ~ && !self.confirm_clean(" Remove cmake_build/ directory?") { [INFO] [stdout] 166 | println!(" ⏭️ Skipped"); [INFO] [stdout] 167 | return; [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/clean.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | / if !self.dry_run && !self.skip_confirm { [INFO] [stdout] 371 | | if !self.confirm_clean("\n⚠️ This will remove ALL build artifacts. Continue?") { [INFO] [stdout] 372 | | println!(" ⏭️ Aborted"); [INFO] [stdout] 373 | | return; [INFO] [stdout] 374 | | } [INFO] [stdout] 375 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 370 ~ if !self.dry_run && !self.skip_confirm [INFO] [stdout] 371 ~ && !self.confirm_clean("\n⚠️ This will remove ALL build artifacts. Continue?") { [INFO] [stdout] 372 | println!(" ⏭️ Aborted"); [INFO] [stdout] 373 | return; [INFO] [stdout] 374 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:447:17 [INFO] [stdout] | [INFO] [stdout] 447 | patch.path.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `patch.path.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:63:35 [INFO] [stdout] | [INFO] [stdout] 63 | eprintln!("✗ {}", "Version required for delete operation"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 - eprintln!("✗ {}", "Version required for delete operation"); [INFO] [stdout] 63 + eprintln!("✗ Version required for delete operation"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:448:17 [INFO] [stdout] | [INFO] [stdout] 448 | patch.git.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `patch.git.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:456:17 [INFO] [stdout] | [INFO] [stdout] 456 | dep.path.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `dep.path.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|s| s.as_str())` on an `Option` value [INFO] [stdout] --> src/commands/install.rs:457:17 [INFO] [stdout] | [INFO] [stdout] 457 | dep.git.as_ref().map(|s| s.as_str()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `dep.git.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 76 | eprintln!("=== {} ===", "Creating Git tag"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 - eprintln!("=== {} ===", "Creating Git tag"); [INFO] [stdout] 76 + eprintln!("=== Creating Git tag ==="); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:132:27 [INFO] [stdout] | [INFO] [stdout] 132 | .args(&["tag", "-d", &tag_version]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", "-d", &tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 142 | cmd.args(&["tag", &tag_version]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", &tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 152 | cmd.args(&["tag", "-a", &tag_version, "-m", &tag_message]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", "-a", &tag_version, "-m", &tag_message]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:177:19 [INFO] [stdout] | [INFO] [stdout] 177 | .args(&["show", &tag_version, "--no-patch"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["show", &tag_version, "--no-patch"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:189:29 [INFO] [stdout] | [INFO] [stdout] 189 | eprintln!("{}", "Pushing tag to remote..."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 189 - eprintln!("{}", "Pushing tag to remote..."); [INFO] [stdout] 189 + eprintln!("Pushing tag to remote..."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 191 | push_cmd.args(&["push", "origin", &tag_version]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["push", "origin", &tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:203:39 [INFO] [stdout] | [INFO] [stdout] 203 | eprintln!("⚠ {}", "Failed to push tag to remote"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 203 - eprintln!("⚠ {}", "Failed to push tag to remote"); [INFO] [stdout] 203 + eprintln!("⚠ Failed to push tag to remote"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands/install.rs:563:5 [INFO] [stdout] | [INFO] [stdout] 563 | / fn install_from_git( [INFO] [stdout] 564 | | &self, [INFO] [stdout] 565 | | dep_name: &str, [INFO] [stdout] 566 | | version: &str, [INFO] [stdout] ... | [INFO] [stdout] 571 | | ccgo_home: &Path, [INFO] [stdout] 572 | | ) -> Result { [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:215:27 [INFO] [stdout] | [INFO] [stdout] 215 | eprintln!("✓ {}", "Tag operation completed successfully!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 215 - eprintln!("✓ {}", "Tag operation completed successfully!"); [INFO] [stdout] 215 + eprintln!("✓ Tag operation completed successfully!"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:231:19 [INFO] [stdout] | [INFO] [stdout] 231 | .args(&["tag", "-d", tag_version]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", "-d", tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:250:23 [INFO] [stdout] | [INFO] [stdout] 250 | .args(&["push", "origin", "--delete", tag_version]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["push", "origin", "--delete", tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:259:39 [INFO] [stdout] | [INFO] [stdout] 259 | eprintln!("⚠ {}", "Failed to delete remote tag (may not exist)"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 259 - eprintln!("⚠ {}", "Failed to delete remote tag (may not exist)"); [INFO] [stdout] 259 + eprintln!("⚠ Failed to delete remote tag (may not exist)"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 264 | eprintln!("✓ {}", "Tag deletion completed"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 264 - eprintln!("✓ {}", "Tag deletion completed"); [INFO] [stdout] 264 + eprintln!("✓ Tag deletion completed"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:274:37 [INFO] [stdout] | [INFO] [stdout] 274 | eprintln!("=== {} ===", "Remote tags"); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 274 - eprintln!("=== {} ===", "Remote tags"); [INFO] [stdout] 274 + eprintln!("=== Remote tags ==="); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:277:23 [INFO] [stdout] | [INFO] [stdout] 277 | .args(&["ls-remote", "--tags", "origin"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["ls-remote", "--tags", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:302:37 [INFO] [stdout] | [INFO] [stdout] 302 | eprintln!("=== {} ===", "Local tags"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 302 - eprintln!("=== {} ===", "Local tags"); [INFO] [stdout] 302 + eprintln!("=== Local tags ==="); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:716:19 [INFO] [stdout] | [INFO] [stdout] 716 | .args(&["rev-parse", "--is-inside-work-tree"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--is-inside-work-tree"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:726:19 [INFO] [stdout] | [INFO] [stdout] 726 | .args(&["rev-parse", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:737:19 [INFO] [stdout] | [INFO] [stdout] 737 | .args(&["rev-parse", "--abbrev-ref", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--abbrev-ref", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:305:23 [INFO] [stdout] | [INFO] [stdout] 305 | .args(&["tag", "-l"]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `["tag", "-l"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:748:19 [INFO] [stdout] | [INFO] [stdout] 748 | .args(&["config", "--get", "remote.origin.url"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["config", "--get", "remote.origin.url"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/install.rs:759:19 [INFO] [stdout] | [INFO] [stdout] 759 | .args(&["status", "--porcelain"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["status", "--porcelain"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:345:15 [INFO] [stdout] | [INFO] [stdout] 345 | .args(&["symbolic-ref", "--short", "-q", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["symbolic-ref", "--short", "-q", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:360:15 [INFO] [stdout] | [INFO] [stdout] 360 | .args(&["rev-list", "HEAD", "--count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-list", "HEAD", "--count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:375:15 [INFO] [stdout] | [INFO] [stdout] 375 | .args(&["rev-parse", "--short", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--short", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 390 | .args(&["log", "-n1", "--format=%at"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["log", "-n1", "--format=%at"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:426:15 [INFO] [stdout] | [INFO] [stdout] 426 | .args(&["rev-parse", tag]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", tag]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/commands/install.rs:990:9 [INFO] [stdout] | [INFO] [stdout] 990 | / directories::BaseDirs::new() [INFO] [stdout] 991 | | .and_then(|dirs| Some(dirs.home_dir().to_path_buf())) [INFO] [stdout] | |_________________________________________________________________^ help: try: `directories::BaseDirs::new().map(|dirs| dirs.home_dir().to_path_buf())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:206:37 [INFO] [stdout] | [INFO] [stdout] 206 | fn list_tests(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 206 ~ fn list_tests(&self, build_dir: &Path, verbose: bool) -> Result<()> { [INFO] [stdout] 207 ~ let discovery = TestDiscovery::new(build_dir.to_path_buf(), verbose); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:230:44 [INFO] [stdout] | [INFO] [stdout] 230 | fn aggregate_results(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 230 - fn aggregate_results(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] 230 + fn aggregate_results(&self, build_dir: &Path, verbose: bool) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:251:39 [INFO] [stdout] | [INFO] [stdout] 251 | fn report_to_ci(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 251 - fn report_to_ci(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] 251 + fn report_to_ci(&self, build_dir: &Path, verbose: bool) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:278:23 [INFO] [stdout] | [INFO] [stdout] 278 | project_root: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 278 ~ project_root: &Path, [INFO] [stdout] 279 | build_dir: &PathBuf, [INFO] [stdout] ... [INFO] [stdout] 284 | let config = CoverageConfig { [INFO] [stdout] 285 ~ source_dir: project_root.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:279:20 [INFO] [stdout] | [INFO] [stdout] 279 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 279 ~ build_dir: &Path, [INFO] [stdout] 280 | verbose: bool, [INFO] [stdout] ... [INFO] [stdout] 285 | source_dir: project_root.clone(), [INFO] [stdout] 286 ~ build_dir: build_dir.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands/tree.rs:396:5 [INFO] [stdout] | [INFO] [stdout] 396 | / fn print_dependency( [INFO] [stdout] 397 | | &self, [INFO] [stdout] 398 | | dep: &DependencyConfig, [INFO] [stdout] 399 | | prefix: &str, [INFO] [stdout] ... | [INFO] [stdout] 404 | | project_dir: &Path, [INFO] [stdout] 405 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/tree.rs:881:9 [INFO] [stdout] | [INFO] [stdout] 881 | duplicates.sort_by(|a, b| b.1.cmp(&a.1)); // Sort by count descending [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 881 - duplicates.sort_by(|a, b| b.1.cmp(&a.1)); // Sort by count descending [INFO] [stdout] 881 + duplicates.sort_by_key(|b| std::cmp::Reverse(b.1)); // Sort by count descending [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/update.rs:180:19 [INFO] [stdout] | [INFO] [stdout] 180 | .args(&["fetch", "origin"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["fetch", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/update.rs:257:19 [INFO] [stdout] | [INFO] [stdout] 257 | .args(&["rev-parse", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/update.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | .args(&["rev-parse", &format!("origin/{}", branch)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", &format!("origin/{}", branch)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/commands/vendor.rs:644:9 [INFO] [stdout] | [INFO] [stdout] 644 | / directories::BaseDirs::new() [INFO] [stdout] 645 | | .and_then(|dirs| Some(dirs.home_dir().to_path_buf())) [INFO] [stdout] | |_________________________________________________________________^ help: try: `directories::BaseDirs::new().map(|dirs| dirs.home_dir().to_path_buf())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:63:35 [INFO] [stdout] | [INFO] [stdout] 63 | eprintln!("✗ {}", "Version required for delete operation"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 - eprintln!("✗ {}", "Version required for delete operation"); [INFO] [stdout] 63 + eprintln!("✗ Version required for delete operation"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 76 | eprintln!("=== {} ===", "Creating Git tag"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 - eprintln!("=== {} ===", "Creating Git tag"); [INFO] [stdout] 76 + eprintln!("=== Creating Git tag ==="); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:132:27 [INFO] [stdout] | [INFO] [stdout] 132 | .args(&["tag", "-d", &tag_version]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", "-d", &tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 142 | cmd.args(&["tag", &tag_version]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", &tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 152 | cmd.args(&["tag", "-a", &tag_version, "-m", &tag_message]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", "-a", &tag_version, "-m", &tag_message]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:177:19 [INFO] [stdout] | [INFO] [stdout] 177 | .args(&["show", &tag_version, "--no-patch"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["show", &tag_version, "--no-patch"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:189:29 [INFO] [stdout] | [INFO] [stdout] 189 | eprintln!("{}", "Pushing tag to remote..."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 189 - eprintln!("{}", "Pushing tag to remote..."); [INFO] [stdout] 189 + eprintln!("Pushing tag to remote..."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 191 | push_cmd.args(&["push", "origin", &tag_version]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["push", "origin", &tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:203:39 [INFO] [stdout] | [INFO] [stdout] 203 | eprintln!("⚠ {}", "Failed to push tag to remote"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 203 - eprintln!("⚠ {}", "Failed to push tag to remote"); [INFO] [stdout] 203 + eprintln!("⚠ Failed to push tag to remote"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:215:27 [INFO] [stdout] | [INFO] [stdout] 215 | eprintln!("✓ {}", "Tag operation completed successfully!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 215 - eprintln!("✓ {}", "Tag operation completed successfully!"); [INFO] [stdout] 215 + eprintln!("✓ Tag operation completed successfully!"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:231:19 [INFO] [stdout] | [INFO] [stdout] 231 | .args(&["tag", "-d", tag_version]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["tag", "-d", tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:250:23 [INFO] [stdout] | [INFO] [stdout] 250 | .args(&["push", "origin", "--delete", tag_version]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["push", "origin", "--delete", tag_version]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:259:39 [INFO] [stdout] | [INFO] [stdout] 259 | eprintln!("⚠ {}", "Failed to delete remote tag (may not exist)"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 259 - eprintln!("⚠ {}", "Failed to delete remote tag (may not exist)"); [INFO] [stdout] 259 + eprintln!("⚠ Failed to delete remote tag (may not exist)"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 264 | eprintln!("✓ {}", "Tag deletion completed"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 264 - eprintln!("✓ {}", "Tag deletion completed"); [INFO] [stdout] 264 + eprintln!("✓ Tag deletion completed"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:274:37 [INFO] [stdout] | [INFO] [stdout] 274 | eprintln!("=== {} ===", "Remote tags"); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 274 - eprintln!("=== {} ===", "Remote tags"); [INFO] [stdout] 274 + eprintln!("=== Remote tags ==="); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:277:23 [INFO] [stdout] | [INFO] [stdout] 277 | .args(&["ls-remote", "--tags", "origin"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["ls-remote", "--tags", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/tag.rs:302:37 [INFO] [stdout] | [INFO] [stdout] 302 | eprintln!("=== {} ===", "Local tags"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 302 - eprintln!("=== {} ===", "Local tags"); [INFO] [stdout] 302 + eprintln!("=== Local tags ==="); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:305:23 [INFO] [stdout] | [INFO] [stdout] 305 | .args(&["tag", "-l"]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `["tag", "-l"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:345:15 [INFO] [stdout] | [INFO] [stdout] 345 | .args(&["symbolic-ref", "--short", "-q", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["symbolic-ref", "--short", "-q", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:360:15 [INFO] [stdout] | [INFO] [stdout] 360 | .args(&["rev-list", "HEAD", "--count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-list", "HEAD", "--count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:375:15 [INFO] [stdout] | [INFO] [stdout] 375 | .args(&["rev-parse", "--short", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--short", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 390 | .args(&["log", "-n1", "--format=%at"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["log", "-n1", "--format=%at"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/tag.rs:426:15 [INFO] [stdout] | [INFO] [stdout] 426 | .args(&["rev-parse", tag]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", tag]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:206:37 [INFO] [stdout] | [INFO] [stdout] 206 | fn list_tests(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 206 ~ fn list_tests(&self, build_dir: &Path, verbose: bool) -> Result<()> { [INFO] [stdout] 207 ~ let discovery = TestDiscovery::new(build_dir.to_path_buf(), verbose); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:230:44 [INFO] [stdout] | [INFO] [stdout] 230 | fn aggregate_results(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 230 - fn aggregate_results(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] 230 + fn aggregate_results(&self, build_dir: &Path, verbose: bool) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:251:39 [INFO] [stdout] | [INFO] [stdout] 251 | fn report_to_ci(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 251 - fn report_to_ci(&self, build_dir: &PathBuf, verbose: bool) -> Result<()> { [INFO] [stdout] 251 + fn report_to_ci(&self, build_dir: &Path, verbose: bool) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:278:23 [INFO] [stdout] | [INFO] [stdout] 278 | project_root: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 278 ~ project_root: &Path, [INFO] [stdout] 279 | build_dir: &PathBuf, [INFO] [stdout] ... [INFO] [stdout] 284 | let config = CoverageConfig { [INFO] [stdout] 285 ~ source_dir: project_root.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/test.rs:279:20 [INFO] [stdout] | [INFO] [stdout] 279 | build_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 279 ~ build_dir: &Path, [INFO] [stdout] 280 | verbose: bool, [INFO] [stdout] ... [INFO] [stdout] 285 | source_dir: project_root.clone(), [INFO] [stdout] 286 ~ build_dir: build_dir.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/dependency/graph.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/dependency/graph.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | indent: usize, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_indent` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/dependency/graph.rs:307:21 [INFO] [stdout] | [INFO] [stdout] 307 | indent, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/dependency/graph.rs:318:28 [INFO] [stdout] | [INFO] [stdout] 318 | let shared_count = if total_count > unique_count { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 319 | | total_count - unique_count [INFO] [stdout] 320 | | } else { [INFO] [stdout] 321 | | 0 [INFO] [stdout] 322 | | }; [INFO] [stdout] | |_________^ help: replace it with: `total_count.saturating_sub(unique_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/dependency/resolver.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / if !existing_version.is_empty() && !dep.version.is_empty() { [INFO] [stdout] 136 | | if existing_version != &dep.version { [INFO] [stdout] 137 | | // Try to parse versions and check compatibility [INFO] [stdout] 138 | | let existing_req = VersionRequirement::parse(existing_version); [INFO] [stdout] ... | [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if !existing_version.is_empty() && !dep.version.is_empty() [INFO] [stdout] 136 ~ && existing_version != &dep.version { [INFO] [stdout] 137 | // Try to parse versions and check compatibility [INFO] [stdout] ... [INFO] [stdout] 148 | } [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dep.git` after checking its variant with `is_some` [INFO] [stdout] --> src/dependency/resolver.rs:230:57 [INFO] [stdout] | [INFO] [stdout] 228 | } else if dep.git.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &dep.git` [INFO] [stdout] 229 | // Git dependency - should be in global cache [INFO] [stdout] 230 | let hash_input = format!("{}:{}", dep.name, dep.git.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands/tree.rs:396:5 [INFO] [stdout] | [INFO] [stdout] 396 | / fn print_dependency( [INFO] [stdout] 397 | | &self, [INFO] [stdout] 398 | | dep: &DependencyConfig, [INFO] [stdout] 399 | | prefix: &str, [INFO] [stdout] ... | [INFO] [stdout] 404 | | project_dir: &Path, [INFO] [stdout] 405 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/dependency/version_resolver.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 86 | / let candidates = match (self, other) { [INFO] [stdout] 87 | | (Self::Exact(v), _) if other.matches(v) => return Some(v.clone()), [INFO] [stdout] 88 | | (_, Self::Exact(v)) if self.matches(v) => return Some(v.clone()), [INFO] [stdout] 89 | | (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] ... | [INFO] [stdout] 99 | | _ => None, [INFO] [stdout] 100 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 101 | [INFO] [stdout] 102 | candidates [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 | [INFO] [stdout] 88 ~ match (self, other) { [INFO] [stdout] 89 + (Self::Exact(v), _) if other.matches(v) => return Some(v.clone()), [INFO] [stdout] 90 + (_, Self::Exact(v)) if self.matches(v) => return Some(v.clone()), [INFO] [stdout] 91 + (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] 92 + // Try common versions [INFO] [stdout] 93 + let test_versions = vec![ [INFO] [stdout] 94 + "1.0.0", "1.1.0", "1.2.0", "2.0.0", "2.1.0", "3.0.0", [INFO] [stdout] 95 + ]; [INFO] [stdout] 96 + test_versions [INFO] [stdout] 97 + .into_iter() [INFO] [stdout] 98 + .filter_map(|v| Version::parse(v).ok()) [INFO] [stdout] 99 + .find(|v| req1.matches(v) && req2.matches(v)) [INFO] [stdout] 100 + } [INFO] [stdout] 101 + _ => None, [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/tree.rs:881:9 [INFO] [stdout] | [INFO] [stdout] 881 | duplicates.sort_by(|a, b| b.1.cmp(&a.1)); // Sort by count descending [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 881 - duplicates.sort_by(|a, b| b.1.cmp(&a.1)); // Sort by count descending [INFO] [stdout] 881 + duplicates.sort_by_key(|b| std::cmp::Reverse(b.1)); // Sort by count descending [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/update.rs:180:19 [INFO] [stdout] | [INFO] [stdout] 180 | .args(&["fetch", "origin"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["fetch", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/update.rs:257:19 [INFO] [stdout] | [INFO] [stdout] 257 | .args(&["rev-parse", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/update.rs:272:19 [INFO] [stdout] | [INFO] [stdout] 272 | .args(&["rev-parse", &format!("origin/{}", branch)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", &format!("origin/{}", branch)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/commands/vendor.rs:644:9 [INFO] [stdout] | [INFO] [stdout] 644 | / directories::BaseDirs::new() [INFO] [stdout] 645 | | .and_then(|dirs| Some(dirs.home_dir().to_path_buf())) [INFO] [stdout] | |_________________________________________________________________^ help: try: `directories::BaseDirs::new().map(|dirs| dirs.home_dir().to_path_buf())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/index.rs:488:33 [INFO] [stdout] | [INFO] [stdout] 488 | if path.is_dir() && path.file_name().map_or(false, |n| n.len() == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 488 - if path.is_dir() && path.file_name().map_or(false, |n| n.len() == 1) { [INFO] [stdout] 488 + if path.is_dir() && path.file_name().is_some_and(|n| n.len() == 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/index.rs:494:24 [INFO] [stdout] | [INFO] [stdout] 494 | if file_path.extension().map_or(false, |e| e == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 494 - if file_path.extension().map_or(false, |e| e == "json") { [INFO] [stdout] 494 + if file_path.extension().is_some_and(|e| e == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/registry/shorthand.rs:283:105 [INFO] [stdout] | [INFO] [stdout] 283 | if reference.starts_with('v') || reference.chars().next().map_or(false, |c| c.is_numeric()) { [INFO] [stdout] | _________________________________________________________________________________________________________^ [INFO] [stdout] 284 | | entry.push_str(&format!("\nbranch = \"{}\"", reference)); [INFO] [stdout] 285 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/registry/shorthand.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 285 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 286 | | entry.push_str(&format!("\nbranch = \"{}\"", reference)); [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/shorthand.rs:283:46 [INFO] [stdout] | [INFO] [stdout] 283 | if reference.starts_with('v') || reference.chars().next().map_or(false, |c| c.is_numeric()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 283 - if reference.starts_with('v') || reference.chars().next().map_or(false, |c| c.is_numeric()) { [INFO] [stdout] 283 + if reference.starts_with('v') || reference.chars().next().is_some_and(|c| c.is_numeric()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/version_discovery.rs:190:23 [INFO] [stdout] | [INFO] [stdout] 190 | .find(|t| t.semver.as_ref().map_or(false, |v| v.is_stable()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 190 - .find(|t| t.semver.as_ref().map_or(false, |v| v.is_stable()))) [INFO] [stdout] 190 + .find(|t| t.semver.as_ref().is_some_and(|v| v.is_stable()))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:572:41 [INFO] [stdout] | [INFO] [stdout] 572 | path: PathBuf::from(&line[3..]), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:566:13 [INFO] [stdout] | [INFO] [stdout] 566 | if line.starts_with("SF:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 566 ~ if let Some() = line.strip_prefix("SF:") { [INFO] [stdout] 567 | // New source file [INFO] [stdout] ... [INFO] [stdout] 571 | current_file = Some(FileCoverage { [INFO] [stdout] 572 ~ path: PathBuf::from(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:584:44 [INFO] [stdout] | [INFO] [stdout] 584 | let parts: Vec<&str> = line[3..].split(',').collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:581:20 [INFO] [stdout] | [INFO] [stdout] 581 | } else if line.starts_with("DA:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 581 ~ } else if let Some() = line.strip_prefix("DA:") { [INFO] [stdout] 582 | // Line data: DA:line,hits [INFO] [stdout] 583 | if let Some(ref mut file) = current_file { [INFO] [stdout] 584 ~ let parts: Vec<&str> = .split(',').collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:608:40 [INFO] [stdout] | [INFO] [stdout] 608 | if let Ok(count) = line[4..].parse::() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:605:20 [INFO] [stdout] | [INFO] [stdout] 605 | } else if line.starts_with("FNF:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 605 ~ } else if let Some() = line.strip_prefix("FNF:") { [INFO] [stdout] 606 | // Function count [INFO] [stdout] 607 | if let Some(ref mut file) = current_file { [INFO] [stdout] 608 ~ if let Ok(count) = .parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:615:40 [INFO] [stdout] | [INFO] [stdout] 615 | if let Ok(count) = line[4..].parse::() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:612:20 [INFO] [stdout] | [INFO] [stdout] 612 | } else if line.starts_with("FNH:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 612 ~ } else if let Some() = line.strip_prefix("FNH:") { [INFO] [stdout] 613 | // Functions hit [INFO] [stdout] 614 | if let Some(ref mut file) = current_file { [INFO] [stdout] 615 ~ if let Ok(count) = .parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/testing/discovery.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | / if file_name.contains("test") [INFO] [stdout] 130 | | || file_name.contains("Test") [INFO] [stdout] 131 | | || file_name.contains("_googletest") [INFO] [stdout] 132 | | || file_name.contains("_catch2") [INFO] [stdout] ... | [INFO] [stdout] 137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 129 ~ if (file_name.contains("test") [INFO] [stdout] 130 | || file_name.contains("Test") [INFO] [stdout] 131 | || file_name.contains("_googletest") [INFO] [stdout] 132 ~ || file_name.contains("_catch2") [INFO] [stdout] 133 ~ || file_name.contains("_catch2")) [INFO] [stdout] 134 | { [INFO] [stdout] 135 ~ && self.is_executable(&path) { [INFO] [stdout] 136 | executables.push(path); [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/dependency/graph.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/dependency/graph.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | indent: usize, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_indent` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/dependency/graph.rs:307:21 [INFO] [stdout] | [INFO] [stdout] 307 | indent, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/dependency/graph.rs:318:28 [INFO] [stdout] | [INFO] [stdout] 318 | let shared_count = if total_count > unique_count { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 319 | | total_count - unique_count [INFO] [stdout] 320 | | } else { [INFO] [stdout] 321 | | 0 [INFO] [stdout] 322 | | }; [INFO] [stdout] | |_________^ help: replace it with: `total_count.saturating_sub(unique_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/dependency/resolver.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / if !existing_version.is_empty() && !dep.version.is_empty() { [INFO] [stdout] 136 | | if existing_version != &dep.version { [INFO] [stdout] 137 | | // Try to parse versions and check compatibility [INFO] [stdout] 138 | | let existing_req = VersionRequirement::parse(existing_version); [INFO] [stdout] ... | [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if !existing_version.is_empty() && !dep.version.is_empty() [INFO] [stdout] 136 ~ && existing_version != &dep.version { [INFO] [stdout] 137 | // Try to parse versions and check compatibility [INFO] [stdout] ... [INFO] [stdout] 148 | } [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dep.git` after checking its variant with `is_some` [INFO] [stdout] --> src/dependency/resolver.rs:230:57 [INFO] [stdout] | [INFO] [stdout] 228 | } else if dep.git.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &dep.git` [INFO] [stdout] 229 | // Git dependency - should be in global cache [INFO] [stdout] 230 | let hash_input = format!("{}:{}", dep.name, dep.git.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/dependency/version_resolver.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 86 | / let candidates = match (self, other) { [INFO] [stdout] 87 | | (Self::Exact(v), _) if other.matches(v) => return Some(v.clone()), [INFO] [stdout] 88 | | (_, Self::Exact(v)) if self.matches(v) => return Some(v.clone()), [INFO] [stdout] 89 | | (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] ... | [INFO] [stdout] 99 | | _ => None, [INFO] [stdout] 100 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 101 | [INFO] [stdout] 102 | candidates [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 | [INFO] [stdout] 88 ~ match (self, other) { [INFO] [stdout] 89 + (Self::Exact(v), _) if other.matches(v) => return Some(v.clone()), [INFO] [stdout] 90 + (_, Self::Exact(v)) if self.matches(v) => return Some(v.clone()), [INFO] [stdout] 91 + (Self::Range(req1), Self::Range(req2)) => { [INFO] [stdout] 92 + // Try common versions [INFO] [stdout] 93 + let test_versions = vec![ [INFO] [stdout] 94 + "1.0.0", "1.1.0", "1.2.0", "2.0.0", "2.1.0", "3.0.0", [INFO] [stdout] 95 + ]; [INFO] [stdout] 96 + test_versions [INFO] [stdout] 97 + .into_iter() [INFO] [stdout] 98 + .filter_map(|v| Version::parse(v).ok()) [INFO] [stdout] 99 + .find(|v| req1.matches(v) && req2.matches(v)) [INFO] [stdout] 100 + } [INFO] [stdout] 101 + _ => None, [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/testing/benchmark.rs:314:22 [INFO] [stdout] | [INFO] [stdout] 314 | md.push_str(&format!("| Metric | Count |\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"| Metric | Count |\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/testing/benchmark.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | md.push_str(&format!("|--------|-------|\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"|--------|-------|\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 65 | .args(&["rev-parse", "--abbrev-ref", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--abbrev-ref", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | .args(&["rev-parse", "--short", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--short", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | .args(&["status", "--porcelain"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["status", "--porcelain"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 114 | .args(&["describe", "--tags", "--abbrev=0"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["describe", "--tags", "--abbrev=0"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:131:15 [INFO] [stdout] | [INFO] [stdout] 131 | .args(&["rev-list", &format!("{}..HEAD", latest_tag), "--count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-list", &format!("{}..HEAD", latest_tag), "--count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:147:15 [INFO] [stdout] | [INFO] [stdout] 147 | .args(&["rev-list", "HEAD", "--count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-list", "HEAD", "--count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/workspace/resolver.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | / if other_member.name != member.name { [INFO] [stdout] 159 | | if self.depends_on_member(member, &other_member.name)? { [INFO] [stdout] 160 | | self.visit_member(other_member, visited, visiting, order)?; [INFO] [stdout] 161 | | } [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ if other_member.name != member.name [INFO] [stdout] 159 ~ && self.depends_on_member(member, &other_member.name)? { [INFO] [stdout] 160 | self.visit_member(other_member, visited, visiting, order)?; [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/index.rs:488:33 [INFO] [stdout] | [INFO] [stdout] 488 | if path.is_dir() && path.file_name().map_or(false, |n| n.len() == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 488 - if path.is_dir() && path.file_name().map_or(false, |n| n.len() == 1) { [INFO] [stdout] 488 + if path.is_dir() && path.file_name().is_some_and(|n| n.len() == 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/index.rs:494:24 [INFO] [stdout] | [INFO] [stdout] 494 | if file_path.extension().map_or(false, |e| e == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 494 - if file_path.extension().map_or(false, |e| e == "json") { [INFO] [stdout] 494 + if file_path.extension().is_some_and(|e| e == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/build/platforms/mod.rs:248:25 [INFO] [stdout] | [INFO] [stdout] 248 | let all_platforms = vec![ [INFO] [stdout] | _________________________^ [INFO] [stdout] 249 | | BuildTarget::Linux, [INFO] [stdout] 250 | | BuildTarget::Windows, [INFO] [stdout] 251 | | BuildTarget::Ohos, [INFO] [stdout] ... | [INFO] [stdout] 256 | | BuildTarget::Android, [INFO] [stdout] 257 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 248 ~ let all_platforms = [BuildTarget::Linux, [INFO] [stdout] 249 + BuildTarget::Windows, [INFO] [stdout] 250 + BuildTarget::Ohos, [INFO] [stdout] 251 + BuildTarget::Ios, [INFO] [stdout] 252 + BuildTarget::Macos, [INFO] [stdout] 253 + BuildTarget::Tvos, [INFO] [stdout] 254 + BuildTarget::Watchos, [INFO] [stdout] 255 ~ BuildTarget::Android]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/build/platforms/mod.rs:542:21 [INFO] [stdout] | [INFO] [stdout] 542 | let platforms = vec![ [INFO] [stdout] | _____________________^ [INFO] [stdout] 543 | | BuildTarget::Ios, [INFO] [stdout] 544 | | BuildTarget::Macos, [INFO] [stdout] 545 | | BuildTarget::Tvos, [INFO] [stdout] 546 | | BuildTarget::Watchos, [INFO] [stdout] 547 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 542 ~ let platforms = [BuildTarget::Ios, [INFO] [stdout] 543 + BuildTarget::Macos, [INFO] [stdout] 544 + BuildTarget::Tvos, [INFO] [stdout] 545 ~ BuildTarget::Watchos]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/registry/shorthand.rs:283:105 [INFO] [stdout] | [INFO] [stdout] 283 | if reference.starts_with('v') || reference.chars().next().map_or(false, |c| c.is_numeric()) { [INFO] [stdout] | _________________________________________________________________________________________________________^ [INFO] [stdout] 284 | | entry.push_str(&format!("\nbranch = \"{}\"", reference)); [INFO] [stdout] 285 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/registry/shorthand.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 285 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 286 | | entry.push_str(&format!("\nbranch = \"{}\"", reference)); [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/shorthand.rs:283:46 [INFO] [stdout] | [INFO] [stdout] 283 | if reference.starts_with('v') || reference.chars().next().map_or(false, |c| c.is_numeric()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 283 - if reference.starts_with('v') || reference.chars().next().map_or(false, |c| c.is_numeric()) { [INFO] [stdout] 283 + if reference.starts_with('v') || reference.chars().next().is_some_and(|c| c.is_numeric()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/registry/version_discovery.rs:190:23 [INFO] [stdout] | [INFO] [stdout] 190 | .find(|t| t.semver.as_ref().map_or(false, |v| v.is_stable()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 190 - .find(|t| t.semver.as_ref().map_or(false, |v| v.is_stable()))) [INFO] [stdout] 190 + .find(|t| t.semver.as_ref().is_some_and(|v| v.is_stable()))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:572:41 [INFO] [stdout] | [INFO] [stdout] 572 | path: PathBuf::from(&line[3..]), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:566:13 [INFO] [stdout] | [INFO] [stdout] 566 | if line.starts_with("SF:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 566 ~ if let Some() = line.strip_prefix("SF:") { [INFO] [stdout] 567 | // New source file [INFO] [stdout] ... [INFO] [stdout] 571 | current_file = Some(FileCoverage { [INFO] [stdout] 572 ~ path: PathBuf::from(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:584:44 [INFO] [stdout] | [INFO] [stdout] 584 | let parts: Vec<&str> = line[3..].split(',').collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:581:20 [INFO] [stdout] | [INFO] [stdout] 581 | } else if line.starts_with("DA:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 581 ~ } else if let Some() = line.strip_prefix("DA:") { [INFO] [stdout] 582 | // Line data: DA:line,hits [INFO] [stdout] 583 | if let Some(ref mut file) = current_file { [INFO] [stdout] 584 ~ let parts: Vec<&str> = .split(',').collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:608:40 [INFO] [stdout] | [INFO] [stdout] 608 | if let Ok(count) = line[4..].parse::() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:605:20 [INFO] [stdout] | [INFO] [stdout] 605 | } else if line.starts_with("FNF:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 605 ~ } else if let Some() = line.strip_prefix("FNF:") { [INFO] [stdout] 606 | // Function count [INFO] [stdout] 607 | if let Some(ref mut file) = current_file { [INFO] [stdout] 608 ~ if let Ok(count) = .parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/testing/coverage.rs:615:40 [INFO] [stdout] | [INFO] [stdout] 615 | if let Ok(count) = line[4..].parse::() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/testing/coverage.rs:612:20 [INFO] [stdout] | [INFO] [stdout] 612 | } else if line.starts_with("FNH:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 612 ~ } else if let Some() = line.strip_prefix("FNH:") { [INFO] [stdout] 613 | // Functions hit [INFO] [stdout] 614 | if let Some(ref mut file) = current_file { [INFO] [stdout] 615 ~ if let Ok(count) = .parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/testing/discovery.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | / if file_name.contains("test") [INFO] [stdout] 130 | | || file_name.contains("Test") [INFO] [stdout] 131 | | || file_name.contains("_googletest") [INFO] [stdout] 132 | | || file_name.contains("_catch2") [INFO] [stdout] ... | [INFO] [stdout] 137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 129 ~ if (file_name.contains("test") [INFO] [stdout] 130 | || file_name.contains("Test") [INFO] [stdout] 131 | || file_name.contains("_googletest") [INFO] [stdout] 132 ~ || file_name.contains("_catch2") [INFO] [stdout] 133 ~ || file_name.contains("_catch2")) [INFO] [stdout] 134 | { [INFO] [stdout] 135 ~ && self.is_executable(&path) { [INFO] [stdout] 136 | executables.push(path); [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/testing/benchmark.rs:314:22 [INFO] [stdout] | [INFO] [stdout] 314 | md.push_str(&format!("| Metric | Count |\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"| Metric | Count |\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/testing/benchmark.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | md.push_str(&format!("|--------|-------|\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"|--------|-------|\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 65 | .args(&["rev-parse", "--abbrev-ref", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--abbrev-ref", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | .args(&["rev-parse", "--short", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--short", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | .args(&["status", "--porcelain"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["status", "--porcelain"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 114 | .args(&["describe", "--tags", "--abbrev=0"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["describe", "--tags", "--abbrev=0"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:131:15 [INFO] [stdout] | [INFO] [stdout] 131 | .args(&["rev-list", &format!("{}..HEAD", latest_tag), "--count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-list", &format!("{}..HEAD", latest_tag), "--count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/git_version.rs:147:15 [INFO] [stdout] | [INFO] [stdout] 147 | .args(&["rev-list", "HEAD", "--count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-list", "HEAD", "--count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/workspace/resolver.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | / if other_member.name != member.name { [INFO] [stdout] 159 | | if self.depends_on_member(member, &other_member.name)? { [INFO] [stdout] 160 | | self.visit_member(other_member, visited, visiting, order)?; [INFO] [stdout] 161 | | } [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ if other_member.name != member.name [INFO] [stdout] 159 ~ && self.depends_on_member(member, &other_member.name)? { [INFO] [stdout] 160 | self.visit_member(other_member, visited, visiting, order)?; [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/build/platforms/mod.rs:248:25 [INFO] [stdout] | [INFO] [stdout] 248 | let all_platforms = vec![ [INFO] [stdout] | _________________________^ [INFO] [stdout] 249 | | BuildTarget::Linux, [INFO] [stdout] 250 | | BuildTarget::Windows, [INFO] [stdout] 251 | | BuildTarget::Ohos, [INFO] [stdout] ... | [INFO] [stdout] 256 | | BuildTarget::Android, [INFO] [stdout] 257 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 248 ~ let all_platforms = [BuildTarget::Linux, [INFO] [stdout] 249 + BuildTarget::Windows, [INFO] [stdout] 250 + BuildTarget::Ohos, [INFO] [stdout] 251 + BuildTarget::Ios, [INFO] [stdout] 252 + BuildTarget::Macos, [INFO] [stdout] 253 + BuildTarget::Tvos, [INFO] [stdout] 254 + BuildTarget::Watchos, [INFO] [stdout] 255 ~ BuildTarget::Android]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/build/platforms/mod.rs:542:21 [INFO] [stdout] | [INFO] [stdout] 542 | let platforms = vec![ [INFO] [stdout] | _____________________^ [INFO] [stdout] 543 | | BuildTarget::Ios, [INFO] [stdout] 544 | | BuildTarget::Macos, [INFO] [stdout] 545 | | BuildTarget::Tvos, [INFO] [stdout] 546 | | BuildTarget::Watchos, [INFO] [stdout] 547 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 542 ~ let platforms = [BuildTarget::Ios, [INFO] [stdout] 543 + BuildTarget::Macos, [INFO] [stdout] 544 + BuildTarget::Tvos, [INFO] [stdout] 545 ~ BuildTarget::Watchos]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 52.97s [INFO] running `Command { std: "docker" "inspect" "cbfbeec5dae348991a457dda636db0510be715f73661053f9ffee367644529bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbfbeec5dae348991a457dda636db0510be715f73661053f9ffee367644529bc", kill_on_drop: false }` [INFO] [stdout] cbfbeec5dae348991a457dda636db0510be715f73661053f9ffee367644529bc