[INFO] fetching crate casperlabs-ownable 0.2.0... [INFO] linting casperlabs-ownable-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate casperlabs-ownable 0.2.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate casperlabs-ownable 0.2.0 [INFO] finished tweaking crates.io crate casperlabs-ownable 0.2.0 [INFO] tweaked toml for crates.io crate casperlabs-ownable 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate casperlabs-ownable 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding casper-contract v1.4.4 (available: v5.1.1) [INFO] [stderr] Adding casper-types v1.5.0 (available: v7.0.0) [INFO] [stderr] Adding cryptoxide v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding ed25519 v1.2.0 (available: v1.5.3) [INFO] [stderr] Adding signature v1.2.2 (available: v1.6.4) [INFO] [stderr] Adding subtle v2.4.1 (available: v2.6.1) [INFO] [stderr] Adding zeroize v1.3.0 (available: v1.8.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded casperlabs-contract-utils v0.2.2 [INFO] [stderr] Downloaded casper_types_derive v0.1.0 [INFO] [stderr] Downloaded quote v1.0.45 [INFO] [stderr] Downloaded ecdsa v0.10.2 [INFO] [stderr] Downloaded signature v1.2.2 [INFO] [stderr] Downloaded rand_chacha v0.2.2 [INFO] [stderr] Downloaded zeroize v1.3.0 [INFO] [stderr] Downloaded funty v1.1.0 [INFO] [stderr] Downloaded wee_alloc v0.4.5 [INFO] [stderr] Downloaded digest v0.9.0 [INFO] [stderr] Downloaded crunchy v0.2.4 [INFO] [stderr] Downloaded cfg-if v0.1.10 [INFO] [stderr] Downloaded zeroize_derive v1.4.3 [INFO] [stderr] Downloaded crypto-mac v0.8.0 [INFO] [stderr] Downloaded hex_fmt v0.3.0 [INFO] [stderr] Downloaded wyz v0.2.0 [INFO] [stderr] Downloaded block-buffer v0.9.0 [INFO] [stderr] Downloaded crypto-mac v0.10.1 [INFO] [stderr] Downloaded hmac v0.10.1 [INFO] [stderr] Downloaded ff v0.8.0 [INFO] [stderr] Downloaded base16 v0.2.1 [INFO] [stderr] Downloaded radium v0.3.0 [INFO] [stderr] Downloaded group v0.8.0 [INFO] [stderr] Downloaded subtle v2.4.1 [INFO] [stderr] Downloaded num-derive v0.3.3 [INFO] [stderr] Downloaded ed25519 v1.2.0 [INFO] [stderr] Downloaded opaque-debug v0.3.1 [INFO] [stderr] Downloaded num-iter v0.1.45 [INFO] [stderr] Downloaded uint v0.9.5 [INFO] [stderr] Downloaded rand_hc v0.2.0 [INFO] [stderr] Downloaded itoa v1.0.17 [INFO] [stderr] Downloaded memory_units v0.4.0 [INFO] [stderr] Downloaded num-complex v0.4.6 [INFO] [stderr] Downloaded bitflags v1.3.2 [INFO] [stderr] Downloaded generic-array v0.14.9 [INFO] [stderr] Downloaded casper-contract v1.4.4 [INFO] [stderr] Downloaded num-rational v0.4.2 [INFO] [stderr] Downloaded elliptic-curve v0.8.5 [INFO] [stderr] Downloaded num v0.4.3 [INFO] [stderr] Downloaded once_cell v1.21.4 [INFO] [stderr] Downloaded proc-macro2 v1.0.106 [INFO] [stderr] Downloaded zmij v1.0.21 [INFO] [stderr] Downloaded blake2 v0.9.2 [INFO] [stderr] Downloaded static_assertions v1.1.0 [INFO] [stderr] Downloaded serde_bytes v0.11.19 [INFO] [stderr] Downloaded sha2 v0.9.9 [INFO] [stderr] Downloaded k256 v0.7.3 [INFO] [stderr] Downloaded ed25519-dalek v1.0.1 [INFO] [stderr] Downloaded unicode-ident v1.0.24 [INFO] [stderr] Downloaded rand_core v0.5.1 [INFO] [stderr] Downloaded base64 v0.13.1 [INFO] [stderr] Downloaded zerocopy-derive v0.8.42 [INFO] [stderr] Downloaded rand v0.7.3 [INFO] [stderr] Downloaded num-bigint v0.4.6 [INFO] [stderr] Downloaded memchr v2.8.0 [INFO] [stderr] Downloaded casper-types v1.5.0 [INFO] [stderr] Downloaded bitvec v0.18.5 [INFO] [stderr] Downloaded serde_json v1.0.149 [INFO] [stderr] Downloaded cryptoxide v0.3.6 [INFO] [stderr] Downloaded zerocopy v0.8.42 [INFO] [stderr] Downloaded syn v2.0.117 [INFO] [stderr] Downloaded curve25519-dalek v3.2.1 [INFO] [stderr] Downloaded libc v0.2.183 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54acc2185797f62b29b3c12eee935983eb5d8d2e3adcc03980d2f0f38f3fade2 [INFO] running `Command { std: "docker" "start" "-a" "54acc2185797f62b29b3c12eee935983eb5d8d2e3adcc03980d2f0f38f3fade2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54acc2185797f62b29b3c12eee935983eb5d8d2e3adcc03980d2f0f38f3fade2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54acc2185797f62b29b3c12eee935983eb5d8d2e3adcc03980d2f0f38f3fade2", kill_on_drop: false }` [INFO] [stdout] 54acc2185797f62b29b3c12eee935983eb5d8d2e3adcc03980d2f0f38f3fade2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc01d0d8aef829d43264a59d3be5c2792df4eed3912a1b41072d5f9b6f41e4f1 [INFO] running `Command { std: "docker" "start" "-a" "dc01d0d8aef829d43264a59d3be5c2792df4eed3912a1b41072d5f9b6f41e4f1", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking radium v0.3.0 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Compiling wee_alloc v0.4.5 [INFO] [stderr] Checking bitvec v0.18.5 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking base16 v0.2.1 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Checking memory_units v0.4.0 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking cryptoxide v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.10.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking signature v1.2.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking ed25519 v1.2.0 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling casper_types_derive v0.1.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking ff v0.8.0 [INFO] [stderr] Checking group v0.8.0 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking elliptic-curve v0.8.5 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking ecdsa v0.10.2 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking k256 v0.7.3 [INFO] [stderr] Checking casper-types v1.5.0 [INFO] [stderr] Checking casper-contract v1.4.4 [INFO] [stderr] Checking casperlabs-contract-utils v0.2.2 [INFO] [stderr] Checking casperlabs-ownable v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ownable.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | new_owner: new_owner, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_owner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/data.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | "hash-0000000000000000000000000000000000000000000000000000000000000000".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"hash-0000000000000000000000000000000000000000000000000000000000000000"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ownable.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return data::get_owner(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return data::get_owner(); [INFO] [stdout] 52 + data::get_owner() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ownable.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self.get_caller() == data::get_owner(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self.get_caller() == data::get_owner(); [INFO] [stdout] 62 + self.get_caller() == data::get_owner() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ownable.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if !(new_owner != data::zero_address()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(new_owner == data::zero_address())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ownable.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | new_owner: new_owner, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_owner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/data.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | "hash-0000000000000000000000000000000000000000000000000000000000000000".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"hash-0000000000000000000000000000000000000000000000000000000000000000"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ownable.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return data::get_owner(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return data::get_owner(); [INFO] [stdout] 52 + data::get_owner() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ownable.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self.get_caller() == data::get_owner(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self.get_caller() == data::get_owner(); [INFO] [stdout] 62 + self.get_caller() == data::get_owner() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ownable.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if !(new_owner != data::zero_address()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(new_owner == data::zero_address())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.66s [INFO] running `Command { std: "docker" "inspect" "dc01d0d8aef829d43264a59d3be5c2792df4eed3912a1b41072d5f9b6f41e4f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc01d0d8aef829d43264a59d3be5c2792df4eed3912a1b41072d5f9b6f41e4f1", kill_on_drop: false }` [INFO] [stdout] dc01d0d8aef829d43264a59d3be5c2792df4eed3912a1b41072d5f9b6f41e4f1